Re: svn commit: r340676 - in head/sys: kern sys

2018-11-28 Thread Mateusz Guzik
On 11/26/18, John Baldwin wrote: > On 11/22/18 9:28 AM, Mateusz Guzik wrote: >> diff --git a/sys/sys/systm.h b/sys/sys/systm.h >> index a1b98c5660c..fab94ee7979 100644 >> --- a/sys/sys/systm.h >> +++ b/sys/sys/systm.h >> @@ -523,7 +523,11 @@ int alloc_unr_specific(struct unrhdr *uh, u_int >>

Re: svn commit: r340676 - in head/sys: kern sys

2018-11-26 Thread John Baldwin
On 11/22/18 9:28 AM, Mateusz Guzik wrote: > diff --git a/sys/sys/systm.h b/sys/sys/systm.h > index a1b98c5660c..fab94ee7979 100644 > --- a/sys/sys/systm.h > +++ b/sys/sys/systm.h > @@ -523,7 +523,11 @@ int alloc_unr_specific(struct unrhdr *uh, u_int item); > int alloc_unrl(struct unrhdr *uh); >

Re: svn commit: r340676 - in head/sys: kern sys

2018-11-22 Thread Warner Losh
On Thu, Nov 22, 2018 at 10:28 AM Mateusz Guzik wrote: > On 11/20/18, Warner Losh wrote: > > On Tue, Nov 20, 2018 at 8:28 AM Mateusz Guzik wrote: > > > >> On 11/20/18, Konstantin Belousov wrote: > >> >> +#if defined(__mips__) || defined(__powerpc__) > >> > Please note what I asked about this

Re: svn commit: r340676 - in head/sys: kern sys

2018-11-22 Thread Mateusz Guzik
On 11/20/18, Warner Losh wrote: > On Tue, Nov 20, 2018 at 8:28 AM Mateusz Guzik wrote: > >> On 11/20/18, Konstantin Belousov wrote: >> >> +#if defined(__mips__) || defined(__powerpc__) >> > Please note what I asked about this #ifdefs in the review. mips >> > and powerpc machine/atomic.h should

Re: svn commit: r340676 - in head/sys: kern sys

2018-11-20 Thread Mark Millard via svn-src-head
Mateusz Guzik mjg at FreeBSD.org wrote on Tue Nov 20 14:58:42 UTC 2018 : > +#if defined(__mips__) || defined(__powerpc__) > +#define UNR64_LOCKED > +#endif But on powerpc64 ( system clang from head -r339076 ): # clang -dM -E -x c /dev/null | grep -i __power #define __POWERPC__ 1 #define

Re: svn commit: r340676 - in head/sys: kern sys

2018-11-20 Thread Warner Losh
On Tue, Nov 20, 2018 at 8:28 AM Mateusz Guzik wrote: > On 11/20/18, Konstantin Belousov wrote: > > On Tue, Nov 20, 2018 at 02:58:41PM +, Mateusz Guzik wrote: > >> Author: mjg > >> Date: Tue Nov 20 14:58:41 2018 > >> New Revision: 340676 > >> URL:

Re: svn commit: r340676 - in head/sys: kern sys

2018-11-20 Thread Mateusz Guzik
On 11/20/18, Konstantin Belousov wrote: > On Tue, Nov 20, 2018 at 02:58:41PM +, Mateusz Guzik wrote: >> Author: mjg >> Date: Tue Nov 20 14:58:41 2018 >> New Revision: 340676 >> URL: https://svnweb.freebsd.org/changeset/base/340676 >> >> Log: >> Implement unr64 >> >> Important users of unr

Re: svn commit: r340676 - in head/sys: kern sys

2018-11-20 Thread Konstantin Belousov
On Tue, Nov 20, 2018 at 02:58:41PM +, Mateusz Guzik wrote: > Author: mjg > Date: Tue Nov 20 14:58:41 2018 > New Revision: 340676 > URL: https://svnweb.freebsd.org/changeset/base/340676 > > Log: > Implement unr64 > > Important users of unr like tmpfs or pipes can get away with just >

svn commit: r340676 - in head/sys: kern sys

2018-11-20 Thread Mateusz Guzik
Author: mjg Date: Tue Nov 20 14:58:41 2018 New Revision: 340676 URL: https://svnweb.freebsd.org/changeset/base/340676 Log: Implement unr64 Important users of unr like tmpfs or pipes can get away with just ever-increasing counters, making the overhead of managing the state for 32 bit