Re: svn commit: r343349 - head/sys/dev/ocs_fc

2019-01-25 Thread Rodney W. Grimes
> On Fri, Jan 25, 2019 at 7:44 AM Rodney W. Grimes > wrote: > > > > > Hi Rodney, > > > > > > I fixed many coverity tool warnings as part of this commit. Adding all the > > > warnings and fix details seemed over kill. > > > > It seems like overkill when your commiting, but if you have > > have to

Re: svn commit: r343349 - head/sys/dev/ocs_fc

2019-01-25 Thread Kyle Evans
On Fri, Jan 25, 2019 at 7:44 AM Rodney W. Grimes wrote: > > > Hi Rodney, > > > > I fixed many coverity tool warnings as part of this commit. Adding all the > > warnings and fix details seemed over kill. > > It seems like overkill when your commiting, but if you have > have to go digging through

Re: svn commit: r343349 - head/sys/dev/ocs_fc

2019-01-25 Thread Rodney W. Grimes
> Hi Rodney, > > I fixed many coverity tool warnings as part of this commit. Adding all the > warnings and fix details seemed over kill. It seems like overkill when your commiting, but if you have have to go digging through commit history trying to find something it helps a great deal to have

Re: svn commit: r343349 - head/sys/dev/ocs_fc

2019-01-25 Thread Ram Kishore Vegesna via svn-src-head
Hi Rodney, I fixed many coverity tool warnings as part of this commit. Adding all the warnings and fix details seemed over kill. I will use a better commit message when I do MFC commit of this revision. Thanks, Ram On Thu, Jan 24, 2019 at 12:28 AM Rodney W. Grimes <

Re: svn commit: r343349 - head/sys/dev/ocs_fc

2019-01-23 Thread Rodney W. Grimes
> Author: ram > Date: Wed Jan 23 17:34:01 2019 > New Revision: 343349 > URL: https://svnweb.freebsd.org/changeset/base/343349 > > Log: > Fixed issues reported by coverity scan. The quality of this commit message is rather low, it should of at least included some details about what was wrong,

svn commit: r343349 - head/sys/dev/ocs_fc

2019-01-23 Thread Ram Kishore Vegesna
Author: ram Date: Wed Jan 23 17:34:01 2019 New Revision: 343349 URL: https://svnweb.freebsd.org/changeset/base/343349 Log: Fixed issues reported by coverity scan. Approved by: mav MFC after: 3 weeks Modified: head/sys/dev/ocs_fc/ocs_cam.c head/sys/dev/ocs_fc/ocs_hw.c