On Sun, Jan 27, 2019 at 7:09 AM Devin Teske wrote:
>
>
> > On Jan 26, 2019, at 9:31 PM, Bruce Evans wrote:
> >
> > On Sat, 26 Jan 2019, Stefan Esser wrote:
> >
> >> Am 26.01.19 um 22:59 schrieb Colin Percival:
> >>> ...
> >>> The length of the string was already being recalculated, by strcpy.
>
> On Jan 26, 2019, at 9:31 PM, Bruce Evans wrote:
>
> On Sat, 26 Jan 2019, Stefan Esser wrote:
>
>> Am 26.01.19 um 22:59 schrieb Colin Percival:
>>> ...
>>> The length of the string was already being recalculated, by strcpy.
>>>
>>> It seems to me that this could be written as
>>>
>>>
On Sat, 26 Jan 2019, Stefan Esser wrote:
Am 26.01.19 um 22:59 schrieb Colin Percival:
...
The length of the string was already being recalculated, by strcpy.
It seems to me that this could be written as
temp = malloc(slen + 1);
if (temp == NULL) /* could not allocate memory
> On 26 Jan 2019, at 1:59 PM, Colin Percival wrote:
>
> On 1/26/19 1:36 PM, Rodney W. Grimes wrote:
>>> Author: se
>>> Date: Sat Jan 26 21:30:26 2019
>>> New Revision: 343480
>>> URL: https://svnweb.freebsd.org/changeset/base/343480
>>>
>>> Log:
>>> Silence Clang Scan warning about
Am 26.01.19 um 22:59 schrieb Colin Percival:
> On 1/26/19 1:36 PM, Rodney W. Grimes wrote:
>>> Author: se
>>> Date: Sat Jan 26 21:30:26 2019
>>> New Revision: 343480
>>> URL: https://svnweb.freebsd.org/changeset/base/343480
>>>
>>> Log:
>>> Silence Clang Scan warning about potentially unsafe use
On 1/26/19 1:36 PM, Rodney W. Grimes wrote:
>> Author: se
>> Date: Sat Jan 26 21:30:26 2019
>> New Revision: 343480
>> URL: https://svnweb.freebsd.org/changeset/base/343480
>>
>> Log:
>> Silence Clang Scan warning about potentially unsafe use of strcpy.
>>
>> While this is a false positive,
> Author: se
> Date: Sat Jan 26 21:30:26 2019
> New Revision: 343480
> URL: https://svnweb.freebsd.org/changeset/base/343480
>
> Log:
> Silence Clang Scan warning about potentially unsafe use of strcpy.
>
> While this is a false positive, the use of strdup() simplifies the code.
Though
Author: se
Date: Sat Jan 26 21:30:26 2019
New Revision: 343480
URL: https://svnweb.freebsd.org/changeset/base/343480
Log:
Silence Clang Scan warning about potentially unsafe use of strcpy.
While this is a false positive, the use of strdup() simplifies the code.
MFC after:2 weeks
