Re: svn commit: r343896 - head/sbin/dhclient

2019-02-08 Thread Konstantin Belousov
On Fri, Feb 08, 2019 at 02:23:01PM +0100, Jilles Tjoelker wrote: > On Fri, Feb 08, 2019 at 07:36:08AM +, Konstantin Belousov wrote: > > Author: kib > > Date: Fri Feb 8 07:36:08 2019 > > New Revision: 343896 > > URL: https://svnweb.freebsd.org/changeset/base/343896 > > > Log: > > Correctly

Re: svn commit: r343896 - head/sbin/dhclient

2019-02-08 Thread Nash Kaminski
I would be in favor of Jilles' implementation as well, since fundamentally dhclient just tests for zero/nonzero exit status and therefore what is critical is making sure such status is nonzero in *any* failure case of dhclient-script, including abnormal termination via signal. - Nash On Fri, Feb

Re: svn commit: r343896 - head/sbin/dhclient

2019-02-08 Thread Jilles Tjoelker
On Fri, Feb 08, 2019 at 07:36:08AM +, Konstantin Belousov wrote: > Author: kib > Date: Fri Feb 8 07:36:08 2019 > New Revision: 343896 > URL: https://svnweb.freebsd.org/changeset/base/343896 > Log: > Correctly return exit status from the exited process. > This is also OpenBSD rev. 1.117,

svn commit: r343896 - head/sbin/dhclient

2019-02-07 Thread Konstantin Belousov
Author: kib Date: Fri Feb 8 07:36:08 2019 New Revision: 343896 URL: https://svnweb.freebsd.org/changeset/base/343896 Log: Correctly return exit status from the exited process. This is also OpenBSD rev. 1.117, as pointed out by Ryan Moeller . Submitted by: Nash Kaminski MFC