Author: pkelsey
Date: Fri Feb  8 20:34:47 2019
New Revision: 343919
URL: https://svnweb.freebsd.org/changeset/base/343919

Log:
  Fix em(4) interrupt routing
  
  When configured with more tx queues than rx queues,
  em_if_msix_intr_assign() was incorrectly routing the tx event
  interrupts.
  
  Reviewed by:  erj, marius
  MFC after:    1 week
  Differential Revision:        https://reviews.freebsd.org/D19070

Modified:
  head/sys/dev/e1000/if_em.c

Modified: head/sys/dev/e1000/if_em.c
==============================================================================
--- head/sys/dev/e1000/if_em.c  Fri Feb  8 19:19:31 2019        (r343918)
+++ head/sys/dev/e1000/if_em.c  Fri Feb  8 20:34:47 2019        (r343919)
@@ -1996,7 +1996,7 @@ em_if_msix_intr_assign(if_ctx_t ctx, int msix)
                    &adapter->rx_queues[i % adapter->rx_num_queues].que_irq,
                    IFLIB_INTR_TX, tx_que, tx_que->me, buf);
 
-               tx_que->msix = (vector % adapter->tx_num_queues);
+               tx_que->msix = (vector % adapter->rx_num_queues);
 
                /*
                 * Set the bit to enable interrupt
@@ -2009,9 +2009,9 @@ em_if_msix_intr_assign(if_ctx_t ctx, int msix)
                        adapter->ims |= tx_que->eims;
                        adapter->ivars |= (8 | tx_que->msix) << (8 + (i * 4));
                } else if (adapter->hw.mac.type == e1000_82575) {
-                       tx_que->eims = E1000_EICR_TX_QUEUE0 << (i %  
adapter->tx_num_queues);
+                       tx_que->eims = E1000_EICR_TX_QUEUE0 << i;
                } else {
-                       tx_que->eims = 1 << (i %  adapter->tx_num_queues);
+                       tx_que->eims = 1 << i;
                }
        }
 
_______________________________________________
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Reply via email to