Re: svn commit: r345900 - head/sbin/fsck_msdosfs

2019-09-03 Thread Hans Petter Selasky
On 4/5/19 9:51 PM, Conrad Meyer wrote: static const u_char dot_name[11] = ". "; static const u_char dotdot_name[11] = ".. "; Seems more clear to me. Using this syntax will include a terminating zero. --HPS ___ svn-src-head@freebsd

Re: svn commit: r345900 - head/sbin/fsck_msdosfs

2019-09-03 Thread Rodney W. Grimes
> On Fri, Apr 5, 2019 at 6:49 AM Ed Maste wrote: > > > > On Fri, 5 Apr 2019 at 00:49, Rodney W. Grimes > > wrote: > > > > > > > > > +static const u_char dot_name[] = { > > > > + '.', ' ',' ',' ',' ',' ',' ',' ',' ',' ',' ' }; > > > > +static const u_char dotdot_name[] = { > > > > + '.',

Re: svn commit: r345900 - head/sbin/fsck_msdosfs

2019-09-03 Thread Conrad Meyer
On Fri, Apr 5, 2019 at 6:49 AM Ed Maste wrote: > > On Fri, 5 Apr 2019 at 00:49, Rodney W. Grimes > wrote: > > > > > > +static const u_char dot_name[] = { > > > + '.', ' ',' ',' ',' ',' ',' ',' ',' ',' ',' ' }; > > > +static const u_char dotdot_name[] = { > > > + '.', '.',' ',' ',' ',' ',

Re: svn commit: r345900 - head/sbin/fsck_msdosfs

2019-09-03 Thread Ian Lepore
On Sat, 2019-04-06 at 01:47 +1100, Bruce Evans wrote: > On Fri, 5 Apr 2019, Ed Maste wrote: > > > On Fri, 5 Apr 2019 at 00:49, Rodney W. Grimes > > wrote: > >> > > > >>> +static const u_char dot_name[] = { > >>> + '.', ' ',' ',' ',' ',' ',' ',' ',' ',' ',' ' }; > >>> +static const u_char dot

Re: svn commit: r345900 - head/sbin/fsck_msdosfs

2019-09-03 Thread Enji Cooper
On Apr 5, 2019, at 13:22, Rodney W. Grimes wrote: >>> On Fri, Apr 5, 2019 at 6:49 AM Ed Maste wrote: >>> On Fri, 5 Apr 2019 at 00:49, Rodney W. Grimes wrote: >>> > +static const u_char dot_name[] = { > + '.', ' ',' ',' ',' ',' ',' ',' ',' ',' ',' ' }; > +stati

Re: svn commit: r345900 - head/sbin/fsck_msdosfs

2019-09-03 Thread Rodney W. Grimes
> On Apr 5, 2019, at 13:22, Rodney W. Grimes wrote: > > >>> On Fri, Apr 5, 2019 at 6:49 AM Ed Maste wrote: > >>> > On Fri, 5 Apr 2019 at 00:49, Rodney W. Grimes > wrote: > > >>> > > +static const u_char dot_name[] = { > > + '.', ' ',' ',' ',' ',' ',' ',' ',' ',' '

Re: svn commit: r345900 - head/sbin/fsck_msdosfs

2019-09-03 Thread Xin LI
On Fri, Apr 5, 2019 at 12:56 PM Hans Petter Selasky wrote: > On 4/5/19 9:51 PM, Conrad Meyer wrote: > > static const u_char dot_name[11] = ". "; > > static const u_char dotdot_name[11] = ".. "; > > > > Seems more clear to me. > > Using this syntax will include a terminating zero.

Re: svn commit: r345900 - head/sbin/fsck_msdosfs

2019-09-03 Thread Conrad Meyer
On Fri, Apr 5, 2019 at 12:56 PM Hans Petter Selasky wrote: > > On 4/5/19 9:51 PM, Conrad Meyer wrote: > > static const u_char dot_name[11] = ". "; > > static const u_char dotdot_name[11] = ".. "; > > > > Seems more clear to me. > > Using this syntax will include a terminating zero

Re: svn commit: r345900 - head/sbin/fsck_msdosfs

2019-09-03 Thread Konstantin Belousov
On Fri, Apr 05, 2019 at 09:55:43PM +0200, Hans Petter Selasky wrote: > On 4/5/19 9:51 PM, Conrad Meyer wrote: > > static const u_char dot_name[11] = ". "; > > static const u_char dotdot_name[11] = ".. "; > > > > Seems more clear to me. > > Using this syntax will include a termina

Re: svn commit: r345900 - head/sbin/fsck_msdosfs

2019-09-03 Thread Bruce Evans
On Fri, 5 Apr 2019, Ed Maste wrote: On Fri, 5 Apr 2019 at 00:49, Rodney W. Grimes wrote: +static const u_char dot_name[] = { + '.', ' ',' ',' ',' ',' ',' ',' ',' ',' ',' ' }; +static const u_char dotdot_name[] = { + '.', '.',' ',' ',' ',' ',' ',' ',' ',' ',' ' }; + Does it make s

Re: svn commit: r345900 - head/sbin/fsck_msdosfs

2019-09-03 Thread Rodney W. Grimes
> On Fri, 5 Apr 2019, Ed Maste wrote: > > > On Fri, 5 Apr 2019 at 00:49, Rodney W. Grimes > > wrote: > >> > > > >>> +static const u_char dot_name[] = { > >>> + '.', ' ',' ',' ',' ',' ',' ',' ',' ',' ',' ' }; > >>> +static const u_char dotdot_name[] = { > >>> + '.', '.',' ',' ',' ',' ','

Re: svn commit: r345900 - head/sbin/fsck_msdosfs

2019-09-03 Thread Rodney W. Grimes
> Author: delphij > Date: Fri Apr 5 02:21:16 2019 > New Revision: 345900 > URL: https://svnweb.freebsd.org/changeset/base/345900 > > Log: > Implement checking of `.' and `..' entries of subdirectory. > > Reviewed by:pfg > Obtained from: Android > https://and

Re: svn commit: r345900 - head/sbin/fsck_msdosfs

2019-09-03 Thread Ed Maste
On Fri, 5 Apr 2019 at 00:49, Rodney W. Grimes wrote: > > > +static const u_char dot_name[] = { > > + '.', ' ',' ',' ',' ',' ',' ',' ',' ',' ',' ' }; > > +static const u_char dotdot_name[] = { > > + '.', '.',' ',' ',' ',' ',' ',' ',' ',' ',' ' }; > > + > > Does it make since to encode thes

svn commit: r345900 - head/sbin/fsck_msdosfs

2019-09-03 Thread Xin LI
Author: delphij Date: Fri Apr 5 02:21:16 2019 New Revision: 345900 URL: https://svnweb.freebsd.org/changeset/base/345900 Log: Implement checking of `.' and `..' entries of subdirectory. Reviewed by: pfg Obtained from:Android https://android.googlesource.com/plat

Re: svn commit: r345900 - head/sbin/fsck_msdosfs

2019-04-05 Thread Conrad Meyer
On Fri, Apr 5, 2019 at 12:56 PM Hans Petter Selasky wrote: > > On 4/5/19 9:51 PM, Conrad Meyer wrote: > > static const u_char dot_name[11] = ". "; > > static const u_char dotdot_name[11] = ".. "; > > > > Seems more clear to me. > > Using this syntax will include a terminating zero

Re: svn commit: r345900 - head/sbin/fsck_msdosfs

2019-04-05 Thread Rodney W. Grimes
> On Apr 5, 2019, at 13:22, Rodney W. Grimes wrote: > > >>> On Fri, Apr 5, 2019 at 6:49 AM Ed Maste wrote: > >>> > On Fri, 5 Apr 2019 at 00:49, Rodney W. Grimes > wrote: > > >>> > > +static const u_char dot_name[] = { > > + '.', ' ',' ',' ',' ',' ',' ',' ',' ',' '

Re: svn commit: r345900 - head/sbin/fsck_msdosfs

2019-04-05 Thread Enji Cooper
On Apr 5, 2019, at 13:22, Rodney W. Grimes wrote: >>> On Fri, Apr 5, 2019 at 6:49 AM Ed Maste wrote: >>> On Fri, 5 Apr 2019 at 00:49, Rodney W. Grimes wrote: >>> > +static const u_char dot_name[] = { > + '.', ' ',' ',' ',' ',' ',' ',' ',' ',' ',' ' }; > +stati

Re: svn commit: r345900 - head/sbin/fsck_msdosfs

2019-04-05 Thread Konstantin Belousov
On Fri, Apr 05, 2019 at 09:55:43PM +0200, Hans Petter Selasky wrote: > On 4/5/19 9:51 PM, Conrad Meyer wrote: > > static const u_char dot_name[11] = ". "; > > static const u_char dotdot_name[11] = ".. "; > > > > Seems more clear to me. > > Using this syntax will include a termina

Re: svn commit: r345900 - head/sbin/fsck_msdosfs

2019-04-05 Thread Rodney W. Grimes
> On Fri, Apr 5, 2019 at 6:49 AM Ed Maste wrote: > > > > On Fri, 5 Apr 2019 at 00:49, Rodney W. Grimes > > wrote: > > > > > > > > > +static const u_char dot_name[] = { > > > > + '.', ' ',' ',' ',' ',' ',' ',' ',' ',' ',' ' }; > > > > +static const u_char dotdot_name[] = { > > > > + '.',

Re: svn commit: r345900 - head/sbin/fsck_msdosfs

2019-04-05 Thread Xin LI
On Fri, Apr 5, 2019 at 12:56 PM Hans Petter Selasky wrote: > On 4/5/19 9:51 PM, Conrad Meyer wrote: > > static const u_char dot_name[11] = ". "; > > static const u_char dotdot_name[11] = ".. "; > > > > Seems more clear to me. > > Using this syntax will include a terminating zero.

Re: svn commit: r345900 - head/sbin/fsck_msdosfs

2019-04-05 Thread Hans Petter Selasky
On 4/5/19 9:51 PM, Conrad Meyer wrote: static const u_char dot_name[11] = ". "; static const u_char dotdot_name[11] = ".. "; Seems more clear to me. Using this syntax will include a terminating zero. --HPS ___ svn-src-head@freebsd.o

Re: svn commit: r345900 - head/sbin/fsck_msdosfs

2019-04-05 Thread Conrad Meyer
On Fri, Apr 5, 2019 at 6:49 AM Ed Maste wrote: > > On Fri, 5 Apr 2019 at 00:49, Rodney W. Grimes > wrote: > > > > > > +static const u_char dot_name[] = { > > > + '.', ' ',' ',' ',' ',' ',' ',' ',' ',' ',' ' }; > > > +static const u_char dotdot_name[] = { > > > + '.', '.',' ',' ',' ',' ',

Re: svn commit: r345900 - head/sbin/fsck_msdosfs

2019-04-05 Thread Ian Lepore
On Sat, 2019-04-06 at 01:47 +1100, Bruce Evans wrote: > On Fri, 5 Apr 2019, Ed Maste wrote: > > > On Fri, 5 Apr 2019 at 00:49, Rodney W. Grimes > > wrote: > >> > > > >>> +static const u_char dot_name[] = { > >>> + '.', ' ',' ',' ',' ',' ',' ',' ',' ',' ',' ' }; > >>> +static const u_char dot

Re: svn commit: r345900 - head/sbin/fsck_msdosfs

2019-04-05 Thread Rodney W. Grimes
> On Fri, 5 Apr 2019, Ed Maste wrote: > > > On Fri, 5 Apr 2019 at 00:49, Rodney W. Grimes > > wrote: > >> > > > >>> +static const u_char dot_name[] = { > >>> + '.', ' ',' ',' ',' ',' ',' ',' ',' ',' ',' ' }; > >>> +static const u_char dotdot_name[] = { > >>> + '.', '.',' ',' ',' ',' ','

Re: svn commit: r345900 - head/sbin/fsck_msdosfs

2019-04-05 Thread Bruce Evans
On Fri, 5 Apr 2019, Ed Maste wrote: On Fri, 5 Apr 2019 at 00:49, Rodney W. Grimes wrote: +static const u_char dot_name[] = { + '.', ' ',' ',' ',' ',' ',' ',' ',' ',' ',' ' }; +static const u_char dotdot_name[] = { + '.', '.',' ',' ',' ',' ',' ',' ',' ',' ',' ' }; + Does it make s

Re: svn commit: r345900 - head/sbin/fsck_msdosfs

2019-04-05 Thread Ed Maste
On Fri, 5 Apr 2019 at 00:49, Rodney W. Grimes wrote: > > > +static const u_char dot_name[] = { > > + '.', ' ',' ',' ',' ',' ',' ',' ',' ',' ',' ' }; > > +static const u_char dotdot_name[] = { > > + '.', '.',' ',' ',' ',' ',' ',' ',' ',' ',' ' }; > > + > > Does it make since to encode thes

Re: svn commit: r345900 - head/sbin/fsck_msdosfs

2019-04-04 Thread Rodney W. Grimes
> Author: delphij > Date: Fri Apr 5 02:21:16 2019 > New Revision: 345900 > URL: https://svnweb.freebsd.org/changeset/base/345900 > > Log: > Implement checking of `.' and `..' entries of subdirectory. > > Reviewed by:pfg > Obtained from: Android > https://and

svn commit: r345900 - head/sbin/fsck_msdosfs

2019-04-04 Thread Xin LI
Author: delphij Date: Fri Apr 5 02:21:16 2019 New Revision: 345900 URL: https://svnweb.freebsd.org/changeset/base/345900 Log: Implement checking of `.' and `..' entries of subdirectory. Reviewed by: pfg Obtained from:Android https://android.googlesource.com/plat