Re: svn commit: r351364 - in head/sys: crypto/blowfish crypto/chacha20 crypto/des opencrypto

2019-08-24 Thread Mark Millard via svn-src-head
Warner Losh imp at bsdimp.com wrote on Fri Aug 23 22:05:39 UTC 2019 : > On Fri, Aug 23, 2019 at 12:26 PM Conrad Meyer wrote: > > > At expected peril of wading into a thread >4 emails deep, > > > > @Warner, modern GCC reports a similar warning; it just doesn't become > > an error (at least in

Re: svn commit: r351364 - in head/sys: crypto/blowfish crypto/chacha20 crypto/des opencrypto

2019-08-23 Thread Warner Losh
On Fri, Aug 23, 2019 at 12:26 PM Conrad Meyer wrote: > At expected peril of wading into a thread >4 emails deep, > > @Warner, modern GCC reports a similar warning; it just doesn't become > an error (at least in CI?). I'm not sure of the mechanism. Maybe > CI-specific? Old GCC didn't have a

Re: svn commit: r351364 - in head/sys: crypto/blowfish crypto/chacha20 crypto/des opencrypto

2019-08-23 Thread Conrad Meyer
At expected peril of wading into a thread >4 emails deep, @Warner, modern GCC reports a similar warning; it just doesn't become an error (at least in CI?). I'm not sure of the mechanism. Maybe CI-specific? Old GCC didn't have a -Wno-error for -Wcast-qual, so -Wcast-qual + -Werror there

Re: svn commit: r351364 - in head/sys: crypto/blowfish crypto/chacha20 crypto/des opencrypto

2019-08-23 Thread Bjoern A. Zeeb
On 23 Aug 2019, at 16:48, Warner Losh wrote: On Fri, Aug 23, 2019 at 10:10 AM Bjoern A. Zeeb wrote: On 23 Aug 2019, at 15:53, Warner Losh wrote: Sorry for top posting... I had planned this for next week, but I think give this insanity of this patch, we should do it now: turn off -Werror

Re: svn commit: r351364 - in head/sys: crypto/blowfish crypto/chacha20 crypto/des opencrypto

2019-08-23 Thread Warner Losh
On Fri, Aug 23, 2019 at 10:10 AM Bjoern A. Zeeb wrote: > On 23 Aug 2019, at 15:53, Warner Losh wrote: > > > Sorry for top posting... > > > > I had planned this for next week, but I think give this insanity of > > this > > patch, we should do it now: turn off -Werror for gcc 4.2.1 > > > >

Re: svn commit: r351364 - in head/sys: crypto/blowfish crypto/chacha20 crypto/des opencrypto

2019-08-23 Thread Bjoern A. Zeeb
On 23 Aug 2019, at 15:53, Warner Losh wrote: Sorry for top posting... I had planned this for next week, but I think give this insanity of this patch, we should do it now: turn off -Werror for gcc 4.2.1 https://reviews.freebsd.org/D21378 has the review. There's no benefit to these

Re: svn commit: r351364 - in head/sys: crypto/blowfish crypto/chacha20 crypto/des opencrypto

2019-08-23 Thread Warner Losh
Sorry for top posting... I had planned this for next week, but I think give this insanity of this patch, we should do it now: turn off -Werror for gcc 4.2.1 https://reviews.freebsd.org/D21378 has the review. There's no benefit to these head-scratcher changes when we can get the same benefit by

Re: svn commit: r351364 - in head/sys: crypto/blowfish crypto/chacha20 crypto/des opencrypto

2019-08-22 Thread John Baldwin
On 8/22/19 2:39 AM, Bjoern A. Zeeb wrote: > On 22 Aug 2019, at 0:02, John Baldwin wrote: > > Hi, > >> Author: jhb >> Date: Thu Aug 22 00:02:08 2019 >> New Revision: 351364 >> URL: https://svnweb.freebsd.org/changeset/base/351364 >> >> Log: >> Use 'const' for keys and IVs passed to software

Re: svn commit: r351364 - in head/sys: crypto/blowfish crypto/chacha20 crypto/des opencrypto

2019-08-22 Thread Bjoern A. Zeeb
On 22 Aug 2019, at 0:02, John Baldwin wrote: Hi, Author: jhb Date: Thu Aug 22 00:02:08 2019 New Revision: 351364 URL: https://svnweb.freebsd.org/changeset/base/351364 Log: Use 'const' for keys and IVs passed to software encryption algorithms. Specifically, use 'const' for the key

svn commit: r351364 - in head/sys: crypto/blowfish crypto/chacha20 crypto/des opencrypto

2019-08-21 Thread John Baldwin
Author: jhb Date: Thu Aug 22 00:02:08 2019 New Revision: 351364 URL: https://svnweb.freebsd.org/changeset/base/351364 Log: Use 'const' for keys and IVs passed to software encryption algorithms. Specifically, use 'const' for the key passed to the 'setkey' method and 'const' for the 'iv'