Re: svn commit: r357004 - in head/sys: kern sys

2020-01-27 Thread Gleb Smirnoff
On Fri, Jan 24, 2020 at 12:23:33PM -0800, Cy Schubert wrote: C> > Let not the network epoch become the new Giant of EPOCH's. There might C> > be realtime constraints for EPOCH's aswell. C> C> I also had that concern yesterday. C> C> Obtaining an EPOCH higher up the call stack or lower down

Re: svn commit: r357004 - in head/sys: kern sys

2020-01-27 Thread Gleb Smirnoff
Hans, On Fri, Jan 24, 2020 at 08:21:54PM +0100, Hans Petter Selasky wrote: H> > If a driver has interrupt moderation than epoch batching counter H> > basically won't ever grow over 1. It kicks in only of driver doesn't H> > have it, or receives interrupts at a very high rate. H> H> Depending

Re: svn commit: r357004 - in head/sys: kern sys

2020-01-24 Thread Cy Schubert
In message <7d7db96d-26b1-1d2b-9f8d-a3f8fbe8c...@selasky.org>, Hans Petter Sela sky writes: > On 2020-01-24 18:05, Gleb Smirnoff wrote: > > On Fri, Jan 24, 2020 at 10:24:53AM +0100, Hans Petter Selasky wrote: > > H> What you want to do here is right, but how it is implemented is wrong, > > H> in

Re: svn commit: r357004 - in head/sys: kern sys

2020-01-24 Thread Hans Petter Selasky
On 2020-01-24 18:05, Gleb Smirnoff wrote: On Fri, Jan 24, 2020 at 10:24:53AM +0100, Hans Petter Selasky wrote: H> What you want to do here is right, but how it is implemented is wrong, H> in my opinion. H> H> 1) Remove intr_epoch_batch. Most network drivers use interrupt H> moderation, and a

Re: svn commit: r357004 - in head/sys: kern sys

2020-01-24 Thread Gleb Smirnoff
On Fri, Jan 24, 2020 at 10:24:53AM +0100, Hans Petter Selasky wrote: H> What you want to do here is right, but how it is implemented is wrong, H> in my opinion. H> H> 1) Remove intr_epoch_batch. Most network drivers use interrupt H> moderation, and a timeout of 1000 iterations can easily become

Re: svn commit: r357004 - in head/sys: kern sys

2020-01-24 Thread Hans Petter Selasky
On 2020-01-23 09:36, Hans Petter Selasky wrote: On 2020-01-23 02:24, Gleb Smirnoff wrote: Author: glebius Date: Thu Jan 23 01:24:47 2020 New Revision: 357004 URL: https://svnweb.freebsd.org/changeset/base/357004 Log:    Enter the network epoch for interrupt handlers of INTR_TYPE_NET.   

Re: svn commit: r357004 - in head/sys: kern sys

2020-01-24 Thread Hans Petter Selasky
On 2020-01-23 09:36, Hans Petter Selasky wrote: On 2020-01-23 02:24, Gleb Smirnoff wrote: Author: glebius Date: Thu Jan 23 01:24:47 2020 New Revision: 357004 URL: https://svnweb.freebsd.org/changeset/base/357004 Log:    Enter the network epoch for interrupt handlers of INTR_TYPE_NET.   

Re: svn commit: r357004 - in head/sys: kern sys

2020-01-23 Thread Hans Petter Selasky
On 2020-01-23 02:24, Gleb Smirnoff wrote: Author: glebius Date: Thu Jan 23 01:24:47 2020 New Revision: 357004 URL: https://svnweb.freebsd.org/changeset/base/357004 Log: Enter the network epoch for interrupt handlers of INTR_TYPE_NET. Provide tunable to limit how many times handlers

svn commit: r357004 - in head/sys: kern sys

2020-01-22 Thread Gleb Smirnoff
Author: glebius Date: Thu Jan 23 01:24:47 2020 New Revision: 357004 URL: https://svnweb.freebsd.org/changeset/base/357004 Log: Enter the network epoch for interrupt handlers of INTR_TYPE_NET. Provide tunable to limit how many times handlers may be executed without reentering epoch.