Re: svn commit: r362829 - head/sys/compat/linuxkpi/common/src

2020-07-01 Thread Konstantin Belousov
On Wed, Jul 01, 2020 at 12:56:12PM +0200, Hans Petter Selasky wrote: > On 2020-07-01 12:30, Konstantin Belousov wrote: > > I see no point in repeating the same pfind/tdfind calls, better to convert > > them to pget(), and have this code in one intended place. > > I wonder if we can convert all

Re: svn commit: r362829 - head/sys/compat/linuxkpi/common/src

2020-07-01 Thread Hans Petter Selasky
On 2020-07-01 12:30, Konstantin Belousov wrote: I see no point in repeating the same pfind/tdfind calls, better to convert them to pget(), and have this code in one intended place. I wonder if we can convert all cases in linux_current.c to use pget(). Could you have a look too? --HPS

Re: svn commit: r362829 - head/sys/compat/linuxkpi/common/src

2020-07-01 Thread Konstantin Belousov
On Wed, Jul 01, 2020 at 11:35:21AM +0200, Hans Petter Selasky wrote: > On 2020-07-01 11:21, Konstantin Belousov wrote: > > It should be expressed as pget(pid, 0); instead of duplicating. > > Hi, > > Currently the LinuxKPI style is to use tdfind() and pfind(). If you look at > linux_current.c you

Re: svn commit: r362829 - head/sys/compat/linuxkpi/common/src

2020-07-01 Thread Hans Petter Selasky
On 2020-07-01 11:21, Konstantin Belousov wrote: It should be expressed as pget(pid, 0); instead of duplicating. Hi, Currently the LinuxKPI style is to use tdfind() and pfind(). If you look at linux_current.c you see multiple uses of the exact same syntax. Quickly looking at the pget()

Re: svn commit: r362829 - head/sys/compat/linuxkpi/common/src

2020-07-01 Thread Konstantin Belousov
On Wed, Jul 01, 2020 at 08:23:57AM +, Hans Petter Selasky wrote: > Author: hselasky > Date: Wed Jul 1 08:23:57 2020 > New Revision: 362829 > URL: https://svnweb.freebsd.org/changeset/base/362829 > > Log: > The "pid" field in the LinuxKPI task struct is typically set to the thread > ID >

svn commit: r362829 - head/sys/compat/linuxkpi/common/src

2020-07-01 Thread Hans Petter Selasky
Author: hselasky Date: Wed Jul 1 08:23:57 2020 New Revision: 362829 URL: https://svnweb.freebsd.org/changeset/base/362829 Log: The "pid" field in the LinuxKPI task struct is typically set to the thread ID and not the process ID. Make sure the linux_task_exiting() function uses tdfind() to