Re: svn commit: r367771 - head/sbin/nvmecontrol

2020-11-17 Thread Jessica Clarke
On 17 Nov 2020, at 17:29, Jessica Clarke wrote: > On 17 Nov 2020, at 17:12, Adrian Chadd wrote: >> @@ -175,8 +176,7 @@ update_firmware(int fd, uint8_t *payload, int32_t payl >> errx(EX_OSERR, "unable to malloc %zd bytes", >> (size_t)max_xfer_size); >> >> while (resid > 0) { >>

Re: svn commit: r367771 - head/sbin/nvmecontrol

2020-11-17 Thread Jessica Clarke
On 17 Nov 2020, at 17:12, Adrian Chadd wrote: > @@ -175,8 +176,7 @@ update_firmware(int fd, uint8_t *payload, int32_t payl > errx(EX_OSERR, "unable to malloc %zd bytes", > (size_t)max_xfer_size); > > while (resid > 0) { > - size = (resid >= (int32_t)max_xfer_size)

svn commit: r367771 - head/sbin/nvmecontrol

2020-11-17 Thread Adrian Chadd
Author: adrian Date: Tue Nov 17 17:12:28 2020 New Revision: 367771 URL: https://svnweb.freebsd.org/changeset/base/367771 Log: [nvmecontrol] Fix type signedness warning-to-error on gcc-6.4 This fixes a type signedness comparison warning-to-error on gcc-6.4. The ternary operation casts it r