Re: svn commit: r226151 - head/usr.bin/kdump

2011-10-11 Thread Dag-Erling Smørgrav
Jaakko Heinonen j...@freebsd.org writes: Dag-Erling Smorgrav d...@freebsd.org writes: +#define print_number(i,n,c)\ + do {\ + if (decimal)\ +

Re: svn commit: r226151 - head/usr.bin/kdump

2011-10-11 Thread Dag-Erling Smørgrav
Jaakko Heinonen j...@freebsd.org writes: I am not sure if you understood what I meant here. Casting to uintmax_t is obviously more correct but print_number() will still print the negative range in 64-bit format on i386. Hmm, you are right, it would have worked if *i was first cast to an

svn commit: r226247 - head/sys/compat/linux

2011-10-11 Thread Christian Brueffer
Author: brueffer Date: Tue Oct 11 10:32:23 2011 New Revision: 226247 URL: http://svn.freebsd.org/changeset/base/226247 Log: Properly free linux_gidset in case of an error. CID: 4136 Found with: Coverity Prevent(tm) MFC after:1 week Modified:

Re: svn commit: r226247 - head/sys/compat/linux

2011-10-11 Thread Giovanni Trematerra
On Tue, Oct 11, 2011 at 12:32 PM, Christian Brueffer bruef...@freebsd.org wrote: Author: brueffer Date: Tue Oct 11 10:32:23 2011 New Revision: 226247 URL: http://svn.freebsd.org/changeset/base/226247 Log:  Properly free linux_gidset in case of an error.  CID:          4136  Found with:  

Re: svn commit: r226247 - head/sys/compat/linux

2011-10-11 Thread John Baldwin
On Tuesday, October 11, 2011 6:32:23 am Christian Brueffer wrote: Author: brueffer Date: Tue Oct 11 10:32:23 2011 New Revision: 226247 URL: http://svn.freebsd.org/changeset/base/226247 Log: Properly free linux_gidset in case of an error. CID:4136 Found with:

svn commit: r226252 - head/sys/netinet

2011-10-11 Thread Michael Tuexen
Author: tuexen Date: Tue Oct 11 13:24:37 2011 New Revision: 226252 URL: http://svn.freebsd.org/changeset/base/226252 Log: Use the most significant 6 bits of the dscp instead of the least significant ones. This has changed in the latest version of the socket API ID and provides backwards

svn commit: r226253 - head/sys/compat/linux

2011-10-11 Thread Christian Brueffer
Author: brueffer Date: Tue Oct 11 13:40:37 2011 New Revision: 226253 URL: http://svn.freebsd.org/changeset/base/226253 Log: Add curly braces missed in r226247. Pointy hat to:brueffer Submitted by: many MFC after:1 week Modified: head/sys/compat/linux/linux_uid16.c

Re: svn commit: r226247 - head/sys/compat/linux

2011-10-11 Thread Christian Brueffer
On 10/11/11 13:26 , Giovanni Trematerra wrote: On Tue, Oct 11, 2011 at 12:32 PM, Christian Brueffer bruef...@freebsd.org wrote: Author: brueffer Date: Tue Oct 11 10:32:23 2011 New Revision: 226247 URL: http://svn.freebsd.org/changeset/base/226247 Log: Properly free linux_gidset in case of

Re: svn commit: r226151 - head/usr.bin/kdump

2011-10-11 Thread Jaakko Heinonen
On 2011-10-11, Dag-Erling Smørgrav wrote: @@ -113,6 +114,8 @@ #define print_number(i,n,c) do { \ if (decimal)\ printf(%c%jd, c, (intmax_t)*i); \ + else if (sizeof(*i) ==

Re: svn commit: r226151 - head/usr.bin/kdump

2011-10-11 Thread Dag-Erling Smørgrav
Jaakko Heinonen j...@freebsd.org writes: This assumes that sizeof(*i) is always sizeof(long) or sizeof(uintmax_t). I prefer the fix bde suggested in another mail if it's possible (I don't know if *i is always type of register_t). It is. I didn't realize there was a u_register_t. DES --

svn commit: r226262 - head/usr.bin/kdump

2011-10-11 Thread Dag-Erling Smorgrav
Author: des Date: Tue Oct 11 15:04:58 2011 New Revision: 226262 URL: http://svn.freebsd.org/changeset/base/226262 Log: The previous commit did not fix the issue since it did not prevent sign extension. Cast to u_register_t first, then to uintmax_t. Submitted by: bde@ Modified:

svn commit: r226263 - head/share/man/man4

2011-10-11 Thread Gleb Smirnoff
Author: glebius Date: Tue Oct 11 15:41:07 2011 New Revision: 226263 URL: http://svn.freebsd.org/changeset/base/226263 Log: Properly document default number of rx/tx descriptors for Intel cards. Modified: head/share/man/man4/em.4 head/share/man/man4/igb.4 Modified: head/share/man/man4/em.4

Re: svn commit: r226157 - head/usr.bin/kdump

2011-10-11 Thread Garrett Cooper
On Sat, Oct 8, 2011 at 5:47 AM, Dag-Erling Smorgrav d...@freebsd.org wrote: Author: des Date: Sat Oct  8 12:47:00 2011 New Revision: 226157 URL: http://svn.freebsd.org/changeset/base/226157 Log:  Bring ioctlname() in line with all the other *name() functions, which  actually print the name

svn commit: r226264 - head/share/man/man4

2011-10-11 Thread Gleb Smirnoff
Author: glebius Date: Tue Oct 11 18:26:31 2011 New Revision: 226264 URL: http://svn.freebsd.org/changeset/base/226264 Log: Fix date in last commit. Noticed by: Larry Rosenman ler lerctr.org Modified: head/share/man/man4/em.4 Modified: head/share/man/man4/em.4

svn commit: r226265 - head/sys/kern

2011-10-11 Thread Kirk McKusick
Author: mckusick Date: Tue Oct 11 18:46:41 2011 New Revision: 226265 URL: http://svn.freebsd.org/changeset/base/226265 Log: When unmounting a filesystem always wait for the vfs_busy lock to clear so that if no vnodes in the filesystem are actively in use the unmount will succeed rather than

svn commit: r226266 - head/sbin/tunefs

2011-10-11 Thread Kirk McKusick
Author: mckusick Date: Tue Oct 11 19:03:57 2011 New Revision: 226266 URL: http://svn.freebsd.org/changeset/base/226266 Log: After creating a filesystem using newfs -j the time stamps are all zero and thus report as having been made in January 1970. Apart from looking a bit silly, it also

Re: svn commit: r226157 - head/usr.bin/kdump

2011-10-11 Thread Dag-Erling Smørgrav
Garrett Cooper yaneg...@gmail.com writes: Seeing that you've committed quite a bit to kdump recently, could you please take a look at http://www.freebsd.org/cgi/query-pr.cgi?pr=161478 ? Hmm, that patch actually removes code, but if the point is make ktrace and kdump build at WARNS level 6,

Re: svn commit: r226157 - head/usr.bin/kdump

2011-10-11 Thread Garrett Cooper
2011/10/11 Dag-Erling Smørgrav d...@des.no: Garrett Cooper yaneg...@gmail.com writes:     Seeing that you've committed quite a bit to kdump recently, could you please take a look at http://www.freebsd.org/cgi/query-pr.cgi?pr=161478 ? Hmm, that patch actually removes code, but if the point is

svn commit: r226269 - in head: lib/libc/sys sys/kern sys/sys usr.bin/kdump usr.bin/ktrace

2011-10-11 Thread Dag-Erling Smorgrav
Author: des Date: Tue Oct 11 20:37:10 2011 New Revision: 226269 URL: http://svn.freebsd.org/changeset/base/226269 Log: Add a new trace point, KTRFAC_CAPFAIL, which traces capability check failures. It is included in the default set for ktrace(1) and kdump(1). Modified:

Re: svn commit: r226157 - head/usr.bin/kdump

2011-10-11 Thread Dag-Erling Smørgrav
Garrett Cooper yaneg...@gmail.com writes: Awesome! If you can find out where capname was at, I don't have an issue with re-adding that portion of the patch. The issue is that the compile fails with WARNS 0 because it can't find the identifier in any of the included headers (and it's new code

Re: svn commit: r226157 - head/usr.bin/kdump

2011-10-11 Thread Garrett Cooper
2011/10/11 Dag-Erling Smørgrav d...@des.no: Garrett Cooper yaneg...@gmail.com writes: Awesome! If you can find out where capname was at, I don't have an issue with re-adding that portion of the patch. The issue is that the compile fails with WARNS 0 because it can't find the identifier in

svn commit: r226270 - head/sys/dev/lge

2011-10-11 Thread Marius Strobl
Author: marius Date: Tue Oct 11 21:52:24 2011 New Revision: 226270 URL: http://svn.freebsd.org/changeset/base/226270 Log: - Remove unused remnants of MII bitbang'ing. - Sprinkle const. Modified: head/sys/dev/lge/if_lge.c head/sys/dev/lge/if_lgereg.h Modified: head/sys/dev/lge/if_lge.c

Re: svn commit: r226157 - head/usr.bin/kdump

2011-10-11 Thread Dag-Erling Smørgrav
Would you mind reviewing the attached patch, which cleans up ktrace(1)? DES -- Dag-Erling Smørgrav - d...@des.no Index: usr.bin/ktrace/ktrace.c === --- usr.bin/ktrace/ktrace.c (revision 226262) +++ usr.bin/ktrace/ktrace.c (working

svn commit: r226271 - in head/usr.bin/grep: . regex

2011-10-11 Thread Gabor Kovesdan
Author: gabor Date: Tue Oct 11 22:27:23 2011 New Revision: 226271 URL: http://svn.freebsd.org/changeset/base/226271 Log: - Use getprogname() instead of __progname - Allow disabling bzip2 support with WITHOUT_BZIP2 - Fix handling patterns that start with a dot - Remove superfluous

Re: svn commit: r226266 - head/sbin/tunefs

2011-10-11 Thread Alexander Best
On Tue Oct 11 11, Kirk McKusick wrote: Author: mckusick Date: Tue Oct 11 19:03:57 2011 New Revision: 226266 URL: http://svn.freebsd.org/changeset/base/226266 Log: After creating a filesystem using newfs -j the time stamps are all zero and thus report as having been made in January

Re: svn commit: r226157 - head/usr.bin/kdump

2011-10-11 Thread Dag-Erling Smørgrav
Garrett Cooper yaneg...@gmail.com writes: Seeing that you've committed quite a bit to kdump recently, could you please take a look at http://www.freebsd.org/cgi/query-pr.cgi?pr=161478 ? Hmm, did you run across this while testing your patch? % make cc -O2 -pipe

Re: svn commit: r226157 - head/usr.bin/kdump

2011-10-11 Thread Garrett Cooper
2011/10/11 Dag-Erling Smørgrav d...@des.no: Garrett Cooper yaneg...@gmail.com writes: Seeing that you've committed quite a bit to kdump recently, could you please take a look at http://www.freebsd.org/cgi/query-pr.cgi?pr=161478 ? Hmm, did you run across this while testing your patch? %

svn commit: r226273 - head/usr.bin/grep

2011-10-11 Thread Gabor Kovesdan
Author: gabor Date: Wed Oct 12 01:09:57 2011 New Revision: 226273 URL: http://svn.freebsd.org/changeset/base/226273 Log: - Fix counting of match limit (-m) Reported by: Nali Toja nalit...@gmail.com Approved by: delphij (mentor) Modified: head/usr.bin/grep/util.c Modified:

svn commit: r226274 - head/usr.bin/newgrp

2011-10-11 Thread Xin LI
Author: delphij Date: Wed Oct 12 01:19:12 2011 New Revision: 226274 URL: http://svn.freebsd.org/changeset/base/226274 Log: - Fix an off-by-one bug in addgroup(). - Fix the error message when setgid() failed. PR: bin/161509 Submitted by: Jeremy Huddleston jeremyhu apple com

svn commit: r226277 - head/etc

2011-10-11 Thread Colin Percival
Author: cperciva Date: Wed Oct 12 03:29:12 2011 New Revision: 226277 URL: http://svn.freebsd.org/changeset/base/226277 Log: Now that the portsnap buildbox is generating the raw bits for INDEX-9, add it to the set of INDEX files built by portsnap. Modified: head/etc/portsnap.conf Modified: