Re: svn commit: r323692 - in head/sys/compat: linsysfs linux

On 09/18/17 01:40, Conrad Meyer wrote: + sprintf(chardevname, "226:%d", + device_get_unit(dev)); Hi, Try to use snprintf(). Define the chardevname size as a macro, or just allocate it on the stack if it is < 32 bytes. --HPS

Re: svn commit: r323692 - in head/sys/compat: linsysfs linux

On 09/18/17 17:09, Conrad Meyer wrote: Seems unhelpful here, as the maximum length of "226:%d" is shorter than the buffer. It makes code-review easier. --HPS ___ svn-src-head@freebsd.org mailing list

svn commit: r323703 - in head/sys/compat/linuxkpi/common: include/linux src

Author: hselasky Date: Mon Sep 18 13:17:23 2017 New Revision: 323703 URL: https://svnweb.freebsd.org/changeset/base/323703 Log: Add support for shared memory functions to the LinuxKPI. Obtained from:kmacy @ MFC after:1 week Sponsored by: Mellanox

Re: svn commit: r323692 - in head/sys/compat: linsysfs linux

On 09/18/17 01:40, Conrad Meyer wrote: device_get_children(dev, , ); for (i = 0; i < nchildren; i++) { if (children[i]) - linsysfs_run_bus(children[i], dir, scsi, new_path, prefix); + linsysfs_run_bus(children[i], dir,

Re: svn commit: r323692 - in head/sys/compat: linsysfs linux

Seems unhelpful here, as the maximum length of "226:%d" is shorter than the buffer. On Mon, Sep 18, 2017 at 3:38 AM, Hans Petter Selasky wrote: > On 09/18/17 01:40, Conrad Meyer wrote: >> >> + sprintf(chardevname, "226:%d", >> +

Re: svn commit: r323692 - in head/sys/compat: linsysfs linux

On 09/18/17 01:40, Conrad Meyer wrote: + + dinfo = device_get_ivars(parent); + if (dinfo != NULL && dinfo->cfg.baseclass == PCIC_DISPLAY) { + devclass = device_get_devclass(dev); + if (devclass != NULL) +

RE: svn commit: r323709 - head/usr.sbin/tcpdump/tcpdump

Thank you. Sent using a tiny phone keyboard. Apologies for any typos. Cy Schubert or -Original Message- From: Gordon Tetlow Sent: 18/09/2017 09:42 To: src-committ...@freebsd.org; svn-src-...@freebsd.org; svn-src-head@freebsd.org Subject:

Re: svn commit: r323692 - in head/sys/compat: linsysfs linux

This was not introduced in this change. On Mon, Sep 18, 2017 at 8:05 AM, Hans Petter Selasky wrote: > On 09/18/17 01:40, Conrad Meyer wrote: >> >> device_get_children(dev, , ); >> for (i = 0; i < nchildren; i++) { >> if (children[i]) >> -

svn commit: r323709 - head/usr.sbin/tcpdump/tcpdump

Author: gordon Date: Mon Sep 18 16:42:13 2017 New Revision: 323709 URL: https://svnweb.freebsd.org/changeset/base/323709 Log: Revert tcpdump to using the source manpage instead of having a copy here. This helps future maintainability of tcpdump so we don't forget to update the manpage

svn commit: r323707 - head/sys/boot/i386/libi386

Author: tsoome Date: Mon Sep 18 15:17:01 2017 New Revision: 323707 URL: https://svnweb.freebsd.org/changeset/base/323707 Log: loader: biosmem allocate heap just below 4GB The current biosmem code is walking bios smap entries and looking for smap entry just below 4GB line, if there is

svn commit: r323706 - head/sys/sys

Author: hselasky Date: Mon Sep 18 13:39:51 2017 New Revision: 323706 URL: https://svnweb.freebsd.org/changeset/base/323706 Log: Bump the __FreeBSD_version after recent LinuxKPI changes. MFC after:1 week Sponsored by: Mellanox Technologies Modified:

svn commit: r323705 - in head/sys/compat/linuxkpi/common: include/asm include/linux src

Author: hselasky Date: Mon Sep 18 13:37:14 2017 New Revision: 323705 URL: https://svnweb.freebsd.org/changeset/base/323705 Log: The LinuxKPI atomics do not have acquire nor release semantics unless specified. Fix code to use READ_ONCE() and WRITE_ONCE() where appropriate. Suggested by:

svn commit: r323704 - in head/sys/compat/linuxkpi/common: include/linux src

Author: hselasky Date: Mon Sep 18 13:23:59 2017 New Revision: 323704 URL: https://svnweb.freebsd.org/changeset/base/323704 Log: Only wire pages in the LinuxKPI instead of holding and wiring them. This prevents the page daemon from regularly scanning the held pages. Suggested by:

Re: svn commit: r323692 - in head/sys/compat: linsysfs linux

On Sun, Sep 17, 2017 at 4:40 PM, Conrad Meyer wrote: > Author: cem > Date: Sun Sep 17 23:40:16 2017 > New Revision: 323692 > URL: https://svnweb.freebsd.org/changeset/base/323692 > > Log: > linsysfs(5): Add support for recent libdrm > > Expose more information about PCI

svn commit: r323715 - head/sys/contrib/ipfilter/netinet

Author: cy Date: Mon Sep 18 19:16:41 2017 New Revision: 323715 URL: https://svnweb.freebsd.org/changeset/base/323715 Log: Don't use an apostrophe in a possesive pronoun. MFC after:3 days Modified: head/sys/contrib/ipfilter/netinet/ip_state.c Modified:

svn commit: r323714 - head/sys/compat/linsysfs

Author: rlibby Date: Mon Sep 18 19:09:40 2017 New Revision: 323714 URL: https://svnweb.freebsd.org/changeset/base/323714 Log: linsysfs: quiet gcc -Wformat after r323692 Reviewed by: cem Sponsored by: Dell EMC Isilon Modified: head/sys/compat/linsysfs/linsysfs.c Modified:

svn commit: r323710 - head/sys/compat/linsysfs

Author: cem Date: Mon Sep 18 17:14:13 2017 New Revision: 323710 URL: https://svnweb.freebsd.org/changeset/base/323710 Log: linsysfs(5): Fix two unrelated issues 1. Swap the order of device_get_ivars with device_get_devclass and devclass name validation. This bug was introduced in

svn commit: r323712 - head/sys/dev/ppc

Author: scottl Date: Mon Sep 18 18:42:28 2017 New Revision: 323712 URL: https://svnweb.freebsd.org/changeset/base/323712 Log: Hide a normal probe warning message under bootverbose, similar to atkbdc Sponsored by: Netflix Modified: head/sys/dev/ppc/ppc.c Modified: head/sys/dev/ppc/ppc.c

svn commit: r323721 - head/sys/cam/mmc

Author: kibab Date: Mon Sep 18 20:17:08 2017 New Revision: 323721 URL: https://svnweb.freebsd.org/changeset/base/323721 Log: Add kern.features flag for MMCCAM kern.features.mmcam will be present and equal to 1 if the kernel has been compiled with option MMCCAM. This will help

Re: svn commit: r323715 - head/sys/contrib/ipfilter/netinet

On Mon, 2017-09-18 at 19:16 +, Cy Schubert wrote: > Author: cy > Date: Mon Sep 18 19:16:41 2017 > New Revision: 323715 > URL: https://svnweb.freebsd.org/changeset/base/323715 > > Log: >   Don't use an apostrophe in a possesive pronoun. >    And that really is the way to remember it for those

svn commit: r323717 - head/usr.bin/sdiotool

Author: kibab Date: Mon Sep 18 20:01:01 2017 New Revision: 323717 URL: https://svnweb.freebsd.org/changeset/base/323717 Log: Make basic Broadcom I/O space reading functions work It's now possible to use Broadcom functions to read the I/O registers of SDIO card. The functions were copied

svn commit: r323722 - in head/sys: i386/i386 i386/include i386/isa kern

Author: kib Date: Mon Sep 18 20:22:42 2017 New Revision: 323722 URL: https://svnweb.freebsd.org/changeset/base/323722 Log: Fix handling of the segment registers on i386. Suppose that userspace is executing with the non-standard segment descriptors. Then, until exception or interrupt

svn commit: r323723 - in head/sys/ufs: ffs ufs

Author: jhb Date: Mon Sep 18 23:30:39 2017 New Revision: 323723 URL: https://svnweb.freebsd.org/changeset/base/323723 Log: Add UFS_LINK_MAX for the UFS-specific limit on link counts. ino64 expanded nlink_t to 64 bits, but the on-disk format for UFS is still limited to 16 bits. This is a

svn commit: r323724 - in head/sys/dev/cxgbe: . firmware

Author: jhb Date: Mon Sep 18 23:50:34 2017 New Revision: 323724 URL: https://svnweb.freebsd.org/changeset/base/323724 Log: Enable support for lookaside crypto operations by default. This permits ccr(4) to be used with the default firmware configuration file. Discussed with: np