svn commit: r331322 - head/sys/netinet

Author: glebius Date: Wed Mar 21 20:59:30 2018 New Revision: 331322 URL: https://svnweb.freebsd.org/changeset/base/331322 Log: The net.inet.tcp.nolocaltimewait=1 optimization prevents local TCP connections from entering the TIME_WAIT state. However, it omits sending the ACK for the FIN,

Re: svn commit: r331298 - head/sys/dev/syscons

On Wed, 21 Mar 2018, Warner Losh wrote: Log: Unlock giant when calling shutdown_nice() This breaks the driver. Giant is syscons' driver lock, and also the interrupt handler lock for at least the atkbd keyboard driver, so vt sometimes holds the lock for. vt has to sprinkle lots of Giant

Re: svn commit: r331298 - head/sys/dev/syscons

On Thu, Mar 22, 2018 at 04:53:22AM +1100, Bruce Evans wrote: > Serial console drivers with fast interrupt handlers have much more > broken locking for ddb special keys. It is invalid to either drop locks > or call the "any" function from a fast interrupt handler, but buggy > serial console

svn commit: r331324 - head/lib/libthr/thread

Author: jhb Date: Wed Mar 21 21:13:26 2018 New Revision: 331324 URL: https://svnweb.freebsd.org/changeset/base/331324 Log: Ensure thread library is initialized in pthread_testcancel(). Call _thr_check_init() before reading curthread in pthread_testcancel(). If a constructor in a

svn commit: r331321 - in head/stand: efi/boot1 efi/loader lua

Author: kevans Date: Wed Mar 21 20:36:57 2018 New Revision: 331321 URL: https://svnweb.freebsd.org/changeset/base/331321 Log: UEFI: Ditch console mode setting, choose optimal GOP mode later in boot boot1 is too early to be deciding a good resolution. Console modes don't map

svn commit: r331325 - head/sys/kern

Author: markj Date: Wed Mar 21 21:15:43 2018 New Revision: 331325 URL: https://svnweb.freebsd.org/changeset/base/331325 Log: Elide the object lock in the common case in vfs_vmio_unwire(). The object lock was only needed when attempting to free B_DIRECT buffer pages, and for testing for

Re: svn commit: r331306 - head/sys/dev/usb/controller

On 03/21/18 17:45, Andrew Turner wrote: On 21 Mar 2018, at 15:37, Hans Petter Selasky wrote: On 03/21/18 16:24, Kyle Evans wrote: + { + .ep_end = 7, + .ep_fifosz_shift = 9, + .ep_fifosz_reg = MUSB2_VAL_FIFOSZ_512 |

Re: svn commit: r331279 - in head: include lib/libc/gen lib/libc/sys lib/libc/tests/gen sys/compat/freebsd32 sys/conf sys/kern sys/sys tests/sys/kern usr.bin/truss

On Wed, Mar 21, 2018 at 8:37 AM Conrad Meyer wrote: > On Wed, Mar 21, 2018 at 8:23 AM, Konstantin Belousov > wrote: > > On Wed, Mar 21, 2018 at 08:03:16AM -0700, Conrad Meyer wrote: > >> On Wed, Mar 21, 2018 at 3:33 AM, Konstantin Belousov > >> > Libraries

Re: svn commit: r331298 - head/sys/dev/syscons

On Thu, 22 Mar 2018, Bruce Evans wrote: On Wed, 21 Mar 2018, Warner Losh wrote: Log: Unlock giant when calling shutdown_nice() ... This breaks the driver. Giant is syscons' driver lock, and also the interrupt handler lock for at least the atkbd keyboard driver, so vt sometimes holds the

svn commit: r331313 - head/share/man/man4

Author: csjp Date: Wed Mar 21 17:22:42 2018 New Revision: 331313 URL: https://svnweb.freebsd.org/changeset/base/331313 Log: Document the limitations associated with using the audit syscalls from jailed process. These might get implemented in jails in the future, but for now they are not

Re: svn commit: r331279 - in head: include lib/libc/gen lib/libc/sys lib/libc/tests/gen sys/compat/freebsd32 sys/conf sys/kern sys/sys tests/sys/kern usr.bin/truss

Please see https://reviews.freebsd.org/D14785 . :-) Thanks, Conrad On Wed, Mar 21, 2018 at 10:31 AM, Xin LI wrote: > > > > On Wed, Mar 21, 2018 at 8:37 AM Conrad Meyer wrote: >> >> On Wed, Mar 21, 2018 at 8:23 AM, Konstantin Belousov >>

svn commit: r331314 - head/stand/lua

Author: kevans Date: Wed Mar 21 18:02:56 2018 New Revision: 331314 URL: https://svnweb.freebsd.org/changeset/base/331314 Log: lualoader: Use printc when we expect ANSI escape sequences Modified: head/stand/lua/drawer.lua Modified: head/stand/lua/drawer.lua

svn commit: r331290 - head/sys/sys

Author: kib Date: Wed Mar 21 10:26:39 2018 New Revision: 331290 URL: https://svnweb.freebsd.org/changeset/base/331290 Log: Move sysinit and sysuninit linker sets in the data (writeable) section. Both sets are sorted in place, and with the introduction of read-only permissions on the

Re: svn commit: r331279 - in head: include lib/libc/gen lib/libc/sys lib/libc/tests/gen sys/compat/freebsd32 sys/conf sys/kern sys/sys tests/sys/kern usr.bin/truss

On Wed, Mar 21, 2018 at 01:15:45AM +, Conrad Meyer wrote: > +int > +getentropy(void *buf, size_t buflen) > +{ > + ssize_t rd; > + > + if (buflen > 256) { > + errno = EIO; > + return (-1); > + } > + > + while (buflen > 0) { > + rd =

svn commit: r331285 - head/share/misc

Author: eadler Date: Wed Mar 21 09:07:01 2018 New Revision: 331285 URL: https://svnweb.freebsd.org/changeset/base/331285 Log: [bsd-family-tree] Announce NetBSD 7.1.2 MFC After:3 days Modified: head/share/misc/bsd-family-tree Modified: head/share/misc/bsd-family-tree

svn commit: r331291 - head/sys/cam/scsi

Author: imp Date: Wed Mar 21 12:55:59 2018 New Revision: 331291 URL: https://svnweb.freebsd.org/changeset/base/331291 Log: Revert r331273: "Release the "TUR" reference when clearing the TUR work flag. We mostly" It exposes other issues, so revert to the pervious state of known issues.

svn commit: r331329 - head/sys/i386/ibcs2

Author: emaste Date: Wed Mar 21 23:26:42 2018 New Revision: 331329 URL: https://svnweb.freebsd.org/changeset/base/331329 Log: Fix kernel memory disclosure in ibcs2_getdents ibcs2_getdents() copies a dirent structure to userland. The ibcs2 dirent structure contains a 2 byte pad element.

svn commit: r331332 - head/lib/libjail

Author: jamie Date: Wed Mar 21 23:50:46 2018 New Revision: 331332 URL: https://svnweb.freebsd.org/changeset/base/331332 Log: If a jail parameter isn't found, try loading a related kernel module. Modified: head/lib/libjail/jail.c Modified: head/lib/libjail/jail.c

svn commit: r331333 - head/sys/dev/drm

Author: emaste Date: Wed Mar 21 23:51:14 2018 New Revision: 331333 URL: https://svnweb.freebsd.org/changeset/base/331333 Log: Fix kernel memory disclosure in drm_infobufs drm_infobufs() has a structure on the stack, fills it out and copies it to userland. There are 2 elements in the

Re: svn commit: r331298 - head/sys/dev/syscons

On Wed, Mar 21, 2018 at 11:53 AM, Bruce Evans wrote: > On Wed, 21 Mar 2018, Warner Losh wrote: > > Log: >> Unlock giant when calling shutdown_nice() >> > > This breaks the driver. Giant is syscons' driver lock, and also the > interrupt handler lock for at least the atkbd

svn commit: r331339 - head/sys/dev/drm

Author: emaste Date: Thu Mar 22 01:00:55 2018 New Revision: 331339 URL: https://svnweb.freebsd.org/changeset/base/331339 Log: Correct signedness bug in drm_modeset_ctl drm_modeset_ctl() takes a signed in from userland, does a boundscheck, and then uses it to index into a structure and

svn commit: r331327 - head/sys/i386/ibcs2

Author: emaste Date: Wed Mar 21 23:17:26 2018 New Revision: 331327 URL: https://svnweb.freebsd.org/changeset/base/331327 Log: Add ) missing from r330297 Sponsored by: The FreeBSD Foundation Modified: head/sys/i386/ibcs2/ibcs2_ipc.c Modified: head/sys/i386/ibcs2/ibcs2_ipc.c

Re: svn commit: r331298 - head/sys/dev/syscons

On Wed, Mar 21, 2018 at 2:27 PM, Konstantin Belousov wrote: > On Thu, Mar 22, 2018 at 04:53:22AM +1100, Bruce Evans wrote: > > Serial console drivers with fast interrupt handlers have much more > > broken locking for ddb special keys. It is invalid to either drop locks > >

svn commit: r331334 - in head/lib/libc: gen include sys tests/gen

Author: cem Date: Wed Mar 21 23:52:37 2018 New Revision: 331334 URL: https://svnweb.freebsd.org/changeset/base/331334 Log: getentropy(3): Fallback to kern.arandom sysctl on older kernels On older kernels, when userspace program disables SIGSYS, catch ENOSYS and emulate getrandom(2)

svn commit: r331326 - in head/stand: forth i386/loader

Author: kevans Date: Wed Mar 21 22:01:51 2018 New Revision: 331326 URL: https://svnweb.freebsd.org/changeset/base/331326 Log: Forth version of EFI autoresizing r331321 delegated autoresizing to an efi-autoresizecons command that currently is expected to be done in forth/lua prior to

svn commit: r331328 - head/sys/kern

Author: glebius Date: Wed Mar 21 23:21:32 2018 New Revision: 331328 URL: https://svnweb.freebsd.org/changeset/base/331328 Log: Fix sysctl types broken in r329612. Modified: head/sys/kern/vfs_bio.c Modified: head/sys/kern/vfs_bio.c

svn commit: r331331 - head/stand/common

Author: cem Date: Wed Mar 21 23:46:26 2018 New Revision: 331331 URL: https://svnweb.freebsd.org/changeset/base/331331 Log: Apply r228478 (CTASSERT => _Static_assert()) to stand bootstrap.h Reported by: GCC (it doesn't like the unused array) Sponsored by: Dell EMC Isilon Modified:

Re: svn commit: r331326 - in head/stand: forth i386/loader

On Wed, Mar 21, 2018 at 10:30 PM, Cy Schubert wrote: > In message <201803212201.w2lm1pvl020...@repo.freebsd.org>, Kyle Evans > writes: >> Author: kevans >> Date: Wed Mar 21 22:01:51 2018 >> New Revision: 331326 >> URL: https://svnweb.freebsd.org/changeset/base/331326 >>

Re: svn commit: r331328 - head/sys/kern

On Wed, 21 Mar 2018, Gleb Smirnoff wrote: Log: Fix sysctl types broken in r329612. This is still broken. Modified: head/sys/kern/vfs_bio.c == --- head/sys/kern/vfs_bio.c Wed Mar 21 23:17:26 2018

svn commit: r331343 - head/sys/netinet

Author: glebius Date: Thu Mar 22 05:07:57 2018 New Revision: 331343 URL: https://svnweb.freebsd.org/changeset/base/331343 Log: Fix LINT-NOINET build initializing local to false. This is a dead code, since for NOINET build isipv6 is always true, but this dead code makes it compilable.

Re: svn commit: r331209 - head

On Mon, Mar 19, 2018 at 09:20:40AM -0700, John Baldwin wrote: > On Monday, March 19, 2018 03:27:53 PM Kyle Evans wrote: > > New Revision: 331209 > > URL: https://svnweb.freebsd.org/changeset/base/331209 > > > > Log: > > Add note to UPDATING about UEFI changes requiring loader(8) update > >

Re: svn commit: r331209 - head

On Wed, Mar 21, 2018 at 10:03 PM, Alexey Dokuchaev wrote: > On Mon, Mar 19, 2018 at 09:20:40AM -0700, John Baldwin wrote: > > On Monday, March 19, 2018 03:27:53 PM Kyle Evans wrote: > > > New Revision: 331209 > > > URL: https://svnweb.freebsd.org/changeset/base/331209 > > > >

Re: svn commit: r331326 - in head/stand: forth i386/loader

In message <201803212201.w2lm1pvl020...@repo.freebsd.org>, Kyle Evans writes: > Author: kevans > Date: Wed Mar 21 22:01:51 2018 > New Revision: 331326 > URL: https://svnweb.freebsd.org/changeset/base/331326 > > Log: > Forth version of EFI autoresizing > > r331321 delegated autoresizing to

Re: svn commit: r331209 - head

On Wed, Mar 21, 2018 at 10:39 PM, Alexey Dokuchaev wrote: > On Wed, Mar 21, 2018 at 10:34:15PM -0600, Warner Losh wrote: > > On Wed, Mar 21, 2018 at 10:03 PM, Alexey Dokuchaev > > wrote: > > > On Mon, Mar 19, 2018 at 09:20:40AM -0700, John Baldwin wrote: >

Re: svn commit: r331209 - head

On Wed, Mar 21, 2018 at 10:34:15PM -0600, Warner Losh wrote: > On Wed, Mar 21, 2018 at 10:03 PM, Alexey Dokuchaev > wrote: > > On Mon, Mar 19, 2018 at 09:20:40AM -0700, John Baldwin wrote: > > > ... > > > How does this fit with the recommended installation steps of doing > > >

svn commit: r331341 - head/stand/forth

Author: kevans Date: Thu Mar 22 04:16:14 2018 New Revision: 331341 URL: https://svnweb.freebsd.org/changeset/base/331341 Log: forthloader: Don't break BIOS boots... I thought I tested this scenario, but clearly I failed to. =( BIOS boots won't have efi-autoresizecons, so trying to use

svn commit: r331344 - head/sys/kern

Author: glebius Date: Thu Mar 22 05:26:27 2018 New Revision: 331344 URL: https://svnweb.freebsd.org/changeset/base/331344 Log: Redo r331328. We need to fix not only type but also format. While here again notice that we are fixing regression from r331106. Modified: head/sys/kern/vfs_bio.c

svn commit: r331342 - head/sys/dev/cxgbe/common

Author: np Date: Thu Mar 22 04:42:29 2018 New Revision: 331342 URL: https://svnweb.freebsd.org/changeset/base/331342 Log: cxgbe(4): Do not read MFG diags information from custom boards. MFC after:1 week Sponsored by: Chelsio Communications Modified:

svn commit: r331298 - head/sys/dev/syscons

Author: imp Date: Wed Mar 21 14:47:12 2018 New Revision: 331298 URL: https://svnweb.freebsd.org/changeset/base/331298 Log: Unlock giant when calling shutdown_nice() Modified: head/sys/dev/syscons/syscons.c Modified: head/sys/dev/syscons/syscons.c

Re: svn commit: r331279 - in head: include lib/libc/gen lib/libc/sys lib/libc/tests/gen sys/compat/freebsd32 sys/conf sys/kern sys/sys tests/sys/kern usr.bin/truss

On Wed, Mar 21, 2018 at 3:33 AM, Konstantin Belousov wrote: > On Wed, Mar 21, 2018 at 01:15:45AM +, Conrad Meyer wrote: >> +int >> +getentropy(void *buf, size_t buflen) >> +{ >> + ssize_t rd; >> + >> + if (buflen > 256) { >> + errno = EIO; >> +

Re: svn commit: r331259 - head/stand/lua

On Tue, Mar 20, 2018 at 6:04 PM, Devin Teske wrote: > > Minor nit ... > > While resetf is unlikely to be mistaken for anything other than "reset > foreground", ... > > "resetb" could easily be mistaken for "reset bold". > > I would like to suggest, in tradition, that

svn commit: r331294 - head/sys/kern

Author: imp Date: Wed Mar 21 14:46:54 2018 New Revision: 331294 URL: https://svnweb.freebsd.org/changeset/base/331294 Log: Remove Giant from init creation and vfs_mountroot. Sponsored by: Netflix Discussed with: kib@, mckusick@ Differential Review: https://reviews.freebsd.org/D14712

svn commit: r331295 - head/sys/kern

Author: imp Date: Wed Mar 21 14:46:59 2018 New Revision: 331295 URL: https://svnweb.freebsd.org/changeset/base/331295 Log: bufshutdown is no longer called with Giant held, so there's no need to drop or pickup Giant anymore. Remove that code and adjust comments. Modified:

svn commit: r331304 - head/stand/lua

Author: kevans Date: Wed Mar 21 15:09:47 2018 New Revision: 331304 URL: https://svnweb.freebsd.org/changeset/base/331304 Log: lualoader: Clear up some possible naming confusion In the original lualoader project, 'escapef' and 'escapeb' were chosen for 'escape fg' and 'escape bg'. We've

Re: svn commit: r331279 - in head: include lib/libc/gen lib/libc/sys lib/libc/tests/gen sys/compat/freebsd32 sys/conf sys/kern sys/sys tests/sys/kern usr.bin/truss

On 20/03/2018 20:40, Ian Lepore wrote: On Wed, 2018-03-21 at 01:15 +, Conrad Meyer wrote: Author: cem Date: Wed Mar 21 01:15:45 2018 New Revision: 331279 URL: https://svnweb.freebsd.org/changeset/base/331279 Log:   Implement getrandom(2) and getentropy(3)   The general idea here is

svn commit: r331292 - head/release/arm64

Author: gjb Date: Wed Mar 21 14:36:16 2018 New Revision: 331292 URL: https://svnweb.freebsd.org/changeset/base/331292 Log: Following ports commit r465175, avoid fetch(1) to obtain overlays and DTB files for the RPI3. Submitted by: manu Sponsored by: The FreeBSD Foundation Modified:

svn commit: r331296 - head/sys/sparc64/sbus

Author: imp Date: Wed Mar 21 14:47:03 2018 New Revision: 331296 URL: https://svnweb.freebsd.org/changeset/base/331296 Log: These interrupts call shutdown_nice() which should be called Giant unlocked. Rather than dropping it in the interrupt handler, mark these handlers as MPSAFE. Modified:

svn commit: r331299 - head/sys/sparc64/pci

Author: imp Date: Wed Mar 21 14:47:17 2018 New Revision: 331299 URL: https://svnweb.freebsd.org/changeset/base/331299 Log: Mark psycho interrupts as MPSAFE. It's safe to do so now that we don't need Giant to call shutdown_nice(). Modified: head/sys/sparc64/pci/psycho.c Modified:

Re: svn commit: r331339 - head/sys/dev/drm

On 21 March 2018 at 21:00, Ed Maste wrote: > Author: emaste > Date: Thu Mar 22 01:00:55 2018 > New Revision: 331339 > URL: https://svnweb.freebsd.org/changeset/base/331339 > > Log: > Correct signedness bug in drm_modeset_ctl > > Reported by: Ilja Van Sprundel

svn commit: r331340 - head/sys/dev/cxgbe

Author: np Date: Thu Mar 22 02:04:57 2018 New Revision: 331340 URL: https://svnweb.freebsd.org/changeset/base/331340 Log: cxgbe(4): Tunnel congestion drops on a port should be cleared when the stats for that port are cleared. MFC after:1 week Sponsored by: Chelsio Communications

svn commit: r331311 - head/sys/opencrypto

Author: cem Date: Wed Mar 21 16:12:07 2018 New Revision: 331311 URL: https://svnweb.freebsd.org/changeset/base/331311 Log: cryptosoft(4): Zero plain hash contexts, too An OCF-naive user program could use these primitives to implement HMAC, for example. This would make the freed context

svn commit: r331312 - in head: sys/conf sys/contrib/libb2 sys/crypto/blake2 sys/modules sys/modules/blake2 sys/modules/crypto sys/opencrypto tests/sys/opencrypto

Author: cem Date: Wed Mar 21 16:18:14 2018 New Revision: 331312 URL: https://svnweb.freebsd.org/changeset/base/331312 Log: Import Blake2 algorithms (blake2b, blake2s) from libb2 The upstream repository is on github BLAKE2/libb2. Files landed in sys/contrib/libb2 are the unmodified

svn commit: r331293 - in head: etc/mtree lib lib/libipt share/mk

Author: br Date: Wed Mar 21 14:37:04 2018 New Revision: 331293 URL: https://svnweb.freebsd.org/changeset/base/331293 Log: Add new shared library -- libipt. libipt is the Intel Processor Trace (Intel PT) packets decoder. - Include libipt to amd64 build. - Install libipt headers to

svn commit: r331297 - head/sys/arm/at91

Author: imp Date: Wed Mar 21 14:47:08 2018 New Revision: 331297 URL: https://svnweb.freebsd.org/changeset/base/331297 Log: This is MPSAFE on this platform, so don't take Giant out while running the callback. Modified: head/sys/arm/at91/at91_rst.c Modified: head/sys/arm/at91/at91_rst.c

svn commit: r331306 - head/sys/dev/usb/controller

Author: andrew Date: Wed Mar 21 15:17:54 2018 New Revision: 331306 URL: https://svnweb.freebsd.org/changeset/base/331306 Log: Use a table to find the endpoint configuration On the Allwinner SoCs we need to set a custom endpoint configuration. To allow for this use a table to store the

Re: svn commit: r331279 - in head: include lib/libc/gen lib/libc/sys lib/libc/tests/gen sys/compat/freebsd32 sys/conf sys/kern sys/sys tests/sys/kern usr.bin/truss

On Wed, Mar 21, 2018 at 08:03:16AM -0700, Conrad Meyer wrote: > On Wed, Mar 21, 2018 at 3:33 AM, Konstantin Belousov > wrote: > > On Wed, Mar 21, 2018 at 01:15:45AM +, Conrad Meyer wrote: > >> +int > >> +getentropy(void *buf, size_t buflen) > >> +{ > >> + ssize_t rd;

Re: svn commit: r331306 - head/sys/dev/usb/controller

On Wed, Mar 21, 2018 at 10:17 AM, Andrew Turner wrote: > Author: andrew > Date: Wed Mar 21 15:17:54 2018 > New Revision: 331306 > URL: https://svnweb.freebsd.org/changeset/base/331306 > > Log: > Use a table to find the endpoint configuration > > On the Allwinner SoCs we

Re: svn commit: r331279 - in head: include lib/libc/gen lib/libc/sys lib/libc/tests/gen sys/compat/freebsd32 sys/conf sys/kern sys/sys tests/sys/kern usr.bin/truss

On Wed, Mar 21, 2018 at 8:23 AM, Konstantin Belousov wrote: > On Wed, Mar 21, 2018 at 08:03:16AM -0700, Conrad Meyer wrote: >> On Wed, Mar 21, 2018 at 3:33 AM, Konstantin Belousov >> > Libraries must not abort the application. >> > Esp. libc. >> >> What do you propose

Re: svn commit: r331279 - in head: include lib/libc/gen lib/libc/sys lib/libc/tests/gen sys/compat/freebsd32 sys/conf sys/kern sys/sys tests/sys/kern usr.bin/truss

On Wed, Mar 21, 2018 at 9:37 AM, Conrad Meyer wrote: > On Wed, Mar 21, 2018 at 8:23 AM, Konstantin Belousov > wrote: > > On Wed, Mar 21, 2018 at 08:03:16AM -0700, Conrad Meyer wrote: > >> On Wed, Mar 21, 2018 at 3:33 AM, Konstantin Belousov > >> >

svn commit: r331309 - in head/sys: netinet netinet6

Author: jtl Date: Wed Mar 21 15:54:46 2018 New Revision: 331309 URL: https://svnweb.freebsd.org/changeset/base/331309 Log: If the INP lock is uncontested, avoid taking a reference and jumping through the lock-switching hoops. A few of the INP lookup operations that lock INPs after the

svn commit: r331310 - head/sys/dev/e1000

Author: shurd Date: Wed Mar 21 15:57:36 2018 New Revision: 331310 URL: https://svnweb.freebsd.org/changeset/base/331310 Log: Update copyright per Matthew Macy "Under my tutelage Nicole did 85% of the work. At the time it seemed simplest for a number of reasons to put my copyright on it.

Re: svn commit: r331279 - in head: include lib/libc/gen lib/libc/sys lib/libc/tests/gen sys/compat/freebsd32 sys/conf sys/kern sys/sys tests/sys/kern usr.bin/truss

On Wed, Mar 21, 2018 at 09:42:26AM -0600, Warner Losh wrote: > On Wed, Mar 21, 2018 at 9:37 AM, Conrad Meyer wrote: > > > On Wed, Mar 21, 2018 at 8:23 AM, Konstantin Belousov > > wrote: > > > On Wed, Mar 21, 2018 at 08:03:16AM -0700, Conrad Meyer wrote: >

Re: svn commit: r331306 - head/sys/dev/usb/controller

On 03/21/18 16:24, Kyle Evans wrote: + { + .ep_end = 7, + .ep_fifosz_shift = 9, + .ep_fifosz_reg = MUSB2_VAL_FIFOSZ_512 | MUSB2_MASK_FIFODB, + }, I'm afraid I'm not familiar with this- why did .ep_fifosz_shift for this case drop to 9? frx =

Re: svn commit: r331306 - head/sys/dev/usb/controller

> On 21 Mar 2018, at 15:37, Hans Petter Selasky wrote: > > On 03/21/18 16:24, Kyle Evans wrote: >>> + { >>> + .ep_end = 7, >>> + .ep_fifosz_shift = 9, >>> + .ep_fifosz_reg = MUSB2_VAL_FIFOSZ_512 | MUSB2_MASK_FIFODB, >>> +