svn commit: r334342 - head/sys/kern

Author: brooks Date: Tue May 29 17:49:03 2018 New Revision: 334342 URL: https://svnweb.freebsd.org/changeset/base/334342 Log: Correct pointer subtraction in KASSERT(). The assertion would never fire without truly spectacular future programming errors. Reported by: Coverity CID:

svn commit: r334345 - head/lib/libpmc

Author: mmacy Date: Tue May 29 18:26:12 2018 New Revision: 334345 URL: https://svnweb.freebsd.org/changeset/base/334345 Log: libpmc: free allocated string on return from pmc_allocate Reported by: Coverity CID: 1391359 Modified: head/lib/libpmc/libpmc.c Modified:

Re: svn commit: r334347 - head/lib/libpmc

On 05/29/2018 14:07, Matt Macy wrote: > if (pmc_pmu_pmcallocate(ctrname, _config) == 0) { > - if (PMC_CALL(PMCALLOCATE, _config) < 0) > - return (errno); > - free(spec_copy); > + if (PMC_CALL(PMCALLOCATE, _config) < 0) { > +

svn commit: r334343 - head/sys/net

Author: mmacy Date: Tue May 29 18:03:43 2018 New Revision: 334343 URL: https://svnweb.freebsd.org/changeset/base/334343 Log: iflib: hold context lock across detach for drivers that need it Modified: head/sys/net/iflib.c Modified: head/sys/net/iflib.c

svn commit: r334344 - in head/sys: dev/hwpmc kern sys

Author: mmacy Date: Tue May 29 18:03:48 2018 New Revision: 334344 URL: https://svnweb.freebsd.org/changeset/base/334344 Log: hwpmc: don't enter epoch section across mmap hook Modified: head/sys/dev/hwpmc/hwpmc_mod.c head/sys/kern/vfs_vnops.c head/sys/sys/pmckern.h Modified:

svn commit: r334349 - head/lib/libpmc

Author: mmacy Date: Tue May 29 20:09:35 2018 New Revision: 334349 URL: https://svnweb.freebsd.org/changeset/base/334349 Log: libpmc: don't return -1 on success in pmc_allocate Modified: head/lib/libpmc/libpmc.c Modified: head/lib/libpmc/libpmc.c

svn commit: r334341 - head/sys/dev/fdt

Author: andrew Date: Tue May 29 17:44:40 2018 New Revision: 334341 URL: https://svnweb.freebsd.org/changeset/base/334341 Log: Increase the number of fdt memory regions we support to 16. Some SoCs have many excluded regions causing a buffer overflow in the early boot code if this value is

Re: svn commit: r334345 - head/lib/libpmc

On 05/29/2018 13:26, Matt Macy wrote: > if (pmc_pmu_pmcallocate(ctrname, _config) == 0) { > if (PMC_CALL(PMCALLOCATE, _config) < 0) > return (errno); ^^ spec_copy is still leaked here. > + free(spec_copy); >

svn commit: r334347 - head/lib/libpmc

Author: mmacy Date: Tue May 29 19:07:00 2018 New Revision: 334347 URL: https://svnweb.freebsd.org/changeset/base/334347 Log: libpmc: don't leak string in error case either Reported by: vangyzen@ Modified: head/lib/libpmc/libpmc.c Modified: head/lib/libpmc/libpmc.c

svn commit: r334346 - head/lib/libpmc

Author: mmacy Date: Tue May 29 18:30:37 2018 New Revision: 334346 URL: https://svnweb.freebsd.org/changeset/base/334346 Log: libpmc: remove fixed counter diagnostic Modified: head/lib/libpmc/libpmc_pmu_util.c (contents, props changed) Modified: head/lib/libpmc/libpmc_pmu_util.c

svn commit: r334348 - in head/sys: amd64/linux amd64/linux32 i386/linux

Author: brooks Date: Tue May 29 20:03:24 2018 New Revision: 334348 URL: https://svnweb.freebsd.org/changeset/base/334348 Log: Correct pointer subtraction in KASSERT(). The assertion would never fire without truly spectacular future programming errors. Reported by: Coverity CID:

svn commit: r334351 - head/lib/libpmc

Author: vangyzen Date: Tue May 29 20:30:46 2018 New Revision: 334351 URL: https://svnweb.freebsd.org/changeset/base/334351 Log: pmc_annotate: adhere to the API If the 'mode' parameter was invalid, pmc_annotate() would return EINVAL instead of setting errno and returning -1.

svn commit: r334358 - in head/sys: kern net sys

Author: shurd Date: Tue May 29 21:56:39 2018 New Revision: 334358 URL: https://svnweb.freebsd.org/changeset/base/334358 Log: iflib: mark irq allocation name parameter as constant The *name parameter passed to iflib_irq_alloc_generic and iflib_softirq_alloc_generic is never modified. Many

svn commit: r334360 - in head: etc/mtree tests/sys tests/sys/audit

Author: asomers Date: Tue May 29 23:08:33 2018 New Revision: 334360 URL: https://svnweb.freebsd.org/changeset/base/334360 Log: Add initial set of tests for audit(4) This change includes the framework for testing the auditability of various syscalls, and includes changes for the first 12.

Re: svn commit: r334362 - head/tests/sys

Thanks Ed. I'll try to figure out the root cause for this. On Tue, May 29, 2018 at 6:36 PM, Ed Maste wrote: > Author: emaste > Date: Wed May 30 00:36:58 2018 > New Revision: 334362 > URL: https://svnweb.freebsd.org/changeset/base/334362 > > Log: > Temporarily disconnect audit tests > >

svn commit: r334363 - head/usr.bin/elfdump

Author: emaste Date: Wed May 30 01:16:50 2018 New Revision: 334363 URL: https://svnweb.freebsd.org/changeset/base/334363 Log: elfdump: chase ABI tag note name change from r232832 r232832 changed the ABI tag note name from .note.ABI-tag to .note.tag. Follow suit in elfdump. Elfdump's

svn commit: r334354 - head/lib/libpmc

Author: mmacy Date: Tue May 29 21:02:13 2018 New Revision: 334354 URL: https://svnweb.freebsd.org/changeset/base/334354 Log: libpmc: silence scan-build warnings Modified: head/lib/libpmc/libpmc_pmu_util.c (contents, props changed) head/lib/libpmc/pmclog.c Modified:

svn commit: r334359 - head/cddl/usr.sbin/dwatch

Author: dteske Date: Tue May 29 22:36:37 2018 New Revision: 334359 URL: https://svnweb.freebsd.org/changeset/base/334359 Log: dwatch(1): Fix "-t test" for post-processing profiles Profiles that perform post-processing of the DTrace output were dropping the "-t test" option on the floor.

svn commit: r334356 - head/sys/kern

Author: glebius Date: Tue May 29 21:45:15 2018 New Revision: 334356 URL: https://svnweb.freebsd.org/changeset/base/334356 Log: Revert second chunk of r333860. The warning from gcc is false positive. The npages won't be ever used in no space case. Modified: head/sys/kern/kern_sendfile.c

svn commit: r334357 - head/sbin/dumpon

Author: sbruno Date: Tue May 29 21:52:13 2018 New Revision: 334357 URL: https://svnweb.freebsd.org/changeset/base/334357 Log: dumpon(8) - fix the WITHOUT_CRYPTO buildworld case. Its rare, but some of us do build this way. Sponsored by: Limelight Networks Modified:

svn commit: r334361 - head/usr.sbin/pmc

Author: mmacy Date: Wed May 30 00:06:17 2018 New Revision: 334361 URL: https://svnweb.freebsd.org/changeset/base/334361 Log: pmc: don't break build with format issues Modified: head/usr.sbin/pmc/Makefile Modified: head/usr.sbin/pmc/Makefile

svn commit: r334350 - in head/usr.sbin: . pmc

Author: mmacy Date: Tue May 29 20:28:34 2018 New Revision: 334350 URL: https://svnweb.freebsd.org/changeset/base/334350 Log: pmc: Add new sub-command structured "pmc" utility This will manage pmc functionality with a more manageable structure of subcommands rather than the gradually

svn commit: r334353 - head/usr.sbin/pmc

Author: mmacy Date: Tue May 29 21:02:08 2018 New Revision: 334353 URL: https://svnweb.freebsd.org/changeset/base/334353 Log: pmc: silence scan-build warnings Modified: head/usr.sbin/pmc/cmd_pmc_stat.c (contents, props changed) Modified: head/usr.sbin/pmc/cmd_pmc_stat.c

svn commit: r334362 - head/tests/sys

Author: emaste Date: Wed May 30 00:36:58 2018 New Revision: 334362 URL: https://svnweb.freebsd.org/changeset/base/334362 Log: Temporarily disconnect audit tests Audit tests added in r334360 broke the build on a number of archs. Remove the subdir from the top level tests/sys/Makefile

Re: svn commit: r334360 - in head: etc/mtree tests/sys tests/sys/audit

On 29 May 2018 at 19:08, Alan Somers wrote: > Author: asomers > Date: Tue May 29 23:08:33 2018 > New Revision: 334360 > URL: https://svnweb.freebsd.org/changeset/base/334360 > > Log: > Add initial set of tests for audit(4) This has broken the build on many architectures, e.g. mips:

Re: svn commit: r334314 - head/sys/net

On 05/29/18 09:14, Matt Macy wrote: Author: mmacy Date: Tue May 29 07:14:57 2018 New Revision: 334314 URL: https://svnweb.freebsd.org/changeset/base/334314 Log: rt_getifa_fib: don't use ifa but info->rti_ifa Reported by: kp Modified: head/sys/net/route.c Modified:

svn commit: r334314 - head/sys/net

Author: mmacy Date: Tue May 29 07:14:57 2018 New Revision: 334314 URL: https://svnweb.freebsd.org/changeset/base/334314 Log: rt_getifa_fib: don't use ifa but info->rti_ifa Reported by: kp Modified: head/sys/net/route.c Modified: head/sys/net/route.c

svn commit: r334316 - head/sys/teken

Author: dumbbell Date: Tue May 29 08:41:44 2018 New Revision: 334316 URL: https://svnweb.freebsd.org/changeset/base/334316 Log: teken: Fix `sequences` header which was crossing the 80-col boundary Also, the commented line's columns for `DECID` were not re-aligned in r334302.

svn commit: r334373 - head

Author: imp Date: Wed May 30 05:00:30 2018 New Revision: 334373 URL: https://svnweb.freebsd.org/changeset/base/334373 Log: We've removed the special case code for upgrading from FreeBSD 9 so remove the special warning. It's in svn if we need it. Modified: head/UPDATING Modified:

svn commit: r334365 - head/sys/dev/pci

Author: jhibbits Date: Wed May 30 02:41:47 2018 New Revision: 334365 URL: https://svnweb.freebsd.org/changeset/base/334365 Log: Restrict PCIe maxslots to 0, instead of PCI_SLOTMAX Summary: PCIe only permits 1 device on an endpoint, so some devices ignore the device part of B:D:F

svn commit: r334366 - head/sys/powerpc/powernv

Author: jhibbits Date: Wed May 30 02:47:23 2018 New Revision: 334366 URL: https://svnweb.freebsd.org/changeset/base/334366 Log: Cache the phandle of the PCI node in opal_pci_attach Simple cleanup, no functional change. This is related to the fixups needed for POWER9 support. Modified:

svn commit: r334367 - head/sys/powerpc/powernv

Author: jhibbits Date: Wed May 30 03:00:57 2018 New Revision: 334367 URL: https://svnweb.freebsd.org/changeset/base/334367 Log: Make opal_pci driver work with POWER9 Summary: Coupled with r334365, this makes PCI work on POWER9. There is still more to do to fully exploit the hardware

svn commit: r334368 - in head/sys: kern sys

Author: mmacy Date: Wed May 30 03:39:57 2018 New Revision: 334368 URL: https://svnweb.freebsd.org/changeset/base/334368 Log: epoch(9): make epoch closer to style(9) Modified: head/sys/kern/subr_epoch.c head/sys/sys/epoch.h Modified: head/sys/kern/subr_epoch.c

svn commit: r334369 - head/lib/libpmc

Author: mmacy Date: Wed May 30 03:40:02 2018 New Revision: 334369 URL: https://svnweb.freebsd.org/changeset/base/334369 Log: libpmc: bring pmu_util closer in line with style(9) Modified: head/lib/libpmc/libpmc_pmu_util.c (contents, props changed) Modified:

svn commit: r334370 - head/sys/cddl/dev/dtrace/powerpc

Author: jhibbits Date: Wed May 30 03:48:27 2018 New Revision: 334370 URL: https://svnweb.freebsd.org/changeset/base/334370 Log: Protect dtrace_getpcstack() from a NULL stack pointer in a trap frame Found when trying to use lockstat on a POWER9, the stack pointer (r1) could be NULL, and

Re: svn commit: r334367 - head/sys/powerpc/powernv

On Tue, May 29, 2018 at 10:00 PM, Justin Hibbits wrote: > Author: jhibbits > Date: Wed May 30 03:00:57 2018 > New Revision: 334367 > URL: https://svnweb.freebsd.org/changeset/base/334367 > > Log: > Make opal_pci driver work with POWER9 > > Summary: > Coupled with r334365, this makes PCI

svn commit: r334371 - head/lib/libpmc

Author: mmacy Date: Wed May 30 04:12:51 2018 New Revision: 334371 URL: https://svnweb.freebsd.org/changeset/base/334371 Log: libpmc: squelch valgrind warnings Modified: head/lib/libpmc/libpmc.c Modified: head/lib/libpmc/libpmc.c

svn commit: r334372 - head/sys/dev/vt/hw/ofwfb

Author: nwhitehorn Date: Wed May 30 04:15:33 2018 New Revision: 334372 URL: https://svnweb.freebsd.org/changeset/base/334372 Log: If linebytes property is missing from the graphics device, assume no overscan and synthesize it from the display depth and screen width. This may not be right,

svn commit: r334364 - head/sys/conf

Author: rpokala Date: Wed May 30 02:26:36 2018 New Revision: 334364 URL: https://svnweb.freebsd.org/changeset/base/334364 Log: Remove the mlx5 driver from LINT kernel config for 32-bit PPC The mlx5 driver requires 64-bit atomics, which are not supported on 32-bit PPC. Exclude that driver

svn commit: r334318 - head/contrib/tcpdump

Author: slavash Date: Tue May 29 10:29:04 2018 New Revision: 334318 URL: https://svnweb.freebsd.org/changeset/base/334318 Log: MFV r333668: Vendor import two upstream commits: c1bb8784abd3ca978e376b0d10e324db0491237b 9c4af7213cc2543a1f5586d8f2c19f86aa0cbe72 When using tcpdump -I

svn commit: r334317 - head/lib/libfetch

Author: des Date: Tue May 29 10:28:20 2018 New Revision: 334317 URL: https://svnweb.freebsd.org/changeset/base/334317 Log: Use __VA_ARGS__ to simplify the DEBUG macro. MFC after:3 weeks Modified: head/lib/libfetch/common.c head/lib/libfetch/common.h head/lib/libfetch/fetch.c

svn commit: r334319 - head/lib/libfetch

Author: des Date: Tue May 29 10:29:43 2018 New Revision: 334319 URL: https://svnweb.freebsd.org/changeset/base/334319 Log: Fix a few (but far from all) style issues. MFC after:3 weeks Modified: head/lib/libfetch/http.c Modified: head/lib/libfetch/http.c

svn commit: r334320 - in head/sys: cddl/compat/opensolaris/kern cddl/compat/opensolaris/sys i386/include

Author: hselasky Date: Tue May 29 11:59:02 2018 New Revision: 334320 URL: https://svnweb.freebsd.org/changeset/base/334320 Log: Implement atomic_add_64() and atomic_subtract_64() for the i386 target. While at it add missing _acq_ and _rel_ variants for 64-bit atomic operations under

Re: svn commit: r334320 - in head/sys: cddl/compat/opensolaris/kern cddl/compat/opensolaris/sys i386/include

On 05/29/18 15:02, Cy Schubert wrote: In message <201805291159.w4tbx3e5085...@repo.freebsd.org>, Hans Petter Selasky writes: Author: hselasky Date: Tue May 29 11:59:02 2018 New Revision: 334320 URL: https://svnweb.freebsd.org/changeset/base/334320 Log: Implement atomic_add_64() and

Re: svn commit: r334320 - in head/sys: cddl/compat/opensolaris/kern cddl/compat/opensolaris/sys i386/include

On 05/29/18 15:10, Hans Petter Selasky wrote: Hi Hans, This broke in lib32 on an amd64 system. --- cddl/lib/libnvpair__L --- In file included from /opt/src/svn-current/sys/cddl/contrib/opensolaris/ common/nvpair/opensolaris_fnvpair.c:29: In file included from

svn commit: r334324 - in head/sys: netinet netinet6

Author: ae Date: Tue May 29 12:32:08 2018 New Revision: 334324 URL: https://svnweb.freebsd.org/changeset/base/334324 Log: Remove empty encap_init() function. MFC after:2 weeks Modified: head/sys/netinet/in_proto.c head/sys/netinet/ip_encap.c head/sys/netinet/ip_encap.h

svn commit: r334328 - in head/sys/cddl/compat/opensolaris: kern sys

Author: hselasky Date: Tue May 29 13:43:16 2018 New Revision: 334328 URL: https://svnweb.freebsd.org/changeset/base/334328 Log: Fix 32-bit buildworld for i386 after r334320. The 64-bit atomics defined for i386 are currently only available in the kernel space. Found by: cy@ MFC

Re: svn commit: r334320 - in head/sys: cddl/compat/opensolaris/kern cddl/compat/opensolaris/sys i386/include

In message <201805291159.w4tbx3e5085...@repo.freebsd.org>, Hans Petter Selasky writes: > Author: hselasky > Date: Tue May 29 11:59:02 2018 > New Revision: 334320 > URL: https://svnweb.freebsd.org/changeset/base/334320 > > Log: > Implement atomic_add_64() and atomic_subtract_64() for the i386

svn commit: r334326 - head/lib/libfetch

Author: des Date: Tue May 29 13:07:36 2018 New Revision: 334326 URL: https://svnweb.freebsd.org/changeset/base/334326 Log: Fix an inverted conditional in the netrc code, which would ignore the value of $HOME and always use the home directory from the passwd database, unless $HOME was unset,

Re: svn commit: r334320 - in head/sys: cddl/compat/opensolaris/kern cddl/compat/opensolaris/sys i386/include

In message , Hans Petter Sela sky writes: > On 05/29/18 15:10, Hans Petter Selasky wrote: > >> Hi Hans, > >> > >> This broke in lib32 on an amd64 system. > >> > >> --- cddl/lib/libnvpair__L --- > >> In file included from /opt/src/svn-current/sys/cddl/contrib/opensolaris/ > >>

svn commit: r334334 - head/sys/dev/usb

Author: eadler Date: Tue May 29 14:08:06 2018 New Revision: 334334 URL: https://svnweb.freebsd.org/changeset/base/334334 Log: [usbdevs] add misig letters Modified: head/sys/dev/usb/usbdevs Modified: head/sys/dev/usb/usbdevs

svn commit: r334329 - head/sys/arm64/arm64

Author: andrew Date: Tue May 29 13:52:25 2018 New Revision: 334329 URL: https://svnweb.freebsd.org/changeset/base/334329 Log: On ThunderX2 we need to be careful to only map the memory the firmware lists in the EFI memory map. As such we need to reduce the mappings to restrict them to not be

Re: svn commit: r334320 - in head/sys: cddl/compat/opensolaris/kern cddl/compat/opensolaris/sys i386/include

On 29 May 2018 at 09:10, Hans Petter Selasky wrote: > > I only tested buildkernel i386 LINT + GENERIC with this change. I will have > a look ASAP. On IRC the suggestion was made to run buildworld for any header change, and I think this seems like a reasonable standard. Our full buildworld times

svn commit: r334331 - head/sys/dev/usb

Author: eadler Date: Tue May 29 14:04:50 2018 New Revision: 334331 URL: https://svnweb.freebsd.org/changeset/base/334331 Log: [usbdevs] Add USB product ID for Philips SPC N900 CCD Webcam PR: 228488 Submitted by: "Harald Schmalzbauer" Modified: head/sys/dev/usb/usbdevs

svn commit: r334333 - head/sys/dev/usb

Author: eadler Date: Tue May 29 14:04:58 2018 New Revision: 334333 URL: https://svnweb.freebsd.org/changeset/base/334333 Log: [usbdevs] add several intel product identifiers Modified: head/sys/dev/usb/usbdevs Modified: head/sys/dev/usb/usbdevs

Re: svn commit: r334320 - in head/sys: cddl/compat/opensolaris/kern cddl/compat/opensolaris/sys i386/include

On 05/29/18 16:00, Ed Maste wrote: On IRC the suggestion was made to run buildworld for any header change, and I think this seems like a reasonable standard. Our full buildworld times are admittedly quite long, so if you have a suitably up-to-date toolchain on the build host you can skip

svn commit: r334336 - head/sys/dev/usb

Author: eadler Date: Tue May 29 14:40:50 2018 New Revision: 334336 URL: https://svnweb.freebsd.org/changeset/base/334336 Log: [usbdevs] add several GENESYS product ids Add USB product ID for two GENESYS LOGIC ICs, found in DELOCK In-Desk-Hub 61991 PR: 228489 Submitted

svn commit: r334332 - in head: share/man/man4 sys/conf sys/dev/mlx5 sys/dev/mlx5/mlx5_core sys/dev/mlx5/mlx5_en sys/modules/mlx5 sys/modules/mlx5en sys/modules/mlx5ib

Author: hselasky Date: Tue May 29 14:04:57 2018 New Revision: 334332 URL: https://svnweb.freebsd.org/changeset/base/334332 Log: Add support for hardware rate limiting to mlx5en(4). The hardware rate limiting feature is enabled by the RATELIMIT kernel option. Please refer to ifconfig(8)

svn commit: r334335 - head/sys/dev/usb

Author: eadler Date: Tue May 29 14:37:48 2018 New Revision: 334335 URL: https://svnweb.freebsd.org/changeset/base/334335 Log: [usbdevs] add AMD vendor ids - also more fully spell the name of ATI for ATI2 Modified: head/sys/dev/usb/usbdevs Modified: head/sys/dev/usb/usbdevs

svn commit: r334338 - head/sys/x86/x86

Author: avg Date: Tue May 29 16:03:53 2018 New Revision: 334338 URL: https://svnweb.freebsd.org/changeset/base/334338 Log: fix x86 UP build broken by r334204, TSC resynchronization Reported by: bde MFC after:1 week X-MFC with: r334204 Modified: head/sys/x86/x86/tsc.c

svn commit: r334339 - head/sbin/savecore

Author: markj Date: Tue May 29 16:04:53 2018 New Revision: 334339 URL: https://svnweb.freebsd.org/changeset/base/334339 Log: The extension for zstd-compressed files is ".zst". Reported by: manu Modified: head/sbin/savecore/savecore.c Modified: head/sbin/savecore/savecore.c

svn commit: r334340 - in head/sys: dev/uart kern sys x86/acpica

Author: avg Date: Tue May 29 16:16:24 2018 New Revision: 334340 URL: https://svnweb.freebsd.org/changeset/base/334340 Log: add support for console resuming, implement it for uart, use on x86 This change adds a new optional console method cn_resume and a kernel console interface cnresume.

svn commit: r334337 - head/release/amd64

Author: emaste Date: Tue May 29 15:06:13 2018 New Revision: 334337 URL: https://svnweb.freebsd.org/changeset/base/334337 Log: switch amd64 memstick installer images to MBR A good number of BIOSes have trouble booting from GPT in non-UEFI mode. This is commonly reported with Lenovo

Re: svn commit: r334337 - head/release/amd64

On 05/29, Ed Maste wrote: > Author: emaste > Date: Tue May 29 15:06:13 2018 > New Revision: 334337 > URL: https://svnweb.freebsd.org/changeset/base/334337 > > Log: > switch amd64 memstick installer images to MBR > > A good number of BIOSes have trouble booting from GPT in non-UEFI mode. >

Re: svn commit: r334320 - in head/sys: cddl/compat/opensolaris/kern cddl/compat/opensolaris/sys i386/include

On Tue, May 29, 2018 at 8:16 AM, Hans Petter Selasky wrote: > On 05/29/18 16:00, Ed Maste wrote: > >> On IRC the suggestion was made to run buildworld for any header >> change, and I think this seems like a reasonable standard. >> >> Our full buildworld times are admittedly quite long, so if you