svn commit: r228872 - head/sys/mips/cavium

2011-12-24 Thread Oleksandr Tymoshenko
Author: gonzo Date: Sat Dec 24 23:15:25 2011 New Revision: 228872 URL: http://svn.freebsd.org/changeset/base/228872 Log: - Initialize compact_flash_attribute_base_addr from bootinfo structure Modified: head/sys/mips/cavium/octeon_machdep.c Modified: head/sys/mips/cavium/octeon_machdep.c

Re: svn commit: r228857 - in head/usr.bin: . csup

2011-12-24 Thread Steve Kargl
On Sat, Dec 24, 2011 at 01:36:18PM -0800, Doug Barton wrote: > On 12/24/2011 04:16, Marius Strobl wrote: > > On FreeBSD just use the MD5 implementation of libmd rather than that of > > libcrypto so we don't need to relinquish csup when world is built without > > OpenSSL. > > Did you benchmar

svn commit: r228871 - head/sbin/ipfw

2011-12-24 Thread Eitan Adler
Author: eadler (ports committer) Date: Sat Dec 24 22:37:27 2011 New Revision: 228871 URL: http://svn.freebsd.org/changeset/base/228871 Log: - Add fallthrough comment Approved by: pluknet Found with: Coverity Prevent(tm) CID: 10125 Modified: head/sbin/ipfw/main.c Modified

Re: svn commit: r228857 - in head/usr.bin: . csup

2011-12-24 Thread Doug Barton
On 12/24/2011 04:16, Marius Strobl wrote: > On FreeBSD just use the MD5 implementation of libmd rather than that of > libcrypto so we don't need to relinquish csup when world is built without > OpenSSL. Did you benchmark this at all? I agree that keeping csup available absent openssl is a go

Re: svn commit: r228843 - head/contrib/telnet/libtelnet head/crypto/heimdal/appl/telnet/libtelnet head/include head/lib/libc/gen head/lib/libc/iconv head/lib/libc/include head/lib/libc/net head/libexe

2011-12-24 Thread Xin LI
2011/12/24 Edward Tomasz Napierała : > Wiadomość napisana przez Andrey Chernov w dniu 24 gru 2011, o godz. 11:50: >> On Sat, Dec 24, 2011 at 02:45:21AM -0800, Xin LI wrote: >>> On Sat, Dec 24, 2011 at 2:39 AM, Andrey Chernov wrote: On Sat, Dec 24, 2011 at 02:26:20AM -0800, Xin LI wrote: >

svn commit: r228869 - in head: lib/libpmc sys/dev/hwpmc sys/powerpc/aim sys/powerpc/include sys/sys

2011-12-24 Thread Justin Hibbits
Author: jhibbits Date: Sat Dec 24 19:34:52 2011 New Revision: 228869 URL: http://svn.freebsd.org/changeset/base/228869 Log: Implement hwpmc counting PMC support for PowerPC G4+ (MPC745x/MPC744x). Sampling is in progress. Approved by: nwhitehorn (mentor) MFC after:9.0-RELEASE Modif

svn commit: r228868 - head/sys/conf

2011-12-24 Thread Dimitry Andric
Author: dim Date: Sat Dec 24 19:01:31 2011 New Revision: 228868 URL: http://svn.freebsd.org/changeset/base/228868 Log: When building the kernel for amd64 with clang, don't attempt to use the -frename-registers option, as it is not supported. No change for builds with gcc. MFC after:

svn commit: r228867 - head/sys/conf

2011-12-24 Thread Dimitry Andric
Author: dim Date: Sat Dec 24 18:57:42 2011 New Revision: 228867 URL: http://svn.freebsd.org/changeset/base/228867 Log: Make another clang warning, -Wparentheses-equality, non-fatal during kernel builds. All the instances of this warning in our tree are completely harmless, and many people s

svn commit: r228866 - head/sys/netinet6

2011-12-24 Thread John Baldwin
Author: jhb Date: Sat Dec 24 18:11:54 2011 New Revision: 228866 URL: http://svn.freebsd.org/changeset/base/228866 Log: Fix a bug where TAILQ_FIRST(&V_ifnet) was accessed without holding the proper lock. Reviewed by: bz MFC after:1 week Modified: head/sys/netinet6/icmp6.c Modifi

svn commit: r228865 - head/sys/modules/asr

2011-12-24 Thread Dimitry Andric
Author: dim Date: Sat Dec 24 17:54:58 2011 New Revision: 228865 URL: http://svn.freebsd.org/changeset/base/228865 Log: Amend r228781 by also disabling -Warray-bounds warnings for the asr module. MFC after:1 week Modified: head/sys/modules/asr/Makefile Modified: head/sys/modules/as

svn commit: r228864 - head/sys/fs/ntfs

2011-12-24 Thread Kevin Lo
Author: kevlo Date: Sat Dec 24 15:49:52 2011 New Revision: 228864 URL: http://svn.freebsd.org/changeset/base/228864 Log: Discard local array based on return values. Pointed out by: uqs Found with: Coverity Prevent(tm) CID: 10089 Modified: head/sys/fs/ntfs/ntfs_subr.c head/

svn commit: r228863 - head/include

2011-12-24 Thread David Chisnall
Author: theraven Date: Sat Dec 24 15:31:06 2011 New Revision: 228863 URL: http://svn.freebsd.org/changeset/base/228863 Log: ...and actually install it. Approved by: dim (mentor) Modified: head/include/Makefile Modified: head/include/Makefile

svn commit: r228862 - head/include

2011-12-24 Thread David Chisnall
Author: theraven Date: Sat Dec 24 15:17:01 2011 New Revision: 228862 URL: http://svn.freebsd.org/changeset/base/228862 Log: Initial implementation of stdatomic.h. Works (at least in the parts that were tested) with clang and gcc, and more efficiently with clang+a big out-of-tree diff that I

Re: svn commit: r228796 - head/sys/fs/msdosfs

2011-12-24 Thread Kevin Lo
On Thu, 2011-12-22 at 07:39 -0500, John Baldwin wrote: > On Thursday, December 22, 2011 1:31:29 am Kevin Lo wrote: > > Author: kevlo > > Date: Thu Dec 22 06:31:29 2011 > > New Revision: 228796 > > URL: http://svn.freebsd.org/changeset/base/228796 > > > > Log: > > Discarding local array based on

Re: svn commit: r228843 - head/contrib/telnet/libtelnet head/crypto/heimdal/appl/telnet/libtelnet head/include head/lib/libc/gen head/lib/libc/iconv head/lib/libc/include head/lib/libc/net head/libexe

2011-12-24 Thread Edward Tomasz Napierała
Wiadomość napisana przez Andrey Chernov w dniu 24 gru 2011, o godz. 11:50: > On Sat, Dec 24, 2011 at 02:45:21AM -0800, Xin LI wrote: >> On Sat, Dec 24, 2011 at 2:39 AM, Andrey Chernov wrote: >>> On Sat, Dec 24, 2011 at 02:26:20AM -0800, Xin LI wrote: chroot(2) can create legitimate and secure

svn commit: r228861 - head/sys/modules/nve

2011-12-24 Thread Dimitry Andric
Author: dim Date: Sat Dec 24 13:36:28 2011 New Revision: 228861 URL: http://svn.freebsd.org/changeset/base/228861 Log: Set WERROR= for the nve(4) module. This driver gives several warnings with clang, which will probably never be fixed, as it is unmaintained, and superseded by nfe(4).

svn commit: r228860 - head/sys/conf

2011-12-24 Thread Dimitry Andric
Author: dim Date: Sat Dec 24 13:30:15 2011 New Revision: 228860 URL: http://svn.freebsd.org/changeset/base/228860 Log: Make another clang warning, -Wempty-body, non-fatal during kernel builds. All the instances of this warning in our tree are completely harmless. (Most of the empty bodies

svn commit: r228859 - head/sys/sys

2011-12-24 Thread David Chisnall
Author: theraven Date: Sat Dec 24 13:28:49 2011 New Revision: 228859 URL: http://svn.freebsd.org/changeset/base/228859 Log: Some GCC-compatibility definitions. Define clang's feature test pseudomacros to always evaluate to 0 if we are using a compiler that doesn't implement them. This lets

svn commit: r228858 - head/sys/conf

2011-12-24 Thread Marius Strobl
Author: marius Date: Sat Dec 24 12:28:23 2011 New Revision: 228858 URL: http://svn.freebsd.org/changeset/base/228858 Log: Update a comment to reflect reality and explain why we're using the medany code model. Modified: head/sys/conf/kern.mk Modified: head/sys/conf/kern.mk =

svn commit: r228857 - in head/usr.bin: . csup

2011-12-24 Thread Marius Strobl
Author: marius Date: Sat Dec 24 12:16:38 2011 New Revision: 228857 URL: http://svn.freebsd.org/changeset/base/228857 Log: On FreeBSD just use the MD5 implementation of libmd rather than that of libcrypto so we don't need to relinquish csup when world is built without OpenSSL. Modified: he

Re: svn commit: r228843 - head/contrib/telnet/libtelnet head/crypto/heimdal/appl/telnet/libtelnet head/include head/lib/libc/gen head/lib/libc/iconv head/lib/libc/include head/lib/libc/net head/libexe

2011-12-24 Thread Andrey Chernov
On Sat, Dec 24, 2011 at 02:50:45PM +0400, Andrey Chernov wrote: > On Sat, Dec 24, 2011 at 02:45:21AM -0800, Xin LI wrote: > > On Sat, Dec 24, 2011 at 2:39 AM, Andrey Chernov wrote: > > > On Sat, Dec 24, 2011 at 02:26:20AM -0800, Xin LI wrote: > > >> chroot(2) can create legitimate and secure envir

Re: svn commit: r228843 - head/contrib/telnet/libtelnet head/crypto/heimdal/appl/telnet/libtelnet head/include head/lib/libc/gen head/lib/libc/iconv head/lib/libc/include head/lib/libc/net head/libexe

2011-12-24 Thread Andrey Chernov
On Sat, Dec 24, 2011 at 02:45:21AM -0800, Xin LI wrote: > On Sat, Dec 24, 2011 at 2:39 AM, Andrey Chernov wrote: > > On Sat, Dec 24, 2011 at 02:26:20AM -0800, Xin LI wrote: > >> chroot(2) can create legitimate and secure environment where dlopen(2) > >> is safe and necessary. > > > > Yes, so ischr

Re: svn commit: r228843 - head/contrib/telnet/libtelnet head/crypto/heimdal/appl/telnet/libtelnet head/include head/lib/libc/gen head/lib/libc/iconv head/lib/libc/include head/lib/libc/net head/libexe

2011-12-24 Thread Xin LI
On Sat, Dec 24, 2011 at 2:39 AM, Andrey Chernov wrote: > On Sat, Dec 24, 2011 at 02:26:20AM -0800, Xin LI wrote: >> chroot(2) can create legitimate and secure environment where dlopen(2) >> is safe and necessary. > > Yes, so ischroot() check can be used only into that places where libc's > libc_dl

Re: svn commit: r228843 - head/contrib/telnet/libtelnet head/crypto/heimdal/appl/telnet/libtelnet head/include head/lib/libc/gen head/lib/libc/iconv head/lib/libc/include head/lib/libc/net head/libexe

2011-12-24 Thread Andrey Chernov
On Sat, Dec 24, 2011 at 02:26:20AM -0800, Xin LI wrote: > chroot(2) can create legitimate and secure environment where dlopen(2) > is safe and necessary. Yes, so ischroot() check can be used only into that places where libc's libc_dlopen() currently used, i.e. placed into libc_dlopen() itself. -

Re: svn commit: r228843 - head/contrib/telnet/libtelnet head/crypto/heimdal/appl/telnet/libtelnet head/include head/lib/libc/gen head/lib/libc/iconv head/lib/libc/include head/lib/libc/net head/libexe

2011-12-24 Thread Xin LI
On Sat, Dec 24, 2011 at 2:05 AM, Andrey Chernov wrote: > On Fri, Dec 23, 2011 at 07:51:43PM +0200, Kostik Belousov wrote: >> The __FreeBSD_libc_enter_restricted_mode() is, and its name is ugly >> exactly to note the ugly intent. I do not see how the symbol can go > > There must be no ugly intents

Re: svn commit: r228843 - head/contrib/telnet/libtelnet head/crypto/heimdal/appl/telnet/libtelnet head/include head/lib/libc/gen head/lib/libc/iconv head/lib/libc/include head/lib/libc/net head/libexe

2011-12-24 Thread Andrey Chernov
On Fri, Dec 23, 2011 at 07:51:43PM +0200, Kostik Belousov wrote: > The __FreeBSD_libc_enter_restricted_mode() is, and its name is ugly > exactly to note the ugly intent. I do not see how the symbol can go There must be no ugly intents and names. This whole idea just proves yet one our @secteam ug

Re: svn commit: r228843 - head/contrib/telnet/libtelnet head/crypto/heimdal/appl/telnet/libtelnet head/include head/lib/libc/gen head/lib/libc/iconv head/lib/libc/include head/lib/libc/net head/libexe

2011-12-24 Thread Doug Barton
On 12/23/2011 20:22, Xin LI wrote: > On Fri, Dec 23, 2011 at 4:19 PM, Doug Barton wrote: >> On 12/23/2011 10:42, Alexander Kabaev wrote: >>> On Fri, 23 Dec 2011 20:29:59 +0200 >>> Kostik Belousov wrote: >>> On Fri, Dec 23, 2011 at 01:20:34PM -0500, Alexander Kabaev wrote: > On Fri, 23 De