svn commit: r241360 - head/sys/netpfil/pf

2012-10-09 Thread Gleb Smirnoff
Author: glebius Date: Mon Oct 8 23:02:32 2012 New Revision: 241360 URL: http://svn.freebsd.org/changeset/base/241360 Log: Any pfil(9) hooks should be called with already set VNET context. Reviewed by: bz Modified: head/sys/netpfil/pf/pf_ioctl.c Modified:

svn commit: r241361 - head/sys/boot/forth

2012-10-09 Thread Devin Teske
Author: dteske Date: Mon Oct 8 23:02:35 2012 New Revision: 241361 URL: http://svn.freebsd.org/changeset/base/241361 Log: Add an echo to say we're Booting... when the overloaded boot Ficl word is executed to better differentiate between loader-specific errors and kernel- specific errors (if

svn commit: r241359 - head/sys/netpfil/ipfw

2012-10-09 Thread Gleb Smirnoff
Author: glebius Date: Mon Oct 8 22:58:28 2012 New Revision: 241359 URL: http://svn.freebsd.org/changeset/base/241359 Log: Catch up with r241245 and do not return packet back in host byte order. Modified: head/sys/netpfil/ipfw/ip_fw_pfil.c Modified: head/sys/netpfil/ipfw/ip_fw_pfil.c

svn commit: r241369 - in head/sys: dev/arcmsr netgraph/netflow netpfil/ipfw

2012-10-09 Thread Kevin Lo
Author: kevlo Date: Tue Oct 9 06:15:16 2012 New Revision: 241369 URL: http://svn.freebsd.org/changeset/base/241369 Log: Fix typo: s/unknow/unknown Modified: head/sys/dev/arcmsr/arcmsr.c head/sys/netgraph/netflow/ng_netflow.c head/sys/netpfil/ipfw/ip_dn_glue.c Modified:

svn commit: r241367 - head/sys/boot/forth

2012-10-09 Thread Devin Teske
Author: dteske Date: Tue Oct 9 03:54:53 2012 New Revision: 241367 URL: http://svn.freebsd.org/changeset/base/241367 Log: Fix a typo (s/prefix/suffix/) and comment. NOTE: This is in an unused portion of the menu framework. Reviewed by: eadler, adrian (co-mentor) Approved by:

svn commit: r241365 - head/sys/boot/forth

2012-10-09 Thread Devin Teske
Author: dteske Date: Tue Oct 9 03:11:15 2012 New Revision: 241365 URL: http://svn.freebsd.org/changeset/base/241365 Log: Fix an oversight that cyclic menu items actually are zero-based and can accommodate 10 different states. Reviewed by: eadler, adrian (co-mentor) Approved by:

svn commit: r241371 - in head/sys: amd64/amd64 amd64/include i386/i386 i386/include pc98/pc98 sparc64/include sparc64/sparc64 x86/x86

2012-10-09 Thread Attilio Rao
Author: attilio Date: Tue Oct 9 12:22:43 2012 New Revision: 241371 URL: http://svn.freebsd.org/changeset/base/241371 Log: Reverts r234074,234105,234564,234723,234989,235231-235232 and part of r234247. Use, instead, the static intializer introduced in r239923 for x86 and sparc64

svn commit: r241373 - head/lib/libc/stdlib

2012-10-09 Thread Eitan Adler
Author: eadler Date: Tue Oct 9 14:25:14 2012 New Revision: 241373 URL: http://svn.freebsd.org/changeset/base/241373 Log: Remove undefined behavior from sranddev() and srandomdev(). This doesn't actually work with any modern C compiler: In particular, both clang and modern gcc

svn commit: r241374 - in head/sys: amd64/include gnu/fs/xfs/FreeBSD i386/include kern mips/include pc98/include sparc64/include sys x86/include

2012-10-09 Thread Attilio Rao
Author: attilio Date: Tue Oct 9 14:32:30 2012 New Revision: 241374 URL: http://svn.freebsd.org/changeset/base/241374 Log: Add an unified macro to deny ability from the compiler to reorder instruction loads/stores at its will. The macro __compiler_membar() is currently supported for both

Re: svn commit: r241370 - in head: share/examples/kld/dyn_sysctl share/examples/kld/firmware/fwconsumer share/man/man9 sys/amd64/linux32 sys/cddl/contrib/opensolaris/uts/common/fs/zfs sys/compat/svr4

2012-10-09 Thread Rui Paulo
On 9 Oct 2012, at 01:27, Kevin Lo ke...@freebsd.org wrote: Author: kevlo Date: Tue Oct 9 08:27:40 2012 New Revision: 241370 URL: http://svn.freebsd.org/changeset/base/241370 Log: Prefer NULL over 0 for pointers Very dubious benefit and no one review this...? Did you even check if the

Re: svn commit: r241373 - head/lib/libc/stdlib

2012-10-09 Thread Andrey Chernov
Do you check assembler output for _both_ cases? In my testing clang and gcc xor's 'junk' properly in case it have 'volatile' keyword (as in srandomdev()) and elide it without 'volatile'. IMHO this change should be backed out for srandomdev() and adding 'volatile' for sranddev() instead. On

svn commit: r241375 - head/sys/dev/sound/pci/hda

2012-10-09 Thread Alexander Motin
Author: mav Date: Tue Oct 9 17:06:31 2012 New Revision: 241375 URL: http://svn.freebsd.org/changeset/base/241375 Log: Cast vendor-specific spell on VIA VT1818S codecs alike to VT1708S to make analog input loopback and dual-stream playback work by enabling signal mixing by nid 22, as it

Re: svn commit: r241373 - head/lib/libc/stdlib

2012-10-09 Thread David Chisnall
On 9 Oct 2012, at 17:33, Andrey Chernov wrote: Do you check assembler output for _both_ cases? In my testing clang and gcc xor's 'junk' properly in case it have 'volatile' keyword (as in srandomdev()) and elide it without 'volatile'. IMHO this change should be backed out for srandomdev() and

Re: svn commit: r241373 - head/lib/libc/stdlib

2012-10-09 Thread mdf
On Tue, Oct 9, 2012 at 10:16 AM, David Chisnall thera...@freebsd.org wrote: On 9 Oct 2012, at 17:33, Andrey Chernov wrote: Do you check assembler output for _both_ cases? In my testing clang and gcc xor's 'junk' properly in case it have 'volatile' keyword (as in srandomdev()) and elide it

Re: svn commit: r241373 - head/lib/libc/stdlib

2012-10-09 Thread Eitan Adler
On 9 October 2012 12:33, Andrey Chernov a...@freebsd.org wrote: Do you check assembler output for _both_ cases? Yes. In my testing clang and gcc xor's 'junk' properly in case it have 'volatile' keyword (as in srandomdev()) and elide it without 'volatile'. volatile is still undefined: see

Re: svn commit: r241373 - head/lib/libc/stdlib

2012-10-09 Thread Eitan Adler
On 9 October 2012 13:27, m...@freebsd.org wrote: The original behavior can be recovered by using inline assembly to fetch the value from a register into a local C variable; this would at least not rely on undefined behavior. But I agree it's of dubious value anyways. I proposed this (with a

Re: svn commit: r241373 - head/lib/libc/stdlib

2012-10-09 Thread Eitan Adler
On 9 October 2012 13:16, David Chisnall thera...@freebsd.org wrote: On 9 Oct 2012, at 17:33, Andrey Chernov wrote: Do you check assembler output for _both_ cases? In my testing clang and gcc xor's 'junk' properly in case it have 'volatile' keyword (as in srandomdev()) and elide it without

Re: svn commit: r241373 - head/lib/libc/stdlib

2012-10-09 Thread Andrey Chernov
On 09.10.2012 21:47, Eitan Adler wrote: On 9 October 2012 12:33, Andrey Chernov a...@freebsd.org wrote: Do you check assembler output for _both_ cases? Yes. ... http://blog.eitanadler.com/2012/10/reduced-entropy-in-rand-and-random.html At this URL I see only already known buggy assembler

Re: svn commit: r241373 - head/lib/libc/stdlib

2012-10-09 Thread Eitan Adler
On 9 October 2012 14:24, Andrey Chernov a...@freebsd.org wrote: I don't have ISO9899 nearby, could you directly quote mentioned sections, please? Accesses to volatile object (a) produce side effects (b) have implementation defined values. A more careful re-reading of the relevant section leads

Re: svn commit: r241373 - head/lib/libc/stdlib

2012-10-09 Thread Steve Kargl
On Tue, Oct 09, 2012 at 04:23:59PM -0400, Eitan Adler wrote: On 9 October 2012 14:24, Andrey Chernov a...@freebsd.org wrote: I don't have ISO9899 nearby, could you directly quote mentioned sections, please? Accesses to volatile object (a) produce side effects (b) have implementation

Re: svn commit: r241373 - head/lib/libc/stdlib

2012-10-09 Thread Eitan Adler
On 9 October 2012 17:25, Steve Kargl s...@troutmask.apl.washington.edu wrote: ... yes, I was misreading the text. Clang has no way of determining if 'a' is initialized or not. If David is correct that 'junk' is optimized out by clang/llvm, then it seems that clang violates footnote 116. Yes,

Re: svn commit: r241373 - head/lib/libc/stdlib

2012-10-09 Thread Eitan Adler
On 9 October 2012 18:06, Eitan Adler ead...@freebsd.org wrote: On 9 October 2012 17:25, Steve Kargl s...@troutmask.apl.washington.edu wrote: ... yes, I was misreading the text. Clang has no way of determining if 'a' is initialized or not. If David is correct that 'junk' is optimized out by

Re: svn commit: r241373 - head/lib/libc/stdlib

2012-10-09 Thread Steve Kargl
On Tue, Oct 09, 2012 at 06:06:55PM -0400, Eitan Adler wrote: On 9 October 2012 17:25, Steve Kargl s...@troutmask.apl.washington.edu wrote: ... yes, I was misreading the text. Clang has no way of determining if 'a' is initialized or not. If David is correct that 'junk' is optimized out

svn commit: r241386 - head/sys/dev/acpica

2012-10-09 Thread Neel Natu
Author: neel Date: Wed Oct 10 00:06:31 2012 New Revision: 241386 URL: http://svn.freebsd.org/changeset/base/241386 Log: Grab the softc from the ACPI host-pci bridge device instead of from the pci endpoint device. Reviewed by: jhb Modified: head/sys/dev/acpica/acpi_pcib_acpi.c

svn commit: r241388 - head/sys/dev/bge

2012-10-09 Thread Pyun YongHyeon
Author: yongari Date: Wed Oct 10 01:24:02 2012 New Revision: 241388 URL: http://svn.freebsd.org/changeset/base/241388 Log: If the maximum payload size is 256 bytes or more, set the DMA write water mark to 256 bytes. Otherwise controller will encounter DMA write under run errors and would

svn commit: r241391 - head/sys/dev/bge

2012-10-09 Thread Pyun YongHyeon
Author: yongari Date: Wed Oct 10 02:35:10 2012 New Revision: 241391 URL: http://svn.freebsd.org/changeset/base/241391 Log: Do not force PCIe 1.0a mode in device reset on BCM5717 and newer controllers. BCM5785 does not require PCI 1.0a mode as well during reset. Modified:

svn commit: r241393 - head/sys/dev/bge

2012-10-09 Thread Pyun YongHyeon
Author: yongari Date: Wed Oct 10 05:43:04 2012 New Revision: 241393 URL: http://svn.freebsd.org/changeset/base/241393 Log: Remove unnecessary delay. I don't see any comments in data sheet that requires 10ms delay after device reset. Because that code was there from day 1, I guess it was