svn commit: r309136 - head/sys/dev/hyperv/vmbus

Author: sephe Date: Fri Nov 25 07:41:42 2016 New Revision: 309136 URL: https://svnweb.freebsd.org/changeset/base/309136 Log: hyperv/vmbus: Don't free the bufring if its GPADL can't be disconnected. MFC after:1 week Sponsored by: Microsoft Differential Revision:

svn commit: r309135 - in head/sys/dev/hyperv: include vmbus

Author: sephe Date: Fri Nov 25 07:24:11 2016 New Revision: 309135 URL: https://svnweb.freebsd.org/changeset/base/309135 Log: hyperv/vmbus: Return EISCONN if the bufring GPADL can't be disconnected. So that the callers of vmbus_chan_open_br() could handle the passed in bufring memory

svn commit: r309134 - head/sys/dev/hyperv/vmbus

Author: sephe Date: Fri Nov 25 07:03:45 2016 New Revision: 309134 URL: https://svnweb.freebsd.org/changeset/base/309134 Log: hyperv/vmbus: No stranded bufring GPADL is allowed. MFC after:1 week Sponsored by: Microsoft Differential Revision:https://reviews.freebsd.org/D8568

svn commit: r309133 - head/sys/dev/hyperv/vmbus

Author: sephe Date: Fri Nov 25 06:48:53 2016 New Revision: 309133 URL: https://svnweb.freebsd.org/changeset/base/309133 Log: hyperv/vmbus: GPADL disconnect error on a revoked channel is benign. MFC after:1 week Sponsored by: Microsoft Differential Revision:

svn commit: r309132 - head/sys/dev/hyperv/vmbus

Author: sephe Date: Fri Nov 25 06:12:18 2016 New Revision: 309132 URL: https://svnweb.freebsd.org/changeset/base/309132 Log: hyperv/vmbus: Don't close unopened channels. MFC after:1 week Sponsored by: Microsoft Differential Revision:https://reviews.freebsd.org/D8566

svn commit: r309131 - head/sys/dev/hyperv/vmbus

Author: sephe Date: Fri Nov 25 06:01:45 2016 New Revision: 309131 URL: https://svnweb.freebsd.org/changeset/base/309131 Log: hyperv/vmbus: Fix sysctl tree leakage, if channel open fails. MFC after:1 week Sponsored by: Microsoft Differential Revision:

svn commit: r309129 - head/sys/dev/hyperv/vmbus

Author: sephe Date: Fri Nov 25 05:46:15 2016 New Revision: 309129 URL: https://svnweb.freebsd.org/changeset/base/309129 Log: hyperv/vmbus: Minor style changes. MFC after:1 week Sponsored by: Microsoft Differential Revision:https://reviews.freebsd.org/D8564 Modified:

svn commit: r309128 - head/sys/dev/hyperv/vmbus

Author: sephe Date: Fri Nov 25 05:35:29 2016 New Revision: 309128 URL: https://svnweb.freebsd.org/changeset/base/309128 Log: hyperv/vmbus: Commit the GPADL id only after the connection succeeds. Minor style change. MFC after:1 week Sponsored by: Microsoft Differential

Re: svn commit: r309124 - in head: . contrib/compiler-rt contrib/compiler-rt/include/sanitizer contrib/compiler-rt/lib/asan contrib/compiler-rt/lib/builtins contrib/compiler-rt/lib/builtins/arm contri

This is huge, and a long time coming! Thanks all! -Ravi (rpokala@) -Original Message- > From: on behalf of Dimitry Andric > > Date: 2016-11-24, Thursday at 14:54 > To: , , >

svn commit: r309127 - in head/sys/dev/hyperv: pcib vmbus

Author: dexuan Date: Fri Nov 25 04:35:40 2016 New Revision: 309127 URL: https://svnweb.freebsd.org/changeset/base/309127 Log: hyperv/vmbus,pcib: unbreak build in case NEW_PCIB is undefined vmbus_pcib requires NEW_PCIB, but in case that's not defined, we at least shouldn't break build.

Re: svn commit: r308942 - in head/sys/modules: . bytgpio

> On Nov 24, 2016, at 11:46 AM, Ed Maste wrote: > > On 21 November 2016 at 14:47, Oleksandr Tymoshenko wrote: >> Author: gonzo >> Date: Mon Nov 21 19:47:37 2016 >> New Revision: 308942 >> URL: https://svnweb.freebsd.org/changeset/base/308942 >> >> Log:

svn commit: r309126 - head/usr.bin/clang/lld

Author: emaste Date: Fri Nov 25 01:24:35 2016 New Revision: 309126 URL: https://svnweb.freebsd.org/changeset/base/309126 Log: Correct lld llvm-tblgen dependency file name Modified: head/usr.bin/clang/lld/Makefile Modified: head/usr.bin/clang/lld/Makefile

Re: svn commit: r308942 - in head/sys/modules: . bytgpio

On Thu, Nov 24, 2016 at 12:46 PM, Ed Maste wrote: > On 21 November 2016 at 14:47, Oleksandr Tymoshenko wrote: >> Author: gonzo >> Date: Mon Nov 21 19:47:37 2016 >> New Revision: 308942 >> URL: https://svnweb.freebsd.org/changeset/base/308942 >> >> Log: >>

Re: svn commit: r309121 - head/usr.sbin/bhyve

On Thu, 2016-11-24 at 22:16 +, Jakub Wojciech Klama wrote: > Author: jceel > Date: Thu Nov 24 22:16:18 2016 > New Revision: 309121 > URL: https://svnweb.freebsd.org/changeset/base/309121 > > Log: >   virtio_console: handle short writes to an Unix domain socket > gracefully. >    >   writev()

svn commit: r309121 - head/usr.sbin/bhyve

Author: jceel Date: Thu Nov 24 22:16:18 2016 New Revision: 309121 URL: https://svnweb.freebsd.org/changeset/base/309121 Log: virtio_console: handle short writes to an Unix domain socket gracefully. writev() can do a short write. Retrying it results in a very convoluted and complex code,

svn commit: r309120 - head/usr.sbin/bhyve

Author: jceel Date: Thu Nov 24 21:53:42 2016 New Revision: 309120 URL: https://svnweb.freebsd.org/changeset/base/309120 Log: Allow opening virtio-console ports from the host side before guest enumerates them. Approved by: trasz Sponsored by: iXsystems, Inc. Modified:

svn commit: r309119 - head/sys/dev/virtio/pci

Author: avg Date: Thu Nov 24 21:32:04 2016 New Revision: 309119 URL: https://svnweb.freebsd.org/changeset/base/309119 Log: virtio_pci: fix announcement of MSI-X interrupts for queues Queues that do not need interrupts - for instance, output queues - do not have a corresponding entry in

svn commit: r309116 - head/sys/dev/virtio/console

Author: avg Date: Thu Nov 24 21:12:32 2016 New Revision: 309116 URL: https://svnweb.freebsd.org/changeset/base/309116 Log: virtio_console: correctly determine presense of payload and its length MFC after:2 weeks Modified: head/sys/dev/virtio/console/virtio_console.c Modified:

Re: svn commit: r309109 - head/lib/libutil

> On Nov 24, 2016, at 11:06 AM, John Baldwin wrote: > > On Thursday, November 24, 2016 02:50:21 PM Dag-Erling Smørgrav wrote: >> Author: des >> Date: Thu Nov 24 14:50:21 2016 >> New Revision: 309109 >> URL: https://svnweb.freebsd.org/changeset/base/309109 >> >> Log: >> Add a

Re: svn commit: r309109 - head/lib/libutil

This kind of language isn't really appropriate. Please revert the commit immediately. When you've had time to think of an appropriate way to word comments to the same effect, please commit that separately. Thanks, Conrad On Thu, Nov 24, 2016 at 6:50 AM, Dag-Erling Smørgrav

svn commit: r309114 - head/sys/powerpc/include

Author: jhibbits Date: Thu Nov 24 20:31:46 2016 New Revision: 309114 URL: https://svnweb.freebsd.org/changeset/base/309114 Log: Fix the build post-r309017 for MPC85XX/MPC85XXSPE r309017 removed two fields from struct vmmeter, which is embedded in struct pcpu. This caused the struct size

svn commit: r309113 - in head/sys: arm/ti/cpsw conf

Author: loos Date: Thu Nov 24 20:14:43 2016 New Revision: 309113 URL: https://svnweb.freebsd.org/changeset/base/309113 Log: Add the etherswitch(4) support for TI CPSW. Adds VLAN and port management abilities for etherswitchcfg(8). The code is conditionally enabled for now, because it

svn commit: r309112 - head/sys/modules

Author: gonzo Date: Thu Nov 24 20:08:17 2016 New Revision: 309112 URL: https://svnweb.freebsd.org/changeset/base/309112 Log: [bytgpio] Fix pc98 build by disabling bytgpio module for this platform Reported by: dim Modified: head/sys/modules/Makefile Modified: head/sys/modules/Makefile

Re: svn commit: r309017 - in head/sys: cddl/compat/opensolaris/sys compat/linprocfs fs/tmpfs sys vm

On Nov 22, 2016, at 12:13 PM, Alan Cox wrote: Author: alc Date: Tue Nov 22 18:13:46 2016 New Revision: 309017 URL: https://svnweb.freebsd.org/changeset/base/309017 Log: Remove PG_CACHED-related fields from struct vmmeter, because they are no longer used. More precisely, they are always

Re: svn commit: r309109 - head/lib/libutil

I'm happy to have a comment noting the extreme subtleties in play and calling you out as the domain expert to contact. However, I don't think that the "UNDER PAIN OF DEATH" is appropriate, even jocularly; there are other ways to express the needed sentiment that do not cause one to think about

Re: svn commit: r308942 - in head/sys/modules: . bytgpio

On 21 November 2016 at 14:47, Oleksandr Tymoshenko wrote: > Author: gonzo > Date: Mon Nov 21 19:47:37 2016 > New Revision: 308942 > URL: https://svnweb.freebsd.org/changeset/base/308942 > > Log: > [bytgpio] Add module for bytgpio(4) It looks like this breaks tinderbox for

Re: svn commit: r308000 - in head/sys: dev/netmap net

On 27 October 2016 at 05:46, Luigi Rizzo wrote: > Author: luigi > Date: Thu Oct 27 09:46:22 2016 > New Revision: 308000 > URL: https://svnweb.freebsd.org/changeset/base/308000 > > Log: > Various fixes for ptnet/ptnetmap (passthrough of netmap ports). In detail: > - use

Re: svn commit: r309109 - head/lib/libutil

John Baldwin writes: > Of course, there's only one person who has touched flopen [...] > Perhaps you were just warning yourself? :) Precisely. If memory serves, I wrote that comment after receiving a patch from someone who made the same mistake that I had already made and

Re: svn commit: r308857 - in head: bin/dd sys/mips/conf sys/mips/ingenic

On 19 November 2016 at 12:46, Ruslan Bukin wrote: > Author: br > Date: Sat Nov 19 17:46:18 2016 > New Revision: 308857 > URL: https://svnweb.freebsd.org/changeset/base/308857 > > Log: > Bring in support for Ingenic XBurst JZ4780 and > X1000 systems on chips. Hi Ruslan,

Re: svn commit: r309109 - head/lib/libutil

On Thursday, November 24, 2016 05:27:17 PM Dag-Erling Smørgrav wrote: > Marcelo Araujo writes: > > We have code review, we have some many ways for communication, even > > revert a commit if needed. > > No. This is the kind of mistake where the code will seem to work

Re: svn commit: r309109 - head/lib/libutil

On Thursday, November 24, 2016 02:50:21 PM Dag-Erling Smørgrav wrote: > Author: des > Date: Thu Nov 24 14:50:21 2016 > New Revision: 309109 > URL: https://svnweb.freebsd.org/changeset/base/309109 > > Log: > Add a warning against modifying this code without understanding it, and > an example

svn commit: r309111 - head/sys/kern

Author: mjg Date: Thu Nov 24 18:21:48 2016 New Revision: 309111 URL: https://svnweb.freebsd.org/changeset/base/309111 Log: wait: avoid relocking the child if proc_to_reap returns 1 proc_to_reap would always unlock. However, if it returned 1, kern_wait6 would immediately lock it again.

Re: svn commit: r309109 - head/lib/libutil

On Nov 25, 2016 12:27 AM, "Dag-Erling Smørgrav" wrote: > > Marcelo Araujo writes: > > We have code review, we have some many ways for communication, even > > revert a commit if needed. > > No. This is the kind of mistake where the code will seem to work

Re: svn commit: r309109 - head/lib/libutil

Marcelo Araujo writes: > We have code review, we have some many ways for communication, even > revert a commit if needed. No. This is the kind of mistake where the code will seem to work just fine and end up in a release before a user suddenly discovers that they have

Re: svn commit: r309109 - head/lib/libutil

On Thu, Nov 24, 2016 at 03:39:35PM +, Alexey Dokuchaev wrote: > It is good for the community and for FreeBSD. Only if we wish to forever remain a closed, cliquish, group of developers. mcl ___ svn-src-head@freebsd.org mailing list

Re: svn commit: r309109 - head/lib/libutil

I thought the src/MAINTAINERS mechanism was designed for exactly this. mcl ___ svn-src-head@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Re: svn commit: r309109 - head/lib/libutil

On Thu, Nov 24, 2016 at 11:27:52PM +0800, Marcelo Araujo wrote: > We have code review, we have some many ways for communication, even revert > a commit if needed. Or we can ask people to think twice, so we won't have to revert bogus commits. > Please revert it, it is bad for the community and

Re: svn commit: r309109 - head/lib/libutil

On Nov 24, 2016 10:50 PM, "Dag-Erling Smørgrav" wrote: > > Author: des > Date: Thu Nov 24 14:50:21 2016 > New Revision: 309109 > URL: https://svnweb.freebsd.org/changeset/base/309109 > > Log: > Add a warning against modifying this code without understanding it, and > an

[off-list] Re: svn commit: r309109 - head/lib/libutil

On 11/24/16 15:56, Kubilay Kocak wrote: On 25/11/2016 1:50 AM, Dag-Erling Smørgrav wrote: +/* + * Reliably open and lock a file. + * + * DO NOT, UNDER PAIN OF DEATH, modify this code without first reading the + * revision history and discussing your changes with . + * Don't be

Re: svn commit: r309109 - head/lib/libutil

On Fri, Nov 25, 2016 at 01:56:36AM +1100, Kubilay Kocak wrote: > On 25/11/2016 1:50 AM, Dag-Erling Sm??rgrav wrote: > > +/* + * Reliably open and lock a file. + * + * DO NOT, UNDER PAIN OF > > DEATH, modify this code without first reading the + * revision > > history and discussing your changes

Re: svn commit: r309109 - head/lib/libutil

On 25/11/2016 1:50 AM, Dag-Erling Smørgrav wrote: > +/* + * Reliably open and lock a file. + * + * DO NOT, UNDER PAIN OF > DEATH, modify this code without first reading the + * revision > history and discussing your changes with . + * Don't > be fooled by the code's apparent

svn commit: r309109 - head/lib/libutil

Author: des Date: Thu Nov 24 14:50:21 2016 New Revision: 309109 URL: https://svnweb.freebsd.org/changeset/base/309109 Log: Add a warning against modifying this code without understanding it, and an example of how not to make it more portable. I've had this lying around uncommitted since

Re: svn commit: r305898 - head/usr.sbin/bhyve

On 17/09/2016 16:48, Jakub Wojciech Klama wrote: > Author: jceel > Date: Sat Sep 17 13:48:01 2016 > New Revision: 305898 > URL: https://svnweb.freebsd.org/changeset/base/305898 > > Log: > Add virtio-console support to bhyve. Please update bhyve.8 with this device and its options. An example

svn commit: r309100 - head/release/doc/en_US.ISO8859-1/hardware

Author: brueffer Date: Thu Nov 24 10:35:49 2016 New Revision: 309100 URL: https://svnweb.freebsd.org/changeset/base/309100 Log: Sync the rtwn(4) entry with the manpage. Modified: head/release/doc/en_US.ISO8859-1/hardware/article.xml Modified:

svn commit: r309099 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

Author: avg Date: Thu Nov 24 10:34:42 2016 New Revision: 309099 URL: https://svnweb.freebsd.org/changeset/base/309099 Log: MFV r308990: 7181 race between zfs_mount and zfs_ioc_rollback illumos/illumos-gate@90f2c094b3822f4825f21cef2c2faf7d03b55139

svn commit: r309098 - in head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs: . sys

Author: avg Date: Thu Nov 24 10:29:21 2016 New Revision: 309098 URL: https://svnweb.freebsd.org/changeset/base/309098 Log: MFV r308988: 7199, 7200 dsl_dataset_rollback_sync may try to free already free blocks 7199 dsl_dataset_rollback_sync may try to free already free blocks 7200 no

svn commit: r309097 - in head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs: . sys

Author: avg Date: Thu Nov 24 10:21:22 2016 New Revision: 309097 URL: https://svnweb.freebsd.org/changeset/base/309097 Log: MFV r308987: 7180 potential race between zfs_suspend_fs+zfs_resume_fs and zfs_ioc_rename illumos/illumos-gate@690041b9caf801816f2d0bac90bc7cecefb73523

svn commit: r309096 - head/cddl/contrib/opensolaris/lib/libzfs/common

Author: avg Date: Thu Nov 24 10:11:09 2016 New Revision: 309096 URL: https://svnweb.freebsd.org/changeset/base/309096 Log: MFV r308989: 6428 set canmount=off on unmounted filesystem tries to unmount children This is a cosmetic and bookkeeping change as the actual change is already in

svn commit: r309095 - head/share/man/man5

Author: martymac (ports committer) Date: Thu Nov 24 10:04:20 2016 New Revision: 309095 URL: https://svnweb.freebsd.org/changeset/base/309095 Log: Fix path for per-user nsmb.conf file ~/nsmb.conf, as erroneously introduced by r214387, is never used. Fix the man page to specify that

svn commit: r309094 - head/cddl/contrib/opensolaris

Author: avg Date: Thu Nov 24 10:03:57 2016 New Revision: 309094 URL: https://svnweb.freebsd.org/changeset/base/309094 Log: MFV r308986: 6412 zfs receive: -u can be ignored sometimes This is a record only change, the actual change is in FreeBSD since r297520. Modified: Directory

svn commit: r309093 - head/sys/dev/firewire

Author: avg Date: Thu Nov 24 09:47:56 2016 New Revision: 309093 URL: https://svnweb.freebsd.org/changeset/base/309093 Log: firewire: initialize tag label to -1 in fw_xfer_alloc() Zero can be confused for a potentially valid value. For example, if I load and unload sbp driver I get a lot

svn commit: r309092 - head/sys/dev/firewire

Author: avg Date: Thu Nov 24 09:43:42 2016 New Revision: 309092 URL: https://svnweb.freebsd.org/changeset/base/309092 Log: fwohci: report whether PhysicalUpperBound register is implemented Please see section 5.15 of 1394 OHCI Specification. If the register is not implemented, then the

Re: svn commit: r308687 - head/libexec/rtld-elf

On Wed, Nov 23, 2016 at 11:06:53AM -0800, Bryan Drewery wrote: > On 11/15/2016 1:37 AM, Konstantin Belousov wrote: > > Author: kib > > Date: Tue Nov 15 09:37:35 2016 > > New Revision: 308687 > > URL: https://svnweb.freebsd.org/changeset/base/308687 > > > > Log: > > Update hint to utilize user

svn commit: r309090 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

Author: avg Date: Thu Nov 24 09:00:51 2016 New Revision: 309090 URL: https://svnweb.freebsd.org/changeset/base/309090 Log: further fix zfs_lock() diagnostics It was very wrong to look at the vnode and znode internals without having locked the vnode first. Reported by: pho Tested