svn commit: r334020 - head/sys/sys

2018-05-21 Thread Matt Macy
Author: mmacy Date: Tue May 22 05:49:40 2018 New Revision: 334020 URL: https://svnweb.freebsd.org/changeset/base/334020 Log: pmc: annotate locking for po_ssnext in pmc_owner Modified: head/sys/sys/pmc.h Modified: head/sys/sys/pmc.h

svn commit: r334019 - head/usr.sbin/bhyve

2018-05-21 Thread Marcelo Araujo
Author: araujo Date: Tue May 22 05:21:53 2018 New Revision: 334019 URL: https://svnweb.freebsd.org/changeset/base/334019 Log: Include atkbdc header where there are declared the prototype functions atkbdc_event and atkbdc_init. MFC after:4 weeks. Sponsored by: iXsystems Inc.

svn commit: r334018 - in head/sys/i386: i386 include

2018-05-21 Thread Matt Macy
Author: mmacy Date: Tue May 22 05:09:33 2018 New Revision: 334018 URL: https://svnweb.freebsd.org/changeset/base/334018 Log: fix i386 builds after r334005 and r334009 r334005: add pc_ibpb_set as it is now referenced by common code (although presumably not needed on i386 since it has been

Re: svn commit: r334008 - head/bin/sh

2018-05-21 Thread Cy Schubert
In message <20180522061339.21497...@freyja.zeit4.iv.bundesimmobilien.de> , "O. H artmann" writes: > On Mon, 21 May 2018 21:52:48 + (UTC) > Jilles Tjoelker wrote: > > > Author: jilles > > Date: Mon May 21 21:52:48 2018 > > New Revision: 334008 > > URL:

svn commit: r334017 - in head: lib/libpmcstat usr.sbin/pmcstat

2018-05-21 Thread Matt Macy
Author: mmacy Date: Tue May 22 04:45:46 2018 New Revision: 334017 URL: https://svnweb.freebsd.org/changeset/base/334017 Log: pmcstat: add option to not decode the leaf function in top mode -I will allow the user to see the hot instruction in question as opposed getting the name of the

Re: svn commit: r334008 - head/bin/sh

2018-05-21 Thread O. Hartmann
On Mon, 21 May 2018 21:52:48 + (UTC) Jilles Tjoelker wrote: > Author: jilles > Date: Mon May 21 21:52:48 2018 > New Revision: 334008 > URL: https://svnweb.freebsd.org/changeset/base/334008 > > Log: > sh: Split CNL syntax category to avoid a check on state[level].syntax

svn commit: r334016 - head/usr.sbin/bhyve

2018-05-21 Thread Marcelo Araujo
Author: araujo Date: Tue May 22 04:08:08 2018 New Revision: 334016 URL: https://svnweb.freebsd.org/changeset/base/334016 Log: We must free the variable str. Spotted by: clang's static analyzer Submitted by: Tom Rix Reviewed by: grehan MFC after:4 weeks Sponsored by:

svn commit: r334015 - in head/sys: conf powerpc/powernv

2018-05-21 Thread Justin Hibbits
Author: jhibbits Date: Tue May 22 03:57:32 2018 New Revision: 334015 URL: https://svnweb.freebsd.org/changeset/base/334015 Log: Add an IPMI attachment for PowerNV systems IPMI access on PowerNV systems is done through the OPAL firmware. This adds a simple attachment for communicating

svn commit: r334014 - head/sys/powerpc/pseries

2018-05-21 Thread Justin Hibbits
Author: jhibbits Date: Tue May 22 03:24:16 2018 New Revision: 334014 URL: https://svnweb.freebsd.org/changeset/base/334014 Log: Add a comment explaining the need of a global temporary variable cpu_xirr is used only as a temporary location for the OPAL call in PIC_DISPATCH().

svn commit: r334011 - in head/sys: conf powerpc/powernv

2018-05-21 Thread Justin Hibbits
Author: jhibbits Date: Tue May 22 02:42:53 2018 New Revision: 334011 URL: https://svnweb.freebsd.org/changeset/base/334011 Log: Basic OPAL sensor support for POWER9 platforms Summary: PowerNV architectures (in the test case POWER9) export sensors via the device tree, which are accessed

svn commit: r334010 - head/usr.bin/top

2018-05-21 Thread Eitan Adler
Author: eadler Date: Tue May 22 02:13:04 2018 New Revision: 334010 URL: https://svnweb.freebsd.org/changeset/base/334010 Log: top(1): unbreak build with gcc7; fix varargs - use correct function for varargs argument - allow build to complete with gcc7 at current WARNS Reported by:

Re: svn commit: r333995 - head/sys/teken

2018-05-21 Thread Bruce Evans
On Mon, 21 May 2018, [UTF-8] Jean-S??bastien P??dron wrote: Log: teken: Rename the "Set Cursor Style" sequence to match vt100.net docs This fixes inconsistencies with the rest of the `sequences` file. No functional changes. Requested by: ed Modified: head/sys/teken/sequences

svn commit: r334009 - in head/sys: amd64/amd64 amd64/include amd64/vmm/amd amd64/vmm/intel i386/i386 i386/include x86/include

2018-05-21 Thread John Baldwin
Author: jhb Date: Tue May 22 00:45:00 2018 New Revision: 334009 URL: https://svnweb.freebsd.org/changeset/base/334009 Log: Cleanups related to debug exceptions on x86. - Add constants for fields in DR6 and the reserved fields in DR7. Use these constants instead of magic numbers in

Re: svn commit: r333962 - head/usr.bin/top

2018-05-21 Thread John Baldwin
On Monday, May 21, 2018 04:40:20 AM Eitan Adler wrote: > Author: eadler > Date: Mon May 21 04:40:20 2018 > New Revision: 333962 > URL: https://svnweb.freebsd.org/changeset/base/333962 > > Log: > top(1): further unconditionally assume we're on FreeBSD > > Modified: >

svn commit: r334008 - head/bin/sh

2018-05-21 Thread Jilles Tjoelker
Author: jilles Date: Mon May 21 21:52:48 2018 New Revision: 334008 URL: https://svnweb.freebsd.org/changeset/base/334008 Log: sh: Split CNL syntax category to avoid a check on state[level].syntax No functional change is intended. Modified: head/bin/sh/mksyntax.c head/bin/sh/parser.c

svn commit: r334007 - head/etc/devd

2018-05-21 Thread Emmanuel Vadot
Author: manu Date: Mon May 21 21:44:47 2018 New Revision: 334007 URL: https://svnweb.freebsd.org/changeset/base/334007 Log: devd: Always install devmatch.conf It allows devd to run devmatch to find the correct driver based on pnp info. No Objection from:imp Modified:

svn commit: r334006 - head/sys/arm/allwinner

2018-05-21 Thread Emmanuel Vadot
Author: manu Date: Mon May 21 21:15:46 2018 New Revision: 334006 URL: https://svnweb.freebsd.org/changeset/base/334006 Log: aw_mmc: Correctly reset the mmc controller Always disable FIFO access as we don't use it. Rename some register bits so they are in sync with the register name.

svn commit: r334005 - in head/sys: amd64/amd64 amd64/include dev/cpuctl x86/acpica x86/include x86/x86

2018-05-21 Thread Konstantin Belousov
Author: kib Date: Mon May 21 21:08:19 2018 New Revision: 334005 URL: https://svnweb.freebsd.org/changeset/base/334005 Log: Add Intel Spec Store Bypass Disable control. Speculative Store Bypass (SSB) is a speculative execution side channel vulnerability identified by Jann Horn of Google

svn commit: r334004 - in head/sys/x86: include x86

2018-05-21 Thread Konstantin Belousov
Author: kib Date: Mon May 21 21:07:13 2018 New Revision: 334004 URL: https://svnweb.freebsd.org/changeset/base/334004 Log: Add definition for Intel Speculative Store Bypass Disable MSR bits Security: CVE-2018-3639 Sponsored by: The FreeBSD Foundation MFC after:3 days Modified:

svn commit: r334003 - head/sys/amd64/amd64

2018-05-21 Thread Konstantin Belousov
Author: kib Date: Mon May 21 21:05:55 2018 New Revision: 334003 URL: https://svnweb.freebsd.org/changeset/base/334003 Log: Preserve other bits in IA32_SPEC_CTL MSR when changing the IBRS and STIBP states. Tested by:emaste (previous version) Sponsored by: The FreeBSD Foundation

svn commit: r334000 - head/sys/dev/usb/serial

2018-05-21 Thread Andriy Gapon
Author: avg Date: Mon May 21 21:00:13 2018 New Revision: 334000 URL: https://svnweb.freebsd.org/changeset/base/334000 Log: uchcom: reject parity and double stop bits as unsupported Reviewed by: hselasky MFC after:2 weeks Modified: head/sys/dev/usb/serial/uchcom.c Modified:

svn commit: r334002 - head/sys/dev/usb/serial

2018-05-21 Thread Andriy Gapon
Author: avg Date: Mon May 21 21:04:31 2018 New Revision: 334002 URL: https://svnweb.freebsd.org/changeset/base/334002 Log: uchcom: extend hardware support to version 0x30 This change adds support for a UBS<->RS232 adapter based on CH340 (or an analogue) that I own. The device seems to

svn commit: r334001 - head/sys/dev/usb/serial

2018-05-21 Thread Andriy Gapon
Author: avg Date: Mon May 21 21:02:10 2018 New Revision: 334001 URL: https://svnweb.freebsd.org/changeset/base/334001 Log: uchcom: remove UCHCOM_REG_BREAK2 alias of UCHCOM_REG_LCR1 Also, add definitions for more bits of UCHCOM_REG_LCR1 as seen in the Linux driver. UCHCOM_LCR1_PARENB

svn commit: r333997 - head/sys/dev/usb/serial

2018-05-21 Thread Andriy Gapon
Author: avg Date: Mon May 21 20:57:14 2018 New Revision: 333997 URL: https://svnweb.freebsd.org/changeset/base/333997 Log: uchcom: report detected product based on USB product ID Product IDs are specified in vendor documents. The previously used device ID is not. This is a cosmetic

svn commit: r333999 - head/sys/dev/usb/serial

2018-05-21 Thread Andriy Gapon
Author: avg Date: Mon May 21 20:59:15 2018 New Revision: 333999 URL: https://svnweb.freebsd.org/changeset/base/333999 Log: uchcom: add a hardware configuration tweak seen in Linux code Reviewed by: hselasky MFC after:2 weeks Modified: head/sys/dev/usb/serial/uchcom.c Modified:

svn commit: r333998 - head/sys/dev/usb/serial

2018-05-21 Thread Andriy Gapon
Author: avg Date: Mon May 21 20:58:06 2018 New Revision: 333998 URL: https://svnweb.freebsd.org/changeset/base/333998 Log: uchcom: add DPRINTF-s to aid debugging of the driver Reviewed by: hselasky MFC after:2 weeks Modified: head/sys/dev/usb/serial/uchcom.c Modified:

Re: svn commit: r333911 - head/sys/netinet

2018-05-21 Thread Matthew Macy
On Mon, May 21, 2018 at 6:15 AM, Jonathan Looney wrote: > On Sat, May 19, 2018 at 10:27 PM, Matt Macy wrote: >> >> + il = malloc(sizeof(struct in_pcblist) + n * sizeof(struct inpcb >> *), M_TEMP, M_WAITOK|M_ZERO); >> + inp_list =

Re: svn commit: r333859 - head/sys/kern

2018-05-21 Thread Matthew Macy
Bear in mind that prior to my change most functions would call it without ever using it on non-debug builds. On Mon, May 21, 2018 at 9:54 AM, Eric van Gyzen wrote: > On 05/19/2018 00:09, Matt Macy wrote: >> @@ -1663,16 +1655,18 @@ static int >> umtxq_sleep_pi(struct umtx_q

svn commit: r333995 - head/sys/teken

2018-05-21 Thread Jean-Sébastien Pédron
Author: dumbbell Date: Mon May 21 20:35:16 2018 New Revision: 333995 URL: https://svnweb.freebsd.org/changeset/base/333995 Log: teken: Rename the "Set Cursor Style" sequence to match vt100.net docs This fixes inconsistencies with the rest of the `sequences` file. No functional

svn commit: r333994 - in head/sys: dev/acpica kern sys

2018-05-21 Thread Andriy Gapon
Author: avg Date: Mon May 21 20:23:04 2018 New Revision: 333994 URL: https://svnweb.freebsd.org/changeset/base/333994 Log: stop and restart kernel event timers in the suspend / resume cycle I have a system that is very unstable after resuming from suspend-to-RAM but only if HPET is used

Re: svn commit: r333919 - in head/contrib/file: . doc magic magic/Magdir python src tests

2018-05-21 Thread Andreas Tobler
Hi Eitan, On 20.05.18 07:06, Eitan Adler wrote: Author: eadler Date: Sun May 20 05:06:42 2018 New Revision: 333919 URL: https://svnweb.freebsd.org/changeset/base/333919 Log: MFV: file 5.33 Merge the latest file(1) in. Relevent Changelog: - extend the support for ${x?:}

svn commit: r333992 - head/sys/amd64/amd64

2018-05-21 Thread Konstantin Belousov
Author: kib Date: Mon May 21 19:15:05 2018 New Revision: 333992 URL: https://svnweb.freebsd.org/changeset/base/333992 Log: Fix grammar. Submitted by: alc MFC after:1 week Modified: head/sys/amd64/amd64/pmap.c Modified: head/sys/amd64/amd64/pmap.c

svn commit: r333990 - head/sys/amd64/amd64

2018-05-21 Thread Konstantin Belousov
Author: kib Date: Mon May 21 18:41:16 2018 New Revision: 333990 URL: https://svnweb.freebsd.org/changeset/base/333990 Log: Add missed barrier for pm_gen/pm_active interaction. When we issue shootdown IPIs, we first assign zero to pm_gens to indicate the need to flush on the next context

Re: svn commit: r333929 - head/usr.bin/top

2018-05-21 Thread Brooks Davis
On Sun, May 20, 2018 at 05:59:59PM +, Eitan Adler wrote: > Author: eadler > Date: Sun May 20 17:59:59 2018 > New Revision: 333929 > URL: https://svnweb.freebsd.org/changeset/base/333929 > > Log: > top(1): Make lack of "percent" information explicit > > When count is 1, no delta

svn commit: r333989 - head/sys/dev/usb/template

2018-05-21 Thread Edward Tomasz Napierala
Author: trasz Date: Mon May 21 17:33:52 2018 New Revision: 333989 URL: https://svnweb.freebsd.org/changeset/base/333989 Log: Add a somewhat ugly hack that makes OSX serial device node names human-readable. MFC after:2 weeks Sponsored by: The FreeBSD Foundation Modified:

Re: svn commit: r333859 - head/sys/kern

2018-05-21 Thread Matthew Macy
Good point. Will fix. On Mon, May 21, 2018 at 9:54 AM, Eric van Gyzen wrote: > On 05/19/2018 00:09, Matt Macy wrote: >> @@ -1663,16 +1655,18 @@ static int >> umtxq_sleep_pi(struct umtx_q *uq, struct umtx_pi *pi, uint32_t owner, >> const char *wmesg, struct abs_timeout

Re: svn commit: r333859 - head/sys/kern

2018-05-21 Thread Eric van Gyzen
On 05/19/2018 00:09, Matt Macy wrote: > @@ -1663,16 +1655,18 @@ static int > umtxq_sleep_pi(struct umtx_q *uq, struct umtx_pi *pi, uint32_t owner, > const char *wmesg, struct abs_timeout *timo, bool shared) > { > - struct umtxq_chain *uc; > struct thread *td, *td1; > struct

svn commit: r333988 - head/share/man/man4

2018-05-21 Thread Edward Tomasz Napierala
Author: trasz Date: Mon May 21 16:50:27 2018 New Revision: 333988 URL: https://svnweb.freebsd.org/changeset/base/333988 Log: Fix typo. MFC after:2 weeks Sponsored by: The FreeBSD Foundation Modified: head/share/man/man4/cdce.4 Modified: head/share/man/man4/cdce.4

svn commit: r333987 - head/sys/dev/usb/template

2018-05-21 Thread Edward Tomasz Napierala
Author: trasz Date: Mon May 21 16:33:13 2018 New Revision: 333987 URL: https://svnweb.freebsd.org/changeset/base/333987 Log: Improve description strings for USB device-mode serial ports. MFC after:2 weeks Sponsored by: The FreeBSD Foundation Modified:

svn commit: r333986 - head/sys/netpfil/ipfw

2018-05-21 Thread Andrey V. Elsukov
Author: ae Date: Mon May 21 16:19:00 2018 New Revision: 333986 URL: https://svnweb.freebsd.org/changeset/base/333986 Log: Remove check for matching the rulenum, ruleid and rule pointer from dyn_lookup_ipv[46]_state_locked(). These checks are remnants of not ready to be committed code, and

svn commit: r333985 - head/sys/arm64/arm64

2018-05-21 Thread Andrew Turner
Author: andrew Date: Mon May 21 16:14:53 2018 New Revision: 333985 URL: https://svnweb.freebsd.org/changeset/base/333985 Log: Restrict the faulting addresses we call pmap_fault from to just those that may fault due to superpage mappings being changed. Sponsored by: DARPA, AFRL Modified:

svn commit: r333984 - head/sys/netinet

2018-05-21 Thread Matt Macy
Author: mmacy Date: Mon May 21 16:13:43 2018 New Revision: 333984 URL: https://svnweb.freebsd.org/changeset/base/333984 Log: inpcb: revert deferred inpcb free pending further review Modified: head/sys/netinet/in_pcb.c head/sys/netinet/in_pcb.h Modified: head/sys/netinet/in_pcb.c

Re: svn commit: r333968 - in head/sys: netinet netinet6

2018-05-21 Thread Matthew Macy
Looking closer I think the ifp should always be set. I'll just add an assert to that effect and make it non-conditional. -M On Mon, May 21, 2018 at 1:55 AM, Marko Zec wrote: > On Mon, 21 May 2018 08:34:10 + > Matt Macy wrote: > >> Author: mmacy >> Date: Mon

svn commit: r333983 - head/sys/kern

2018-05-21 Thread Mark Johnston
Author: markj Date: Mon May 21 16:03:51 2018 New Revision: 333983 URL: https://svnweb.freebsd.org/changeset/base/333983 Log: Don't pass a section cookie to CK for non-preemptible epoch sections. They're only useful when multiple threads may share an epoch record, and that can't happen

Re: svn commit: r333968 - in head/sys: netinet netinet6

2018-05-21 Thread Matthew Macy
Sorry about that On Mon, May 21, 2018 at 04:59 Hans Petter Selasky wrote: > On 05/21/18 13:49, Ed Maste wrote: > > After r333968 the build is also broken on all archs but amd64 and i386. > > It looks like amd64 and i386 build with VIMAGE enabled by default, while > the others

svn commit: r333982 - head/sys/dev/usb/template

2018-05-21 Thread Edward Tomasz Napierala
Author: trasz Date: Mon May 21 15:06:19 2018 New Revision: 333982 URL: https://svnweb.freebsd.org/changeset/base/333982 Log: Use USB Vendor Identifiers and Product Identifiers provided by V-USB (https://github.com/obdev/v-usb/blob/master/usbdrv/USB-IDs-for-free.txt). Previously we were

svn commit: r333981 - head/sys/netinet

2018-05-21 Thread Michael Tuexen
Author: tuexen Date: Mon May 21 14:53:22 2018 New Revision: 333981 URL: https://svnweb.freebsd.org/changeset/base/333981 Log: Only fillin data srucuture when actually stored. Modified: head/sys/netinet/sctputil.c Modified: head/sys/netinet/sctputil.c

svn commit: r333980 - head/sys/netinet

2018-05-21 Thread Michael Tuexen
Author: tuexen Date: Mon May 21 14:52:18 2018 New Revision: 333980 URL: https://svnweb.freebsd.org/changeset/base/333980 Log: Do the appropriate accounting when ip_output() fails. Modified: head/sys/netinet/sctp_output.c Modified: head/sys/netinet/sctp_output.c

svn commit: r333979 - head/sys/netinet

2018-05-21 Thread Michael Tuexen
Author: tuexen Date: Mon May 21 14:51:20 2018 New Revision: 333979 URL: https://svnweb.freebsd.org/changeset/base/333979 Log: Make clear why there is an assignment, which is not necessary. Modified: head/sys/netinet/sctp_indata.c Modified: head/sys/netinet/sctp_indata.c

Re: svn commit: r333959 - head/usr.bin/top

2018-05-21 Thread Ian Lepore
On Mon, 2018-05-21 at 09:46 +0100, Andrew Turner wrote: > > > > > On 21 May 2018, at 04:58, Eitan Adler wrote: > > > > Author: eadler > > Date: Mon May 21 03:58:15 2018 > > New Revision: 333959 > > URL: https://svnweb.freebsd.org/changeset/base/333959 > > > > Log: > >  

Re: svn commit: r333915 - head/sys/netinet

2018-05-21 Thread Jonathan T. Looney
Summary: I'm not sure this addresses all the subtleties of INPCB destruction. I think it would benefit from wider review. I suggest it be reverted in the meantime. On Sun, May 20, 2018 at 12:38 AM, Matt Macy wrote: > + > +/* > + * Unconditionally schedule an inpcb to be freed

Re: svn commit: r333911 - head/sys/netinet

2018-05-21 Thread Jonathan Looney
On Sat, May 19, 2018 at 10:27 PM, Matt Macy wrote: > + il = malloc(sizeof(struct in_pcblist) + n * sizeof(struct inpcb > *), M_TEMP, M_WAITOK|M_ZERO); > + inp_list = il->il_inp_list; > Why does this need M_ZERO? Jonathan

svn commit: r333978 - in head/sys: netinet netinet6

2018-05-21 Thread Ed Maste
Author: emaste Date: Mon May 21 13:08:44 2018 New Revision: 333978 URL: https://svnweb.freebsd.org/changeset/base/333978 Log: Pair CURVNET_SET and CURVNET_RESTORE in a block Per vnet(9), CURVNET_SET and CURVNET_RESTORE cannot be used as a single statement for a conditional and

Re: svn commit: r333968 - in head/sys: netinet netinet6

2018-05-21 Thread Hans Petter Selasky
On 05/21/18 13:49, Ed Maste wrote: After r333968 the build is also broken on all archs but amd64 and i386. It looks like amd64 and i386 build with VIMAGE enabled by default, while the others not. 12-current. So both VIMAGE and non-VIMAGE should be tested. --HPS

svn commit: r333976 - head/release/arm64

2018-05-21 Thread Emmanuel Vadot
Author: manu Date: Mon May 21 11:58:02 2018 New Revision: 333976 URL: https://svnweb.freebsd.org/changeset/base/333976 Log: release: arm64: Use loader.efi as bootaa64.efi for RPI3 and PINE64 boot1.efi have some trouble to read MBR partitions, it needs them to be aligned a certain way

svn commit: r333975 - in head/sys: netinet netinet6

2018-05-21 Thread Ed Maste
Author: emaste Date: Mon May 21 11:56:07 2018 New Revision: 333975 URL: https://svnweb.freebsd.org/changeset/base/333975 Log: Revert r333968, it broke all archs but i386 and amd64 Modified: head/sys/netinet/in_mcast.c head/sys/netinet6/in6_mcast.c Modified: head/sys/netinet/in_mcast.c

Re: svn commit: r333968 - in head/sys: netinet netinet6

2018-05-21 Thread Ed Maste
On 21 May 2018 at 04:55, Marko Zec wrote: > On Mon, 21 May 2018 08:34:10 + > Matt Macy wrote: > >> Author: mmacy >> Date: Mon May 21 08:34:10 2018 >> New Revision: 333968 >> URL: https://svnweb.freebsd.org/changeset/base/333968 >> >> Log: >> in(6)_mcast:

svn commit: r333974 - head/usr.bin/top

2018-05-21 Thread Eitan Adler
Author: eadler Date: Mon May 21 09:43:50 2018 New Revision: 333974 URL: https://svnweb.freebsd.org/changeset/base/333974 Log: top(1): fix build Remove 'top.local.hs'. This was not noticed since /srv/obj/fbsd/srv/src/freebsd/svn/head/amd64.amd64/usr.bin/top/top.local.h existed locally

svn commit: r333973 - head/usr.bin/top

2018-05-21 Thread Eitan Adler
Author: eadler Date: Mon May 21 09:32:52 2018 New Revision: 333973 URL: https://svnweb.freebsd.org/changeset/base/333973 Log: top(1): clean up some "const" related warnings This leaves at WARNS=6: 35 warnings in top.c 88 warnings in machine.c all of which are either

svn commit: r333972 - head/usr.bin/top

2018-05-21 Thread Eitan Adler
Author: eadler Date: Mon May 21 09:25:21 2018 New Revision: 333972 URL: https://svnweb.freebsd.org/changeset/base/333972 Log: top(1): modernize a bit; reduce warnings - Replace caddr_t with "void *". This reduces the number of warnings at WARNS=6 - use "static" where possible -

svn commit: r333971 - head/usr.bin/top

2018-05-21 Thread Eitan Adler
Author: eadler Date: Mon May 21 09:21:42 2018 New Revision: 333971 URL: https://svnweb.freebsd.org/changeset/base/333971 Log: Add missing va_end Reported by: andrew Modified: head/usr.bin/top/display.c Modified: head/usr.bin/top/display.c

svn commit: r333970 - head/usr.bin/top

2018-05-21 Thread Eitan Adler
Author: eadler Date: Mon May 21 09:20:26 2018 New Revision: 333970 URL: https://svnweb.freebsd.org/changeset/base/333970 Log: Revert r333969 which contained one too many changes Modified: head/usr.bin/top/Makefile head/usr.bin/top/commands.c head/usr.bin/top/display.c

svn commit: r333969 - head/usr.bin/top

2018-05-21 Thread Eitan Adler
Author: eadler Date: Mon May 21 09:18:01 2018 New Revision: 333969 URL: https://svnweb.freebsd.org/changeset/base/333969 Log: top(1): modernize a bit; reduce warnings - Replace caddr_t with "void *". This reduces the number of warnings at WARNS=6 - use "static" where possible -

Re: svn commit: r333959 - head/usr.bin/top

2018-05-21 Thread Andrew Turner
> On 21 May 2018, at 04:58, Eitan Adler wrote: > > Author: eadler > Date: Mon May 21 03:58:15 2018 > New Revision: 333959 > URL: https://svnweb.freebsd.org/changeset/base/333959 > > Log: > top(1): build with WARNS=3 > > This fixes everything but >

Re: svn commit: r333968 - in head/sys: netinet netinet6

2018-05-21 Thread Marko Zec
On Mon, 21 May 2018 08:34:10 + Matt Macy wrote: > Author: mmacy > Date: Mon May 21 08:34:10 2018 > New Revision: 333968 > URL: https://svnweb.freebsd.org/changeset/base/333968 > > Log: > in(6)_mcast: Expand out vnet set / restore macro so that they work > in a

svn commit: r333968 - in head/sys: netinet netinet6

2018-05-21 Thread Matt Macy
Author: mmacy Date: Mon May 21 08:34:10 2018 New Revision: 333968 URL: https://svnweb.freebsd.org/changeset/base/333968 Log: in(6)_mcast: Expand out vnet set / restore macro so that they work in a conditional block Reported by: zec at fer.hr Modified: head/sys/netinet/in_mcast.c

Re: svn commit: r333967 - head/sys/netinet

2018-05-21 Thread Marko Zec
On Mon, 21 May 2018 01:03:53 -0700 Matthew Macy wrote: > On Mon, May 21, 2018 at 00:47 Marko Zec wrote: > > On Mon, 21 May 2018 07:12:06 + Matt Macy wrote: ... > > > + if (ifp) > > > +

Re: svn commit: r333967 - head/sys/netinet

2018-05-21 Thread Matthew Macy
On Mon, May 21, 2018 at 00:47 Marko Zec wrote: > On Mon, 21 May 2018 07:12:06 + > Matt Macy wrote: > > > Author: mmacy > > Date: Mon May 21 07:12:06 2018 > > New Revision: 333967 > > URL: https://svnweb.freebsd.org/changeset/base/333967 > > > > Log: > >

Re: svn commit: r333967 - head/sys/netinet

2018-05-21 Thread Matthew Macy
Thanks On Mon, May 21, 2018 at 00:47 Marko Zec wrote: > On Mon, 21 May 2018 07:12:06 + > Matt Macy wrote: > > > Author: mmacy > > Date: Mon May 21 07:12:06 2018 > > New Revision: 333967 > > URL: https://svnweb.freebsd.org/changeset/base/333967 > > > > Log: >

Re: svn commit: r333967 - head/sys/netinet

2018-05-21 Thread Marko Zec
On Mon, 21 May 2018 07:12:06 + Matt Macy wrote: > Author: mmacy > Date: Mon May 21 07:12:06 2018 > New Revision: 333967 > URL: https://svnweb.freebsd.org/changeset/base/333967 > > Log: > ensure that vnet is set when doing in_leavegroup > > Modified: >

svn commit: r333967 - head/sys/netinet

2018-05-21 Thread Matt Macy
Author: mmacy Date: Mon May 21 07:12:06 2018 New Revision: 333967 URL: https://svnweb.freebsd.org/changeset/base/333967 Log: ensure that vnet is set when doing in_leavegroup Modified: head/sys/netinet/in_mcast.c Modified: head/sys/netinet/in_mcast.c

Re: svn commit: r333945 - head/usr.bin/top

2018-05-21 Thread Alexey Dokuchaev
On Mon, May 21, 2018 at 10:32:30AM +1000, Bruce Evans wrote: > ... > > if (smpmode && namelength > SMPUNAMELEN) > > namelength = SMPUNAMELEN; > > else if (namelength > UPUNAMELEN) > > But 33 is too large. It is much larger than the hard-coded maximum limits, > so it is never