svn commit: r340664 - head/sys/sys

2018-11-19 Thread Warner Losh
Author: imp Date: Tue Nov 20 07:11:23 2018 New Revision: 340664 URL: https://svnweb.freebsd.org/changeset/base/340664 Log: Ensure that all values of ns, us and ms work for {n,u,m}stosbt Integer overflows and wrong constants limited the accuracy of these functions and created situatiosn

Re: svn commit: r340661 - head/sys/fs/nfsserver

2018-11-19 Thread Rick Macklem
>Author: rmacklem >Date: Tue Nov 20 01:52:45 2018 >New Revision: 340661 >URL: https://svnweb.freebsd.org/changeset/base/340661 > >Log: > r304026 added code that started statistics gathering for an operation > before the operation number (the variable called "op") was sanity checked. > This

svn commit: r340663 - head/sys/fs/nfsserver

2018-11-19 Thread Rick Macklem
Author: rmacklem Date: Tue Nov 20 01:59:57 2018 New Revision: 340663 URL: https://svnweb.freebsd.org/changeset/base/340663 Log: Improve sanity checking for the dircount hint argument to NFSv3's ReaddirPlus and NFSv4's Readdir operations. The code checked for a zero argument, but did not

svn commit: r340662 - head/sys/fs/nfs

2018-11-19 Thread Rick Macklem
Author: rmacklem Date: Tue Nov 20 01:56:34 2018 New Revision: 340662 URL: https://svnweb.freebsd.org/changeset/base/340662 Log: nfsm_advance() would panic() when the offs argument was negative. The code assumed that this would indicate a corrupted mbuf chain, but it could simply be caused

svn commit: r340661 - head/sys/fs/nfsserver

2018-11-19 Thread Rick Macklem
Author: rmacklem Date: Tue Nov 20 01:52:45 2018 New Revision: 340661 URL: https://svnweb.freebsd.org/changeset/base/340661 Log: r304026 added code that started statistics gathering for an operation before the operation number (the variable called "op") was sanity checked. This patch moves

Re: svn commit: r340653 - in head/sys/powerpc: fpu include powerpc

2018-11-19 Thread Justin Hibbits
Well, this is to allow a retry in case the cache wasn't properly flushed already. This came about because the blrl instruction in the GOT was seen as an illegal instruction, and it didn't seem to matter if I synced in pmap_enter(), it would still SIGILL probabilistically. Since this block was

Re: svn commit: r340653 - in head/sys/powerpc: fpu include powerpc

2018-11-19 Thread Nathan Whitehorn
Is this reasonable? What if the junk in the cache happened to be a *valid* instruction? Won't this approach result in silent corruption and later failure? -Nathan On 11/19/18 3:54 PM, Justin Hibbits wrote: > Author: jhibbits > Date: Mon Nov 19 23:54:49 2018 > New Revision: 340653 > URL:

svn commit: r340656 - head/sys/sparc64/sparc64

2018-11-19 Thread Marius Strobl
Author: marius Date: Tue Nov 20 00:08:33 2018 New Revision: 340656 URL: https://svnweb.freebsd.org/changeset/base/340656 Log: Given that the idea of D15374 was to "make memmove a first class citizen", provide a _MEMMOVE extension of _MEMCPY that deals with overlap based on the previous

svn commit: r340655 - head/usr.bin/pom

2018-11-19 Thread Thomas Munro
Author: tmunro Date: Tue Nov 20 00:06:53 2018 New Revision: 340655 URL: https://svnweb.freebsd.org/changeset/base/340655 Log: pom: Fix fencepost bugs. Under some conditions pom would report "waning" and then "full", show higher percentages than it should, and get confused by DST. Fix.

svn commit: r340654 - head/sys/dev/sdhci

2018-11-19 Thread Marius Strobl
Author: marius Date: Mon Nov 19 23:56:33 2018 New Revision: 340654 URL: https://svnweb.freebsd.org/changeset/base/340654 Log: For consistency within the front-end, prefer SDHCI_{READ,WRITE}_{2,4}() to sdhci_acpi_{read,write}_{2,4}() in the sdhci_acpi_set_uhs_timing() added in r340543.

svn commit: r340653 - in head/sys/powerpc: fpu include powerpc

2018-11-19 Thread Justin Hibbits
Author: jhibbits Date: Mon Nov 19 23:54:49 2018 New Revision: 340653 URL: https://svnweb.freebsd.org/changeset/base/340653 Log: powerpc: Sync icache on SIGILL, in case of cache issues The update of jemalloc to 5.1.0 exposed a cache syncing issue on a Freescale e500 base system. There

svn commit: r340652 - head/rescue/rescue

2018-11-19 Thread Ed Maste
Author: emaste Date: Mon Nov 19 22:18:18 2018 New Revision: 340652 URL: https://svnweb.freebsd.org/changeset/base/340652 Log: rescue: set NO_SHARED in Makefile The rescue binary is built statically via the Makefile generated by crunchgen, but that does not trigger other shared/static

Re: svn commit: r339898 - head/lib/libc/amd64/sys

2018-11-19 Thread Charlie Li
On 05/11/2018 21:51, Konstantin Belousov wrote: > For you, but not for me. > Turns out I omitted the fact that I have WITH_RETPOLINE enabled, which caused all this. emaste@ reported in PR 26 and committed r340650. -- Charlie Li Can't think of a witty .sigline today… (This email address is

svn commit: r340651 - in head/sys: conf dev/cxgbe/firmware modules/cxgbe/t4_firmware modules/cxgbe/t5_firmware modules/cxgbe/t6_firmware

2018-11-19 Thread Navdeep Parhar
Author: np Date: Mon Nov 19 21:59:07 2018 New Revision: 340651 URL: https://svnweb.freebsd.org/changeset/base/340651 Log: cxgbe(4): Update T4/5/6 firmwares to 1.22.0.3. Obtained from:Chelsio Communications MFC after:2 months Sponsored by: Chelsio Communications Added:

Re: svn commit: r340450 - head/sys/sys

2018-11-19 Thread Warner Losh
On Mon, Nov 19, 2018 at 9:05 AM Bruce Evans wrote: > On Tue, 20 Nov 2018, Bruce Evans wrote: > > > On Tue, 20 Nov 2018, Bruce Evans wrote: > > > >> On Mon, 19 Nov 2018, Warner Losh wrote: > >> > >>> On Mon, Nov 19, 2018 at 12:31 AM Andriy Gapon wrote: > > ... > > I found my test program. > > >

svn commit: r340650 - head/share/mk

2018-11-19 Thread Ed Maste
Author: emaste Date: Mon Nov 19 20:48:47 2018 New Revision: 340650 URL: https://svnweb.freebsd.org/changeset/base/340650 Log: Avoid retpolineplt with static linking Statically linked binaries linked with -zretpolineplt crash at startup as lld produces a broken PLT. PR:

svn commit: r340649 - head/usr.bin/fortune/datfiles

2018-11-19 Thread Benedict Reuschling
Author: bcr (doc committer) Date: Mon Nov 19 20:45:49 2018 New Revision: 340649 URL: https://svnweb.freebsd.org/changeset/base/340649 Log: Add a fortune describing how to upload a machine's dmesg information to the NYCBUG database. We want to encourage our users to upload their dmesgs so

Re: svn commit: r340640 - head/lib/libc

2018-11-19 Thread Ed Maste
On Mon, 19 Nov 2018 at 14:38, Shawn Webb wrote: > > Since the use of ifunc in libc is only applicable to amd64, I wonder > if it would be best to disable BIND_NOW in > lib/libc/amd64/Makefile.inc. I don't believe there's any need to > disable BIND_NOW for libc on other architectures. At least

Re: svn commit: r340640 - head/lib/libc

2018-11-19 Thread Shawn Webb
On Mon, Nov 19, 2018 at 06:12:39PM +, Ed Maste wrote: > Author: emaste > Date: Mon Nov 19 18:12:39 2018 > New Revision: 340640 > URL: https://svnweb.freebsd.org/changeset/base/340640 > > Log: > libc: forcibly disable BIND_NOW > > Building libc WITH_BIND_NOW results in segfault at

svn commit: r340645 - head/tools/build

2018-11-19 Thread Alex Richardson
Author: arichardson Date: Mon Nov 19 18:58:34 2018 New Revision: 340645 URL: https://svnweb.freebsd.org/changeset/base/340645 Log: Add capsicum_helpers.h to -legacy if needed This fixes bootstrap of capsicumized strings on FreeBSD 11. Reviewed By: oshogbo, bdrewery Differential

Re: svn commit: r339476 - head/sys/i386/conf

2018-11-19 Thread Conrad Meyer
No. On Mon, Nov 19, 2018 at 7:58 AM Niclas Zeising wrote: > > On 10/20/18 9:16 PM, Conrad Meyer wrote: > > Author: cem > > Date: Sat Oct 20 19:16:43 2018 > > New Revision: 339476 > > URL: https://svnweb.freebsd.org/changeset/base/339476 > > > > Log: > >Add a MINIMAL config for i386, based on

svn commit: r340644 - in head/sys: dev/acpica kern sys

2018-11-19 Thread Ben Widawsky
Author: bwidawsk Date: Mon Nov 19 18:29:03 2018 New Revision: 340644 URL: https://svnweb.freebsd.org/changeset/base/340644 Log: acpi: fix acpi_ec_probe to only check EC devices This patch utilizes the fixed_devclass attribute in order to make sure other acpi devices with params don't get

svn commit: r340642 - head/lib/libthr/thread

2018-11-19 Thread Edward Tomasz Napierala
Author: trasz Date: Mon Nov 19 18:24:08 2018 New Revision: 340642 URL: https://svnweb.freebsd.org/changeset/base/340642 Log: Make libthr(3) use sysconf(_SC_NPROCESSORS_CONF); this shaves off two calls to sysctl(2) from the binary startup. Reviewed by: kib MFC after:2 weeks

svn commit: r340641 - head/lib/libc/gen

2018-11-19 Thread Edward Tomasz Napierala
Author: trasz Date: Mon Nov 19 18:23:17 2018 New Revision: 340641 URL: https://svnweb.freebsd.org/changeset/base/340641 Log: Make sysconf(_SC_PAGESIZE) return the value from getpagesize(3). That avoids a syscall - getpagesize(3) gets the value from the ELF aux strings. Reviewed by:

svn commit: r340640 - head/lib/libc

2018-11-19 Thread Ed Maste
Author: emaste Date: Mon Nov 19 18:12:39 2018 New Revision: 340640 URL: https://svnweb.freebsd.org/changeset/base/340640 Log: libc: forcibly disable BIND_NOW Building libc WITH_BIND_NOW results in segfault at process start. For now force BIND_NOW off until the root cause can be

svn commit: r340639 - head/sys/fs/fuse

2018-11-19 Thread Mark Johnston
Author: markj Date: Mon Nov 19 17:33:44 2018 New Revision: 340639 URL: https://svnweb.freebsd.org/changeset/base/340639 Log: Remove comments made obsolete by the ino64 work. MFC after:3 days Sponsored by: The FreeBSD Foundation Modified: head/sys/fs/fuse/fuse_internal.c

Re: svn commit: r333263 - in head: lib/libjail sys/cddl/contrib/opensolaris/uts/common/fs/zfs sys/compat/linprocfs sys/compat/linsysfs sys/fs/devfs sys/fs/fdescfs sys/fs/nullfs sys/fs/procfs sys/fs/ps

2018-11-19 Thread Alan Somers
On Fri, Nov 16, 2018 at 7:16 PM James Gritton wrote: > On 2018-11-16 16:30, Alan Somers wrote: > > On Fri, Nov 16, 2018 at 2:28 PM James Gritton wrote: > >> On 2018-11-16 10:34, Alan Somers wrote: >> >> On Fri, May 4, 2018 at 2:54 PM Jamie Gritton wrote: >> >>> Author: jamie >>> Date: Fri May

svn commit: r340638 - head/lib/libcasper/services/cap_dns

2018-11-19 Thread Mariusz Zaborski
Author: oshogbo Date: Mon Nov 19 17:22:52 2018 New Revision: 340638 URL: https://svnweb.freebsd.org/changeset/base/340638 Log: libcasper: provide compatibility with the old version of service Some external tools like tcpdump(1) have upstream the changes with old limits name. Because of

svn commit: r340637 - head/sys/vm

2018-11-19 Thread Alan Cox
Author: alc Date: Mon Nov 19 17:17:23 2018 New Revision: 340637 URL: https://svnweb.freebsd.org/changeset/base/340637 Log: Use swp_pager_isondev() throughout. Submitted by: o...@j.email.ne.jp Change swp_pager_isondev()'s return type to bool. Reviewed by: kib MFC after:1 week

svn commit: r340636 - head/sbin/bectl/tests

2018-11-19 Thread Kyle Evans
Author: kevans Date: Mon Nov 19 17:09:57 2018 New Revision: 340636 URL: https://svnweb.freebsd.org/changeset/base/340636 Log: bectl(8) tests: attempt to load the ZFS module Observed in a CI test image, bectl_create test will run and be marked as skipped because the module is not loaded.

svn commit: r340635 - head/lib/libbe

2018-11-19 Thread Kyle Evans
Author: kevans Date: Mon Nov 19 16:47:21 2018 New Revision: 340635 URL: https://svnweb.freebsd.org/changeset/base/340635 Log: libbe(3): Handle non-ZFS rootfs better If rootfs isn't ZFS, current version will emit an error claiming so and fail to initialize libbe. As a consumer, bectl -r

Re: svn commit: r340363 - in head: . contrib/tcpdump contrib/traceroute lib/libcasper/services/cap_dns lib/libcasper/services/cap_dns/tests sbin/ping

2018-11-19 Thread Ed Maste
On Mon, 12 Nov 2018 at 10:53, Mariusz Zaborski wrote: > > Author: oshogbo > Date: Mon Nov 12 15:52:45 2018 > New Revision: 340363 > URL: https://svnweb.freebsd.org/changeset/base/340363 > > Log: > libcasper: [ch]ange the name of limits in cap_dns so the intentions are > obvious. Mariusz and I

Re: svn commit: r340632 - head/sys/powerpc/conf

2018-11-19 Thread Niclas Zeising
On 11/19/18 4:42 PM, Justin Hibbits wrote: On Mon, 19 Nov 2018 15:36:58 + (UTC) Niclas Zeising wrote: Author: zeising (doc,ports committer) Date: Mon Nov 19 15:36:58 2018 New Revision: 340632 URL: https://svnweb.freebsd.org/changeset/base/340632 Log: Enable evdev on ppc64

Re: svn commit: r340450 - head/sys/sys

2018-11-19 Thread Bruce Evans
On Tue, 20 Nov 2018, Bruce Evans wrote: On Tue, 20 Nov 2018, Bruce Evans wrote: On Mon, 19 Nov 2018, Warner Losh wrote: On Mon, Nov 19, 2018 at 12:31 AM Andriy Gapon wrote: ... I found my test program. But I think I understand the problem now. mstosbt(1000) is overflowing with my

Re: svn commit: r339476 - head/sys/i386/conf

2018-11-19 Thread Niclas Zeising
On 10/20/18 9:16 PM, Conrad Meyer wrote: Author: cem Date: Sat Oct 20 19:16:43 2018 New Revision: 339476 URL: https://svnweb.freebsd.org/changeset/base/339476 Log: Add a MINIMAL config for i386, based on amd64 Any plans to MFC this? Regards -- Niclas Zeising

Re: svn commit: r340632 - head/sys/powerpc/conf

2018-11-19 Thread Justin Hibbits
On Mon, 19 Nov 2018 15:36:58 + (UTC) Niclas Zeising wrote: > Author: zeising (doc,ports committer) > Date: Mon Nov 19 15:36:58 2018 > New Revision: 340632 > URL: https://svnweb.freebsd.org/changeset/base/340632 > > Log: > Enable evdev on ppc64 > > Enable evdev on ppc64 as well,

svn commit: r340632 - head/sys/powerpc/conf

2018-11-19 Thread Niclas Zeising
Author: zeising (doc,ports committer) Date: Mon Nov 19 15:36:58 2018 New Revision: 340632 URL: https://svnweb.freebsd.org/changeset/base/340632 Log: Enable evdev on ppc64 Enable evdev on ppc64 as well, similar to what was done for amd64 and i386 in r340387. Evdev can be used by X

svn commit: r340631 - head/sys/compat/linux

2018-11-19 Thread Tijl Coosemans
Author: tijl Date: Mon Nov 19 15:31:54 2018 New Revision: 340631 URL: https://svnweb.freebsd.org/changeset/base/340631 Log: Do proper copyin of control message data in the Linux sendmsg syscall. Instead of calling m_append with a user address, allocate an mbuf cluster and copy data into

Re: svn commit: r340450 - head/sys/sys

2018-11-19 Thread Bruce Evans
On Tue, 20 Nov 2018, Bruce Evans wrote: On Mon, 19 Nov 2018, Warner Losh wrote: On Mon, Nov 19, 2018 at 12:31 AM Andriy Gapon wrote: As a side note, I wonder if those functions are ever used on negative values, given the type of the argument, and if anyone checked their correctness in

Re: svn commit: r340450 - head/sys/sys

2018-11-19 Thread Bruce Evans
On Mon, 19 Nov 2018, Warner Losh wrote: On Mon, Nov 19, 2018 at 12:31 AM Andriy Gapon wrote: On 19/11/2018 03:38, Warner Losh wrote: I'll talk to Allan to see if he can test that. the bare 1 should be handled properly because of C's promotion rules. 1ull << 32 is an unsigned long long.

svn commit: r340622 - head/sys/kern

2018-11-19 Thread Hans Petter Selasky
Author: hselasky Date: Mon Nov 19 09:36:09 2018 New Revision: 340622 URL: https://svnweb.freebsd.org/changeset/base/340622 Log: Minor code factoring. No functional change. MFC after:1 week Sponsored by: Mellanox Technologies Modified: head/sys/kern/kern_sysctl.c

svn commit: r340621 - head/sys/kern

2018-11-19 Thread Hans Petter Selasky
Author: hselasky Date: Mon Nov 19 09:35:16 2018 New Revision: 340621 URL: https://svnweb.freebsd.org/changeset/base/340621 Log: Be more verbose when a sysctl fails to unregister. Print name of sysctl in question. MFC after:1 week Sponsored by: Mellanox Technologies