Re: uninitialized variables [Was: svn commit: r365445 - head/sys/cam/mmc]

On 09/09/2020 08:49, Andriy Gapon wrote: > On 08/09/2020 15:48, Mark Johnston wrote: >> I observed the same thing recently as well: the compiler catches >> uninitialized variables only in simple cases. In my case, any uses of >> goto within the function seemed to silence the warning, even if they

uninitialized variables [Was: svn commit: r365445 - head/sys/cam/mmc]

On 08/09/2020 15:48, Mark Johnston wrote: > I observed the same thing recently as well: the compiler catches > uninitialized variables only in simple cases. In my case, any uses of > goto within the function seemed to silence the warning, even if they > appeared after the uninitialized reference.

svn commit: r365494 - head/lib/libc/tests/stdlib/dynthr_mod

Author: kevans Date: Wed Sep 9 02:45:47 2020 New Revision: 365494 URL: https://svnweb.freebsd.org/changeset/base/365494 Log: libc tests: dynthr_mod: fix some WARNS issues This is being addressed as part of a side-patch I'm working on that builds all the things with WARNS=6, instead of

svn commit: r365493 - head/lib/libc/tests/resolv

Author: kevans Date: Wed Sep 9 02:42:21 2020 New Revision: 365493 URL: https://svnweb.freebsd.org/changeset/base/365493 Log: libc/resolv: attempt to fix the test under WARNS=6 In a side-change that I'm working on to start defaulting src builds to WARNS=6 where WARNS isn't otherwise

svn commit: r365492 - head/share/man/man5

Author: kevans Date: Wed Sep 9 00:41:31 2020 New Revision: 365492 URL: https://svnweb.freebsd.org/changeset/base/365492 Log: src.conf(5): regen after r365491 Modified: head/share/man/man5/src.conf.5 Modified: head/share/man/man5/src.conf.5

svn commit: r365491 - head/share/mk

Author: kevans Date: Wed Sep 9 00:40:54 2020 New Revision: 365491 URL: https://svnweb.freebsd.org/changeset/base/365491 Log: opts: FREEBSD_UPDATE no longer relies on PORTSNAP phttpget is no longer tied to the portsnap build as of r365490. MFC after:3 days Differential Revision:

svn commit: r365490 - in head: libexec libexec/phttpget tools/build/mk usr.sbin/portsnap usr.sbin/portsnap/phttpget

Author: kevans Date: Wed Sep 9 00:39:47 2020 New Revision: 365490 URL: https://svnweb.freebsd.org/changeset/base/365490 Log: phttpget: move out of portsnap Currently, WITHOUT_PORTSNAP forces WITHOUT_FREEBSD_UPDATE because the latter relies on phttpget, which lives inside the portsnap

svn commit: r365489 - head/contrib/elftoolchain/libelf

Author: bdragon Date: Wed Sep 9 00:06:35 2020 New Revision: 365489 URL: https://svnweb.freebsd.org/changeset/base/365489 Log: [PowerPC64LE] PPC64LE support for libelf. Fix native detection when building on powerpc64le. I will be submitting this and r361104 upstream shortly.

svn commit: r365488 - head/sys/vm

Author: kib Date: Wed Sep 9 00:00:43 2020 New Revision: 365488 URL: https://svnweb.freebsd.org/changeset/base/365488 Log: Allow consumer to customize physical pager. Add support for user-supplied callbacks into phys pager operations, providing custom getpages(), haspage(), and

svn commit: r365486 - in head/sys: sys vm

Author: kib Date: Tue Sep 8 23:48:19 2020 New Revision: 365486 URL: https://svnweb.freebsd.org/changeset/base/365486 Log: Add kern_mmap_racct_check(), a helper to verify limits in vm_mmap*(). Reviewed by: markj Tested by:pho Sponsored by: The FreeBSD Foundation MFC after:1

svn commit: r365487 - head/sys/powerpc/powernv

Author: bdragon Date: Tue Sep 8 23:48:49 2020 New Revision: 365487 URL: https://svnweb.freebsd.org/changeset/base/365487 Log: [PowerPC64] Fix xive order calculation in qemu TCG When emulating a single thread system for testing reasons, mp_maxid can be 0. This trips up our math for

svn commit: r365485 - in head/sys: dev/ksyms dev/xen/gntdev kern

Author: kib Date: Tue Sep 8 23:38:49 2020 New Revision: 365485 URL: https://svnweb.freebsd.org/changeset/base/365485 Log: Convert allocations of the phys pager to vm_pager_allocate(). Future changes would require additional initialization of OBJT_PHYS objects, and vm_object_allocate()

svn commit: r365484 - head/sys/vm

Author: kib Date: Tue Sep 8 23:28:09 2020 New Revision: 365484 URL: https://svnweb.freebsd.org/changeset/base/365484 Log: Add interruptible variant of vm_wait(9), vm_wait_intr(9). Also add msleep flags argument to vm_wait_doms(9). Reviewed by: markj Tested by:pho Sponsored

svn commit: r365483 - head/stand/libofw

Author: bdragon Date: Tue Sep 8 23:22:11 2020 New Revision: 365483 URL: https://svnweb.freebsd.org/changeset/base/365483 Log: Fix 64-bit build of libofw. Adjust a couple of printf() lines that deal with dumping out addresses to cast to uintmax_t. This allows building a 64-bit

svn commit: r365481 - in head/sys/powerpc: aim powerpc

Author: bdragon Date: Tue Sep 8 22:59:43 2020 New Revision: 365481 URL: https://svnweb.freebsd.org/changeset/base/365481 Log: [PowerPC64] Hide dssall instruction from llvm assembler When doing a build for a modern CPUTYPE, llvm will throw errors if obsolete instructions are used, even

svn commit: r365479 - head/sys/powerpc/powerpc

Author: bdragon Date: Tue Sep 8 22:42:41 2020 New Revision: 365479 URL: https://svnweb.freebsd.org/changeset/base/365479 Log: [PowerPC] Add root_pic assertion. When enabling an interrupt, assert that we do in fact have a root PIC. This would have saved me some debugging effort.

svn commit: r365478 - in head/sys: crypto/armv8 dev/hifn dev/safe

Author: jhb Date: Tue Sep 8 22:41:35 2020 New Revision: 365478 URL: https://svnweb.freebsd.org/changeset/base/365478 Log: Don't return errors from the cryptodev_process() method. The cryptodev_process() method should either return 0 if it has completed a request, or ERESTART to defer

svn commit: r365477 - head/sys/geom/part

Author: eugen Date: Tue Sep 8 22:23:53 2020 New Revision: 365477 URL: https://svnweb.freebsd.org/changeset/base/365477 Log: geom_part: extend kern.geom.part.check_integrity to work on GPT There are multiple USB/SATA bridges on the market that unconditionally cut some LBAs off connected

Re: svn commit: r365475 - head/sys/net/route

On Tue, Sep 8, 2020 at 5:39 PM Alexander V. Chernikov wrote: > -CTLFLAG_VNET | CTLTYPE_U32 | CTLFLAG_RWTUN | CTLFLAG_MPSAFE, NULL, 0, > +CTLFLAG_VNET | CTLTYPE_U32 | CTLFLAG_MPSAFE, NULL, 0, Don't you still need CTLFLAG_RW? I don't believe that the sysctl is usable at all without it.

Re: svn commit: r364465 - in head/sys: conf net net/route

08.09.2020, 21:03, "Andriy Gapon" : > On 22/08/2020 00:34, Alexander V. Chernikov wrote: >>  Author: melifaro >>  Date: Fri Aug 21 21:34:52 2020 >>  New Revision: 364465 >>  URL: https://svnweb.freebsd.org/changeset/base/364465 >> >>  Log: >>    Make net.fibs growable. >> >>    Allow to

Re: svn commit: r365475 - head/sys/net/route

08.09.2020, 22:39, "Alexander V. Chernikov" : > Author: melifaro > Date: Tue Sep 8 21:39:34 2020 > New Revision: 365475 > URL: https://svnweb.freebsd.org/changeset/base/365475 > > Log: >   Fix panic with net.fibs tunable set in loader.conf. > >   Fix by removing forgotten CTLFLAG_RWTUN flag from

svn commit: r365475 - head/sys/net/route

Author: melifaro Date: Tue Sep 8 21:39:34 2020 New Revision: 365475 URL: https://svnweb.freebsd.org/changeset/base/365475 Log: Fix panic with net.fibs tunable set in loader.conf. Fix by removing forgotten CTLFLAG_RWTUN flag from the sysctl, loader variable will be read later in

Re: svn commit: r364465 - in head/sys: conf net net/route

On 22/08/2020 00:34, Alexander V. Chernikov wrote: > Author: melifaro > Date: Fri Aug 21 21:34:52 2020 > New Revision: 364465 > URL: https://svnweb.freebsd.org/changeset/base/364465 > > Log: > Make net.fibs growable. > > Allow to dynamically grow the amount of fibs in each vnet. > >

svn commit: r365466 - head/sys/modules/zfs

Author: mmacy Date: Tue Sep 8 17:47:30 2020 New Revision: 365466 URL: https://svnweb.freebsd.org/changeset/base/365466 Log: ZFS: remove some extra defines When merging a number of defines that are needed in the standalone build made it in to the module makefile. Reported by:

svn commit: r365464 - head/sys/kern

Author: mjg Date: Tue Sep 8 16:07:47 2020 New Revision: 365464 URL: https://svnweb.freebsd.org/changeset/base/365464 Log: fd: fix fhold on an uninitialized var in fdcopy_remapped Reported by: gcc9 Modified: head/sys/kern/kern_descrip.c Modified: head/sys/kern/kern_descrip.c

svn commit: r365463 - head/sys/kern

Author: mjg Date: Tue Sep 8 16:06:46 2020 New Revision: 365463 URL: https://svnweb.freebsd.org/changeset/base/365463 Log: cache: drop write-only tvp_seqc vars Modified: head/sys/kern/vfs_cache.c Modified: head/sys/kern/vfs_cache.c

svn commit: r365462 - head/sys/kern

Author: mjg Date: Tue Sep 8 16:06:26 2020 New Revision: 365462 URL: https://svnweb.freebsd.org/changeset/base/365462 Log: vfs: drop a write-only var in vfs_periodic_msync_inactive Modified: head/sys/kern/vfs_subr.c Modified: head/sys/kern/vfs_subr.c

Re: svn commit: r365460 - in head/sys/arm64: arm64 include

On Tue, Sep 8, 2020 at 12:36 PM Mitchell Horne wrote: > > Author: mhorne > Date: Tue Sep 8 15:36:38 2020 > New Revision: 365460 > URL: https://svnweb.freebsd.org/changeset/base/365460 > > Log: > arm64: export new HWCAP features > > Expose some of the new HWCAP features added in r65304. This

svn commit: r365461 - head/sys/libkern

Author: mhorne Date: Tue Sep 8 15:39:19 2020 New Revision: 365461 URL: https://svnweb.freebsd.org/changeset/base/365461 Log: arm64: check for CRC32 support via HWCAP Doing it this way eliminates the assumption about homogeneous support for the feature, since HWCAP values are only set if

svn commit: r365460 - in head/sys/arm64: arm64 include

Author: mhorne Date: Tue Sep 8 15:36:38 2020 New Revision: 365460 URL: https://svnweb.freebsd.org/changeset/base/365460 Log: arm64: export new HWCAP features Expose some of the new HWCAP features added in r65304. This includes the addition of elf_hwcap2 into the sysvec, and a separate

svn commit: r365459 - in head/sys: arm64/include sys

Author: mhorne Date: Tue Sep 8 15:08:20 2020 New Revision: 365459 URL: https://svnweb.freebsd.org/changeset/base/365459 Log: arm64: fix incorrect HWCAP definitions FreeBSD exports CPU features as bits in the AT_HWCAP and AT_HWCAP2 vectors via elf_aux_info(3). This interface is similar

svn commit: r365458 - head/usr.bin/sort

Author: gbe (doc committer) Date: Tue Sep 8 15:01:49 2020 New Revision: 365458 URL: https://svnweb.freebsd.org/changeset/base/365458 Log: sort(1): Remove duplicate option check Reviewed by: lwhsu, emaste Approved by: emaste Obtained from:DragonFlyBSD MFC after:1 week

svn commit: r365457 - head/sys/net

Author: kp Date: Tue Sep 8 14:54:10 2020 New Revision: 365457 URL: https://svnweb.freebsd.org/changeset/base/365457 Log: net: mitigate vnet / epair cleanup races There's a race where dying vnets move their interfaces back to their original vnet, and if_epair cleanup (where deleting one

Re: svn commit: r365449 - head/sbin/rcorder

Hi, I think this change warrants an entry in RELNOTES. Cheers, Mitchell On Tue, Sep 8, 2020 at 7:36 AM Andrey V. Elsukov wrote: > > Author: ae > Date: Tue Sep 8 10:36:11 2020 > New Revision: 365449 > URL: https://svnweb.freebsd.org/changeset/base/365449 > > Log: > Add a few features to

svn commit: r365456 - head/sys/conf

Author: mhorne Date: Tue Sep 8 13:24:44 2020 New Revision: 365456 URL: https://svnweb.freebsd.org/changeset/base/365456 Log: RISC-V: enable MK_FORMAT_EXTENSIONS This option was marked as broken because our riscv64-xtoolchain-gcc package lacked support. Since we are moving away from

svn commit: r365455 - in head/sys: dev/xilinx riscv/riscv

Author: mhorne Date: Tue Sep 8 13:21:13 2020 New Revision: 365455 URL: https://svnweb.freebsd.org/changeset/base/365455 Log: RISC-V: fix some mismatched format specifiers RISC-V is currently built with -Wno-format, which is how these went undetected. Address them now before re-enabling

Re: svn commit: r365445 - head/sys/cam/mmc

On Tue, Sep 08, 2020 at 02:24:59PM +0200, Michal Meloun wrote: > On 08.09.2020 9:10, Andriy Gapon wrote: > > On 08/09/2020 08:46, Andriy Gapon wrote: > >> Author: avg > >> Date: Tue Sep 8 05:46:10 2020 > >> New Revision: 365445 > >> URL: https://svnweb.freebsd.org/changeset/base/365445 > >> > >>

Re: svn commit: r365445 - head/sys/cam/mmc

On 08.09.2020 9:10, Andriy Gapon wrote: > On 08/09/2020 08:46, Andriy Gapon wrote: >> Author: avg >> Date: Tue Sep 8 05:46:10 2020 >> New Revision: 365445 >> URL: https://svnweb.freebsd.org/changeset/base/365445 >> >> Log: >> mmc_da: make sure that part_index is not used uninitialized in

Re: svn commit: r365445 - head/sys/cam/mmc

On 8 Sep 2020, at 7:10, Andriy Gapon wrote: On 08/09/2020 08:46, Andriy Gapon wrote: Author: avg Date: Tue Sep 8 05:46:10 2020 New Revision: 365445 URL: https://svnweb.freebsd.org/changeset/base/365445 Log: mmc_da: make sure that part_index is not used uninitialized in sddastart [snip]

svn commit: r365451 - head/sys/conf

Author: andrew Date: Tue Sep 8 11:46:33 2020 New Revision: 365451 URL: https://svnweb.freebsd.org/changeset/base/365451 Log: Move gpio and hwpmc to the correct place in files.arm64 Sponsored by: Innovate UK Modified: head/sys/conf/files.arm64 Modified: head/sys/conf/files.arm64

svn commit: r365450 - in head/sys: arm64/conf conf dev/gpio

Author: andrew Date: Tue Sep 8 11:35:35 2020 New Revision: 365450 URL: https://svnweb.freebsd.org/changeset/base/365450 Log: Add a GPIO driver for the Arm pl061 controller A PL061 is a simple 8 pin GPIO controller. This GPIO device is used to signal an internal request for shutdown on

svn commit: r365449 - head/sbin/rcorder

Author: ae Date: Tue Sep 8 10:36:11 2020 New Revision: 365449 URL: https://svnweb.freebsd.org/changeset/base/365449 Log: Add a few features to rcorder: o Enhance dependency loop logging: print full chain instead of the last link competing the loop; o Add -g option to generate

Re: svn commit: r365445 - head/sys/cam/mmc

On 08/09/2020 10:10, Andriy Gapon wrote: > On 08/09/2020 08:46, Andriy Gapon wrote: >> Author: avg >> Date: Tue Sep 8 05:46:10 2020 >> New Revision: 365445 >> URL: https://svnweb.freebsd.org/changeset/base/365445 >> >> Log: >> mmc_da: make sure that part_index is not used uninitialized in

Re: svn commit: r365445 - head/sys/cam/mmc

On 08/09/2020 08:46, Andriy Gapon wrote: > Author: avg > Date: Tue Sep 8 05:46:10 2020 > New Revision: 365445 > URL: https://svnweb.freebsd.org/changeset/base/365445 > > Log: > mmc_da: make sure that part_index is not used uninitialized in sddastart [snip] > Modified: head/sys/cam/mmc/mmc_da.c

svn commit: r365447 - head/sys/cam/mmc

Author: avg Date: Tue Sep 8 06:19:23 2020 New Revision: 365447 URL: https://svnweb.freebsd.org/changeset/base/365447 Log: mmc_da: universally use uint8_t for the partition index Also, assert in sdda_init_switch_part() that the index is within the defined range. MFC after:1 week

svn commit: r365446 - head/sys/cam/mmc

Author: avg Date: Tue Sep 8 06:18:34 2020 New Revision: 365446 URL: https://svnweb.freebsd.org/changeset/base/365446 Log: mmc_da: fix a typo and a too long line MFC after:1 week Modified: head/sys/cam/mmc/mmc_da.c Modified: head/sys/cam/mmc/mmc_da.c