svn commit: r298017 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

2016-04-14 Thread Alan Somers
Author: asomers Date: Thu Apr 14 23:14:41 2016 New Revision: 298017 URL: https://svnweb.freebsd.org/changeset/base/298017 Log: Add more debugging statements in vdev_geom.c Log a debugging message whenever geom functions fail in vdev_geom_attach. Printing these messages is controlled by vf

svn commit: r298072 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

2016-04-15 Thread Alan Somers
Author: asomers Date: Fri Apr 15 16:36:17 2016 New Revision: 298072 URL: https://svnweb.freebsd.org/changeset/base/298072 Log: Don't corrupt ZFS label's physpath attribute when booting while a disk is missing Prior to this change, vdev_geom_open_by_path would call vdev_geom_attach prior

svn commit: r298212 - head/sys/cam/scsi

2016-04-18 Thread Alan Somers
Author: asomers Date: Mon Apr 18 15:01:59 2016 New Revision: 298212 URL: https://svnweb.freebsd.org/changeset/base/298212 Log: Add the ability to read a SAS device's Target Port NAA designator sys/cam/scsi/scsi_all.h sys/cam/scsi/scsi_all.c Add the scsi_devid_is_port_naa helper fu

svn commit: r298420 - head/sys/geom

2016-04-21 Thread Alan Somers
Author: asomers Date: Thu Apr 21 16:43:15 2016 New Revision: 298420 URL: https://svnweb.freebsd.org/changeset/base/298420 Log: Notify userspace listeners when geom disk attributes have changed sys/geom/geom_disk.c: disk_attr_changed(): Generate a devctl event of type GEOM: for

Re: svn commit: r298420 - head/sys/geom

2016-04-21 Thread Alan Somers
On Thu, Apr 21, 2016 at 11:09 AM, Ngie Cooper wrote: > On Thu, Apr 21, 2016 at 10:08 AM, Ngie Cooper > wrote: > > On Thu, Apr 21, 2016 at 9:43 AM, Alan Somers > wrote: > >> Author: asomers > >> Date: Thu Apr 21 16:43:15 2016 > >> New Revision: 2

svn commit: r298439 - head/sys/geom

2016-04-21 Thread Alan Somers
Author: asomers Date: Thu Apr 21 21:13:41 2016 New Revision: 298439 URL: https://svnweb.freebsd.org/changeset/base/298439 Log: DRY on buffer sizes. Update to r298420. sys/geom/geom_disk.c: In disk_attr_changed, don't repeat a buffer size. Reported by: ngie, hselasky MFC afte

svn commit: r298483 - in head: etc/mtree usr.sbin/extattr usr.sbin/extattr/tests

2016-04-22 Thread Alan Somers
Author: asomers Date: Fri Apr 22 17:02:47 2016 New Revision: 298483 URL: https://svnweb.freebsd.org/changeset/base/298483 Log: Add ATF tests for usr.sbin/extattr Add ATF tests for the existing behavior of setextattr, rmextattr, lsextattr, and getextattr. Reviewed by: ngie MFC afte

svn commit: r298644 - head/sbin/devd

2016-04-26 Thread Alan Somers
Author: asomers Date: Tue Apr 26 14:48:58 2016 New Revision: 298644 URL: https://svnweb.freebsd.org/changeset/base/298644 Log: Add GEOM::physpath documentation to devd.conf(5) Suggested by: trasz Reviewed by: trasz MFC after:4 weeks Sponsored by: Spectra Logic Corp Differential

Re: svn commit: r298655 - head/sys/kgssapi

2016-04-26 Thread Alan Somers
Nice catch. Will you be MFCing this to stable/10? On Tue, Apr 26, 2016 at 12:11 PM, Conrad E. Meyer wrote: > Author: cem > Date: Tue Apr 26 18:11:45 2016 > New Revision: 298655 > URL: https://svnweb.freebsd.org/changeset/base/298655 > > Log: > kgssapi: Don't leak memory in error cases > > R

Re: svn commit: r298655 - head/sys/kgssapi

2016-04-26 Thread Alan Somers
isn't applicable to stable/10, or because the committer forgot it, or because the committer just "doesn't do stable". Please help maintain stable/10. It's everyone's job. -Alan On Tue, Apr 26, 2016 at 1:23 PM, Conrad Meyer wrote: > Nope! I don't do stable/.

svn commit: r298744 - head/usr.sbin/extattr/tests

2016-04-28 Thread Alan Somers
Author: asomers Date: Thu Apr 28 15:13:50 2016 New Revision: 298744 URL: https://svnweb.freebsd.org/changeset/base/298744 Log: Add PACKAGE fields to usr.sbin/extattr/tests/Makefile usr.sbin/extattr/tests/Makefile Add boiler plate required by 298107 but omitted by 298483. These

svn commit: r298786 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

2016-04-29 Thread Alan Somers
Author: asomers Date: Fri Apr 29 15:23:51 2016 New Revision: 298786 URL: https://svnweb.freebsd.org/changeset/base/298786 Log: Refactor vdev_geom_attach and friends to reduce code duplication sys/cddl/contrib/opensolaris/uts/common/fs/zfs/vdev_geom.c Move checks for provider's secto

svn commit: r298811 - in head: sys/kern tests/sys/kern

2016-04-29 Thread Alan Somers
Author: asomers Date: Fri Apr 29 21:11:31 2016 New Revision: 298811 URL: https://svnweb.freebsd.org/changeset/base/298811 Log: Automate the subr_unit test. Build and install the subr_unit test program originally written by phk, and run it with the other ATF tests. tests/sys/kern/Make

svn commit: r298814 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

2016-04-29 Thread Alan Somers
Author: asomers Date: Fri Apr 29 21:29:37 2016 New Revision: 298814 URL: https://svnweb.freebsd.org/changeset/base/298814 Log: Fix a use-after-free when "zpool import" fails clear vd->vdev_tsd in vdev_geom_close_locked instead of vdev_geom_detach. In the latter function, it would fail to

svn commit: r299085 - in head/usr.sbin/extattr: . tests

2016-05-04 Thread Alan Somers
Author: asomers Date: Wed May 4 20:20:55 2016 New Revision: 299085 URL: https://svnweb.freebsd.org/changeset/base/299085 Log: Allow setextattr(8) to take attribute values from stdin Add the -i option to setextattr. This option allow extended attribute data to be provided via stdin. Add a

svn commit: r299087 - in head/usr.sbin/extattr: . tests

2016-05-04 Thread Alan Somers
Author: asomers Date: Wed May 4 21:07:30 2016 New Revision: 299087 URL: https://svnweb.freebsd.org/changeset/base/299087 Log: Fix "getextattr -x" with non-ascii attribute values extattr/rmextattr.c When printing hex output, treat all attribute values as unsigned char arrays

svn commit: r299090 - in head: etc/mtree include lib/libbluetooth sbin/hastd share/man/man3 sys/dev/xen/blkback sys/kern sys/net sys/sys tests/sys tests/sys/sys usr.sbin/bluetooth/hccontrol

2016-05-04 Thread Alan Somers
Author: asomers Date: Wed May 4 22:34:11 2016 New Revision: 299090 URL: https://svnweb.freebsd.org/changeset/base/299090 Log: Improve performance and functionality of the bitstring(3) api Two new functions are provided, bit_ffs_at() and bit_ffc_at(), which allow for efficient searching o

svn commit: r299121 - in head/sys/dev: mpr mps

2016-05-05 Thread Alan Somers
Author: asomers Date: Thu May 5 15:32:47 2016 New Revision: 299121 URL: https://svnweb.freebsd.org/changeset/base/299121 Log: mpr(4) and mps(4) shouldn't indefinitely retry for "terminated ioc" errors Submitted by: ken Reviewed by: slm MFC after:4 weeks Sponsored by: Spectra Log

Re: svn commit: r299090 - in head: etc/mtree include lib/libbluetooth sbin/hastd share/man/man3 sys/dev/xen/blkback sys/kern sys/net sys/sys tests/sys tests/sys/sys usr.sbin/bluetooth/hccontrol

2016-05-05 Thread Alan Somers
On Thu, May 5, 2016 at 10:31 AM, John Baldwin wrote: > On Wednesday, May 04, 2016 10:34:11 PM Alan Somers wrote: > > Author: asomers > > Date: Wed May 4 22:34:11 2016 > > New Revision: 299090 > > URL: https://svnweb.freebsd.org/changeset/base/299090 > > >

Re: svn commit: r295707 - in head/sys: cddl/contrib/opensolaris/uts/common/fs/zfs dev/mmc dev/virtio/block geom geom/journal geom/mirror geom/raid geom/raid3 kern

2016-05-09 Thread Alan Somers
On Wed, Feb 17, 2016 at 10:16 AM, Warner Losh wrote: > Author: imp > Date: Wed Feb 17 17:16:02 2016 > New Revision: 295707 > URL: https://svnweb.freebsd.org/changeset/base/295707 > > Log: > Create an API to reset a struct bio (g_reset_bio). This is mandatory > for all struct bio you get back

Re: svn commit: r299371 - in head: sbin/camcontrol sys/cam sys/cam/scsi

2016-05-10 Thread Alan Somers
On Tue, May 10, 2016 at 9:46 AM, Edward Tomasz Napierala wrote: > Author: trasz > Date: Tue May 10 15:46:33 2016 > New Revision: 299371 > URL: https://svnweb.freebsd.org/changeset/base/299371 > > Log: > Add "camcontrol reprobe" subcommand, and implement it for da(4). > This makes it possible

svn commit: r289845 - head/sbin/savecore

2015-10-23 Thread Alan Somers
Author: asomers Date: Fri Oct 23 19:28:24 2015 New Revision: 289845 URL: https://svnweb.freebsd.org/changeset/base/289845 Log: Fix various Coverity issues in sbin/savecore/savecore.c: CID1009429: Fix unchecked return value from lseek while clearing dump CID1007781: Fix file descriptor lea

svn commit: r290400 - head/share/man/man4

2015-11-05 Thread Alan Somers
as written by -.An Alan Somers Aq Mt al...@spectralogic.com -and -.An John Suykerbuyk Aq Mt jo...@spectralogic.com . +.An Alan Somers Aq Mt asom...@freebsd.org +and John Suykerbuyk. .Sh CAVEATS Packets sent through Xennet pass over shared memory, so the protocol includes no form of link-layer c

svn commit: r290463 - head/sbin/savecore

2015-11-06 Thread Alan Somers
Author: asomers Date: Fri Nov 6 19:18:20 2015 New Revision: 290463 URL: https://svnweb.freebsd.org/changeset/base/290463 Log: Always check the return value of lseek. This is a follow-up to r289845, which only fixed one occurence of CID 1009429. Coverity CID: 1009429 Reviewed by:

Re: svn commit: r295768 - head/usr.sbin/iostat

2016-02-19 Thread Alan Somers
On Fri, Feb 19, 2016 at 5:24 AM, Sergey Kandaurov wrote: > On 18 February 2016 at 23:08, Alan Somers wrote: >> Author: asomers >> Date: Thu Feb 18 20:08:01 2016 >> New Revision: 295768 >> URL: https://svnweb.freebsd.org/changeset/base/295768 >> >> Lo

Re: svn commit: r295768 - head/usr.sbin/iostat

2016-02-21 Thread Alan Somers
On Sun, Feb 21, 2016 at 3:00 PM, Andrew Turner wrote: > On Thu, 18 Feb 2016 20:08:01 + (UTC) > Alan Somers wrote: > >> Author: asomers >> Date: Thu Feb 18 20:08:01 2016 >> New Revision: 295768 >> URL: https://svnweb.freebsd.org/changeset/base/295768 >>

svn commit: r295900 - head/usr.sbin/iostat

2016-02-22 Thread Alan Somers
Author: asomers Date: Mon Feb 22 21:40:53 2016 New Revision: 295900 URL: https://svnweb.freebsd.org/changeset/base/295900 Log: Fix the usr.sbin/iostat build with GCC, broken by r295768 Renamed some local variables for compatibility with -Wshadow Reported by: Andrew Turner Tested by:

Re: svn commit: r292074 - in head/sys/dev: nvd nvme

2016-03-10 Thread Alan Somers
Are you saying that Intel NVMe controllers perform poorly for all I/Os that are less than 128KB, or just for I/Os of any size that cross a 128KB boundary? On Thu, Dec 10, 2015 at 7:06 PM, Steven Hartland wrote: > Author: smh > Date: Fri Dec 11 02:06:03 2015 > New Revision: 292074 > URL: https://

Re: svn commit: r292074 - in head/sys/dev: nvd nvme

2016-03-10 Thread Alan Somers
t don't cross > the 128k boundary. > > Warner > > On Thu, Mar 10, 2016 at 11:01 AM, Alan Somers wrote: > >> Are you saying that Intel NVMe controllers perform poorly for all I/Os >> that are less than 128KB, or just for I/Os of any size that cross a 128KB >

Re: svn commit: r292074 - in head/sys/dev: nvd nvme

2016-03-11 Thread Alan Somers
restricting its ability to use large _or_ small record sizes. Hopefully the NVME slow path isn't _too_ slow. On Fri, Mar 11, 2016 at 2:07 AM, Alexander Motin wrote: > On 11.03.16 06:58, Alan Somers wrote: > > Do they behave badly for writes that cross a 128KB boundary, but are > &

Re: svn commit: r287445 - in head: bin/setfacl lib/libc/posix1e share/man/man9 sys/cddl/compat/opensolaris/kern sys/cddl/contrib/opensolaris/uts/common/sys sys/kern sys/sys tools/regression/acltools

2016-03-19 Thread Alan Somers
On Thu, Sep 3, 2015 at 6:14 PM, Xin LI wrote: > Author: delphij > Date: Fri Sep 4 00:14:20 2015 > New Revision: 287445 > URL: https://svnweb.freebsd.org/changeset/base/287445 > > Log: > Expose an interface to determine if an ACE is inherited. > > Submitted by: sef > Reviewed by: trasz >

Re: svn commit: r287445 - in head: bin/setfacl lib/libc/posix1e share/man/man9 sys/cddl/compat/opensolaris/kern sys/cddl/contrib/opensolaris/uts/common/sys sys/kern sys/sys tools/regression/acltools

2016-03-19 Thread Alan Somers
at 9:29 PM, Xin LI wrote: > > > > +sef who created the patch... > > > > On Wed, Mar 16, 2016 at 3:40 PM, Alan Somers > wrote: > >> > >> > >> On Thu, Sep 3, 2015 at 6:14 PM, Xin LI wrote: > >>> > >>> Author: delphij >

svn commit: r297838 - head/sbin/devd/tests

2016-04-11 Thread Alan Somers
Author: asomers Date: Mon Apr 11 22:14:29 2016 New Revision: 297838 URL: https://svnweb.freebsd.org/changeset/base/297838 Log: Fix an intermittent bug in sbin/devd/client_test.stream In case where the two events were being received in separate reads, the event buffer was being null-termin

Re: svn commit: r250953 - head/sys/cddl/contrib/opensolaris/uts/common/dtrace

2013-07-03 Thread Alan Somers
This creates another panic on module unload when WITNESS is enabled, because the module exits while holding the fasttrap_cleanup_mtx. This patch fixes the problem. I'm not sure if the mtx_destroy() is necessary, but I would feel dirty to leave it out. Does this patch look good to you? Index: sy

svn commit: r253046 - head/sbin/devd

2013-07-08 Thread Alan Somers
Author: asomers Date: Mon Jul 8 21:10:30 2013 New Revision: 253046 URL: http://svnweb.freebsd.org/changeset/base/253046 Log: Correct the printf format specifier for total_events. Add __printflike argument checking for devdlog(). Reported by: pjd Approved by: gibbs (co-mentor) Modified

Re: svn commit: r253924 - in head: etc etc/rc.d share/man/man5

2013-08-22 Thread Alan Somers
With this revision, I am unable to down an ipv4 interface using "/etc/rc.d/netif stop em1". When I try, ipv4_down cannot find the address to delete, because "$_inet" begins with a tab character and the therefore it matches the "*)" rule in the case statement. Presumably "$_inet" doesn't always be

svn commit: r254743 - head/etc

2013-08-23 Thread Alan Somers
Author: asomers Date: Fri Aug 23 23:12:16 2013 New Revision: 254743 URL: http://svnweb.freebsd.org/changeset/base/254743 Log: Correctly remove an interface's ipv4 address when the user calls "/etc/rc.d/netif stop XXX". The old globbing pattern failed to account for the possibility of a tab

svn commit: r257006 - head/sbin/geom/class/part

2013-10-23 Thread Alan Somers
Author: asomers Date: Wed Oct 23 18:58:11 2013 New Revision: 257006 URL: http://svnweb.freebsd.org/changeset/base/257006 Log: sbin/geom/class/part/geom_part.c Always validate the return of find_geomcfg(). It could be NULL, for example when the geom is withering. Approved by

Re: svn commit: r252481 - in head: etc sbin/devd

2013-11-07 Thread Alan Somers
On Thu, Nov 7, 2013 at 5:11 AM, Andriy Gapon wrote: > > First, apologies for this very delayed reaction. > > on 02/07/2013 00:20 Alan Somers said the following: >> Author: asomers >> Date: Mon Jul 1 21:20:17 2013 >> New Revision: 252481 >> URL: http://svnw

svn commit: r310118 - head/bin/ls/tests

2016-12-15 Thread Alan Somers
Author: asomers Date: Thu Dec 15 16:13:52 2016 New Revision: 310118 URL: https://svnweb.freebsd.org/changeset/base/310118 Log: Fix ls_tests:o_flag with ZFS TMPDIR Unlike UFS or TMPFS, ZFS sets uarch automatically whenever a file is updated. The test must explicitly clear uarch to be porta

svn commit: r310180 - head/sys/net

2016-12-16 Thread Alan Somers
Author: asomers Date: Fri Dec 16 22:39:30 2016 New Revision: 310180 URL: https://svnweb.freebsd.org/changeset/base/310180 Log: Fix panic during lagg destruction with simultaneous status check If you run "ifconfig lagg0 destroy" and "ifconfig lagg0" at the same time a page fault may result

Re: svn commit: r310180 - head/sys/net

2016-12-16 Thread Alan Somers
On Fri, Dec 16, 2016 at 3:45 PM, Mateusz Guzik wrote: > On Fri, Dec 16, 2016 at 10:39:31PM +0000, Alan Somers wrote: >> Author: asomers >> Date: Fri Dec 16 22:39:30 2016 >> New Revision: 310180 >> URL: https://svnweb.freebsd.org/changeset/base/310180 >> &

Re: svn commit: r310180 - head/sys/net

2016-12-20 Thread Alan Somers
On Tue, Dec 20, 2016 at 7:52 AM, Ryan Stone wrote: > > > On Fri, Dec 16, 2016 at 5:39 PM, Alan Somers wrote: >> >> >> Modified: head/sys/net/if_lagg.c >> >> == >> --- head/sy

svn commit: r310327 - head/sys/net

2016-12-20 Thread Alan Somers
Author: asomers Date: Tue Dec 20 15:45:53 2016 New Revision: 310327 URL: https://svnweb.freebsd.org/changeset/base/310327 Log: Remove stray debugging code from r310180 Reported by: rstone Pointy hat to:asomers MFC after:3 weeks X-MFC-with: 310180 Sponsored by: Spectra

svn commit: r310417 - head/sys/boot/forth

2016-12-22 Thread Alan Somers
Author: asomers Date: Thu Dec 22 15:48:54 2016 New Revision: 310417 URL: https://svnweb.freebsd.org/changeset/base/310417 Log: Add a dumpdev example to /boot/defaults/loader.conf Submitted by: rgrimes MFC after:4 weeks Sponsored by: Spectra Logic Corp Modified: head/sys/boot/fort

svn commit: r310786 - head/tests/sys/geom/class/eli

2016-12-29 Thread Alan Somers
Author: asomers Date: Thu Dec 29 20:28:50 2016 New Revision: 310786 URL: https://svnweb.freebsd.org/changeset/base/310786 Log: Reduce the runtime of the GELI tests There is no reduction in test coverage. On my system runtime is reduced from 38m32s to 6m24s. tests/sys/geom/class/eli/

svn commit: r310803 - head/tests/sys/geom/class/nop

2016-12-29 Thread Alan Somers
22:38 2016 (r310803) @@ -0,0 +1,166 @@ +# Copyright (c) 2016 Alan Somers +# All rights reserved. +# +# Redistribution and use in source and binary forms, with or without +# modification, are permitted provided that the following conditions +# are met: +# 1. Redistributions of source code must

svn commit: r310985 - head

2016-12-31 Thread Alan Somers
Author: asomers Date: Sat Dec 31 21:31:58 2016 New Revision: 310985 URL: https://svnweb.freebsd.org/changeset/base/310985 Log: Update ObsoleteFiles.inc for r310803 MFC after:26 days X-MFC-with: 310803 Modified: head/ObsoleteFiles.inc Modified: head/ObsoleteFiles.inc

svn commit: r311160 - head/sys/dev/mpr

2017-01-03 Thread Alan Somers
Author: asomers Date: Tue Jan 3 17:35:16 2017 New Revision: 311160 URL: https://svnweb.freebsd.org/changeset/base/311160 Log: misc minor fixes in mpr(4) sys/dev/mpr/mpr_sas.c * Fix a potential null pointer dereference (CID 1305731) * Check for overrun of the ccb_scsiio.cdb_

svn commit: r311210 - head/usr.sbin/diskinfo

2017-01-03 Thread Alan Somers
Author: asomers Date: Wed Jan 4 00:39:06 2017 New Revision: 311210 URL: https://svnweb.freebsd.org/changeset/base/311210 Log: Quell Coverity for diskinfo(8) * CID 1198994: Don't run the speed disk on a disk with no sectors * CID 1011442: Don't call close(2) if open(2) fails * CID 10111

svn commit: r311288 - head/usr.bin/chat

2017-01-04 Thread Alan Somers
Author: asomers Date: Wed Jan 4 16:24:40 2017 New Revision: 311288 URL: https://svnweb.freebsd.org/changeset/base/311288 Log: Delete dead code in chat(8) It's always been dead, ever since first import in 1994. It's still dead in OpenBSD's version, too. Reported by: Coverity CID:

svn commit: r311292 - head/usr.bin/rpcgen

2017-01-04 Thread Alan Somers
Author: asomers Date: Wed Jan 4 17:39:20 2017 New Revision: 311292 URL: https://svnweb.freebsd.org/changeset/base/311292 Log: Remove dead code in rpc_parse.c It's been dead ever since it was imported from TI-RPC in 1995. The dead code is still present in Illumos today, but was removed f

svn commit: r311298 - head/sbin/dhclient

2017-01-04 Thread Alan Somers
Author: asomers Date: Wed Jan 4 18:13:05 2017 New Revision: 311298 URL: https://svnweb.freebsd.org/changeset/base/311298 Log: Remove dead code in dhclient(8) The offending code has been dead ever since the import from OpenBSD in r195805. OpenBSD later deleted that entire function.

svn commit: r311305 - in head/sys: cam cam/ctl cam/scsi dev/aac dev/aacraid dev/advansys dev/aha dev/ahb dev/ahci dev/aic dev/aic7xxx dev/amr dev/arcmsr dev/ata dev/buslogic dev/ciss dev/dpt dev/es...

2017-01-04 Thread Alan Somers
Author: asomers Date: Wed Jan 4 20:26:42 2017 New Revision: 311305 URL: https://svnweb.freebsd.org/changeset/base/311305 Log: Always null-terminate ccb_pathinq.(sim_vid|hba_vid|dev_name) The sim_vid, hba_vid, and dev_name fields of struct ccb_pathinq are fixed-length strings. AFAICT the

svn commit: r311340 - head/usr.bin/tail

2017-01-04 Thread Alan Somers
Author: asomers Date: Wed Jan 4 23:22:34 2017 New Revision: 311340 URL: https://svnweb.freebsd.org/changeset/base/311340 Log: Misc Coverity fixes for tail(1) CID 1006402: Initialize stack variable CID 271580: Don't leak memory when ENOMEM. Reported by: Coverity CID: 2

svn commit: r311349 - head/etc/mtree

2017-01-04 Thread Alan Somers
Author: asomers Date: Thu Jan 5 02:47:56 2017 New Revision: 311349 URL: https://svnweb.freebsd.org/changeset/base/311349 Log: tabs -> spaces in etc/mtree MFC after:4 weeks Modified: head/etc/mtree/BSD.tests.dist head/etc/mtree/BSD.var.dist Modified: head/etc/mtree/BSD.tests.dist

svn commit: r311445 - head/etc/mtree

2017-01-05 Thread Alan Somers
Author: asomers Date: Thu Jan 5 15:07:04 2017 New Revision: 311445 URL: https://svnweb.freebsd.org/changeset/base/311445 Log: Fix typo from r311349 Reported by: lwhsu Pointy-hat-to:asomers MFC after:4 weeks X-MFC-with: 311349 Modified: head/etc/mtree/BSD.tests.dist

svn commit: r311572 - in head/usr.bin/cmp: . tests

2017-01-06 Thread Alan Somers
== --- /dev/null 00:00:00 1970 (empty, because file is newly added) +++ head/usr.bin/cmp/tests/cmp_test2.sh Sat Jan 7 00:59:06 2017 (r311572) @@ -0,0 +1,67 @@ +# Copyright (c) 2017 Alan Somers +# All rights reserved

svn commit: r311893 - in head: . tests/sys/geom/class/gate

2017-01-10 Thread Alan Somers
Author: asomers Date: Tue Jan 10 20:35:09 2017 New Revision: 311893 URL: https://svnweb.freebsd.org/changeset/base/311893 Log: ATFify the geom gate tests. This ensures their cleanup routines will be run even if they should timeout. tests/sys/geom/class/gate/ggate_test.sh tests/sys/ge

svn commit: r311894 - head

2017-01-10 Thread Alan Somers
Author: asomers Date: Tue Jan 10 20:37:44 2017 New Revision: 311894 URL: https://svnweb.freebsd.org/changeset/base/311894 Log: Fix typo from change 310985 in ObsoleteFiles.inc MFC after:16 days X-MFC-With: 310803 Sponsored by: Spectra Logic Corp Modified: head/ObsoleteFiles.inc

svn commit: r311895 - in head: etc/mtree usr.bin/tail usr.bin/tail/tests

2017-01-10 Thread Alan Somers
= tests + +ATF_TESTS_SH= tail_test + +.include Added: head/usr.bin/tail/tests/tail_test.sh == --- /dev/null 00:00:00 1970 (empty, because file is newly added) +++ head/usr.bin/tail/tests/tail_test.shTue Ja

svn commit: r311928 - head/usr.bin/tail

2017-01-11 Thread Alan Somers
Author: asomers Date: Wed Jan 11 16:09:25 2017 New Revision: 311928 URL: https://svnweb.freebsd.org/changeset/base/311928 Log: Fix build of usr.bin/tail with GCC Submitted by: pluknet Reported by: pluknet MFC after:27 days X-MFC-with: 311895 Sponsored by: Spectra Logic Corp

Re: svn commit: r311895 - in head: etc/mtree usr.bin/tail usr.bin/tail/tests

2017-01-11 Thread Alan Somers
On Wed, Jan 11, 2017 at 5:53 AM, Sergey Kandaurov wrote: > On 10 January 2017 at 23:43, Alan Somers wrote: >> >> Author: asomers >> Date: Tue Jan 10 20:43:32 2017 >> New Revision: 311895 >> URL: https://svnweb.freebsd.org/changeset/base/311895 >> >> L

svn commit: r311985 - head/usr.sbin/route6d

2017-01-12 Thread Alan Somers
Author: asomers Date: Thu Jan 12 16:22:28 2017 New Revision: 311985 URL: https://svnweb.freebsd.org/changeset/base/311985 Log: Fix uninitialized variable CIDs in route6d The variables in question are actually return arguments, but it's still good form to initialize them. Reported by:

svn commit: r312395 - head/sbin/devd

2017-01-18 Thread Alan Somers
Author: asomers Date: Wed Jan 18 20:24:37 2017 New Revision: 312395 URL: https://svnweb.freebsd.org/changeset/base/312395 Log: Fix several Coverity CIDs in devd CID 1362055, 1362054: File descriptor leaks during shutdown CID 1362013: Potential null-termination fail with long network devic

Re: svn commit: r286700 - in head: sbin/ifconfig sys/net

2017-01-18 Thread Alan Somers
Is the change to lacp_port_create correct? The comment indicates that fast is configurable, but it's actually constant. Later on, there's some dead code that depends on the value of fast (it was dead before this commit, too). CID: 1305734 CID: 1305692 -Alan On Wed, Aug 12, 2015 at 2:21 PM, Hir

svn commit: r312396 - head/cddl/usr.sbin/zfsd

2017-01-18 Thread Alan Somers
Author: asomers Date: Wed Jan 18 22:10:18 2017 New Revision: 312396 URL: https://svnweb.freebsd.org/changeset/base/312396 Log: Fix an unchecked return value in zfsd It's pretty unlikely to actually hit this, but good to check it anyway Reported by: Coverity CID: 1362018 M

svn commit: r312417 - head/sbin/devd

2017-01-19 Thread Alan Somers
Author: asomers Date: Thu Jan 19 16:59:55 2017 New Revision: 312417 URL: https://svnweb.freebsd.org/changeset/base/312417 Log: Fix build of devd with GCC 4.2 Reported by: olivier Pointy-hat-to:asomers MFC after:27 days X-MFC-with: 312395 Sponsored by: Spectra Logic Co

Re: svn commit: r312395 - head/sbin/devd

2017-01-19 Thread Alan Somers
On Thu, Jan 19, 2017 at 2:24 AM, Olivier Cochard-Labbé wrote: > On Wed, Jan 18, 2017 at 9:24 PM, Alan Somers wrote: >> >> Author: asomers >> Date: Wed Jan 18 20:24:37 2017 >> New Revision: 312395 >> URL: https://svnweb.freebsd.org/changeset/base/312395 >>

svn commit: r312553 - head/sys/cam/scsi

2017-01-20 Thread Alan Somers
Author: asomers Date: Fri Jan 20 17:54:24 2017 New Revision: 312553 URL: https://svnweb.freebsd.org/changeset/base/312553 Log: Fix "camcontrol timestamp -s" with LTO-7 drives The length of the scsi_set_timestamp_parameters struct was incorrect. LTO-5 drives don't care, but LTO-7 drives d

svn commit: r312558 - head/sbin/camcontrol

2017-01-20 Thread Alan Somers
Author: asomers Date: Fri Jan 20 21:21:41 2017 New Revision: 312558 URL: https://svnweb.freebsd.org/changeset/base/312558 Log: Misc Coverity fixes in camcontrol(8) CID 1229913 Fix output of "camcontrol persist -i report_capabilities". The reported Persistent Reservation Ty

svn commit: r312559 - head/usr.sbin/camdd

2017-01-20 Thread Alan Somers
Author: asomers Date: Fri Jan 20 21:40:04 2017 New Revision: 312559 URL: https://svnweb.freebsd.org/changeset/base/312559 Log: Fix misc Coverity defects in camdd(8) CID 1341620 Fix a small memory leak CID 1341630 Though this is technically a false positive, rearrange the

svn commit: r312913 - head/tests/sys/aio

2017-01-27 Thread Alan Somers
Author: asomers Date: Sat Jan 28 04:33:51 2017 New Revision: 312913 URL: https://svnweb.freebsd.org/changeset/base/312913 Log: Improve the aio tests * Add tests for aio_suspend(2). * Add tests for polled completion notification. * Test the full matrix of file descriptor types and comple

svn commit: r312995 - head/sys/dev/mpr

2017-01-30 Thread Alan Somers
Author: asomers Date: Mon Jan 30 19:49:08 2017 New Revision: 312995 URL: https://svnweb.freebsd.org/changeset/base/312995 Log: Initialize a stack variable in mprsas_get_sas_address_for_sata_disk Thought it's difficult to reproduce, I think this variable was responsible for a use-after-fre

Re: svn commit: r313008 - head/tests/sys/geom/class/gate

2017-01-31 Thread Alan Somers
I think wait_for_ggate_device should also be used at line 32, which calls "ggatec create". -Alan On Mon, Jan 30, 2017 at 11:12 PM, Ngie Cooper wrote: > Author: ngie > Date: Tue Jan 31 06:12:51 2017 > New Revision: 313008 > URL: https://svnweb.freebsd.org/changeset/base/313008 > > Log: > Wait fo

svn commit: r313025 - head/tests/sys/netinet

2017-01-31 Thread Alan Somers
Author: asomers Date: Tue Jan 31 20:13:50 2017 New Revision: 313025 URL: https://svnweb.freebsd.org/changeset/base/313025 Log: Add tests for multi-fib IPv6 routing PR: 196361 Submitted by: jhujh...@adjectivism.org Reported by: Jason Healy MFC after:4 weeks Sponsored

svn commit: r365262 - head/usr.bin/nfsstat

2020-09-02 Thread Alan Somers
Author: asomers Date: Wed Sep 2 17:36:30 2020 New Revision: 365262 URL: https://svnweb.freebsd.org/changeset/base/365262 Log: Fix output of nfsstat -cE in json or xml mode Due to a copy/paste error, the "getacl" field was duplicated, but only in XML or JSON mode, not in txt mode. Di

svn commit: r365389 - head/sys/crypto/via

2020-09-06 Thread Alan Somers
Author: asomers Date: Sun Sep 6 19:25:31 2020 New Revision: 365389 URL: https://svnweb.freebsd.org/changeset/base/365389 Log: padlock(4): fix instapanics with geli authentication cryptodev_process implementations are supposed to return 0 PR: 247986 Submitted by: jhb MFC

svn commit: r365391 - head/share/man/man5

2020-09-06 Thread Alan Somers
Author: asomers Date: Sun Sep 6 20:32:13 2020 New Revision: 365391 URL: https://svnweb.freebsd.org/changeset/base/365391 Log: nsswitch.conf(5): recommend placing cache after files When cache precedes files, and nscd is configured to allow negative caching, commands like "pw groupadd" can

Re: svn commit: r364637 - head/sys/kern

2020-09-06 Thread Alan Somers
On Mon, Aug 24, 2020 at 3:01 AM Mateusz Guzik wrote: > Author: mjg > Date: Mon Aug 24 09:00:57 2020 > New Revision: 364637 > URL: https://svnweb.freebsd.org/changeset/base/364637 > > Log: > cache: lockless reverse lookup > > This enables fully scalable operation for getcwd and significantly >

svn commit: r365415 - head/share/man/man5

2020-09-07 Thread Alan Somers
Author: asomers Date: Mon Sep 7 13:44:54 2020 New Revision: 365415 URL: https://svnweb.freebsd.org/changeset/base/365415 Log: nsswitch.conf.5: style fixes Fix some whitespace, and remove the .Tn macro Reported by: mandoc, igor Reviewed by: bcr (manpages) MFC after:1 week D

svn commit: r365549 - head/bin/cp

2020-09-09 Thread Alan Somers
Author: asomers Date: Thu Sep 10 02:48:55 2020 New Revision: 365549 URL: https://svnweb.freebsd.org/changeset/base/365549 Log: cp: use copy_file_range(2) This has three advantages over write(2)/read(2): * Fewer context switches and data copies * Mostly preserves a file's sparseness

svn commit: r365643 - head/bin/cp

2020-09-11 Thread Alan Somers
Author: asomers Date: Fri Sep 11 20:49:36 2020 New Revision: 365643 URL: https://svnweb.freebsd.org/changeset/base/365643 Log: cp: fall back to read/write if copy_file_range fails Even though copy_file_range has a file-system agnostic version, it still fails on devfs (perhaps because the

Re: svn commit: r365643 - head/bin/cp

2020-09-19 Thread Alan Somers
On Fri, Sep 11, 2020 at 3:52 PM Rick Macklem wrote: > Konstantin Belousov wrote: > >On Fri, Sep 11, 2020 at 08:49:36PM +0000, Alan Somers wrote: > >> Author: asomers > >> Date: Fri Sep 11 20:49:36 2020 > >> New Revision: 365643 > >> URL: htt

svn commit: r365910 - head/lib/libc/gen

2020-09-19 Thread Alan Somers
Author: asomers Date: Sat Sep 19 19:08:27 2020 New Revision: 365910 URL: https://svnweb.freebsd.org/changeset/base/365910 Log: fix integer underflow in getgrnam_r and getpwnam_r Sometimes nscd(8) will return a 1-byte buffer for a nonexistent entry. This triggered an integer underflow in g

Re: svn commit: r365643 - head/bin/cp

2020-09-19 Thread Alan Somers
On Sat, Sep 19, 2020 at 5:32 PM Konstantin Belousov wrote: > On Sat, Sep 19, 2020 at 11:18:56PM +, Rick Macklem wrote: > > Alan Somers wrote: > > >On Fri, Sep 11, 2020 at 3:52 PM Rick Macklem <mailto:rmack...@uoguelph.ca>> wrote: > > >Konstantin Belousov

svn commit: r365956 - head/tools/regression/fsx

2020-09-21 Thread Alan Somers
Author: asomers Date: Mon Sep 21 17:48:28 2020 New Revision: 365956 URL: https://svnweb.freebsd.org/changeset/base/365956 Log: fsx: fix build with WARNS=6 * signed/unsigned comparisons * use standard warn(3) * Suppress warnings about local vars and funcs not declared static * const-co

Re: svn commit: r365643 - head/bin/cp

2020-09-22 Thread Alan Somers
On Tue, Sep 22, 2020 at 2:48 PM Kyle Evans wrote: > On Fri, Sep 11, 2020 at 3:49 PM Alan Somers wrote: > > > > Author: asomers > > Date: Fri Sep 11 20:49:36 2020 > > New Revision: 365643 > > URL: https://svnweb.freebsd.org/changeset/base/365643 > > > &

Re: svn commit: r365643 - head/bin/cp

2020-09-22 Thread Alan Somers
Sep 22, 2020 at 2:54 PM Mateusz Guzik wrote: > Can we instead add a workaround to the build tree? > > Where is cp /dev/null coming from anyway? Perhaps this can be patched > to touch the target file. > > On 9/22/20, Alan Somers wrote: > > On Tue, Sep 22, 2020 at 2:48 PM Kyle E

Re: svn commit: r365643 - head/bin/cp

2020-09-22 Thread Alan Somers
tftp.h arpa/tftp.h; \ > for i in _time.h _strings.h _string.h; do \ > - [ -f xlocale/$$i ] || cp /dev/null xlocale/$$i; \ > + [ -f xlocale/$$i ] || :> xlocale/$$i; \ > done; \ > for i in ${STAND_H_INC}; do \ >

Re: svn commit: r365643 - head/bin/cp

2020-09-22 Thread Alan Somers
+1. On Tue, Sep 22, 2020 at 3:27 PM Kyle Evans wrote: > I'm running a build at the suggestion of mjg to confirm there aren't > any others hiding that can be converted, and I will commit after I've > verified that this is it. > > On Tue, Sep 22, 2020 at 4:02 PM Al

Re: svn commit: r365643 - head/bin/cp

2020-09-22 Thread Alan Somers
>> >> >> >> On Tue, Sep 22, 2020 at 3:27 PM Kyle Evans wrote: >> >>> >> >>> I'm running a build at the suggestion of mjg to confirm there aren't >> >>> any others hiding that can be converted, and I will commit after I'

Re: svn commit: r365643 - head/bin/cp

2020-09-22 Thread Alan Somers
Go ahead and commit. Consider it reviewed by me. And if I understand correctly, this commit means there's no need for a special updating procedure, right? On Tue, Sep 22, 2020 at 6:55 PM Warner Losh wrote: > > > On Tue, Sep 22, 2020 at 5:17 PM Kyle Evans wrote: > >> On Tue, Sep 22, 2020, 17:0

svn commit: r366118 - head/sys/kern

2020-09-24 Thread Alan Somers
Author: asomers Date: Thu Sep 24 15:38:01 2020 New Revision: 366118 URL: https://svnweb.freebsd.org/changeset/base/366118 Log: Fix some signed/unsigned comparison warnings in NFS Reviewed by: rmacklem MFC after:2 weeks Differential Revision:https://reviews.freebsd.org/D2653

svn commit: r366121 - in head: sys/fs/fuse tests/sys/fs/fusefs

2020-09-24 Thread Alan Somers
Author: asomers Date: Thu Sep 24 16:27:53 2020 New Revision: 366121 URL: https://svnweb.freebsd.org/changeset/base/366121 Log: fusefs: fix mmap'd writes in direct_io mode If a FUSE server returns FOPEN_DIRECT_IO in response to FUSE_OPEN, that instructs the kernel to bypass the page cache

svn commit: r366131 - head/lib/libc/tests/sys

2020-09-24 Thread Alan Somers
Author: asomers Date: Thu Sep 24 21:39:09 2020 New Revision: 366131 URL: https://svnweb.freebsd.org/changeset/base/366131 Log: lib/libc/tests/sys: raise WARNS to 6 MFC after:2 weeks Modified: head/lib/libc/tests/sys/Makefile Modified: head/lib/libc/tests/sys/Makefile ===

svn commit: r366132 - head/lib/libc/tests/iconv

2020-09-24 Thread Alan Somers
Author: asomers Date: Thu Sep 24 21:42:44 2020 New Revision: 366132 URL: https://svnweb.freebsd.org/changeset/base/366132 Log: lib/libc/tests/iconv: raise WARNS to 6 MFC after:2 weeks Modified: head/lib/libc/tests/iconv/Makefile head/lib/libc/tests/iconv/iconvctl_test.c Modified:

svn commit: r366207 - head/lib/libc/gen

2020-09-27 Thread Alan Somers
Author: asomers Date: Sun Sep 27 22:26:41 2020 New Revision: 366207 URL: https://svnweb.freebsd.org/changeset/base/366207 Log: Misc compiler warning fixes in lib/libc Reviewed by: kevans, imp MFC after:2 weeks Differential Revision:https://reviews.freebsd.org/D26534 Modifi

Re: svn commit: r366207 - head/lib/libc/gen

2020-09-27 Thread Alan Somers
On Sun, Sep 27, 2020 at 5:15 PM Konstantin Belousov wrote: > On Sun, Sep 27, 2020 at 10:26:41PM +0000, Alan Somers wrote: > > Author: asomers > > Date: Sun Sep 27 22:26:41 2020 > > New Revision: 366207 > > URL: https://svnweb.freebsd.org/changeset/base/366207 >

svn commit: r366365 - head/tests/sys/fs/fusefs

2020-10-02 Thread Alan Somers
Author: asomers Date: Fri Oct 2 17:06:05 2020 New Revision: 366365 URL: https://svnweb.freebsd.org/changeset/base/366365 Log: fusefs tests: quell Coverity "Argument cannot be negative" warnings Must abort tests early if open(2) fails. Reported by: Coverity Coverity CID: 1432810 and

<    4   5   6   7   8   9   10   >