svn commit: r215686 - head/sys/dev/mxge

2010-11-22 Thread Andrew Gallatin
Author: gallatin Date: Mon Nov 22 16:43:05 2010 New Revision: 215686 URL: http://svn.freebsd.org/changeset/base/215686 Log: Fix a TSO checksum bug on mxge(4): The Myri10GE NIC will assume all TSO frames contain partial checksum, and will emit TSO segments with bad TCP checksums if a TSO

svn commit: r208312 - head/sys/dev/mxge

2010-05-19 Thread Andrew Gallatin
Author: gallatin Date: Wed May 19 20:00:15 2010 New Revision: 208312 URL: http://svn.freebsd.org/changeset/base/208312 Log: Correctly identify some twinax cables, which report a media type of 1. Modified: head/sys/dev/mxge/if_mxge.c Modified: head/sys/dev/mxge/if_mxge.c

svn commit: r223957 - head/sys/dev/mxge

2011-07-12 Thread Andrew Gallatin
Author: gallatin Date: Tue Jul 12 14:43:49 2011 New Revision: 223957 URL: http://svn.freebsd.org/changeset/base/223957 Log: Fix media reporting for dual port CX4 myri10ge NICs MFC after: 7 days Sponsored by: Myricom, Inc. Modified: head/sys/dev/mxge/if_mxge.c Modified:

svn commit: r204212 - head/sys/dev/mxge

2010-02-22 Thread Andrew Gallatin
Author: gallatin Date: Mon Feb 22 16:57:03 2010 New Revision: 204212 URL: http://svn.freebsd.org/changeset/base/204212 Log: Update mxge to support IFCAP_VLAN_HWTSO. Note: If/when FreeBSD supports TSO over IPv6, the minimal mxge fw rev to enable IFCAP_VLAN_HWTSO will need to be increased

Re: svn commit: r205221 - head/sys/dev/bge

2010-03-17 Thread Andrew Gallatin
Pyun YongHyeon wrote: Revert r205090. It's hard to know when the mail box register write will get flushed to the hardware and it may take longer. Pointed out by: scottl I may be mis-reading the code, but it looks like the mailbox register is in memory space, which should be

svn commit: r205255 - head/sys/dev/mxge

2010-03-17 Thread Andrew Gallatin
Author: gallatin Date: Wed Mar 17 20:13:09 2010 New Revision: 205255 URL: http://svn.freebsd.org/changeset/base/205255 Log: Fix 2 bugs in mxge_attach() - Don't leak slice resources when mxge_alloc_rings() fails - Start taskq threads only after we know attach will succeed. At boot

svn commit: r206662 - head/sys/dev/mxge

2010-04-15 Thread Andrew Gallatin
Author: gallatin Date: Thu Apr 15 13:50:55 2010 New Revision: 206662 URL: http://svn.freebsd.org/changeset/base/206662 Log: Cleanup if_media handling in mxge(4) - Re-probe xfp / sfp+ socket on link events, in case user has changed transceiver - correctly report current media to

svn commit: r206663 - head/sys/dev/mxge

2010-04-15 Thread Andrew Gallatin
Author: gallatin Date: Thu Apr 15 14:26:52 2010 New Revision: 206663 URL: http://svn.freebsd.org/changeset/base/206663 Log: Add missing IFCAP_LINKSTATE to mxge Submitted by: yongari Modified: head/sys/dev/mxge/if_mxge.c Modified: head/sys/dev/mxge/if_mxge.c

svn commit: r220385 - head/sys/dev/mxge

2011-04-06 Thread Andrew Gallatin
Author: gallatin Date: Wed Apr 6 15:45:32 2011 New Revision: 220385 URL: http://svn.freebsd.org/changeset/base/220385 Log: Implement mxge_init() This fixes a long standing bug in mxge(4) where ifconfig mxge0 $IP did not bring the interface into a RUNNING state, like it does on most

svn commit: r220424 - head/sys/dev/mxge

2011-04-07 Thread Andrew Gallatin
Author: gallatin Date: Thu Apr 7 13:49:44 2011 New Revision: 220424 URL: http://svn.freebsd.org/changeset/base/220424 Log: Fix a bug in mxge's LRO which can cause dup acks to get aggregated hence prevent TCP from entering fast retransmit. Pointed out by: jeff Reviewed by: gnn MFC

svn commit: r247011 - in head/sys: dev/mxge modules/mxge/mxge

2013-02-19 Thread Andrew Gallatin
Author: gallatin Date: Tue Feb 19 21:33:21 2013 New Revision: 247011 URL: http://svnweb.freebsd.org/changeset/base/247011 Log: Add support to mxge for IPv6 TX csum offload IPv6 TSO. Sponsored by: Myricom, Inc. MFC after: 7 days Modified: head/sys/dev/mxge/if_mxge.c

svn commit: r247104 - head/sys/netinet

2013-02-21 Thread Andrew Gallatin
Author: gallatin Date: Thu Feb 21 17:00:35 2013 New Revision: 247104 URL: http://svnweb.freebsd.org/changeset/base/247104 Log: Fix tcp_lro_rx_ipv4() for drivers that do not set CSUM_IP_CHECKED. Specifcially, in_cksum_hdr() returns 0 (not 0x) when the IPv4 checksum is correct. Without

svn commit: r247133 - in head/sys: conf dev/mxge modules/mxge/mxge

2013-02-21 Thread Andrew Gallatin
Author: gallatin Date: Thu Feb 21 21:28:33 2013 New Revision: 247133 URL: http://svnweb.freebsd.org/changeset/base/247133 Log: Improve mxge's receive performance for IPv6: - Add support for IPv6 rx csum offload - Finally switch mxge from using its own driver lro, to using tcp_lro

svn commit: r247152 - head/sys/dev/mxge

2013-02-22 Thread Andrew Gallatin
Author: gallatin Date: Fri Feb 22 16:46:28 2013 New Revision: 247152 URL: http://svnweb.freebsd.org/changeset/base/247152 Log: Try harder to make mxge safe for all combinations of INET and INET6 - Re-fix build by restoring local removed in r247151, but protected by #if defined(INET) ||

svn commit: r247159 - head/sys/dev/mxge

2013-02-22 Thread Andrew Gallatin
Author: gallatin Date: Fri Feb 22 19:21:29 2013 New Revision: 247159 URL: http://svnweb.freebsd.org/changeset/base/247159 Log: Improvements for newer mxge nics: - Some mxge nics may store the serial number in the SN2 field of the EEPROM. These will also have an SN=0 field, so parse

svn commit: r247160 - head/sys/dev/mxge

2013-02-22 Thread Andrew Gallatin
Author: gallatin Date: Fri Feb 22 19:23:33 2013 New Revision: 247160 URL: http://svnweb.freebsd.org/changeset/base/247160 Log: Bump mxge copyright. Sponsored by: Myricom MFC After: 7 days Modified: head/sys/dev/mxge/if_mxge.c head/sys/dev/mxge/if_mxge_var.h Modified:

svn commit: r247268 - head/sys/dev/mxge

2013-02-25 Thread Andrew Gallatin
Author: gallatin Date: Mon Feb 25 16:22:40 2013 New Revision: 247268 URL: http://svnweb.freebsd.org/changeset/base/247268 Log: Several cleanups and fixes to mxge: - Remove vestigial null pointer tests after malloc(..., M_WAITOK). - Remove vestigal qualhack union - Use strlcpy()

Re: svn commit: r280971 - in head: contrib/ipfilter/tools share/man/man4 sys/contrib/ipfilter/netinet sys/netinet sys/netipsec sys/netpfil/pf

2015-05-14 Thread Andrew Gallatin
On 04/02/2015 11:24 AM, Hans Petter Selasky wrote: If we are transmitting using TSO, will the network adapter increment the IP ID field somehow? What happens if an outgoing IP packet resulting Sorry for the delayed reply; I was just catching up on FreeBSD email, and I'm not sure that the

svn commit: r284612 - head/sys/dev/ixl

2015-06-19 Thread Andrew Gallatin
Author: gallatin Date: Fri Jun 19 21:40:26 2015 New Revision: 284612 URL: https://svnweb.freebsd.org/changeset/base/284612 Log: Fix typo in baudrate initialization that was causing ixl to be seen as a 4GbE NIC, rather than a 40GbE NIC. Reviewed by: Eric Joyner eric.joy...@intel.com

Re: svn commit: r290650 - in head/sys: dev/mlx5 dev/mlx5/mlx5_core dev/mlx5/mlx5_en modules/mlx5 modules/mlx5en

2015-11-10 Thread Andrew Gallatin
On 11/10/2015 07:20, Hans Petter Selasky wrote: Author: hselasky Date: Tue Nov 10 12:20:22 2015 New Revision: 290650 URL: https://svnweb.freebsd.org/changeset/base/290650 Log: Add mlx5 and mlx5en driver(s) for ConnectX-4 and ConnectX-4LX cards from Mellanox Technologies. The current

Re: svn commit: r292949 - head/sys/dev/mlx5/mlx5_en

2016-01-02 Thread Andrew Gallatin
On 12/30/2015 10:01, Hans Petter Selasky wrote: Author: hselasky Date: Wed Dec 30 15:01:47 2015 New Revision: 292949 URL: https://svnweb.freebsd.org/changeset/base/292949 Log: Add support for modifying coalescing parameters runtime. Thank you -- this will be very helpful! Drew

svn commit: r303626 - in head/sys: netinet netinet6

2016-08-01 Thread Andrew Gallatin
Author: gallatin Date: Mon Aug 1 17:02:21 2016 New Revision: 303626 URL: https://svnweb.freebsd.org/changeset/base/303626 Log: Rework IPV6 TCP path MTU discovery to match IPv4 - Re-write tcp_ctlinput6() to closely mimic the IPv4 tcp_ctlinput() - Now that tcp_ctlinput6() updates

svn commit: r303457 - head/sys/netinet

2016-07-28 Thread Andrew Gallatin
Author: gallatin Date: Thu Jul 28 19:32:25 2016 New Revision: 303457 URL: https://svnweb.freebsd.org/changeset/base/303457 Log: Call tcp_notify() directly to shoot down routes, rather than calling in_pcbnotifyall(). This avoids lock contention on tcbinfo due to in_pcbnotifyall()

svn commit: r306637 - head/sys/vm

2016-10-03 Thread Andrew Gallatin
Author: gallatin Date: Mon Oct 3 13:23:43 2016 New Revision: 306637 URL: https://svnweb.freebsd.org/changeset/base/306637 Log: Conditionally move initial vfs bio alloc above 4G On machines with just the wrong amount of physical memory (enough to have a lot of bufs, but not enough to use

svn commit: r307673 - head/sys/net

2016-10-20 Thread Andrew Gallatin
Author: gallatin Date: Thu Oct 20 13:48:29 2016 New Revision: 307673 URL: https://svnweb.freebsd.org/changeset/base/307673 Log: Clear mbuf hashtype on loopback when RSS is enabled. The hashtype on an outgoing mbuf reflects the correct hash on the transmit side of the connection. If this

svn commit: r321790 - head/sbin/sysctl

2017-07-31 Thread Andrew Gallatin
Author: gallatin Date: Mon Jul 31 14:56:35 2017 New Revision: 321790 URL: https://svnweb.freebsd.org/changeset/base/321790 Log: Don't request CTLTYPE_OPAQUE if we can't print them. The intent is to skip expensive opaque sysctls like tcp_pcblist unless they are explicitly requested.

svn commit: r320738 - head/sys/kern

2017-07-06 Thread Andrew Gallatin
Author: gallatin Date: Thu Jul 6 15:03:54 2017 New Revision: 320738 URL: https://svnweb.freebsd.org/changeset/base/320738 Log: Simplify UIO_SYSSPACE and UIO_NOCOPY paths in uiomove Uiomove can only block when the segflag is UIO_USERSPACE, otherwise we end up just doing a bcopy (or

svn commit: r333325 - head/sys/kern

2018-05-07 Thread Andrew Gallatin
Author: gallatin Date: Mon May 7 15:24:03 2018 New Revision: 25 URL: https://svnweb.freebsd.org/changeset/base/25 Log: Boost thread priority while changing CPU frequency Boost the priority of user-space threads when they set their affinity to a core to adjust its frequency.

svn commit: r333459 - head/sys/kern

2018-05-10 Thread Andrew Gallatin
Author: gallatin Date: Thu May 10 13:19:42 2018 New Revision: 333459 URL: https://svnweb.freebsd.org/changeset/base/333459 Log: Fix the build after r333457 In r333457, the arguments to kern_pwritev() were accidentally re-ordered as part of ANSIfication, breaking the build. Modified:

Re: svn commit: r333457 - head/sys/kern

2018-05-10 Thread Andrew Gallatin
On 05/10/18 07:36, Ed Maste wrote: Author: emaste Date: Thu May 10 11:36:16 2018 New Revision: 333457 URL:

svn commit: r333462 - head/sys/netinet6

2018-05-10 Thread Andrew Gallatin
Author: gallatin Date: Thu May 10 16:19:41 2018 New Revision: 333462 URL: https://svnweb.freebsd.org/changeset/base/333462 Log: Fix a panic in the IPv6 multicast code. Use LIST_FOREACH_SAFE in in6m_disconnect() since we're deleting and freeing item from the membership list while

Re: svn commit: r333470 - in head: share/mk sys/conf

2018-05-10 Thread Andrew Gallatin
On 05/10/18 16:10, Ed Maste wrote: Author: emaste Date: Thu May 10 20:10:02 2018 New Revision: 333470 URL:

Re: svn commit: r333470 - in head: share/mk sys/conf

2018-05-10 Thread Andrew Gallatin
On 05/10/18 19:14, Ed Maste wrote: On 10 May 2018 at 18:24, Andrew Gallatin <galla...@cs.duke.edu> wrote: Rather than erroring out, we please just use the appropriate linker? That's my goal, but it's a bit of an involved change and will take some time to make sure we don't introdu

Re: svn commit: r333470 - in head: share/mk sys/conf

2018-05-10 Thread Andrew Gallatin
On 05/10/18 20:11, Ed Maste wrote: On 10 May 2018 at 20:00, Andrew Gallatin <galla...@cs.duke.edu> wrote: Unfortunately, it looks like this method will get blown away by an installworld: Ah. You can set WITH_LLD_IS_LD in /etc/src.conf and installworld will install ld as a symlink to

svn commit: r333329 - head/sys/net

2018-05-07 Thread Andrew Gallatin
Author: gallatin Date: Mon May 7 18:11:22 2018 New Revision: 29 URL: https://svnweb.freebsd.org/changeset/base/29 Log: Fix an off-by-one error when deciding to request a tx interrupt The canonical check for whether or not a ring is drainable is TXQ_AVAIL() > MAX_TX_DESC() + 2.

Re: svn commit: r333703 - head/sys/vm

2018-05-17 Thread Andrew Gallatin
On 05/17/18 14:07, Mark Johnston wrote: On Thu, May 17, 2018 at 10:07:34AM -0700, Conrad Meyer wrote: On Wed, May 16, 2018 at 9:27 PM, Mark Johnston wrote: Author: markj Date: Thu May 17 04:27:08 2018 New Revision: 333703 URL:

Re: svn commit: r334143 - head/sys/dev/cxgbe

2018-05-24 Thread Andrew Gallatin
On 05/24/18 06:18, Navdeep Parhar wrote: Log: cxgbe(4): Data path for rate-limited tx. This is hardware support for the SO_MAX_PACING_RATE sockopt (see setsockopt(2)), which is available in kernels built with "options RATELIMIT". Relnotes: Yes Sponsored by:

svn commit: r333793 - head/usr.sbin/pmcannotate

2018-05-18 Thread Andrew Gallatin
Author: gallatin Date: Fri May 18 14:14:04 2018 New Revision: 333793 URL: https://svnweb.freebsd.org/changeset/base/333793 Log: Teach pmcannotate about $TMPDIR and _PATH_TMP Convert pmcannotate to using $TMPDIR and _PATH_TMP rather than hard coding /tmp for temporary files. Pmcannotate

svn commit: r333655 - head/sys/sys

2018-05-15 Thread Andrew Gallatin
Author: gallatin Date: Tue May 15 23:55:38 2018 New Revision: 333655 URL: https://svnweb.freebsd.org/changeset/base/333655 Log: Unhook DEBUG_BUFRING from INVARIANTS Some of the DEBUG_BUFRING checks are racy, and can lead to spurious assertions when run under high load. Unhook these

svn commit: r333131 - head/sys/net

2018-04-30 Thread Andrew Gallatin
Author: gallatin Date: Mon Apr 30 23:53:27 2018 New Revision: 333131 URL: https://svnweb.freebsd.org/changeset/base/333131 Log: Fix iflib_encap() EFBIG handling bugs 1) Don't give up if m_collapse() fails. Rather than giving up, try m_defrag() immediately. 2) Fix a leak where, if

svn commit: r333141 - head/sys/dev/cxgbe

2018-05-01 Thread Andrew Gallatin
Author: gallatin Date: Tue May 1 15:33:21 2018 New Revision: 333141 URL: https://svnweb.freebsd.org/changeset/base/333141 Log: Optionally panic when cxgbe encounters a fatal error Sometimes it is better to panic than to leave a machine unreachable. Reviewed by: np Sponsored by:

svn commit: r337709 - head/sys/net

2018-08-13 Thread Andrew Gallatin
Author: gallatin Date: Mon Aug 13 14:13:25 2018 New Revision: 337709 URL: https://svnweb.freebsd.org/changeset/base/337709 Log: lagg: allow lacp to manage the link state Lacp needs to manage the link state itself. Unlike other lagg protocols, the ability of lacp to pass traffic depends

Re: svn commit: r337709 - head/sys/net

2018-08-14 Thread Andrew Gallatin
It could probably be MFCed if somebody could verify that it causes no harm in 11. I have no way to test lagg/lacp on 11, so I did not mark it for MFC. Drew On 8/13/18 9:58 PM, Kubilay Kocak wrote: On 14/08/2018 12:13 am, Andrew Gallatin wrote: Author: gallatin Date: Mon Aug 13 14:13:25 2018

svn commit: r338341 - head/sys/netinet6

2018-08-27 Thread Andrew Gallatin
Author: gallatin Date: Mon Aug 27 18:13:20 2018 New Revision: 338341 URL: https://svnweb.freebsd.org/changeset/base/338341 Log: Reject IPv4 SO_REUSEPORT_LB groups when looking up an IPv6 listening socket Similar to how the IPv4 code will reject an IPv6 LB group, we must ignore IPv4 LB

Re: svn commit: r335967 - head/sys/dev/mxge

2018-07-04 Thread Andrew Gallatin
On 7/4/18 9:20 PM, Rodney W. Grimes wrote: On 07/04/18 15:46, Rodney W. Grimes wrote: Author: gallatin Date: Wed Jul 4 19:29:06 2018 New Revision: 335967 URL:

svn commit: r335973 - head/sys/dev/mxge

2018-07-04 Thread Andrew Gallatin
Author: gallatin Date: Thu Jul 5 02:43:10 2018 New Revision: 335973 URL: https://svnweb.freebsd.org/changeset/base/335973 Log: mxge: replace 65536 with IP_MAXPACKET in tso settings. Modified: head/sys/dev/mxge/if_mxge.c Modified: head/sys/dev/mxge/if_mxge.c

Re: svn commit: r335967 - head/sys/dev/mxge

2018-07-04 Thread Andrew Gallatin
On 07/04/18 15:46, Rodney W. Grimes wrote: Author: gallatin Date: Wed Jul 4 19:29:06 2018 New Revision: 335967 URL:

Re: svn commit: r335916 - head/sys/conf

2018-07-07 Thread Andrew Gallatin
On 07/05/18 19:59, John Baldwin wrote: You misunderstand. /usr/local/sys/modules would hold module sources so that they can be recompiled when building a kernel without having to rebuild the package or reinstall the package. Binary modules would continue to be installed in /boot/modules.

Re: svn commit: r335967 - head/sys/dev/mxge

2018-07-07 Thread Andrew Gallatin
On 07/05/18 17:14, Rick Macklem wrote: Andrew Gallatin wrote: On 7/4/18 9:20 PM, Rodney W. Grimes wrote: [stuff snipped] It is using a magic constant twice, where one has a derived value that is dependent on the value of the other. That is bad and error prone and does not document that one

Re: svn commit: r336042 - head/sys/dev/cxgbe/common

2018-07-07 Thread Andrew Gallatin
On 07/06/18 15:33, Navdeep Parhar wrote: Log: cxgbe(4): Assume that any unknown flash on the card is 4MB and has 64KB sectors, instead of refusing to attach to the card. Thank you! Drew ___ svn-src-head@freebsd.org mailing list

svn commit: r335957 - head/sys/dev/mxge

2018-07-04 Thread Andrew Gallatin
Author: gallatin Date: Wed Jul 4 14:25:38 2018 New Revision: 335957 URL: https://svnweb.freebsd.org/changeset/base/335957 Log: mxge: fix panic at module unload r333175 (multicast changes) exposed a bug where mxge was not checking to see if the driver was being unloaded while handing

svn commit: r335966 - head/sys/dev/mxge

2018-07-04 Thread Andrew Gallatin
Author: gallatin Date: Wed Jul 4 18:54:44 2018 New Revision: 335966 URL: https://svnweb.freebsd.org/changeset/base/335966 Log: mxge: Add SIOCGI2C support for devices with SFP/XFP cages Modified: head/sys/dev/mxge/if_mxge.c Modified: head/sys/dev/mxge/if_mxge.c

Re: svn commit: r335966 - head/sys/dev/mxge

2018-07-04 Thread Andrew Gallatin
On 07/04/18 14:54, Andrew Gallatin wrote: mxge: Add SIOCGI2C support for devices with SFP/XFP cages Note that I do not have any XFP devices to test with, only SFP and CX4. If this causes problems for XFP devices, I can restrict SIOCGI2C support to just SFP if needed. Drew

svn commit: r335967 - head/sys/dev/mxge

2018-07-04 Thread Andrew Gallatin
Author: gallatin Date: Wed Jul 4 19:29:06 2018 New Revision: 335967 URL: https://svnweb.freebsd.org/changeset/base/335967 Log: mxge: choose appropriate values for hw tso Modified: head/sys/dev/mxge/if_mxge.c Modified: head/sys/dev/mxge/if_mxge.c

svn commit: r332645 - head/sbin/ifconfig

2018-04-17 Thread Andrew Gallatin
Author: gallatin Date: Tue Apr 17 12:54:58 2018 New Revision: 332645 URL: https://svnweb.freebsd.org/changeset/base/332645 Log: Make lagg creation more fault tolerant - Warn, don't exit, when SIOCSLAGGPORT returns an error. When we exit with an error during lagg creation, a single

svn commit: r332653 - head/sys/dev/ixgbe

2018-04-17 Thread Andrew Gallatin
Author: gallatin Date: Tue Apr 17 16:51:27 2018 New Revision: 332653 URL: https://svnweb.freebsd.org/changeset/base/332653 Log: Restore SIOCGI2C functionality to ixgbe When ixgbe was converted to iflib, it lost the SIOCGI2C support that allows ifconfig to print SFP state, optical light

Re: svn commit: r332645 - head/sbin/ifconfig

2018-04-17 Thread Andrew Gallatin
On 04/17/18 09:47, Kubilay Kocak wrote: Log: Make lagg creation more fault tolerant <...> MFC please? <..> Hmm.. I intentionally did not mark it for MFC, for 2 reasons. I don't run -stable, and I hate to MFC something when I haven't run it. And I'm also worried because it

Re: svn commit: r332860 - head/sys/kern

2018-04-24 Thread Andrew Gallatin
On 04/24/18 13:24, Jonathan T. Looney wrote: On Mon, Apr 23, 2018 at 6:04 PM, John Baldwin > wrote: > > I think this is actually a key question.  In my experience to date I have not > encountered a large number of post-panic assertion failures. 

Re: svn commit: r340097 - in head/sys: kern sys

2018-11-12 Thread Andrew Gallatin
On 11/2/18 11:43 PM, Matt Macy wrote: Author: mmacy Date: Sat Nov 3 03:43:32 2018 New Revision: 340097 URL:

svn commit: r339043 - in head/sys: kern vm x86/acpica

2018-10-01 Thread Andrew Gallatin
Author: gallatin Date: Mon Oct 1 14:14:21 2018 New Revision: 339043 URL: https://svnweb.freebsd.org/changeset/base/339043 Log: Allow empty NUMA memory domains to support Threadripper2 The AMD Threadripper 2990WX is basically a slightly crippled Epyc. Rather than having 4 memory

Re: svn commit: r339043 - in head/sys: kern vm x86/acpica

2018-10-01 Thread Andrew Gallatin
On 10/1/18 10:14 AM, Andrew Gallatin wrote: Author: gallatin Date: Mon Oct 1 14:14:21 2018 New Revision: 339043 URL: https://urldefense.proofpoint.com/v2/url?u=https-3A__svnweb.freebsd.org_changeset_base_339043=DwIDaQ=imBPVzF25OnBgGmVOlcsiEgHoG1i6YHLR0Sj_gZ4adc=Ed

Re: svn commit: r343030 - in head/sys: cam conf dev/md dev/nvme fs/fuse fs/nfsclient fs/smbfs kern sys ufs/ffs vm

2019-01-15 Thread Andrew Gallatin
On 1/14/19 8:02 PM, Gleb Smirnoff wrote: Log: Allocate pager bufs from UMA instead of 80-ish mutex protected linked list. <...> Together with: gallatin Thank you so much for carrying this over the finish line! Drew ___

Re: svn commit: r343269 - head/sys/dev/cxgbe

2019-01-21 Thread Andrew Gallatin
On 1/21/19 1:42 PM, Navdeep Parhar wrote: Log: cxgbe(4): Allow negative values in hw.cxgbe.fw_install and take them to Thank you! Drew ___ svn-src-head@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-head To

Re: svn commit: r341578 - head/sys/dev/mlx5/mlx5_en

2018-12-17 Thread Andrew Gallatin
On 12/17/18 2:08 PM, Bruce Evans wrote: On Mon, 17 Dec 2018, Andrew Gallatin wrote: On 12/5/18 9:20 AM, Slava Shwartsman wrote: Author: slavash Date: Wed Dec  5 14:20:57 2018 New Revision: 341578 URL: https://urldefense.proofpoint.com/v2/url?u=https

Re: svn commit: r341578 - head/sys/dev/mlx5/mlx5_en

2018-12-17 Thread Andrew Gallatin
On 12/5/18 9:20 AM, Slava Shwartsman wrote: Author: slavash Date: Wed Dec 5 14:20:57 2018 New Revision: 341578 URL:

svn commit: r341095 - head/sys/net

2018-11-27 Thread Andrew Gallatin
Author: gallatin Date: Tue Nov 27 20:01:05 2018 New Revision: 341095 URL: https://svnweb.freebsd.org/changeset/base/341095 Log: Use busdma unconditionally in iflib - Remove the complex mechanism to choose between using busdma and raw pmap_kextract at runtime. The reduced complexity

svn commit: r342774 - head/sys/conf

2019-01-04 Thread Andrew Gallatin
Author: gallatin Date: Fri Jan 4 18:38:27 2019 New Revision: 342774 URL: https://svnweb.freebsd.org/changeset/base/342774 Log: Limit git history searches in newvers.sh newvers.sh takes upwards of 4-5 seconds to complete on trees checked out from github, due to searching the entire

Re: svn commit: r344099 - head/sys/net

2019-02-22 Thread Andrew Gallatin
I think the misunderstanding here is that I think he's not getting the ifp from the route. My recollection is that he is holding the ifps when he enables HW pacing in BBR. Due to limitations in different NIC hardware, you can only have N different rates, etc. So he goes ahead and allocates

Re: svn commit: r344817 - in head/sys: dev/e1000 net

2019-03-08 Thread Andrew Gallatin
On 3/5/19 4:06 PM, Matthew Macy wrote: This represents a misunderstanding of how defines are used. This left the option open to the user to enable the use of larger than page size buffers as it does enable better performance. Over the course of a long uptime memory can get too fragmented.

svn commit: r345273 - head/sys/kern

2019-03-18 Thread Andrew Gallatin
Author: gallatin Date: Mon Mar 18 12:41:42 2019 New Revision: 345273 URL: https://svnweb.freebsd.org/changeset/base/345273 Log: Fix a typo introduced in r344133 The line was misedited to change tt to st instead of changing ut to st. The use of st as the denominator in

Re: svn commit: r345138 - head/share/man/man9

2019-03-15 Thread Andrew Gallatin
On 3/14/19 11:36 PM, Rodney W. Grimes wrote: [ Charset UTF-8 unsupported, converting... ] On Thu, 14 Mar 2019 at 22:39, Rodney W. Grimes wrote: 4. There is no easy way to show "changed byte at offset 0x432 from 0xef to 0xfe" How do we represent Copyright and License in such objects?

svn commit: r343430 - head/sys/net

2019-01-25 Thread Andrew Gallatin
Author: gallatin Date: Fri Jan 25 15:02:18 2019 New Revision: 343430 URL: https://svnweb.freebsd.org/changeset/base/343430 Log: Fix an iflib driver unload panic introduced in r343085 The new loop to sync and unload descriptors was indexed by "i", rather than "j". The panic was caused

svn commit: r346247 - head/sys/dev/mlx5/mlx5_en

2019-04-15 Thread Andrew Gallatin
Author: gallatin Date: Mon Apr 15 17:14:50 2019 New Revision: 346247 URL: https://svnweb.freebsd.org/changeset/base/346247 Log: mlx5en: Enable new pfil(9) KPI ethernet filtering hooks This allows efficient filtering at packet ingress on mlx5en. Note that the packets are filtered (and

svn commit: r346281 - head/sys/sys

2019-04-16 Thread Andrew Gallatin
Author: gallatin Date: Tue Apr 16 16:49:34 2019 New Revision: 346281 URL: https://svnweb.freebsd.org/changeset/base/346281 Log: Replace cosqos with numa_domain in mbuf pkthdr The cosqos field was added nearly 6 years ago in r254804, and it is still unused by any in-tree consumers. I

Re: svn commit: r349055 - head/sys/net

2019-06-15 Thread Andrew Gallatin
On 2019-06-15 07:07, Marius Strobl wrote: Author: marius Date: Sat Jun 15 11:07:41 2019 New Revision: 349055 Log: - Replace unused and only ever written to members of public iflib(9) structs with placeholders (in the latter case, IFLIB_MAX_TX_BYTES etc. are also only ever used

Re: svn commit: r349055 - head/sys/net

2019-06-15 Thread Andrew Gallatin
On 2019-06-15 11:59, Marius Strobl wrote: On Sat, Jun 15, 2019 at 09:08:05AM -0400, Andrew Gallatin wrote: On 2019-06-15 07:07, Marius Strobl wrote: Author: marius Date: Sat Jun 15 11:07:41 2019 New Revision: 349055 Log: - Replace unused and only ever written to members of public iflib

svn commit: r347410 - in head: . sys/amd64/conf sys/arm/conf sys/arm64/conf sys/i386/conf sys/powerpc/conf sys/riscv/conf sys/sparc64/conf

2019-05-09 Thread Andrew Gallatin
Author: gallatin Date: Thu May 9 22:38:15 2019 New Revision: 347410 URL: https://svnweb.freebsd.org/changeset/base/347410 Log: Remove IPSEC from GENERIC due to performance issues Having IPSEC compiled into the kernel imposes a non-trivial performance penalty on multi-threaded workloads

Re: svn commit: r347410 - in head: . sys/amd64/conf sys/arm/conf sys/arm64/conf sys/i386/conf sys/powerpc/conf sys/riscv/conf sys/sparc64/conf

2019-05-11 Thread Andrew Gallatin
On 2019-05-10 11:50, Kristof Provost wrote: On 10 May 2019, at 8:31, Andrew Gallatin wrote: On 2019-05-10 08:44, Slawa Olhovchenkov wrote: pf have ifdef for IPSEC, but don't have support IPSEC_SUPPORT (netpfil/pf/if_pfsync.c). Thanks for pointing this out. It seems

svn commit: r348109 - in head/sys/x86: include x86

2019-05-22 Thread Andrew Gallatin
Author: gallatin Date: Wed May 22 13:44:15 2019 New Revision: 348109 URL: https://svnweb.freebsd.org/changeset/base/348109 Log: x86 MCA: introduce MCA hooks for different vendor implementations This is needed for AMD SMCA processors, as SMCA uses different MSR address for access MCA

Re: svn commit: r348109 - in head/sys/x86: include x86

2019-05-23 Thread Andrew Gallatin
On 2019-05-22 13:09, Andriy Gapon wrote: On 22/05/2019 16:44, Andrew Gallatin wrote: This is needed for AMD SMCA processors, as SMCA uses different MSR address for access MCA banks. Just curious, what is SMCA? " Scalable Machine Check Architecture "

Re: svn commit: r348241 - head

2019-05-24 Thread Andrew Gallatin
On 2019-05-24 11:45, Mark Johnston wrote: Modernize the MAKE_JUST_KERNELS hint in the top-level makefile. It doesn't make sense to limit to -j12 anymore, build scalability is better than it used to be. Fold the hint into the description of the universe target. Reviewed

svn commit: r347430 - in head/sys: kern netinet sys

2019-05-10 Thread Andrew Gallatin
Author: gallatin Date: Fri May 10 13:41:19 2019 New Revision: 347430 URL: https://svnweb.freebsd.org/changeset/base/347430 Log: Bind TCP HPTS (pacer) threads to NUMA domains Bind the TCP pacer threads to NUMA domains and build per-domain pacer-thread lookup tables. These tables allow us

Re: svn commit: r347410 - in head: . sys/amd64/conf sys/arm/conf sys/arm64/conf sys/i386/conf sys/powerpc/conf sys/riscv/conf sys/sparc64/conf

2019-05-10 Thread Andrew Gallatin
On 2019-05-10 08:44, Slawa Olhovchenkov wrote: pf have ifdef for IPSEC, but don't have support IPSEC_SUPPORT (netpfil/pf/if_pfsync.c). Thanks for pointing this out. It seems like IPSEC_SUPPORT would work for this. I've made a patch, and it compiles and the pf module loads. However, I

Re: svn commit: r346598 - head/sys/modules

2019-04-29 Thread Andrew Gallatin
On 2019-04-29 10:21, Rodney W. Grimes wrote: On Tue, 23 Apr 2019 at 13:26, Rodney W. Grimes wrote: Very cool, now how do I get a PCIe slot into a RPI3!!! lol :-) I know you're joking but the comment does highlight an issue in the AArch64 world - there's a lack of good mid-range developer

Re: svn commit: r346598 - head/sys/modules

2019-04-29 Thread Andrew Gallatin
On 2019-04-29 10:54, Emmanuel Vadot wrote: On Mon, 29 Apr 2019 10:49:01 -0400 Andrew Gallatin wrote: On 2019-04-29 10:21, Rodney W. Grimes wrote: On Tue, 23 Apr 2019 at 13:26, Rodney W. Grimes wrote: Very cool, now how do I get a PCIe slot into a RPI3!!! lol :-) I know you're joking

svn commit: r347055 - in head: sbin/ifconfig sys/net

2019-05-03 Thread Andrew Gallatin
Author: gallatin Date: Fri May 3 14:43:21 2019 New Revision: 347055 URL: https://svnweb.freebsd.org/changeset/base/347055 Log: Select lacp egress ports based on NUMA domain This change creates an array of port maps indexed by numa domain for lacp port selection. If we have lacp

svn commit: r346632 - head/sys/net

2019-04-24 Thread Andrew Gallatin
Author: gallatin Date: Wed Apr 24 13:32:04 2019 New Revision: 346632 URL: https://svnweb.freebsd.org/changeset/base/346632 Log: iflib: Add pfil hooks As with mlx5en, the idea is to drop unwanted traffic as early in receive as possible, before mbufs are allocated and anything is passed

svn commit: r346677 - in head/sys: dev/cxgbe dev/mlx5/mlx5_en kern netinet netinet6

2019-04-25 Thread Andrew Gallatin
Author: gallatin Date: Thu Apr 25 15:37:28 2019 New Revision: 346677 URL: https://svnweb.freebsd.org/changeset/base/346677 Log: Track TCP connection's NUMA domain in the inpcb Drivers can now pass up numa domain information via the mbuf numa domain field. This information is then used

svn commit: r346579 - in head: share/man/man9 sys/dev/cxgbe sys/dev/mlx5/mlx5_en sys/net

2019-04-22 Thread Andrew Gallatin
Author: gallatin Date: Mon Apr 22 19:24:21 2019 New Revision: 346579 URL: https://svnweb.freebsd.org/changeset/base/346579 Log: Track device's NUMA domain in ifnet & alloc ifnet from NUMA local memory This commit adds new if_alloc_domain() and if_alloc_dev() methods to allocate ifnets.

Re: svn commit: r351200 - in head/sys: amd64/amd64 dev/acpica

2019-08-19 Thread Andrew Gallatin
On 2019-08-18 19:44, Jeff Roberson wrote: Author: jeff Date: Sun Aug 18 23:44:23 2019 New Revision: 351200 <..> Log: Allocate all per-cpu datastructures in domain correct memory. Reviewed by: kib, gallatin (some objections) No objection to what you actually committed. The only

svn commit: r346281 - head/sys/sys

2019-09-03 Thread Andrew Gallatin
Author: gallatin Date: Tue Apr 16 16:49:34 2019 New Revision: 346281 URL: https://svnweb.freebsd.org/changeset/base/346281 Log: Replace cosqos with numa_domain in mbuf pkthdr The cosqos field was added nearly 6 years ago in r254804, and it is still unused by any in-tree consumers. I

svn commit: r346579 - in head: share/man/man9 sys/dev/cxgbe sys/dev/mlx5/mlx5_en sys/net

2019-09-03 Thread Andrew Gallatin
Author: gallatin Date: Mon Apr 22 19:24:21 2019 New Revision: 346579 URL: https://svnweb.freebsd.org/changeset/base/346579 Log: Track device's NUMA domain in ifnet & alloc ifnet from NUMA local memory This commit adds new if_alloc_domain() and if_alloc_dev() methods to allocate ifnets.

svn commit: r346632 - head/sys/net

2019-09-03 Thread Andrew Gallatin
Author: gallatin Date: Wed Apr 24 13:32:04 2019 New Revision: 346632 URL: https://svnweb.freebsd.org/changeset/base/346632 Log: iflib: Add pfil hooks As with mlx5en, the idea is to drop unwanted traffic as early in receive as possible, before mbufs are allocated and anything is passed

svn commit: r346247 - head/sys/dev/mlx5/mlx5_en

2019-09-03 Thread Andrew Gallatin
Author: gallatin Date: Mon Apr 15 17:14:50 2019 New Revision: 346247 URL: https://svnweb.freebsd.org/changeset/base/346247 Log: mlx5en: Enable new pfil(9) KPI ethernet filtering hooks This allows efficient filtering at packet ingress on mlx5en. Note that the packets are filtered (and

svn commit: r352228 - head/sys/netinet

2019-09-11 Thread Andrew Gallatin
Author: gallatin Date: Wed Sep 11 18:48:26 2019 New Revision: 352228 URL: https://svnweb.freebsd.org/changeset/base/352228 Log: Avoid unneeded call to arc4random() in syncache_add() Don't call arc4random() unconditionally to initialize sc_iss, and then when syncookies are enabled, just

Re: svn commit: r352228 - head/sys/netinet

2019-09-13 Thread Andrew Gallatin
On 2019-09-11 17:16, Conrad Meyer wrote: Small nitpick: On Wed, Sep 11, 2019 at 11:48 AM Andrew Gallatin wrote: Note that on a system under a syn flood attack, arc4random() becomes quite expensive, and the chacha_poly crypto that it calls arc4random uses chacha20 — there is no "

svn commit: r350245 - head/usr.sbin/pciconf

2019-07-23 Thread Andrew Gallatin
Author: gallatin Date: Tue Jul 23 16:28:17 2019 New Revision: 350245 URL: https://svnweb.freebsd.org/changeset/base/350245 Log: pciconf: report PCI Gen4 speeds PCIe gen4 runs at 16GT/s. Report this as the speed of Gen4 links. Reviewed by: imp MFC after:7 days Sponsored by:

svn commit: r352816 - in head/sys: kern sys

2019-09-27 Thread Andrew Gallatin
Author: gallatin Date: Fri Sep 27 20:08:19 2019 New Revision: 352816 URL: https://svnweb.freebsd.org/changeset/base/352816 Log: kTLS: Fix a bug where we would not encrypt anon data inplace. Software Kernel TLS needs to allocate a new destination crypto buffer when encrypting data from

svn commit: r352814 - in head/sys: kern net opencrypto sys

2019-09-27 Thread Andrew Gallatin
Author: gallatin Date: Fri Sep 27 19:17:40 2019 New Revision: 352814 URL: https://svnweb.freebsd.org/changeset/base/352814 Log: kTLS support for TLS 1.3 TLS 1.3 requires a few changes because 1.3 pretends to be 1.2 with a record type of application data. The "real" record type is then

svn commit: r352552 - head/sys/kern

2019-09-20 Thread Andrew Gallatin
Author: gallatin Date: Fri Sep 20 09:36:07 2019 New Revision: 352552 URL: https://svnweb.freebsd.org/changeset/base/352552 Log: remove redundant "ktls" in KTLS thr name This reducesthe string width of the ktls thread name and improves "ps" output. Glanced at by: jhb Event:

  1   2   >