Re: svn commit: r274489 - in head/sys/amd64: amd64 include

2014-11-23 Thread David Chisnall
On 21 Nov 2014, at 23:26, Scott Long wrote: > That’s a good question to look further into. I didn’t see any measurable > differences with this change. I think that the cost of the function call > itself masks the cost of a few extra instructions, but I didn’t test with > switching it on/off

Re: svn commit: r280955 - in head/sys: modules/notrandom dev/notrandom

2015-04-01 Thread David Chisnall
On 1 Apr 2015, at 18:41, Mateusz Guzik wrote: > > I guess you were right, this was bad. > > I moved the implementation to null.c, I hope this makes everyone happy. > > https://lists.freebsd.org/pipermail/svn-src-all/2015-April/101876.html This almost certainly does not make people happy: - *

Re: svn commit: r280955 - in head/sys: modules/notrandom dev/notrandom

2015-04-02 Thread David Chisnall
On 2 Apr 2015, at 11:22, Mateusz Guzik wrote: > > Now one has to wonder how obnoxious one has to get so that people think > "this can't be real". > > I tried really hard. :) Not sure about your locale, but here (where the tradition originated) if you fool someone in the morning then they are a

Re: svn commit: r281721 - head/sys/sys

2015-04-21 Thread David Chisnall
On 20 Apr 2015, at 17:19, Bruce Evans wrote: > > Enums should never be used in ABIs, since their size can be anything > large enough. The rules for the size of enums also differ between C and C++, though clang (and, I think, gcc) support an attribute for specifying the enum type. > They also c

svn commit: r281925 - head/lib/libc/locale

2015-04-24 Thread David Chisnall
Author: theraven Date: Fri Apr 24 10:17:55 2015 New Revision: 281925 URL: https://svnweb.freebsd.org/changeset/base/281925 Log: Small changes to locale-related man pages. Fix a missing .h and change the recommended include for the POSIX2008 functions from xlocale.h to locale.h. Including xlo

svn commit: r281927 - head/lib/libc/locale

2015-04-24 Thread David Chisnall
Author: theraven Date: Fri Apr 24 10:21:20 2015 New Revision: 281927 URL: https://svnweb.freebsd.org/changeset/base/281927 Log: __xlocale_C_ctype should not be const. It contains a reference count that is modified by newlocale / duplocale / freelocale. MFC after:1 week Modified: he

Re: svn commit: r264265 - in head: crypto/openssl/crypto/bn crypto/openssl/crypto/ec crypto/openssl/ssl sys/fs/nfsserver

2014-04-09 Thread David Chisnall
On 9 Apr 2014, at 15:19, Kubilay Kocak wrote: > That expectation is orthogonal to whether we or other projects do it one > way or another. RHEL users may well be as confused as ours (whether of > not ours are). It may be relevant as a data point, but not for decision > making. I can confirm that

Re: svn commit: r265367 - head/lib/libc/regex

2014-05-05 Thread David Chisnall
On 5 May 2014, at 18:42, Andrey Chernov wrote: > Please don't commit OpenBSD errors. Now you mix calloc() with the > realloc() for the same variable later which makes calloc() zeroing > pointless and waste of CPU. The purpose of calloc() here is not (primarily) to get the zero'd size, it's to g

Re: svn commit: r265367 - head/lib/libc/regex

2014-05-05 Thread David Chisnall
On 5 May 2014, at 20:49, Pedro Giffuni wrote: > Yes, but I reverted it because there are other ways to check for overflows > without the performance hit. Do we have a good reusable routine for doing this somewhere? Clang and gcc both have some idiom recognisers that try to spot when people ar

Re: svn commit: r265367 - head/lib/libc/regex

2014-05-05 Thread David Chisnall
On 5 May 2014, at 22:33, Warner Losh wrote: > reallocf(): > The reallocf() function is identical to the realloc() function, except > that it will free the passed pointer when the requested memory cannot be > allocated. This is a FreeBSD specific API designed to ease the problems >

Re: svn commit: r265367 - head/lib/libc/regex

2014-05-05 Thread David Chisnall
On 5 May 2014, at 22:40, Andrey Chernov wrote: > On 05.05.2014 22:28, David Chisnall wrote: >> On 5 May 2014, at 18:42, Andrey Chernov wrote: >> >>> Please don't commit OpenBSD errors. Now you mix calloc() with the >>> realloc() for the same varia

Re: svn commit: r265367 - head/lib/libc/regex

2014-05-05 Thread David Chisnall
On 5 May 2014, at 22:51, Andrey Chernov wrote: > For standard malloc/realloc interface it is up to the caller to check > n*size not overflows. You must trust caller already does such check. Do a search of the CVE database sometime to see how well placed that trust generally is. Or even look at

Re: svn commit: r265367 - head/lib/libc/regex

2014-05-06 Thread David Chisnall
Bruce, On 6 May 2014, at 05:46, Bruce Evans wrote: > The standard behaviour is undefined. It cannot be relied on. From C99 > (n869.txt): > > %7.20.3.1 The calloc function > % %Synopsis > % %[#1] > % %#include > %void *calloc(size_t nme

Re: svn commit: r265861 - in head/sys: arm/include modules

2014-05-11 Thread David Chisnall
On 11 May 2014, at 13:53, Ian Lepore wrote: > Ooops, indeed, thanks. Although... it's a good change in terms of > speeding up the build, I just didn't intend to commit it until it got > tested with -j levels higher than I can test with my little 6-core > machine. I'd be happy to test it on a 32

Re: svn commit: r265861 - in head/sys: arm/include modules

2014-05-11 Thread David Chisnall
On 11 May 2014, at 14:05, Ian Lepore wrote: > On Sun, 2014-05-11 at 13:58 +0100, David Chisnall wrote: >> On 11 May 2014, at 13:53, Ian Lepore wrote: >> >>> Ooops, indeed, thanks. Although... it's a good change in terms of >>> speeding up the build, I ju

Re: svn commit: r266423 - in head/sys: conf dev/i40e modules/i40e

2014-05-21 Thread David Chisnall
On 20 May 2014, at 18:16, Gleb Smirnoff wrote: > Would be cool if most of tools (netstat, systat, etc...) could > determine size of terminal and dynamically widen all their fields. > Thus, tool can run w/o any abbreviations when run in a script mode, > run abbreviated on a small terminal, and run

Re: svn commit: r266865 - in head: include include/xlocale lib/libc/string

2014-05-30 Thread David Chisnall
On 30 May 2014, at 06:18, Rui Paulo wrote: > Is this going to cause any ports fallout? It shouldn't do. Any code that compiles on OS X will expect these to be in the correct place, and since DragonFly applied the fix first we'd hopefully have found any fallout via dports. David

Re: svn commit: r266974 - in head/sys: dev/dc dev/fxp dev/mii dev/netmap kern net

2014-06-03 Thread David Chisnall
On 3 Jun 2014, at 06:01, Adrian Chadd wrote: > I wonder if in the short term we should just use inlines for now, at > least so the methodization can get done without hurting people on > ARM/MIPS. It's probably worth thinking a bit more carefully about the KPI, since it's something we'll likely

Re: svn commit: r258779 - in head/sys/dev: cesa drm drm2/i915 drm2/radeon hatm

2013-12-01 Thread David Chisnall
On 1 Dec 2013, at 07:59, Konstantin Belousov wrote: > Revert the drm2/i915 changes from this and following commits now. > You did not contacted obvious maintainer of the file. > > The changes are pointless and make the import of upstream changes > harder; for i915_reg.h, much harder. > > Not to

svn commit: r259249 - head/usr.bin/dtc

2013-12-12 Thread David Chisnall
Author: theraven Date: Thu Dec 12 08:48:45 2013 New Revision: 259249 URL: http://svnweb.freebsd.org/changeset/base/259249 Log: Fix the version string in dts emission. Reported by: Patrick Wildt MFC after:1 week Modified: head/usr.bin/dtc/fdt.cc Modified: head/usr.bin/dtc/fdt.cc =

svn commit: r259250 - head/usr.bin/dtc

2013-12-12 Thread David Chisnall
Author: theraven Date: Thu Dec 12 08:55:24 2013 New Revision: 259250 URL: http://svnweb.freebsd.org/changeset/base/259250 Log: Some more cleanups and bug fixes in dtc for property printing / parsing. Submitted by: Patrick Wildt Modified: head/usr.bin/dtc/fdt.cc Modified: head/usr.bin/dt

svn commit: r260553 - head/lib/libcxxrt

2014-01-11 Thread David Chisnall
Author: theraven Date: Sat Jan 11 19:02:17 2014 New Revision: 260553 URL: http://svnweb.freebsd.org/changeset/base/260553 Log: Add missing C++11 typeinfos to the libcxxrt version script. PR: 185663 MFC after:1 week Modified: head/lib/libcxxrt/Version.map Modified: head/l

Re: svn commit: r261031 - in head: . etc usr.sbin/etcupdate usr.sbin/mergemaster

2014-01-23 Thread David Chisnall
On 22 Jan 2014, at 22:36, Glen Barber wrote: > It needs to use the build host version, because using (for example) > powerpc resulting binary won't work on and amd64 system. If it's used as part of the build, then it should be part of the toolchain target and we should be using the version buil

Re: svn commit: r278479 - in head: etc sys/kern

2015-02-10 Thread David Chisnall
On 10 Feb 2015, at 18:30, Rui Paulo wrote: > > Another thing I had in mind (which is more work) was to abstract the devctl > kernel code in an API which could make it easy to fan out the notifications > to multiple /dev devices. However, that may be overkill. This kind of notification is some

Re: svn commit: r279603 - in head: bin/rcp usr.bin/rlogin usr.bin/rsh

2015-03-05 Thread David Chisnall
On 5 Mar 2015, at 12:30, Slawa Olhovchenkov wrote: > > Yes, if ships before (don't break if working). > Some Linux distro remove telnet from default install. > Do you like to remove telnet also? Absolutely, now that netcat is part of the default install. For anything that a sane user might con

Re: svn commit: r279603 - in head: bin/rcp usr.bin/rlogin usr.bin/rsh

2015-03-05 Thread David Chisnall
On 5 Mar 2015, at 12:33, Slawa Olhovchenkov wrote: > > And how to test open/listing ports/sockets?! netcat - nc(1) - which can also work in the other direction and is designed specifically for this purpose. > How to connect to mpd control socket?! mpdcon from the command line, MPDroid from my

Re: svn commit: r279603 - in head: bin/rcp usr.bin/rlogin usr.bin/rsh

2015-03-05 Thread David Chisnall
On 5 Mar 2015, at 12:21, Slawa Olhovchenkov wrote: > >> I guess when they are going to be not precious enough to be removed? :) >> >> In modern world of ssh and https, does any OS require them in base? > > yes. > Some telecom equipment require rlogin. 'Some relatively obscure use case needs th

Re: svn commit: r279603 - in head: bin/rcp usr.bin/rlogin usr.bin/rsh

2015-03-05 Thread David Chisnall
> On 5 Mar 2015, at 12:42, Slawa Olhovchenkov wrote: > >> netcat - nc(1) - which can also work in the other direction and is designed >> specifically for this purpose. > > nc(1) don't correctly work. It works for me for everything that I used to use telnet for (connection testing, checking p

Re: svn commit: r279603 - in head: bin/rcp usr.bin/rlogin usr.bin/rsh

2015-03-05 Thread David Chisnall
On 5 Mar 2015, at 13:14, Slawa Olhovchenkov wrote: > > In previos message -- silently return when telnet speak about used IP > address and diagnostic messages. One simple command do many diagnostic > information. Okay, so check the return code. Or pass -v if you want more verbose information:

Re: svn commit: r279603 - in head: bin/rcp usr.bin/rlogin usr.bin/rsh

2015-03-05 Thread David Chisnall
On 5 Mar 2015, at 14:04, Dmitry Sivachenko wrote: > It is so nice to have most useful stuff out of the box. The question is whether a tool for logging into remote machines without encryption is 'the most useful stuff'. The tool is also [ab]used for network testing, but we already provide a be

Re: svn commit: r279603 - in head: bin/rcp usr.bin/rlogin usr.bin/rsh

2015-03-05 Thread David Chisnall
On 5 Mar 2015, at 14:13, Slawa Olhovchenkov wrote: > > Not better, no. Does telnet support creating server sockets? No. Does telnet support IPsec? No. Does telnet let you specify the tcp window size? No. Does telnet come with a massive selection of options for insecure login / authenticatio

Re: svn commit: r279764 - head/sys/vm

2015-03-10 Thread David Chisnall
On 10 Mar 2015, at 10:18, Konstantin Belousov wrote: > > Because you cannot grep for the panic string when __func__ is used. The userspace assert uses __func__, __FILE__ and __LINE__, which means that you never need to grep the source code to find out where the assert came from: the assertion

Re: svn commit: r302252 - head/sys/kern

2016-07-05 Thread David Chisnall
On 4 Jul 2016, at 21:09, Adrian Chadd wrote: > > Right, so if we're not careful, we could leak bits of kernel memory, > and it can also screw up key cache comparisons. > > (I asked this question because I've been screwed by it recentlyish, > and it looks like the latest C standard didn't fix it.

Re: svn commit: r286168 - head/sys/net

2015-08-02 Thread David Chisnall
On 2 Aug 2015, at 17:34, Ian Lepore wrote: > > It generates a compiler error, so the output is going to contain > file-and-line like any other compiler error, as well as the message from > the source code. It will, of course, vary between compilers, but this is what clang generates: $ cat stati

Re: svn commit: r286715 - head/lib/libc/string

2015-08-13 Thread David Chisnall
On 13 Aug 2015, at 08:11, Marcelo Araujo wrote: > > The bcopy() was removed in IEEE Std 1003.1-2008 and it is marked as LEGACY in > IEEE Std 1003.1-2004. However, BSD has its implementation before IEEE Std > 1003.1-2001. > > In my understood it is obsolete on POSIX, but not truly obsolete for

Re: svn commit: r286715 - head/lib/libc/string

2015-08-13 Thread David Chisnall
On 13 Aug 2015, at 08:56, Marcelo Araujo wrote: > > So it means, this commit here was right already: > https://svnweb.freebsd.org/base?view=revision&revision=286651 > > Although I made a mistake with the date. More or less. I partly agree with Bruce that suggesting memcpy is misleading. I’d

Re: svn commit: r287780 - in head: share/man/man9 sys/kern sys/sys

2015-09-17 Thread David Chisnall
On 17 Sep 2015, at 08:20, Hans Petter Selasky wrote: > > On 09/17/15 00:05, Gleb Smirnoff wrote: >> Weren't you explicitly asked not to touch this system without a proper >> review and discussion? > > Adding a new function is not touching code. Adding a new interface to an existing core subsyst

Re: svn commit: r292809 - head/lib/libc/stdio

2015-12-29 Thread David Chisnall
On 30 Dec 2015, at 00:48, Bruce Evans wrote: > > - C++ apparently spells this as both _Alignof() and alignof() after 2011/03 This is not correct. C++ spells it alignof. C spells it _Alignof, unless you include , in which case C spells it alignof and defines _ _alignof_is_defined. On FreeBSD

Re: svn commit: r290711 - head/sys/ofed/drivers/infiniband/core

2015-11-13 Thread David Chisnall
On 13 Nov 2015, at 08:35, Konstantin Belousov wrote: > > On Fri, Nov 13, 2015 at 09:18:54AM +0100, Hans Petter Selasky wrote: >> Hi, >> >> On 11/12/15 18:17, Conrad Meyer wrote: >>> These should cast through (u)intptr_t rather than unsigned long. >>> >> >> This is Linux code, and they use "uns

svn commit: r292876 - head/usr.bin/dtc

2015-12-29 Thread David Chisnall
Author: theraven Date: Tue Dec 29 16:29:42 2015 New Revision: 292876 URL: https://svnweb.freebsd.org/changeset/base/292876 Log: Improvements to BSD-licensed DTC. - Added an expression parser so that expressions from headers are now working - Fixed missing null terminators on cross referen

Re: svn commit: r284198 - head/bin/ls

2015-06-13 Thread David Chisnall
On 13 Jun 2015, at 11:17, Ian Lepore wrote: > > If you would have told me a year ago that you had a simple scheme that > could make 30 years of experience maintaining code for unix-like systems > completely worthless I would have been skeptical, but it seems we're > well on our way. There is a l

Re: svn commit: r268137 - head/sys/sys

2015-06-19 Thread David Chisnall
I only just caught this (having seen the fallout from NetBSD doing the same thing in a shipping release and the pain that it’s caused): __weak is a reserved keyword in Objective-C, please pick another name for this. This in cdefs.h makes it impossible to include any FreeBSD standard headers in

Re: svn commit: r268137 - head/sys/sys

2015-06-19 Thread David Chisnall
On 19 Jun 2015, at 11:45, Hans Petter Selasky wrote: > > Appearently this will be fixed in GNUSTEP base: > > http://cvsweb.netbsd.org/bsdweb.cgi/src/sys/sys/cdefs_elf.h?only_with_tag=MAIN > > Is this still an issue? It is impossible to fix it in GNUstep Base, because we can’t guarantee that u

Re: svn commit: r268137 - head/sys/sys

2015-06-19 Thread David Chisnall
On 19 Jun 2015, at 12:57, Hans Petter Selasky wrote: > > Hi, > >> Then they will get a compile error no matter what GNUstep’s Foundation.h >> does. It can’t prevent cdefs.h from redefining __weak to be something >> different. >> > > Except "#undef __weak” Please read the example that I wro

Re: svn commit: r268137 - head/sys/sys

2015-06-19 Thread David Chisnall
On 19 Jun 2015, at 14:41, Hans Petter Selasky wrote: > > On 06/19/15 14:54, David Chisnall wrote: >> I definitely know of people building out-of-ports programs on FreeBSD whose >> code you have just broken (including myself, > > though I do Objective-C stuff on 10, so

Re: svn commit: r268137 - head/sys/sys

2015-06-19 Thread David Chisnall
On 19 Jun 2015, at 15:32, Marcelo Araujo wrote: > > Maybe would be a good idea run an 'exp run' with this patch? Just to double > check if any port will break, although after you rename, I don't believe it > will conflict anymore, however an 'exp run' would show you it. It’s probably worth doi

Re: svn commit: r285284 - head/lib/liblzma

2015-07-09 Thread David Chisnall
On 9 Jul 2015, at 03:53, NGie Cooper wrote: > > $ cat ~/has_immintrin.c > #include > > #if __has_include() > #error "I have immintrin.h" > #else > #error "I don't have immintrin.h" > #endif > $ clang -c ~/has_immintrin.c > /home/ngie/has_immintrin.c:4:2: error: "I have immintrin.h" > #error "I

Re: svn commit: r285284 - head/lib/liblzma

2015-07-09 Thread David Chisnall
On 9 Jul 2015, at 10:19, NGie Cooper wrote: > > Yes, but this case will fail for gcc 4.3 ~ 4.4 through 5.x if you use > my recommended method... I think that’s probably fine. We basically have four cases that we care about: - People who are using clang because it’s the system compiler [works]

Re: svn commit: r285404 - head/sys/compat/cloudabi

2015-07-12 Thread David Chisnall
On 11 Jul 2015, at 21:56, Konstantin Belousov wrote: > >> Bucket 2: The system call could also just fail and return an error >> (MSG_NOSIGPIPE). > SIGPIPE exists to ensure that naive programs do something reasonable > when their stdout suddenly goes away. Or, transposing the PoV, it allows > to w

Re: svn commit: r285552 - head/usr.bin/xargs

2015-07-15 Thread David Chisnall
On 15 Jul 2015, at 01:02, Xin Li wrote: > > My only concern with strtonum() is that it's English only. Given that strtonum() wraps strtoll, it ought to support whatever the current locale is (assuming that the program calls setlocale() before calling strtonum(), otherwise it will use the C loc

Re: svn commit: r289027 - head/contrib/tzcode/stdtime

2015-10-08 Thread David Chisnall
On 8 Oct 2015, at 13:51, Andriy Gapon wrote: > > What if one day github disappears but FreeBSD is still going? > The full commit message would be lost. That’s not the only thing that is bad about this commit message. Why ‘Assume C89?’ We compile libc as C99 + GNU extensions and are likely to

svn commit: r289935 - in head/usr.bin: . dtc

2015-10-25 Thread David Chisnall
Author: theraven Date: Sun Oct 25 14:52:16 2015 New Revision: 289935 URL: https://svnweb.freebsd.org/changeset/base/289935 Log: Lots of improvements to the BSD-licensed dtc - Various fixes to includes (including recursive includes) - Lots of testing that the output exactly matches GPL'd d

svn commit: r289995 - head/usr.bin/dtc

2015-10-26 Thread David Chisnall
Author: theraven Date: Mon Oct 26 10:37:17 2015 New Revision: 289995 URL: https://svnweb.freebsd.org/changeset/base/289995 Log: Ensure that dtc is built in C++11 mode. Reported by: George Abdelmalik Modified: head/usr.bin/dtc/Makefile Modified: head/usr.bin/dtc/Makefile ===

Re: svn commit: r289995 - head/usr.bin/dtc

2015-10-26 Thread David Chisnall
On 26 Oct 2015, at 10:48, Baptiste Daroussin wrote: > > Just jumping on that one, you should probably revisit de HACKING files :) Ah, good point. I’ll update them. David ___ svn-src-head@freebsd.org mailing list https://lists.freebsd.org/mailman/lis

svn commit: r289996 - head/usr.bin/dtc

2015-10-26 Thread David Chisnall
Author: theraven Date: Mon Oct 26 11:02:57 2015 New Revision: 289996 URL: https://svnweb.freebsd.org/changeset/base/289996 Log: Update some obsolete information in the HACKING document. Reported by: bapt Modified: head/usr.bin/dtc/HACKING Modified: head/usr.bin/dtc/HACKING

Re: svn commit: r295768 - head/usr.sbin/iostat

2016-02-22 Thread David Chisnall
On 19 Feb 2016, at 23:23, Dimitry Andric wrote: > > This warning is only produced when you use -Wall -W, and then initialize > structs partially, i.e. you initialize some fields but not others. I > think this is a quite reasonable warning for a high warning level. The warning is annoying in man

Re: svn commit: r295768 - head/usr.sbin/iostat

2016-02-22 Thread David Chisnall
On 22 Feb 2016, at 10:15, Kubilay Kocak wrote: > > For the lay persons among us (I'm genuinely interested), what are the > the downsides to requiring initialization of all fields? Explicit initialisation, or initialisation in general? Being able to initialise the entire structure with code that

svn commit: r234573 - head/include/xlocale

2012-04-22 Thread David Chisnall
Author: theraven Date: Sun Apr 22 16:58:14 2012 New Revision: 234573 URL: http://svn.freebsd.org/changeset/base/234573 Log: Fix a bug caused by some misplaced brackets. Reported by: das Modified: head/include/xlocale/_ctype.h Modified: head/include/xlocale/_ctype.h

svn commit: r234578 - head/lib/libc/locale

2012-04-22 Thread David Chisnall
Author: theraven Date: Sun Apr 22 18:51:38 2012 New Revision: 234578 URL: http://svn.freebsd.org/changeset/base/234578 Log: Fix some incorrect symbol versions. Reported by: das Modified: head/lib/libc/locale/Symbol.map Modified: head/lib/libc/locale/Symbol.map =

svn commit: r234732 - head/usr.sbin/wpa/hostapd

2012-04-27 Thread David Chisnall
Author: theraven Date: Fri Apr 27 15:35:09 2012 New Revision: 234732 URL: http://svn.freebsd.org/changeset/base/234732 Log: Add a note to hostapd.conf about an unhelpful error message in the hope that it won't confuse anyone else in the future. MFC after:1 week Modified: head/usr.s

svn commit: r234958 - head/include

2012-05-03 Thread David Chisnall
Author: theraven Date: Thu May 3 15:54:06 2012 New Revision: 234958 URL: http://svn.freebsd.org/changeset/base/234958 Log: Fix after clang decided to rename all of its builtins to include a c11 prefix to disambiguate them from the one provided by GCC. Note: Clang 3.1 also supports the G

svn commit: r234976 - in head/contrib/libc++: include src

2012-05-03 Thread David Chisnall
Author: theraven Date: Thu May 3 17:44:07 2012 New Revision: 234976 URL: http://svn.freebsd.org/changeset/base/234976 Log: Import new version of libc++. Among other improvements, this comes with an header that works with clang 3.1 (and, importantly, the pre-3.1 snapshot currently in head)

Re: svn commit: r235267 - in head/usr.bin/sort: . nls

2012-05-11 Thread David Chisnall
On 11 May 2012, at 08:48, Konstantin Belousov wrote: > On Fri, May 11, 2012 at 12:37:16PM +, Gabor Kovesdan wrote: >> Author: gabor >> Date: Fri May 11 12:37:16 2012 >> New Revision: 235267 >> URL: http://svn.freebsd.org/changeset/base/235267 > >> +bool byte_sort = false; >> + >> +static wcha

svn commit: r236148 - head/lib/msun/src

2012-05-27 Thread David Chisnall
Author: theraven Date: Sun May 27 12:54:41 2012 New Revision: 236148 URL: http://svn.freebsd.org/changeset/base/236148 Log: Allow inclusion of libc++ to work after including math.h Submitted by: Yamaya Takashi Reviewed by: das MFC after:1 week Modified: head/lib/msun/src/math.h

svn commit: r236177 - head/gnu/lib/libsupc++

2012-05-28 Thread David Chisnall
Author: theraven Date: Mon May 28 12:11:00 2012 New Revision: 236177 URL: http://svn.freebsd.org/changeset/base/236177 Log: Correctly export operator new / delete for things linking against libsupc++ but not libstdc++. Unfortunately, it appears that libsupc++ / libstdc++ have a different

Re: svn commit: r236137 - head/contrib/gcc/config/i386

2012-05-28 Thread David Chisnall
On 28 May 2012, at 20:33, Dimitry Andric wrote: > On the other hand, it's really platform-dependent: I've checked several > Linux distributions, and it is fairly unpredictable whether their gcc > passes --hash-style to the linker, or if they do, which option they use. Can we make it dependent on

Re: svn commit: r236137 - head/contrib/gcc/config/i386

2012-05-30 Thread David Chisnall
On 30 May 2012, at 09:01, Marius Strobl wrote: > Ehm, yes, but given that this wouldn't be the first such flag we have > is avoiding it really worth the link time and run time overheads in > the long term? Given the small overhead of the extra hashes, yes. At some point in the future, we can t

Re: svn commit: r236456 - in head/sys: amd64/include i386/include

2012-06-04 Thread David Chisnall
On 4 Jun 2012, at 11:00, Tijl Coosemans wrote: > On 02-06-2012 20:10, Konstantin Belousov wrote: >> Author: kib >> Date: Sat Jun 2 18:10:16 2012 >> New Revision: 236456 >> URL: http://svn.freebsd.org/changeset/base/236456 >> >> Log: >> Use plain store for atomic_store_rel on x86, instead of imp

svn commit: r236889 - head/lib/libc/locale

2012-06-11 Thread David Chisnall
Author: theraven Date: Mon Jun 11 14:02:02 2012 New Revision: 236889 URL: http://svn.freebsd.org/changeset/base/236889 Log: Fix a leak when setting the global character locale to "C" from something else. Reported by: mm Modified: head/lib/libc/locale/setrunelocale.c Modified: head/lib

svn commit: r236890 - in head: gnu/lib/libsupc++ lib/libcxxrt

2012-06-11 Thread David Chisnall
Author: theraven Date: Mon Jun 11 15:40:57 2012 New Revision: 236890 URL: http://svn.freebsd.org/changeset/base/236890 Log: Clean up some symbol versions for libsupc++ / libcxxrt. MFC after:1 week Reviewed by: kan Modified: head/gnu/lib/libsupc++/Version.map head/lib/libcxxrt/Ve

Re: svn commit: r240549 - head/sys/arm/tegra

2012-09-16 Thread David Chisnall
On 16 Sep 2012, at 10:37, Chris Rees wrote: > Actually: > > for (;;) >; This form will generate a compiler warning, because it looks like a missing loop body. You can silence the warning by this form: for (;;) {} This makes it clear that you have an explicit body containing no statem

Re: svn commit: r240850 - head/lib/libstand

2012-09-24 Thread David Chisnall
On 23 Sep 2012, at 20:27, Garrett Cooper wrote: >+1. free(3) should silently ignore NULL parameters passed into it. Indeed. The C standard's description for free() states that: > If ptr is a null pointer, no action occurs. This means that a standards-compilant compiler is entirely at liber

Re: svn commit: r241373 - head/lib/libc/stdlib

2012-10-09 Thread David Chisnall
On 9 Oct 2012, at 17:33, Andrey Chernov wrote: > Do you check assembler output for _both_ cases? > In my testing clang and gcc xor's 'junk' properly in case it have > 'volatile' keyword (as in srandomdev()) and elide it without 'volatile'. > IMHO this change should be backed out for srandomdev() a

Re: svn commit: r241931 - in head/sys: conf kern

2012-10-23 Thread David Chisnall
On 23 Oct 2012, at 16:05, Andre Oppermann wrote: > For zero copy send we're trying to come up with a sendfile-like > approach where the page is simply wired into kernel space. The > application then is not allowed to touch it until the socket > buffer has released it again. The main issue here i

svn commit: r242945 - in head/contrib/libc++: include include/ext src

2012-11-12 Thread David Chisnall
Author: theraven Date: Tue Nov 13 03:27:43 2012 New Revision: 242945 URL: http://svnweb.freebsd.org/changeset/base/242945 Log: Import new version of libc++ into base. Modified: head/contrib/libc++/include/__config head/contrib/libc++/include/__functional_base head/contrib/libc++/include/_

svn commit: r243673 - head/contrib/libc++/include

2012-11-29 Thread David Chisnall
Author: theraven Date: Thu Nov 29 13:35:44 2012 New Revision: 243673 URL: http://svnweb.freebsd.org/changeset/base/243673 Log: Merge new libc++ into head. Modified: head/contrib/libc++/include/exception head/contrib/libc++/include/iterator head/contrib/libc++/include/locale Directory Prop

Re: svn commit: r243670 - head/share/man/man5

2012-11-30 Thread David Chisnall
On 30 Nov 2012, at 00:15, Eitan Adler wrote: > Every time I talk to the clang folk about flags they point me to gcc > documentation. No we don't. We point you at the gcc documentation and at the clang manual. Clang aims to support all of the gcc flags, and provides some extra ones as document

svn commit: r245304 - head/contrib/libcxxrt

2013-01-11 Thread David Chisnall
Author: theraven Date: Fri Jan 11 15:05:55 2013 New Revision: 245304 URL: http://svnweb.freebsd.org/changeset/base/245304 Log: Merge new version of libcxxrt. This brings in three fixes: - Don't treat pointers to members as pointers in catch blocks (they're usually fat pointers). -

svn commit: r245327 - head/contrib/libcxxrt

2013-01-12 Thread David Chisnall
Author: theraven Date: Sat Jan 12 10:06:59 2013 New Revision: 245327 URL: http://svnweb.freebsd.org/changeset/base/245327 Log: Fix libcxxrt / libc++ build with the clang in head. Pointy hat to:theraven Modified: head/contrib/libcxxrt/atomic.h Modified: head/contrib/libcxxrt/atom

svn commit: r245745 - head/contrib/libcxxrt

2013-01-21 Thread David Chisnall
Author: theraven Date: Mon Jan 21 17:37:23 2013 New Revision: 245745 URL: http://svnweb.freebsd.org/changeset/base/245745 Log: Import new fix from libcxxrt. This fixes the case where you attempt to rethrow an exception when you haven't caught one. This is largely a cosmetic fix, as (unles

svn commit: r245803 - in head: . gnu/usr.bin share/man/man5 share/mk usr.bin/dtc

2013-01-22 Thread David Chisnall
=== --- /dev/null 00:00:00 1970 (empty, because file is newly added) +++ head/usr.bin/dtc/checking.cc Tue Jan 22 17:49:51 2013 (r245803) @@ -0,0 +1,210 @@ +/*- + * Copyright (c) 2013 David Chisnall + * All right

svn commit: r245807 - head/usr.bin/dtc

2013-01-22 Thread David Chisnall
Author: theraven Date: Tue Jan 22 18:12:31 2013 New Revision: 245807 URL: http://svnweb.freebsd.org/changeset/base/245807 Log: Fix logic error in explicitly specified dtb versions spotted by gavin. Modified: head/usr.bin/dtc/dtc.cc Modified: head/usr.bin/dtc/dtc.cc ==

svn commit: r245809 - head/usr.bin/dtc

2013-01-22 Thread David Chisnall
Author: theraven Date: Tue Jan 22 18:15:43 2013 New Revision: 245809 URL: http://svnweb.freebsd.org/changeset/base/245809 Log: Fix the missing sentence that ended in the middle in the man page for dtc (also spotted by gavin). Modified: head/usr.bin/dtc/dtc.1 Modified: head/usr.bin/dtc/dtc

svn commit: r245822 - head

2013-01-22 Thread David Chisnall
Author: theraven Date: Tue Jan 22 19:40:26 2013 New Revision: 245822 URL: http://svnweb.freebsd.org/changeset/base/245822 Log: Fix spurious leading / on dtc path in Makefile.inc1. Spotted by jhb. Modified: head/Makefile.inc1 Modified: head/Makefile.inc1 =

svn commit: r245839 - head/usr.bin/dtc

2013-01-23 Thread David Chisnall
Author: theraven Date: Wed Jan 23 08:54:34 2013 New Revision: 245839 URL: http://svnweb.freebsd.org/changeset/base/245839 Log: Explicitly include headers that are implicitly included by libstdc++. Fixes building dtc with libc++. Modified: head/usr.bin/dtc/checking.cc head/usr.bin/dtc/dtb

svn commit: r245901 - head/usr.bin/dtc

2013-01-25 Thread David Chisnall
Author: theraven Date: Fri Jan 25 08:34:38 2013 New Revision: 245901 URL: http://svnweb.freebsd.org/changeset/base/245901 Log: Fix style nit in dtc man page: sentences should start on new lines. Reported By: joel Modified: head/usr.bin/dtc/dtc.1 Modified: head/usr.bin/dtc/dtc.1 ===

svn commit: r246028 - in head: gnu/lib/libsupc++ lib/libcxxrt

2013-01-28 Thread David Chisnall
Author: theraven Date: Mon Jan 28 11:12:49 2013 New Revision: 246028 URL: http://svnweb.freebsd.org/changeset/base/246028 Log: Fix some symbol version mismatches between libstdc++ and libsupc++/libcxxrt that were causing the runtime and STL libraries to see different versions of various clas

svn commit: r246462 - head/contrib/libcxxrt

2013-02-07 Thread David Chisnall
Author: theraven Date: Thu Feb 7 11:08:03 2013 New Revision: 246462 URL: http://svnweb.freebsd.org/changeset/base/246462 Log: Fix a copy-and-paste error in libcxxrt. Modified: head/contrib/libcxxrt/exception.cc Modified: head/contrib/libcxxrt/exception.cc ===

svn commit: r246487 - in head/contrib/libc++: include src

2013-02-07 Thread David Chisnall
Author: theraven Date: Thu Feb 7 15:45:28 2013 New Revision: 246487 URL: http://svnweb.freebsd.org/changeset/base/246487 Log: Import new libc++ to head. Various small fixes and cleanups. MFC after:2 weeks Modified: head/contrib/libc++/include/__config head/contrib/libc++/include/

Re: svn commit: r237434 - in head/lib/libc: amd64/sys gen i386/sys include sys

2012-06-22 Thread David Chisnall
On 22 Jun 2012, at 08:34, Marius Strobl wrote: > I don't know much about x86 CPUs but is my understanding correct > that TSCs are not synchronized in any way across CPUs, i.e. > reading it on different CPUs may result in time going backwards > etc., which is okay for this application though? As l

Re: svn commit: r238118 - head/lib/libc/gen

2012-07-04 Thread David Chisnall
On 4 Jul 2012, at 21:32, Andrey Chernov wrote: > 1) /dev/urandom may not exist in jails/sandboxes while sysctls (or old way > initialization) always exists. From the perspective of Capsicum sandboxes, a device node is better than a sysctl. The kernel must hard-code policy about which sysctls a

svn commit: r238182 - head/lib/libc/locale

2012-07-06 Thread David Chisnall
Author: theraven Date: Fri Jul 6 20:16:22 2012 New Revision: 238182 URL: http://svn.freebsd.org/changeset/base/238182 Log: Restore the __collate_load_error global that was accidentally removed in the xlocale refactoring. MFC after:1 week Modified: head/lib/libc/locale/collate.c

Re: svn commit: r227753 - in head: contrib/gdtoa include lib/libc/gdtoa lib/libc/gen lib/libc/locale lib/libc/regex lib/libc/stdio lib/libc/stdlib lib/libc/stdtime lib/libc/string

2012-01-30 Thread David Chisnall
On 18 Jan 2012, at 19:07, David Schultz wrote: > This patch appears to cause a large performance regression. For > example, I measured a 78% slowdown for strtol("42", ...). That's definitely worth taking a closer look at. I think we can cache some things in TLS and avoid some pthread_getsp

svn commit: r231673 - in head: etc/mtree include include/xlocale lib/libc/locale sys/sys

2012-02-14 Thread David Chisnall
+++ head/include/xlocale.h Tue Feb 14 12:03:23 2012(r231673) @@ -1,5 +1,5 @@ /*- - * Copyright (c) 2011 The FreeBSD Foundation + * Copyright (c) 2011, 2012 The FreeBSD Foundation * All rights reserved. * * This software was developed by David Chisnall under sponsorship from @@ -8,16 +8,16 @@ * R

svn commit: r231682 - in head: include lib/libc/locale

2012-02-14 Thread David Chisnall
Author: theraven Date: Tue Feb 14 14:24:37 2012 New Revision: 231682 URL: http://svn.freebsd.org/changeset/base/231682 Log: Fix a misplaced __NO_TLS locations, and change a GNUism to a C11ism for consistency. Approved by: brooks (mentor) Modified: head/include/runetype.h head/lib/li

Re: svn commit: r232351 - in head/sys: kern sys ufs/ffs ufs/ufs

2012-03-02 Thread David Chisnall
On 2 Mar 2012, at 12:53, Konstantin Belousov wrote: > This part of the change breaks KBI. I suggest that for merge to stable/9 > you would leave the bread and breadn as functions. Can we not do this for the general case? Provide them as inline extern functions in the header, and implement them

svn commit: r232498 - in head: etc/mtree include include/xlocale lib/libc/locale sys/sys

2012-03-04 Thread David Chisnall
--- head/include/xlocale.h Sun Mar 4 15:25:11 2012(r232497) +++ head/include/xlocale.h Sun Mar 4 15:31:13 2012(r232498) @@ -1,5 +1,5 @@ /*- - * Copyright (c) 2011 The FreeBSD Foundation + * Copyright (c) 2011, 2012 The FreeBSD Foundation * All rights reserved. *

svn commit: r232601 - in head/lib/libc: locale regex

2012-03-06 Thread David Chisnall
this software were developed by David Chisnall * under sponsorship from the FreeBSD Foundation. * - * Copyright (c) 2011 The FreeBSD Foundation - * All rights reserved. - * Portions of this software were developed by David Chisnall - * under sponsorship from the FreeBSD Foundation

Re: svn commit: r232570 - head/sys/boot/i386/boot2

2012-03-08 Thread David Chisnall
On 8 Mar 2012, at 16:05, John Baldwin wrote: > On Wednesday, March 07, 2012 5:00:19 pm Jung-uk Kim wrote: >> On Monday 05 March 2012 02:53 pm, John Baldwin wrote: >>> Author: jhb >>> Date: Mon Mar 5 19:53:17 2012 >>> New Revision: 232570 >>> URL: http://svn.freebsd.org/changeset/base/232570 >>>

svn commit: r232926 - in head: include/xlocale lib/libc/locale

2012-03-13 Thread David Chisnall
Author: theraven Date: Tue Mar 13 14:14:13 2012 New Revision: 232926 URL: http://svn.freebsd.org/changeset/base/232926 Log: More xlocale cleanups. Approved by: dim (mentor) Modified: head/include/xlocale/_ctype.h head/lib/libc/locale/Symbol.map Modified: head/include/xlocale/_ctype.h

<    1   2   3   >