Re: svn commit: r241610 - in head: . sys/dev/usb sys/net sys/net80211 sys/netpfil/ipfw sys/netpfil/pf sys/sys

2012-10-27 Thread Gleb Smirnoff
On Fri, Oct 26, 2012 at 09:16:08PM -0700, Rui Paulo wrote: R I second Adrian's comments and I would like to add that you must NOT commit something like this, breaking the ABI, when you discussed this *ONE YEAR* ago with only two people (one of them is not very active in the networking stack).

Re: svn commit: r242161 - in head/sys: net netinet netpfil/pf

2012-10-27 Thread Gleb Smirnoff
On Sat, Oct 27, 2012 at 12:58:52PM +0200, Andre Oppermann wrote: A On 26.10.2012 23:06, Gleb Smirnoff wrote: A Author: glebius A Date: Fri Oct 26 21:06:33 2012 A New Revision: 242161 A URL: http://svn.freebsd.org/changeset/base/242161 A A Log: A o Remove last argument to ip_fragment

Re: svn commit: r242254 - head/sys/netinet

2012-10-28 Thread Gleb Smirnoff
On Sun, Oct 28, 2012 at 06:07:34PM +, Andre Oppermann wrote: A @@ -296,8 +297,8 @@ syncache_destroy(void) A mtx_destroy(sch-sch_mtx); A } A A -KASSERT(V_tcp_syncache.cache_count == 0, (%s: cache_count %d not 0, A -__func__, V_tcp_syncache.cache_count)); A +

Re: svn commit: r242274 - head/sys/sys

2012-10-28 Thread Gleb Smirnoff
On Mon, Oct 29, 2012 at 01:35:17AM +, Attilio Rao wrote: A Author: attilio A Date: Mon Oct 29 01:35:17 2012 A New Revision: 242274 A URL: http://svn.freebsd.org/changeset/base/242274 A A Log: A Compiler have a precise knowledge of the content of sched_pin() and A sched_unpin() as they are

Re: svn commit: r242161 - in head/sys: net netinet netpfil/pf

2012-10-28 Thread Gleb Smirnoff
On Mon, Oct 29, 2012 at 01:41:04PM -0700, YongHyeon PYUN wrote: Y On Sun, Oct 28, 2012 at 02:01:37AM +0400, Gleb Smirnoff wrote: Y On Sat, Oct 27, 2012 at 12:58:52PM +0200, Andre Oppermann wrote: Y A On 26.10.2012 23:06, Gleb Smirnoff wrote: Y A Author: glebius Y A Date: Fri Oct 26 21:06:33

Re: svn commit: r242325 - head/sys/netinet

2012-10-30 Thread Gleb Smirnoff
On Mon, Oct 29, 2012 at 08:42:48PM +, Michael Tuexen wrote: M Author: tuexen M Date: Mon Oct 29 20:42:48 2012 M New Revision: 242325 M URL: http://svn.freebsd.org/changeset/base/242325 M M Log: M Use ntohs() and htons() in correct order. However, this doesn't change M functionality. Oh,

Re: svn commit: r242402 - in head/sys: kern vm

2012-11-01 Thread Gleb Smirnoff
On Wed, Oct 31, 2012 at 06:33:51PM +, Attilio Rao wrote: A Doesn't this padding to cache line size only help x86 processors in an A SMP kernel? I was expecting to see some #ifdef SMP so that we don't pay A a big price for no gain in small-memory ARM systems and such. But maybe A I'm

svn commit: r242467 - head/sys/dev/drm2

2012-11-01 Thread Gleb Smirnoff
Author: glebius Date: Fri Nov 2 05:26:33 2012 New Revision: 242467 URL: http://svn.freebsd.org/changeset/base/242467 Log: - If DRM_DEBUG_DEFAULT_ON is defined, then initialize drm_debug_flagi to all supported debugging bits. - If DRM_DEBUG_DEFAULT_ON isn't defined, then initialize

svn commit: r209607 - head/sys/dev/ixgbe

2010-06-30 Thread Gleb Smirnoff
Author: glebius Date: Wed Jun 30 11:17:55 2010 New Revision: 209607 URL: http://svn.freebsd.org/changeset/base/209607 Log: Fix build. Modified: head/sys/dev/ixgbe/ixgbe.h Modified: head/sys/dev/ixgbe/ixgbe.h == ---

Re: svn commit: r209622 - head/sys/dev/ixgbe

2010-07-01 Thread Gleb Smirnoff
Jack, On Wed, Jun 30, 2010 at 10:09:22PM -0700, Jack Vogel wrote: J I went to a LOT of trouble setting up a mirror at home and just as I went to J commit J the change its updated. J J While I understand the good intentions, please don't do this again. If I had J been J unresponsive for days or

svn commit: r209633 - head/sys/netgraph

2010-07-01 Thread Gleb Smirnoff
Author: glebius Date: Thu Jul 1 17:46:12 2010 New Revision: 209633 URL: http://svn.freebsd.org/changeset/base/209633 Log: The struct ipfw_rule_ref follows the struct m_tag. Deal with this correctly. This fixes breakage of ng_ipfw(4) in r201527. Submitted by: Alexander Zagrebin alexz

svn commit: r209797 - head/sys/netinet/ipfw

2010-07-08 Thread Gleb Smirnoff
Author: glebius Date: Thu Jul 8 13:07:40 2010 New Revision: 209797 URL: http://svn.freebsd.org/changeset/base/209797 Log: Since r209216 bpf(4) searches for mbuf_tags(9) and thus will not work with a stub m_hdr instead of a full mbuf. PR: kern/148050 Modified:

svn commit: r209845 - head/sys/netinet/ipfw

2010-07-09 Thread Gleb Smirnoff
Author: glebius Date: Fri Jul 9 11:27:33 2010 New Revision: 209845 URL: http://svn.freebsd.org/changeset/base/209845 Log: Improve last commit: use bpf_mtap2() to avoiding stack usage. Prodded by: julian Modified: head/sys/netinet/ipfw/ip_fw_log.c Modified:

Re: svn commit: r209859 - head/sys/dev/e1000

2010-07-13 Thread Gleb Smirnoff
On Fri, Jul 09, 2010 at 05:11:30PM +, Jack F Vogel wrote: J Author: jfv J Date: Fri Jul 9 17:11:29 2010 J New Revision: 209859 J URL: http://svn.freebsd.org/changeset/base/209859 J J Log: J Fix of a VLAN problem by jhb, the checksum capability J got lost along the way. J J MFC: asap

Re: svn commit: r209859 - head/sys/dev/e1000

2010-07-13 Thread Gleb Smirnoff
On Tue, Jul 13, 2010 at 04:39:13PM +0400, Gleb Smirnoff wrote: T On Fri, Jul 09, 2010 at 05:11:30PM +, Jack F Vogel wrote: T J Author: jfv T J Date: Fri Jul 9 17:11:29 2010 T J New Revision: 209859 T J URL: http://svn.freebsd.org/changeset/base/209859 T J T J Log: T J Fix of a VLAN problem

svn commit: r210500 - head/sys/netgraph/netflow

2010-07-26 Thread Gleb Smirnoff
Author: glebius Date: Mon Jul 26 13:48:35 2010 New Revision: 210500 URL: http://svn.freebsd.org/changeset/base/210500 Log: Zero padding fields of netflow records. This helps to reduce size of compressed export logs. Requested by: Alexey Illarionov littlesavage orionet.ru Modified:

svn commit: r210529 - head/sys/net

2010-07-27 Thread Gleb Smirnoff
Author: glebius Date: Tue Jul 27 10:05:27 2010 New Revision: 210529 URL: http://svn.freebsd.org/changeset/base/210529 Log: When installing a new ARP entry via 'arp -S', lla_lookup() will either find an existing entry, or allocate a new one. In the latter case an entry would have flags, that

svn commit: r210533 - head/sys/net

2010-07-27 Thread Gleb Smirnoff
Author: glebius Date: Tue Jul 27 11:56:49 2010 New Revision: 210533 URL: http://svn.freebsd.org/changeset/base/210533 Log: Don't check malloc(M_WAITOK) result. Modified: head/sys/net/if_llatbl.c Modified: head/sys/net/if_llatbl.c

svn commit: r210537 - in head/sys: netgraph netinet/ipfw

2010-07-27 Thread Gleb Smirnoff
Author: glebius Date: Tue Jul 27 14:26:34 2010 New Revision: 210537 URL: http://svn.freebsd.org/changeset/base/210537 Log: Fix operation of netgraph action in conjunction with the net.inet.ip.fw.one_pass sysctl. The ngtee action is still broken. PR: kern/148885 Submitted

svn commit: r210539 - head/sbin/ipfw

2010-07-27 Thread Gleb Smirnoff
Author: glebius Date: Tue Jul 27 14:31:39 2010 New Revision: 210539 URL: http://svn.freebsd.org/changeset/base/210539 Log: Document that the ngtee action no longer accepts packet, and thus don't depend on one_pass flag anymore. This is a POLA violation, but it is quite difficult to

svn commit: r212256 - head/sys/netinet/ipfw

2010-09-06 Thread Gleb Smirnoff
Author: glebius Date: Mon Sep 6 13:17:01 2010 New Revision: 212256 URL: http://svn.freebsd.org/changeset/base/212256 Log: in_delayed_cksum() requires host byte order. Reported by: Alexander Levin amindomao googlemail.com MFC after:1 week Modified:

svn commit: r213480 - in head/sys/dev/usb: . serial

2010-10-06 Thread Gleb Smirnoff
Author: glebius Date: Wed Oct 6 14:29:00 2010 New Revision: 213480 URL: http://svn.freebsd.org/changeset/base/213480 Log: Add support to Alcatel/TCTMobile X080S USB 3G modem. The device needs special eject command to reappear as modem. It also requires DIR_IN flag in the command message,

svn commit: r213481 - head/sys/dev/usb

2010-10-06 Thread Gleb Smirnoff
Author: glebius Date: Wed Oct 6 14:29:50 2010 New Revision: 213481 URL: http://svn.freebsd.org/changeset/base/213481 Log: Remove extra assignment. Modified: head/sys/dev/usb/usb_msctest.c Modified: head/sys/dev/usb/usb_msctest.c

svn commit: r213717 - head/sys/dev/usb

2010-10-12 Thread Gleb Smirnoff
Author: glebius Date: Tue Oct 12 09:41:42 2010 New Revision: 213717 URL: http://svn.freebsd.org/changeset/base/213717 Log: We already have dummy receive buffer in sc-buffer. Suggested by: hselasky Modified: head/sys/dev/usb/usb_msctest.c Modified: head/sys/dev/usb/usb_msctest.c

svn commit: r213831 - head/usr.sbin/ntp

2010-10-14 Thread Gleb Smirnoff
Author: glebius Date: Thu Oct 14 11:20:23 2010 New Revision: 213831 URL: http://svn.freebsd.org/changeset/base/213831 Log: Enable the shared memory reference clock driver. The GPS devices are getting more and more popular, as source of precise time, and the gpsd daemon from ports is using

svn commit: r236297 - head/sys/netinet

2012-05-30 Thread Gleb Smirnoff
Author: glebius Date: Wed May 30 07:11:27 2012 New Revision: 236297 URL: http://svn.freebsd.org/changeset/base/236297 Log: After r228571 carp_output() expects carp_softc * pointer in the mtag. Noticed by: thompsa Modified: head/sys/netinet/ip_carp.c Modified:

svn commit: r236310 - head/sys/netinet

2012-05-30 Thread Gleb Smirnoff
Author: glebius Date: Wed May 30 13:51:00 2012 New Revision: 236310 URL: http://svn.freebsd.org/changeset/base/236310 Log: Improve style(9) of bcopy() to and from mbuf tag. Submitted by: bde Modified: head/sys/netinet/ip_carp.c Modified: head/sys/netinet/ip_carp.c

svn commit: r236560 - head/sys/kern

2012-06-04 Thread Gleb Smirnoff
Author: glebius Date: Mon Jun 4 12:49:21 2012 New Revision: 236560 URL: http://svn.freebsd.org/changeset/base/236560 Log: Optimise kern_sendfile(): skip cycling through the entire mbuf chain in m_cat(), storing pointer to last mbuf in chain in local variable and attaching new mbuf to the

svn commit: r236563 - head/sys/kern

2012-06-04 Thread Gleb Smirnoff
Author: glebius Date: Mon Jun 4 14:18:13 2012 New Revision: 236563 URL: http://svn.freebsd.org/changeset/base/236563 Log: Microoptimisation of code from r236560, also coming from Nginx Inc. Submitted by: ru Modified: head/sys/kern/uipc_syscalls.c Modified:

Re: svn commit: r236563 - head/sys/kern

2012-06-04 Thread Gleb Smirnoff
On Mon, Jun 04, 2012 at 07:48:58PM -0700, Adrian Chadd wrote: A This commit undid part of what you committed in a previous commit? It didn't. Since we are sure that second arugment of m_cat() isn't a chain, but a single M_EXT mbuf, we can skip using m_cat and reduce code to m_last. -- Totus

svn commit: r236598 - head/sys/kern

2012-06-04 Thread Gleb Smirnoff
Author: glebius Date: Tue Jun 5 05:16:04 2012 New Revision: 236598 URL: http://svn.freebsd.org/changeset/base/236598 Log: style(9) for r236563. Modified: head/sys/kern/uipc_syscalls.c Modified: head/sys/kern/uipc_syscalls.c

svn commit: r236634 - head/usr.sbin/pmcstat

2012-06-05 Thread Gleb Smirnoff
Author: glebius Date: Tue Jun 5 20:08:59 2012 New Revision: 236634 URL: http://svn.freebsd.org/changeset/base/236634 Log: Don't crash trying to load symbols from striped file. PR: bin/167361 Submitted by: Slawa Olhovchenkov slw zxy.spb.ru Silence from: jkoshy Modified:

svn commit: r236671 - head/sys/contrib/pf/net

2012-06-06 Thread Gleb Smirnoff
Author: glebius Date: Wed Jun 6 09:36:52 2012 New Revision: 236671 URL: http://svn.freebsd.org/changeset/base/236671 Log: Merge revision 1.715 from OpenBSD: date: 2010/12/24 20:12:56; author: henning; state: Exp; lines: +3 -3 in pf_src_connlimit, the indices to sk-addr were

svn commit: r237929 - head/sys/geom/mirror

2012-07-01 Thread Gleb Smirnoff
Author: glebius Date: Sun Jul 1 15:30:43 2012 New Revision: 237929 URL: http://svn.freebsd.org/changeset/base/237929 Log: In g_mirror_regular_request() upon successful delivery treat BIO_DELETE requests same way as BIO_WRITE removing them from queue. This fixes panic with BIO_DELETE

svn commit: r237930 - head/sys/geom/mirror

2012-07-01 Thread Gleb Smirnoff
Author: glebius Date: Sun Jul 1 15:43:52 2012 New Revision: 237930 URL: http://svn.freebsd.org/changeset/base/237930 Log: Make geom_mirror more friendly to SSDs. To properly support TRIM, we need to pass BIO_DELETE requests down to providers that support it. Also, we need to announce our

svn commit: r237975 - head/sys/dev/sound/pci

2012-07-02 Thread Gleb Smirnoff
Author: glebius Date: Mon Jul 2 07:39:55 2012 New Revision: 237975 URL: http://svn.freebsd.org/changeset/base/237975 Log: - Call bus_generic_attach() at end of hdspe_attach(). - Use own devclass_t in DRIVER_MODULE(). This fixes operation of hdspe(4) when built as loadable module.

svn commit: r238010 - in head: share/mk usr.sbin

2012-07-02 Thread Gleb Smirnoff
Author: glebius Date: Mon Jul 2 18:04:31 2012 New Revision: 238010 URL: http://svn.freebsd.org/changeset/base/238010 Log: Fix build after r237997. Modified: head/share/mk/bsd.own.mk head/usr.sbin/Makefile Modified: head/share/mk/bsd.own.mk

Re: svn commit: r237997 - in head: tools/build/mk tools/build/options usr.sbin

2012-07-02 Thread Gleb Smirnoff
On Mon, Jul 02, 2012 at 03:28:50PM +, Baptiste Daroussin wrote: B Author: bapt B Date: Mon Jul 2 15:28:50 2012 B New Revision: 237997 B URL: http://svn.freebsd.org/changeset/base/237997 B B Log: B New build KNOB: WITHOUT_PKGBOOTSTRAP to condition building of usr.sbin/pkg B Do not

svn commit: r238016 - in head/sys: netinet netinet6

2012-07-02 Thread Gleb Smirnoff
Author: glebius Date: Mon Jul 2 19:44:18 2012 New Revision: 238016 URL: http://svn.freebsd.org/changeset/base/238016 Log: Remove route caching from IP multicast routing code. There is no reason to do that, and also, cached route never got unreferenced, which meant a reference leak.

svn commit: r238092 - in head/sys: net netinet netinet6

2012-07-04 Thread Gleb Smirnoff
Author: glebius Date: Wed Jul 4 07:37:53 2012 New Revision: 238092 URL: http://svn.freebsd.org/changeset/base/238092 Log: When ip_output()/ip6_output() is supplied a struct route *ro argument, it skips FLOWTABLE lookup. However, the non-NULL ro has dual meaning here: it may be supplied to

svn commit: r238093 - head/share/man/man9

2012-07-04 Thread Gleb Smirnoff
Author: glebius Date: Wed Jul 4 07:42:12 2012 New Revision: 238093 URL: http://svn.freebsd.org/changeset/base/238093 Log: Document RO_RTFREE() macro. Modified: head/share/man/man9/rtalloc.9 Modified: head/share/man/man9/rtalloc.9

Re: svn commit: r238092 - in head/sys: net netinet netinet6

2012-07-09 Thread Gleb Smirnoff
On Sat, Jul 07, 2012 at 09:36:11PM +, Bjoern A. Zeeb wrote: B Author: glebius B Date: Wed Jul 4 07:37:53 2012 B New Revision: 238092 B URL: http://svn.freebsd.org/changeset/base/238092 B B Log: B When ip_output()/ip6_output() is supplied a struct route *ro argument, B it skips

Re: svn commit: r238277 - in head: etc/defaults etc/rc.d sbin/ipfw share/man/man5 sys/netinet/ipfw

2012-07-10 Thread Gleb Smirnoff
Hiroki, On Tue, Jul 10, 2012 at 05:30:02AM +0900, Hiroki Sato wrote: H Given that we add a new API to H enumerate the interfaces including bpf-only providers with fake H ifnets, which providers/utilities should be converted to use it? IMO H usbusN would be a reasonable target but others

svn commit: r238498 - head/sys/contrib/pf/net

2012-07-15 Thread Gleb Smirnoff
Author: glebius Date: Sun Jul 15 19:10:00 2012 New Revision: 238498 URL: http://svn.freebsd.org/changeset/base/238498 Log: Use M_NOWAIT while holding the pf giant lock. Modified: head/sys/contrib/pf/net/pf_if.c Modified: head/sys/contrib/pf/net/pf_if.c

svn commit: r238516 - head/sys/netinet

2012-07-16 Thread Gleb Smirnoff
Author: glebius Date: Mon Jul 16 07:08:34 2012 New Revision: 238516 URL: http://svn.freebsd.org/changeset/base/238516 Log: If ip_output() returns EMSGSIZE to tcp_output(), then the latter calls tcp_mtudisc(), which in its turn may call tcp_output(). Under certain conditions (must admit they

svn commit: r238572 - head/sys/netinet

2012-07-18 Thread Gleb Smirnoff
Author: glebius Date: Wed Jul 18 08:41:00 2012 New Revision: 238572 URL: http://svn.freebsd.org/changeset/base/238572 Log: When traversing global in_ifaddr list in the IFP_TO_IA() macro, we need to obtain IN_IFADDR_RLOCK(). Modified: head/sys/netinet/in_var.h Modified:

svn commit: r238573 - head/sys/netinet

2012-07-18 Thread Gleb Smirnoff
Author: glebius Date: Wed Jul 18 08:58:30 2012 New Revision: 238573 URL: http://svn.freebsd.org/changeset/base/238573 Log: Plug a reference leak: before doing 'goto again' we need to unref ia-ia_ifa if there is any. Submitted by: Andrey Zonov andrey zonov.org Modified:

svn commit: r238672 - head/sys/dev/sdhci

2012-07-21 Thread Gleb Smirnoff
Author: glebius Date: Sat Jul 21 14:07:43 2012 New Revision: 238672 URL: http://svn.freebsd.org/changeset/base/238672 Log: Fix typo in comment, should be MHz here. Submitted by: Daan Vreeken Daan vitsch.nl Modified: head/sys/dev/sdhci/sdhci.c Modified: head/sys/dev/sdhci/sdhci.c

Re: svn commit: r238672 - head/sys/dev/sdhci

2012-07-23 Thread Gleb Smirnoff
On Sat, Jul 21, 2012 at 03:30:26PM +, Alexey Dokuchaev wrote: A On Sat, Jul 21, 2012 at 02:07:43PM +, Gleb Smirnoff wrote: A Author: glebius A Date: Sat Jul 21 14:07:43 2012 A New Revision: 238672 A URL: http://svn.freebsd.org/changeset/base/238672 A A Log: AFix typo in comment

svn commit: r238828 - head/sys/sys

2012-07-27 Thread Gleb Smirnoff
Author: glebius Date: Fri Jul 27 09:16:48 2012 New Revision: 238828 URL: http://svn.freebsd.org/changeset/base/238828 Log: Add assertion for refcount overflow. Submitted by: Andrey Zonov andrey zonov.org Reviewed by: kib Modified: head/sys/sys/refcount.h Modified:

Re: svn commit: r238828 - head/sys/sys

2012-07-27 Thread Gleb Smirnoff
On Fri, Jul 27, 2012 at 02:12:37PM +0300, Konstantin Belousov wrote: K On Fri, Jul 27, 2012 at 09:16:48AM +, Gleb Smirnoff wrote: K Author: glebius K Date: Fri Jul 27 09:16:48 2012 K New Revision: 238828 K URL: http://svn.freebsd.org/changeset/base/238828 K K Log: KAdd assertion

Re: svn commit: r238828 - head/sys/sys

2012-07-27 Thread Gleb Smirnoff
On Fri, Jul 27, 2012 at 10:32:55PM +1000, Bruce Evans wrote: B On Fri, Jul 27, 2012 at 02:12:37PM +0300, Konstantin Belousov wrote: B K On Fri, Jul 27, 2012 at 09:16:48AM +, Gleb Smirnoff wrote: B K ... B K Log: B KAdd assertion for refcount overflow. B K B KSubmitted

Re: svn commit: r238828 - head/sys/sys

2012-07-27 Thread Gleb Smirnoff
On Fri, Jul 27, 2012 at 11:30:58PM +1000, Bruce Evans wrote: B On Fri, Jul 27, 2012 at 10:32:55PM +1000, Bruce Evans wrote: B B I just noticed that there is a technical problem -- the count is read B B unlocked in the KASSERT. And since the comparision is for equality, B B if you lose the

svn commit: r238898 - head/sys/dev/sdhci

2012-07-30 Thread Gleb Smirnoff
Author: glebius Date: Mon Jul 30 08:56:56 2012 New Revision: 238898 URL: http://svn.freebsd.org/changeset/base/238898 Log: Return back double spacing. Modified: head/sys/dev/sdhci/sdhci.c Modified: head/sys/dev/sdhci/sdhci.c

svn commit: r238945 - in head/sys: net netinet netinet6

2012-07-31 Thread Gleb Smirnoff
Author: glebius Date: Tue Jul 31 11:31:12 2012 New Revision: 238945 URL: http://svn.freebsd.org/changeset/base/238945 Log: Some style(9) and whitespace changes. Together with:Andrey Zonov andrey zonov.org Modified: head/sys/net/if_llatbl.c head/sys/net/if_llatbl.h

svn commit: r238967 - in head/sys: net netinet netinet6

2012-08-01 Thread Gleb Smirnoff
Author: glebius Date: Wed Aug 1 09:00:26 2012 New Revision: 238967 URL: http://svn.freebsd.org/changeset/base/238967 Log: Some more whitespace cleanup. Modified: head/sys/net/if_llatbl.c head/sys/netinet/if_ether.c head/sys/netinet/in.c head/sys/netinet6/in6.c Modified:

svn commit: r238989 - head/sys/net

2012-08-02 Thread Gleb Smirnoff
Author: glebius Date: Thu Aug 2 13:20:44 2012 New Revision: 238989 URL: http://svn.freebsd.org/changeset/base/238989 Log: The llentry_update() is used only by flowtable and the latter always passes NULL pointer to it. Thus, code can be simplified and function renamed to llentry_alloc() to

svn commit: r238990 - in head/sys: net netinet netinet6

2012-08-02 Thread Gleb Smirnoff
Author: glebius Date: Thu Aug 2 13:57:49 2012 New Revision: 238990 URL: http://svn.freebsd.org/changeset/base/238990 Log: Fix races between in_lltable_prefix_free(), lla_lookup(), llentry_free() and arptimer(): o Use callout_init_rw() for lle timeout, this allows us safely

Re: svn commit: r238990 - in head/sys: net netinet netinet6

2012-08-02 Thread Gleb Smirnoff
On Thu, Aug 02, 2012 at 04:46:42PM +, Bjoern A. Zeeb wrote: B On Thu, 2 Aug 2012, Gleb Smirnoff wrote: B B Author: glebius B Date: Thu Aug 2 13:57:49 2012 B New Revision: 238990 B URL: http://svn.freebsd.org/changeset/base/238990 B B Log: B Fix races between in_lltable_prefix_free

svn commit: r239090 - head/share/man/man4

2012-08-06 Thread Gleb Smirnoff
Author: glebius Date: Mon Aug 6 08:59:39 2012 New Revision: 239090 URL: http://svn.freebsd.org/changeset/base/239090 Log: Add supported device. Modified: head/share/man/man4/umodem.4 Modified: head/share/man/man4/umodem.4

svn commit: r226725 - head/usr.sbin/ypserv

2011-10-25 Thread Gleb Smirnoff
Author: glebius Date: Tue Oct 25 10:33:26 2011 New Revision: 226725 URL: http://svn.freebsd.org/changeset/base/226725 Log: Protect NIS server with madvise(2) since this daemon is required for succesful authentication of users. Modified: head/usr.sbin/ypserv/yp_main.c Modified:

svn commit: r226829 - head/sys/netgraph

2011-10-27 Thread Gleb Smirnoff
Author: glebius Date: Thu Oct 27 09:43:25 2011 New Revision: 226829 URL: http://svn.freebsd.org/changeset/base/226829 Log: - If KDB NETGRAPH_DEBUG are on, print traces on discovered failed invariants. - Reduce tautology in NETGRAPH_DEBUG output. Modified: head/sys/netgraph/netgraph.h

svn commit: r226830 - head/sys/net

2011-10-27 Thread Gleb Smirnoff
Author: glebius Date: Thu Oct 27 09:45:12 2011 New Revision: 226830 URL: http://svn.freebsd.org/changeset/base/226830 Log: Add macro IF_DEQUEUE_ALL(ifq, m), that takes the entire mbuf chain off the queue. It can be utilized in queue processing to avoid multiple locking/unlocking. Modified:

svn commit: r226831 - head/sys/contrib/pf/net

2011-10-27 Thread Gleb Smirnoff
Author: glebius Date: Thu Oct 27 09:47:00 2011 New Revision: 226831 URL: http://svn.freebsd.org/changeset/base/226831 Log: Utilize new IF_DEQUEUE_ALL(ifq, m) macro in pfsyncintr() to reduce contention on ifqueue lock. Modified: head/sys/contrib/pf/net/if_pfsync.c Modified:

svn commit: r227308 - head/sys/netinet6

2011-11-07 Thread Gleb Smirnoff
Author: glebius Date: Mon Nov 7 14:22:18 2011 New Revision: 227308 URL: http://svn.freebsd.org/changeset/base/227308 Log: In icmp6_redirect_input: - Assert that we got a valid mbuf with rcvif pointer. [1] - Use __func__ in logging. Submitted by: prabhakar lakhera prabhakar.lakhera

svn commit: r227419 - head/sbin/ipfw

2011-11-10 Thread Gleb Smirnoff
Author: glebius Date: Thu Nov 10 12:05:26 2011 New Revision: 227419 URL: http://svn.freebsd.org/changeset/base/227419 Log: Note that NAT instance argument can be tablearg. PR: misc/162265 Submitted by: Paul Procacci pprocacci gmail.com Modified: head/sbin/ipfw/ipfw.8

svn commit: r227528 - head/etc

2011-11-15 Thread Gleb Smirnoff
Author: glebius Date: Tue Nov 15 12:59:07 2011 New Revision: 227528 URL: http://svn.freebsd.org/changeset/base/227528 Log: On some laptops it is important to re-open /dev/psm after resume. moused(8) was capable to do this upon SIGHUP for more than a decade. Automate this via rc.resume in

svn commit: r227738 - head/sbin/ifconfig

2011-11-19 Thread Gleb Smirnoff
Author: glebius Date: Sat Nov 19 19:06:08 2011 New Revision: 227738 URL: http://svn.freebsd.org/changeset/base/227738 Log: For unknown reason, since rev 1.1 of ifconfig.c, sin_family isn't set properly for the mask argument. Since I'd like to improve argument sanity checking in kernel

svn commit: r227787 - head/etc

2011-11-21 Thread Gleb Smirnoff
Author: glebius Date: Mon Nov 21 12:23:22 2011 New Revision: 227787 URL: http://svn.freebsd.org/changeset/base/227787 Log: Better use pkill(1) in last commit. Submitted by: pjd Modified: head/etc/rc.resume Modified: head/etc/rc.resume

svn commit: r227790 - head/sys/netinet

2011-11-21 Thread Gleb Smirnoff
Author: glebius Date: Mon Nov 21 13:40:35 2011 New Revision: 227790 URL: http://svn.freebsd.org/changeset/base/227790 Log: Be more informative for unknown hardware address format message. Submitted by: Andrzej Tobola ato iem.pw.edu.pl Modified: head/sys/netinet/if_ether.c Modified:

svn commit: r227791 - head/sys/netinet

2011-11-21 Thread Gleb Smirnoff
Author: glebius Date: Mon Nov 21 14:10:13 2011 New Revision: 227791 URL: http://svn.freebsd.org/changeset/base/227791 Log: Historically in_control() did not check sockaddrs supplied with structs ifreq/in_aliasreq and there've been several panics due to that problem. All these panics were

Re: svn commit: r227791 - head/sys/netinet

2011-11-21 Thread Gleb Smirnoff
to recover in case of (*ifp-if_ioctl) failure, but did not try to recover in case of failure of: in_addprefix() ifa_add_loopback_route() Q --Qing Q Q On Mon, Nov 21, 2011 at 6:10 AM, Gleb Smirnoff gleb...@freebsd.org wrote: Q Author: glebius Q Date: Mon Nov 21 14:10:13 2011 Q New Revision

svn commit: r227801 - head/sys/netinet

2011-11-21 Thread Gleb Smirnoff
Author: glebius Date: Mon Nov 21 20:07:12 2011 New Revision: 227801 URL: http://svn.freebsd.org/changeset/base/227801 Log: This check isn't needed now, sanity checking done in the beginning. Missed it in last commit. Modified: head/sys/netinet/in.c Modified: head/sys/netinet/in.c

Re: svn commit: r227791 - head/sys/netinet

2011-11-22 Thread Gleb Smirnoff
Qing, first I'd like to notice that we are speaking about obsoleted interfaces. This should be taken into account during all the discussion. We shouldn't make code more complex in favor to make obsoleted interfaces more smart. 1) Scrubbing in in_ifinit() is done only in case of SIOCSIFADDR.

svn commit: r227831 - head/sys/netinet

2011-11-22 Thread Gleb Smirnoff
Author: glebius Date: Tue Nov 22 19:39:27 2011 New Revision: 227831 URL: http://svn.freebsd.org/changeset/base/227831 Log: style(9) nit Modified: head/sys/netinet/in.c Modified: head/sys/netinet/in.c == ---

svn commit: r227832 - head/sys/net

2011-11-22 Thread Gleb Smirnoff
Author: glebius Date: Tue Nov 22 19:42:17 2011 New Revision: 227832 URL: http://svn.freebsd.org/changeset/base/227832 Log: Improve logging: - don't hardcode function name - use LOG_DEBUG for such a debug message - print error value Modified: head/sys/net/if.c Modified:

svn commit: r227901 - head/sbin/ipfw

2011-11-23 Thread Gleb Smirnoff
Author: glebius Date: Wed Nov 23 18:38:08 2011 New Revision: 227901 URL: http://svn.freebsd.org/changeset/base/227901 Log: Fix parsing of redirect_addr argument. PR: kern/162739 MFC after:3 days Modified: head/sbin/ipfw/nat.c Modified: head/sbin/ipfw/nat.c

svn commit: r227958 - head/sys/netinet

2011-11-24 Thread Gleb Smirnoff
Author: glebius Date: Thu Nov 24 22:43:48 2011 New Revision: 227958 URL: http://svn.freebsd.org/changeset/base/227958 Log: Fix stupid typo in r227830. PR: 162806 Pointy hat to:glebius Modified: head/sys/netinet/in.c Modified: head/sys/netinet/in.c

svn commit: r227959 - head/sys/netinet

2011-11-24 Thread Gleb Smirnoff
Author: glebius Date: Thu Nov 24 22:46:11 2011 New Revision: 227959 URL: http://svn.freebsd.org/changeset/base/227959 Log: Remove superfluous check: SIOCAIFADDR must have ifra_addr supplied. Modified: head/sys/netinet/in.c Modified: head/sys/netinet/in.c

svn commit: r228062 - head/sys/netinet

2011-11-28 Thread Gleb Smirnoff
Author: glebius Date: Mon Nov 28 13:30:14 2011 New Revision: 228062 URL: http://svn.freebsd.org/changeset/base/228062 Log: Fix one more fallout from r227791: do not overwrite trimmed sa_len on the ia_sockmask when doing SIOCSIFNETMASK. Reported by: Stefan Bethke stb lassitu.de, gonzo

svn commit: r228071 - head/sys/net

2011-11-28 Thread Gleb Smirnoff
Author: glebius Date: Mon Nov 28 14:44:59 2011 New Revision: 228071 URL: http://svn.freebsd.org/changeset/base/228071 Log: - Use generic alloc_unr(9) allocator for if_clone, instead of hand-made. - When registering new cloner, check whether a cloner with same name already exist. -

Re: svn commit: r228071 - head/sys/net

2011-11-29 Thread Gleb Smirnoff
On Mon, Nov 28, 2011 at 07:47:22PM +, Bjoern A. Zeeb wrote: B On 28. Nov 2011, at 14:44 , Gleb Smirnoff wrote: B B Author: glebius B Date: Mon Nov 28 14:44:59 2011 B New Revision: 228071 B URL: http://svn.freebsd.org/changeset/base/228071 B B Log: B - Use generic alloc_unr(9

Re: svn commit: r228071 - head/sys/net

2011-11-29 Thread Gleb Smirnoff
On Mon, Nov 28, 2011 at 10:23:07PM +0200, Jaakko Heinonen wrote: J On 2011-11-28, Bjoern A. Zeeb wrote: J static void J if_clone_free(struct if_clone *ifc) J { J -for (int bytoff = 0; bytoff ifc-ifc_bmlen; bytoff++) { J -KASSERT(ifc-ifc_units[bytoff] == 0x00, J

svn commit: r228150 - head/sys/contrib/pf/net

2011-11-30 Thread Gleb Smirnoff
Author: glebius Date: Wed Nov 30 08:47:17 2011 New Revision: 228150 URL: http://svn.freebsd.org/changeset/base/228150 Log: Return value should be conditional on return value of pfsync_defer_ptr() PR: kern/162947 Submitted by: Matthieu Kraus matthieu.kraus s2008.tu-chemnitz.de

svn commit: r228313 - head/sys/netinet

2011-12-06 Thread Gleb Smirnoff
Author: glebius Date: Tue Dec 6 20:55:20 2011 New Revision: 228313 URL: http://svn.freebsd.org/changeset/base/228313 Log: Fix a very special case when SIOCAIFADDR supplies mask of 0.0.0.0, don't overwrite the mask with autoguessing based on classes. Modified: head/sys/netinet/in.c

svn commit: r228321 - head/sys/netinet6

2011-12-07 Thread Gleb Smirnoff
Author: glebius Date: Wed Dec 7 13:37:42 2011 New Revision: 228321 URL: http://svn.freebsd.org/changeset/base/228321 Log: Fix double free. PR: kern/163089 Submitted by: Herbie Robinson Herbie.Robinson stratus.com Modified: head/sys/netinet6/mld6.c Modified:

svn commit: r228454 - head/sys/netinet

2011-12-12 Thread Gleb Smirnoff
Author: glebius Date: Tue Dec 13 06:56:43 2011 New Revision: 228454 URL: http://svn.freebsd.org/changeset/base/228454 Log: Belatedly catch up with r151555. in_scrubprefix() also needs this fix. We should compare not only addresses, but their masks, too, when searching for matching prefix.

svn commit: r228455 - head/sys/nfs

2011-12-12 Thread Gleb Smirnoff
Author: glebius Date: Tue Dec 13 07:02:48 2011 New Revision: 228455 URL: http://svn.freebsd.org/changeset/base/228455 Log: Some cleanup of BOOTP code. Initially I wanted to just change the ifioctl() usage, but end up with more changes. - Use SIOCAIFADDR instead of old rusty SIOCSIFADDR,

Re: svn commit: r228457 - head/share/man/man5

2011-12-13 Thread Gleb Smirnoff
On Tue, Dec 13, 2011 at 08:23:03AM +, Ruslan Ermilov wrote: R Author: ru R Date: Tue Dec 13 08:23:03 2011 R New Revision: 228457 R URL: http://svn.freebsd.org/changeset/base/228457 R R Log: R The inet keyword in the ifconfig_IF_aliasN is mandatory for R IPv4 aliases to work since

svn commit: r228463 - head/sbin/dhclient

2011-12-13 Thread Gleb Smirnoff
Author: glebius Date: Tue Dec 13 11:54:51 2011 New Revision: 228463 URL: http://svn.freebsd.org/changeset/base/228463 Log: dhclient-script relied on incorrect behavior of SIOCAIFADDR ioctl, that changed 0.0.0.0/0.0.0.0 prefix to 0.0.0.0/255.0.0.0. In the r228313 this behavior was fixed,

svn commit: r228472 - head/etc

2011-12-13 Thread Gleb Smirnoff
Author: glebius Date: Tue Dec 13 14:36:04 2011 New Revision: 228472 URL: http://svn.freebsd.org/changeset/base/228472 Log: Add compatibility support for specifing IPv4 aliases in rc.conf without the inet keyword. Obtained from:hrs Modified: head/etc/network.subr Modified:

svn commit: r228499 - head/share/man/man9

2011-12-14 Thread Gleb Smirnoff
version of this manual page was written by +.An -nosplit +.An Garrett Wollman . +It was significantly updated by +.An Gleb Smirnoff . ___ svn-src-head@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail

svn commit: r228500 - head/share/man/man9

2011-12-14 Thread Gleb Smirnoff
Author: glebius Date: Wed Dec 14 14:55:19 2011 New Revision: 228500 URL: http://svn.freebsd.org/changeset/base/228500 Log: More MLINKS for rtalloc.9 Modified: head/share/man/man9/Makefile Modified: head/share/man/man9/Makefile

svn commit: r228527 - head/sys/conf

2011-12-15 Thread Gleb Smirnoff
Author: glebius Date: Thu Dec 15 11:15:23 2011 New Revision: 228527 URL: http://svn.freebsd.org/changeset/base/228527 Log: Add RADIX_MPATH to LINT. Modified: head/sys/conf/NOTES Modified: head/sys/conf/NOTES == ---

svn commit: r228532 - head/sys/net

2011-12-15 Thread Gleb Smirnoff
Author: glebius Date: Thu Dec 15 12:49:10 2011 New Revision: 228532 URL: http://svn.freebsd.org/changeset/base/228532 Log: Simplify rtrequest(RTM_ADD): ifa can't be NULL after rt_getifa_fib(). Modified: head/sys/net/route.c Modified: head/sys/net/route.c

Re: svn commit: r223637 - in head: . contrib/pf/authpf contrib/pf/ftp-proxy contrib/pf/man contrib/pf/pfctl contrib/pf/pflogd sbin/pflogd sys/conf sys/contrib/altq/altq sys/contrib/pf/net sys/modules

2011-12-15 Thread Gleb Smirnoff
Peter, On Fri, Dec 16, 2011 at 01:58:51PM +1100, Peter Jeremy wrote: P On 2011-Jun-28 11:57:25 +, Bjoern A. Zeeb b...@freebsd.org wrote: P Author: bz P Date: Tue Jun 28 11:57:25 2011 P New Revision: 223637 P URL: http://svn.freebsd.org/changeset/base/223637 P P Log: P Update packet

svn commit: r228563 - head/sys/conf

2011-12-16 Thread Gleb Smirnoff
Author: glebius Date: Fri Dec 16 08:27:04 2011 New Revision: 228563 URL: http://svn.freebsd.org/changeset/base/228563 Log: Fix my braino in description of RADIX_MPATH. Modified: head/sys/conf/NOTES Modified: head/sys/conf/NOTES

svn commit: r228565 - head/sbin/devd

2011-12-16 Thread Gleb Smirnoff
Author: glebius Date: Fri Dec 16 10:14:41 2011 New Revision: 228565 URL: http://svn.freebsd.org/changeset/base/228565 Log: Xref re_format(7). Modified: head/sbin/devd/devd.8 Modified: head/sbin/devd/devd.8 == ---

svn commit: r228566 - head/sbin/devd

2011-12-16 Thread Gleb Smirnoff
Author: glebius Date: Fri Dec 16 10:21:01 2011 New Revision: 228566 URL: http://svn.freebsd.org/changeset/base/228566 Log: Xref re_format(7) in devd.conf(5), not in devd(8). Pointy hat to:glebius Modified: head/sbin/devd/devd.8 head/sbin/devd/devd.conf.5 Modified:

svn commit: r228571 - in head: . lib/libc/net sbin/ifconfig share/man/man4 sys/net sys/netinet sys/netinet6 sys/sys

2011-12-16 Thread Gleb Smirnoff
$ .\ .\ Copyright (c) 2003, Ryan McBride. All rights reserved. +.\ Copyright (c) 2011, Gleb Smirnoff gleb...@freebsd.org .\ .\ Redistribution and use in source and binary forms, with or without .\ modification, are permitted provided that the following conditions @@ -25,7 +26,7 @@ .\ .\ $FreeBSD$ .\ -.Dd

<    1   2   3   4   5   6   7   8   9   10   >