Luigi,
On Thu, Mar 01, 2012 at 05:35:17PM +, Luigi Rizzo wrote:
L Author: luigi
L Date: Thu Mar 1 17:35:16 2012
L New Revision: 232347
L URL: http://svn.freebsd.org/changeset/base/232347
L
L Log:
L remove some write-only variables.
L There is another block of code that is now useless
Author: glebius
Date: Sun Mar 4 09:45:43 2012
New Revision: 232484
URL: http://svn.freebsd.org/changeset/base/232484
Log:
Fix build w/o 'options IEEE80211_SUPPORT_MESH'.
Modified:
head/sys/net80211/ieee80211_input.c
Modified: head/sys/net80211/ieee80211_input.c
Author: glebius
Date: Mon Mar 5 06:12:15 2012
New Revision: 232538
URL: http://svn.freebsd.org/changeset/base/232538
Log:
Fix ng_ipfw(4) cookie number in example.
Pointed out by: Jacco van Buuren jaccovanbuuren gmail.com
Modified:
head/share/man/man4/ng_patch.4
Modified:
Author: glebius
Date: Thu Mar 8 09:20:00 2012
New Revision: 232685
URL: http://svn.freebsd.org/changeset/base/232685
Log:
Merge from OpenBSD:
revision 1.146
date: 2010/05/12 08:11:11; author: claudio; state: Exp; lines: +2 -3
bzero() the full compressed update struct before
Author: glebius
Date: Mon Mar 19 09:30:40 2012
New Revision: 233167
URL: http://svn.freebsd.org/changeset/base/233167
Log:
Rotate auth.log and messages at the beginning of a year. Otherwise,
daily security checks 800.loginfail and 900.tcpwrap may produce
false positive alerts.
Modified:
Davide,
On Fri, Mar 16, 2012 at 08:32:11PM +, Davide Italiano wrote:
D Author: davide
D Date: Fri Mar 16 20:32:11 2012
D New Revision: 233045
D URL: http://svn.freebsd.org/changeset/base/233045
D
D Log:
D Add rudimentary profiling of the hash table used in the in the umtx code to
D
Author: glebius
Date: Fri Apr 19 13:40:13 2013
New Revision: 249649
URL: http://svnweb.freebsd.org/changeset/base/249649
Log:
Don't compare unsigned socklen_t against 0.
Reviewed by: jhb
Modified:
head/sys/kern/uipc_syscalls.c
Modified: head/sys/kern/uipc_syscalls.c
Author: glebius
Date: Mon Apr 22 09:02:23 2013
New Revision: 249763
URL: http://svnweb.freebsd.org/changeset/base/249763
Log:
Panic if UMA_ZONE_PCPU is created at early stages of boot, when mp_ncpus
isn't yet initialized. Otherwise we will panic at first allocation later.
Sponsored by:
On Wed, Apr 24, 2013 at 06:30:32PM +, Randall Stewart wrote:
R Author: rrs
R Date: Wed Apr 24 18:30:32 2013
R New Revision: 249848
R URL: http://svnweb.freebsd.org/changeset/base/249848
R
R Log:
R This fixes the issue with the randomly changing default
R route. What it was is there are
Author: glebius
Date: Thu Apr 25 12:42:09 2013
New Revision: 249894
URL: http://svnweb.freebsd.org/changeset/base/249894
Log:
Introduce a pointer to const variable gw, which points either at the
same place as dst, or to the sockaddr in the routing table.
The const constraint of gw makes
Author: glebius
Date: Thu Apr 25 16:23:22 2013
New Revision: 249896
URL: http://svnweb.freebsd.org/changeset/base/249896
Log:
Restore the ipNetToMedia MIB, that was broken with new ARP commit
in the r186119.
Submitted by: Konstantin Kukushkin dark rambler-co.ru
Modified:
Author: glebius
Date: Thu Apr 25 16:34:04 2013
New Revision: 249897
URL: http://svnweb.freebsd.org/changeset/base/249897
Log:
Don't free memory that is going to be used as error string.
PR: bin/178121
Submitted by: Garrett Cooper yaneurabeya gmail.com
Modified:
Author: glebius
Date: Thu Apr 25 17:38:04 2013
New Revision: 249903
URL: http://svnweb.freebsd.org/changeset/base/249903
Log:
Fix couple of mbuf leaks in incoming ARP processing.
Modified:
head/sys/netinet/if_ether.c
Modified: head/sys/netinet/if_ether.c
On Thu, Apr 25, 2013 at 11:33:33AM -0700, Adrian Chadd wrote:
A .. is it possible to trigger a remote DoS through mbuf exhaustion
A somehow by exploiting this?
Yes, from a connected network.
--
Totus tuus, Glebius.
___
svn-src-head@freebsd.org mailing
On Fri, Apr 26, 2013 at 01:24:12AM -0700, Adrian Chadd wrote:
A On 26 April 2013 01:17, Gleb Smirnoff gleb...@freebsd.org wrote:
A On Thu, Apr 25, 2013 at 11:33:33AM -0700, Adrian Chadd wrote:
A A .. is it possible to trigger a remote DoS through mbuf exhaustion
A A somehow by exploiting
Author: glebius
Date: Fri Apr 26 12:50:32 2013
New Revision: 249925
URL: http://svnweb.freebsd.org/changeset/base/249925
Log:
Add const qualifier to the dst parameter of the ifnet if_output method.
Modified:
head/sys/dev/iicbus/if_ic.c
head/sys/dev/lmc/if_lmc.c
head/sys/dev/lmc/if_lmc.h
Author: glebius
Date: Fri Apr 26 13:02:11 2013
New Revision: 249926
URL: http://svnweb.freebsd.org/changeset/base/249926
Log:
On those machines that use critical(9) for counter(9) we need to
include systm.h.
Modified:
head/share/man/man9/counter.9
Modified: head/share/man/man9/counter.9
Author: glebius
Date: Fri Apr 26 13:03:22 2013
New Revision: 249927
URL: http://svnweb.freebsd.org/changeset/base/249927
Log:
Add usie to LINT.
Modified:
head/sys/conf/NOTES
Modified: head/sys/conf/NOTES
==
---
Author: glebius
Date: Fri Apr 26 13:18:07 2013
New Revision: 249928
URL: http://svnweb.freebsd.org/changeset/base/249928
Log:
Document constantness of dst argument to if_output.
Submitted by: pluknet
Modified:
head/share/man/man9/ifnet.9
Modified: head/share/man/man9/ifnet.9
Author: glebius
Date: Sat Apr 27 08:11:48 2013
New Revision: 249976
URL: http://svnweb.freebsd.org/changeset/base/249976
Log:
Add const qualifier to the dst parameter of the ifnet if_output method.
Modified:
head/sys/ofed/drivers/infiniband/ulp/ipoib/ipoib_main.c
Modified:
Author: glebius
Date: Mon Apr 29 06:11:19 2013
New Revision: 250039
URL: http://svnweb.freebsd.org/changeset/base/250039
Log:
Remove useless ifdef KLD_MODULE from dummynet module unload path. This
fixes panic on unload.
Reported by: pho
Modified:
head/sys/netpfil/ipfw/ip_dummynet.c
On Tue, Apr 30, 2013 at 08:10:17PM +0400, Sergey Kandaurov wrote:
S On 30 April 2013 19:59, Davide Italiano dav...@freebsd.org wrote:
S Author: davide
S Date: Tue Apr 30 15:59:22 2013
S New Revision: 250105
S URL: http://svnweb.freebsd.org/changeset/base/250105
S
S Log:
Smalloc(9) cannot
Author: glebius
Date: Mon May 6 21:43:15 2013
New Revision: 250312
URL: http://svnweb.freebsd.org/changeset/base/250312
Log:
Simplify printf().
Modified:
head/sys/netpfil/pf/pf.c
Modified: head/sys/netpfil/pf/pf.c
Author: glebius
Date: Mon May 6 21:44:06 2013
New Revision: 250313
URL: http://svnweb.freebsd.org/changeset/base/250313
Log:
Improve KASSERT() message.
Modified:
head/sys/netpfil/pf/if_pfsync.c
Modified: head/sys/netpfil/pf/if_pfsync.c
Author: glebius
Date: Sat May 11 10:51:32 2013
New Revision: 250504
URL: http://svnweb.freebsd.org/changeset/base/250504
Log:
Rate limit the number of remotely triggered ARP log messages
to 1 log message per second.
Modified:
head/sys/netinet/if_ether.c
head/usr.sbin/arp/arp.4
Modified:
Author: glebius
Date: Sat May 11 17:57:52 2013
New Revision: 250518
URL: http://svnweb.freebsd.org/changeset/base/250518
Log:
Invalid creatorid is always EINVAL, not only when we are in verbose mode.
Modified:
head/sys/netpfil/pf/if_pfsync.c
Modified: head/sys/netpfil/pf/if_pfsync.c
Author: glebius
Date: Sat May 11 17:58:26 2013
New Revision: 250519
URL: http://svnweb.freebsd.org/changeset/base/250519
Log:
Fix DIOCADDSTATE operation.
Modified:
head/sys/netpfil/pf/pf_ioctl.c
Modified: head/sys/netpfil/pf/pf_ioctl.c
Author: glebius
Date: Sat May 11 18:03:36 2013
New Revision: 250521
URL: http://svnweb.freebsd.org/changeset/base/250521
Log:
Better debug message.
Modified:
head/sys/netpfil/pf/pf.c
Modified: head/sys/netpfil/pf/pf.c
Author: glebius
Date: Sat May 11 18:06:51 2013
New Revision: 250522
URL: http://svnweb.freebsd.org/changeset/base/250522
Log:
Return meaningful error code from pf_state_key_attach() and
pf_state_insert().
Modified:
head/sys/netpfil/pf/pf.c
Modified: head/sys/netpfil/pf/pf.c
On Thu, May 16, 2013 at 04:20:18PM +, Julian Elischer wrote:
J Modified: head/sys/sys/mbuf.h
J
==
J --- head/sys/sys/mbuf.h Thu May 16 15:28:38 2013(r250699)
J +++ head/sys/sys/mbuf.h Thu May 16
Sorry, I am slowpoke. Everything had already been noticed by
other reviewers.
On Fri, May 17, 2013 at 11:37:21AM +0400, Gleb Smirnoff wrote:
T On Thu, May 16, 2013 at 04:20:18PM +, Julian Elischer wrote:
T J Modified: head/sys/sys/mbuf.h
T J
On Tue, May 21, 2013 at 09:58:01PM +, Mateusz Guzik wrote:
M Author: mjg
M Date: Tue May 21 21:58:00 2013
M New Revision: 250890
M URL: http://svnweb.freebsd.org/changeset/base/250890
M
M Log:
M passing fd over unix socket: fix a corner case where caller
M wants to pass no descriptors.
M
Author: glebius
Date: Tue Jun 4 11:19:08 2013
New Revision: 251374
URL: http://svnweb.freebsd.org/changeset/base/251374
Log:
Improve r250890, so that we stop processing of a message with zero
descriptors as early as possible, and assert that number of descriptors
is positive in
On Fri, Jun 07, 2013 at 10:27:51AM +, Mikolaj Golub wrote:
M Author: trociny
M Date: Fri Jun 7 10:27:50 2013
M New Revision: 251490
M URL: http://svnweb.freebsd.org/changeset/base/251490
M
M Log:
M Properly set curvnet context in lagg_port_setlladdr() task handler.
M
M Reported by:
On Fri, Jun 07, 2013 at 02:33:08PM +0400, Gleb Smirnoff wrote:
T On Fri, Jun 07, 2013 at 10:27:51AM +, Mikolaj Golub wrote:
T M Author: trociny
T M Date: Fri Jun 7 10:27:50 2013
T M New Revision: 251490
T M URL: http://svnweb.freebsd.org/changeset/base/251490
T M
T M Log:
T M Properly set
Author: glebius
Date: Sat Jun 8 13:02:43 2013
New Revision: 251522
URL: http://svnweb.freebsd.org/changeset/base/251522
Log:
Separate LIO_SYNC processing into a separate function aio_process_sync(),
and rename aio_process() into aio_process_rw().
Reviewed by: kib
Sponsored by:
Author: glebius
Date: Sat Jun 8 13:13:40 2013
New Revision: 251523
URL: http://svnweb.freebsd.org/changeset/base/251523
Log:
Make sys_mlock() function just a wrapper around vm_mlock() function
that does all the job.
Reviewed by: kib, jilles
Sponsored by: Nginx, Inc.
Modified:
(r251526)
@@ -0,0 +1,133 @@
+.\ Copyright (c) 2013 Gleb Smirnoff gleb...@freebsd.org
+.\ All rights reserved.
+.\
+.\ Redistribution and use in source and binary forms, with or without
+.\ modification, are permitted provided that the following conditions
+.\ are met:
+.\ 1. Redistributions of source
Author: glebius
Date: Sat Jun 8 13:30:13 2013
New Revision: 251527
URL: http://svnweb.freebsd.org/changeset/base/251527
Log:
aio_mlock() added:
- Regen for r251526.
- Bump __FreeBSD_version.
Modified:
head/sys/compat/freebsd32/freebsd32_proto.h
Author: glebius
Date: Thu Jun 13 06:07:19 2013
New Revision: 251681
URL: http://svnweb.freebsd.org/changeset/base/251681
Log:
Improve locking strategy between keys hash and ID hash.
Before this change state creating sequence was:
1) lock wire key hash
2) link state's wire key
3)
Greg,
On Thu, Jun 13, 2013 at 04:11:21AM +, Greg Lehey wrote:
G Author: grog
G Date: Thu Jun 13 04:11:21 2013
G New Revision: 251678
G URL: http://svnweb.freebsd.org/changeset/base/251678
G
G Log:
G Revert revision 251648. style(9) requires an empty line here.
I am also a bit concerned
On Tue, Jun 18, 2013 at 10:25:08AM +0200, Andre Oppermann wrote:
A There used to be a problem with per CPU caches accumulating large amounts
A of items without freeing back to the global (or socket) pool.
A
A Do these updates to UMA change this situation and/or do you have further
A improvements
Author: glebius
Date: Fri Jun 21 06:36:26 2013
New Revision: 252055
URL: http://svnweb.freebsd.org/changeset/base/252055
Log:
Fix kmod_*stat_inc() after r249276. The incorrect code actually
increased the pointer, not the memory it points to.
In collaboration with:kib
Reported
Bruce,
On Fri, Jun 21, 2013 at 09:04:34AM +1000, Bruce Evans wrote:
B The i386 version of the counter asm doesn't support the immediate
B constraint for technical reasons. 64 bit counters are too large and
B slow to use on i386, especially when they are implemented as they are
B without
Bruce,
On Fri, Jun 21, 2013 at 09:02:36PM +1000, Bruce Evans wrote:
B Not if it is a 32-bit increment on 32-bit systems, as it should be.
B
B I said to use a daemon to convert small (16 or 32 bit) counters into
B larger (32 or 64 bit) ones. It is almost as efficient to call the
B accumulation
On Sun, Jun 23, 2013 at 10:33:43AM +0300, Konstantin Belousov wrote:
K On Sat, Jun 22, 2013 at 06:58:15PM +1000, Bruce Evans wrote:
K So the i386 version be simply addl; adcl to memory. Each store in
K this is atomic at the per-CPU level. If there is no carry, then the
K separate stores are
Bruce,
did you run your benchmarks in userland or in kernel? How many
parallel threads were updating the same counter?
Can you please share your benchmarks?
--
Totus tuus, Glebius.
___
svn-src-head@freebsd.org mailing list
Author: glebius
Date: Mon Jun 24 13:36:16 2013
New Revision: 252161
URL: http://svnweb.freebsd.org/changeset/base/252161
Log:
Typo in comment.
Modified:
head/sys/vm/vm_page.c
Modified: head/sys/vm/vm_page.c
==
---
On Mon, Jun 24, 2013 at 11:16:33PM +1000, Bruce Evans wrote:
B K This is quite interesting idea, but I still did not decided if it
B K acceptable. The issue is that we could add the carry to the other
B K processor counter, if the preemption kicks in at right time between
B K two
Bruce,
On Wed, Jun 26, 2013 at 11:42:39AM +1000, Bruce Evans wrote:
B Anyway, as Gleb said, there is no point in
B optimizing the i386 kernel.
B
B I said that there is every point in optimizing the i386 kernel. This
B applies even more to other 32-bit arches. Some CPUs are much slower
B
Author: glebius
Date: Thu Jun 27 10:42:09 2013
New Revision: 252302
URL: http://svnweb.freebsd.org/changeset/base/252302
Log:
Fix build.
Modified:
head/sbin/nvmecontrol/logpage.c
head/sbin/nvmecontrol/nvmecontrol.c
Modified: head/sbin/nvmecontrol/logpage.c
Author: glebius
Date: Fri Feb 7 13:47:33 2014
New Revision: 261590
URL: http://svnweb.freebsd.org/changeset/base/261590
Log:
Remove identical vnet sysctl handlers, and handle CTLFLAG_VNET
in the sysctl_root().
Note: SYSCTL_VNET_* macros can be removed as well. All is
needed to
Author: glebius
Date: Fri Feb 7 14:26:33 2014
New Revision: 261592
URL: http://svnweb.freebsd.org/changeset/base/261592
Log:
Catch up on r261590.
Modified:
head/sys/netinet/in_pcb.c
Modified: head/sys/netinet/in_pcb.c
Author: glebius
Date: Fri Feb 7 14:29:03 2014
New Revision: 261593
URL: http://svnweb.freebsd.org/changeset/base/261593
Log:
Provide macros that allow easily export uma(9) zone limits and
current usage via sysctl(9):
SYSCTL_UMA_MAX()
SYSCTL_ADD_UMA_MAX()
SYSCTL_UMA_CUR()
Author: glebius
Date: Fri Feb 7 14:31:51 2014
New Revision: 261594
URL: http://svnweb.freebsd.org/changeset/base/261594
Log:
Utilize SYSCTL_UMA_CUR() to export usage of syncache and
tcp reassembly zones.
Sponsored by: Nginx, Inc.
Modified:
head/sys/netinet/tcp_reass.c
Author: glebius
Date: Fri Feb 7 14:34:31 2014
New Revision: 261595
URL: http://svnweb.freebsd.org/changeset/base/261595
Log:
sysctl_handle_counter_u64() doesn't use arg2 argument, thus simplify
the SYSCTL_COUNTER_U64() macro.
Sponsored by: Nginx, Inc.
Modified:
Author: glebius
Date: Fri Feb 7 15:18:23 2014
New Revision: 261601
URL: http://svnweb.freebsd.org/changeset/base/261601
Log:
o Revamp API between flowtable and netinet, netinet6.
- ip_output() and ip_output6() simply call flowtable_lookup(),
passing mbuf and address family. That's
On Fri, Feb 07, 2014 at 03:34:27PM +, Bjoern A. Zeeb wrote:
B * XXX This does not end up updating timeouts at runtime
B * and only reflects the value for the last table added :-/
B */
B -SYSCTL_VNET_INT(_net_inet_flowtable, OID_AUTO, syn_expire, CTLFLAG_RW,
B
Author: glebius
Date: Fri Feb 7 21:56:16 2014
New Revision: 261610
URL: http://svnweb.freebsd.org/changeset/base/261610
Log:
Remove unused defines.
Modified:
head/sys/net/flowtable.c
Modified: head/sys/net/flowtable.c
Author: glebius
Date: Fri Feb 7 22:30:42 2014
New Revision: 261613
URL: http://svnweb.freebsd.org/changeset/base/261613
Log:
Fix comment.
Modified:
head/sys/net/flowtable.h
Modified: head/sys/net/flowtable.h
==
---
Author: glebius
Date: Sat Feb 8 09:56:26 2014
New Revision: 261627
URL: http://svnweb.freebsd.org/changeset/base/261627
Log:
Remove never set flag FL_OVERWRITE. The only place where
it was checked led to lock/critnest leak.
Modified:
head/sys/net/flowtable.c
head/sys/net/pfvar.h
Author: glebius
Date: Sat Feb 8 09:57:52 2014
New Revision: 261628
URL: http://svnweb.freebsd.org/changeset/base/261628
Log:
Revert accidentially leaked changes in r261627.
Modified:
head/sys/net/pfvar.h
Modified: head/sys/net/pfvar.h
Author: glebius
Date: Sat Feb 8 22:10:53 2014
New Revision: 261640
URL: http://svnweb.freebsd.org/changeset/base/261640
Log:
Spacing.
Modified:
head/sys/net/flowtable.c
Modified: head/sys/net/flowtable.c
==
---
Author: glebius
Date: Sat Feb 8 22:12:00 2014
New Revision: 261641
URL: http://svnweb.freebsd.org/changeset/base/261641
Log:
Remove ft_rtalloc and choose rtalloc function at compile time.
Modified:
head/sys/net/flowtable.c
Modified: head/sys/net/flowtable.c
Author: glebius
Date: Mon Feb 10 19:47:14 2014
New Revision: 261722
URL: http://svnweb.freebsd.org/changeset/base/261722
Log:
Add zpcpu_get_cpu() that converts base pointer of UMA_ZPCPU_ZONE
to a pointer private to a given cpuid.
Sponsored by: Nginx, Inc.
Modified:
head/sys/sys/pcpu.h
Author: glebius
Date: Mon Feb 10 19:48:26 2014
New Revision: 261723
URL: http://svnweb.freebsd.org/changeset/base/261723
Log:
Make M_ZERO flag work correctly on UMA_ZONE_PCPU zones.
Sponsored by: Nginx, Inc.
Modified:
head/sys/vm/uma_core.c
Modified: head/sys/vm/uma_core.c
Author: glebius
Date: Mon Feb 10 19:51:15 2014
New Revision: 261724
URL: http://svnweb.freebsd.org/changeset/base/261724
Log:
Style.
Modified:
head/sys/vm/uma.h
Modified: head/sys/vm/uma.h
==
--- head/sys/vm/uma.h
Author: glebius
Date: Mon Feb 10 19:59:46 2014
New Revision: 261725
URL: http://svnweb.freebsd.org/changeset/base/261725
Log:
Create two public UMA_ZONE_PCPU zones: 64 bit sized and pointer sized.
Sponsored by: Nginx, Inc.
Modified:
head/sys/kern/subr_counter.c
Author: glebius
Date: Wed Feb 12 09:41:17 2014
New Revision: 261796
URL: http://svnweb.freebsd.org/changeset/base/261796
Log:
While it isn't too late and kvm_read_zpcpu() function isn't yet used
outside libkvm(3), change its order of arguments, so that it is the
same as in kvm_read().
Author: glebius
Date: Wed Feb 12 09:59:48 2014
New Revision: 261797
URL: http://svnweb.freebsd.org/changeset/base/261797
Log:
Fix world build WITHOUT_PF.
Sponsored by: Nginx, Inc.
Modified:
head/sbin/ipfw/Makefile
head/sbin/ipfw/ipfw2.h
head/usr.bin/kdump/Makefile
Bruce,
On Thu, Feb 13, 2014 at 01:52:07AM +1100, Bruce Evans wrote:
B --- head/lib/libkvm/kvm_getpcpu.3 Wed Feb 12 08:04:38 2014
(r261795)
B +++ head/lib/libkvm/kvm_getpcpu.3 Wed Feb 12 09:41:17 2014
(r261796)
B @@ -50,7 +50,7 @@
B .Ft void *
B .Fn kvm_getpcpu kvm_t *kd
Author: glebius
Date: Wed Feb 12 20:11:20 2014
New Revision: 261811
URL: http://svnweb.freebsd.org/changeset/base/261811
Log:
Fix function name in KASSERT().
Submitted by: hiren
Modified:
head/sys/vm/vm_object.c
Modified: head/sys/vm/vm_object.c
Author: glebius
Date: Thu Feb 13 05:19:09 2014
New Revision: 261825
URL: http://svnweb.freebsd.org/changeset/base/261825
Log:
Remove unused FL_NOAUTO.
Modified:
head/sys/net/flowtable.c
head/sys/net/flowtable.h
Modified: head/sys/net/flowtable.c
On Fri, Feb 14, 2014 at 12:05:09AM +, Adrian Chadd wrote:
A Modified: head/usr.bin/netstat/flowtable.c
A
==
A --- head/usr.bin/netstat/flowtable.c Thu Feb 13 22:24:36 2014
(r261858)
A +++
On Fri, Feb 14, 2014 at 10:21:04AM +0400, Gleb Smirnoff wrote:
T On Fri, Feb 14, 2014 at 12:05:09AM +, Adrian Chadd wrote:
T A Modified: head/usr.bin/netstat/flowtable.c
T A
==
T A --- head/usr.bin/netstat/flowtable.c
On Fri, Feb 14, 2014 at 07:43:40AM +, Adrian Chadd wrote:
A Author: adrian
A Date: Fri Feb 14 07:43:39 2014
A New Revision: 261875
A URL: http://svnweb.freebsd.org/changeset/base/261875
A
A Log:
A Reword.
A
A Suggestion:glebius
A
A Modified:
A
Author: glebius
Date: Fri Feb 14 10:05:21 2014
New Revision: 261882
URL: http://svnweb.freebsd.org/changeset/base/261882
Log:
Once pf became not covered by a single mutex, many counters in it became
race prone. Some just gather statistics, but some are later used in
different calculations.
Author: glebius
Date: Fri Feb 14 10:56:26 2014
New Revision: 261883
URL: http://svnweb.freebsd.org/changeset/base/261883
Log:
Whenever flowtable lookup fails, we do route lookup and then try to
insert flow entry. During the route lookup the critical section is
exited. It may happen, that
Author: glebius
Date: Fri Feb 14 19:43:00 2014
New Revision: 261898
URL: http://svnweb.freebsd.org/changeset/base/261898
Log:
Fix build on 32bit arches broken by me in r261882.
Modified:
head/sbin/pfctl/pfctl.c
Modified: head/sbin/pfctl/pfctl.c
Author: glebius
Date: Sat Feb 15 16:22:51 2014
New Revision: 261937
URL: http://svnweb.freebsd.org/changeset/base/261937
Log:
Better build fix.
Modified:
head/sbin/pfctl/pfctl.c
Modified: head/sbin/pfctl/pfctl.c
==
Author: glebius
Date: Mon Feb 17 11:50:56 2014
New Revision: 262027
URL: http://svnweb.freebsd.org/changeset/base/262027
Log:
o Remove at compile time the HASH_ALL code, that was never
tested and is unfinished. However, I've tested my version,
it works okay. As before it is unfinished:
Author: glebius
Date: Mon Feb 17 12:01:50 2014
New Revision: 262028
URL: http://svnweb.freebsd.org/changeset/base/262028
Log:
Bring copyright notice to standard style.
Modified:
head/sys/net/flowtable.c
head/sys/net/flowtable.h
Modified: head/sys/net/flowtable.c
Author: glebius
Date: Mon Feb 17 12:02:44 2014
New Revision: 262029
URL: http://svnweb.freebsd.org/changeset/base/262029
Log:
Whitespace.
Modified:
head/sys/net/flowtable.c
Modified: head/sys/net/flowtable.c
==
---
==
--- head/sys/net/flowtable.cMon Feb 17 12:02:44 2014(r262029)
+++ head/sys/net/flowtable.cMon Feb 17 12:07:17 2014(r262030)
@@ -1,5 +1,5 @@
/*-
- *
+ * Copyright (c) 2014 Gleb Smirnoff gleb...@freebsd.org
* Copyright (c) 2008-2010
Author: glebius
Date: Tue Feb 18 14:21:26 2014
New Revision: 262162
URL: http://svnweb.freebsd.org/changeset/base/262162
Log:
Fix incorrect assertions.
Modified:
head/sys/net/flowtable.c
Modified: head/sys/net/flowtable.c
Martin,
On Tue, Feb 18, 2014 at 10:17:12PM +, Martin Matuska wrote:
M Author: mm
M Date: Tue Feb 18 22:17:12 2014
M New Revision: 262196
M URL: http://svnweb.freebsd.org/changeset/base/262196
M
M Log:
M De-virtualize pf_mtag_z [1]
M Process V_pf_overloadqueue in vnet context [2]
M
M
Martin,
M On Tue, Feb 18, 2014 at 10:17:12PM +, Martin Matuska wrote:
M M Author: mm
M M Date: Tue Feb 18 22:17:12 2014
M M New Revision: 262196
M M URL: http://svnweb.freebsd.org/changeset/base/262196
M M
M M Log:
M M De-virtualize pf_mtag_z [1]
M M Process V_pf_overloadqueue
On Wed, Feb 19, 2014 at 08:49:01PM +0200, Mikolaj Golub wrote:
M -SLIST_HEAD(pf_overload_head, pf_overload_entry);
M +struct pf_overload_head {
M + SLIST_HEAD(, pf_overload_entry) head;
M + struct vnet *vnet;
M +};
M static VNET_DEFINE(struct pf_overload_head,
Author: glebius
Date: Sat Feb 22 19:20:40 2014
New Revision: 262341
URL: http://svnweb.freebsd.org/changeset/base/262341
Log:
Improve logging of send errors, reporting error code and interface.
Reduce code duplication between INET and INET6.
Tested by:Lytochkin Boris lytboris
On Sat, Feb 22, 2014 at 03:28:38PM -0800, Craig Rodrigues wrote:
C Much thanks to you and Nicos for working on pf + VIMAGE.
C I work on FreeNAS at iXsystems, and in FreeNAS we enable
C VIMAGE, because we use jails quiet heavily.
C
C I encouraged Martin to go with his patch, because
C it seemed to
Adrian,
On Mon, Feb 24, 2014 at 02:43:58AM +, Adrian Chadd wrote:
A Log:
A Add a new option - 'a file' - which spits out annotated callgraphs.
A
A '-m file' spits out the given stream into file (eg, /dev/stdout).
A However, it only resolves the first symbol; it doesn't parse the
Author: glebius
Date: Tue Mar 4 19:49:41 2014
New Revision: 262747
URL: http://svnweb.freebsd.org/changeset/base/262747
Log:
Remove ifa_ref()/ifa_free(), which are atomic(9), from ip_output().
The ifaddr is already referenced by the rtentry, and we are holding
reference on the rtentry
Author: glebius
Date: Wed Mar 5 00:40:03 2014
New Revision: 262760
URL: http://svnweb.freebsd.org/changeset/base/262760
Log:
Instead of playing games with casts simply add 3 more members to the
structure pf_rule, that are used when the structure is passed via
ioctl().
PR:
Author: glebius
Date: Wed Mar 5 01:17:47 2014
New Revision: 262763
URL: http://svnweb.freebsd.org/changeset/base/262763
Log:
- Remove rt_metrics_lite and simply put its members into rtentry.
- Use counter(9) for rt_pksent (former rt_rmx.rmx_pksent). This
removes another cache trashing ++
Author: glebius
Date: Wed Mar 5 01:47:08 2014
New Revision: 262767
URL: http://svnweb.freebsd.org/changeset/base/262767
Log:
Hide struct rtentry from userland.
Modified:
head/sys/net/route.h
head/usr.bin/netstat/route.c
Modified: head/sys/net/route.h
Author: glebius
Date: Wed Mar 5 02:35:41 2014
New Revision: 262771
URL: http://svnweb.freebsd.org/changeset/base/262771
Log:
Fix build.
Modified:
head/sys/netatalk/at_proto.c
Modified: head/sys/netatalk/at_proto.c
Author: glebius
Date: Wed Mar 5 02:35:15 2014
New Revision: 262770
URL: http://svnweb.freebsd.org/changeset/base/262770
Log:
Pacify gcc.
Modified:
head/sys/net/flowtable.c
Modified: head/sys/net/flowtable.c
==
---
Author: glebius
Date: Wed Mar 5 19:26:22 2014
New Revision: 262799
URL: http://svnweb.freebsd.org/changeset/base/262799
Log:
Fix compilation for 32-bit machines.
Modified:
head/sbin/pfctl/pfctl.c
Modified: head/sbin/pfctl/pfctl.c
Author: glebius
Date: Wed Mar 5 21:16:46 2014
New Revision: 262806
URL: http://svnweb.freebsd.org/changeset/base/262806
Log:
The route code used to mtx_destroy() a locked mutex before rtentry free. Now,
after r262763 it started to return locked mutexes to UMA. To fix that,
conditionally
On Wed, Mar 05, 2014 at 03:29:55PM -0800, Adrian Chadd wrote:
A ... why's the code returning locked mutexes to UMA?
A
A Why not fix the places that are doing this and doing a lock assertion
A in the destructor? What's this buy us?
A
A I'm very wary of design patterns like this that do
401 - 500 of 2438 matches
Mail list logo
