svn commit: r366687 - head/tools/tools/crypto

2020-10-13 Thread John Baldwin
Author: jhb Date: Tue Oct 13 22:20:03 2020 New Revision: 366687 URL: https://svnweb.freebsd.org/changeset/base/366687 Log: Fix various warnings with higher WARNS. - Rename global 'crid' to 'requested_crid' to avoid shadowing. - Remove some unused function arguments. - Use __DECONST().

Re: svn commit: r366687 - head/tools/tools/crypto

2020-10-13 Thread John Baldwin
On 10/13/20 3:20 PM, John Baldwin wrote: > Author: jhb > Date: Tue Oct 13 22:20:03 2020 > New Revision: 366687 > URL: https://svnweb.freebsd.org/changeset/base/366687 > > Log: > Fix various warnings with higher WARNS. > > - Rename global 'crid' t

Re: svn commit: r366766 - head

2020-10-16 Thread John Baldwin
ly still a bit premature. 'make USE_GCC_TOOLCHAINS=yes tinderbox' still uses gcc6 as I still have several open reviews for gcc9 fixes, though OpenZFS regressed the build for both gcc6 and gcc9 as Adrian is finding. I think I would also just suggest 'pkg install ${TARGET_ARCH}-gcc6

svn commit: r366843 - head/sys/i386/i386

2020-10-19 Thread John Baldwin
Author: jhb Date: Mon Oct 19 17:35:45 2020 New Revision: 366843 URL: https://svnweb.freebsd.org/changeset/base/366843 Log: Properly clear PCB_KERNNPX in fpu_kern_leave(). PR: 250423 Reported by: CI Tested by:lwhsu Modified: head/sys/i386/i386/npx.c Modified: head/sys/

svn commit: r366844 - in head: share/man/man4 sys/opencrypto

2020-10-19 Thread John Baldwin
Author: jhb Date: Mon Oct 19 18:21:41 2020 New Revision: 366844 URL: https://svnweb.freebsd.org/changeset/base/366844 Log: Mark asymmetric cryptography via OCF deprecated for 14.0. Only one MIPS-specific driver implements support for one of the asymmetric operations. There are no in-kern

svn commit: r366845 - head/sys/kern

2020-10-19 Thread John Baldwin
Author: jhb Date: Mon Oct 19 18:24:06 2020 New Revision: 366845 URL: https://svnweb.freebsd.org/changeset/base/366845 Log: Check TF_TOE not the tod pointer to determine if TOE is active. The TF_TOE flag is the check used in the rest of the network stack to determine if TOE is active on a

svn commit: r366852 - head/sys/opencrypto

2020-10-19 Thread John Baldwin
Author: jhb Date: Mon Oct 19 20:04:03 2020 New Revision: 366852 URL: https://svnweb.freebsd.org/changeset/base/366852 Log: Fix a couple of bugs for asym crypto introduced in r359374. - Check for null pointers in the crypto_drivers[] array when checking for empty slots in crypto_select_k

svn commit: r366854 - head/sys/dev/cxgbe/tom

2020-10-19 Thread John Baldwin
Author: jhb Date: Mon Oct 19 20:08:50 2020 New Revision: 366854 URL: https://svnweb.freebsd.org/changeset/base/366854 Log: Re-enable receive flow control for TOE TLS sockets. Flow control was disabled during initial TOE TLS development to workaround a hang (and to match the Linux TOE TLS

svn commit: r366897 - in head/sys: conf dev/md

2020-10-20 Thread John Baldwin
=== --- /dev/null 00:00:00 1970 (empty, because file is newly added) +++ head/sys/dev/md/embedfs.S Tue Oct 20 16:48:45 2020(r366897) @@ -0,0 +1,46 @@ +/*- + * SPDX-License-Identifier: BSD-2-Clause + * + * Copyright (c) 2020 John Ba

svn commit: r366898 - in head: secure/lib/libcrypto secure/lib/libcrypto/aarch64 secure/lib/libcrypto/amd64 secure/lib/libcrypto/arm secure/lib/libcrypto/engines/padlock secure/lib/libcrypto/i386 s...

2020-10-20 Thread John Baldwin
Author: jhb Date: Tue Oct 20 17:00:43 2020 New Revision: 366898 URL: https://svnweb.freebsd.org/changeset/base/366898 Log: Move generated OpenSSL assembly routines into the kernel sources. Sponsored by: Netflix Added: head/sys/crypto/openssl/ head/sys/crypto/openssl/aarch64/ - cop

svn commit: r366901 - in head: share/man/man4 sys/amd64/conf sys/conf sys/crypto/openssl sys/i386/conf sys/modules sys/modules/ossl

2020-10-20 Thread John Baldwin
Author: jhb Date: Tue Oct 20 17:50:18 2020 New Revision: 366901 URL: https://svnweb.freebsd.org/changeset/base/366901 Log: Add a kernel crypto driver using assembly routines from OpenSSL. Currently, this supports SHA1 and SHA2-{224,256,384,512} both as plain hashes and in HMAC mode on bot

svn commit: r366955 - head/sys/dev/cxgbe/tom

2020-10-22 Thread John Baldwin
Author: jhb Date: Fri Oct 23 00:23:54 2020 New Revision: 366955 URL: https://svnweb.freebsd.org/changeset/base/366955 Log: Handle CPL_RX_DATA on active TLS sockets. In certain edge cases, the NIC might have only received a partial TLS record which it needs to return to the driver. For ex

svn commit: r367122 - head/sys/netinet

2020-10-28 Thread John Baldwin
Author: jhb Date: Thu Oct 29 00:03:19 2020 New Revision: 367122 URL: https://svnweb.freebsd.org/changeset/base/367122 Log: Save the current TCP pacing rate in t_pacing_rate. Reviewed by: gallatin, gnn Sponsored by: Netflix Differential Revision:https://reviews.freebsd.org/D2687

svn commit: r367123 - in head: sbin/ifconfig sys/dev/mlx5/mlx5_en sys/kern sys/net sys/netinet sys/sys

2020-10-28 Thread John Baldwin
Author: jhb Date: Thu Oct 29 00:23:16 2020 New Revision: 367123 URL: https://svnweb.freebsd.org/changeset/base/367123 Log: Support hardware rate limiting (pacing) with TLS offload. - Add a new send tag type for a send tag that supports both rate limiting (packet pacing) and TLS offload

Re: svn commit: r367123 - in head: sbin/ifconfig sys/dev/mlx5/mlx5_en sys/kern sys/net sys/netinet sys/sys

2020-10-29 Thread John Baldwin
On 10/28/20 5:23 PM, John Baldwin wrote: > Author: jhb > Date: Thu Oct 29 00:23:16 2020 > New Revision: 367123 > URL: https://svnweb.freebsd.org/changeset/base/367123 > > Log: > Support hardware rate limiting (pacing) with TLS offload. > > ... >

svn commit: r367146 - head/sys/netinet

2020-10-29 Thread John Baldwin
Author: jhb Date: Thu Oct 29 22:14:34 2020 New Revision: 367146 URL: https://svnweb.freebsd.org/changeset/base/367146 Log: Store the new send tag in the right place. r350501 added the 'st' parameter, but did not pass it down to if_snd_tag_alloc(). Reviewed by: gallatin Sponsored b

svn commit: r367147 - head/sys/netinet

2020-10-29 Thread John Baldwin
Author: jhb Date: Thu Oct 29 22:16:59 2020 New Revision: 367147 URL: https://svnweb.freebsd.org/changeset/base/367147 Log: Remove an extra if_ref(). In r348254, if_snd_tag_alloc() routines were changed to bump the ifp refcount via m_snd_tag_init(). This function wasn't in the tree at t

svn commit: r367148 - head/sys/netinet

2020-10-29 Thread John Baldwin
Author: jhb Date: Thu Oct 29 22:18:56 2020 New Revision: 367148 URL: https://svnweb.freebsd.org/changeset/base/367148 Log: Call m_snd_tag_rele() to free send tags. Send tags are refcounted and if_snd_tag_free() is called by m_snd_tag_rele() when the last reference is dropped on a send tag

svn commit: r367149 - head/sys/dev/mlx5/mlx5_en

2020-10-29 Thread John Baldwin
Author: jhb Date: Thu Oct 29 22:22:27 2020 New Revision: 367149 URL: https://svnweb.freebsd.org/changeset/base/367149 Log: Use public interfaces to manage the nested rate limit send tag. Each TLS send tag in mlx5 contains a nested rate limit send tag. Previously, the driver was calling in

svn commit: r367151 - in head/sys: dev/mlx5/mlx5_en kern net netinet sys

2020-10-29 Thread John Baldwin
Author: jhb Date: Thu Oct 29 23:28:39 2020 New Revision: 367151 URL: https://svnweb.freebsd.org/changeset/base/367151 Log: Add m_snd_tag_alloc() as a wrapper around if_snd_tag_alloc(). This gives a more uniform API for send tag life cycle management. Reviewed by: gallatin, hselasky

svn commit: r367153 - head/sys/dev/mlx5/mlx5_en

2020-10-29 Thread John Baldwin
Author: jhb Date: Fri Oct 30 00:06:36 2020 New Revision: 367153 URL: https://svnweb.freebsd.org/changeset/base/367153 Log: Fix a couple of silly bugs in r367149. - Assign the TLS rate limit value to the correct member of the rl_params for the nested rate limit tag. - Remove a dead

Re: svn commit: r367185 - head/tests/sys/opencrypto

2020-10-30 Thread John Baldwin
On 10/30/20 12:53 PM, Jung-uk Kim wrote: > Author: jkim > Date: Fri Oct 30 19:53:16 2020 > New Revision: 367185 > URL: https://svnweb.freebsd.org/changeset/base/367185 > > Log: > Add ossl(4) to cryptotest. Thanks! My bad for missing th

svn commit: r367187 - head/sys/dev/mlx5/mlx5_en

2020-10-30 Thread John Baldwin
Author: jhb Date: Fri Oct 30 21:05:50 2020 New Revision: 367187 URL: https://svnweb.freebsd.org/changeset/base/367187 Log: Remove IF_SND_TAG_TYPE_TLS_RATE_LIMIT conditionals. Support for TLS rate limit tags is now in the tree, so this macro is always defined. Reviewed by: hselasky

svn commit: r367188 - head/sbin/sysctl

2020-10-30 Thread John Baldwin
Author: jhb Date: Fri Oct 30 21:13:05 2020 New Revision: 367188 URL: https://svnweb.freebsd.org/changeset/base/367188 Log: Use a dynamic buffer for the copy of a node's new value. This permits setting a node's value to a string longer than BUFSIZ. Reported by: Sony Arpita Das @ Chelsi

svn commit: r367309 - in head/sys: crypto crypto/chacha20 crypto/des crypto/rijndael crypto/skein opencrypto

2020-11-03 Thread John Baldwin
Author: jhb Date: Tue Nov 3 22:27:54 2020 New Revision: 367309 URL: https://svnweb.freebsd.org/changeset/base/367309 Log: Consistently use C99 fixed-width types in the in-kernel crypto code. Reviewed by: markj Sponsored by: Chelsio Communications Differential Revision:https://

svn commit: r367310 - in head/sys: crypto opencrypto

2020-11-03 Thread John Baldwin
Author: jhb Date: Tue Nov 3 22:32:30 2020 New Revision: 367310 URL: https://svnweb.freebsd.org/changeset/base/367310 Log: Replace some K&R function definitions with ANSI C. Reviewed by: markj Sponsored by: Chelsio Communications Differential Revision:https://reviews.freebsd.or

svn commit: r367311 - head/tools/tools/crypto

2020-11-03 Thread John Baldwin
Author: jhb Date: Tue Nov 3 22:53:23 2020 New Revision: 367311 URL: https://svnweb.freebsd.org/changeset/base/367311 Log: Remove unnecessary __DECONST(). Reviewed by: markj Sponsored by: Chelsio Communications Differential Revision:https://reviews.freebsd.org/D27063 Modified:

svn commit: r367403 - head/sys/opencrypto

2020-11-05 Thread John Baldwin
Author: jhb Date: Thu Nov 5 23:26:02 2020 New Revision: 367403 URL: https://svnweb.freebsd.org/changeset/base/367403 Log: Don't modify the destination pointer in ioctl requests. This breaks the case where the original pointer was NULL but an in-line IV was used. Reviewed by: markj

svn commit: r367404 - head/sys/opencrypto

2020-11-05 Thread John Baldwin
Author: jhb Date: Thu Nov 5 23:28:05 2020 New Revision: 367404 URL: https://svnweb.freebsd.org/changeset/base/367404 Log: Style fixes for function prototypes and definitions. Reviewed by: markj Sponsored by: Chelsio Communications Differential Revision:https://reviews.freebsd.

svn commit: r367406 - head/sys/crypto/aesni

2020-11-05 Thread John Baldwin
Author: jhb Date: Thu Nov 5 23:31:58 2020 New Revision: 367406 URL: https://svnweb.freebsd.org/changeset/base/367406 Log: Check cipher key lengths during probesession. OCF drivers in general should perform as many session parameter checks as possible during probesession rather than when

svn commit: r367407 - head/sys/opencrypto

2020-11-05 Thread John Baldwin
Author: jhb Date: Thu Nov 5 23:42:36 2020 New Revision: 367407 URL: https://svnweb.freebsd.org/changeset/base/367407 Log: Move cryptodev_cb earlier before it is used. This is consistent with cryptodevkey_cb being defined before it is used and removes a prototype in the middle of the file

svn commit: r367409 - head/sys/opencrypto

2020-11-05 Thread John Baldwin
Author: jhb Date: Fri Nov 6 00:10:58 2020 New Revision: 367409 URL: https://svnweb.freebsd.org/changeset/base/367409 Log: Split logic to create new sessions into a separate function. This simplifies cryptof_ioctl as it now a wrapper around functions that contain the bulk of the per-ioctl

svn commit: r367410 - head/sys/opencrypto

2020-11-05 Thread John Baldwin
Author: jhb Date: Fri Nov 6 00:15:52 2020 New Revision: 367410 URL: https://svnweb.freebsd.org/changeset/base/367410 Log: Move cryptof_ioctl() below the routines it calls. Reviewed by: markj Sponsored by: Chelsio Communications Differential Revision:https://reviews.freebsd.org

svn commit: r367425 - head/sys/opencrypto

2020-11-06 Thread John Baldwin
Author: jhb Date: Fri Nov 6 18:05:29 2020 New Revision: 367425 URL: https://svnweb.freebsd.org/changeset/base/367425 Log: Group session management routines together before first use. - Rename cse*() to cse_*() to more closely match other local APIs in this file. - Merge the old cs

svn commit: r367426 - head/sys/opencrypto

2020-11-06 Thread John Baldwin
Author: jhb Date: Fri Nov 6 18:09:52 2020 New Revision: 367426 URL: https://svnweb.freebsd.org/changeset/base/367426 Log: Use void * in place of caddr_t. Reviewed by: markj Sponsored by: Chelsio Communications Differential Revision:https://reviews.freebsd.org/D27065 Modified:

svn commit: r367437 - head/share/man/man4

2020-11-06 Thread John Baldwin
Author: jhb Date: Fri Nov 6 23:37:59 2020 New Revision: 367437 URL: https://svnweb.freebsd.org/changeset/base/367437 Log: Update copies of ioctl structures to match recent changes in head. - Update for C99 types and void pointers. - Update example algorithms to not use removed algorithms

svn commit: r367574 - head/lib/csu/common

2020-11-10 Thread John Baldwin
Author: jhb Date: Tue Nov 10 19:04:54 2020 New Revision: 367574 URL: https://svnweb.freebsd.org/changeset/base/367574 Log: Rename __JCR_LIST__ to __JCR_END__ in crtend.c. This is more consistent with the names used for .ctor and .dtor symbols and better reflects __JCR_END__'s role. R

svn commit: r367575 - head/lib/csu/tests

2020-11-10 Thread John Baldwin
Author: jhb Date: Tue Nov 10 19:07:30 2020 New Revision: 367575 URL: https://svnweb.freebsd.org/changeset/base/367575 Log: Fix dso_handle_check for PIE executables. PIE executables use crtbeginS.o and have a non-NULL dso_handle as a result. Reviewed by: andrew, emaste MFC after:

svn commit: r367576 - in head/lib/csu/tests: . dynamic dynamicpie

2020-11-10 Thread John Baldwin
Author: jhb Date: Tue Nov 10 19:09:35 2020 New Revision: 367576 URL: https://svnweb.freebsd.org/changeset/base/367576 Log: Add C startup code tests for PIE binaries. - Force dynamic to be a non-PIE binary. - Add a dynamicpie test which uses a PIE binary. Reviewed by: andrew Obt

svn commit: r367578 - head/sys/dev/cxgbe/tom

2020-11-10 Thread John Baldwin
Author: jhb Date: Tue Nov 10 19:54:39 2020 New Revision: 367578 URL: https://svnweb.freebsd.org/changeset/base/367578 Log: Clear tp->tod in t4_pcb_detach(). Otherwise, a socket can have a non-NULL tp->tod while TF_TOE is clear. In particular, if a newly accepted socket falls back to non-T

Re: svn commit: r367694 - in head/sys: kern sys

2020-11-17 Thread John Baldwin
(refcount_releasen(&limp->pl_refcnt, n)) > + free((void *)limp, M_PLIMIT); You don't need this cast. -- John Baldwin ___ svn-src-head@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Re: svn commit: r367695 - in head/sys: kern sys

2020-11-17 Thread John Baldwin
han inline (for better or for worse). Better would be: static __inline void credbatch_prep() { ... } static __inline void credbatch_process() { ... } void credbatch_add(); void credbatch_final(); It seems you just have a duplicate credbatch_add() in fact. Also, why have an empty inli

Re: svn commit: r367692 - head/sys/sys

2020-11-17 Thread John Baldwin
that, it mostly forces a rebuild, but that's mostly a side effect, not due to explicit magic around __FreeBSD_version. -- John Baldwin ___ svn-src-head@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, s

Re: svn commit: r367692 - head/sys/sys

2020-11-17 Thread John Baldwin
On 11/17/20 2:37 PM, Warner Losh wrote: > On Tue, Nov 17, 2020 at 3:18 PM John Baldwin wrote: > >> On 11/14/20 2:34 PM, Warner Losh wrote: >>> true, but a version bump forces that and versions are cheap enough... >> >> Strictly speaking, version bumps don&#x

svn commit: r367806 - head/sys/kern

2020-11-18 Thread John Baldwin
Author: jhb Date: Wed Nov 18 16:21:37 2020 New Revision: 367806 URL: https://svnweb.freebsd.org/changeset/base/367806 Log: Fix a few nits in vn_printf(). - Mask out recently added VV_* bits to avoid printing them twice. - Keep VI_LOCKed on the same line as the rest of the flags. R

Re: svn commit: r367695 - in head/sys: kern sys

2020-11-18 Thread John Baldwin
On 11/18/20 2:16 PM, Mateusz Guzik wrote: > On 11/17/20, John Baldwin wrote: >> On 11/14/20 11:22 AM, Mateusz Guzik wrote: > Interested parties can check the consumer (also seen in the diff) to > see this is for consistency. I don't think any comments are warranted > in

Re: svn commit: r367695 - in head/sys: kern sys

2020-11-19 Thread John Baldwin
On 11/18/20 8:52 PM, Mark Johnston wrote: > On Wed, Nov 18, 2020 at 03:37:36PM -0800, John Baldwin wrote: >> On 11/18/20 2:16 PM, Mateusz Guzik wrote: >>> On 11/17/20, John Baldwin wrote: >>>> On 11/14/20 11:22 AM, Mateusz Guzik wrote: >>> Interested parti

Re: svn commit: r367530 - in head/sys/netinet: . tcp_stacks

2020-11-19 Thread John Baldwin
old connection? The language in RFC 7323 3.2 is all about segments on an existing connection, not segments from a new connection I think? That is, I think we should perhaps move this check after the TH_SYN check so that a mismatch doesn't prevent recycling? -- John Baldwin ___ svn-src-head@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Re: svn commit: r367530 - in head/sys/netinet: . tcp_stacks

2020-11-19 Thread John Baldwin
On 11/19/20 2:55 PM, John Baldwin wrote: > On 11/9/20 1:49 PM, Michael Tuexen wrote: >> Author: tuexen >> Date: Mon Nov 9 21:49:40 2020 >> New Revision: 367530 >> URL: https://svnweb.freebsd.org/changeset/base/367530 >> >> Log: >> RFC 7323 specifies

svn commit: r368002 - head

2020-11-24 Thread John Baldwin
Author: jhb Date: Tue Nov 24 22:52:12 2020 New Revision: 368002 URL: https://svnweb.freebsd.org/changeset/base/368002 Log: Correct entries for manpages removed in r359374. Reported by: Yuri Pankov Sponsored by: Chelsio Communications Modified: head/ObsoleteFiles.inc Modified: head/O

svn commit: r368003 - in head: lib/libvmmapi sys/amd64/include sys/amd64/vmm sys/amd64/vmm/io usr.sbin/bhyve

2020-11-24 Thread John Baldwin
Author: jhb Date: Tue Nov 24 23:18:52 2020 New Revision: 368003 URL: https://svnweb.freebsd.org/changeset/base/368003 Log: Honor the disabled setting for MSI-X interrupts for passthrough devices. Add a new ioctl to disable all MSI-X interrupts for a PCI passthrough device and invoke it if

svn commit: r368004 - head/sys/amd64/vmm/io

2020-11-24 Thread John Baldwin
Author: jhb Date: Tue Nov 24 23:56:33 2020 New Revision: 368004 URL: https://svnweb.freebsd.org/changeset/base/368004 Log: Pull the check for VM ownership into ppt_find(). This reduces some code duplication. One behavior change is that ppt_assign_device() will now only succeed if the dev

svn commit: r368005 - in head: lib/libprocstat share/man/man4 sys/opencrypto sys/sys tools/tools/crypto usr.bin/procstat

2020-11-24 Thread John Baldwin
Author: jhb Date: Wed Nov 25 00:10:54 2020 New Revision: 368005 URL: https://svnweb.freebsd.org/changeset/base/368005 Log: Remove the cloned file descriptors for /dev/crypto. Crypto file descriptors were added in the original OCF import as a way to provide per-open data (specifically the

Re: svn commit: r367945 - head

2020-11-24 Thread John Baldwin
it-svn. > > Reported By:jhb > > Modified: > head/.arcconfig In my case I wasn't using git svn, just using arc with git branches from the GH mirror. Thanks for fixing! -- John Baldwin ___ svn-src-head@freebsd.o

Re: svn commit: r368005 - in head: lib/libprocstat share/man/man4 sys/opencrypto sys/sys tools/tools/crypto usr.bin/procstat

2020-11-24 Thread John Baldwin
On 11/24/20 4:10 PM, John Baldwin wrote: > Author: jhb > Date: Wed Nov 25 00:10:54 2020 > New Revision: 368005 > URL: https://svnweb.freebsd.org/changeset/base/368005 > > Log: > Remove the cloned file descriptors for /dev/crypto. > > Crypto file descriptors wer

svn commit: r368007 - head/share/man/man4

2020-11-24 Thread John Baldwin
Author: jhb Date: Wed Nov 25 01:09:58 2020 New Revision: 368007 URL: https://svnweb.freebsd.org/changeset/base/368007 Log: Remove a reference to CRIOGET missed in r368005. Modified: head/share/man/man4/crypto.4 Modified: head/share/man/man4/crypto.4 ==

Re: svn commit: r368005 - in head: lib/libprocstat share/man/man4 sys/opencrypto sys/sys tools/tools/crypto usr.bin/procstat

2020-11-24 Thread John Baldwin
On 11/24/20 4:10 PM, John Baldwin wrote: > Author: jhb > Date: Wed Nov 25 00:10:54 2020 > New Revision: 368005 > URL: https://svnweb.freebsd.org/changeset/base/368005 > > Log: > Remove the cloned file descriptors for /dev/crypto. > > Crypto file descriptors wer

svn commit: r368008 - in head: tests/sys/opencrypto tools/tools/crypto

2020-11-24 Thread John Baldwin
Author: jhb Date: Wed Nov 25 01:31:00 2020 New Revision: 368008 URL: https://svnweb.freebsd.org/changeset/base/368008 Log: Remove uses of CRIOGET in OCF tests after r368005. Pointy hat to:jhb Sponsored by: Chelsio Communications Differential Revision:https://reviews.free

Re: svn commit: r368022 - head/lib/libsysdecode

2020-11-25 Thread John Baldwin
ot &= ~PROT_MAX(protm);'. As it is, if there are any invalid bits set, those are now lost. The change to mask off only the PROT_MAX bits would preserve any invalid/unknown bits. (To test, try passing -1 or the like as a prot value and comparing the decoded output for kdump or truss.) -- Jo

Re: svn commit: r368038 - head/sys/kern

2020-11-25 Thread John Baldwin
> + pipelock(wpipe, 0); > if (error != 0) > break; > + continue; A continue as the last line of a while() loop seems spurious? -- John Baldwin ___ svn-src-head@fr

svn commit: r368040 - head/share/man/man4

2020-11-25 Thread John Baldwin
Author: jhb Date: Wed Nov 25 23:17:23 2020 New Revision: 368040 URL: https://svnweb.freebsd.org/changeset/base/368040 Log: Add a manpage for kernel TLS. This subsumes some of the content from tcp(4) describing the socket options but also adds additional notes. Reviewed by: gallatin,

svn commit: r368117 - head/usr.sbin/bhyve

2020-11-27 Thread John Baldwin
Author: jhb Date: Sat Nov 28 03:54:48 2020 New Revision: 368117 URL: https://svnweb.freebsd.org/changeset/base/368117 Log: bhyve: 'xhci,tablet' snapshot fixes Permit suspend/resume of a XHCI device model that has not been attached to by a driver in a guest OS. Submitted by: Vitaliy G

svn commit: r368118 - head/usr.sbin/bhyve

2020-11-27 Thread John Baldwin
Author: jhb Date: Sat Nov 28 04:06:09 2020 New Revision: 368118 URL: https://svnweb.freebsd.org/changeset/base/368118 Log: bhyve: Add snapshot support for virtio-rnd. This uses the same snapshot routine as other VirtIO devices. Submitted by: Vitaliy Gusev Differential Revision:

svn commit: r368119 - head/usr.sbin/bhyve

2020-11-27 Thread John Baldwin
Author: jhb Date: Sat Nov 28 04:21:22 2020 New Revision: 368119 URL: https://svnweb.freebsd.org/changeset/base/368119 Log: Suspend I/O on ahci-cd devices during a snapshot. Submitted by: Vitaliy Gusev Modified: head/usr.sbin/bhyve/snapshot.c Modified: head/usr.sbin/bhyve/snapshot.c ===

Re: svn commit: r368187 - head/sys/dev/nvme

2020-11-30 Thread John Baldwin
d you known how are compiler guys creative >> with generating of new warnings... >> I known that C++17 have 'maybe_unused' attribute, but relationship to >> standard '__unused' looks unclear. >> >> In any case, I have not single problem to change thi

svn commit: r368240 - in head/sys: cddl/dev/dtrace/amd64 cddl/dev/dtrace/i386 ddb riscv/riscv sys x86/x86

2020-12-01 Thread John Baldwin
Author: jhb Date: Tue Dec 1 17:04:46 2020 New Revision: 368240 URL: https://svnweb.freebsd.org/changeset/base/368240 Log: Add a kstack_contains() helper function. This is useful for stack unwinders which need to avoid out-of-bounds reads of a kernel stack which can trigger kernel faults.

svn commit: r368241 - head/sys/mips/mips

2020-12-01 Thread John Baldwin
Author: jhb Date: Tue Dec 1 17:17:22 2020 New Revision: 368241 URL: https://svnweb.freebsd.org/changeset/base/368241 Log: Make stack_save*() more robust on MIPS. - Validate any stack addresses read from against td_kstack before reading. If an unwind operation would attempt to read out

svn commit: r368242 - head/sys/cddl/dev/dtrace/riscv

2020-12-01 Thread John Baldwin
Author: jhb Date: Tue Dec 1 18:08:22 2020 New Revision: 368242 URL: https://svnweb.freebsd.org/changeset/base/368242 Log: Use uintptr_t for pointers in stack frames. This catches up to the changes made to struct unwind_state in r364180. Reviewed by: mhorne Obtained from:Che

svn commit: r368245 - in head/sys: arm64/arm64 arm64/include cddl/dev/dtrace/aarch64

2020-12-01 Thread John Baldwin
Author: jhb Date: Tue Dec 1 18:22:34 2020 New Revision: 368245 URL: https://svnweb.freebsd.org/changeset/base/368245 Log: Use uintptr_t instead of uint64_t for pointers in stack frames. Reviewed by: andrew Obtained from:CheriBSD Sponsored by: DARPA Differential Revision:

svn commit: r368247 - head/share/man/man4

2020-12-01 Thread John Baldwin
Author: jhb Date: Tue Dec 1 18:57:37 2020 New Revision: 368247 URL: https://svnweb.freebsd.org/changeset/base/368247 Log: Fix a couple of typos. Submitted by: rmacklem Modified: head/share/man/man4/ktls.4 Modified: head/share/man/man4/ktls.4

Re: svn commit: r368263 - head/sys/cddl/dev/dtrace/amd64

2020-12-02 Thread John Baldwin
s (arm64, riscv, mips) in the patch series that had functional changes and fixed those while testing the functional changes. -- John Baldwin ___ svn-src-head@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe,

Re: svn commit: r366857 - head/libexec/rc/rc.d

2020-12-02 Thread John Baldwin
uring shutdown and not all interfaces that would be a happy-enough compromise that would still satisfy the original PR? -- John Baldwin ___ svn-src-head@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

svn commit: r368311 - in head/sys/dev/cxgbe: . tom

2020-12-03 Thread John Baldwin
Author: jhb Date: Thu Dec 3 21:49:20 2020 New Revision: 368311 URL: https://svnweb.freebsd.org/changeset/base/368311 Log: Fix downgrading of TOE TLS sockets to plain TOE. If a TOE TLS socket ends up using an unsupported TLS version or ciphersuite, it must be downgraded to a "plain" TOE s

svn commit: r368312 - head/sys/dev/cxgbe/tom

2020-12-03 Thread John Baldwin
Author: jhb Date: Thu Dec 3 21:59:47 2020 New Revision: 368312 URL: https://svnweb.freebsd.org/changeset/base/368312 Log: Clear TLS offload mode for unsupported cipher suites and versions. If TOE TLS is requested for an unsupported cipher suite or TLS version, disable TLS processing and

svn commit: r368314 - head/sys/dev/cxgbe/tom

2020-12-03 Thread John Baldwin
Author: jhb Date: Thu Dec 3 22:01:13 2020 New Revision: 368314 URL: https://svnweb.freebsd.org/changeset/base/368314 Log: Don't transmit mbufs that aren't yet ready on TOE sockets. This includes mbufs waiting for data from sendfile() I/O requests, or mbufs awaiting encryption for KTLS.

svn commit: r368316 - in head/sys/dev/cxgbe: . tom

2020-12-03 Thread John Baldwin
Author: jhb Date: Thu Dec 3 22:06:08 2020 New Revision: 368316 URL: https://svnweb.freebsd.org/changeset/base/368316 Log: Clear TLS offload mode if a TLS socket hangs without receiving data. By default, if a TOE TLS socket stops receiving data for more than 5 seconds, revert the connecti

svn commit: r368347 - head/sys/mips/mips

2020-12-04 Thread John Baldwin
Author: jhb Date: Fri Dec 4 20:14:25 2020 New Revision: 368347 URL: https://svnweb.freebsd.org/changeset/base/368347 Log: Various fixes for the MIPS DDB stack unwinder. - Fix kernel stack unwinding end-of-function false-positive The kernel stack unwinder assumes that any jr $ra indi

svn commit: r368417 - head/sys/sys

2020-12-07 Thread John Baldwin
Author: jhb Date: Mon Dec 7 18:58:08 2020 New Revision: 368417 URL: https://svnweb.freebsd.org/changeset/base/368417 Log: Bump __FreeBSD_version for removal of crypto fd's in r368005. Requested by: swills Sponsored by: Chelsio Communications Modified: head/sys/sys/param.h Modified: h

Re: svn commit: r368005 - in head: lib/libprocstat share/man/man4 sys/opencrypto sys/sys tools/tools/crypto usr.bin/procstat

2020-12-07 Thread John Baldwin
On 12/6/20 8:51 PM, Steve Wills wrote: > Hi, > > On 11/24/20 7:10 PM, John Baldwin wrote: >> Author: jhb >> Date: Wed Nov 25 00:10:54 2020 >> New Revision: 368005 >> URL: https://svnweb.freebsd.org/changeset/base/368005 >> >> Log: >>

Re: svn commit: r368005 - in head: lib/libprocstat share/man/man4 sys/opencrypto sys/sys tools/tools/crypto usr.bin/procstat

2020-12-07 Thread John Baldwin
On 12/7/20 11:11 AM, Kyle Evans wrote: > On Mon, Dec 7, 2020 at 12:58 PM John Baldwin wrote: >> >> On 12/6/20 8:51 PM, Steve Wills wrote: >>> Hi, >>> >>> On 11/24/20 7:10 PM, John Baldwin wrote: >>>> Author: jhb >>>> Date:

Re: svn commit: r368005 - in head: lib/libprocstat share/man/man4 sys/opencrypto sys/sys tools/tools/crypto usr.bin/procstat

2020-12-07 Thread John Baldwin
On 12/7/20 12:37 PM, Kyle Evans wrote: > On Mon, Dec 7, 2020 at 2:36 PM John Baldwin wrote: >> >> qemu-user uses this flag? What on earth can it be using it for? >> > > It was faithfully responding that it wasn't implemented to any > target-application usage,

svn commit: r368454 - in head/sys: cddl/dev/dtrace/riscv cddl/dev/fbt riscv/include riscv/riscv

2020-12-08 Thread John Baldwin
Author: jhb Date: Tue Dec 8 17:57:18 2020 New Revision: 368454 URL: https://svnweb.freebsd.org/changeset/base/368454 Log: Stack unwinding robustness fixes for RISC-V. - Push the kstack_contains check down into unwind_frame() so that it is honored by DDB and DTrace. - Check that th

svn commit: r368455 - in head/sys: arm64/arm64 arm64/include cddl/dev/dtrace/aarch64 cddl/dev/fbt

2020-12-08 Thread John Baldwin
Author: jhb Date: Tue Dec 8 18:00:58 2020 New Revision: 368455 URL: https://svnweb.freebsd.org/changeset/base/368455 Log: Check that the frame pointer is within the current stack. This same check is used on other architectures. Previously this would permit a stack frame to unwind into a

Re: svn commit: r368667 - in head: . gnu/usr.bin gnu/usr.bin/binutils gnu/usr.bin/gdb tools/build/mk

2020-12-15 Thread John Baldwin
; excessively outdated GDB in FreeBSD 13. > > Sponsored by: The FreeBSD Foundation > Differential Revision: https://reviews.freebsd.org/D27610 Are you going to remove the -gdwarf-2 bits from kern.mk now? (Does ctfconvert support newer DWARF?) -- John Baldwin ___

svn commit: r368685 - head/sys/compat/linuxkpi/common/include/linux

2020-12-15 Thread John Baldwin
Author: jhb Date: Wed Dec 16 00:11:30 2020 New Revision: 368685 URL: https://svnweb.freebsd.org/changeset/base/368685 Log: Use the 't' modifier to print a ptrdiff_t. Reviewed by: imp Obtained from:CheriBSD Sponsored by: DARPA Differential Revision:https://reviews.free

svn commit: r368686 - head/sys/dev/mrsas

2020-12-15 Thread John Baldwin
Author: jhb Date: Wed Dec 16 00:13:32 2020 New Revision: 368686 URL: https://svnweb.freebsd.org/changeset/base/368686 Log: Use uintptr_t instead of unsigned long for pointers. The sense_ptr thing is quite broken. As near as I can tell, the driver tries to copyout to a physical address ra

svn commit: r368687 - head/sys/dev/mxge

2020-12-15 Thread John Baldwin
Author: jhb Date: Wed Dec 16 00:17:54 2020 New Revision: 368687 URL: https://svnweb.freebsd.org/changeset/base/368687 Log: Use uintptr_t instead of unsigned long for integers holding pointers. Reviewed by: imp, gallatin Obtained from:CheriBSD Sponsored by: DARPA Differential

svn commit: r368688 - head/sys/dev/usb

2020-12-15 Thread John Baldwin
Author: jhb Date: Wed Dec 16 00:27:28 2020 New Revision: 368688 URL: https://svnweb.freebsd.org/changeset/base/368688 Log: Use more standard types for manipulating pointers. - Use a uintptr_t cast to get the virtual address of a pointer in USB_P2U() instead of a ptrdiff_t. - Add of

Re: svn commit: r368667 - in head: . gnu/usr.bin gnu/usr.bin/binutils gnu/usr.bin/gdb tools/build/mk

2020-12-16 Thread John Baldwin
On 12/16/20 9:41 AM, Ed Maste wrote: > On Tue, 15 Dec 2020 at 18:25, John Baldwin wrote: >> >> On 12/15/20 9:44 AM, Ed Maste wrote: >>> Author: emaste >>> Date: Tue Dec 15 17:44:19 2020 >>> New Revision: 368667 >>> URL: https://svnweb.freebsd.

svn commit: r368738 - head/sys/compat/linuxkpi/common/include/linux

2020-12-17 Thread John Baldwin
Author: jhb Date: Thu Dec 17 20:28:53 2020 New Revision: 368738 URL: https://svnweb.freebsd.org/changeset/base/368738 Log: Cleanups to *ERR* compat shims. - Use [u]intptr_t casts to convert pointers to integers. - Change IS_ERR* to return bool instead of long. Reviewed by: manu

svn commit: r368739 - in head/sys: conf kern tools

2020-12-17 Thread John Baldwin
--- /dev/null 00:00:00 1970 (empty, because file is newly added) +++ head/sys/kern/firmw.S Thu Dec 17 20:31:17 2020(r368739) @@ -0,0 +1,49 @@ +/*- + * SPDX-License-Identifier: BSD-2-Clause + * + * Copyright (c) 2020 John Baldwin + * + * This softwa

svn commit: r368741 - in head/sys/dev/usb: . controller

2020-12-17 Thread John Baldwin
Author: jhb Date: Thu Dec 17 20:45:10 2020 New Revision: 368741 URL: https://svnweb.freebsd.org/changeset/base/368741 Log: Use __containerof() instead of home-rolled versions. Reviewed by: imp, hselasky Obtained from:CheriBSD Sponsored by: DARPA Differential Revision:

svn commit: r368768 - in head/sys: amd64/amd64 arm64/arm64 i386/i386 riscv/riscv

2020-12-18 Thread John Baldwin
Author: jhb Date: Fri Dec 18 20:41:23 2020 New Revision: 368768 URL: https://svnweb.freebsd.org/changeset/base/368768 Log: Skip the vm.pmap.kernel_maps sysctl by default. This sysctl node can generate very verbose output, so don't trigger it for sysctl -a or sysctl vm.pmap. Reviewed

Re: svn commit: r368789 - head/libexec/rtld-elf/rtld-libc

2020-12-19 Thread John Baldwin
could probably safely link against it directly unlike libc where we have to pick specific object files. -- John Baldwin ___ svn-src-head@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Re: svn commit: r368789 - head/libexec/rtld-elf/rtld-libc

2020-12-21 Thread John Baldwin
On 12/19/20 8:27 PM, Ryan Libby wrote: > On Sat, Dec 19, 2020 at 7:23 PM John Baldwin wrote: >> >> On 12/19/20 12:38 AM, Ryan Libby wrote: >>> Author: rlibby >>> Date: Sat Dec 19 08:38:31 2020 >>> New Revision: 368789 >>> URL: https://s

Re: svn commit: r363263 - in head/lib/csu: . common

2021-02-26 Thread John Baldwin
On 2/26/21 6:02 AM, Kyle Evans wrote: On Thu, Jul 16, 2020 at 4:58 PM John Baldwin wrote: Author: jhb Date: Thu Jul 16 21:58:43 2020 New Revision: 363263 URL: https://svnweb.freebsd.org/changeset/base/363263 Log: Include ABI note tag in shared libraries. Split the ELF feature note

Re: svn commit: r355301 - head/usr.sbin/bhyve

2019-12-03 Thread John Baldwin
#x27;s use a uart, so any changes have to be in usr.sbin/bhyve, not in sys/. However, to do that you have to actually do something more complicated to turn \r\n and \n\r sequences from the guest into plain \n to stdout while still DTRT for "bare" \r and \n characters. You also have to make sure you do the right thing for input and not just output in the device models. I'm not quite a fan of this commit as-is since you will get spurious new lines now if you don't use a serial console. I would perhaps rather have a custom printf() wrapper in bhyve that outputs the \r as needed for debug and error printfs only when stdio has been changed to be raw. I was busy with family stuff and thanksgiving last week so didn't have time to review it before it was committed unfortunately. -- John Baldwin ___ svn-src-head@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

svn commit: r355373 - in head/sys: amd64/amd64 amd64/cloudabi32 amd64/cloudabi64 amd64/ia32 amd64/linux amd64/linux32 arm/arm arm/cloudabi32 arm64/arm64 arm64/cloudabi32 arm64/cloudabi64 arm64/linu...

2019-12-03 Thread John Baldwin
Author: jhb Date: Tue Dec 3 23:17:54 2019 New Revision: 355373 URL: https://svnweb.freebsd.org/changeset/base/355373 Log: Use uintptr_t instead of register_t * for the stack base. - Use ustringp for the location of the argv and environment strings and allow destp to travel further down

svn commit: r355374 - head/sys/sparc64/sparc64

2019-12-03 Thread John Baldwin
Author: jhb Date: Tue Dec 3 23:20:19 2019 New Revision: 355374 URL: https://svnweb.freebsd.org/changeset/base/355374 Log: Pass 0 to __builtin_frame_address() to appease modern GCC. Modern versions of GCC warn about passing non-zero values to __builtin_frame_address(). Passing 1 is a cos

Re: svn commit: r355374 - head/sys/sparc64/sparc64

2019-12-03 Thread John Baldwin
On 12/3/19 3:20 PM, John Baldwin wrote: > Author: jhb > Date: Tue Dec 3 23:20:19 2019 > New Revision: 355374 > URL: https://svnweb.freebsd.org/changeset/base/355374 > > Log: > Pass 0 to __builtin_frame_address() to appease modern GCC. > > Modern versions of GCC

<    2   3   4   5   6   7   8   9   10   11   >