svn commit: r322407 - head/sys/libkern/x86

2017-08-11 Thread Ryan Libby
Author: rlibby Date: Fri Aug 11 17:05:31 2017 New Revision: 322407 URL: https://svnweb.freebsd.org/changeset/base/322407 Log: x86/crc32_sse42.c: quiet unused function warning Reviewed by: cem Approved by: markj (mentor) Sponsored by: Dell EMC Isilon Differential Revision:

svn commit: r322418 - head/lib/msun/src

2017-08-11 Thread Ryan Libby
Author: rlibby Date: Fri Aug 11 22:41:24 2017 New Revision: 322418 URL: https://svnweb.freebsd.org/changeset/base/322418 Log: lib/msun: avoid referring to broken LDBL_MAX LDBL_MAX is broken on i386: https://lists.freebsd.org/pipermail/freebsd-numerics/2012-September/000288.html Gcc

Re: svn commit: r322418 - head/lib/msun/src

2017-08-12 Thread Ryan Libby
On Sat, Aug 12, 2017 at 2:53 PM, Ngie Cooper (yaneurabeya) wrote: [...] > Here are the full gamut of definitions for LDBL_MAX_EXP. It seems > that sparc64 isn’t the only architecture using this pattern: > > $ grep -r DBL_MAX_EXP sys/*/include >

svn commit: r322435 - head/lib/msun/src

2017-08-12 Thread Ryan Libby
Author: rlibby Date: Sat Aug 12 18:28:02 2017 New Revision: 322435 URL: https://svnweb.freebsd.org/changeset/base/322435 Log: Revert r322418, LDBL_MAX_EXP unsuitable for macro pasting on some arches Either need a different way to spell HALF_LDBL_MAX, or a different way to spell

Re: svn commit: r322418 - head/lib/msun/src

2017-08-12 Thread Ryan Libby
On Sat, Aug 12, 2017 at 9:26 AM, Ian Lepore <i...@freebsd.org> wrote: > On Fri, 2017-08-11 at 22:41 +0000, Ryan Libby wrote: >> Author: rlibby >> Date: Fri Aug 11 22:41:24 2017 >> New Revision: 322418 >> URL: https://svnweb.freebsd.org/changeset/base/32241

Re: svn commit: r322418 - head/lib/msun/src

2017-08-12 Thread Ryan Libby
On Sat, Aug 12, 2017 at 9:57 AM, Ryan Libby <rli...@freebsd.org> wrote: > On Sat, Aug 12, 2017 at 9:26 AM, Ian Lepore <i...@freebsd.org> wrote: >> On Fri, 2017-08-11 at 22:41 +, Ryan Libby wrote: >>> Author: rlibby >>> Date: Fri Aug 11 22:41:24 2017

svn commit: r320908 - head/sys/kern

2017-07-12 Thread Ryan Libby
Author: rlibby Date: Wed Jul 12 07:30:14 2017 New Revision: 320908 URL: https://svnweb.freebsd.org/changeset/base/320908 Log: kvprintf %b enhancements Make the %b formatter accept number formatting flags. It will now accept alternate form, precision, and length modifiers. It also now

Re: svn commit: r320908 - head/sys/kern

2017-07-12 Thread Ryan Libby
On Wed, Jul 12, 2017 at 12:43 AM, Roman Divacky wrote: > Clang knows about %b modifier and can do some semantic analysis on it. > Currently it type checks the first arg to be an int and the second to be > a char*. > > Do you think it would be worth modifying the checks to

svn commit: r320977 - head/sys/dev/ixl

2017-07-13 Thread Ryan Libby
Author: rlibby Date: Fri Jul 14 00:10:51 2017 New Revision: 320977 URL: https://svnweb.freebsd.org/changeset/base/320977 Log: ixl: gcc build errors Fix minor -Werror issues when building with gcc from -Wredundant-decls, -Wunused, -Wbool-operations. Also ensure the M_IXL malloc type is

Re: svn commit: r320977 - head/sys/dev/ixl

2017-07-13 Thread Ryan Libby
On Thu, Jul 13, 2017 at 6:17 PM, Ngie Cooper <yaneurab...@gmail.com> wrote: > On Thu, Jul 13, 2017 at 5:10 PM, Ryan Libby <rli...@freebsd.org> wrote: >> Author: rlibby >> Date: Fri Jul 14 00:10:51 2017 >> New Revision: 320977 >> URL: https://s

Re: svn commit: r320908 - head/sys/kern

2017-07-12 Thread Ryan Libby
On Wed, Jul 12, 2017 at 3:20 PM, John Baldwin <j...@freebsd.org> wrote: > On Wednesday, July 12, 2017 01:09:39 AM Ryan Libby wrote: >> On Wed, Jul 12, 2017 at 12:43 AM, Roman Divacky <rdiva...@freebsd.org> wrote: >> > Clang knows about %b modifier and

svn commit: r321106 - in head/sys: dev/qlnx/qlnxe modules/qlnx modules/qlnx/qlnxe

2017-07-18 Thread Ryan Libby
Author: rlibby Date: Tue Jul 18 06:15:05 2017 New Revision: 321106 URL: https://svnweb.freebsd.org/changeset/base/321106 Log: qlnx: gcc build errors Propagate warning flags from kern.opts.mk and then fix minor -Werror issues when building with gcc from -Wredundant-decls,

Re: svn commit: r321284 - in head/sys: amd64/include sys

2017-07-20 Thread Ryan Libby
On Thu, Jul 20, 2017 at 1:01 AM, Bruce Evans <b...@optusnet.com.au> wrote: > On Thu, 20 Jul 2017, Ryan Libby wrote: >> Modified: head/sys/amd64/include/efi.h >> >> == >> --- head/sys/amd6

svn commit: r321284 - in head/sys: amd64/include sys

2017-07-20 Thread Ryan Libby
Author: rlibby Date: Thu Jul 20 06:47:06 2017 New Revision: 321284 URL: https://svnweb.freebsd.org/changeset/base/321284 Log: efi: restrict visibility of EFIABI_ATTR-declared functions In-tree gcc (4.2) doesn't understand __attribute__((ms_abi)) (EFIABI_ATTR). Avoid declaring functions

Re: svn commit: r321284 - in head/sys: amd64/include sys

2017-07-20 Thread Ryan Libby
On Thu, Jul 20, 2017 at 3:33 AM, Konstantin Belousov <kostik...@gmail.com> wrote: > On Thu, Jul 20, 2017 at 02:08:30AM -0700, Ryan Libby wrote: >> On Thu, Jul 20, 2017 at 1:01 AM, Bruce Evans <b...@optusnet.com.au> wrote: [...] >> > This bug is not very common.

svn commit: r321335 - in head/sys: amd64/amd64 x86/x86

2017-07-21 Thread Ryan Libby
Author: rlibby Date: Fri Jul 21 17:11:36 2017 New Revision: 321335 URL: https://svnweb.freebsd.org/changeset/base/321335 Log: __pcpu: gcc -Wredundant-decls Pollution from counter.h made __pcpu visible in amd64/pmap.c. Delete the existing extern decl of __pcpu in amd64/pmap.c and avoid

svn commit: r321376 - head/sys/compat/linuxkpi/common/include/linux

2017-07-22 Thread Ryan Libby
Author: rlibby Date: Sat Jul 22 21:29:44 2017 New Revision: 321376 URL: https://svnweb.freebsd.org/changeset/base/321376 Log: linuxkpi compiler.h: avoid gcc -Wunused-value in dummy expressions It looks like the __acquire and __release macros are for the consumption of static analysis

svn commit: r320513 - head/sys/dev/mpt

2017-06-30 Thread Ryan Libby
Author: rlibby Date: Fri Jun 30 22:06:24 2017 New Revision: 320513 URL: https://svnweb.freebsd.org/changeset/base/320513 Log: mpt.h: macro parenthesization Build with gcc -Wint-in-bool-context revealed a macro parenthesization error (invoking mpt_lprt with a ternary expression for

svn commit: r320511 - head/sys/geom/virstor

2017-06-30 Thread Ryan Libby
Author: rlibby Date: Fri Jun 30 22:01:18 2017 New Revision: 320511 URL: https://svnweb.freebsd.org/changeset/base/320511 Log: g_virstor.h: macro parenthesization Build with gcc -Wint-in-bool-context revealed a macro parenthesization error (invoking LOG_MSG with a ternary expression for

svn commit: r320517 - head/sys/dev/xen/netfront

2017-06-30 Thread Ryan Libby
Author: rlibby Date: Fri Jun 30 22:14:22 2017 New Revision: 320517 URL: https://svnweb.freebsd.org/changeset/base/320517 Log: netfront.c: avoid gcc variably-modified warning gcc produces a "variably modified X at file scope" warning for structures that use these size definitions. I

svn commit: r320714 - head/sys/dev/hptmv

2017-07-06 Thread Ryan Libby
Author: rlibby Date: Thu Jul 6 05:32:22 2017 New Revision: 320714 URL: https://svnweb.freebsd.org/changeset/base/320714 Log: hptmv: avoid gcc variably-modified warning gcc produces a "variably modified X at file scope" warning for structures that use these size definitions. PR:

svn commit: r320764 - head/sys/amd64/vmm/amd

2017-07-07 Thread Ryan Libby
Author: rlibby Date: Fri Jul 7 06:37:19 2017 New Revision: 320764 URL: https://svnweb.freebsd.org/changeset/base/320764 Log: amd-vi: gcc build errors amdvi_cmp_wait: gcc complained about a malformed string behind an ifdef. struct amdvi_dte: widen the type of the first reserved

svn commit: r321668 - head/usr.sbin/bhyve

2017-07-28 Thread Ryan Libby
Author: rlibby Date: Fri Jul 28 21:42:59 2017 New Revision: 321668 URL: https://svnweb.freebsd.org/changeset/base/321668 Log: bhyve/pci_e82545.c: squelch gcc warning for noreturn procedure Gcc complained that e82545_tx_thread has a return type declared but doesn't return anything.

svn commit: r321669 - head/usr.sbin/bhyve

2017-07-28 Thread Ryan Libby
Author: rlibby Date: Fri Jul 28 21:47:10 2017 New Revision: 321669 URL: https://svnweb.freebsd.org/changeset/base/321669 Log: bhyve/vga.c: fix atc_color_select_67 bit shift Gcc noticed that the result of the bit shift is always zero. Shift so that the ATC_CS_C67 bits end up in bits 6 &

svn commit: r322329 - head/sys/boot/i386/boot2

2017-08-09 Thread Ryan Libby
Author: rlibby Date: Wed Aug 9 20:13:49 2017 New Revision: 322329 URL: https://svnweb.freebsd.org/changeset/base/322329 Log: i386/boot2: -fno-asynchronous-unwind-tables for gcc The amd64 build of boot2 was failing with gcc 6.3.0 due to being more than 1 kB too large. It was apparently

svn commit: r322332 - in head: contrib/jemalloc/include/jemalloc/internal contrib/jemalloc/src lib/libc/stdlib/jemalloc

2017-08-09 Thread Ryan Libby
Author: rlibby Date: Wed Aug 9 22:58:42 2017 New Revision: 322332 URL: https://svnweb.freebsd.org/changeset/base/322332 Log: Pick 'Remove external linkage for spin_adaptive' from upstream jemalloc Apply the changes from upstream jemalloc 048c6679. This is actually not quite a cherry

svn commit: r322335 - head/usr.bin/calendar/calendars

2017-08-09 Thread Ryan Libby
1987 06/06 Sergei Kolobov <ser...@freebsd.org> born in Karpinsk, Russian Federation, 1972 +06/06 Ryan Libby <rli...@freebsd.org> born in Kirkland, Washington, United States, 1985 06/06 Alan Eldridge <al...@freebsd.org> died in Denver, Colorado, 2003 06/07 Jimmy Olgeni <o

svn commit: r322600 - head/sys/crypto/aesni

2017-08-16 Thread Ryan Libby
Author: rlibby Date: Wed Aug 16 22:54:35 2017 New Revision: 322600 URL: https://svnweb.freebsd.org/changeset/base/322600 Log: aesni: quiet -Wcast-qual Reviewed by: delphij Approved by: markj (mentor) Sponsored by: Dell EMC Isilon Differential Revision:

svn commit: r322650 - head/sys/dev/safe

2017-08-18 Thread Ryan Libby
Author: rlibby Date: Fri Aug 18 08:05:33 2017 New Revision: 322650 URL: https://svnweb.freebsd.org/changeset/base/322650 Log: safe: quiet -Wtautological-compare Code was testing that an unsigned type was >= 0. Reviewed by: markj Approved by: markj (mentor) Sponsored by: Dell EMC

svn commit: r319967 - head/sys/kern

2017-06-14 Thread Ryan Libby
Author: rlibby Date: Thu Jun 15 04:49:12 2017 New Revision: 319967 URL: https://svnweb.freebsd.org/changeset/base/319967 Log: ddb show socket debugging Display the mbuf/cluster count for a sockbuf and fix a couple whitespace issues in the output. Reviewed by: jhb, markj (both

svn commit: r319923 - head/share/misc

2017-06-13 Thread Ryan Libby
Kurakin\n...@freebsd.org\n2003/12/18"] +rlibby [label="Ryan Libby\nrli...@freebsd.org\n2017/06/07"] rmacklem [label="Rick Macklem\nrmack...@freebsd.org\n2009/03/27"] rmh [label="Robert Millan\n...@freebsd.org\n2011/09/18"] rnoland [label="Rober

svn commit: r319938 - head/sys/kern

2017-06-14 Thread Ryan Libby
Author: rlibby Date: Wed Jun 14 07:46:52 2017 New Revision: 319938 URL: https://svnweb.freebsd.org/changeset/base/319938 Log: ddb show files: fix up file types and whitespace This makes ddb show files more descriptive and also adjusts the whitespace to align the columns for non-32-bit

Re: svn commit: r323692 - in head/sys/compat: linsysfs linux

2017-09-18 Thread Ryan Libby
On Sun, Sep 17, 2017 at 4:40 PM, Conrad Meyer wrote: > Author: cem > Date: Sun Sep 17 23:40:16 2017 > New Revision: 323692 > URL: https://svnweb.freebsd.org/changeset/base/323692 > > Log: > linsysfs(5): Add support for recent libdrm > > Expose more information about PCI

svn commit: r323714 - head/sys/compat/linsysfs

2017-09-18 Thread Ryan Libby
Author: rlibby Date: Mon Sep 18 19:09:40 2017 New Revision: 323714 URL: https://svnweb.freebsd.org/changeset/base/323714 Log: linsysfs: quiet gcc -Wformat after r323692 Reviewed by: cem Sponsored by: Dell EMC Isilon Modified: head/sys/compat/linsysfs/linsysfs.c Modified:

svn commit: r323573 - head/share/mk

2017-09-13 Thread Ryan Libby
Author: rlibby Date: Thu Sep 14 03:41:49 2017 New Revision: 323573 URL: https://svnweb.freebsd.org/changeset/base/323573 Log: gcc builds: reenable -Wstrict-overflow for bsd.sys.mk This effectively reverts r304877, after having relegated the warning suppression to the zic(8) makefile in

svn commit: r323572 - head/usr.sbin/zic/zic

2017-09-13 Thread Ryan Libby
Author: rlibby Date: Thu Sep 14 03:39:42 2017 New Revision: 323572 URL: https://svnweb.freebsd.org/changeset/base/323572 Log: zic: -Wno-error=strict-overflow Reviewed by: emaste Sponsored by: Dell EMC Isilon X-Differential Revision: https://reviews.freebsd.org/D12284 Modified:

svn commit: r323574 - head/sys/conf

2017-09-13 Thread Ryan Libby
Author: rlibby Date: Thu Sep 14 03:42:41 2017 New Revision: 323574 URL: https://svnweb.freebsd.org/changeset/base/323574 Log: gcc builds: reenable -Wstrict-overflow for kern.mk Reviewed by: emaste Sponsored by: Dell EMC Isilon Differential Revision:

svn commit: r324621 - head/sys/dev/mlx4/mlx4_en

2017-10-14 Thread Ryan Libby
Author: rlibby Date: Sat Oct 14 23:25:44 2017 New Revision: 324621 URL: https://svnweb.freebsd.org/changeset/base/324621 Log: mlx4: use enum constants instead of const vars for case exprs Follow up from r324201 to fix compilation with gcc, which complains about non-ICE case expressions.

svn commit: r324680 - head/sys/gdb

2017-10-16 Thread Ryan Libby
Author: rlibby Date: Tue Oct 17 01:12:17 2017 New Revision: 324680 URL: https://svnweb.freebsd.org/changeset/base/324680 Log: gdb kernel server: fixup Search:memory style This is a NFC patch to move around the Search:memory implementation so that it doesn't exceed the standard column

svn commit: r323004 - head/lib/msun/tests

2017-08-29 Thread Ryan Libby
Author: rlibby Date: Tue Aug 29 22:37:24 2017 New Revision: 323004 URL: https://svnweb.freebsd.org/changeset/base/323004 Log: lib/msun: add more csqrt unit tests for precision and overflow Reviewed by: bde Approved by: markj (mentor) Sponsored by: Dell EMC Isilon Modified:

svn commit: r323003 - head/lib/msun/src

2017-08-29 Thread Ryan Libby
Author: rlibby Date: Tue Aug 29 22:32:29 2017 New Revision: 323003 URL: https://svnweb.freebsd.org/changeset/base/323003 Log: lib/msun: avoid referring to broken LDBL_MAX LDBL_MAX is broken on i386: https://lists.freebsd.org/pipermail/freebsd-numerics/2012-September/000288.html Gcc

Re: svn commit: r323393 - in head/sys: sys vm

2017-09-11 Thread Ryan Libby
On Mon, Sep 11, 2017 at 12:30 AM, Mateusz Guzik wrote: [...] > That said, looking now at the struct I think its use should be retired > from the kernel. It can remain in headers for userspace use. > > First, there is a bunch of counter(9) fields. I don't know the original >

svn commit: r323200 - head

2017-09-05 Thread Ryan Libby
Author: rlibby Date: Wed Sep 6 01:55:40 2017 New Revision: 323200 URL: https://svnweb.freebsd.org/changeset/base/323200 Log: Makefile.inc1: bump elf tool chain version check after PR 215350 fix This causes builds to use the in-tree libdwarf with the bug fix instead of the host library.

svn commit: r323276 - head/usr.sbin/crunch/crunchgen

2017-09-07 Thread Ryan Libby
Author: rlibby Date: Thu Sep 7 17:20:47 2017 New Revision: 323276 URL: https://svnweb.freebsd.org/changeset/base/323276 Log: crunchgen: quiet -Wmissing-prototypes Reviewed by: emaste (previous version) Sponsored by: Dell EMC Isilon Differential Revision:

Re: svn commit: r323516 - in head/sys: dev/bnxt dev/e1000 kern net sys

2017-09-12 Thread Ryan Libby
On Tue, Sep 12, 2017 at 6:18 PM, Stephen Hurd wrote: > Author: shurd > Date: Wed Sep 13 01:18:42 2017 > New Revision: 323516 > URL: https://svnweb.freebsd.org/changeset/base/323516 > > Log: > Roll up iflib commits from github. This pulls in most of the work done > by Matt

svn commit: r323192 - head/contrib/binutils/opcodes

2017-09-05 Thread Ryan Libby
Author: rlibby Date: Tue Sep 5 19:04:07 2017 New Revision: 323192 URL: https://svnweb.freebsd.org/changeset/base/323192 Log: gnu binutils: FSGSBASE assembly/disassembly Enable the in-tree binutils to assemble and disassemble amd64 FSGSBASE instructions (rdfsbase, rdgsbase, wrfsbase,

svn commit: r322940 - head/sys/amd64/amd64

2017-08-26 Thread Ryan Libby
Author: rlibby Date: Sat Aug 26 23:13:18 2017 New Revision: 322940 URL: https://svnweb.freebsd.org/changeset/base/322940 Log: amd64: drop q suffix from rd[fg]sbase for gas compatibility Reviewed by: kib Approved by: markj (mentor) Sponsored by: Dell EMC Isilon Differential

Re: svn commit: r322969 - in head: sbin/mdconfig sys/dev/md sys/sys

2017-08-28 Thread Ryan Libby
On Mon, Aug 28, 2017 at 11:24 AM, Maxim Sobolev wrote: > Hi John, > > Thanks for your feedback! To address the points that you've raised: > > 1. I've tested on both 32 and 64 bit platforms, it seems not to be the > case. See imp's comment and my reply here >

Re: svn commit: r322824 - in head: lib/clang share/mk usr.bin/clang

2017-08-25 Thread Ryan Libby
On Wed, Aug 23, 2017 at 4:30 PM, John Baldwin wrote: > Author: jhb > Date: Wed Aug 23 23:30:25 2017 > New Revision: 322824 > URL: https://svnweb.freebsd.org/changeset/base/322824 > > Log: > Improve the coverage of debug symbols for MK_DEBUG_FILES. > > - Include debug symbols

svn commit: r323155 - head/lib/libefivar

2017-09-04 Thread Ryan Libby
Author: rlibby Date: Mon Sep 4 18:59:44 2017 New Revision: 323155 URL: https://svnweb.freebsd.org/changeset/base/323155 Log: libefivar: -fno-strict-aliasing Avoid dealing with some code that uses type-punned pointers. See D12210 and D12211 for more background. Reviewed by: imp

Re: svn commit: r323008 - in head/sys: dev/e1000 net

2017-08-29 Thread Ryan Libby
On Tue, Aug 29, 2017 at 5:20 PM, Sean Bruno wrote: > Author: sbruno > Date: Wed Aug 30 00:20:43 2017 > New Revision: 323008 > URL: https://svnweb.freebsd.org/changeset/base/323008 > > Log: > Continuation of lock cleanup in e1000. > > Post-cold sleep instead of DELAY when

Re: svn commit: r324713 - head/sys/fs/ext2fs

2017-10-18 Thread Ryan Libby
On Tue, Oct 17, 2017 at 11:21 PM, Fedor Uporov wrote: > Ryan, > > Seems like, I lost the dual declaration when made the merging and then did > not check the gcc build. > > Thanks for fix. > No problem. Welcome aboard.

svn commit: r324705 - head/sys/dev/cxgbe/tom

2017-10-17 Thread Ryan Libby
Author: rlibby Date: Tue Oct 17 20:37:31 2017 New Revision: 324705 URL: https://svnweb.freebsd.org/changeset/base/324705 Log: cxgbe: delete now-redundant vnet decls r324539 gathered some vnet decls into netinet/tcp_var.h, so that they are now redundant in

svn commit: r324713 - head/sys/fs/ext2fs

2017-10-17 Thread Ryan Libby
Author: rlibby Date: Wed Oct 18 00:41:23 2017 New Revision: 324713 URL: https://svnweb.freebsd.org/changeset/base/324713 Log: ext2: delete redundant decl of ext2_fserr Fix gcc build after r324706. Reviewed by: pfg Differential Revision:https://reviews.freebsd.org/D12709

svn commit: r324728 - in head/sys/dev: qlnx/qlnxe qlxgb qlxgbe qlxge

2017-10-18 Thread Ryan Libby
Author: rlibby Date: Wed Oct 18 19:28:28 2017 New Revision: 324728 URL: https://svnweb.freebsd.org/changeset/base/324728 Log: ql*_def.h: fix QL_ALIGN parenthesization QL_ALIGN is a set of copies of roundup2, but it was missing an outer set of parentheses, which began to matter with

svn commit: r324811 - in head/sys/dev/pms/freebsd/driver: common ini/src

2017-10-21 Thread Ryan Libby
Author: rlibby Date: Sat Oct 21 07:23:45 2017 New Revision: 324811 URL: https://svnweb.freebsd.org/changeset/base/324811 Log: pms/freebsd: fix compiler warnings - A number of unused variable warnings, - a missing prototype warning (actually a dead function), - and a potential use of

Re: svn commit: r324811 - in head/sys/dev/pms/freebsd/driver: common ini/src

2017-10-21 Thread Ryan Libby
On Sat, Oct 21, 2017 at 12:43 AM, Ngie Cooper (yaneurabeya) <yaneurab...@gmail.com> wrote: > >> On Oct 21, 2017, at 00:23, Ryan Libby <rli...@freebsd.org> wrote: >> >> Author: rlibby >> Date: Sat Oct 21 07:23:45 2017 >> New Revision: 324811 >> UR

Re: svn commit: r334708 - head/sys/kern

2018-06-08 Thread Ryan Libby
On Thu, Jun 7, 2018 at 10:03 PM, Mateusz Guzik wrote: > On Fri, Jun 8, 2018 at 6:29 AM, Ryan Libby wrote: >> >> On Thu, Jun 7, 2018 at 8:32 PM, Mark Johnston wrote: >> > On Wed, Jun 06, 2018 at 05:03:11PM +0300, Konstantin Belousov wrote: >> >> On Wed, Jun

svn commit: r335076 - head/sys/i386/i386

2018-06-13 Thread Ryan Libby
Author: rlibby Date: Wed Jun 13 19:57:03 2018 New Revision: 335076 URL: https://svnweb.freebsd.org/changeset/base/335076 Log: i386: copyin/copyout error is EFAULT Discussed with: kib MFC with: r332489 Sponsored by: Dell EMC Isilon Modified: head/sys/i386/i386/copyout.c

Re: svn commit: r335094 - head/sys/ofed/drivers/infiniband/core

2018-06-13 Thread Ryan Libby
On Wed, Jun 13, 2018 at 4:30 PM, Matt Macy wrote: > Author: mmacy > Date: Wed Jun 13 23:30:54 2018 > New Revision: 335094 > URL: https://svnweb.freebsd.org/changeset/base/335094 > > Log: > fix OFED build after r335053 > > Modified: > head/sys/ofed/drivers/infiniband/core/ib_user_mad.c > >

svn commit: r334957 - in head: lib/libpmc usr.sbin/pmc

2018-06-11 Thread Ryan Libby
Author: rlibby Date: Mon Jun 11 16:09:54 2018 New Revision: 334957 URL: https://svnweb.freebsd.org/changeset/base/334957 Log: pmc gcc fixups Fix the build of lib/libpmc and usr.sbin/pmc for gcc on amd64. Reviewed by:mmacy Sponsored by: Dell EMC Isilon Differential Revision:

Re: svn commit: r334708 - head/sys/kern

2018-06-07 Thread Ryan Libby
On Thu, Jun 7, 2018 at 8:32 PM, Mark Johnston wrote: > On Wed, Jun 06, 2018 at 05:03:11PM +0300, Konstantin Belousov wrote: >> On Wed, Jun 06, 2018 at 12:57:12PM +, Justin Hibbits wrote: >> > Author: jhibbits >> > Date: Wed Jun 6 12:57:11 2018 >> > New Revision: 334708 >> > URL:

Re: head -r335782 (?) broke ci.freebsd.org's FreeBSD-head-amd64-gcc build (lib32 part of build)

2018-06-29 Thread Ryan Libby
On Fri, Jun 29, 2018 at 1:26 PM, John Baldwin wrote: > On 6/28/18 7:54 PM, Mark Millard wrote: >> On 2018-Jun-28, at 6:04 PM, Mark Millard wrote: >> >>> On 2018-Jun-28, at 5:39 PM, Mark Millard wrote: >>> [ ci.free.bsd.org jumped from -r335773 (built) to -r335784 (failed) for

Re: head -r335782 (?) broke ci.freebsd.org's FreeBSD-head-amd64-gcc build (lib32 part of build)

2018-06-29 Thread Ryan Libby
[Re-sending from my subscription address, sorry for the spam] On Fri, Jun 29, 2018 at 1:26 PM, John Baldwin wrote: > On 6/28/18 7:54 PM, Mark Millard wrote: >> On 2018-Jun-28, at 6:04 PM, Mark Millard wrote: >> >>> On 2018-Jun-28, at 5:39 PM, Mark Millard wrote: >>> [ ci.free.bsd.org

svn commit: r347628 - in head/sys: amd64/amd64 i386/i386

2019-05-15 Thread Ryan Libby
Author: rlibby Date: Wed May 15 18:13:43 2019 New Revision: 347628 URL: https://svnweb.freebsd.org/changeset/base/347628 Log: x86: spell vpxor %zmm0 as vpxord Fix gcc/gas amd64 & i386 build after r347566. Reviewed by: kib Sponsored by: Dell EMC Isilon Differential Revision:

svn commit: r347645 - head/sys/x86/iommu

2019-05-15 Thread Ryan Libby
Author: rlibby Date: Thu May 16 04:24:08 2019 New Revision: 347645 URL: https://svnweb.freebsd.org/changeset/base/347645 Log: iommu static analysis cleanup A static analyzer complained about a couple instances of checking a variable against NULL after already having dereferenced it. -

svn commit: r347646 - head/sys/ddb

2019-05-15 Thread Ryan Libby
Author: rlibby Date: Thu May 16 05:29:54 2019 New Revision: 347646 URL: https://svnweb.freebsd.org/changeset/base/347646 Log: db show thread: avoid overflow in tick conversion The previous calculations for displaying the time since last switch easily overflowed, after less than 36 min

svn commit: r348770 - in head: share/man/man9 sys/sys

2019-06-06 Thread Ryan Libby
Author: rlibby Date: Fri Jun 7 04:09:12 2019 New Revision: 348770 URL: https://svnweb.freebsd.org/changeset/base/348770 Log: Allow fail points to have separate declarations, definitions, and evals Submitted by: Matthew Bryan Reviewed by: cem Sponsored by: Dell EMC Isilon

svn commit: r349373 - head/sys/netipsec

2019-06-25 Thread Ryan Libby
Author: rlibby Date: Tue Jun 25 15:43:52 2019 New Revision: 349373 URL: https://svnweb.freebsd.org/changeset/base/349373 Log: netipsec key_register: check for M_NOWAIT alloc failure Reviewed by: ae, cem Sponsored by: Dell EMC Isilon Differential Revision:

svn commit: r349288 - head/sys/ddb

2019-06-21 Thread Ryan Libby
Author: rlibby Date: Sat Jun 22 05:35:23 2019 New Revision: 349288 URL: https://svnweb.freebsd.org/changeset/base/349288 Log: ddb show proc typo Modified: head/sys/ddb/db_ps.c Modified: head/sys/ddb/db_ps.c == ---

svn commit: r355396 - head/sys/kern

2019-12-04 Thread Ryan Libby
Author: rlibby Date: Wed Dec 4 18:21:29 2019 New Revision: 355396 URL: https://svnweb.freebsd.org/changeset/base/355396 Log: mbuf zones: take out the trash The mbuf zones were explicitly specifying the uma trash procedures on zcreate, conditionally on INVARIANTS, because that used to be

svn commit: r355400 - head/sys/sys

2019-12-04 Thread Ryan Libby
Author: rlibby Date: Wed Dec 4 20:15:17 2019 New Revision: 355400 URL: https://svnweb.freebsd.org/changeset/base/355400 Log: bistring: avoid gcc -Wsign-compare Appease gcc after after r355377, which broke gcc builds. Reviewed by: dougm MFC with: r355377 Differential

svn commit: r355343 - head/sys/mips/mips

2019-12-03 Thread Ryan Libby
Author: rlibby Date: Tue Dec 3 17:43:52 2019 New Revision: 355343 URL: https://svnweb.freebsd.org/changeset/base/355343 Log: mips busdma: bzero map on alloc Maps from the mips busdma dmamap_zone were not completely initialized. In particular, pagesneeded and pagesreserved were not

svn commit: r355344 - head/sys/sys

2019-12-03 Thread Ryan Libby
Author: rlibby Date: Tue Dec 3 17:43:57 2019 New Revision: 355344 URL: https://svnweb.freebsd.org/changeset/base/355344 Log: bitset: avoid pessimized code when bitset size is not constant We have a couple optimizations for when the bitset is known to be just one word. But with

svn commit: r355605 - head/sys/vm

2019-12-10 Thread Ryan Libby
Author: rlibby Date: Wed Dec 11 06:50:55 2019 New Revision: 355605 URL: https://svnweb.freebsd.org/changeset/base/355605 Log: uma: pretty print zone flags sysctl Requested by: jeff Reviewed by: jeff, markj Sponsored by: Dell EMC Isilon Differential Revision:

svn commit: r355709 - in head: share/man/man9 sys/i386/i386 sys/kern sys/sparc64/sparc64 sys/sys sys/x86/x86

2019-12-13 Thread Ryan Libby
Author: rlibby Date: Fri Dec 13 09:32:16 2019 New Revision: 355709 URL: https://svnweb.freebsd.org/changeset/base/355709 Log: bitset: rename confusing macro NAND to ANDNOT s/BIT_NAND/BIT_ANDNOT/, and for CPU and DOMAINSET too. The actual implementation is "and not" (or "but not"), i.e.

svn commit: r355706 - head/sys/vm

2019-12-13 Thread Ryan Libby
Author: rlibby Date: Fri Dec 13 09:31:59 2019 New Revision: 355706 URL: https://svnweb.freebsd.org/changeset/base/355706 Log: uma dbg: flexible size for slab debug bitset too Recently (r355315) the size of the struct uma_slab bitset field us_free became dynamic instead of conservative.

svn commit: r355708 - head/sys/vm

2019-12-13 Thread Ryan Libby
Author: rlibby Date: Fri Dec 13 09:32:09 2019 New Revision: 355708 URL: https://svnweb.freebsd.org/changeset/base/355708 Log: uma: report slab efficiency Reviewed by: jeff Sponsored by: Dell EMC Isilon Differential Revision:https://reviews.freebsd.org/D22766 Modified:

svn commit: r355707 - head/sys/vm

2019-12-13 Thread Ryan Libby
Author: rlibby Date: Fri Dec 13 09:32:03 2019 New Revision: 355707 URL: https://svnweb.freebsd.org/changeset/base/355707 Log: uma: delay bucket_init() until we might actually enable buckets This helps with a bootstrapping problem in upcoming work. We don't first enable buckets until

svn commit: r355710 - head/lib/libmemstat

2019-12-13 Thread Ryan Libby
Author: rlibby Date: Fri Dec 13 10:34:19 2019 New Revision: 355710 URL: https://svnweb.freebsd.org/changeset/base/355710 Log: libmemstat: unbreak build r355706 added an instance of offsetof() to the UMA private kernel header file uma_int.h. Userspace memstat_uma.c includes that header,

svn commit: r355711 - in head: lib/libmemstat sys/vm

2019-12-13 Thread Ryan Libby
Author: rlibby Date: Fri Dec 13 11:21:28 2019 New Revision: 355711 URL: https://svnweb.freebsd.org/changeset/base/355711 Log: Revert r355706 & r355710 The quick fix didn't work. I'll sort it out tomorrow. Revert r355710: "libmemstat: unbreak build" Revert r355706: "uma dbg:

svn commit: r355746 - head/sys/vm

2019-12-13 Thread Ryan Libby
Author: rlibby Date: Sat Dec 14 05:21:56 2019 New Revision: 355746 URL: https://svnweb.freebsd.org/changeset/base/355746 Log: uma dbg: flexible size for slab debug bitset too Recently (r355315) the size of the struct uma_slab bitset field us_free became dynamic instead of conservative.

Re: svn commit: r355137 - head/sys/vm

2019-12-03 Thread Ryan Libby
On Tue, Dec 3, 2019 at 12:43 PM Gleb Smirnoff wrote: > > Ryan, > > On Wed, Nov 27, 2019 at 07:49:56PM +, Ryan Libby wrote: > R> Author: rlibby > R> Date: Wed Nov 27 19:49:55 2019 > R> New Revision: 355137 > R> URL: https://svnweb.freebsd.org/changeset/b

Re: svn commit: r355137 - head/sys/vm

2019-12-03 Thread Ryan Libby
On Tue, Dec 3, 2019 at 1:12 PM Ian Lepore wrote: > > On Tue, 2019-12-03 at 12:59 -0800, Ryan Libby wrote: > > > +* XXX UMA_ZONE_OFFPAGE. > > All over freebsd we have cryptic XXX comments that have no meaning to > anyone except whoever wrote them (and, I susp

Re: svn commit: r355784 - in head/sys: compat/linuxkpi/common/src dev/dpaa kern mips/nlm sys

2019-12-16 Thread Ryan Libby
On Mon, Dec 16, 2019 at 7:30 AM Ed Maste wrote: > > On Sun, 15 Dec 2019 at 16:27, Jeff Roberson wrote: > > > > Author: jeff > > Date: Sun Dec 15 21:26:50 2019 > > New Revision: 355784 > > URL: https://svnweb.freebsd.org/changeset/base/355784 > > > > Log: > > schedlock 4/4 > > FYI i386, arm,

Re: svn commit: r355747 - in head: . include lib/libc/stdlib lib/libxo

2019-12-14 Thread Ryan Libby
On Sat, Dec 14, 2019 at 12:28 AM Conrad Meyer wrote: > > Author: cem > Date: Sat Dec 14 08:28:10 2019 > New Revision: 355747 > URL: https://svnweb.freebsd.org/changeset/base/355747 > > Log: > Deprecate sranddev(3) API > > It serves no useful purpose and wasn't as popular as its equally

svn commit: r355083 - head/sys/kern

2019-11-24 Thread Ryan Libby
Author: rlibby Date: Mon Nov 25 07:38:27 2019 New Revision: 355083 URL: https://svnweb.freebsd.org/changeset/base/355083 Log: sysctl sysctls: wire old buf before output with sysctl lock Several sysctl sysctls output to a user buffer while holding a non-sleepable lock that protects the

svn commit: r355084 - head/sys/vm

2019-11-24 Thread Ryan Libby
Author: rlibby Date: Mon Nov 25 07:38:31 2019 New Revision: 355084 URL: https://svnweb.freebsd.org/changeset/base/355084 Log: vm_object_collapse_scan_wait: drop locks before reacquiring Regression from r352174. In the vm_page_rename() failure case we forgot to unlock the vm object locks

svn commit: r355126 - in head/sys: kern sys

2019-11-26 Thread Ryan Libby
Author: rlibby Date: Wed Nov 27 01:54:39 2019 New Revision: 355126 URL: https://svnweb.freebsd.org/changeset/base/355126 Log: witness: sleepable rm locks are not sleepable in read mode There are two classes of rm lock, one "sleepable" and one not. But even a "sleepable" rm lock is only

svn commit: r355137 - head/sys/vm

2019-11-27 Thread Ryan Libby
Author: rlibby Date: Wed Nov 27 19:49:55 2019 New Revision: 355137 URL: https://svnweb.freebsd.org/changeset/base/355137 Log: uma: trash memory when ctor/dtor supplied too On INVARIANTS kernels, UMA has a use-after-free detection mechanism. This mechanism previously required that all of

Re: svn commit: r355101 - head/sys/dev/cfi

2019-11-25 Thread Ryan Libby
On Mon, Nov 25, 2019 at 1:21 PM Ed Maste wrote: > > Author: emaste > Date: Mon Nov 25 21:21:37 2019 > New Revision: 355101 > URL: https://svnweb.freebsd.org/changeset/base/355101 > > Log: > cfi: check for inter overflow in cfi_devioctl > > Reported by:Pietro Oliva > Reviewed by: markj

svn commit: r355103 - head/sys/netinet

2019-11-25 Thread Ryan Libby
Author: rlibby Date: Mon Nov 25 22:25:34 2019 New Revision: 355103 URL: https://svnweb.freebsd.org/changeset/base/355103 Log: in_mcast.c: need if_addr_lock around inm_release_deferred Apply a similar fix as for in6_mcast.c. Reviewed by: hselasky Sponsored by: Dell EMC Isilon

svn commit: r355102 - head/sys/netinet6

2019-11-25 Thread Ryan Libby
Author: rlibby Date: Mon Nov 25 22:25:10 2019 New Revision: 355102 URL: https://svnweb.freebsd.org/changeset/base/355102 Log: in6_joingroup_locked: need if_addr_lock around in6m_disconnect_locked It looks like the call that requires the lock was introduced in r337866. Reviewed by:

svn commit: r355166 - head/sys/vm

2019-11-27 Thread Ryan Libby
Author: rlibby Date: Thu Nov 28 04:15:16 2019 New Revision: 355166 URL: https://svnweb.freebsd.org/changeset/base/355166 Log: uma: move sysctl vm.uma defn out from under INVARIANTS Fix non-INVARIANTS builds after r355149. Reported by: Michael Butler Reviewed by: markj

svn commit: r355208 - head/sys/conf

2019-11-28 Thread Ryan Libby
Author: rlibby Date: Fri Nov 29 06:25:07 2019 New Revision: 355208 URL: https://svnweb.freebsd.org/changeset/base/355208 Log: kern.mk: -Wno-error=stringop-overflow for gcc due to false positives Demote gcc's Wstringop-overflow to Wno-error due to false positives. E.g. the riscv64 build

svn commit: r355207 - head/sys/kern

2019-11-28 Thread Ryan Libby
Author: rlibby Date: Fri Nov 29 06:25:03 2019 New Revision: 355207 URL: https://svnweb.freebsd.org/changeset/base/355207 Log: ktls_session zone: don't need to specify uma trash The use of the uma trash procedures is automatic, there's no need to pass them explicitly here. Reviewed

svn commit: r355974 - head/lib/libdevdctl

2019-12-20 Thread Ryan Libby
Author: rlibby Date: Sat Dec 21 02:44:26 2019 New Revision: 355974 URL: https://svnweb.freebsd.org/changeset/base/355974 Log: libdevdctl: g++9 avoid Wdeprecated-copy g++9 now warns about having defined an assignment operator but using the default copy constructor, or vice versa. Avoid

svn commit: r355975 - head/contrib/jemalloc/src

2019-12-20 Thread Ryan Libby
Author: rlibby Date: Sat Dec 21 02:44:38 2019 New Revision: 355975 URL: https://svnweb.freebsd.org/changeset/base/355975 Log: jemalloc: pick from upstream: Fix GCC-9.1 warning with macro GET_ARG_NUMERIC Pick 2d6d099fed05b1509e81e54458516528bfbbf38d from upstream jemalloc: Fix

svn commit: r355971 - head/share/mk

2019-12-20 Thread Ryan Libby
Author: rlibby Date: Sat Dec 21 02:43:49 2019 New Revision: 355971 URL: https://svnweb.freebsd.org/changeset/base/355971 Log: gcc9: quiet Waddress-of-packed-member for user build Disable the warning for WARNS <= 3. This is lame, but it's what we already do for the clang build.

svn commit: r355972 - in head: sbin/camcontrol sys/sys

2019-12-20 Thread Ryan Libby
Author: rlibby Date: Sat Dec 21 02:44:00 2019 New Revision: 355972 URL: https://svnweb.freebsd.org/changeset/base/355972 Log: Declare packed struct ata_params as 2-byte-aligned This avoids gcc9 warning about unaligned access to the structure when casting to uint16_t pointer type.

  1   2   >