svn commit: r304025 - head/share/misc

) @@ -312,6 +312,7 @@ theraven [label="David Chisnall\ntherave thompsa [label="Andrew Thompson\nthom...@freebsd.org\n2005/05/25"] ticso [label="Bernd Walter\nti...@freebsd.org\n2002/01/31"] tijl [label="Tijl Coosemans\nt...@freebsd.org\n2010/07/16"] +tsoome [labe

svn commit: r304321 - in head/sys: boot/efi/boot1 boot/efi/loader boot/i386/boot2 boot/i386/gptboot boot/i386/gptzfsboot boot/i386/zfsboot boot/userboot/ficl boot/userboot/userboot boot/userboot/zf...

======= --- head/sys/cddl/boot/zfs/sha256.c Wed Aug 17 22:13:39 2016 (r304320) +++ head/sys/cddl/boot/zfs/sha256.c Thu Aug 18 00:37:07 2016 (r304321) @@ -23,19 +23,21 @@ * Copyright 2005 Sun Microsystems, Inc. All rights re

svn commit: r313042 - in head/sys/boot: efi/include efi/libefi efi/loader forth

Author: tsoome Date: Wed Feb 1 08:46:59 2017 New Revision: 313042 URL: https://svnweb.freebsd.org/changeset/base/313042 Log: loader.efi environment related cleanups Since we have dedicated libefi/env.c file for variable support, the following changes are done: Simple cstyle changes

Re: svn commit: r313337 - head/sys/boot/efi/loader

> On 6. veebr 2017, at 15:53, Cy Schubert <cy.schub...@komquats.com> wrote: > > In message <201702061057.v16avs9m018...@repo.freebsd.org>, Toomas Soome > writes: >> Author: tsoome >> Date: Mon Feb 6 10:57:54 2017 >> New Revision: 313337 >> URL:

svn commit: r313337 - head/sys/boot/efi/loader

Author: tsoome Date: Mon Feb 6 10:57:54 2017 New Revision: 313337 URL: https://svnweb.freebsd.org/changeset/base/313337 Log: loader: 313329 missed ZFS guard in loader/main.c Missing guard added. Reviewed by: imp, allanjude Approved by: imp (mentor), allanjude (mentor)

Re: svn commit: r313337 - head/sys/boot/efi/loader

> On 6. veebr 2017, at 15:58, Toomas Soome <tso...@me.com> wrote: > > >> On 6. veebr 2017, at 15:53, Cy Schubert <cy.schub...@komquats.com> wrote: >> >> In message <201702061057.v16avs9m018...@repo.freebsd.org>, Toomas Soome >> writes: &g

svn commit: r313442 - head/sys/boot/efi/libefi

Author: tsoome Date: Wed Feb 8 15:52:09 2017 New Revision: 313442 URL: https://svnweb.freebsd.org/changeset/base/313442 Log: loader: possible NULL pointer dereference in efipart.c Fix bugs found by Coverity in efipart.c. The Issue is that efi_devpath_last_node() can return NULL

svn commit: r313451 - head/sys/boot/common

Author: tsoome Date: Wed Feb 8 18:32:53 2017 New Revision: 313451 URL: https://svnweb.freebsd.org/changeset/base/313451 Log: loader: possible NULL pointer dereference in bcache.c Coverity detected the possible NULL pointer dereference case. Also updated comment as was suggested in

svn commit: r313348 - head/sys/boot/i386/libi386

Author: tsoome Date: Mon Feb 6 18:29:43 2017 New Revision: 313348 URL: https://svnweb.freebsd.org/changeset/base/313348 Log: loader: biosdisk fix for 2+TB disks This fix is implementing partition based boundary check for disk IO and updates disk mediasize (if needed), based on

svn commit: r313349 - in head/sys/boot/i386: btx/lib libi386

Author: tsoome Date: Mon Feb 6 18:44:15 2017 New Revision: 313349 URL: https://svnweb.freebsd.org/changeset/base/313349 Log: loader: disk io should not use alloca() The alloca() does give us pointer and we have no practical way to check if the area is actually available, resulting in

svn commit: r313332 - head/sys/boot/common

Author: tsoome Date: Mon Feb 6 08:58:40 2017 New Revision: 313332 URL: https://svnweb.freebsd.org/changeset/base/313332 Log: loader: bcache read ahead block count should take account the large sectors The loader bcache is implementing simple read-ahead to boost the cache. The bcache is

svn commit: r313328 - in head/sys/boot: common usb/storage zfs

Author: tsoome Date: Mon Feb 6 08:26:45 2017 New Revision: 313328 URL: https://svnweb.freebsd.org/changeset/base/313328 Log: loader: Implement disk_ioctl() to support DIOCGSECTORSIZE and DIOCGMEDIASIZE. Need interface to extract information about disk abstraction, to read disk or

svn commit: r313333 - in head: lib/libstand sys/boot/efi/include sys/boot/efi/libefi sys/boot/efi/loader sys/boot/zfs

Author: tsoome Date: Mon Feb 6 09:18:47 2017 New Revision: 31 URL: https://svnweb.freebsd.org/changeset/base/31 Log: loader: Replace EFI part devices. Rewrite EFI part device interface to present disk devices in more user friendly way. We keep list of three types of

svn commit: r313166 - head/sys/boot/efi/libefi

Author: tsoome Date: Fri Feb 3 16:39:10 2017 New Revision: 313166 URL: https://svnweb.freebsd.org/changeset/base/313166 Log: loader: libefi/env.c warnings in arm build The arm build has revealed some of the warnings, the fix for CHAR16 warning is to switch the warning off for env.c

Re: svn commit: r313166 - head/sys/boot/efi/libefi

> On 3. veebr 2017, at 18:47, Ian Lepore <i...@freebsd.org> wrote: > > On Fri, 2017-02-03 at 16:39 +0000, Toomas Soome wrote: >> Author: tsoome >> Date: Fri Feb 3 16:39:10 2017 >> New Revision: 313166 >> URL: https://svnweb.freebsd.org/changeset/base/31316

svn commit: r313047 - in head/sys/boot: common i386/libi386 uboot/lib usb/storage zfs

Author: tsoome Date: Wed Feb 1 20:10:56 2017 New Revision: 313047 URL: https://svnweb.freebsd.org/changeset/base/313047 Log: loader: disk/part api needs to use uint64_t offsets The disk_* and part_* api is using 64bit values for media size and offsets. However, the current api is using

svn commit: r314112 - in head/sys: boot/zfs cddl/boot/zfs

Author: tsoome Date: Wed Feb 22 22:00:50 2017 New Revision: 314112 URL: https://svnweb.freebsd.org/changeset/base/314112 Log: loader: update symlink support in zfs reader As the current zfs file system is providing symlink via system attributes, need to update the code accordingly.

svn commit: r313710 - head/sys/boot/efi/libefi

Author: tsoome Date: Mon Feb 13 21:33:50 2017 New Revision: 313710 URL: https://svnweb.freebsd.org/changeset/base/313710 Log: loader: cstyle fixes and DIOCGMEDIASIZE should use uint64_t Cleaned up some spaces where tabs should be. efipart_ioctl() DIOCGMEDIASIZE needs to use uint64_t, not

svn commit: r313645 - head/sys/boot/efi/libefi

Author: tsoome Date: Sat Feb 11 15:25:49 2017 New Revision: 313645 URL: https://svnweb.freebsd.org/changeset/base/313645 Log: loader: implement MEDIA_FILEPATH_DP support in efipart The efipart rework did break the ARM systems as the new code is using more exact filters to sort the

svn commit: r312374 - head/sys/boot/efi/libefi

Author: tsoome Date: Wed Jan 18 08:18:07 2017 New Revision: 312374 URL: https://svnweb.freebsd.org/changeset/base/312374 Log: loader: efi devpath api usage should be more aware of NULL pointers As the efi_devpath_last_node() and efi_devpath_trim() can return NULL pointers, the consumers

svn commit: r312237 - head/sys/boot/efi/loader

Author: tsoome Date: Sun Jan 15 20:03:13 2017 New Revision: 312237 URL: https://svnweb.freebsd.org/changeset/base/312237 Log: loader.efi: find_currdev() can leak memory The find_currdev() is using variable "copy" to store the reference to trimmed devpath pointer, if for some reason the

svn commit: r312314 - in head/sys/boot/efi: include libefi

Author: tsoome Date: Mon Jan 16 20:57:01 2017 New Revision: 312314 URL: https://svnweb.freebsd.org/changeset/base/312314 Log: loader: move device path definitions to include/efidevp.h No functional change, only moving uuid and protocol bits to include/efidevp.h Reviewed by: imp, jhb

Re: svn commit: r304187 - in head: . share/man/man4 sys/conf sys/dev/mcd sys/modules sys/modules/mcd

> On 19. aug 2016, at 10:39, Konstantin Belousov wrote: > > On Thu, Aug 18, 2016 at 09:28:57PM -0600, Warner Losh wrote: >> On Thu, Aug 18, 2016 at 12:50 AM, Julian Elischer wrote: >>> On 16/08/2016 4:54 AM, John Baldwin wrote: On Monday,

Re: svn commit: r304187 - in head: . share/man/man4 sys/conf sys/dev/mcd sys/modules sys/modules/mcd

> On 19. aug 2016, at 12:24, Konstantin Belousov <kostik...@gmail.com> wrote: > > On Fri, Aug 19, 2016 at 11:50:35AM +0300, Toomas Soome wrote: >> >>> On 19. aug 2016, at 10:39, Konstantin Belousov <kostik...@gmail.com> wrote: >>> >>> On Th

svn commit: r304532 - in head/sys/boot: common efi/loader/arch/amd64 fdt

Author: tsoome Date: Sat Aug 20 16:23:19 2016 New Revision: 304532 URL: https://svnweb.freebsd.org/changeset/base/304532 Log: loader is filling fixed length command_errbuf with sprintf() and is trusting strings provided by user/config files. This update is replacing sprintf with snprintf

Re: svn commit: r304321 - in head/sys: boot/efi/boot1 boot/efi/loader boot/i386/boot2 boot/i386/gptboot boot/i386/gptzfsboot boot/i386/zfsboot boot/userboot/ficl boot/userboot/userboot boot/userboot/z

> On 22. aug 2016, at 17:19, Warner Losh <i...@bsdimp.com> wrote: > > On Mon, Aug 22, 2016 at 3:44 AM, Toomas Soome <tso...@me.com> wrote: >> I do suspect the size difference there is partially due to ficl, in illumos >> (ficl 4): >> >> -rw-r--r

svn commit: r304317 - head/sys/boot/efi/boot1

Author: tsoome Date: Wed Aug 17 21:29:57 2016 New Revision: 304317 URL: https://svnweb.freebsd.org/changeset/base/304317 Log: boot1.efi Free() should check for NULL to provide consistent behavior with libstand Free(). Reviewed by: imp Approved by: imp (mentor) Differential

Re: svn commit: r304321 - in head/sys: boot/efi/boot1 boot/efi/loader boot/i386/boot2 boot/i386/gptboot boot/i386/gptzfsboot boot/i386/zfsboot boot/userboot/ficl boot/userboot/userboot boot/userboot/z

> On 22. aug 2016, at 11:09, Andriy Gapon wrote: > > On 22/08/2016 10:20, Andriy Gapon wrote: >> This commit breaks boot process for me and in a quite weird way. >> I don't have a serial console, so a couple of screenshots. >> This is what happens with this change: >>

Re: svn commit: r305178 - head/sys/boot/i386/libi386

> On 1. sept 2016, at 21:28, John Baldwin <j...@freebsd.org> wrote: > > On Thursday, September 01, 2016 06:35:13 AM Toomas Soome wrote: >> Author: tsoome >> Date: Thu Sep 1 06:35:13 2016 >> New Revision: 305178 >> URL: https://svnweb.freeb

svn commit: r305178 - head/sys/boot/i386/libi386

Author: tsoome Date: Thu Sep 1 06:35:13 2016 New Revision: 305178 URL: https://svnweb.freebsd.org/changeset/base/305178 Log: bd_int13probe() should check extended info if sector info is bad In some Dell systems and usb stick combinations, it is found that int13 AH=08 is reporting back

svn commit: r305116 - head/lib/libstand

Author: tsoome Date: Wed Aug 31 09:23:09 2016 New Revision: 305116 URL: https://svnweb.freebsd.org/changeset/base/305116 Log: recvtftp() is broken for large files, report file size The tftp download for large files will cause internal block id to wrap to 0 as the data type is unsigned

svn commit: r304850 - head/lib/libstand

Author: tsoome Date: Fri Aug 26 14:58:57 2016 New Revision: 304850 URL: https://svnweb.freebsd.org/changeset/base/304850 Log: Unused variables and cstyle fix for loader dosfs Reviewed by: imp, allanjude Approved by: imp (mentor), allanjude (mentor) Differential Revision:

Re: svn commit: r304321 - in head/sys: boot/efi/boot1 boot/efi/loader boot/i386/boot2 boot/i386/gptboot boot/i386/gptzfsboot boot/i386/zfsboot boot/userboot/ficl boot/userboot/userboot boot/userboot/z

> On 22. aug 2016, at 17:56, Toomas Soome <tso...@me.com> wrote: > > >> On 22. aug 2016, at 17:19, Warner Losh <i...@bsdimp.com> wrote: >> >> On Mon, Aug 22, 2016 at 3:44 AM, Toomas Soome <tso...@me.com> wrote: >>> I do suspect the size

Re: svn commit: r304321 - in head/sys: boot/efi/boot1 boot/efi/loader boot/i386/boot2 boot/i386/gptboot boot/i386/gptzfsboot boot/i386/zfsboot boot/userboot/ficl boot/userboot/userboot boot/userboot/z

> On 23. aug 2016, at 11:22, Andriy Gapon <a...@freebsd.org> wrote: > > On 22/08/2016 17:56, Toomas Soome wrote: >> Actually I only now realized I was comparing apples with oranges… I forgot >> the fbsd builds 32bit version in ficl32, this one is 64bit. a

Re: svn commit: r304321 - in head/sys: boot/efi/boot1 boot/efi/loader boot/i386/boot2 boot/i386/gptboot boot/i386/gptzfsboot boot/i386/zfsboot boot/userboot/ficl boot/userboot/userboot boot/userboot/z

> On 23. aug 2016, at 15:16, Slawa Olhovchenkov <s...@zxy.spb.ru> wrote: > > On Tue, Aug 23, 2016 at 03:00:32PM +0300, Toomas Soome wrote: > >> >>> On 23. aug 2016, at 14:29, Slawa Olhovchenkov <s...@zxy.spb.ru> wrote: >>> >>> On

Re: svn commit: r304321 - in head/sys: boot/efi/boot1 boot/efi/loader boot/i386/boot2 boot/i386/gptboot boot/i386/gptzfsboot boot/i386/zfsboot boot/userboot/ficl boot/userboot/userboot boot/userboot/z

> On 23. aug 2016, at 15:36, Slawa Olhovchenkov <s...@zxy.spb.ru> wrote: > > On Tue, Aug 23, 2016 at 03:26:04PM +0300, Toomas Soome wrote: > >>> Main trouble (by kib@) is 640KB real mode limit. >>> Separated heap don't soled this. >>> May be solu

Re: svn commit: r304321 - in head/sys: boot/efi/boot1 boot/efi/loader boot/i386/boot2 boot/i386/gptboot boot/i386/gptzfsboot boot/i386/zfsboot boot/userboot/ficl boot/userboot/userboot boot/userboot/z

> On 23. aug 2016, at 14:29, Slawa Olhovchenkov <s...@zxy.spb.ru> wrote: > > On Tue, Aug 23, 2016 at 11:05:47AM +0300, Toomas Soome wrote: > >> >>> On 22. aug 2016, at 17:56, Toomas Soome <tso...@me.com> wrote: >>> >>> >>&g

svn commit: r304753 - head/sys/cddl/boot/zfs

Author: tsoome Date: Wed Aug 24 16:30:15 2016 New Revision: 304753 URL: https://svnweb.freebsd.org/changeset/base/304753 Log: Bug 212114 - loader: zio_checksum_verify() must test spa for NULL pointer The issue was introduced with adding support for salted checksums, and was revealed by

svn commit: r304754 - head/sys/boot/userboot/userboot

Author: tsoome Date: Wed Aug 24 16:40:29 2016 New Revision: 304754 URL: https://svnweb.freebsd.org/changeset/base/304754 Log: Bug 212038 - svn commit: r304321 broken bhyve zvol VM bhyveload hang 100% WCPU As the support for large blocks was enabled in loader zfs code, the heap in

svn commit: r306638 - head/lib/libstand

Author: tsoome Date: Mon Oct 3 14:07:15 2016 New Revision: 306638 URL: https://svnweb.freebsd.org/changeset/base/306638 Log: Fix remaining bugs in libstancd/cd9660.c reported by Bruce Evans. Fixed text in comments. Reported by: Bruce Evans Reviewed by:

svn commit: r306534 - head/lib/libstand

Author: tsoome Date: Fri Sep 30 22:28:20 2016 New Revision: 306534 URL: https://svnweb.freebsd.org/changeset/base/306534 Log: cd9660_open should check for padding The libstand cd9660 reader code must check for extents having padding. Reviewed by: jhb Approved by: allanjude

svn commit: r306538 - head/lib/libstand

Author: tsoome Date: Fri Sep 30 23:19:08 2016 New Revision: 306538 URL: https://svnweb.freebsd.org/changeset/base/306538 Log: cstyle fix of cd9660_open in libstand rS306534 did create bad cstyle by my mistake, correcting it. Reviewed by: allanjude Approved by: allanjude (mentor)

svn commit: r306380 - head/sys/boot/common

Author: tsoome Date: Tue Sep 27 20:40:44 2016 New Revision: 306380 URL: https://svnweb.freebsd.org/changeset/base/306380 Log: loader command interpreter should reset command_errmsg The command interpreter does leave command_errmsg as is after printing its content, assuming the next

svn commit: r306552 - head/lib/libstand

Author: tsoome Date: Sat Oct 1 07:46:28 2016 New Revision: 306552 URL: https://svnweb.freebsd.org/changeset/base/306552 Log: Fix remaining cstyle issues in libstand/cd9660.c Reported by: Bruce Evans Reviewed by: allanjude Approved by: allanjude (mentor)

svn commit: r308476 - head/sys/boot/forth

Author: tsoome Date: Wed Nov 9 21:28:46 2016 New Revision: 308476 URL: https://svnweb.freebsd.org/changeset/base/308476 Log: boot/forth spelling issue in forth word Reviewed by: dteske, imp Approved by: imp (mentor) Differential Revision:https://reviews.freebsd.org/D8484

svn commit: r308434 - in head: lib/libstand sys/boot/common sys/boot/efi/libefi sys/boot/efi/loader sys/boot/i386/libfirewire sys/boot/i386/libi386 sys/boot/mips/beri/loader sys/boot/ofw/libofw sys...

Author: tsoome Date: Tue Nov 8 06:50:18 2016 New Revision: 308434 URL: https://svnweb.freebsd.org/changeset/base/308434 Log: Loader paged/pageable data is not always paged. This change does modify devsw dv_print() to return the int value, enabling walkers to interrupt the walk on non

Re: svn commit: r308434 - in head: lib/libstand sys/boot/common sys/boot/efi/libefi sys/boot/efi/loader sys/boot/i386/libfirewire sys/boot/i386/libi386 sys/boot/mips/beri/loader sys/boot/ofw/libofw sy

pes initializing 'void (*)(int)' with an expression of type 'int > (int)' [-Werror,-Wincompatible-pointer-types] > .dv_print = zfs_dev_print, > ^~~~~ > 1 error generated. > *** Error code 1 > > Stop. > make[2]: stopped in /usr/src/sys/boot/

svn commit: r307865 - head/sys/boot/zfs

Author: tsoome Date: Mon Oct 24 16:28:54 2016 New Revision: 307865 URL: https://svnweb.freebsd.org/changeset/base/307865 Log: loader should boot pre-feature flags pools. The feature flags chek is missing the corner case where we have valid pool version, but feature flags are not enabled

Re: svn commit: r308434 - in head: lib/libstand sys/boot/common sys/boot/efi/libefi sys/boot/efi/loader sys/boot/i386/libfirewire sys/boot/i386/libi386 sys/boot/mips/beri/loader sys/boot/ofw/libofw sy

appen with any header change, as you can not really build new source with using old headers. rgds, toomas > > On Thu, Nov 10, 2016 at 11:52 PM, Kamil Czekirda <kczeki...@gmail.com> wrote: >> cp /usr/src/lib/libstand/libstand.h /usr/include/stand.h fixed that >> >> th

svn commit: r308827 - in head/sys/boot: common efi/libefi i386/libfirewire i386/libi386 mips/beri/loader pc98/libpc98 uboot/lib usb/storage userboot/userboot zfs

Author: tsoome Date: Sat Nov 19 08:54:21 2016 New Revision: 308827 URL: https://svnweb.freebsd.org/changeset/base/308827 Log: lsdev device name section headers should be printed by dv_print callback. lsdev command does walk over devsw list, prints list element name and will use

svn commit: r308776 - head/sys/boot/zfs

Author: tsoome Date: Thu Nov 17 19:38:30 2016 New Revision: 308776 URL: https://svnweb.freebsd.org/changeset/base/308776 Log: loader: zfs toplevel vdev must have spa set. The salt based checksum mechanisms, such as skein, are storing the seed in spa structure, and need to access the spa

svn commit: r308774 - head/sys/boot/mips/beri/loader

Author: tsoome Date: Thu Nov 17 18:38:35 2016 New Revision: 308774 URL: https://svnweb.freebsd.org/changeset/base/308774 Log: loader: beri_sdcard_disk_print() needs to return int. The https://reviews.freebsd.org/rS308434 did change the return type for dv_print callbacks, but the return

svn commit: r308843 - head/sys/boot/i386/libi386

Author: tsoome Date: Sat Nov 19 16:08:40 2016 New Revision: 308843 URL: https://svnweb.freebsd.org/changeset/base/308843 Log: loader: smbios version check is not correct The version check for sku and family values is not correct, as this data is valid for version 2.4+, that also includes

svn commit: r308195 - head/sys/boot/efi/libefi

Author: tsoome Date: Wed Nov 2 06:37:35 2016 New Revision: 308195 URL: https://svnweb.freebsd.org/changeset/base/308195 Log: efinet_dev_print should honor verbose option. lsdev should display detailed information about net devices only with -v switch. This will make EFI and BIOS version

svn commit: r309369 - head/lib/libstand

Author: tsoome Date: Thu Dec 1 19:19:20 2016 New Revision: 309369 URL: https://svnweb.freebsd.org/changeset/base/309369 Log: libstand: dosfs cstyle cleanup for return keyword. Reviewed by: bapt, imp, allanjude Approved by: imp (mentor), allanjude (mentor) Differential Revision:

svn commit: r310845 - head/sys/boot/i386/common

Author: tsoome Date: Fri Dec 30 18:21:52 2016 New Revision: 310845 URL: https://svnweb.freebsd.org/changeset/base/310845 Log: boot2 will deadlock if extended keys are used on text input The boot2 family of bootblocks (zfsboot/gptzfsboot) are using separate implementation if keyboard

svn commit: r310850 - in head: lib/libstand sys/boot/common sys/boot/efi/libefi sys/boot/i386/libfirewire sys/boot/i386/libi386 sys/boot/mips/beri/loader sys/boot/ofw/libofw sys/boot/pc98/libpc98 s...

Author: tsoome Date: Fri Dec 30 19:06:29 2016 New Revision: 310850 URL: https://svnweb.freebsd.org/changeset/base/310850 Log: dosfs support in libstand is broken since r298230 Apparently the libstand dosfs optimization is a bit too optimistic and did introduce possible memory corruption.

svn commit: r310853 - head/lib/libstand

Author: tsoome Date: Fri Dec 30 20:00:41 2016 New Revision: 310853 URL: https://svnweb.freebsd.org/changeset/base/310853 Log: loader: nandfs calls strategy with one extra argument. The strategy argument cleanup in r310850 did miss another call to strategy(), and left it with extra

Re: svn commit: r316064 - head/sys/boot/i386/boot2

> On 28. märts 2017, at 18:55, Rodney W. Grimes > wrote: > >> On Mon, 27 Mar 2017, Julian Elischer wrote: >> >>> On Tue, 28 Mar 2017, Bruce Evans wrote: >>> >>> [...] >>> they have to fit below 640K and a few multiples of 64K are already used for

svn commit: r316279 - head/sys/boot/efi/libefi

Author: tsoome Date: Thu Mar 30 16:23:31 2017 New Revision: 316279 URL: https://svnweb.freebsd.org/changeset/base/316279 Log: loader: efipart should check disk size from partition table While testing 32bit UEFI OVMF (which has bug about how the disk size is presented), I did witness the

svn commit: r316280 - head/sys/boot/efi/loader

Author: tsoome Date: Thu Mar 30 16:31:35 2017 New Revision: 316280 URL: https://svnweb.freebsd.org/changeset/base/316280 Log: loader: simplify efi_zfs_probe and avoid double probing for zfs. The current efi_zfs_probe() is overcomplicated and can be made simpler. Still we need to pick up

svn commit: r316287 - in head: lib/libstand sys/boot/i386/libi386

Author: tsoome Date: Thu Mar 30 19:32:25 2017 New Revision: 316287 URL: https://svnweb.freebsd.org/changeset/base/316287 Log: Remove OLD_NFSV2 from loader and libstand We have parallel NFSv2 and NFSv3 reader implementations, only configurable at build time, defaulting to v3. Remove v2.

svn commit: r316111 - head/sys/boot/i386/libi386

Author: tsoome Date: Tue Mar 28 21:47:12 2017 New Revision: 316111 URL: https://svnweb.freebsd.org/changeset/base/316111 Log: loader: move bios getsecs into time.c Move the time related function into time.c, keep the same logic as libefi. Reviewed by: allanjude Approved by:

svn commit: r316112 - head/sys/boot/common

Author: tsoome Date: Tue Mar 28 21:50:11 2017 New Revision: 316112 URL: https://svnweb.freebsd.org/changeset/base/316112 Log: loader: ls command should display file types properly With some file system the ls is unable to display file types. Reviewed by: allanjude Approved by:

Re: svn commit: r316132 - head/sys/boot/i386/boot2

> On 30. märts 2017, at 0:55, Warner Losh wrote: > > On Wed, Mar 29, 2017 at 3:36 PM, Poul-Henning Kamp > wrote: >> >> In message <7448826.asyms2t...@ralph.baldwin.cx>, John Baldwin writes: >>> On Wednesday, March 29, 2017 09:30:03 AM Ngie Cooper

svn commit: r315653 - in head: lib/libstand sys/boot/common sys/boot/i386/libi386

Author: tsoome Date: Mon Mar 20 22:20:17 2017 New Revision: 315653 URL: https://svnweb.freebsd.org/changeset/base/315653 Log: loader: verify the value from dhcp.interface-mtu and use snprintf to set mtu Since the uset can set dhcp.interface-mtu, we need to try to validate the value. So

svn commit: r315648 - head/lib/libstand

Author: tsoome Date: Mon Mar 20 19:16:28 2017 New Revision: 315648 URL: https://svnweb.freebsd.org/changeset/base/315648 Log: libstand: verify value provided by nfs.read_size Implement simple value check and feedback. Reviewed by: allanjude, rpokala Approved by: allanjude (mentor)

svn commit: r315408 - in head/sys/boot: common efi/libefi i386/libi386 mips/beri/loader uboot/lib usb/storage userboot/userboot

Author: tsoome Date: Thu Mar 16 12:04:43 2017 New Revision: 315408 URL: https://svnweb.freebsd.org/changeset/base/315408 Log: loader: remove open_disk cache As we provide the disk size verification and correction via disk_ioctl and disk state provided by disk_open(), we can not share the

svn commit: r315645 - head/sys/boot/userboot/userboot

Author: tsoome Date: Mon Mar 20 18:03:40 2017 New Revision: 315645 URL: https://svnweb.freebsd.org/changeset/base/315645 Log: loader: disk_cleanup was left in userboot_disk.c In r315408, disk_cleanup was removed, which is called at sys/boot/userboot/userboot/userboot_disk.c:113. This

svn commit: r315646 - head/sys/boot/i386/libi386

Author: tsoome Date: Mon Mar 20 18:15:36 2017 New Revision: 315646 URL: https://svnweb.freebsd.org/changeset/base/315646 Log: loader: pxe.h constants have wrong values FLTR_PRMSCS should be 0x4 and FLTR_SRC_RTG should be 0x8 PXE Specification 2.1 PXENV_UNDI_OPEN, page 59.

svn commit: r315427 - head/sys/boot/i386/libi386

Author: tsoome Date: Thu Mar 16 21:34:14 2017 New Revision: 315427 URL: https://svnweb.freebsd.org/changeset/base/315427 Log: loader: biosdisk should report IO error from INT13 We should be more verbose about read errors from biosdisk, except filter out the floppy controller errors,

svn commit: r315326 - head/sys/boot/efi/boot1

Author: tsoome Date: Wed Mar 15 19:48:22 2017 New Revision: 315326 URL: https://svnweb.freebsd.org/changeset/base/315326 Log: boot1.efi: can't boot from ZFS on 4kn HDD The boot1.efi immediate issue from PR216964 is that we are reading into too small buffer, from UEFI spec 2.6: The

svn commit: r316654 - head/sys/boot/userboot/userboot

Author: tsoome Date: Sun Apr 9 11:16:16 2017 New Revision: 316654 URL: https://svnweb.freebsd.org/changeset/base/316654 Log: loader: r316585 did miss userboot update The work to implement zfs reader to inspect all pool label copies did miss the userboot, this update does correct this

svn commit: r316682 - in head/sys/boot: ofw/libofw sparc64/loader

Author: tsoome Date: Mon Apr 10 17:57:56 2017 New Revision: 316682 URL: https://svnweb.freebsd.org/changeset/base/316682 Log: loader: r316585 did miss sparc/ofw This update does add the code to pass partition size to vdev_probe() via simple callback. Tested via tinderbox build, but not

svn commit: r316704 - head/sys/boot/efi/loader

Author: tsoome Date: Tue Apr 11 15:20:32 2017 New Revision: 316704 URL: https://svnweb.freebsd.org/changeset/base/316704 Log: loader.efi: only fetch zfs pool guid for the actual boot device With the zfs probe cleanup, the mistake did slip in the probe code; instead of reading the pool

svn commit: r316578 - in head: lib/libstand sys/boot/common

Author: tsoome Date: Thu Apr 6 15:57:53 2017 New Revision: 316578 URL: https://svnweb.freebsd.org/changeset/base/316578 Log: loader: want mechanism to avoid RA with bcache While we have mechanisms in place to protect ourselves against the read behind the disk end, there is still one

svn commit: r316577 - head/sys/boot/common

Author: tsoome Date: Thu Apr 6 15:42:12 2017 New Revision: 316577 URL: https://svnweb.freebsd.org/changeset/base/316577 Log: loader: part.c cstyle cleanup The description tells it all, as an side note, I am using uint8_t instead of u_char as the partition table data really is handled as

Re: svn commit: r316585 - in head/sys/boot: efi/boot1 efi/loader i386/common i386/loader i386/zfsboot zfs

Yes, sorry, I did miss the sparc version, looking on it…. rgds, toomas > On 6. apr 2017, at 22:41, Bryan Drewery <bdrew...@freebsd.org> wrote: > > On 4/6/2017 11:17 AM, Toomas Soome wrote: >> Author: tsoome >> Date: Thu Apr 6 18:17:29 2017 >> N

svn commit: r316590 - head/lib/libstand

Author: tsoome Date: Thu Apr 6 20:12:39 2017 New Revision: 316590 URL: https://svnweb.freebsd.org/changeset/base/316590 Log: libstand/dosfs: cache FAT32 in 128 Kb blocks to save loader memory Current implementation of dosfs in libstand reads full File Allocation Table to the RAM in the

Re: svn commit: r316585 - in head/sys/boot: efi/boot1 efi/loader i386/common i386/loader i386/zfsboot zfs

> On 9. apr 2017, at 1:16, Shawn Webb <shawn.w...@hardenedbsd.org> wrote: > > On Thu, Apr 06, 2017 at 06:17:29PM +0000, Toomas Soome wrote: >> Author: tsoome >> Date: Thu Apr 6 18:17:29 2017 >> New Revision: 316585 >> URL: https://svnweb.freebsd.org/chang

svn commit: r317092 - head/sys/boot/zfs

Author: tsoome Date: Tue Apr 18 15:43:47 2017 New Revision: 317092 URL: https://svnweb.freebsd.org/changeset/base/317092 Log: loader: zfs reader vdev_probe should check for minimum device size The smallest device we can have in the pool is 64MB, since we are trying to walk all four

svn commit: r317097 - in head/sys/boot: common efi/libefi i386/libi386 mips/beri/loader powerpc/ps3 uboot/lib usb/storage userboot/userboot

Author: tsoome Date: Tue Apr 18 18:07:54 2017 New Revision: 317097 URL: https://svnweb.freebsd.org/changeset/base/317097 Log: loader: F_READ/F_WRITE should be checked against masked flag The work to make it possible to avoid bcache via using F_NORA modifier did miss the fact that not all

svn commit: r314504 - head/sys/boot/zfs

Author: tsoome Date: Wed Mar 1 19:02:43 2017 New Revision: 314504 URL: https://svnweb.freebsd.org/changeset/base/314504 Log: loader: r314112 did introduce dereference freed pointer entry CID: 1371675 Reported by: Coverity Reviewed by: jhb, allanjude Approved by: allanjude

Re: svn commit: r316585 - in head/sys/boot: efi/boot1 efi/loader i386/common i386/loader i386/zfsboot zfs

> On 6. apr 2017, at 22:48, Toomas Soome <tso...@me.com> wrote: > > > Yes, sorry, I did miss the sparc version, looking on it…. I did quick and “dirty” first round, but really need some help there, please check and comment: https://reviews.freebsd.org/D10302 <https:

svn commit: r316585 - in head/sys/boot: efi/boot1 efi/loader i386/common i386/loader i386/zfsboot zfs

Author: tsoome Date: Thu Apr 6 18:17:29 2017 New Revision: 316585 URL: https://svnweb.freebsd.org/changeset/base/316585 Log: loader: zfs reader should check all labels The current zfs reader is only checking first label from each device, however, we do have 4 labels on device and we

Re: svn commit: r315653 - in head: lib/libstand sys/boot/common sys/boot/i386/libi386

> On 21. märts 2017, at 17:15, Ian Lepore <i...@freebsd.org> wrote: > > On Tue, 2017-03-21 at 15:35 +0300, Slawa Olhovchenkov wrote: >> On Mon, Mar 20, 2017 at 10:20:17PM +, Toomas Soome wrote: >> >>> >>> Author: tsoome >>> Date: Mon

svn commit: r317099 - head/sys/boot/uboot/lib

Author: tsoome Date: Tue Apr 18 19:36:58 2017 New Revision: 317099 URL: https://svnweb.freebsd.org/changeset/base/317099 Log: loader: uboot disk ioctl should call disk_ioctl As the uboot disk interface is using common/disk.c API, we also should use disk_ioctl() call, this will give us

svn commit: r321767 - head/usr.bin/calendar/calendars

@@ 10/25 Eric Melville <e...@freebsd.org> born in Los Gatos, California, United States, 1980 10/25 Julien Laffaye <jlaff...@freebsd.org> born in Toulouse, France, 1988 10/25 Ashish SHUKLA <ash...@freebsd.org> born in Kanpur, India, 1985 +10/25 Toomas Soome <tso...@free

svn commit: r322542 - head/sys/boot/efi/loader/arch/amd64

Author: tsoome Date: Tue Aug 15 14:03:26 2017 New Revision: 322542 URL: https://svnweb.freebsd.org/changeset/base/322542 Log: loader.efi: repace XXX with real comments in trap.c There are two missing comments marked as XXX in trap.c, fix this. Reviewed by: kib Differential

svn commit: r320467 - in head/sys/boot/i386: libi386 loader

Author: tsoome Date: Thu Jun 29 04:33:55 2017 New Revision: 320467 URL: https://svnweb.freebsd.org/changeset/base/320467 Log: loader: chain load relocate data declaration is bad The implementation is using fixed size array allocated in asm module, need to use proper array declaration for

svn commit: r322074 - head/sys/boot/efi/libefi

Author: tsoome Date: Sat Aug 5 05:20:03 2017 New Revision: 322074 URL: https://svnweb.freebsd.org/changeset/base/322074 Log: libefi/time.c cstyle cleanup libefi/time.c is mix of different styles, this update does cleanup. Also fix 0 versus NULL, and zero the tv structure for case we get

svn commit: r318142 - head/lib/libstand

Author: tsoome Date: Wed May 10 15:35:41 2017 New Revision: 318142 URL: https://svnweb.freebsd.org/changeset/base/318142 Log: libstand: NULL pointer dereference in rarp readether argument is missing & operator. CID: 1374944 Reported by: Coverity, cem Reviewed by: cem

svn commit: r318297 - head/sys/dev/e1000

Author: tsoome Date: Mon May 15 16:53:02 2017 New Revision: 318297 URL: https://svnweb.freebsd.org/changeset/base/318297 Log: e1000api: misleading-indentation Two blocks in e1000_ich8lan.c are misaligned, causing noise with some compilers (gcc 6). Reviewed by: imp, erj

svn commit: r318320 - head/lib/libstand

Author: tsoome Date: Mon May 15 21:50:34 2017 New Revision: 318320 URL: https://svnweb.freebsd.org/changeset/base/318320 Log: loader: add ip layer code into libstand Implement simple separate ip module and fragment re-assembly. The work is based on send and receive previously

svn commit: r318356 - in head: lib/libstand sys/boot/i386/pxeldr

Author: tsoome Date: Tue May 16 17:35:05 2017 New Revision: 318356 URL: https://svnweb.freebsd.org/changeset/base/318356 Log: libstand: increase nfs max read size to 16k With ip fragment reassembly implemented, it makes sense to allow larger nfs reads. Note due to loader heap size limit,

Re: svn commit: r320234 - head/sys/boot/efi/include

> On 22. juuni 2017, at 21:23, Dimitry Andric wrote: > > On 22 Jun 2017, at 16:30, Ed Maste wrote: >> >> Author: emaste >> Date: Thu Jun 22 14:30:09 2017 >> New Revision: 320234 >> URL: https://svnweb.freebsd.org/changeset/base/320234 >> >> Log: >> Make

svn commit: r319084 - head/sys/boot/common

Author: tsoome Date: Sun May 28 21:20:55 2017 New Revision: 319084 URL: https://svnweb.freebsd.org/changeset/base/319084 Log: Small cleanup in dev_net.c The variable servip is unused. One leftover printf and small cstyle nit. Reviewed by: bapt Differential Revision:

svn commit: r319085 - head/lib/libstand

Author: tsoome Date: Sun May 28 21:30:01 2017 New Revision: 319085 URL: https://svnweb.freebsd.org/changeset/base/319085 Log: use the same option list for dhcp discovery and request The DHCP client is supposed to use the same option request list for both DHCP discovery and request.

svn commit: r319601 - head/lib/libmd

Author: tsoome Date: Mon Jun 5 11:55:26 2017 New Revision: 319601 URL: https://svnweb.freebsd.org/changeset/base/319601 Log: ANSIfy md5 functions Update the function declarations. Reviewed by: dim Differential Revision:https://reviews.freebsd.org/D11055 Modified:

svn commit: r320011 - in head/sys/boot: efi/loader forth i386/libi386 i386/loader

relocator_ebp; +extern uint16_t relocator_a20_enabled; + inti386_getdev(void **vdev, const char *devspec, const char **path); char *i386_fmtdev(void *vdev); inti386_setcurrdev(struct env_var *ev, int flags, const void *value); Added: head/sys/boot/i386/libi386/relocater_tramp.S =======

  1   2   3   4   5   >