svn commit: r368553 - head/sbin/decryptcore

Author: vangyzen Date: Fri Dec 11 14:32:42 2020 New Revision: 368553 URL: https://svnweb.freebsd.org/changeset/base/368553 Log: decryptcore: preload OpenSSL error strings; seed PRNG As in r360226, preload OpenSSL error strings and seed the PRNG before entering capability mode. MFC

svn commit: r367059 - head/sys/ddb

Author: vangyzen Date: Mon Oct 26 16:42:53 2020 New Revision: 367059 URL: https://svnweb.freebsd.org/changeset/base/367059 Log: db_search_symbol: prevent pollution from bogus symbols The kernel will never map the first page, so any symbols in that range cannot refer to addresses. Some

svn commit: r366914 - head/sys/dev/ntb/test

Author: vangyzen Date: Wed Oct 21 17:11:57 2020 New Revision: 366914 URL: https://svnweb.freebsd.org/changeset/base/366914 Log: ntb_tool: ubuf is too small to hold a human readable 64 bit value ubuf buffer is too small. It should be 18 if a NULL is not needed, or 19 to hold the NULL

svn commit: r366346 - head/contrib/netbsd-tests/lib/libc/sys

Author: vangyzen Date: Thu Oct 1 21:52:57 2020 New Revision: 366346 URL: https://svnweb.freebsd.org/changeset/base/366346 Log: fix setitimer test for returned it_value An old it_value of {4,3} is valid. Allow it. Reviewed by: bdrewery MFC after:2 weeks Sponsored by: Dell EMC

svn commit: r366345 - in head: contrib/netbsd-tests/usr.bin/grep usr.bin/grep

Author: vangyzen Date: Thu Oct 1 21:48:22 2020 New Revision: 366345 URL: https://svnweb.freebsd.org/changeset/base/366345 Log: zgrep: fix exit status with multiple files zgrep should exit with success when given multiple files and the pattern is found in at least one file. Prior to

svn commit: r365890 - head/sys/amd64/amd64

Author: vangyzen Date: Fri Sep 18 20:53:40 2020 New Revision: 365890 URL: https://svnweb.freebsd.org/changeset/base/365890 Log: amd64 pmap_pkru_same: prev_ppr was always NULL Fix the logic so it works as it appears. Reported by: Coverity Reviewed by: kib MFC after:2 weeks

svn commit: r365886 - in head/sys: dev/fb dev/ksyms dev/vt/hw/fb fs/tmpfs kern vm

Author: vangyzen Date: Fri Sep 18 16:48:08 2020 New Revision: 365886 URL: https://svnweb.freebsd.org/changeset/base/365886 Log: vm_ooffset_t is now unsigned vm_ooffset_t is now unsigned. Remove some tests for negative values, or make other adjustments accordingly. Reported by:

svn commit: r365845 - head/lib/libpmc/pmu-events

Author: vangyzen Date: Thu Sep 17 18:24:51 2020 New Revision: 365845 URL: https://svnweb.freebsd.org/changeset/base/365845 Log: Fix additional memory leak in process_mapfile Additional Coverity detected memory leak fix. Submitted by: bret_ketc...@dell.com Reported by: Coverity

svn commit: r365051 - head/usr.sbin/pmc

Author: vangyzen Date: Tue Sep 1 15:52:18 2020 New Revision: 365051 URL: https://svnweb.freebsd.org/changeset/base/365051 Log: pmc: Fix freed internal location read Coverity detected this error. The fix duplicates the assignment on line 171. Submitted by: bret_ketc...@dell.com

svn commit: r364998 - head/contrib/ofed/infiniband-diags/src

Author: vangyzen Date: Mon Aug 31 16:18:48 2020 New Revision: 364998 URL: https://svnweb.freebsd.org/changeset/base/364998 Log: infiniband-diags: Fix memory leak in dump_multicast_tables Coverity detected leak. Submitted by: bret_ketc...@dell.com Reported by: Coverity Reviewed

svn commit: r364997 - in head/sys/ofed: drivers/infiniband/core include/rdma

Author: vangyzen Date: Mon Aug 31 16:17:28 2020 New Revision: 364997 URL: https://svnweb.freebsd.org/changeset/base/364997 Log: infiniband: Appease Coverty Coverity claims the call to rdma_gid2ip in cma_igmp_send overwrites addr. Use a consistent definition of sockaddr to prevent

svn commit: r364996 - head/lib/libpmc/pmu-events

Author: vangyzen Date: Mon Aug 31 16:07:40 2020 New Revision: 364996 URL: https://svnweb.freebsd.org/changeset/base/364996 Log: libpmc: Fix memory leak in process_mapfile Coverity detected memory leak fix. Submitted by: bret_ketc...@dell.com Reported by: Coverity Reviewed by:

svn commit: r364992 - head/sys/fs/nfsserver

Author: vangyzen Date: Mon Aug 31 15:31:17 2020 New Revision: 364992 URL: https://svnweb.freebsd.org/changeset/base/364992 Log: Fix nfsrvd_locku memory leak Coverity detected memory leak fix. Submitted by: bret_ketc...@dell.com Reported by: Coverity Reviewed by: rmacklem MFC

Re: svn commit: r364991 - head/contrib/ofed/opensm/opensm

On 8/31/20 10:26 AM, Eric van Gyzen wrote: Author: vangyzen Date: Mon Aug 31 15:26:01 2020 New Revision: 364991 URL: https://svnweb.freebsd.org/changeset/base/364991 Log: opensm: Fix a possible dereference of a NULL pointer Submitted by: bret_ketc...@dell.com Reported

svn commit: r364991 - head/contrib/ofed/opensm/opensm

Author: vangyzen Date: Mon Aug 31 15:26:01 2020 New Revision: 364991 URL: https://svnweb.freebsd.org/changeset/base/364991 Log: opensm: Fix a possible dereference of a NULL pointer Reported by: Coverity Reviewed by: hselasky, kib MFC after:2 weeks Sponsored by: Dell EMC Isilon

svn commit: r364989 - head/sys/dev/jedec_dimm

Author: vangyzen Date: Mon Aug 31 15:03:23 2020 New Revision: 364989 URL: https://svnweb.freebsd.org/changeset/base/364989 Log: jedec_dimm: fix array overrun Coverity detected the overrunning of sc->part_str. Submitted by: bret_ketc...@dell.com Reported by: Coverity MFC after:

svn commit: r364935 - head/sys/vm

Author: vangyzen Date: Fri Aug 28 19:59:02 2020 New Revision: 364935 URL: https://svnweb.freebsd.org/changeset/base/364935 Log: vm_pageout_scan_active: ensure ps_delta is initialized Reported by: Coverity Reviewed by: markj MFC after:2 weeks Sponsored by: Dell EMC Isilon

svn commit: r364933 - in head: lib/libmemstat sys/vm

Author: vangyzen Date: Fri Aug 28 19:50:40 2020 New Revision: 364933 URL: https://svnweb.freebsd.org/changeset/base/364933 Log: memstat_kvm_uma: fix reading of uma_zone_domain structures Coverity flagged the scaling by sizeof(uzd). That is the type of the pointer, so the scaling was

svn commit: r364462 - head/sys/dev/ixgbe

Author: vangyzen Date: Fri Aug 21 19:34:41 2020 New Revision: 364462 URL: https://svnweb.freebsd.org/changeset/base/364462 Log: ixgbe: fix impossible condition Coverity flagged this condition: The condition offset == 0 && offset == 65535 can never be true because offset cannot be

svn commit: r364457 - head/sys/amd64/amd64

Author: vangyzen Date: Fri Aug 21 14:22:32 2020 New Revision: 364457 URL: https://svnweb.freebsd.org/changeset/base/364457 Log: amd64 pmap: potential integer overflowing expression Coverity has identified the line in this change as "Potential integer overflowing expression" due to the

svn commit: r363867 - head/lib/libdevinfo

Author: vangyzen Date: Tue Aug 4 21:09:36 2020 New Revision: 363867 URL: https://svnweb.freebsd.org/changeset/base/363867 Log: devinfo: add man page links Add man page links for all functions in devinfo(3). Reported by: vim MFC after:2 weeks Sponsored by: Dell EMC Isilon

svn commit: r363866 - head/lib/libdevinfo

Author: vangyzen Date: Tue Aug 4 21:05:53 2020 New Revision: 363866 URL: https://svnweb.freebsd.org/changeset/base/363866 Log: devinfo: fix memory leak on error paths Refactor to create devinfo_free_dev(). Call it to plug a memory leak on two error paths in devinfo_init_devices().

Re: svn commit: r363607 - head/sys/vm

On 7/27/20 9:25 AM, Mark Johnston wrote: + + /* +* We may be attempting to free the page as part of the handling for an +* I/O error, in which case the page was xbusied by a different thread. +*/ + vm_page_xbusy_claim(m); I've just noticed that

svn commit: r363221 - head/contrib/ofed/libibverbs/examples

Author: vangyzen Date: Wed Jul 15 13:26:15 2020 New Revision: 363221 URL: https://svnweb.freebsd.org/changeset/base/363221 Log: Fix style in r363220 Apply the style change Kostik suggested in the review. Reported by: kib MFC after:2 weeks X-MFC with: r363220 Sponsored by:

svn commit: r363220 - in head/contrib/ofed: infiniband-diags/src libibumad libibverbs libibverbs/examples libmlx5 librdmacm/examples opensm/opensm

Author: vangyzen Date: Wed Jul 15 13:17:16 2020 New Revision: 363220 URL: https://svnweb.freebsd.org/changeset/base/363220 Log: Fix Coverity issues in OFED read_ibdiag_config NULL deref read_ibdiag_config mem leak ib_mad_inv_field_str Missing comma in a string array initialization

Re: svn commit: r362681 - in head: contrib/bc contrib/bc/gen contrib/bc/include contrib/bc/locales contrib/bc/manuals contrib/bc/src contrib/bc/src/bc contrib/bc/src/dc contrib/bc/src/history contrib/

On 6/27/20 8:11 AM, John Baldwin wrote: On 6/27/20 5:02 AM, Stefan Eßer wrote: Author: se Date: Sat Jun 27 12:02:01 2020 New Revision: 362681 URL: https://svnweb.freebsd.org/changeset/base/362681 Log: Import new 2-clause BSD licenced implementation of the bc and dc commands Hmm, I didn't

svn commit: r362126 - head/sys/vm

Author: vangyzen Date: Fri Jun 12 21:53:08 2020 New Revision: 362126 URL: https://svnweb.freebsd.org/changeset/base/362126 Log: Honor db_pager_quit in some vm_object ddb commands These can be rather verbose. MFC after:2 weeks Sponsored by: Dell EMC Isilon Modified:

svn commit: r362121 - in head/sys: amd64/amd64 i386/i386

Author: vangyzen Date: Fri Jun 12 21:17:56 2020 New Revision: 362121 URL: https://svnweb.freebsd.org/changeset/base/362121 Log: FPU init: allocate initial state from UMA to ensure alignment The Intel Instruction Set Reference says this about the XSAVE instruction: Use of a

svn commit: r362120 - in head/sys: amd64/amd64 i386/i386

Author: vangyzen Date: Fri Jun 12 21:12:26 2020 New Revision: 362120 URL: https://svnweb.freebsd.org/changeset/base/362120 Log: FPU: make xsave_area_desc static ...because it can be. Reviewed by: cem kib MFC after:2 weeks Sponsored by: Dell EMC Isilon Differential Revision:

svn commit: r362119 - in head/sys: amd64/amd64 i386/i386

Author: vangyzen Date: Fri Jun 12 21:10:45 2020 New Revision: 362119 URL: https://svnweb.freebsd.org/changeset/base/362119 Log: FPU init: Do potentially blocking operations before disabling interrupts In particular, uma_zcreate creates sysctl oids, which locks an sx lock, which uses IPIs

Re: svn commit: r361699 - head/sys/kern

void vfs_oexport_conv(const struct oexport_args *oexp, struct export_args *exp) { bcopy(oexp, exp, sizeof(*oexp)); - exp->ex_numsecflavors = 0; + if (exp->ex_flags & MNT_EXPORTED) { + exp->ex_numsecflavors = 1; + exp->ex_secflavors[0] =

Re: svn commit: r360964 - in head: lib/libclang_rt lib/libthr lib/msun libexec/rtld-elf libexec/tftpd/tests share/mk stand stand/arm/uboot stand/efi stand/efi/boot1 stand/efi/loader stand/i386/boot2 s

On 5/25/20 3:37 AM, Tijl Coosemans wrote: On Tue, 12 May 2020 15:22:41 + (UTC) Eric van Gyzen wrote: Author: vangyzen Date: Tue May 12 15:22:40 2020 New Revision: 360964 URL: https://svnweb.freebsd.org/changeset/base/360964 Log: Remove tests for obsolete compilers in the build system

svn commit: r361606 - head

Author: vangyzen Date: Thu May 28 22:05:33 2020 New Revision: 361606 URL: https://svnweb.freebsd.org/changeset/base/361606 Log: Add an UPDATING entry for r360964 Reported by: rpokala Sponsored by: Dell EMC Isilon Modified: head/UPDATING Modified: head/UPDATING

svn commit: r361605 - head/share/mk

Author: vangyzen Date: Thu May 28 21:56:31 2020 New Revision: 361605 URL: https://svnweb.freebsd.org/changeset/base/361605 Log: Revert part of r360964 ports/devel/linux_libusb builds FreeBSD libusb with GCC 4.8.5 from devel/linux-c7-devtools. Restore the tests for older GCC in

svn commit: r361559 - head/lib/libifconfig

Author: vangyzen Date: Wed May 27 18:26:10 2020 New Revision: 361559 URL: https://svnweb.freebsd.org/changeset/base/361559 Log: libifconfig: remove redundant NULL check Submitted by: puneeth_kumar.jotha...@emc.com Reported by: Coverity Sponsored by: Dell EMC Isilon Modified:

Re: svn commit: r360964 - in head: lib/libclang_rt lib/libthr lib/msun libexec/rtld-elf libexec/tftpd/tests share/mk stand stand/arm/uboot stand/efi stand/efi/boot1 stand/efi/loader stand/i386/boot2 s

> Why is this marked for MFC? FreeBSD 12 uses base GCC 4.2.1 on some platforms. You’re right, this won’t be MFC’d. My client is configured to add the MFC by default, and I failed to remove it. Eric ___ svn-src-head@freebsd.org mailing list

svn commit: r360964 - in head: lib/libclang_rt lib/libthr lib/msun libexec/rtld-elf libexec/tftpd/tests share/mk stand stand/arm/uboot stand/efi stand/efi/boot1 stand/efi/loader stand/i386/boot2 st...

Author: vangyzen Date: Tue May 12 15:22:40 2020 New Revision: 360964 URL: https://svnweb.freebsd.org/changeset/base/360964 Log: Remove tests for obsolete compilers in the build system Assume gcc is at least 6.4, the oldest xtoolchain in the ports tree. Assume clang is at least 6, which

svn commit: r360328 - in head/sys: kern sys x86/x86

Author: vangyzen Date: Sun Apr 26 00:41:29 2020 New Revision: 360328 URL: https://svnweb.freebsd.org/changeset/base/360328 Log: Fix handling of NMIs from unknown sources (BMC, hypervisor) Release kernels have no KDB backends enabled, so they discard an NMI if it is not due to a hardware

svn commit: r360233 - in head: contrib/jemalloc contrib/jemalloc/doc contrib/jemalloc/include/jemalloc contrib/jemalloc/include/jemalloc/internal contrib/jemalloc/src lib/libc/stdlib/jemalloc

Author: vangyzen Date: Thu Apr 23 23:57:43 2020 New Revision: 360233 URL: https://svnweb.freebsd.org/changeset/base/360233 Log: Update jemalloc to version 5.2.1 Revert r354606 to restore r354605. Apply one line from jemalloc commit d01b425e5d1e1 in hash_x86_128() to fix the build

Re: svn commit: r360068 - in head/sys: kern net sys

+ sz = asprintf(, M_TEMP, "%s-%s-%s", uuid, if_name(ifp), + jailname); + if (sz < 0) { + /* Fall back to a random mac address. */ I was wondering if it would be valuable to give this fall back something like: printf("%s: unable to create fixed

svn commit: r358594 - head/sbin/dumpon

Author: vangyzen Date: Tue Mar 3 22:14:23 2020 New Revision: 358594 URL: https://svnweb.freebsd.org/changeset/base/358594 Log: dumpon: skip size check if using zstd As with gzip, let the dump device be smaller than physical memory when using zstd and full dumps. Also print the

svn commit: r358187 - head/sys/kern

Author: vangyzen Date: Thu Feb 20 23:53:48 2020 New Revision: 358187 URL: https://svnweb.freebsd.org/changeset/base/358187 Log: clamp kernel dump compression level when using gzip If the configured compression level for kernel dumps it outside the supported range, clamp it to the closest

svn commit: r358186 - head/lib/libc/sys

Author: vangyzen Date: Thu Feb 20 23:47:09 2020 New Revision: 358186 URL: https://svnweb.freebsd.org/changeset/base/358186 Log: truncate(2): extending the file is required by POSIX 2008 Update the man page to mention that extending a file with truncate(2) is required by POSIX as of 2008.

svn commit: r356709 - head/usr.sbin/fstyp

Author: vangyzen Date: Mon Jan 13 22:36:29 2020 New Revision: 356709 URL: https://svnweb.freebsd.org/changeset/base/356709 Log: fstyp hammer2: remove dead code best_i will always be >= 0, so remove code to test otherwise. Reported by: Coverity CID: 1412244 MFC after:

svn commit: r356708 - head/usr.sbin/fstyp

Author: vangyzen Date: Mon Jan 13 22:33:48 2020 New Revision: 356708 URL: https://svnweb.freebsd.org/changeset/base/356708 Log: fstyp hammer: use strlcpy Use strlcpy to guarantee NUL termination. Due to this, there is no need for strncmp; simply use strcmp. Reported by: Coverity

svn commit: r356706 - head/sbin/savecore

Author: vangyzen Date: Mon Jan 13 22:01:37 2020 New Revision: 356706 URL: https://svnweb.freebsd.org/changeset/base/356706 Log: savecore: include time zone in info.N file This helps with event correlation when machines are distributed across multiple time zones. Format the time with

svn commit: r356705 - head/sys/fs/nfs

Author: vangyzen Date: Mon Jan 13 21:49:27 2020 New Revision: 356705 URL: https://svnweb.freebsd.org/changeset/base/356705 Log: Add missing comma in nfsv4_errstr Reported by: Coverity CID: 1412243 Sponsored by: Dell EMC Isilon Modified: head/sys/fs/nfs/nfsv4_errstr.h

svn commit: r355593 - head/sbin/fsck_ffs

Author: vangyzen Date: Tue Dec 10 20:04:08 2019 New Revision: 355593 URL: https://svnweb.freebsd.org/changeset/base/355593 Log: fsck_ffs: fix some memory leaks found by Coverity. Reported by: Coverity CID: 1380549 1380550 1380551 MFC after:1 week Sponsored by: Dell EMC

Re: svn commit: r355436 - in head/sys: amd64/amd64 x86/x86

> On Dec 6, 2019, at 4:36 AM, Ed Maste wrote: > > On Thu, 5 Dec 2019 at 21:43, Scott Long wrote: >> >> Author: scottl >> Date: Fri Dec 6 02:43:05 2019 >> New Revision: 355436 >> URL: https://svnweb.freebsd.org/changeset/base/355436 >> >> Log: >> Move the mds, irbs, and ssb mitigation

svn commit: r354624 - head/usr.bin/tip/tip

Author: vangyzen Date: Mon Nov 11 17:41:52 2019 New Revision: 354624 URL: https://svnweb.freebsd.org/changeset/base/354624 Log: tip/cu: check for EOF on input on the local side If cu reads an EOF on the input side, it goes into a tight loop sending a garbage byte to the remote. With

svn commit: r354548 - in head/sys: amd64/amd64 i386/i386

Author: vangyzen Date: Fri Nov 8 16:30:55 2019 New Revision: 354548 URL: https://svnweb.freebsd.org/changeset/base/354548 Log: vmm: pass M_WAITOK to uma_zalloc when allocating FPU save area Submitted by: patrick.sulliv...@dell.com Reviewed by: markj MFC after:2 weeks Sponsored

svn commit: r353448 - head/tests/sys/kern

Author: vangyzen Date: Fri Oct 11 21:23:46 2019 New Revision: 353448 URL: https://svnweb.freebsd.org/changeset/base/353448 Log: coredump_phnum_test: handle full file system gracefully Skip the test if the file system is full. That's out of scope of this test. MFC after:1 week

svn commit: r353344 - head/sys/dev/ioat

Author: vangyzen Date: Wed Oct 9 12:14:10 2019 New Revision: 353344 URL: https://svnweb.freebsd.org/changeset/base/353344 Log: Add CTLFLAG_STATS to the dev.ioat.N.stats sysctl OIDs Refer to r353111. MFC after:2 weeks Sponsored by: Dell EMC Isilon Modified:

svn commit: r353305 - head/tests/sys/kern

Author: vangyzen Date: Tue Oct 8 13:43:05 2019 New Revision: 353305 URL: https://svnweb.freebsd.org/changeset/base/353305 Log: Fix problems in the kern_maxfiles__increase test ATF functions such as ATF_REQUIRE do not work correctly in child processes. Use plain C functions to report

svn commit: r353114 - head/sys/x86/x86

Author: vangyzen Date: Fri Oct 4 21:46:11 2019 New Revision: 353114 URL: https://svnweb.freebsd.org/changeset/base/353114 Log: Make the hw.intrs sysctl OID read-only The handler ignores the new value, so make the OID read-only. I found this while working on r353111. MFC after:

svn commit: r353113 - head/sys/ufs/ffs

Author: vangyzen Date: Fri Oct 4 21:44:52 2019 New Revision: 353113 URL: https://svnweb.freebsd.org/changeset/base/353113 Log: Add CTLFLAG_STATS to several debug.softdep sysctl OIDs Refer to r353111. MFC after:2 weeks Sponsored by: Dell EMC Isilon Modified:

svn commit: r353112 - head/sys/kern

Author: vangyzen Date: Fri Oct 4 21:43:43 2019 New Revision: 353112 URL: https://svnweb.freebsd.org/changeset/base/353112 Log: Add CTLFLAG_STATS to some vfs sysctl OIDs Add CTLFLAG_STATS to the following OIDs: vfs.altbufferflushes vfs.recursiveflushes vfs.barrierwrites

svn commit: r353111 - head/sys/sys

Author: vangyzen Date: Fri Oct 4 21:39:11 2019 New Revision: 353111 URL: https://svnweb.freebsd.org/changeset/base/353111 Log: Add CTLFLAG_STATS to all COUNTER_U64* sysctl OIDs CTLFLAG_STATS identifies a sysctl OID as statistical or informational, as opposed to a configurable/tunable

svn commit: r352898 - head/tests/sys/kern

Author: vangyzen Date: Mon Sep 30 14:05:44 2019 New Revision: 352898 URL: https://svnweb.freebsd.org/changeset/base/352898 Log: Fix coredump_phnum_test when kern.compress_user_cores != 0 If `kern.compress_user_cores` is non-zero, decompress the core file. Use `sysctl -f` to restore

svn commit: r351118 - head/contrib/netbsd-tests/lib/libpthread

Author: vangyzen Date: Fri Aug 16 13:10:08 2019 New Revision: 351118 URL: https://svnweb.freebsd.org/changeset/base/351118 Log: Update pthread_cond_timedwait() test to current NetBSD NetBSD adapted and committed our r350620. Update to their version 1.8. Reviewed by: ngie Obtained

svn commit: r350620 - head/contrib/netbsd-tests/lib/libpthread

Author: vangyzen Date: Mon Aug 5 22:59:35 2019 New Revision: 350620 URL: https://svnweb.freebsd.org/changeset/base/350620 Log: Relax time constraint in pthread_cond_timedwait unit test pthread_cond_timedwait() should wait _at least_ until the timeout, but it might appear to wait longer

svn commit: r350043 - in head: share/man/man5 sys/kern

Author: vangyzen Date: Tue Jul 16 15:51:09 2019 New Revision: 350043 URL: https://svnweb.freebsd.org/changeset/base/350043 Log: Adds signal number format to kern.corefile Add format capability to core file names to include signal that generated the core. This can help various validation

svn commit: r349834 - head/sys/dev/vt

Author: vangyzen Date: Mon Jul 8 13:46:26 2019 New Revision: 349834 URL: https://svnweb.freebsd.org/changeset/base/349834 Log: Ignore kern.vt.splash_cpu without graphics When the system has no graphical console, such as bhyve in common configurations, ignore kern.vt.splash_cpu, instead

svn commit: r349677 - in head: sys/kern tools/test/callout_free

callout_free +SRCS= callout_free.c + +.include Added: head/tools/test/callout_free/callout_free.c == --- /dev/null 00:00:00 1970 (empty, because file is newly added) +++ head/tools/test/callout_free/callout_free.c Wed Jul 3 19:22:44 2019 (r349677) @@ -

svn commit: r349285 - head/sys/dev/virtio/scsi

Author: vangyzen Date: Sat Jun 22 01:20:45 2019 New Revision: 349285 URL: https://svnweb.freebsd.org/changeset/base/349285 Log: VirtIO SCSI: validate seg_max on attach Until r349278, bhyve presented a seg_max to the guest that was too large. Detect this case and clamp it to the

svn commit: r349278 - head/usr.sbin/bhyve

Author: vangyzen Date: Fri Jun 21 18:57:33 2019 New Revision: 349278 URL: https://svnweb.freebsd.org/changeset/base/349278 Log: bhyve: Fix vtscsi maximum segment config The seg_max value reported to the guest should be two less than the host's maximum, in order to leave room for the

Re: svn commit: r344567 - in head: etc/mtree include sbin sbin/veriexec

> On Feb 26, 2019, at 10:17 PM, Warner Losh wrote: > > > > On Tue, Feb 26, 2019, 6:50 AM Alexey Dokuchaev > wrote: > On Mon, Feb 25, 2019 at 10:19:45PM -0800, Rodney W. Grimes wrote: > > > Author: sjg > > > Date: Tue Feb 26 06:17:23 2019 > > > New Revision: 344567 >

svn commit: r343672 - head/libexec/rtld-elf/i386

Author: vangyzen Date: Fri Feb 1 23:16:59 2019 New Revision: 343672 URL: https://svnweb.freebsd.org/changeset/base/343672 Log: rtld: pacify -Wmaybe-uninitialized from gcc6 Sponsored by: Dell EMC Isilon Modified: head/libexec/rtld-elf/i386/reloc.c Modified:

svn commit: r343671 - head/lib/msun

Author: vangyzen Date: Fri Feb 1 23:15:54 2019 New Revision: 343671 URL: https://svnweb.freebsd.org/changeset/base/343671 Log: libm: squelch -Woverflow from gcc6 Sponsored by: Dell EMC Isilon Modified: head/lib/msun/Makefile Modified: head/lib/msun/Makefile

svn commit: r341508 - in head/sys: conf net/altq

Author: vangyzen Date: Tue Dec 4 23:53:42 2018 New Revision: 341508 URL: https://svnweb.freebsd.org/changeset/base/341508 Log: altq: manual cleanup after r341507 Remove a file that became practically empty. Fix indentation. Like r341507, I do not plan to MFC, but anyone else can.

svn commit: r341507 - head/sys/net/altq

Author: vangyzen Date: Tue Dec 4 23:46:43 2018 New Revision: 341507 URL: https://svnweb.freebsd.org/changeset/base/341507 Log: altq: remove ALTQ3_COMPAT code This code has apparently never compiled on FreeBSD since its introduction in 2004 (r130365). It has certainly not compiled

svn commit: r341354 - head/tests/sys/kern

Author: vangyzen Date: Fri Nov 30 23:47:57 2018 New Revision: 341354 URL: https://svnweb.freebsd.org/changeset/base/341354 Log: Maybe make gcc happy According to Jenkins, the GCC architectures were unhappy because: sigaltstack.c:82: warning: missing initializer

svn commit: r341353 - in head: sys/arm/arm sys/arm64/arm64 sys/riscv/riscv tests/sys/kern

sys_getrandom ATF_TESTS_C+= unix_passfd_test Added: head/tests/sys/kern/sigaltstack.c == --- /dev/null 00:00:00 1970 (empty, because file is newly added) +++ head/tests/sys/kern/sigaltstack.c Fri Nov 30 22:44:33 2018 (r341353) @@ -0,0 +1,115 @@ +/*- + * SPDX-License-I

svn commit: r341282 - in head/sys: kern vm

Author: vangyzen Date: Fri Nov 30 04:59:43 2018 New Revision: 341282 URL: https://svnweb.freebsd.org/changeset/base/341282 Log: Include path for tmpfs objects in vm.objects sysctl This applies the fix in r283924 to the vm.objects sysctl added by r283624 so the output will include the

svn commit: r341281 - head/sys/vm

Author: vangyzen Date: Fri Nov 30 04:18:31 2018 New Revision: 341281 URL: https://svnweb.freebsd.org/changeset/base/341281 Log: Add assertions and comment to vm_object_vnode() Reviewed by: kib MFC after:2 weeks Sponsored by: Dell EMC Isilon Differential Revision:

svn commit: r341278 - head/lib/libthr/thread

Author: vangyzen Date: Fri Nov 30 03:02:49 2018 New Revision: 341278 URL: https://svnweb.freebsd.org/changeset/base/341278 Log: Use _thr_isthreaded() and _thr_setthreaded() wrappers ...instead of directly using the global variable. MFC after:2 weeks Sponsored by: Dell EMC Isilon

svn commit: r341277 - head/lib/libthr/thread

Author: vangyzen Date: Fri Nov 30 03:01:32 2018 New Revision: 341277 URL: https://svnweb.freebsd.org/changeset/base/341277 Log: _thr_setthreaded() cannot fail; change return type to void Also remove logic to avoid unnecessary stores to the global variable. Thread creation and destruction

svn commit: r340996 - in head/sys: amd64/amd64 amd64/ia32 i386/i386 kern

Author: vangyzen Date: Mon Nov 26 20:56:05 2018 New Revision: 340996 URL: https://svnweb.freebsd.org/changeset/base/340996 Log: Remove superfluous bzero in getcontext/swapcontext/sendsig We zero the whole structure; we don't need to zero the __spare__ field again. Remove trailing

svn commit: r340995 - in head/sys: arm/arm arm64/arm64 riscv/riscv

Author: vangyzen Date: Mon Nov 26 20:52:53 2018 New Revision: 340995 URL: https://svnweb.freebsd.org/changeset/base/340995 Log: Prevent kernel stack disclosure in signal delivery On arm64 and riscv platforms, sendsig() failed to zero the signal frame before copying it out to userspace.

svn commit: r340994 - in head/sys: amd64/ia32 mips/mips powerpc/powerpc

Author: vangyzen Date: Mon Nov 26 20:50:55 2018 New Revision: 340994 URL: https://svnweb.freebsd.org/changeset/base/340994 Log: Prevent kernel stack disclosure in getcontext/swapcontext Expand r338982 to cover freebsd32 interfaces on amd64, mips, and powerpc. MFC after:2 days

svn commit: r340409 - head/sys/kern

Author: vangyzen Date: Tue Nov 13 20:48:05 2018 New Revision: 340409 URL: https://svnweb.freebsd.org/changeset/base/340409 Log: Make no assertions about lock state when the scheduler is stopped. Change the assert paths in rm, rw, and sx locks to match the lock and unlock paths. I did

svn commit: r340345 - head/usr.sbin/periodic/etc/daily

Author: vangyzen Date: Sun Nov 11 00:39:20 2018 New Revision: 340345 URL: https://svnweb.freebsd.org/changeset/base/340345 Log: Fix daily mailq script for Postfix and daily_show_success="NO" Exit with a zero status when Postfix reports "Mail queue is empty" so this section won't appear

svn commit: r340328 - head

Author: vangyzen Date: Sat Nov 10 19:09:48 2018 New Revision: 340328 URL: https://svnweb.freebsd.org/changeset/base/340328 Log: Update comment about 'universe' disk usage It's 167 GB now (or 81 GB with ZFS lz4). MFC after:2 weeks Sponsored by: Dell EMC Isilon Modified:

svn commit: r340257 - head/sys/netinet6

Author: vangyzen Date: Thu Nov 8 19:50:23 2018 New Revision: 340257 URL: https://svnweb.freebsd.org/changeset/base/340257 Log: in6_ifattach_linklocal: handle immediate removal of the new LLA If another thread immediately removes the link-local address added by in6_update_ifa(),

svn commit: r340127 - in head: contrib/expat contrib/expat/doc contrib/expat/examples contrib/expat/lib contrib/expat/tests contrib/expat/tests/benchmark contrib/expat/xmlwf lib/libexpat

Author: vangyzen Date: Sun Nov 4 16:08:59 2018 New Revision: 340127 URL: https://svnweb.freebsd.org/changeset/base/340127 Log: Update expat to 2.2.6 Update contrib/expat by merging from the vendor branch. Update expat_config.h manually, using make -C /usr/ports/textproc/expat2

svn commit: r339917 - head/sys/kern

Author: vangyzen Date: Tue Oct 30 14:54:15 2018 New Revision: 339917 URL: https://svnweb.freebsd.org/changeset/base/339917 Log: Always stop the scheduler when entering kdb Set curthread->td_stopsched when entering kdb via any vector. Previously, it was only set when entering via panic,

svn commit: r339225 - head/sys/dev/e1000

Author: vangyzen Date: Mon Oct 8 01:28:46 2018 New Revision: 339225 URL: https://svnweb.freebsd.org/changeset/base/339225 Log: em/igb: Do not print link state messages These messages are totally redundant with the iflib messages. They're also not very useful, since they don't include

Re: svn commit: r338829 - head/sys/kern

On 9/20/18 8:32 AM, Mateusz Guzik wrote: fd: prevent inlining of _fdrop thorough kern_descrip.c fdrop is used in several places in the file and almost never has to call _fdrop. Thus inlining it is a pure waste of space. -int +int __noinline _fdrop(struct file *fp, struct

svn commit: r338688 - head/sbin/reboot

Author: vangyzen Date: Fri Sep 14 18:12:30 2018 New Revision: 338688 URL: https://svnweb.freebsd.org/changeset/base/338688 Log: Fix "fasthalt" to halt instead of reboot fasthalt has behaved like reboot, instead of like halt, since r228408 (2011, 10.0-RELEASE). Fix it. One wonders if

svn commit: r338656 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

Author: vangyzen Date: Thu Sep 13 17:56:48 2018 New Revision: 338656 URL: https://svnweb.freebsd.org/changeset/base/338656 Log: Set zfs_arc_meta_strategy to metadata only The previous default of "balanced" appears to have caused pathological behavior, including very poor performance and

svn commit: r335206 - head/cddl/contrib/opensolaris/cmd/zfs

Author: vangyzen Date: Fri Jun 15 15:28:31 2018 New Revision: 335206 URL: https://svnweb.freebsd.org/changeset/base/335206 Log: Fix markup in zfs(8); no content change Sponsored by: Dell EMC Modified: head/cddl/contrib/opensolaris/cmd/zfs/zfs.8 Modified:

Re: svn commit: r334669 - head/sys/sys

On 06/05/2018 15:53, Ian Lepore wrote: > On Tue, 2018-06-05 at 20:34 +0000, Eric van Gyzen wrote: >> Author: vangyzen >> Date: Tue Jun  5 20:34:11 2018 >> New Revision: 334669 >> URL: https://svnweb.freebsd.org/changeset/base/334669 >> >> Log: >

svn commit: r334669 - head/sys/sys

Author: vangyzen Date: Tue Jun 5 20:34:11 2018 New Revision: 334669 URL: https://svnweb.freebsd.org/changeset/base/334669 Log: Make Coverity more happy with r334545 Coverity complains about: if (((flags) & M_WAITOK) || _malloc_item != NULL) saying: The

Re: svn commit: r334545 - in head/sys: contrib/zstd/lib/freebsd kern netinet/libalias sys

On 06/02/2018 17:20, Mateusz Guzik wrote: > +#ifdef _KERNEL > +#define malloc(size, type, flags) ({\ > + void *_malloc_item; \ > + size_t _size = (size); \ > + if

svn commit: r334351 - head/lib/libpmc

Author: vangyzen Date: Tue May 29 20:30:46 2018 New Revision: 334351 URL: https://svnweb.freebsd.org/changeset/base/334351 Log: pmc_annotate: adhere to the API If the 'mode' parameter was invalid, pmc_annotate() would return EINVAL instead of setting errno and returning -1.

Re: svn commit: r334347 - head/lib/libpmc

On 05/29/2018 14:07, Matt Macy wrote: > if (pmc_pmu_pmcallocate(ctrname, _config) == 0) { > - if (PMC_CALL(PMCALLOCATE, _config) < 0) > - return (errno); > - free(spec_copy); > + if (PMC_CALL(PMCALLOCATE, _config) < 0) { > +

Re: svn commit: r334345 - head/lib/libpmc

On 05/29/2018 13:26, Matt Macy wrote: > if (pmc_pmu_pmcallocate(ctrname, _config) == 0) { > if (PMC_CALL(PMCALLOCATE, _config) < 0) > return (errno); ^^ spec_copy is still leaked here. > + free(spec_copy); >

svn commit: r334308 - in head: lib/libc/stdlib share/man/man3

Author: vangyzen Date: Tue May 29 02:41:32 2018 New Revision: 334308 URL: https://svnweb.freebsd.org/changeset/base/334308 Log: Bump the date on man pages in r334306 It seems a shame to ruin the patina of the June 4, 1993 date on abort.3, especially since it still matched the date of

svn commit: r334306 - in head: lib/libc/stdlib share/man/man3

Author: vangyzen Date: Tue May 29 01:16:00 2018 New Revision: 334306 URL: https://svnweb.freebsd.org/changeset/base/334306 Log: Cross-reference abort2(2) from a few man pages I didn't know abort2 existed until it was mentioned on a mailing list. Mention it in related pages so others can

svn commit: r334273 - head/sys/cam/nvme

Author: vangyzen Date: Mon May 28 03:14:36 2018 New Revision: 334273 URL: https://svnweb.freebsd.org/changeset/base/334273 Log: cam nvme: fix array overrun Fix a classic array overrun where the index could be one past the end. Reported by: Coverity CID: 1356596 MFC

  1   2   3   >