Author: jh
Date: Sun Apr 6 16:35:49 2014
New Revision: 264194
URL: http://svnweb.freebsd.org/changeset/base/264194
Log:
Fork a child process and wait until the process terminates when the -P
option is specified. This behavior is documented on the manual page.
PR: bin/187265
Hi,
On 2014-04-03, Greg Lehey wrote:
Add information on standards compliance of many options.
-n and -A are in POSIX.1-2008. Please see this PR:
http://www.freebsd.org/cgi/query-pr.cgi?pr=docs/140435
--
Jaakko
___
Author: jh
Date: Fri Jul 12 06:03:25 2013
New Revision: 253252
URL: http://svnweb.freebsd.org/changeset/base/253252
Log:
Clarify how hide and unhide commands work on directories.
Modified:
head/sbin/devfs/devfs.8
Modified: head/sbin/devfs/devfs.8
Author: jh
Date: Sun Jun 9 08:06:26 2013
New Revision: 251565
URL: http://svnweb.freebsd.org/changeset/base/251565
Log:
Print file names without stdio buffering to avoid mixing buffered and
unbuffered ouput.
PR: bin/176886
Reviewed by: mjg
Modified:
Author: jh
Date: Fri Jun 7 07:17:46 2013
New Revision: 251485
URL: http://svnweb.freebsd.org/changeset/base/251485
Log:
Revert r238399.
The failok option doesn't have any effect at all unless specified in
fstab(5) and combined with the -a flag. The failok option is already
documented
Author: jh
Date: Tue May 21 18:40:54 2013
New Revision: 250868
URL: http://svnweb.freebsd.org/changeset/base/250868
Log:
Remove an extra semicolon from the DOT language output.
PR: kern/178540
Submitted by: Trond Endrestol
MFC after:1 week
Modified:
Author: jh
Date: Thu May 16 18:13:10 2013
New Revision: 250706
URL: http://svnweb.freebsd.org/changeset/base/250706
Log:
A library function shall not set errno to 0.
Reviewed by: mdf
Modified:
head/sys/kern/subr_sbuf.c
Modified: head/sys/kern/subr_sbuf.c
Author: jh
Date: Wed May 15 18:41:49 2013
New Revision: 250667
URL: http://svnweb.freebsd.org/changeset/base/250667
Log:
Rename O_DIRECTORY to O_TMP_DIRECTORY to avoid shadowing the fcntl.h
O_DIRECTORY flag.
PR: bin/173924
Obtained from:git://repo.or.cz/nvi.git
Author: jh
Date: Fri May 10 09:58:32 2013
New Revision: 250443
URL: http://svnweb.freebsd.org/changeset/base/250443
Log:
Check the return value of sbuf_finish().
MFC after:1 week
Modified:
head/usr.sbin/ctladm/ctladm.c
Modified: head/usr.sbin/ctladm/ctladm.c
Author: jh
Date: Fri Apr 19 15:19:29 2013
New Revision: 249650
URL: http://svnweb.freebsd.org/changeset/base/249650
Log:
Include PID in the error message which is printed when the maxproc limit
is exceeded. Improve formatting of the message while here.
PR: kern/60550
On 2013-04-15, Ivan Voras wrote:
Introduce glabel labels based on GEOM ident attributes. In this initial
implementation, error on the side of conservatism and only create labels
for GEOMs of classes DISK and MULTIPATH.
After this commit I get a panic on boot. My kernel has been compiled
Author: jh
Date: Sat Apr 6 13:42:37 2013
New Revision: 249200
URL: http://svnweb.freebsd.org/changeset/base/249200
Log:
Correct the path.
PR: 176256
Submitted by: jhs
Modified:
head/usr.bin/calendar/calendar.1
Modified: head/usr.bin/calendar/calendar.1
Hi,
On 2013-03-21, Martin Matuska wrote:
Merge libzfs_core branch:
includes MFV 238590, 238592, 247580
I am getting the following error after this commit:
# zpool list
failed to read pool configuration: bad address
no pools available
# zfs list
failed to read pool configuration: bad
Author: jh
Date: Thu Jan 24 17:28:39 2013
New Revision: 245891
URL: http://svnweb.freebsd.org/changeset/base/245891
Log:
Sanitize the element descriptor string before using it as a device name.
Reported and tested by: Vitalij Satanivskij
Reviewed by: gibbs, mav
Modified:
On 2013-01-09, Warner Losh wrote:
I do not object, but IMHO having names with the spaces in /dev is weird
and possibly problematic.
I agree and my my preference was also to disallow spaces. However I
expected that someone might complain.
This was the reason of my initial request to
On 2013-01-07, John Baldwin wrote:
I think if it isn't hard to do so, we should aim to preserve labels as they
are generally intended to be human readable as-is. Just preserving spaces is
probably sufficient for this as they are probably the most commonly used
character in labels affected
Author: jh
Date: Sat Dec 22 13:33:28 2012
New Revision: 244584
URL: http://svnweb.freebsd.org/changeset/base/244584
Log:
Reject spaces and double quotation marks in device names. devctl(4)
and devd(8) can't handle names with such characters properly.
PR: bin/144736, kern/161912
Author: jh
Date: Sat Dec 22 13:43:12 2012
New Revision: 244585
URL: http://svnweb.freebsd.org/changeset/base/244585
Log:
Mangle label names containing spaces, non-printable characters '%' or
''. Mangling is only done for label names read from file system
metadata. Encoding resembles URL
Author: jh
Date: Wed Nov 21 16:56:47 2012
New Revision: 243372
URL: http://svnweb.freebsd.org/changeset/base/243372
Log:
Disallow attaching preloaded memory disks via ioctl.
- The feature is dangerous because the kernel code didn't check
validity of the memory address provided from
Author: jh
Date: Wed Nov 21 17:05:57 2012
New Revision: 243373
URL: http://svnweb.freebsd.org/changeset/base/243373
Log:
Print correct unit number when attaching preloaded memory disks.
Retire now unused mdunits variable.
Modified:
head/sys/dev/md/md.c
Modified: head/sys/dev/md/md.c
Hi!
On 2012-11-20, Baptiste Daroussin wrote:
change mode the group file to 0644 after a successfull rename(2)
int
gr_mkdb(void)
{
- return (rename(tempname, group_file));
+ int ret;
+
+ ret = rename(tempname, group_file);
+
+ if (ret == 0)
+
Author: jh
Date: Tue Nov 20 12:32:18 2012
New Revision: 24
URL: http://svnweb.freebsd.org/changeset/base/24
Log:
- Don't pass geom and provider names as format strings.
- Add __printflike() attributes.
- Remove an extra argument for the g_new_geomf() call in swapongeom_ev().
On 2012-11-20, Baptiste Daroussin wrote:
Does this looks better to you?
http://people.freebsd.org/~bapt/gr_util.diff
Yes. Thank you.
--
Jaakko
___
svn-src-head@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-head
To
On 2012-11-08, Greg Lehey wrote:
New Revision: 242725
- return (strcoll(a-fts_name, b-fts_name));
+if (f_samesort)
+ return (strcoll(b-fts_name, a-fts_name));
+else
+ return (strcoll(a-fts_name, b-fts_name));
Please use tabs instead of spaces in
Author: jh
Date: Sat Nov 3 09:18:37 2012
New Revision: 242511
URL: http://svn.freebsd.org/changeset/base/242511
Log:
Print a newline after the error message.
PR: bin/168447
Submitted by: Boris Kochergin
Modified:
head/sbin/fsck_msdosfs/check.c
Modified:
Author: jh
Date: Fri Oct 26 12:46:33 2012
New Revision: 242130
URL: http://svn.freebsd.org/changeset/base/242130
Log:
Improve libgeom XML parsing error handling.
- Abort parsing and return an error if we run out of memory.
- Return EILSEQ from geom_xml2tree() for XML syntax errors.
Author: jh
Date: Thu Aug 23 16:25:36 2012
New Revision: 239612
URL: http://svn.freebsd.org/changeset/base/239612
Log:
Check the return value of sbuf_finish().
Modified:
head/sbin/camcontrol/camcontrol.c
Modified: head/sbin/camcontrol/camcontrol.c
Author: jh
Date: Tue Aug 14 19:16:30 2012
New Revision: 239257
URL: http://svn.freebsd.org/changeset/base/239257
Log:
Reserve room for the terminating NUL when setting or getting kernel
environment variables. KENV_MNAMELEN and KENV_MVALLEN doesn't include
space for the terminating NUL.
Author: jh
Date: Thu Aug 2 15:05:34 2012
New Revision: 238991
URL: http://svn.freebsd.org/changeset/base/238991
Log:
Disallow sectorsize larger than MAXPHYS and mediasize smaller than
sectorsize.
PR: 169947
Submitted by: Filip Palian (original version)
Reviewed by: kib
Author: jh
Date: Fri Jul 20 08:31:36 2012
New Revision: 238652
URL: http://svn.freebsd.org/changeset/base/238652
Log:
style(9).
Modified:
head/bin/cat/cat.c
Modified: head/bin/cat/cat.c
==
--- head/bin/cat/cat.c
Author: jh
Date: Fri Jul 20 08:33:23 2012
New Revision: 238653
URL: http://svn.freebsd.org/changeset/base/238653
Log:
Use proper error message when fstat(2) fails on stdout.
PR: bin/159746
Submitted by: Alex K.
Modified:
head/bin/cat/cat.c
Modified: head/bin/cat/cat.c
Author: jh
Date: Tue Jul 17 09:31:05 2012
New Revision: 238546
URL: http://svn.freebsd.org/changeset/base/238546
Log:
Remove trailing whitespace.
MFC after:2 weeks
Modified:
head/usr.sbin/lpr/common_source/common.c
Modified: head/usr.sbin/lpr/common_source/common.c
Author: jh
Date: Tue Jul 17 09:34:52 2012
New Revision: 238547
URL: http://svn.freebsd.org/changeset/base/238547
Log:
Make sure that arraysz is initialized to a value larger than zero.
arraysz could get initialized to zero on ZFS because ZFS reports
directory sizes differently compared to
Author: jh
Date: Fri Apr 20 10:08:30 2012
New Revision: 234489
URL: http://svn.freebsd.org/changeset/base/234489
Log:
The value of flags matching VNOVAL can't be supported. Return EOPNOTSUPP
from setfflags() in this case. This fixes the return value of
chflags(path, -1).
Discussed
Author: jh
Date: Wed Apr 18 15:19:00 2012
New Revision: 234421
URL: http://svn.freebsd.org/changeset/base/234421
Log:
The part about exec atime no longer applies in the comment.
Pointed out by: bde
Modified:
head/sys/ufs/ufs/ufs_vnops.c
Modified: head/sys/ufs/ufs/ufs_vnops.c
Author: jh
Date: Wed Apr 18 15:22:08 2012
New Revision: 234422
URL: http://svn.freebsd.org/changeset/base/234422
Log:
Return EOPNOTSUPP rather than EPERM for the SF_SNAPSHOT flag because
tmpfs doesn't support snapshots.
Suggested by: bde
Modified:
head/sys/fs/tmpfs/tmpfs_subr.c
Author: jh
Date: Mon Apr 16 18:07:42 2012
New Revision: 234346
URL: http://svn.freebsd.org/changeset/base/234346
Log:
tmpfs: Allow update mounts only for certain options.
Since r230208 update mounts were allowed if the list of mount options
contained the export option. This is not
Author: jh
Date: Mon Apr 16 18:10:34 2012
New Revision: 234347
URL: http://svn.freebsd.org/changeset/base/234347
Log:
Sync tmpfs_chflags() with the recent changes to UFS:
- Add a check for unsupported file flags.
- Return EPERM when an user without PRIV_VFS_SYSFLAGS privilege attempts
On 2012-01-23, Mikolaj Golub wrote:
I see two issues with this patch:
What do you think about this patch?
%%%
Index: sys/fs/tmpfs/tmpfs.h
===
--- sys/fs/tmpfs/tmpfs.h(revision 234201)
+++ sys/fs/tmpfs/tmpfs.h
Author: jh
Date: Fri Apr 13 05:40:26 2012
New Revision: 234202
URL: http://svn.freebsd.org/changeset/base/234202
Log:
Additional manual page updates for r234103.
Submitted by: bde
Modified:
head/lib/libc/sys/chflags.2
Modified: head/lib/libc/sys/chflags.2
Author: jh
Date: Fri Apr 13 05:48:31 2012
New Revision: 234203
URL: http://svn.freebsd.org/changeset/base/234203
Log:
Apply changes from r234103 to ext2fs:
Return EPERM from ext2_setattr() when an user without PRIV_VFS_SYSFLAGS
privilege attempts to toggle SF_SETTABLE flags.
Flags
Author: jh
Date: Wed Apr 11 15:48:50 2012
New Revision: 234139
URL: http://svn.freebsd.org/changeset/base/234139
Log:
Restore the blank line incorrectly removed in r234104.
Pointed out by: bde
Modified:
head/sys/fs/ext2fs/ext2_vnops.c
Modified: head/sys/fs/ext2fs/ext2_vnops.c
Author: jh
Date: Tue Apr 10 15:59:37 2012
New Revision: 234103
URL: http://svn.freebsd.org/changeset/base/234103
Log:
- Return EPERM from ufs_setattr() when an user without PRIV_VFS_SYSFLAGS
privilege attempts to toggle SF_SETTABLE flags.
- Use the '^' operator in the SF_SNAPSHOT
Author: jh
Date: Tue Apr 10 16:05:52 2012
New Revision: 234104
URL: http://svn.freebsd.org/changeset/base/234104
Log:
Apply changes from r233787 to ext2fs:
- Use more natural ip-i_flags instead of vap-va_flags in the final
flags check.
- Style improvements.
No functional change
Hi,
On 2012-04-06, Justin T. Gibbs wrote:
Fix interrupt load balancing regression, introduced in revision
222813, that left all un-pinned interrupts assigned to CPU 0.
sys/x86/x86/intr_machdep.c:
In intr_shuffle_irqs(), remove CPU_SETOF() call that initialized
the
On 2012-04-09, John Baldwin wrote:
I suspect in your case intr_add_cpu() is never called. I think Attilio is
not
correct in that it is not called for the BSP.
Yes, it is not called for the BSP in set_interrupt_apic_ids(). This used to
work because bit 0 was assigned statically. Also,
Author: jh
Date: Wed Apr 4 14:50:21 2012
New Revision: 233875
URL: http://svn.freebsd.org/changeset/base/233875
Log:
Add a check for unsupported file flags to ufs_setattr().
Discussed with: bde
MFC after:2 weeks
Modified:
head/sys/ufs/ufs/ufs_vnops.c
Modified:
Author: jh
Date: Mon Apr 2 16:33:21 2012
New Revision: 233787
URL: http://svn.freebsd.org/changeset/base/233787
Log:
- Use more natural ip-i_flags instead of vap-va_flags in the final
flags check.
- Add a comment for the immutable/append check done after handling of
the flags.
-
Author: jh
Date: Wed Mar 14 15:52:23 2012
New Revision: 232975
URL: http://svn.freebsd.org/changeset/base/232975
Log:
Add an assert for proctree_lock to proc_to_reap().
Discussed with: kib
MFC after:1 week
Modified:
head/sys/kern/kern_exit.c
Modified:
Author: jh
Date: Thu Mar 1 18:17:45 2012
New Revision: 232350
URL: http://svn.freebsd.org/changeset/base/232350
Log:
Since r199137 namei() returns EINVAL for DELETE and RENAME operations if
the last component of the pathname is ..
Reviewed by: kib
MFC after:1 week
Modified:
Author: jh
Date: Fri Feb 24 07:49:55 2012
New Revision: 232101
URL: http://svn.freebsd.org/changeset/base/232101
Log:
style(9).
MFC after:2 weeks
Modified:
head/usr.sbin/wake/wake.c
Modified: head/usr.sbin/wake/wake.c
Author: jh
Date: Fri Feb 24 07:54:08 2012
New Revision: 232102
URL: http://svn.freebsd.org/changeset/base/232102
Log:
Exit with proper status when wake() fails.
PR: bin/153527
Submitted by: Douglas Steinwand
MFC after:2 weeks
Modified:
head/usr.sbin/wake/wake.c
Author: jh
Date: Sat Feb 4 13:37:31 2012
New Revision: 230979
URL: http://svn.freebsd.org/changeset/base/230979
Log:
Remove useless and potentially dangerous rw() function which tries to
update access and modification times by reading and writing the file.
chmod(2) in rw() doesn't help
Author: jh
Date: Sat Jan 28 13:41:34 2012
New Revision: 230642
URL: http://svn.freebsd.org/changeset/base/230642
Log:
Remove trailing whitespace.
Modified:
head/sbin/mount_ntfs/mount_ntfs.c
Modified: head/sbin/mount_ntfs/mount_ntfs.c
On 2012-01-23, Mikolaj Golub wrote:
JH Yes, the patch below does that. I suspect that flipping the MNT_RDONLY
JH flag may be enough for tmpfs but I am not sure.
I see two issues with this patch:
1) 'mount -u -o rw /mnt' does not upgrade to rw, although it returns success.
Argh, this is
On 2012-01-22, Mikolaj Golub wrote:
Also, may be we should allow remounting ro (and may be some othe options) for
tmpfs?
Yes, the patch below does that. I suspect that flipping the MNT_RDONLY
flag may be enough for tmpfs but I am not sure.
JH %%%
JH Index: sys/fs/tmpfs/tmpfs_vfsops.c
JH
Hi,
On 2012-01-22, Mikolaj Golub wrote:
JH # mount -u -o ro /mnt
JH mount: tmpfs : Operation not supported
JH # mount -u -o ro,export /mnt
JH #
There is no error but ro is still ignored, so this is only the issue with
reporting. Note, the code for nullfs (as an example) looks the
Author: jh
Date: Fri Jan 20 10:06:28 2012
New Revision: 230373
URL: http://svn.freebsd.org/changeset/base/230373
Log:
Change mount_fs() to not exit on error. The failok mount option
requires that errors are passed to the caller.
PR: 163668
Reviewed by: Garrett Cooper
Author: jh
Date: Fri Jan 20 12:59:12 2012
New Revision: 230377
URL: http://svn.freebsd.org/changeset/base/230377
Log:
Don't print the nmount(2) provided error message if it is empty.
Modified:
head/sbin/mount/mount_fs.c
Modified: head/sbin/mount/mount_fs.c
Author: jh
Date: Fri Jan 20 07:29:29 2012
New Revision: 230372
URL: http://svn.freebsd.org/changeset/base/230372
Log:
- Clean up checkpath().
- Remove unneeded sysexits.h include.
No functional change.
Submitted by: bde
Modified:
head/sbin/mount/getmntopts.c
Modified:
On 2012-01-17, Kevin Lo wrote:
Return EOPNOTSUPP since we only support update mounts for NFS export.
@@ -150,8 +150,12 @@ tmpfs_mount(struct mount *mp)
return (EINVAL);
if (mp-mnt_flag MNT_UPDATE) {
+ /*
+ * Only support update mounts
Author: jh
Date: Mon Jan 16 19:34:21 2012
New Revision: 230226
URL: http://svn.freebsd.org/changeset/base/230226
Log:
Change checkpath() to not exit on error. This is a prerequisite for
fixing the mount(8) failok option.
PR: 163668
Reviewed by: Garrett Cooper, delphij
Author: jh
Date: Fri Jan 6 09:17:34 2012
New Revision: 229692
URL: http://svn.freebsd.org/changeset/base/229692
Log:
Check the return value of sbuf_finish() in pfs_readlink() and return
ENAMETOOLONG if the buffer overflowed.
Approved by: des
MFC after:2 weeks
Modified:
Author: jh
Date: Fri Jan 6 10:12:59 2012
New Revision: 229694
URL: http://svn.freebsd.org/changeset/base/229694
Log:
r222004 changed sbuf_finish() to not clear the buffer error status. As a
consequence sbuf_len() will return -1 for buffers which had the error
status set prior to
Author: jh
Date: Wed Dec 21 17:03:30 2011
New Revision: 228784
URL: http://svn.freebsd.org/changeset/base/228784
Log:
Follow style(9) more closely in the example.
Modified:
head/share/man/man9/sbuf.9
Modified: head/share/man/man9/sbuf.9
Author: jh
Date: Fri Dec 9 13:15:19 2011
New Revision: 228358
URL: http://svn.freebsd.org/changeset/base/228358
Log:
- Fix markup.
- Remove trailing whitespace.
Modified:
head/share/man/man9/sbuf.9
Modified: head/share/man/man9/sbuf.9
Author: jh
Date: Fri Dec 9 13:28:41 2011
New Revision: 228359
URL: http://svn.freebsd.org/changeset/base/228359
Log:
sbuf_data() hasn't returned NULL for overflowed buffers since r71721.
Modified:
head/share/man/man9/sbuf.9
Modified: head/share/man/man9/sbuf.9
Author: jh
Date: Wed Nov 30 20:08:30 2011
New Revision: 228163
URL: http://svn.freebsd.org/changeset/base/228163
Log:
Add an entry for r227823.
Modified:
head/UPDATING
Modified: head/UPDATING
==
--- head/UPDATING
On 2011-11-28, Bjoern A. Zeeb wrote:
static void
if_clone_free(struct if_clone *ifc)
{
- for (int bytoff = 0; bytoff ifc-ifc_bmlen; bytoff++) {
- KASSERT(ifc-ifc_units[bytoff] == 0x00,
- (ifc_units[%d] is not empty, bytoff));
- }
Author: jh
Date: Sun Nov 27 13:53:36 2011
New Revision: 228021
URL: http://svn.freebsd.org/changeset/base/228021
Log:
Add LINT-NOINET LINT-NOINET6 and LINT-NOIP to the make clean target.
This was missed in r221353.
Modified:
head/sys/conf/makeLINT.mk
Modified: head/sys/conf/makeLINT.mk
Author: jh
Date: Tue Nov 22 16:44:50 2011
New Revision: 227823
URL: http://svn.freebsd.org/changeset/base/227823
Log:
Append unit number to the WMI status device name to allow attaching
multiple acpi_wmi(4) instances.
PR: kern/162491
Reviewed by: avg
Modified:
On 2011-10-11, Dag-Erling Smørgrav wrote:
@@ -113,6 +114,8 @@
#define print_number(i,n,c) do { \
if (decimal)\
printf(%c%jd, c, (intmax_t)*i); \
+ else if (sizeof(*i) ==
Hi,
On 2011-10-08, Dag-Erling Smorgrav wrote:
Fix casting.
Modified: head/usr.bin/kdump/kdump.c
==
--- head/usr.bin/kdump/kdump.cSat Oct 8 12:10:16 2011
(r226150)
+++ head/usr.bin/kdump/kdump.c
Author: jh
Date: Thu Sep 15 13:32:43 2011
New Revision: 225587
URL: http://svn.freebsd.org/changeset/base/225587
Log:
Expose log in the default devfs rules. /etc/rc.d/jail creates /dev/log
as a symbolic link.
PR: conf/160711
Submitted by: Jase Thew
Approved by: re (kib)
Author: jh
Date: Fri Sep 2 19:29:37 2011
New Revision: 225353
URL: http://svn.freebsd.org/changeset/base/225353
Log:
Restore behavior of the autoboot_delay=-1 boot menu setting to the
pre-r222417 state. The behavior was essentially reversed in r222417
which can cause confusion.
PR:
Hi,
On 2011-08-11, Robert Watson wrote:
Second-to-last commit implementing Capsicum capabilities in the FreeBSD
kernel for FreeBSD 9.0:
This commit seems to have broken nfsd for me.
Modified: head/sys/fs/nfsserver/nfs_nfsdport.c
On 2011-08-16, Jonathan Anderson wrote:
Fixed in r224911.
Thanks!
On 16 August 2011 14:57, Jonathan Anderson jonat...@freebsd.org wrote:
It looks like r224086 added goto out error handling, so our return
(error) seems to be a merge conflict.
--
Jaakko
Author: jh
Date: Sun Jun 19 08:53:16 2011
New Revision: 223289
URL: http://svn.freebsd.org/changeset/base/223289
Log:
Don't #undef curses ERR in dialog.h. Otherwise, the macro will be
unavailable if curses.h is included before dialog.h.
PR: bin/156601
Obtained from:
Author: jh
Date: Tue Jun 7 16:23:27 2011
New Revision: 222825
URL: http://svn.freebsd.org/changeset/base/222825
Log:
Remove a gratuitous newline. This should be a non-functional change.
PR: bin/153667
Submitted by: Craig Leres
MFC after:1 week
Modified:
Author: jh
Date: Mon Jun 6 13:50:29 2011
New Revision: 222755
URL: http://svn.freebsd.org/changeset/base/222755
Log:
Pass correct size to write(2).
PR: bin/155915
Submitted by: John Levine
MFC after:2 weeks
Modified:
head/usr.bin/calendar/io.c
Modified:
On 2011-06-06, Hiroki Sato wrote:
di -WARNS?=1
di +WARNS?=6
Shouldn't you just remove the WARNS line because the default for
usr.sbin/ is 6?
--
Jaakko
___
svn-src-head@freebsd.org mailing list
Author: jh
Date: Wed Jun 1 15:48:43 2011
New Revision: 222568
URL: http://svn.freebsd.org/changeset/base/222568
Log:
Don't try to close the stream if fopen(3) fails.
PR: bin/155349
Submitted by: Urankar Mikael
Modified:
head/usr.sbin/kbdmap/kbdmap.c
Modified:
Author: jh
Date: Mon May 23 16:40:44 2011
New Revision: 16
URL: http://svn.freebsd.org/changeset/base/16
Log:
In init_dynamic_kenv(), ignore environment strings exceeding the
KENV_MNAMELEN + 1 + KENV_MVALLEN + 1 length limit to avoid buffer
overflow in getenv(). Currenly loader(8)
Author: jh
Date: Sat May 7 11:10:58 2011
New Revision: 221597
URL: http://svn.freebsd.org/changeset/base/221597
Log:
Add WITNESS_WARN() to getenv() to explicitly note that the function may
sleep. This helps to expose bugs when the requested environment variable
doesn't exist.
Modified:
On 2011-05-07, Kostik Belousov wrote:
@@ -310,6 +310,7 @@ getenv(const char *name)
int len;
if (dynamic_kenv) {
+ WITNESS_WARN(WARN_GIANTOK | WARN_SLEEPOK, NULL, getenv);
mtx_lock(kenv_lock);
cp = _getenv_dynamic(name, NULL);
Author: jh
Date: Sat May 7 17:59:07 2011
New Revision: 221607
URL: http://svn.freebsd.org/changeset/base/221607
Log:
To avoid duplicated warning, move WITNESS_WARN() added in r221597 to the
branch which doesn't call malloc(9).
Suggested by: kib
Modified:
Author: jh
Date: Tue May 3 16:00:26 2011
New Revision: 221390
URL: http://svn.freebsd.org/changeset/base/221390
Log:
Don't pass empty mount options to nmount(2).
Reviewed by: pjd
MFC after:2 weeks
Modified:
head/cddl/compat/opensolaris/misc/zmount.c
Modified:
Author: jh
Date: Fri Apr 22 07:26:09 2011
New Revision: 220937
URL: http://svn.freebsd.org/changeset/base/220937
Log:
Utilize vfs_sanitizeopts() in vfs_mergeopts() to merge options. Because
vfs_sanitizeopts() can handle ro and rw options properly, there is
no more need to add noro in
(jamie@ Cc'd because kern_jail.c also uses the vfsopt framework.)
On 2011-04-22, Jaakko Heinonen wrote:
+ * XXX: This function will keep a nofoo option in the new
+ * options. E.g, if the option's canonical name is foo,
+ * nofoo ends up in the mount point's active options.
I have a follow
Author: jh
Date: Sat Apr 16 06:54:41 2011
New Revision: 220686
URL: http://svn.freebsd.org/changeset/base/220686
Log:
Move TUNABLE_INT_FETCH() out of the SIM lock to avoid sleeping while
holding the lock. The fix is analogous to r220618 for ada(4).
Reviewed by: mav
Modified:
Author: jh
Date: Sat Apr 16 08:38:11 2011
New Revision: 220690
URL: http://svn.freebsd.org/changeset/base/220690
Log:
Move a comment to the right place. The rearrange done in r208928 left
the comment to a wrong place.
Modified:
head/sys/cam/scsi/scsi_da.c
Modified:
On 2011-04-14, Alexander Motin wrote:
Fix typo in write_cache tunable name and move TUNABLE_INT_FETCH() out of
the SIM lock to fix WITNESS warning.
Thanks!
Does this analogous patch for cd(4) and da(4) look good? I am not
completely sure if it's safe to move setting of minimum_cmd_size in
On 2011-04-08, Alexander Motin wrote:
- Add kern.cam.ada.X.write_cache tunables/sysctls to control write caching
on per-device basis.
--- head/sys/cam/ata/ata_da.c Fri Apr 8 14:39:41 2011(r220453)
+++ head/sys/cam/ata/ata_da.c Fri Apr 8 14:42:29 2011(r220454)
@@ -738,6
Author: jh
Date: Sat Mar 26 17:17:24 2011
New Revision: 220040
URL: http://svn.freebsd.org/changeset/base/220040
Log:
Fix some style issues in r219925.
Reported by: bde
MFC after:1 month
Modified:
head/sys/kern/vfs_mount.c
Modified: head/sys/kern/vfs_mount.c
On 2011-03-08, Maxim Sobolev wrote:
On 3/8/2011 9:36 AM, Jaakko Heinonen wrote:
Some linux distros put mount point into the ext2fs labels, such as '/',
or
'/boot', which confuses the devfs code and can cause userland
programs to
fail reading /dev/ext2fs directory with weird
On 2011-03-09, Maxim Sobolev wrote:
OK, so what should I do to resolve the issue in question? Should I go
forward and MFC less generic patch to geom_label code to strip out the
leading slashes from the ext2fs labels?
I am not against merging it. Maybe revert the hack in head after
merging?
On 2011-03-08, Maxim Sobolev wrote:
Some linux distros put mount point into the ext2fs labels, such as '/', or
'/boot', which confuses the devfs code and can cause userland programs to
fail reading /dev/ext2fs directory with weird error code, such as any
program that uses pwlib.
Do
Author: jh
Date: Fri Feb 25 19:10:19 2011
New Revision: 219038
URL: http://svn.freebsd.org/changeset/base/219038
Log:
Document the input line length limit.
Submitted by: Dominic Fandrey (original version)
Modified:
head/usr.bin/rs/rs.1
Modified: head/usr.bin/rs/rs.1
Author: jh
Date: Tue Feb 22 15:31:40 2011
New Revision: 218951
URL: http://svn.freebsd.org/changeset/base/218951
Log:
Xref makefs(8).
PR: 154708
Submitted by: jhs
Modified:
head/sbin/newfs/newfs.8
Modified: head/sbin/newfs/newfs.8
Author: jh
Date: Sat Feb 19 14:27:14 2011
New Revision: 218852
URL: http://svn.freebsd.org/changeset/base/218852
Log:
Don't restore old mount options and flags if VFS_MOUNT(9) succeeds but
vfs_export() fails. Restoring old options and flags after successful
VFS_MOUNT(9) call may cause the
1 - 100 of 161 matches
Mail list logo
