svn commit: r368747 - head/usr.sbin/bhyve

2020-12-17 Thread Peter Grehan
Author: grehan Date: Fri Dec 18 00:38:48 2020 New Revision: 368747 URL: https://svnweb.freebsd.org/changeset/base/368747 Log: Fix issues with various VNC clients. - support VNC version 3.3 (macos "Screen Sharing" builtin client) - wait until client has requested an update prior to

svn commit: r368115 - in head/sys/amd64: include vmm vmm/amd vmm/intel

2020-11-27 Thread Peter Grehan
Author: grehan Date: Sat Nov 28 01:16:59 2020 New Revision: 368115 URL: https://svnweb.freebsd.org/changeset/base/368115 Log: Convert vmm_ops calls to IFUNC There is no need for these to be function pointers since they are never modified post-module load. Rename AMD/Intel ops to be

svn commit: r368047 - head/sys/amd64/vmm/amd

2020-11-25 Thread Peter Grehan
Author: grehan Date: Thu Nov 26 05:58:55 2020 New Revision: 368047 URL: https://svnweb.freebsd.org/changeset/base/368047 Log: Remove manual instruction encodings for VMLOAD, VMRUN, and VMSAVE. This is a relic from when these instructions weren't supported by the toolchain.

svn commit: r367834 - head/usr.sbin/bhyve

2020-11-18 Thread Peter Grehan
Author: grehan Date: Thu Nov 19 07:23:39 2020 New Revision: 367834 URL: https://svnweb.freebsd.org/changeset/base/367834 Log: Advance RIP after userspace instruction decode Add update to RIP after a userspace instruction decode (as is done for the in-kernel counterpart of this case).

svn commit: r367762 - head/usr.sbin/bhyve

2020-11-17 Thread Peter Grehan
Author: grehan Date: Tue Nov 17 13:14:04 2020 New Revision: 367762 URL: https://svnweb.freebsd.org/changeset/base/367762 Log: Add legacy debug/test interfaces for kvm unit tests. Implement the legacy debug/test interfaces expected by KVM-unit-tests' realmode, emulator, and ioapic tests.

svn commit: r367709 - head/usr.sbin/bhyve

2020-11-15 Thread Peter Grehan
Author: grehan Date: Sun Nov 15 12:59:24 2020 New Revision: 367709 URL: https://svnweb.freebsd.org/changeset/base/367709 Log: Fix regression in AHCI controller settings. When the AHCI code was reworked to use FreeBSD struct definitions, the valid element was mis-transcribed resulting

svn commit: r365873 - head/usr.sbin/bhyve

2020-09-17 Thread Peter Grehan
Author: grehan Date: Fri Sep 18 05:54:59 2020 New Revision: 365873 URL: https://svnweb.freebsd.org/changeset/base/365873 Log: Fix byte-reversal of language ID in string descriptor. The language id of String Descriptors in usb mouse is 0x0904, while the spec require 0x0409 (English -

svn commit: r364656 - in head/sys: amd64/amd64 i386/i386

2020-08-24 Thread Peter Grehan
Author: grehan Date: Mon Aug 24 11:49:49 2020 New Revision: 364656 URL: https://svnweb.freebsd.org/changeset/base/364656 Log: cpu_auxmsr: assert caller is preventing CPU migration. Submitted by: Adam Fenn (adam at fenn dot io) Requested by: kib Reviewed by: kib, grehan Approved by:

svn commit: r364343 - in head/sys: amd64/amd64 amd64/vmm/intel i386/i386 x86/include

2020-08-18 Thread Peter Grehan
Author: grehan Date: Tue Aug 18 11:36:38 2020 New Revision: 364343 URL: https://svnweb.freebsd.org/changeset/base/364343 Log: Export a routine to provide the TSC_AUX MSR value and use this in vmm. Also, drop an unnecessary set of braces. Requested by: kib Reviewed by: kib

Re: svn commit: r364340 - in head/sys/amd64: include vmm vmm/intel

2020-08-18 Thread Peter Grehan
On 8/18/20 6:48 PM, Konstantin Belousov wrote: On Tue, Aug 18, 2020 at 07:23:47AM +, Peter Grehan wrote: +void +vmx_msr_guest_exit_tsc_aux(struct vmx *vmx, int vcpuid) +{ + uint64_t guest_tsc_aux = vmx->guest_msrs[vcpuid][IDX_MSR_TSC_AUX]; + uint32_t cpuid = PCPU_GET(cp

svn commit: r364340 - in head/sys/amd64: include vmm vmm/intel

2020-08-18 Thread Peter Grehan
Author: grehan Date: Tue Aug 18 07:23:47 2020 New Revision: 364340 URL: https://svnweb.freebsd.org/changeset/base/364340 Log: Support guest rdtscp and rdpid instructions on Intel VT-x Enable any of rdtscp and/or rdpid for bhyve guests on Intel-based hosts that support the "enable RDTSCP"

svn commit: r364339 - head/sys/amd64/vmm

2020-08-18 Thread Peter Grehan
Author: grehan Date: Tue Aug 18 07:08:17 2020 New Revision: 364339 URL: https://svnweb.freebsd.org/changeset/base/364339 Log: Allow guest device MMIO access from bootmem memory segments. Recent versions of UEFI have moved local APIC timer initialization into the early SEC phase which

svn commit: r363733 - head/usr.sbin/bhyve

2020-07-31 Thread Peter Grehan
Author: grehan Date: Fri Jul 31 12:10:28 2020 New Revision: 363733 URL: https://svnweb.freebsd.org/changeset/base/363733 Log: Replace magic numbers in Identify page register 0 with ATA definitions. No functional change. Verified with objdump output before/after. Requested by: rpokala

svn commit: r363719 - head/sys/sys

2020-07-30 Thread Peter Grehan
Author: grehan Date: Thu Jul 30 23:49:49 2020 New Revision: 363719 URL: https://svnweb.freebsd.org/changeset/base/363719 Log: Definition for the 'removable media flag' from word 0 in the Identify page. This will be used to remove a magic number in the bhyve AHCI emulation. Reported

svn commit: r363596 - head/usr.sbin/bhyve

2020-07-27 Thread Peter Grehan
Author: grehan Date: Mon Jul 27 07:56:55 2020 New Revision: 363596 URL: https://svnweb.freebsd.org/changeset/base/363596 Log: Support the setting of additional AHCI controller parameters. Allow the serial number, firmware revision, model number and nominal media rotation rate (nmrr)

svn commit: r363070 - head/usr.sbin/bhyve

2020-07-10 Thread Peter Grehan
Author: grehan Date: Fri Jul 10 07:26:50 2020 New Revision: 363070 URL: https://svnweb.freebsd.org/changeset/base/363070 Log: Advertise 64-bit physical-address capability. This fixes a coredump with NetBSD guests when XHCI is configured. On seeing the AC64 flag clear, the NetBSD XHCI

svn commit: r362952 - head/usr.sbin/bhyve

2020-07-06 Thread Peter Grehan
Author: grehan Date: Mon Jul 6 08:36:14 2020 New Revision: 362952 URL: https://svnweb.freebsd.org/changeset/base/362952 Log: Silence ACPI RTC error/warning in Linux guests. Allow guests to set the RTC bit in the ACPI PM control register. This eliminates an annoying (and

svn commit: r362644 - head/usr.sbin/bhyve

2020-06-26 Thread Peter Grehan
Author: grehan Date: Fri Jun 26 08:20:38 2020 New Revision: 362644 URL: https://svnweb.freebsd.org/changeset/base/362644 Log: Prevent calling USB backends multiple times. The TRB processing loop could potentially call a back-end twice with the same status transaction. While this was

svn commit: r362643 - head

2020-06-26 Thread Peter Grehan
Author: grehan Date: Fri Jun 26 06:11:50 2020 New Revision: 362643 URL: https://svnweb.freebsd.org/changeset/base/362643 Log: Update bhyve maintainers. Suggested by: jhb Approved by: jhb, tychon Modified: head/MAINTAINERS Modified: head/MAINTAINERS

svn commit: r361442 - head/usr.sbin/bhyve

2020-05-25 Thread Peter Grehan
Author: grehan Date: Mon May 25 06:25:31 2020 New Revision: 361442 URL: https://svnweb.freebsd.org/changeset/base/361442 Log: Fix pci-passthru MSI issues with OpenBSD guests - Return 2 x 16-bit registers in the correct byte order for a 4-byte read that spans the CMD/STATUS register.

svn commit: r361064 - head/sys/amd64/vmm

2020-05-14 Thread Peter Grehan
Author: grehan Date: Thu May 14 22:18:12 2020 New Revision: 361064 URL: https://svnweb.freebsd.org/changeset/base/361064 Log: Hide host CPUID 0x15 TSC/Crystal ratio/freq info from guest In recent Linux (5.3+) and OpenBSD (6.6+) kernels, and with hosts that support CPUID 0x15, the local

Re: svn commit: r359950 - head/usr.sbin/bhyve

2020-04-19 Thread Peter Grehan
Unless there is an ABI problem, I think we should probably go ahead and bump VM_MAX_MEMMAPS That's a reasonable fix - double it (or more) until it's made dynamic. The VGA code is another (future) client of this, and it would allow other things like multiple frame buffers. later, Peter.

svn commit: r334913 - head

2018-06-09 Thread Peter Grehan
Author: grehan Date: Sun Jun 10 04:25:19 2018 New Revision: 334913 URL: https://svnweb.freebsd.org/changeset/base/334913 Log: Pass on bhyve kernel module maintenance to tychon and jhb who've both had a long history with the codebase. Discussed with:tychon, jhb Modified:

Re: svn commit: r334407 - head/sys/dev/pci

2018-05-30 Thread Peter Grehan
Log: Only conform to PCIe spec of 1 device per bus on !x86 bhyve's root PCI complex shows up as PCIe, but behaves as traditional PCI. Until that is special cased in a root complex driver, leave x86 as it was. Thanks Justin ! later, Peter.

Re: svn commit: r334365 - head/sys/dev/pci

2018-05-30 Thread Peter Grehan
If bhyve has its own  attachment id, it is trivial to add a special case on it quickly, too.  vendor_id -- 0x1275 Actually, this can also be AMD. A better check would be if the system is running virtualized. later, Peter. ___

Re: svn commit: r334365 - head/sys/dev/pci

2018-05-30 Thread Peter Grehan
Hi Justin, I can add one either tonight or tomorrow. Thanks. If bhyve has its own attachment id, it is trivial to add a special case on it quickly, too. vendor_id -- 0x1275 later, Peter. ___ svn-src-head@freebsd.org mailing list

Re: svn commit: r334365 - head/sys/dev/pci

2018-05-30 Thread Peter Grehan
Hi Nathan, There are a ton of ARM boards that need this too. You can find one-off hacks all through the tree and one of the nice things about this change is that all of those can be consolidated/removed now. If we are going to have some #ifdef and special cases, it would be better to make

Re: svn commit: r334365 - head/sys/dev/pci

2018-05-30 Thread Peter Grehan
PCIe only permits 1 device on an endpoint, so some devices ignore the device part of B:D:F probing. Although ARI likely fixes this, not all platforms support ARI completely or correctly, so some devices end up showing up 32 times on the bus. I think this might have broken bhyve -

svn commit: r333235 - head/usr.sbin/bhyve

2018-05-03 Thread Peter Grehan
Author: grehan Date: Fri May 4 01:36:49 2018 New Revision: 333235 URL: https://svnweb.freebsd.org/changeset/base/333235 Log: Allow arbitrary numbers of columns for VNC server screen resolution. The prior code only allowed multiples of 32 for the numbers of columns. Remove this

svn commit: r333230 - head/sys/dev/pci

2018-05-03 Thread Peter Grehan
Author: grehan Date: Thu May 3 22:51:44 2018 New Revision: 333230 URL: https://svnweb.freebsd.org/changeset/base/333230 Log: Allow PCI VGA devices to be detached. GPUs often have a VGA PCI class code and are probed/attached by the VGA driver. Allow them to be detached so they can be

Re: svn commit: r333174 - head/sys/amd64/vmm/io

2018-05-02 Thread Peter Grehan
That places the MFC right before the optional 11.2 Beta3, I would rather see this "low risk" change merged before May 11th, the code freeze date and Beta1, if it is desired in 11.2, for maximal test exposure. Sure, that can be done. later, Peter.

svn commit: r333174 - head/sys/amd64/vmm/io

2018-05-02 Thread Peter Grehan
Author: grehan Date: Wed May 2 17:41:00 2018 New Revision: 333174 URL: https://svnweb.freebsd.org/changeset/base/333174 Log: Use PCI power-mgmt to reset a device if FLR fails. A large number of devices don't support PCIe FLR, in particular graphics adapters. Use PCI power management to

svn commit: r330764 - head/usr.sbin/bhyvectl

2018-03-11 Thread Peter Grehan
Author: grehan Date: Sun Mar 11 08:27:11 2018 New Revision: 330764 URL: https://svnweb.freebsd.org/changeset/base/330764 Log: Add CR2 get/set support. Reported/Tested by: Fabian Freyer Reviewed by: araujo Differential Revision:https://reviews.freebsd.org/D14648 MFC after:

svn commit: r327990 - head/share/man/man4

2018-01-14 Thread Peter Grehan
Author: grehan Date: Mon Jan 15 04:52:12 2018 New Revision: 327990 URL: https://svnweb.freebsd.org/changeset/base/327990 Log: The vmm(4) man page is conditional on MK_BHYVE. Submitted by: kevlo Modified: head/share/man/man4/Makefile Modified: head/share/man/man4/Makefile

svn commit: r325261 - head/sys/amd64/vmm

2017-10-31 Thread Peter Grehan
Author: grehan Date: Wed Nov 1 03:26:53 2017 New Revision: 325261 URL: https://svnweb.freebsd.org/changeset/base/325261 Log: Emulate the "OR reg, r/m" instruction (opcode 0BH). This is needed for the HDA emulation with FreeBSD guests. Reviewed by: marcelo MFC after:2

Re: svn commit: r325108 - head/sys/amd64/vmm/io

2017-10-29 Thread Peter Grehan
Hi Ian, In fact I did check maintainers, and I just now checked it again, and seeing nothing on-point, wrote a really snarky reply. Luckily, before hitting send I realized you wouldn't have said anything unless there was an entry in there, so I checked like 4 more times before I noticed the

Re: svn commit: r325108 - head/sys/amd64/vmm/io

2017-10-29 Thread Peter Grehan
  Improve the performance of the hpet timer in bhyve guests by making the   timer frequency a power of two.  This changes the frequency from 10 to   16.7 MHz (2 ^ 24 HZ).  Using a power of two avoids roundoff errors when   doing arithmetic in sbintime_t units.   Testing shows this can

Re: svn commit: r319487 - head/usr.sbin/bhyve

2017-06-10 Thread Peter Grehan
Hi Conrad, Here, keystr is not zero initialized Note that strncpy below does not fill the remainder of the buffer with nuls if rc->password is shorter than 7 characters. +* The client then sends the resulting 16-bytes response. +*/ +#ifndef NO_OPENSSL +

Re: svn commit: r316311 - in head: lib/libstand sys/boot/geli sys/boot/i386/gptboot sys/boot/i386/loader sys/boot/i386/zfsboot

2017-03-31 Thread Peter Grehan
So... can anyone provide a clue what's "explicit" (or different in any way) between explicit_bzero() and normal bzero()? https://www.freebsd.org/cgi/man.cgi?query=explicit_bzero=3=FreeBSD+12-current later, Peter. ___ svn-src-head@freebsd.org

svn commit: r315716 - head/sys/dev/usb/input

2017-03-22 Thread Peter Grehan
Author: grehan Date: Wed Mar 22 17:06:57 2017 New Revision: 315716 URL: https://svnweb.freebsd.org/changeset/base/315716 Log: Bring the handling of the y axis in the ums driver in-line with the other axes. No functional change. Submitted by: Vicki Pfau (vi AT endrift.com) Approved

svn commit: r315715 - head/usr.sbin/bhyve

2017-03-22 Thread Peter Grehan
Author: grehan Date: Wed Mar 22 16:53:03 2017 New Revision: 315715 URL: https://svnweb.freebsd.org/changeset/base/315715 Log: This fixes a typo in bhyve's USB mouse emulation. There is no behavioral difference, as it's just swapping out the name of two identically-valued constants.

svn commit: r315364 - head/sys/amd64/vmm

2017-03-15 Thread Peter Grehan
Author: grehan Date: Thu Mar 16 03:21:42 2017 New Revision: 315364 URL: https://svnweb.freebsd.org/changeset/base/315364 Log: Hide the AMD MONITORX/MWAITX capability. Otherwise, recent Linux guests will use these instructions, resulting in #UD exceptions since bhyve doesn't implement

svn commit: r315361 - in head/sys/x86: include x86

2017-03-15 Thread Peter Grehan
Author: grehan Date: Thu Mar 16 03:06:50 2017 New Revision: 315361 URL: https://svnweb.freebsd.org/changeset/base/315361 Log: Add the AMD MONITORX/MWAITX feature definition introduced in Bulldozer/Ryzen CPUs. Reviewed by: kib MFC after:1 week Modified:

svn commit: r311702 - head/usr.sbin/bhyve

2017-01-08 Thread Peter Grehan
Author: grehan Date: Sun Jan 8 20:58:58 2017 New Revision: 311702 URL: https://svnweb.freebsd.org/changeset/base/311702 Log: Use correct PCI device id for virtio-rng. This prevented the device from attaching with a Windows guest (most other guests use the device type for matching)

svn commit: r311699 - head/usr.sbin/bhyve

2017-01-08 Thread Peter Grehan
Author: grehan Date: Sun Jan 8 20:29:35 2017 New Revision: 311699 URL: https://svnweb.freebsd.org/changeset/base/311699 Log: Make sure the 'Always-one' bit is always set to one, in the first byte of the 3-byte mouse data report. Plan9/9front requires this. Switch over to using

svn commit: r303352 - head/usr.sbin/bhyve

2016-07-26 Thread Peter Grehan
Author: grehan Date: Wed Jul 27 00:03:29 2016 New Revision: 303352 URL: https://svnweb.freebsd.org/changeset/base/303352 Log: - Change the fbuf "vga" parameter to "vga=on|io|off". "io" is the default, and allows VGA i/o registers to be accessed. This is required by Win7/2k8 graphics

svn commit: r303349 - head/usr.sbin/bhyve

2016-07-26 Thread Peter Grehan
Author: grehan Date: Tue Jul 26 23:40:25 2016 New Revision: 303349 URL: https://svnweb.freebsd.org/changeset/base/303349 Log: Catch another case where an XHCI interrupt was being injected without state being set up. This fixes a core dump when dropping to the UEFI prompt with graphics

svn commit: r302972 - head/usr.sbin/bhyve

2016-07-17 Thread Peter Grehan
Author: grehan Date: Sun Jul 17 20:34:46 2016 New Revision: 302972 URL: https://svnweb.freebsd.org/changeset/base/302972 Log: Disallow interrupt requests on disabled endpoints. Submitted by: Leon Dang MFC after:3 days Modified: head/usr.sbin/bhyve/pci_xhci.c Modified:

svn commit: r302546 - head/usr.sbin/bhyve

2016-07-11 Thread Peter Grehan
Author: grehan Date: Mon Jul 11 06:31:15 2016 New Revision: 302546 URL: https://svnweb.freebsd.org/changeset/base/302546 Log: Implement right shift/ctl, and convert the VNC/xorg scancode of 0xff03 into right-alt. Reported by: lme@ MFC after:1 week Modified:

Re: svn commit: r302332 - head/usr.sbin/bhyve

2016-07-05 Thread Peter Grehan
This breaks the external GCC 5.2 build: Fix being worked on in https://reviews.freebsd.org/D7119 later, Peter. ___ svn-src-head@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to

svn commit: r302332 - head/usr.sbin/bhyve

2016-07-03 Thread Peter Grehan
Author: grehan Date: Mon Jul 4 03:19:06 2016 New Revision: 302332 URL: https://svnweb.freebsd.org/changeset/base/302332 Log: Import bhyve_graphics into CURRENT. Thanks to all who tested this on the branch. Original commit message: Initial bhyve native graphics support. This

svn commit: r298355 - head/usr.sbin/bhyve

2016-04-20 Thread Peter Grehan
Author: grehan Date: Wed Apr 20 17:05:32 2016 New Revision: 298355 URL: https://svnweb.freebsd.org/changeset/base/298355 Log: Don't use SYSDIR to avoid conflicts with existing usage. Also, use SRCTOP to locate the top of the source tree instead of a relative path. PR: 208856

Re: svn commit: r297806 - head/sys/amd64/vmm/amd

2016-04-11 Thread Peter Grehan
Hi Shawn, Pardon my ignorance, but does that mean that prior to this commit, a bhyve guest on AMD could modify hardware? No. Before this commit, the guest would exit if it attempted to update microcode. Now it just ignores the attempt. later, Peter.

svn commit: r297778 - head/usr.sbin/bhyve

2016-04-09 Thread Peter Grehan
Author: grehan Date: Sun Apr 10 05:58:19 2016 New Revision: 297778 URL: https://svnweb.freebsd.org/changeset/base/297778 Log: Allow the location of the kernel source tree to be overridden. This makes it easier for the bhyve executable to be built out of the tree. Modified:

Re: svn commit: r296428 - head/sys/boot/common

2016-03-07 Thread Peter Grehan
Are the CFI directives so that DTRACE works, or is there some other reason? It allows gdb to backtrace across exception frames. later, Peter. ___ svn-src-head@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-head To

svn commit: r292061 - head

2015-12-10 Thread Peter Grehan
Author: grehan Date: Thu Dec 10 12:12:47 2015 New Revision: 292061 URL: https://svnweb.freebsd.org/changeset/base/292061 Log: vmm is still maintained. Modified: head/MAINTAINERS Modified: head/MAINTAINERS == ---

svn commit: r288826 - head/usr.sbin/bhyve

2015-10-05 Thread Peter Grehan
Author: grehan Date: Mon Oct 5 14:57:45 2015 New Revision: 288826 URL: https://svnweb.freebsd.org/changeset/base/288826 Log: Clean up some harmless unimplemented-command warning messages. - Don't advertize trusted-computing capability in the Identify page. This prevents Windows from

svn commit: r288524 - head/usr.sbin/bhyve

2015-10-02 Thread Peter Grehan
Author: grehan Date: Fri Oct 2 22:05:51 2015 New Revision: 288524 URL: https://svnweb.freebsd.org/changeset/base/288524 Log: Fix post-test typo that snuck in. Modified: head/usr.sbin/bhyve/fwctl.c Modified: head/usr.sbin/bhyve/fwctl.c

svn commit: r288522 - head/usr.sbin/bhyve

2015-10-02 Thread Peter Grehan
y, because file is newly added) +++ head/usr.sbin/bhyve/fwctl.c Fri Oct 2 21:09:49 2015(r288522) @@ -0,0 +1,549 @@ +/*- + * Copyright (c) 2015 Peter Grehan <gre...@freebsd.org> + * All rights reserved. + * + * Redistribution and use in source and binary forms, with or without + *

svn commit: r288470 - head/usr.sbin/bhyve

2015-10-01 Thread Peter Grehan
Author: grehan Date: Fri Oct 2 02:09:50 2015 New Revision: 288470 URL: https://svnweb.freebsd.org/changeset/base/288470 Log: - Increase the max number of indirect descriptors to match the largest that the Windows virtio driver can send down - Always advertize indirect descriptors. The

svn commit: r286838 - head/usr.sbin/bhyve

2015-08-16 Thread Peter Grehan
Author: grehan Date: Mon Aug 17 05:59:36 2015 New Revision: 286838 URL: https://svnweb.freebsd.org/changeset/base/286838 Log: Add simple (no-op) emulations for the CHECK_POWER_MODE, READ_VERIFY and READ_VERIFY_EXT commands. Reviewed by: mav Modified: head/usr.sbin/bhyve/pci_ahci.c

svn commit: r286837 - head/sys/sys

2015-08-16 Thread Peter Grehan
Author: grehan Date: Mon Aug 17 05:56:41 2015 New Revision: 286837 URL: https://svnweb.freebsd.org/changeset/base/286837 Log: Add define for SATA Check-Power-Mode command, 0xe5. Modified: head/sys/sys/ata.h Modified: head/sys/sys/ata.h

Re: svn commit: r285217 - head/usr.sbin/bhyve

2015-07-06 Thread Peter Grehan
This seems like a wrong fix. A real 3-wire serial console doesn't have DCD and DSR wired on. Why isn't the right fix here having the user with this problem to do stty -f /dev/ttyu0.lock clocal, maybe in rc.local? Hmmm, or maybe it would be right for getty to do the equivelent when it sees a

Re: svn commit: r285217 - head/usr.sbin/bhyve

2015-07-06 Thread Peter Grehan
Ok, so I just tested on real hardware, and something is wrong w/ FreeBSD's behavior... Could this be a change between 10 and HEAD? uart_tty.c r264175 wasn't MFC'd - see UPDATING, 20140405 for the details. later, Peter. ___

Re: svn commit: r285217 - head/usr.sbin/bhyve

2015-07-06 Thread Peter Grehan
Though there is a question is why DCD isn't assert by bhyve when there is a session attached to the console... Modem signal policy wasn't implemented. The workaround now is that DCD is permanently asserted, but at some point when a proper terminal backend is in place, the signal policy would

svn commit: r283168 - head/usr.sbin/bhyve

2015-05-20 Thread Peter Grehan
Author: grehan Date: Thu May 21 04:19:22 2015 New Revision: 283168 URL: https://svnweb.freebsd.org/changeset/base/283168 Log: Temporarily revert r282922 which bumped the max descriptors. While there is no issued with the number of descriptors in a virtio indirect descriptor, it's a

svn commit: r282922 - head/usr.sbin/bhyve

2015-05-14 Thread Peter Grehan
Author: grehan Date: Thu May 14 21:08:48 2015 New Revision: 282922 URL: https://svnweb.freebsd.org/changeset/base/282922 Log: Bump the size of the blockif scatter-gather list to 67. The Windows virtio driver ignores the advertized seg_max field and assumes the host can accept up to 67

svn commit: r282865 - head/usr.sbin/bhyve

2015-05-13 Thread Peter Grehan
Author: grehan Date: Wed May 13 17:38:07 2015 New Revision: 282865 URL: https://svnweb.freebsd.org/changeset/base/282865 Log: Set the subvendor field in config space to the vendor ID. This is required by the Windows virtio drivers to correctly match a device. Submitted by: Leon Dang

svn commit: r282784 - head/usr.sbin/bhyve

2015-05-11 Thread Peter Grehan
Author: grehan Date: Mon May 11 21:24:10 2015 New Revision: 282784 URL: https://svnweb.freebsd.org/changeset/base/282784 Log: Handling indirect descriptors is a capability of the host and not one that needs to be negotiated. Use the host capabilities field and not the negotiated field when

svn commit: r280725 - head/usr.sbin/bhyve

2015-03-26 Thread Peter Grehan
Author: grehan Date: Fri Mar 27 01:58:44 2015 New Revision: 280725 URL: https://svnweb.freebsd.org/changeset/base/280725 Log: Move legacy interrupt allocation for virtio devices to common code. There are a number of assumptions about legacy interrupts always being available in virtio so

Re: svn commit: r278473 - in head/sys: amd64/amd64 amd64/include amd64/vmm contrib/dev/acpica/include i386/i386 i386/include x86/acpica x86/include x86/x86 x86/xen

2015-02-26 Thread Peter Grehan
I'm going to set the x2apic_disable=0 by default in 24 hours so people have time to fix this without it impacting the functionality of -HEAD by default. What gives you the right to make this decision ? later, Peter. ___ svn-src-head@freebsd.org

Re: svn commit: r278473 - in head/sys: amd64/amd64 amd64/include amd64/vmm contrib/dev/acpica/include i386/i386 i386/include x86/acpica x86/include x86/x86 x86/xen

2015-02-26 Thread Peter Grehan
This has been reported by more than one person, it's been a couple of weeks, it's an actual regression, and there's no specific solution in sight. It's been reported by you and one other, with no feedback from the other person despite requests for more information, and there would be a

Re: svn commit: r278473 - in head/sys: amd64/amd64 amd64/include amd64/vmm contrib/dev/acpica/include i386/i386 i386/include x86/acpica x86/include x86/x86 x86/xen

2015-02-26 Thread Peter Grehan
Koop did provide feedback shortly after Kib asked him to provide information and test a patch. There wasn't a response from kib or anyone else until I reported the same bug. http://docs.FreeBSD.org/cgi/mid.cgi?20150219200900.GH34251 later, Peter.

Re: svn commit: r278473 - in head/sys: amd64/amd64 amd64/include amd64/vmm contrib/dev/acpica/include i386/i386 i386/include x86/acpica x86/include x86/x86 x86/xen

2015-02-26 Thread Peter Grehan
I'm not suggesting anything is backed out. I'm suggesting that we just disable it until it's fixed. Both Kostik and Neel gave their reasons for keeping it enabled. I'm adding to that. That way we don't end up with other people complaining that things hang the way that they do and then

Re: svn commit: r278473 - in head/sys: amd64/amd64 amd64/include amd64/vmm contrib/dev/acpica/include i386/i386 i386/include x86/acpica x86/include x86/x86 x86/xen

2015-02-26 Thread Peter Grehan
Anyway - I have that model laptop, it hangs after calling ipi_startup() to the first AP with x2apic enabled. What can I do to continue debugging? Please provide the info that Kostik requested here, try out the patch, and wait for the timezone in Ukraine to be a little more reasonable for a

svn commit: r279220 - head/usr.sbin/bhyve

2015-02-23 Thread Peter Grehan
Author: grehan Date: Mon Feb 23 22:31:39 2015 New Revision: 279220 URL: https://svnweb.freebsd.org/changeset/base/279220 Log: Don't close a block context if it couldn't be opened, for example if the backing file doesn't exist, avoiding a null deref. Reviewed by: neel MFC after:1

svn commit: r278965 - head

2015-02-18 Thread Peter Grehan
Author: grehan Date: Wed Feb 18 19:27:51 2015 New Revision: 278965 URL: https://svnweb.freebsd.org/changeset/base/278965 Log: Restore the ability to use clang as an external compiler. This was inadvertently removed when support for external GCC was added. Deprecate XFLAGS in favour of

svn commit: r277043 - head/sys/dev/uart

2015-01-11 Thread Peter Grehan
Author: grehan Date: Mon Jan 12 03:39:56 2015 New Revision: 277043 URL: https://svnweb.freebsd.org/changeset/base/277043 Log: Add PCI ID for the Oxford Semiconductor OXPCIe952 device. Seen on the StarTech 1 Port Native ExpressCard RS232 Serial AdapterCard with 16950 UART Reported

svn commit: r274931 - head/sys/amd64/vmm

2014-11-23 Thread Peter Grehan
Author: grehan Date: Sun Nov 23 23:07:21 2014 New Revision: 274931 URL: https://svnweb.freebsd.org/changeset/base/274931 Log: Change the lower bound for guest vmspace allocation to 0 instead of using the VM_MIN_ADDRESS constant. HardenedBSD redefines VM_MIN_ADDRESS to be 64K, which

svn commit: r274407 - head/sys/boot/common

2014-11-11 Thread Peter Grehan
Author: grehan Date: Tue Nov 11 22:03:11 2014 New Revision: 274407 URL: https://svnweb.freebsd.org/changeset/base/274407 Log: Fix incorrect reading of 32-bit modinfo by 64-bit loaders. The various structures in the mod_metadata set of a FreeBSD kernel and modules contain pointers. The

svn commit: r273748 - head/sys/x86/x86

2014-10-27 Thread Peter Grehan
Author: grehan Date: Mon Oct 27 22:02:35 2014 New Revision: 273748 URL: https://svnweb.freebsd.org/changeset/base/273748 Log: Output a summary of optional SVM features in dmesg similar to CPU features. If bootverbose is enabled, a detailed list is provided; otherwise, a single-line summary

svn commit: r273749 - head/sys/amd64/vmm/amd

2014-10-27 Thread Peter Grehan
Author: grehan Date: Mon Oct 27 22:20:51 2014 New Revision: 273749 URL: https://svnweb.freebsd.org/changeset/base/273749 Log: Remove bhyve SVM feature printf's now that they are available in the general CPU feature detection code. Reviewed by: neel Modified:

Re: svn commit: r273214 - in head/sys: amd64/vmm/intel modules/vmm

2014-10-17 Thread Peter Grehan
Author: imp Date: Fri Oct 17 13:20:49 2014 New Revision: 273214 URL: https://svnweb.freebsd.org/changeset/base/273214 Log: Fix build to not bogusly always rebuild vmm.ko. Rename vmx_assym.s to vmx_assym.h to reflect that file's actual use and update vmx_support.S's include to match.

svn commit: r272481 - head/usr.sbin/bhyve

2014-10-03 Thread Peter Grehan
Author: grehan Date: Fri Oct 3 17:27:30 2014 New Revision: 272481 URL: https://svnweb.freebsd.org/changeset/base/272481 Log: Add new fields in the FADT, required by IASL 20140926-64. The new IASL from the recent acpi-ca import will error out if it doesn't see these new fields, which

svn commit: r272193 - head/sys/amd64/vmm/io

2014-09-26 Thread Peter Grehan
Author: grehan Date: Sat Sep 27 01:15:24 2014 New Revision: 272193 URL: http://svnweb.freebsd.org/changeset/base/272193 Log: Allow the PIC's IMR register to be read before ICW initialisation. As of git submit e179f6914152eca9, the Linux kernel does a simple probe of the PIC by writing a

svn commit: r272007 - head/usr.sbin/bhyve

2014-09-22 Thread Peter Grehan
Author: grehan Date: Tue Sep 23 01:17:22 2014 New Revision: 272007 URL: http://svnweb.freebsd.org/changeset/base/272007 Log: Correct display of bhyve SMBIOS UUIDs with dmidecode by bumping the version. The mixed little/big-endianness of SMBIOS UUIDs was clarified in v2.6 of the SMBIOS

Re: svn commit: r271711 - head/usr.sbin/bhyve

2014-09-17 Thread Peter Grehan
Update the bhyve(8) manual to reflect that it is no longer considered 'experimental.' If it's no longer experimental, we should document hardware requirements for it to function in the man page(s)... I'll get a phabric review going for this. Like I tried it on my AMD hardware, but it

svn commit: r271338 - head/usr.sbin/bhyve

2014-09-09 Thread Peter Grehan
Author: grehan Date: Tue Sep 9 22:35:02 2014 New Revision: 271338 URL: http://svnweb.freebsd.org/changeset/base/271338 Log: Allow vtnet operation without merged rx buffers. NetBSD's virtio-net implementation doesn't negotiate the merged rx-buffers feature. To support this, check to

svn commit: r271350 - head/sys/dev/nmdm

2014-09-09 Thread Peter Grehan
Author: grehan Date: Wed Sep 10 05:44:15 2014 New Revision: 271350 URL: http://svnweb.freebsd.org/changeset/base/271350 Log: Fix issue with nmdm and leading zeros in device name. The nmdm code enforces a number between the 'nmdm' and 'A|B' portions of the device name. This is then used

svn commit: r271299 - head/usr.sbin/bhyve

2014-09-08 Thread Peter Grehan
Author: grehan Date: Tue Sep 9 04:11:54 2014 New Revision: 271299 URL: http://svnweb.freebsd.org/changeset/base/271299 Log: Add a callback to be notified about negotiated features. Submitted by: luigi Obtained from:Vincenzo Maffione, Universita` di Pisa MFC after:3 days

svn commit: r270689 - head/sys/amd64/vmm

2014-08-26 Thread Peter Grehan
Author: grehan Date: Wed Aug 27 00:53:56 2014 New Revision: 270689 URL: http://svnweb.freebsd.org/changeset/base/270689 Log: Implement the 0x2B SUB instruction, and the OR variant of 0x81. Found with local APIC accesses from bitrig/amd64 bsd.rd, 07/15-snap. Reviewed by: neel MFC

svn commit: r270438 - head/sys/amd64/include

2014-08-23 Thread Peter Grehan
Author: grehan Date: Sun Aug 24 02:07:34 2014 New Revision: 270438 URL: http://svnweb.freebsd.org/changeset/base/270438 Log: Change __inline style to be consistent with FreeBSD usage, and also fix gcc build (on STABLE, when MFCd). PR: 192880 Reviewed by: neel Reported by: ngie

svn commit: r269391 - head/sys/netinet

2014-08-01 Thread Peter Grehan
Author: grehan Date: Fri Aug 1 18:36:40 2014 New Revision: 269391 URL: http://svnweb.freebsd.org/changeset/base/269391 Log: Fix byte ordering in default RSS key. The rss_key[] array in netinet/in_rss.c has the bytes in incorrect order. This results in the RSS test vectors in the

Re: svn commit: r268837 - head/sys/netinet

2014-07-18 Thread Peter Grehan
Update the default RSS hash to the Chelsio T5 firmware one - it provides markedly better distribution of IPv6 address/ports than the previous key. That's actually the key that's used for verification in the Microsoft spec, though it looks like you have the bytes arranged backwards,

Re: svn commit: r268837 - head/sys/netinet

2014-07-18 Thread Peter Grehan
Hi Adrian, Hah! I wonder why the key from the T3 NIC that Robert committed was so .. terrible then. Are you saying that the actual byte order is totally reversed, or just endian? The 32-bit word order of your array is reversed. The last 4 bytes should be the first, etc. Have a look at the

svn commit: r268638 - head/usr.sbin/bhyve

2014-07-14 Thread Peter Grehan
Author: grehan Date: Tue Jul 15 00:25:54 2014 New Revision: 268638 URL: http://svnweb.freebsd.org/changeset/base/268638 Log: Add a call to synthesize a C/H/S value for block emulations that require it (ahci). The algorithm used is from the VHD specification. Modified:

svn commit: r268639 - head/usr.sbin/bhyve

2014-07-14 Thread Peter Grehan
Author: grehan Date: Tue Jul 15 00:27:08 2014 New Revision: 268639 URL: http://svnweb.freebsd.org/changeset/base/268639 Log: Use the blockif CHS routine to create fake CHS values, and then populate them in the identity page. This fixes a divide-by-zero error at probe time with NetBSD.

svn commit: r268276 - head/usr.sbin/bhyve

2014-07-04 Thread Peter Grehan
Author: grehan Date: Sat Jul 5 02:38:53 2014 New Revision: 268276 URL: http://svnweb.freebsd.org/changeset/base/268276 Log: Extend capabilities to 64-bits in preparation for some API changes. The v1.0 virtio spec supports an extended size for guest/host caps, but in practice 64-bits should

svn commit: r268202 - head/usr.sbin/bhyve

2014-07-02 Thread Peter Grehan
Author: grehan Date: Thu Jul 3 00:23:14 2014 New Revision: 268202 URL: http://svnweb.freebsd.org/changeset/base/268202 Log: Use correct flag for event index. Submitted by: luigi Obtained from:Vincenzo Maffione, Universita` di Pisa MFC after:1 week Modified:

svn commit: r267949 - head/usr.sbin/bhyve

2014-06-26 Thread Peter Grehan
Author: grehan Date: Fri Jun 27 05:27:37 2014 New Revision: 267949 URL: http://svnweb.freebsd.org/changeset/base/267949 Log: Set the version and date to fixed fields rather than using preprocessor macros that don't allow reproducible builds. As a side-effect, the date string is now

  1   2   3   >