Re: svn commit: r314420 - head/sys/kern

Sure, but it doesn’t match the comments in that if-else construct. Scott > On Feb 28, 2017, at 2:02 PM, Conrad Meyer wrote: > > On Tue, Feb 28, 2017 at 1:27 PM, Scott Long wrote: >> Author: scottl >> Date: Tue Feb 28 21:27:51 2017 >> New Revision: 314420

Re: svn commit: r300219 - in head/sys: kern sys

Yeah, I was following existing style. Feel free to fix up if you like. Scott > On May 19, 2016, at 12:51 PM, Steven Hartland wrote: > > I thought it was considered better to use if (var == NULL) instead of > if (!var) for pointers as they aren't bools? > >> On 19 May

Re: svn commit: r300201 - head/sys/sys

Thanks! Scott > On May 19, 2016, at 5:19 AM, Alexander Motin wrote: > > Author: mav > Date: Thu May 19 11:19:37 2016 > New Revision: 300201 > URL: https://svnweb.freebsd.org/changeset/base/300201 > > Log: > Add ta_flags initialization in old macros missed in 300113. > >

Re: svn commit: r300154 - head/sys/net

What should I use instead? Scott > On May 18, 2016, at 10:03 AM, Warner Losh wrote: > > Ditto with mips. > > On Wed, May 18, 2016 at 9:50 AM, Justin Hibbits wrote: > On Wed, 18 May 2016 15:45:12 + (UTC) > Scott Long wrote: > >

Re: svn commit: r288122 - in head/sys: kern vm

It should be noted that Netflix has been running with an earlier version of this patch for nearly 10 months. Scott > On Sep 22, 2015, at 11:16 AM, Alan Cox wrote: > > Author: alc > Date: Tue Sep 22 18:16:52 2015 > New Revision: 288122 > URL:

Re: svn commit: r287934 - head/sys/boot/efi/loader

As a side note, I’m still waiting for feedback on the patch I sent you for scsi_sg. I’d like to get this fixed. Scott > On Sep 21, 2015, at 3:53 PM, Rui Paulo wrote: > > No, that doesn't work very well. Not only the modules don't auto-load, the > way the modules are compiled

Re: svn commit: r284297 - in head: cddl/contrib/opensolaris/cmd/lockstat sys/kern sys/sys

On Jun 12, 2015, at 4:01 AM, Andriy Gapon a...@freebsd.org wrote: Author: avg Date: Fri Jun 12 10:01:24 2015 New Revision: 284297 URL: https://svnweb.freebsd.org/changeset/base/284297 Log: several lockstat improvements 0. For spin events report time spent spinning, not a loop

Re: svn commit: r284959 - in head: . share/man/man4 share/man/man9 sys/conf sys/dev/glxsb sys/dev/hifn sys/dev/random sys/dev/rndtest sys/dev/safe sys/dev/syscons sys/dev/ubsec sys/dev/virtio/random s

On Jul 25, 2015, at 8:36 AM, Alexey Dokuchaev da...@freebsd.org wrote: On Fri, Jul 24, 2015 at 07:59:35AM +0100, Mark R V Murray wrote: [...] Heck, piping in mic data to /dev/random is a good way to seed the rng on many machines. Well, sure, but what if you don't have microphone? I want

Re: svn commit: r284959 - in head: . share/man/man4 share/man/man9 sys/conf sys/dev/glxsb sys/dev/hifn sys/dev/random sys/dev/rndtest sys/dev/safe sys/dev/syscons sys/dev/ubsec sys/dev/virtio/random s

On Jul 25, 2015, at 2:10 AM, Mark R V Murray ma...@freebsd.org wrote: On 25 Jul 2015, at 06:06, Scott Long scott4l...@yahoo.com wrote: I’m working on a premise of “tools, not policy”. I’d like there to be enough harvesting points for the box owner to get the warm fuzzies. If they

Re: svn commit: r284959 - in head: . share/man/man4 share/man/man9 sys/conf sys/dev/glxsb sys/dev/hifn sys/dev/random sys/dev/rndtest sys/dev/safe sys/dev/syscons sys/dev/ubsec sys/dev/virtio/random s

On Jul 24, 2015, at 12:59 AM, Mark R V Murray ma...@freebsd.org wrote: On 24 Jul 2015, at 02:25, John-Mark Gurney j...@funkthat.com wrote: I would like to point out that the goal of collecting large amounts is starting to fall out of favor, and I happen to agree with the likes of

Re: svn commit: r284959 - in head: . share/man/man4 share/man/man9 sys/conf sys/dev/glxsb sys/dev/hifn sys/dev/random sys/dev/rndtest sys/dev/safe sys/dev/syscons sys/dev/ubsec sys/dev/virtio/random s

On Jul 23, 2015, at 1:03 AM, Mark R V Murray ma...@freebsd.org wrote: On 23 Jul 2015, at 00:53, Warner Losh i...@bsdimp.com wrote: Neither filesystem operations nor allocations are random events. They are trivially influenced by user code. A malicious attacker could create repeated

Re: svn commit: r282227 - head/sys/cam/scsi

This commit is broken, please revert: Fatal trap 12: page fault while in kernel mode cpuid = 0; apic id = 00 fault virtual address = 0x2102d8 fault code = supervisor read data, page not present instruction pointer = 0x20:0x802fd074 stack pointer =

Re: svn commit: r281451 - head/sys/vm

On Apr 26, 2015, at 11:13 PM, Julian Elischer jul...@freebsd.org wrote: On 4/26/15 3:28 AM, Scott Long wrote: Too early in boot to get a crashdump. but not too early for gdb live. Guys, seriously, the amount of unproductive comments from the sidelines is stupid. The commit was

Re: svn commit: r282064 - head/sys/boot/common

On Apr 27, 2015, at 1:40 AM, Garrett Cooper yaneurab...@gmail.com wrote: On Apr 27, 2015, at 0:38, Scott Long sco...@freebsd.org wrote: Author: scottl Date: Mon Apr 27 07:38:46 2015 New Revision: 282064 URL: https://svnweb.freebsd.org/changeset/base/282064 Log: Small change in

Re: svn commit: r281942 - head/sys/vm

On Apr 25, 2015, at 2:30 AM, Chagin Dmitry dcha...@freebsd.org wrote: On Fri, Apr 24, 2015 at 05:03:53PM +, Scott Long wrote: Author: scottl Date: Fri Apr 24 17:03:53 2015 New Revision: 281942 URL: https://svnweb.freebsd.org/changeset/base/281942 Log: Revert r281451. It causes a

Re: svn commit: r281451 - head/sys/vm

On Apr 25, 2015, at 1:06 AM, Chagin Dmitry dcha...@freebsd.org wrote: On Fri, Apr 24, 2015 at 05:37:21AM -0700, Chris Torek wrote: True, it's not actually odd, it's just surprising the first time one comes across it. Also, I goofed in the text: With the flexible array, (sizeof(struct

Re: svn commit: r281451 - head/sys/vm

On Apr 25, 2015, at 1:59 PM, Dmitry Morozovsky ma...@rinet.ru wrote: On Sat, 25 Apr 2015, Scott Long via svn-src-all wrote: True, it's not actually odd, it's just surprising the first time one comes across it. Also, I goofed in the text: With the flexible array, (sizeof(struct

Re: svn commit: r281451 - head/sys/vm

On Apr 23, 2015, at 6:19 AM, Scott Long scott4l...@yahoo.com wrote: On Apr 12, 2015, at 12:21 AM, Dmitry Chagin dcha...@freebsd.org wrote: Author: dchagin Date: Sun Apr 12 06:21:58 2015 New Revision: 281451 URL: https://svnweb.freebsd.org/changeset/base/281451 Log: Rework r281162.

Re: svn commit: r281451 - head/sys/vm

On Apr 12, 2015, at 12:21 AM, Dmitry Chagin dcha...@freebsd.org wrote: Author: dchagin Date: Sun Apr 12 06:21:58 2015 New Revision: 281451 URL: https://svnweb.freebsd.org/changeset/base/281451 Log: Rework r281162. Indeed, the flexible array member is preferable here. Suggested by:

Re: svn commit: r281451 - head/sys/vm

On Apr 23, 2015, at 1:28 PM, Chagin Dmitry dcha...@freebsd.org wrote: On Thu, Apr 23, 2015 at 12:49:51PM -0600, Scott Long wrote: On Apr 23, 2015, at 6:19 AM, Scott Long scott4l...@yahoo.com wrote: On Apr 12, 2015, at 12:21 AM, Dmitry Chagin dcha...@freebsd.org wrote: Author:

Re: svn commit: r279828 - head/sys/dev/cadence

On Mar 9, 2015, at 4:39 PM, Ian Lepore i...@freebsd.org wrote: Author: ian Date: Mon Mar 9 22:39:58 2015 New Revision: 279828 URL: https://svnweb.freebsd.org/changeset/base/279828 Log: Use the new ifnet API. Also, allocate bus_dma_maps as needed instead of pre-allocating them all

Re: svn commit: r277693 - head/sys/boot/forth

This is completely arbitrary. Please revert it, or I will revert it in 48 hours. Scott On Jan 25, 2015, at 4:57 AM, Dag-Erling Sm?rgrav d...@freebsd.org wrote: Author: des Date: Sun Jan 25 11:57:18 2015 New Revision: 277693 URL: https://svnweb.freebsd.org/changeset/base/277693 Log:

Re: svn commit: r274489 - in head/sys/amd64: amd64 include

On Nov 20, 2014, at 11:33 PM, Rui Paulo rpa...@me.com wrote: On Nov 13, 2014, at 14:11, Scott Long sco...@freebsd.org wrote: Author: scottl Date: Thu Nov 13 22:11:44 2014 New Revision: 274489 URL: https://svnweb.freebsd.org/changeset/base/274489 Log: Extend earlier addition of stack

Re: svn commit: r266481 - head/sys/x86/x86

On May 21, 2014, at 10:03 AM, Konstantin Belousov kostik...@gmail.com wrote: You changed the handling of the alignment, which is probably not correct. The problematic parameter, if any, is boundary. Thanks, this crept in when I re-formatted the code for check-in. I’ll fix it. Scott