Re: svn commit: r216134 - in head: share/man/man9 sys/amd64/include sys/arm/include sys/i386/include sys/ia64/include sys/mips/include sys/pc98/include sys/powerpc/include sys/sparc64/include sys/sun4

2010-12-03 Thread Bruce Cran
On Fri, 3 Dec 2010 20:45:12 +1100 (EST) Bruce Evans b...@optusnet.com.au wrote: KASSERT() in little inline functions gives a lot of bloat for such an unlikely error. Stupid callers can still pass any garbage count except 0. Yes, this catches a specific case that hps raised a few years ago:

Re: svn commit: r216134 - in head: share/man/man9 sys/amd64/include sys/arm/include sys/i386/include sys/ia64/include sys/mips/include sys/pc98/include sys/powerpc/include sys/sparc64/include sys/sun4

2010-12-03 Thread John Baldwin
On Friday, December 03, 2010 5:16:51 am Bruce Cran wrote: On Fri, 3 Dec 2010 20:45:12 +1100 (EST) Bruce Evans b...@optusnet.com.au wrote: KASSERT() in little inline functions gives a lot of bloat for such an unlikely error. Stupid callers can still pass any garbage count except 0.

Re: svn commit: r216134 - in head: share/man/man9 sys/amd64/include sys/arm/include sys/i386/include sys/ia64/include sys/mips/include sys/pc98/include sys/powerpc/include sys/sparc64/include sys/sun4

2010-12-03 Thread Ivan Voras
On 3 December 2010 13:46, John Baldwin j...@freebsd.org wrote: On Friday, December 03, 2010 5:16:51 am Bruce Cran wrote: On Fri, 3 Dec 2010 20:45:12 +1100 (EST) Bruce Evans b...@optusnet.com.au wrote: KASSERT() in little inline functions gives a lot of bloat for such an unlikely error.  

Re: svn commit: r216134 - in head: share/man/man9 sys/amd64/include sys/arm/include sys/i386/include sys/ia64/include sys/mips/include sys/pc98/include sys/powerpc/include sys/sparc64/include sys/sun4

2010-12-03 Thread Bruce Cran
On Fri, 3 Dec 2010 15:27:13 +0100 Ivan Voras ivo...@freebsd.org wrote: I'd say it depends on if the specific case that hps raised a few years ago sentence part refers to an actual problem; i.e. did it happen in practice? If yes, leaving KASSERTs looks like the best option. I've found hps's

Re: svn commit: r216134 - in head: share/man/man9 sys/amd64/include sys/arm/include sys/i386/include sys/ia64/include sys/mips/include sys/pc98/include sys/powerpc/include sys/sparc64/include sys/sun4

2010-12-03 Thread John Baldwin
On Friday, December 03, 2010 9:41:03 am Bruce Cran wrote: On Fri, 3 Dec 2010 15:27:13 +0100 Ivan Voras ivo...@freebsd.org wrote: I'd say it depends on if the specific case that hps raised a few years ago sentence part refers to an actual problem; i.e. did it happen in practice? If yes,

Re: svn commit: r216134 - in head: share/man/man9 sys/amd64/include sys/arm/include sys/i386/include sys/ia64/include sys/mips/include sys/pc98/include sys/powerpc/include sys/sparc64/include sys/sun4

2010-12-03 Thread Bruce Evans
On Fri, 3 Dec 2010, Bruce Cran wrote: On Fri, 3 Dec 2010 20:45:12 +1100 (EST) Bruce Evans b...@optusnet.com.au wrote: KASSERT() in little inline functions gives a lot of bloat for such an unlikely error. Stupid callers can still pass any garbage count except 0. Yes, this catches a specific