Re: svn commit: r241610 - in head: . sys/dev/usb sys/net sys/net80211 sys/netpfil/ipfw sys/netpfil/pf sys/sys

2012-10-27 Thread Adrian Chadd
On 26 October 2012 21:16, Rui Paulo rpa...@felyko.com wrote: I second Adrian's comments and I would like to add that you must NOT commit something like this, breaking the ABI, when you discussed this *ONE YEAR* ago with only two people (one of them is not very active in the networking

Re: svn commit: r241610 - in head: . sys/dev/usb sys/net sys/net80211 sys/netpfil/ipfw sys/netpfil/pf sys/sys

2012-10-27 Thread Gleb Smirnoff
On Fri, Oct 26, 2012 at 09:16:08PM -0700, Rui Paulo wrote: R I second Adrian's comments and I would like to add that you must NOT commit something like this, breaking the ABI, when you discussed this *ONE YEAR* ago with only two people (one of them is not very active in the networking stack).

Re: svn commit: r241610 - in head: . sys/dev/usb sys/net sys/net80211 sys/netpfil/ipfw sys/netpfil/pf sys/sys

2012-10-26 Thread Adrian Chadd
So with this change, you've broken building -HEAD net80211 on -9. Can we please sit down and make this work on both freebsd-9 and freebsd-head? I do a lot of wifi development on -9 with -HEAD wireless and this change broke everything for me. You could've at least asked the maintainers first

Re: svn commit: r241610 - in head: . sys/dev/usb sys/net sys/net80211 sys/netpfil/ipfw sys/netpfil/pf sys/sys

2012-10-26 Thread Rui Paulo
I second Adrian's comments and I would like to add that you must NOT commit something like this, breaking the ABI, when you discussed this *ONE YEAR* ago with only two people (one of them is not very active in the networking stack). This is against all reasonable software development practices.

svn commit: r241610 - in head: . sys/dev/usb sys/net sys/net80211 sys/netpfil/ipfw sys/netpfil/pf sys/sys

2012-10-16 Thread Gleb Smirnoff
Author: glebius Date: Tue Oct 16 13:37:54 2012 New Revision: 241610 URL: http://svn.freebsd.org/changeset/base/241610 Log: Make the struct if_clone opaque to users of the cloning API. Users now use function calls: if_clone_simple() if_clone_advanced() to initialize a cloner,