Re: svn commit: r308996 - head/lib/libfetch

2017-03-12 Thread Ngie Cooper
> On Mar 12, 2017, at 04:26, Dag-Erling Smørgrav wrote: > > "Ngie Cooper (yaneurabeya)" writes: >> Hi Bjoern, > > No, that was my father :) :D.. >>Shouldn’t this be strrchr instead of strchr since you’re >> scanning for the service from the right side

Re: svn commit: r308996 - head/lib/libfetch

2017-03-12 Thread Dag-Erling Smørgrav
"Ngie Cooper (yaneurabeya)" writes: > Hi Bjoern, No, that was my father :) > Shouldn’t this be strrchr instead of strchr since you’re > scanning for the service from the right side of the host, > e.g. “foo:service” or “[::1]:service”? This code would match index 3 >

Re: svn commit: r308996 - head/lib/libfetch

2017-03-11 Thread Ngie Cooper (yaneurabeya)
> On Nov 22, 2016, at 05:30, Dag-Erling Smørgrav wrote: > > Author: des > Date: Tue Nov 22 13:30:07 2016 > New Revision: 308996 > URL: https://svnweb.freebsd.org/changeset/base/308996 > > Log: > Refactor fetch_connect() and fetch_bind() to improve readability and avoid >

Re: svn commit: r308996 - head/lib/libfetch

2017-03-11 Thread Baptiste Daroussin
On Fri, Mar 03, 2017 at 01:29:26PM +0100, Dag-Erling Smørgrav wrote: > "Bjoern A. Zeeb" writes: > > Dag-Erling Smørgrav writes: > >> + /* split address if necessary */ > >> + err = EAI_SYSTEM; > >> + if ((sep = strchr(addr, ':')) != NULL) { > >> +

Re: svn commit: r308996 - head/lib/libfetch

2017-03-03 Thread Dag-Erling Smørgrav
"Bjoern A. Zeeb" writes: > Dag-Erling Smørgrav writes: >> +/* split address if necessary */ >> +err = EAI_SYSTEM; >> +if ((sep = strchr(addr, ':')) != NULL) { >> +len = snprintf(hbuf, sizeof(hbuf), >> +"%.*s",

Re: svn commit: r308996 - head/lib/libfetch

2017-02-28 Thread Bjoern A. Zeeb
On 22 Nov 2016, at 13:30, Dag-Erling Smørgrav wrote: Author: des Date: Tue Nov 22 13:30:07 2016 New Revision: 308996 URL: https://svnweb.freebsd.org/changeset/base/308996 Log: Refactor fetch_connect() and fetch_bind() to improve readability and avoid repeating the same DNS lookups.

Re: svn commit: r308996 - head/lib/libfetch

2016-11-30 Thread Jan Beich
Dag-Erling Smørgrav writes: > conn_t * > fetch_connect(const char *host, int port, int af, int verbose) > { [...] > + fetch_info("resolved"); Can you hide it behind "verbose" flag to avoid confusion? $ pkg The package management tool is not yet installed on your

svn commit: r308996 - head/lib/libfetch

2016-11-22 Thread Dag-Erling Smørgrav
Author: des Date: Tue Nov 22 13:30:07 2016 New Revision: 308996 URL: https://svnweb.freebsd.org/changeset/base/308996 Log: Refactor fetch_connect() and fetch_bind() to improve readability and avoid repeating the same DNS lookups. MFC after:3 weeks Modified: