Re: svn commit: r319487 - head/usr.sbin/bhyve

2017-06-11 Thread Marcelo Araujo
2017-06-11 2:35 GMT+08:00 Conrad Meyer : > On Sat, Jun 10, 2017 at 11:14 AM, Peter Grehan wrote: > > strncpy() is specified to zero-fill if the source is shorter than the > > length. Are we missing something ? > > > > The other issues you brought up look

Re: svn commit: r319487 - head/usr.sbin/bhyve

2017-06-10 Thread Conrad Meyer
On Sat, Jun 10, 2017 at 11:14 AM, Peter Grehan wrote: > strncpy() is specified to zero-fill if the source is shorter than the > length. Are we missing something ? > > The other issues you brought up look valid. Hi Peter, Oops — didn't realize that about strncpy()! Thanks

Re: svn commit: r319487 - head/usr.sbin/bhyve

2017-06-10 Thread Peter Grehan
Hi Conrad, Here, keystr is not zero initialized Note that strncpy below does not fill the remainder of the buffer with nuls if rc->password is shorter than 7 characters. +* The client then sends the resulting 16-bytes response. +*/ +#ifndef NO_OPENSSL +

Re: svn commit: r319487 - head/usr.sbin/bhyve

2017-06-10 Thread Conrad Meyer
Hi, Additionally, one more issue pointed out by Coverity below :-). On Thu, Jun 1, 2017 at 7:35 PM, Marcelo Araujo wrote: > Author: araujo > Date: Fri Jun 2 02:35:16 2017 > New Revision: 319487 > URL: https://svnweb.freebsd.org/changeset/base/319487 > > Log: > Add VNC

Re: svn commit: r319487 - head/usr.sbin/bhyve

2017-06-10 Thread Conrad Meyer
Forgot to mention — this one was CID 1375949. Additionally additionally, On Thu, Jun 1, 2017 at 7:35 PM, Marcelo Araujo wrote: > Author: araujo > Date: Fri Jun 2 02:35:16 2017 > New Revision: 319487 > URL: https://svnweb.freebsd.org/changeset/base/319487 > > Log: > Add

Re: svn commit: r319487 - head/usr.sbin/bhyve

2017-06-10 Thread Conrad Meyer
Hi, See inline comments below. On Thu, Jun 1, 2017 at 7:35 PM, Marcelo Araujo wrote: > Author: araujo > Date: Fri Jun 2 02:35:16 2017 > New Revision: 319487 > URL: https://svnweb.freebsd.org/changeset/base/319487 > > Log: > Add VNC Authentication support based on RFC6143

svn commit: r319487 - head/usr.sbin/bhyve

2017-06-01 Thread Marcelo Araujo
Author: araujo Date: Fri Jun 2 02:35:16 2017 New Revision: 319487 URL: https://svnweb.freebsd.org/changeset/base/319487 Log: Add VNC Authentication support based on RFC6143 section 7.2.2. Submitted by: Fabian Freyer Reworked by: myself Reviewed by: