Re: svn commit: r331306 - head/sys/dev/usb/controller

2018-03-22 Thread Hans Petter Selasky
On 03/22/18 13:02, Andrew Turner wrote: On 21 Mar 2018, at 21:54, Hans Petter Selasky wrote: On 03/21/18 17:45, Andrew Turner wrote: On 21 Mar 2018, at 15:37, Hans Petter Selasky wrote: On 03/21/18 16:24, Kyle Evans wrote: + { +

Re: svn commit: r331306 - head/sys/dev/usb/controller

2018-03-22 Thread Andrew Turner
> On 21 Mar 2018, at 21:54, Hans Petter Selasky wrote: > > On 03/21/18 17:45, Andrew Turner wrote: >>> On 21 Mar 2018, at 15:37, Hans Petter Selasky wrote: >>> >>> On 03/21/18 16:24, Kyle Evans wrote: > + { > + .ep_end = 7, >

Re: svn commit: r331306 - head/sys/dev/usb/controller

2018-03-21 Thread Hans Petter Selasky
On 03/21/18 17:45, Andrew Turner wrote: On 21 Mar 2018, at 15:37, Hans Petter Selasky wrote: On 03/21/18 16:24, Kyle Evans wrote: + { + .ep_end = 7, + .ep_fifosz_shift = 9, + .ep_fifosz_reg = MUSB2_VAL_FIFOSZ_512 |

Re: svn commit: r331306 - head/sys/dev/usb/controller

2018-03-21 Thread Andrew Turner
> On 21 Mar 2018, at 15:37, Hans Petter Selasky wrote: > > On 03/21/18 16:24, Kyle Evans wrote: >>> + { >>> + .ep_end = 7, >>> + .ep_fifosz_shift = 9, >>> + .ep_fifosz_reg = MUSB2_VAL_FIFOSZ_512 | MUSB2_MASK_FIFODB, >>> +

Re: svn commit: r331306 - head/sys/dev/usb/controller

2018-03-21 Thread Hans Petter Selasky
On 03/21/18 16:24, Kyle Evans wrote: + { + .ep_end = 7, + .ep_fifosz_shift = 9, + .ep_fifosz_reg = MUSB2_VAL_FIFOSZ_512 | MUSB2_MASK_FIFODB, + }, I'm afraid I'm not familiar with this- why did .ep_fifosz_shift for this case drop to 9? frx =

Re: svn commit: r331306 - head/sys/dev/usb/controller

2018-03-21 Thread Kyle Evans
On Wed, Mar 21, 2018 at 10:17 AM, Andrew Turner wrote: > Author: andrew > Date: Wed Mar 21 15:17:54 2018 > New Revision: 331306 > URL: https://svnweb.freebsd.org/changeset/base/331306 > > Log: > Use a table to find the endpoint configuration > > On the Allwinner SoCs we

svn commit: r331306 - head/sys/dev/usb/controller

2018-03-21 Thread Andrew Turner
Author: andrew Date: Wed Mar 21 15:17:54 2018 New Revision: 331306 URL: https://svnweb.freebsd.org/changeset/base/331306 Log: Use a table to find the endpoint configuration On the Allwinner SoCs we need to set a custom endpoint configuration. To allow for this use a table to store the