Re: svn commit: r333819 - in head/sys: conf modules/blake2 modules/crypto modules/drm2/i915kms modules/ipfilter

2018-05-19 Thread Matthew Macy 
As I suspected, we fix warnings on non-contrib code. These are only
used on contrib code.
-M

mmacy@anarchy [~/devel/upstream|9:46|26] find sys | xargs grep NO_WSELF_ASSIGN
sys/modules/ipfilter/Makefile:CWARNFLAGS.fil.c=
${NO_WSELF_ASSIGN} -Wno-unused
sys/modules/ipfilter/Makefile:CWARNFLAGS.ip_lookup.c=
${NO_WSELF_ASSIGN} -Wno-unused
sys/modules/ipfilter/Makefile:CWARNFLAGS.ip_proxy.c=
${NO_WSELF_ASSIGN} -Wno-unused
sys/conf/kern.mk:NO_WSELF_ASSIGN=   -Wno-self-assign
sys/conf/files: compile-with "${NORMAL_C} ${NO_WSELF_ASSIGN}
-Wno-unused -I$S/contrib/ipfilter"
sys/conf/files: compile-with "${NORMAL_C} ${NO_WSELF_ASSIGN}
-Wno-unused -I$S/contrib/ipfilter"
sys/conf/files: compile-with "${NORMAL_C} ${NO_WSELF_ASSIGN}
-Wno-unused -Wno-error -I$S/contrib/ipfilter"
mmacy@anarchy [~/devel/upstream|9:47|27] find sys | xargs grep
NO_WSHIFT_COUNT_NEGATIVE
sys/modules/ath_hal/Makefile:CWARNFLAGS.ah_regdomain.c=
${NO_WSHIFT_COUNT_NEGATIVE} ${NO_WSHIFT_COUNT_OVERFLOW}
sys/conf/kern.mk:NO_WSHIFT_COUNT_NEGATIVE=  -Wno-shift-count-negative
sys/conf/files: compile-with "${NORMAL_C} ${NO_WSHIFT_COUNT_NEGATIVE}
${NO_WSHIFT_COUNT_OVERFLOW} -I$S/dev/ath"
mmacy@anarchy [~/devel/upstream|9:47|28] find sys | xargs grep
NO_WSHIFT_COUNT_OVERFLOW
sys/modules/ath_hal/Makefile:CWARNFLAGS.ah_regdomain.c=
${NO_WSHIFT_COUNT_NEGATIVE} ${NO_WSHIFT_COUNT_OVERFLOW}
sys/conf/kern.mk:NO_WSHIFT_COUNT_OVERFLOW=  -Wno-shift-count-overflow
sys/conf/files: compile-with "${NORMAL_C} ${NO_WSHIFT_COUNT_NEGATIVE}
${NO_WSHIFT_COUNT_OVERFLOW} -I$S/dev/ath"

On Sat, May 19, 2018 at 5:30 AM, Matthew Macy  wrote:
> Oops I’ll add a separate define for that
>
> On Sat, May 19, 2018 at 04:27 Ed Maste  wrote:
>>
>> On 18 May 2018 at 20:04, Matt Macy  wrote:
>> > Author: mmacy
>> > Date: Sat May 19 00:04:01 2018
>> > New Revision: 333819
>> > URL: https://svnweb.freebsd.org/changeset/base/333819
>> >
>> > Log:
>> >   Silence non-actionable warnings in vendor code
>> ...
>> > Modified: head/sys/conf/kern.mk
>> >
>> > ==
>> > --- head/sys/conf/kern.mk   Fri May 18 23:42:08 2018
>> > (r333818)
>> > +++ head/sys/conf/kern.mk   Sat May 19 00:04:01 2018
>> > (r333819)
>> > @@ -18,12 +18,13 @@ CWARNFLAGS?=-Wall -Wredundant-decls
>> > -Wnested-externs
>> >  # a false positive.
>> >  .if ${COMPILER_TYPE} == "clang"
>> >  NO_WCONSTANT_CONVERSION=   -Wno-error-constant-conversion
>> > -NO_WSHIFT_COUNT_NEGATIVE=  -Wno-error-shift-count-negative
>> > -NO_WSHIFT_COUNT_OVERFLOW=  -Wno-error-shift-count-overflow
>> > -NO_WSELF_ASSIGN=   -Wno-error-self-assign
>> > +NO_WSHIFT_COUNT_NEGATIVE=  -Wno-shift-count-negative
>> > +NO_WSHIFT_COUNT_OVERFLOW=  -Wno-shift-count-overflow
>> > +NO_WSELF_ASSIGN=   -Wno-self-assign
>>
>> This silences the warning across the tree, not just vendor code.
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Re: svn commit: r333819 - in head/sys: conf modules/blake2 modules/crypto modules/drm2/i915kms modules/ipfilter

2018-05-19 Thread Matthew Macy 
Oops I’ll add a separate define for that

On Sat, May 19, 2018 at 04:27 Ed Maste  wrote:

> On 18 May 2018 at 20:04, Matt Macy  wrote:
> > Author: mmacy
> > Date: Sat May 19 00:04:01 2018
> > New Revision: 333819
> > URL: https://svnweb.freebsd.org/changeset/base/333819
> >
> > Log:
> >   Silence non-actionable warnings in vendor code
> ...
> > Modified: head/sys/conf/kern.mk
> >
> ==
> > --- head/sys/conf/kern.mk   Fri May 18 23:42:08 2018
> (r333818)
> > +++ head/sys/conf/kern.mk   Sat May 19 00:04:01 2018
> (r333819)
> > @@ -18,12 +18,13 @@ CWARNFLAGS?=-Wall -Wredundant-decls
> -Wnested-externs
> >  # a false positive.
> >  .if ${COMPILER_TYPE} == "clang"
> >  NO_WCONSTANT_CONVERSION=   -Wno-error-constant-conversion
> > -NO_WSHIFT_COUNT_NEGATIVE=  -Wno-error-shift-count-negative
> > -NO_WSHIFT_COUNT_OVERFLOW=  -Wno-error-shift-count-overflow
> > -NO_WSELF_ASSIGN=   -Wno-error-self-assign
> > +NO_WSHIFT_COUNT_NEGATIVE=  -Wno-shift-count-negative
> > +NO_WSHIFT_COUNT_OVERFLOW=  -Wno-shift-count-overflow
> > +NO_WSELF_ASSIGN=   -Wno-self-assign
>
> This silences the warning across the tree, not just vendor code.
>
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Re: svn commit: r333819 - in head/sys: conf modules/blake2 modules/crypto modules/drm2/i915kms modules/ipfilter

2018-05-19 Thread Ed Maste 
On 18 May 2018 at 20:04, Matt Macy  wrote:
> Author: mmacy
> Date: Sat May 19 00:04:01 2018
> New Revision: 333819
> URL: https://svnweb.freebsd.org/changeset/base/333819
>
> Log:
>   Silence non-actionable warnings in vendor code
...
> Modified: head/sys/conf/kern.mk
> ==
> --- head/sys/conf/kern.mk   Fri May 18 23:42:08 2018(r333818)
> +++ head/sys/conf/kern.mk   Sat May 19 00:04:01 2018(r333819)
> @@ -18,12 +18,13 @@ CWARNFLAGS?=-Wall -Wredundant-decls 
> -Wnested-externs
>  # a false positive.
>  .if ${COMPILER_TYPE} == "clang"
>  NO_WCONSTANT_CONVERSION=   -Wno-error-constant-conversion
> -NO_WSHIFT_COUNT_NEGATIVE=  -Wno-error-shift-count-negative
> -NO_WSHIFT_COUNT_OVERFLOW=  -Wno-error-shift-count-overflow
> -NO_WSELF_ASSIGN=   -Wno-error-self-assign
> +NO_WSHIFT_COUNT_NEGATIVE=  -Wno-shift-count-negative
> +NO_WSHIFT_COUNT_OVERFLOW=  -Wno-shift-count-overflow
> +NO_WSELF_ASSIGN=   -Wno-self-assign

This silences the warning across the tree, not just vendor code.
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

svn commit: r333819 - in head/sys: conf modules/blake2 modules/crypto modules/drm2/i915kms modules/ipfilter

2018-05-18 Thread Matt Macy 
Author: mmacy
Date: Sat May 19 00:04:01 2018
New Revision: 333819
URL: https://svnweb.freebsd.org/changeset/base/333819

Log:
  Silence non-actionable warnings in vendor code
  
  We can't modify vendor code so there's no signal in warnings from it.
  Similarly -Waddress-of-packed-member is not useful on networking code
  as access to packed structures is fundamental to its operation.

Modified:
  head/sys/conf/files
  head/sys/conf/kern.mk
  head/sys/modules/blake2/Makefile
  head/sys/modules/crypto/Makefile
  head/sys/modules/drm2/i915kms/Makefile
  head/sys/modules/ipfilter/Makefile

Modified: head/sys/conf/files
==
--- head/sys/conf/files Fri May 18 23:42:08 2018(r333818)
+++ head/sys/conf/files Sat May 19 00:04:01 2018(r333819)
@@ -565,7 +565,7 @@ contrib/ipfilter/netinet/ip_lookup.c optional ipfilter
 contrib/ipfilter/netinet/ip_pool.c optional ipfilter inet \
compile-with "${NORMAL_C} -Wno-unused -I$S/contrib/ipfilter"
 contrib/ipfilter/netinet/ip_htable.c optional ipfilter inet \
-   compile-with "${NORMAL_C} -Wno-unused -I$S/contrib/ipfilter"
+   compile-with "${NORMAL_C} -Wno-unused -I$S/contrib/ipfilter 
${NO_WTAUTOLOGICAL_POINTER_COMPARE}"
 contrib/ipfilter/netinet/ip_sync.c optional ipfilter inet \
compile-with "${NORMAL_C} -Wno-unused -I$S/contrib/ipfilter"
 contrib/ipfilter/netinet/mlfk_ipl.c optional ipfilter inet \

Modified: head/sys/conf/kern.mk
==
--- head/sys/conf/kern.mk   Fri May 18 23:42:08 2018(r333818)
+++ head/sys/conf/kern.mk   Sat May 19 00:04:01 2018(r333819)
@@ -18,12 +18,13 @@ CWARNFLAGS?=-Wall -Wredundant-decls 
-Wnested-externs 
 # a false positive.
 .if ${COMPILER_TYPE} == "clang"
 NO_WCONSTANT_CONVERSION=   -Wno-error-constant-conversion
-NO_WSHIFT_COUNT_NEGATIVE=  -Wno-error-shift-count-negative
-NO_WSHIFT_COUNT_OVERFLOW=  -Wno-error-shift-count-overflow
-NO_WSELF_ASSIGN=   -Wno-error-self-assign
+NO_WSHIFT_COUNT_NEGATIVE=  -Wno-shift-count-negative
+NO_WSHIFT_COUNT_OVERFLOW=  -Wno-shift-count-overflow
+NO_WSELF_ASSIGN=   -Wno-self-assign
 NO_WUNNEEDED_INTERNAL_DECL=-Wno-error-unneeded-internal-declaration
 NO_WSOMETIMES_UNINITIALIZED=   -Wno-error-sometimes-uninitialized
 NO_WCAST_QUAL= -Wno-error-cast-qual
+NO_WTAUTOLOGICAL_POINTER_COMPARE= -Wno-tautological-pointer-compare
 # Several other warnings which might be useful in some cases, but not severe
 # enough to error out the whole kernel build.  Display them anyway, so there is
 # some incentive to fix them eventually.
@@ -34,7 +35,7 @@ CWARNEXTRA?=  -Wno-error-tautological-compare -Wno-erro
 CWARNEXTRA+=   -Wno-error-shift-negative-value
 .endif
 .if ${COMPILER_VERSION} >= 4
-CWARNEXTRA+=   -Wno-error-address-of-packed-member
+CWARNEXTRA+=   -Wno-address-of-packed-member
 .endif
 
 CLANG_NO_IAS= -no-integrated-as

Modified: head/sys/modules/blake2/Makefile
==
--- head/sys/modules/blake2/MakefileFri May 18 23:42:08 2018
(r333818)
+++ head/sys/modules/blake2/MakefileSat May 19 00:04:01 2018
(r333819)
@@ -87,4 +87,5 @@ WARNS ?= 6
 .include 
 
 CWARNFLAGS.blake2-dispatch.c   +=  -Wno-unused-const-variable
+CWARNFLAGS.blake2s-ref.c   +=  -Wno-cast-qual -Wno-unused-function
 CWARNFLAGS +=  -Wno-cast-qual

Modified: head/sys/modules/crypto/Makefile
==
--- head/sys/modules/crypto/MakefileFri May 18 23:42:08 2018
(r333818)
+++ head/sys/modules/crypto/MakefileSat May 19 00:04:01 2018
(r333819)
@@ -40,8 +40,8 @@ SRCS  += blake2-sw.c
 CFLAGS.blake2b-ref.c   += -I${SRCTOP}/sys/crypto/blake2 -DSUFFIX=_ref
 CFLAGS.blake2s-ref.c   += -I${SRCTOP}/sys/crypto/blake2 -DSUFFIX=_ref
 CFLAGS.blake2-sw.c += -I${SRCTOP}/sys/crypto/blake2
-CWARNFLAGS.blake2b-ref.c   += -Wno-cast-qual
-CWARNFLAGS.blake2s-ref.c   += -Wno-cast-qual
+CWARNFLAGS.blake2b-ref.c   += -Wno-cast-qual -Wno-unused-function
+CWARNFLAGS.blake2s-ref.c   += -Wno-cast-qual -Wno-unused-function
 SRCS   += chacha.c
 SRCS   += chacha-sw.c
 SRCS   += opt_param.h cryptodev_if.h bus_if.h device_if.h

Modified: head/sys/modules/drm2/i915kms/Makefile
==
--- head/sys/modules/drm2/i915kms/Makefile  Fri May 18 23:42:08 2018
(r333818)
+++ head/sys/modules/drm2/i915kms/Makefile  Sat May 19 00:04:01 2018
(r333819)
@@ -63,3 +63,8 @@ SRCS  +=  
\
 CWARNFLAGS.i915_debug.c=   -Wno-unused-function
 CWARNFLAGS.intel_lvds.c=   -Wno-unused
 CWARNFLAGS.intel_tv.c= -Wno-unused