Re: svn commit: r334128 - in head: . lib/libpmcstat lib/libpmcstat/pmu-events lib/libpmcstat/pmu-events/arch lib/libpmcstat/pmu-events/arch/arm64 lib/libpmcstat/pmu-events/arch/arm64/arm lib/libpmcsta

2018-05-25 Thread Bryan Drewery 
On 5/23/2018 9:30 PM, Matt Macy wrote:
> Author: mmacy
> Date: Thu May 24 04:30:06 2018
> New Revision: 334128
> URL: https://svnweb.freebsd.org/changeset/base/334128
> 
> Log:
>   libpmcstat: compile in events based on json description
> 
> Added:
>   head/lib/libpmcstat/libpmcstat_pmu_util.c   (contents, props changed)
>   head/lib/libpmcstat/pmu-events/
>   head/lib/libpmcstat/pmu-events/Makefile   (contents, props changed)

...

> # cat lib/libpmcstat/pmu-events/Makefile
> # $FreeBSD$
> 
> PROG=jevents
> SRCS=jevents.c jsmn.c json.c
> CFLAGS+= -Wno-cast-qual
> .PATH: ${.CURDIR}
> build-tools: jevents
> MAN=
> .include 

Several things wrong here and in lib/libpmcstat/Makefile

1. Newlines? Existing style from other Makefiles? style.Makefile(5)
2. .PATH implicitly has .CURDIR in it already.
3. Need special META_MODE handling for the build-tools target. I don't
necessarily expect people to get this right but every other use of
build-tools in the tree has a pattern that isn't used here.
4. You used HOST_OBJTOP in lib/libpmcstat/Makefile to refer to jevents
for some reason when nothing else does. This is really just the
META_MODE pattern being wrong.

I'm fixing all of this.

-- 
Regards,
Bryan Drewery



signature.asc
Description: OpenPGP digital signature

Re: svn commit: r334128 - in head: . lib/libpmcstat lib/libpmcstat/pmu-events lib/libpmcstat/pmu-events/arch lib/libpmcstat/pmu-events/arch/arm64 lib/libpmcstat/pmu-events/arch/arm64/arm lib/libpmcsta

2018-05-24 Thread Matthew Macy 
On Thu, May 24, 2018 at 3:36 PM, John Baldwin  wrote:
> On Thursday, May 24, 2018 04:30:06 AM Matt Macy wrote:
>> Author: mmacy
>> Date: Thu May 24 04:30:06 2018
>> New Revision: 334128
>> URL: https://svnweb.freebsd.org/changeset/base/334128
>>
>> Log:
>>   libpmcstat: compile in events based on json description
>
> Please provide more detail for commits like this in the future.  Some 
> questions
> I have some of which probably should have been answered in the log:
>
> - Why does this matter?  For example, does this provide counters for a CPUs
>   we don't currently support counters on?
> - Does this supplant the existing tables of counters in hwpmc or is this
>   a different set of counters (or how do these counter tables interact with
>   our existing tables in general)?
> - What is the origin of these json files?  What is the license?  These seem to
>   come straight from the Linux kernel which should be acknowledged via
>   Obtained from: at the very least.  It does seem that the jevents source is
>   explicitly BSD licensed (2 clause).  This is noted in the git logs in the
>   Linux tree.  However, I couldn't find a clear statement on the json files
>   themselves and what their license is.  Are you aware of a license for those
>   or do they fall under the GPLv2 "default" license in /COPYING of the Linux
>   source tree?

At least the Intel ones come from Intel where everything is BSD
licensed. If the others are GPL I'll move it all to a port.
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Re: svn commit: r334128 - in head: . lib/libpmcstat lib/libpmcstat/pmu-events lib/libpmcstat/pmu-events/arch lib/libpmcstat/pmu-events/arch/arm64 lib/libpmcstat/pmu-events/arch/arm64/arm lib/libpmcsta

2018-05-24 Thread John Baldwin 
On Thursday, May 24, 2018 04:30:06 AM Matt Macy wrote:
> Author: mmacy
> Date: Thu May 24 04:30:06 2018
> New Revision: 334128
> URL: https://svnweb.freebsd.org/changeset/base/334128
> 
> Log:
>   libpmcstat: compile in events based on json description

Please provide more detail for commits like this in the future.  Some questions
I have some of which probably should have been answered in the log:

- Why does this matter?  For example, does this provide counters for a CPUs
  we don't currently support counters on?
- Does this supplant the existing tables of counters in hwpmc or is this
  a different set of counters (or how do these counter tables interact with
  our existing tables in general)?
- What is the origin of these json files?  What is the license?  These seem to
  come straight from the Linux kernel which should be acknowledged via
  Obtained from: at the very least.  It does seem that the jevents source is
  explicitly BSD licensed (2 clause).  This is noted in the git logs in the
  Linux tree.  However, I couldn't find a clear statement on the json files
  themselves and what their license is.  Are you aware of a license for those
  or do they fall under the GPLv2 "default" license in /COPYING of the Linux
  source tree?

-- 
John Baldwin
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Re: svn commit: r334128 - in head: . lib/libpmcstat lib/libpmcstat/pmu-events lib/libpmcstat/pmu-events/arch lib/libpmcstat/pmu-events/arch/arm64 lib/libpmcstat/pmu-events/arch/arm64/arm lib/libpmcsta

2018-05-24 Thread Matthew Macy 
Ugh. Not intentional

On Thu, May 24, 2018 at 02:35 Sergey Kandaurov  wrote:

> On 24 May 2018 at 07:30, Matt Macy  wrote:
>
>> Author: mmacy
>> Date: Thu May 24 04:30:06 2018
>> New Revision: 334128
>> URL: https://svnweb.freebsd.org/changeset/base/334128
>>
>> Log:
>>   libpmcstat: compile in events based on json description
>>
> [...]
>
>
>>
>> Modified: head/Makefile
>>
>> ==
>> --- head/Makefile   Thu May 24 03:44:12 2018(r334127)
>> +++ head/Makefile   Thu May 24 04:30:06 2018(r334128)
>> @@ -481,7 +481,8 @@ worlds: .PHONY
>>  # existing system is.
>>  #
>>  .if make(universe) || make(universe_kernels) || make(tinderbox) ||
>> make(targets)
>> -TARGETS?=amd64 arm arm64 i386 mips powerpc riscv sparc64
>> +TARGETS?=amd64 i386 powerpc arm64
>> +#riscv arm  sparc64 mips
>>  _UNIVERSE_TARGETS= ${TARGETS}
>>  TARGET_ARCHES_arm?=arm armeb armv6 armv7
>>  TARGET_ARCHES_arm64?=  aarch64
>>
>
> Why? Looks like a debug leftover.
>
> --
> wbr,
> pluknet
>
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Re: svn commit: r334128 - in head: . lib/libpmcstat lib/libpmcstat/pmu-events lib/libpmcstat/pmu-events/arch lib/libpmcstat/pmu-events/arch/arm64 lib/libpmcstat/pmu-events/arch/arm64/arm lib/libpmcsta

2018-05-24 Thread Rodney W. Grimes 
[ Charset UTF-8 unsupported, converting... ]
> Author: mmacy
> Date: Thu May 24 04:30:06 2018
> New Revision: 334128
> URL: https://svnweb.freebsd.org/changeset/base/334128
> 
> Log:
>   libpmcstat: compile in events based on json description

Most of this has no copyright or license attached to the files.


> Added:
>   head/lib/libpmcstat/libpmcstat_pmu_util.c   (contents, props changed)
>   head/lib/libpmcstat/pmu-events/
>   head/lib/libpmcstat/pmu-events/Makefile   (contents, props changed)
>   head/lib/libpmcstat/pmu-events/README   (contents, props changed)
>   head/lib/libpmcstat/pmu-events/arch/
>   head/lib/libpmcstat/pmu-events/arch/arm64/
>   head/lib/libpmcstat/pmu-events/arch/arm64/arm/
>   head/lib/libpmcstat/pmu-events/arch/arm64/arm/cortex-a53/
>   head/lib/libpmcstat/pmu-events/arch/arm64/arm/cortex-a53/branch.json   
> (contents, props changed)
>   head/lib/libpmcstat/pmu-events/arch/arm64/arm/cortex-a53/bus.json   
> (contents, props changed)
>   head/lib/libpmcstat/pmu-events/arch/arm64/arm/cortex-a53/cache.json   
> (contents, props changed)
>   head/lib/libpmcstat/pmu-events/arch/arm64/arm/cortex-a53/memory.json   
> (contents, props changed)
>   head/lib/libpmcstat/pmu-events/arch/arm64/arm/cortex-a53/other.json   
> (contents, props changed)
>   head/lib/libpmcstat/pmu-events/arch/arm64/arm/cortex-a53/pipeline.json   
> (contents, props changed)
>   head/lib/libpmcstat/pmu-events/arch/arm64/armv8-recommended.json   
> (contents, props changed)
>   head/lib/libpmcstat/pmu-events/arch/arm64/cavium/
>   head/lib/libpmcstat/pmu-events/arch/arm64/cavium/thunderx2/
>   
> head/lib/libpmcstat/pmu-events/arch/arm64/cavium/thunderx2/core-imp-def.json  
>  (contents, props changed)
>   head/lib/libpmcstat/pmu-events/arch/arm64/hisilicon/
>   head/lib/libpmcstat/pmu-events/arch/arm64/hisilicon/hip08/
>   head/lib/libpmcstat/pmu-events/arch/arm64/hisilicon/hip08/core-imp-def.json 
>   (contents, props changed)
>   head/lib/libpmcstat/pmu-events/arch/arm64/mapfile.csv   (contents, props 
> changed)
>   head/lib/libpmcstat/pmu-events/arch/powerpc/
>   head/lib/libpmcstat/pmu-events/arch/powerpc/mapfile.csv   (contents, props 
> changed)
>   head/lib/libpmcstat/pmu-events/arch/powerpc/power8/
>   head/lib/libpmcstat/pmu-events/arch/powerpc/power8/cache.json   (contents, 
> props changed)
>   head/lib/libpmcstat/pmu-events/arch/powerpc/power8/floating-point.json   
> (contents, props changed)
>   head/lib/libpmcstat/pmu-events/arch/powerpc/power8/frontend.json   
> (contents, props changed)
>   head/lib/libpmcstat/pmu-events/arch/powerpc/power8/marked.json   (contents, 
> props changed)
>   head/lib/libpmcstat/pmu-events/arch/powerpc/power8/memory.json   (contents, 
> props changed)
>   head/lib/libpmcstat/pmu-events/arch/powerpc/power8/other.json   (contents, 
> props changed)
>   head/lib/libpmcstat/pmu-events/arch/powerpc/power8/pipeline.json   
> (contents, props changed)
>   head/lib/libpmcstat/pmu-events/arch/powerpc/power8/pmc.json   (contents, 
> props changed)
>   head/lib/libpmcstat/pmu-events/arch/powerpc/power8/translation.json   
> (contents, props changed)
>   head/lib/libpmcstat/pmu-events/arch/powerpc/power9/
>   head/lib/libpmcstat/pmu-events/arch/powerpc/power9/cache.json   (contents, 
> props changed)
>   head/lib/libpmcstat/pmu-events/arch/powerpc/power9/floating-point.json   
> (contents, props changed)
>   head/lib/libpmcstat/pmu-events/arch/powerpc/power9/frontend.json   
> (contents, props changed)
>   head/lib/libpmcstat/pmu-events/arch/powerpc/power9/marked.json   (contents, 
> props changed)
>   head/lib/libpmcstat/pmu-events/arch/powerpc/power9/memory.json   (contents, 
> props changed)
>   head/lib/libpmcstat/pmu-events/arch/powerpc/power9/other.json   (contents, 
> props changed)
>   head/lib/libpmcstat/pmu-events/arch/powerpc/power9/pipeline.json   
> (contents, props changed)
>   head/lib/libpmcstat/pmu-events/arch/powerpc/power9/pmc.json   (contents, 
> props changed)
>   head/lib/libpmcstat/pmu-events/arch/powerpc/power9/translation.json   
> (contents, props changed)
>   head/lib/libpmcstat/pmu-events/arch/s390/
>   head/lib/libpmcstat/pmu-events/arch/s390/cf_z10/
>   head/lib/libpmcstat/pmu-events/arch/s390/cf_z10/basic.json   (contents, 
> props changed)
>   head/lib/libpmcstat/pmu-events/arch/s390/cf_z10/crypto.json   (contents, 
> props changed)
>   head/lib/libpmcstat/pmu-events/arch/s390/cf_z10/extended.json   (contents, 
> props changed)
>   head/lib/libpmcstat/pmu-events/arch/s390/cf_z13/
>   head/lib/libpmcstat/pmu-events/arch/s390/cf_z13/basic.json   (contents, 
> props changed)
>   head/lib/libpmcstat/pmu-events/arch/s390/cf_z13/crypto.json   (contents, 
> props changed)
>   head/lib/libpmcstat/pmu-events/arch/s390/cf_z13/extended.json   (contents, 
> props changed)
>   head/lib/libpmcstat/pmu-events/arch/s390/cf_z14/
>   head/lib/libpmcstat/pmu-events/arch/s390/cf_z14/basic.json   (contents, 
> props changed)
>

Re: svn commit: r334128 - in head: . lib/libpmcstat lib/libpmcstat/pmu-events lib/libpmcstat/pmu-events/arch lib/libpmcstat/pmu-events/arch/arm64 lib/libpmcstat/pmu-events/arch/arm64/arm lib/libpmcsta

2018-05-24 Thread Sergey Kandaurov 
On 24 May 2018 at 07:30, Matt Macy  wrote:

> Author: mmacy
> Date: Thu May 24 04:30:06 2018
> New Revision: 334128
> URL: https://svnweb.freebsd.org/changeset/base/334128
>
> Log:
>   libpmcstat: compile in events based on json description
> [...]
>
> Modified: head/Makefile
> 
> ==
> --- head/Makefile   Thu May 24 03:44:12 2018(r334127)
> +++ head/Makefile   Thu May 24 04:30:06 2018(r334128)
> @@ -481,7 +481,8 @@ worlds: .PHONY
>  # existing system is.
>  #
>  .if make(universe) || make(universe_kernels) || make(tinderbox) ||
> make(targets)
> -TARGETS?=amd64 arm arm64 i386 mips powerpc riscv sparc64
> +TARGETS?=amd64 i386 powerpc arm64
> +#riscv arm  sparc64 mips
>  _UNIVERSE_TARGETS= ${TARGETS}
>  TARGET_ARCHES_arm?=arm armeb armv6 armv7
>  TARGET_ARCHES_arm64?=  aarch64
>

Why? Looks like a debug leftover.

-- 
wbr,
pluknet
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"