Re: svn commit: r358152 - head/bin/sh

2020-02-22 Thread Pedro Giffuni
For the record ... On 21/02/2020 22:31, Kyle Evans wrote: On Fri, Feb 21, 2020 at 3:53 PM Li-Wen Hsu wrote: On Sat, Feb 22, 2020 at 4:58 AM Antoine Brodin wrote: On Thu, Feb 20, 2020 at 4:01 AM Hiroki Sato wrote: Author: hrs Date: Thu Feb 20 03:01:27 2020 New Revision: 358152 URL:

Re: svn commit: r358152 - head/bin/sh

2020-02-22 Thread Hiroki Sato
Conrad Meyer wrote in : ce> Given the report and looking at the change, I suspect the problem is ce> the promotion of '-residue' from size_t (unsigned 32-bit on i386) to ce> off_t (signed 64-bit). Something like '-(off_t)residue' or even ce> 'off_t residue;' should fix it. Yes, r358235 is

Re: svn commit: r358152 - head/bin/sh

2020-02-21 Thread Kyle Evans
On Fri, Feb 21, 2020 at 3:53 PM Li-Wen Hsu wrote: > > On Sat, Feb 22, 2020 at 4:58 AM Antoine Brodin wrote: > > > > On Thu, Feb 20, 2020 at 4:01 AM Hiroki Sato wrote: > > > > > > Author: hrs > > > Date: Thu Feb 20 03:01:27 2020 > > > New Revision: 358152 > > > URL:

Re: svn commit: r358152 - head/bin/sh

2020-02-21 Thread Conrad Meyer
Given the report and looking at the change, I suspect the problem is the promotion of '-residue' from size_t (unsigned 32-bit on i386) to off_t (signed 64-bit). Something like '-(off_t)residue' or even 'off_t residue;' should fix it. Repro: static void myoff(off_t foo) { printf("%jd\n",

Re: svn commit: r358152 - head/bin/sh

2020-02-21 Thread Li-Wen Hsu
On Sat, Feb 22, 2020 at 4:58 AM Antoine Brodin wrote: > > On Thu, Feb 20, 2020 at 4:01 AM Hiroki Sato wrote: > > > > Author: hrs > > Date: Thu Feb 20 03:01:27 2020 > > New Revision: 358152 > > URL: https://svnweb.freebsd.org/changeset/base/358152 > > > > Log: > > Improve performance of "read"

Re: svn commit: r358152 - head/bin/sh

2020-02-21 Thread Antoine Brodin
On Thu, Feb 20, 2020 at 4:01 AM Hiroki Sato wrote: > > Author: hrs > Date: Thu Feb 20 03:01:27 2020 > New Revision: 358152 > URL: https://svnweb.freebsd.org/changeset/base/358152 > > Log: > Improve performance of "read" built-in command when using a seekable > fd. > > The read built-in

svn commit: r358152 - head/bin/sh

2020-02-19 Thread Hiroki Sato
Author: hrs Date: Thu Feb 20 03:01:27 2020 New Revision: 358152 URL: https://svnweb.freebsd.org/changeset/base/358152 Log: Improve performance of "read" built-in command when using a seekable fd. The read built-in command calls read(2) with a 1-byte buffer because newline characters