Re: svn commit: r358167 - head/sys/netinet6

2020-02-25 Thread Bjoern A. Zeeb
On 25 Feb 2020, at 12:44, Kristof Provost wrote: This change introduces a slight regression when a host replies to IPv6 ping fragmented packets. The problem is the "unfragpartlen" must also be set in the else case of "if (opt)", else the payload offset computation for IPv6 fragments goes

Re: svn commit: r358167 - head/sys/netinet6

2020-02-25 Thread Kristof Provost
On 24 Feb 2020, at 15:21, Hans Petter Selasky wrote: On 2020-02-20 11:56, Bjoern A. Zeeb wrote: + + unfragpartlen = optlen + sizeof(struct ip6_hdr); + Hi Bjoren, This change introduces a slight regression when a host replies to IPv6 ping fragmented packets. The problem is the

Re: svn commit: r358167 - head/sys/netinet6

2020-02-24 Thread Hans Petter Selasky
On 2020-02-24 18:19, Bjoern A. Zeeb wrote: are you sure that this is the problem?  Or does https://reviews.freebsd.org/D23760 solve the actual problem? Yes, I'm confident this is the problem. I made traces with tcpdump and looked at it using wireshark. Just setup two -current machines on a

Re: svn commit: r358167 - head/sys/netinet6

2020-02-24 Thread Bjoern A. Zeeb
On 24 Feb 2020, at 14:21, Hans Petter Selasky wrote: Hi Hans, On 2020-02-20 11:56, Bjoern A. Zeeb wrote: + + unfragpartlen = optlen + sizeof(struct ip6_hdr); + Hi Bjoren, This change introduces a slight regression when a host replies to IPv6 ping fragmented packets. The

Re: svn commit: r358167 - head/sys/netinet6

2020-02-24 Thread Hans Petter Selasky
On 2020-02-20 11:56, Bjoern A. Zeeb wrote: + + unfragpartlen = optlen + sizeof(struct ip6_hdr); + Hi Bjoren, This change introduces a slight regression when a host replies to IPv6 ping fragmented packets. The problem is the "unfragpartlen" must also be set in the else case of

svn commit: r358167 - head/sys/netinet6

2020-02-20 Thread Bjoern A. Zeeb
Author: bz Date: Thu Feb 20 10:56:12 2020 New Revision: 358167 URL: https://svnweb.freebsd.org/changeset/base/358167 Log: ip6_output: improve extension header handling Move IPv6 source address checks from after extension header heandling to the top of the function. If we do not pass