Re: svn commit: r359260 - in head: contrib/kyua etc/mtree lib lib/kyua lib/kyua/cli lib/kyua/drivers lib/kyua/engine lib/kyua/model lib/kyua/store lib/kyua/utils share/mk tools/build/mk usr.bin usr.bi
On 3/23/2020 6:54 PM, Conrad Meyer wrote: > On Mon, Mar 23, 2020 at 6:25 PM Bryan Drewery wrote: >> >> On 3/23/2020 12:01 PM, Brooks Davis wrote: >>> Author: brooks >>> Date: Mon Mar 23 19:01:23 2020 >>> New Revision: 359260 >>> URL: https://svnweb.freebsd.org/changeset/base/359260 >>> >>> Log: >>> Import the kyua test framework. >> >> Dumb question but are we allowed to modify this code without a google >> contributor agreement? I was under the impression that the license was >> restrictive in some regard like that. > > Not a dumb question. Yes, we're allowed to modify the code. The > license is just a boring BSD 3-clause: > https://svnweb.freebsd.org/base/head/contrib/kyua/LICENSE?view=markup > > The restrictions around Google contributor CLA only applied to > submissions to Github.com/jmmv/kyua. FreeBSD no longer considers jmmv > (and thus, Google) upstream for ATF and Kyua. Instead the projects > are forked into the github.com/freebsd/ organization. > Great. I wasn't far off then. Infeasible to modify it pre-fork but now it's not a problem. Thanks. -- Regards, Bryan Drewery signature.asc Description: OpenPGP digital signature
Re: svn commit: r359260 - in head: contrib/kyua etc/mtree lib lib/kyua lib/kyua/cli lib/kyua/drivers lib/kyua/engine lib/kyua/model lib/kyua/store lib/kyua/utils share/mk tools/build/mk usr.bin usr.bi
On Mon, Mar 23, 2020 at 6:25 PM Bryan Drewery wrote: > > On 3/23/2020 12:01 PM, Brooks Davis wrote: > > Author: brooks > > Date: Mon Mar 23 19:01:23 2020 > > New Revision: 359260 > > URL: https://svnweb.freebsd.org/changeset/base/359260 > > > > Log: > > Import the kyua test framework. > > Dumb question but are we allowed to modify this code without a google > contributor agreement? I was under the impression that the license was > restrictive in some regard like that. Not a dumb question. Yes, we're allowed to modify the code. The license is just a boring BSD 3-clause: https://svnweb.freebsd.org/base/head/contrib/kyua/LICENSE?view=markup The restrictions around Google contributor CLA only applied to submissions to Github.com/jmmv/kyua. FreeBSD no longer considers jmmv (and thus, Google) upstream for ATF and Kyua. Instead the projects are forked into the github.com/freebsd/ organization. Best, Conrad ___ svn-src-head@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
Re: svn commit: r359260 - in head: contrib/kyua etc/mtree lib lib/kyua lib/kyua/cli lib/kyua/drivers lib/kyua/engine lib/kyua/model lib/kyua/store lib/kyua/utils share/mk tools/build/mk usr.bin usr.bi
On 3/23/2020 12:01 PM, Brooks Davis wrote: > Author: brooks > Date: Mon Mar 23 19:01:23 2020 > New Revision: 359260 > URL: https://svnweb.freebsd.org/changeset/base/359260 > > Log: > Import the kyua test framework. > > Having kyua in the base system will simplify automated testing in CI and > eliminates bootstrapping issues on new platforms. > > The build of kyua is controlled by WITH(OUT)_TESTS_SUPPORT. > > Reviewed by:emaste > Obtained from: CheriBSD > Sponsored by: DARPA > Differential Revision: https://reviews.freebsd.org/D24103 Dumb question but are we allowed to modify this code without a google contributor agreement? I was under the impression that the license was restrictive in some regard like that. -- Regards, Bryan Drewery signature.asc Description: OpenPGP digital signature
Re: svn commit: r359260 - in head: contrib/kyua etc/mtree lib lib/kyua lib/kyua/cli lib/kyua/drivers lib/kyua/engine lib/kyua/model lib/kyua/store lib/kyua/utils share/mk tools/build/mk usr.bin usr.bi
On Mon, Mar 23, 2020 at 07:01:24PM +, Brooks Davis wrote: > New Revision: 359260 > URL: https://svnweb.freebsd.org/changeset/base/359260 > > Log: > Import the kyua test framework. > > Having kyua in the base system will simplify automated testing in CI > and eliminates bootstrapping issues on new platforms. > > The build of kyua is controlled by WITH(OUT)_TESTS_SUPPORT. What's WITH(OUT)_TESTS_SUPPORT relationship with MK_TESTS? I often put MK_TESTS=no in /etc/make.conf on space-limited machines, do I also have to add WITHOUT_TESTS_SUPPORT there now? Perhaps it makes sense to fold two knobs into one? ./danfe ___ svn-src-head@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
Re: svn commit: r359260 - in head: contrib/kyua etc/mtree lib lib/kyua lib/kyua/cli lib/kyua/drivers lib/kyua/engine lib/kyua/model lib/kyua/store lib/kyua/utils share/mk tools/build/mk usr.bin usr.bi
On Mon, Mar 23, 2020 at 08:15:22PM +, Alexey Dokuchaev wrote: > On Mon, Mar 23, 2020 at 07:01:24PM +, Brooks Davis wrote: > > New Revision: 359260 > > URL: https://svnweb.freebsd.org/changeset/base/359260 > > > > Log: > > Import the kyua test framework. > > > > Having kyua in the base system will simplify automated testing in CI > > and eliminates bootstrapping issues on new platforms. > > > > The build of kyua is controlled by WITH(OUT)_TESTS_SUPPORT. > > What's WITH(OUT)_TESTS_SUPPORT relationship with MK_TESTS? I often put > MK_TESTS=no in /etc/make.conf on space-limited machines, do I also have > to add WITHOUT_TESTS_SUPPORT there now? Perhaps it makes sense to fold > two knobs into one? WITHOUT_TESTS set MK_TESTS_SUPPORT=no unless WITH_TESTS_SUPPORT is specified (src.conf.5 documents this fairly clearly). This allows the test framework to be available without tests. -- Brooks signature.asc Description: PGP signature
Re: svn commit: r359260 - in head: contrib/kyua etc/mtree lib lib/kyua lib/kyua/cli lib/kyua/drivers lib/kyua/engine lib/kyua/model lib/kyua/store lib/kyua/utils share/mk tools/build/mk usr.bin usr.bi
On Mon, Mar 23, 2020 at 12:09:06PM -0700, Cy Schubert wrote: > In message <202003231901.02nj1olx063...@repo.freebsd.org>, Brooks Davis > writes: > > Author: brooks > > Date: Mon Mar 23 19:01:23 2020 > > New Revision: 359260 > > URL: https://svnweb.freebsd.org/changeset/base/359260 > > > > Log: > > Import the kyua test framework. > > > > Having kyua in the base system will simplify automated testing in CI and > > eliminates bootstrapping issues on new platforms. > > > > The build of kyua is controlled by WITH(OUT)_TESTS_SUPPORT. > > > > Reviewed by: emaste > > Obtained from:CheriBSD > > Sponsored by: DARPA > > Differential Revision:https://reviews.freebsd.org/D24103 > > Can we remove the kyua port? Unless of course has options that base will > not provide, which I cannot see it would. We'll be retaining the kyua port at least until all supported releases contain kyua which could be quite some time if we don't MFC for 11.4. We'll probably also want to keep it as a -devel port to allow people to get the latest features on release branches. -- Brooks P.S. At the moment, the import lacks unit tests. Hooking those up is on my todo list, but currently the port covers those... signature.asc Description: PGP signature
