Author: freqlabs
Date: Mon Oct 19 10:38:40 2020
New Revision: 366830
URL: https://svnweb.freebsd.org/changeset/base/366830

Log:
  efibootmgr: Use returned error code for error message, not errno
  
  efivar_unix_path_to_device_path returns the error code, it does not set errno.
  
  Reviewed by:  imp
  MFC after:    1 week
  Differential Revision:        https://reviews.freebsd.org/D26852

Modified:
  head/usr.sbin/efibootmgr/efibootmgr.c

Modified: head/usr.sbin/efibootmgr/efibootmgr.c
==============================================================================
--- head/usr.sbin/efibootmgr/efibootmgr.c       Mon Oct 19 09:52:52 2020        
(r366829)
+++ head/usr.sbin/efibootmgr/efibootmgr.c       Mon Oct 19 10:38:40 2020        
(r366830)
@@ -674,11 +674,16 @@ make_boot_var(const char *label, const char *loader, c
                err(1, "bootvar creation");
        if (loader == NULL)
                errx(1, "Must specify boot loader");
-       if (efivar_unix_path_to_device_path(loader, &loaderdp) != 0)
-               err(1, "Cannot translate unix loader path '%s' to UEFI", 
loader);
+       ret = efivar_unix_path_to_device_path(loader, &loaderdp);
+       if (ret != 0)
+               errc(1, ret, "Cannot translate unix loader path '%s' to UEFI",
+                   loader);
        if (kernel != NULL) {
-               if (efivar_unix_path_to_device_path(kernel, &kerneldp) != 0)
-                       err(1, "Cannot translate unix kernel path '%s' to 
UEFI", kernel);
+               ret = efivar_unix_path_to_device_path(kernel, &kerneldp);
+               if (ret != 0)
+                       errc(1, ret,
+                           "Cannot translate unix kernel path '%s' to UEFI",
+                           kernel);
        } else {
                kerneldp = NULL;
        }
_______________________________________________
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Reply via email to