Re: svn commit: r367321 - head/sys/amd64/linux
On Wed, 4 Nov 2020 at 07:10, Kristof Provost wrote: > > > And why you just abandoned the differential [1]? > > > Probably because it timed out. The review had been pending since August. > Arguably the differential link should have been included as well, but > it’s hardly important in this case. I don’t think we have explicit > policies about this. We probably should. Yes, it's still worth including the phab URL so that it closes automatically and so that others can see how long it was open for. I take no issue with the change itself. ___ svn-src-head@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
Re: svn commit: r367321 - head/sys/amd64/linux
Hi! On 11/4/20 1:09 PM, Kristof Provost wrote: On 4 Nov 2020, at 11:45, Gordon Bergling wrote: Shouldn't such a commit be approved by someone? The committer’s guide seems clear that doc committers may fix comments: https://www.freebsd.org/doc/en_US.ISO8859-1/articles/committers-guide/committer.types.html doc committers may commit documentation changes to src files, such as man pages, READMEs, fortune databases, calendar files, and comment fixes without approval from a src committer, subject to the normal care and tending of commits. Arguably minor spelling fixes are not worth confusing the blame output for, but this seems well within the established rules. +1 BTW, I've another similar patch pending (this time for pmcstat) if some src committer could take a look: https://reviews.freebsd.org/D26082. And why you just abandoned the differential [1]? Probably because it timed out. The review had been pending since August. Arguably the differential link should have been included as well, but it’s hardly important in this case. I don’t think we have explicit policies about this. We probably should. I forgot to link to the review on Phabricator. I didn't follow up with an email as it didn't seem important enough to show up in everyone's mailbox. Cheers! Mateusz ___ svn-src-head@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
Re: svn commit: r367321 - head/sys/amd64/linux
On 4 Nov 2020, at 11:45, Gordon Bergling wrote: Shouldn't such a commit be approved by someone? The committer’s guide seems clear that doc committers may fix comments: https://www.freebsd.org/doc/en_US.ISO8859-1/articles/committers-guide/committer.types.html doc committers may commit documentation changes to src files, such as man pages, READMEs, fortune databases, calendar files, and comment fixes without approval from a src committer, subject to the normal care and tending of commits. Arguably minor spelling fixes are not worth confusing the blame output for, but this seems well within the established rules. And why you just abandoned the differential [1]? Probably because it timed out. The review had been pending since August. Arguably the differential link should have been included as well, but it’s hardly important in this case. I don’t think we have explicit policies about this. We probably should. Best regards, Kristof ___ svn-src-head@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
Re: svn commit: r367321 - head/sys/amd64/linux
Shouldn't such a commit be approved by someone? And why you just abandoned the differential [1]? [1] https://reviews.freebsd.org/D25934 --Gordon On Wed, Nov 04, 2020 at 10:38:25AM +, Mateusz Piotrowski wrote: > Author: 0mp (doc,ports committer) > Date: Wed Nov 4 10:38:25 2020 > New Revision: 367321 > URL: https://svnweb.freebsd.org/changeset/base/367321 > > Log: > Fix a typo > > Modified: > head/sys/amd64/linux/linux_machdep.c > > Modified: head/sys/amd64/linux/linux_machdep.c > == > --- head/sys/amd64/linux/linux_machdep.c Wed Nov 4 10:21:30 2020 > (r367320) > +++ head/sys/amd64/linux/linux_machdep.c Wed Nov 4 10:38:25 2020 > (r367321) > @@ -126,7 +126,7 @@ linux_set_upcall_kse(struct thread *td, register_t sta > > /* >* The newly created Linux thread returns > - * to the user space by the same path that a parent do. > + * to the user space by the same path that a parent does. >*/ > td->td_frame->tf_rax = 0; > return (0); > ___ > svn-src-head@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/svn-src-head > To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org" -- ___ svn-src-head@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
svn commit: r367321 - head/sys/amd64/linux
Author: 0mp (doc,ports committer) Date: Wed Nov 4 10:38:25 2020 New Revision: 367321 URL: https://svnweb.freebsd.org/changeset/base/367321 Log: Fix a typo Modified: head/sys/amd64/linux/linux_machdep.c Modified: head/sys/amd64/linux/linux_machdep.c == --- head/sys/amd64/linux/linux_machdep.cWed Nov 4 10:21:30 2020 (r367320) +++ head/sys/amd64/linux/linux_machdep.cWed Nov 4 10:38:25 2020 (r367321) @@ -126,7 +126,7 @@ linux_set_upcall_kse(struct thread *td, register_t sta /* * The newly created Linux thread returns -* to the user space by the same path that a parent do. +* to the user space by the same path that a parent does. */ td->td_frame->tf_rax = 0; return (0); ___ svn-src-head@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
