Re: svn commit: r330338 - head/sys/amd64/amd64

2018-03-12 Thread Andriy Gapon
On 09/03/2018 21:22, John Baldwin wrote: > On Saturday, March 03, 2018 03:10:37 PM Andriy Gapon wrote: >> Author: avg >> Date: Sat Mar 3 15:10:37 2018 >> New Revision: 330338 >> URL: https://svnweb.freebsd.org/changeset/base/330338 >> >> Log: >> db_nextframe/amd64: catch up with r328083 to recog

svn commit: r330792 - in head: sbin/ipfw sys/netpfil/ipfw

2018-03-12 Thread Andrey V. Elsukov
Author: ae Date: Mon Mar 12 09:40:46 2018 New Revision: 330792 URL: https://svnweb.freebsd.org/changeset/base/330792 Log: Do not try to reassemble IPv6 fragments in "reass" rule. ip_reass() expects IPv4 packet and will just corrupt any IPv6 packets that it gets. Until proper IPv6 fragment

svn commit: r330793 - head/sys/x86/x86

2018-03-12 Thread Andriy Gapon
Author: avg Date: Mon Mar 12 11:28:09 2018 New Revision: 330793 URL: https://svnweb.freebsd.org/changeset/base/330793 Log: fix r297857, do not modify CPU extension bits under virtual machines r297857 was meant for real hardware only. PR: 213155 Submitted by: mainl...@apeiro

Re: svn commit: r330783 - in head/sys: amd64/include isa x86/isa

2018-03-12 Thread Hans Petter Selasky
On 03/11/18 21:13, Ian Lepore wrote: -struct mtx atrtc_lock; +static struct mtx atrtc_lock; MTX_SYSINIT(atrtc_lock_init, &atrtc_lock, "atrtc", MTX_SPIN); +struct mtx atrtc_time_lock; +MTX_SYSINIT(atrtc_time_lock_init, &atrtc_time_lock, "atrtc", MTX_DEF); One of my boxes panics now because

svn commit: r330795 - head/lib/libsysdecode

2018-03-12 Thread Bjoern A. Zeeb
Author: bz Date: Mon Mar 12 13:32:51 2018 New Revision: 330795 URL: https://svnweb.freebsd.org/changeset/base/330795 Log: The vmresult table was missing most of the values apart from two due to extra "_" in the names we grep for. Add the "_" to the pattern. Reviewed by: jhb MFC after:

svn commit: r330796 - head/sys/cam/scsi

2018-03-12 Thread Warner Losh
Author: imp Date: Mon Mar 12 15:17:16 2018 New Revision: 330796 URL: https://svnweb.freebsd.org/changeset/base/330796 Log: Tighten up periph lock to avoid some races Make sure the periph lock is held around rmw access to softc data, espeically flags, including work flags in iosched. Add

svn commit: r330797 - head/sys/x86/isa

2018-03-12 Thread Ian Lepore
Author: ian Date: Mon Mar 12 15:26:11 2018 New Revision: 330797 URL: https://svnweb.freebsd.org/changeset/base/330797 Log: Give the atrtc_time_lock a unique name. Reported by: hps@ Modified: head/sys/x86/isa/atrtc.c Modified: head/sys/x86/isa/atrtc.c ===

svn commit: r330798 - in head/sys: compat/linux i386/linux

2018-03-12 Thread Ed Maste
Author: emaste Date: Mon Mar 12 15:35:24 2018 New Revision: 330798 URL: https://svnweb.freebsd.org/changeset/base/330798 Log: Linuxulator: apply style(9) to return Sponsored by: Turing Robotic Industries Inc. Modified: head/sys/compat/linux/linux_ioctl.c head/sys/compat/linux/linux_sig

Re: svn commit: r330780 - in head/sys: amd64/include isa x86/isa

2018-03-12 Thread Ian Lepore
On Sun, 2018-03-11 at 23:25 +0200, Konstantin Belousov wrote: > On Sun, Mar 11, 2018 at 02:20:39PM -0600, Ian Lepore wrote: > > > > On Sun, 2018-03-11 at 21:58 +0200, Konstantin Belousov wrote: > > > > > > On Sun, Mar 11, 2018 at 07:22:58PM +, Ian Lepore wrote: > > > > > > > > > > > > [...]

svn commit: r330799 - head/sys/kern

2018-03-12 Thread Ed Maste
Author: emaste Date: Mon Mar 12 15:45:50 2018 New Revision: 330799 URL: https://svnweb.freebsd.org/changeset/base/330799 Log: ANSIfy sys/kern/imgact_* Modified: head/sys/kern/imgact_elf.c head/sys/kern/imgact_gzip.c Modified: head/sys/kern/imgact_elf.c =

Re: svn commit: r330780 - in head/sys: amd64/include isa x86/isa

2018-03-12 Thread Konstantin Belousov
On Mon, Mar 12, 2018 at 09:34:51AM -0600, Ian Lepore wrote: > On Sun, 2018-03-11 at 23:25 +0200, Konstantin Belousov wrote: > > On Sun, Mar 11, 2018 at 02:20:39PM -0600, Ian Lepore wrote: > > > > > > On Sun, 2018-03-11 at 21:58 +0200, Konstantin Belousov wrote: > > > > > > > > On Sun, Mar 11, 201

svn commit: r330802 - in head: sbin/nvmecontrol sys/dev/nvme

2018-03-12 Thread Alexander Motin
Author: mav Date: Mon Mar 12 16:31:25 2018 New Revision: 330802 URL: https://svnweb.freebsd.org/changeset/base/330802 Log: Print fuses and fna fields in identify data. MFC after:2 weeks Sponsored by: iXsystems, Inc. Modified: head/sbin/nvmecontrol/identify.c head/sys/dev/nvme/nvm

Re: svn commit: r328554 - head/sys/cam/scsi

2018-03-12 Thread Warner Losh
I think this is a good idea to MFC. We've had no reports of it causing issues. There's more extensive locking changes / tweaks needed for da that just went in that likely should also be MFC'd. Warner On Sun, Mar 11, 2018 at 9:17 PM, Dexuan-BSD Cui wrote: > Hi imp and all, > I think this patch

Re: svn commit: r330792 - in head: sbin/ipfw sys/netpfil/ipfw

2018-03-12 Thread Rodney W. Grimes
> Author: ae > Date: Mon Mar 12 09:40:46 2018 > New Revision: 330792 > URL: https://svnweb.freebsd.org/changeset/base/330792 > > Log: > Do not try to reassemble IPv6 fragments in "reass" rule. > > ip_reass() expects IPv4 packet and will just corrupt any IPv6 packets > that it gets. Until

svn commit: r330803 - head/sys/dev/e1000

2018-03-12 Thread Toomas Soome
Author: tsoome Date: Mon Mar 12 17:05:53 2018 New Revision: 330803 URL: https://svnweb.freebsd.org/changeset/base/330803 Log: e1000g: this statement may fall through The gcc 7 does check for switch statement fall through cases, and if legit, such complaint can besilenced by /* FALLTHROUGH

Re: svn commit: r330711 - head/sbin/sysctl

2018-03-12 Thread John Baldwin
On Saturday, March 10, 2018 10:46:53 AM Eugene Grosbein wrote: > 10.03.2018 6:37, John Baldwin wrote: > > > Author: jhb > > Date: Fri Mar 9 23:37:19 2018 > > New Revision: 330711 > > URL: https://svnweb.freebsd.org/changeset/base/330711 > > > > Log: > > Permit sysctl(8) to set an array of nume

Re: svn commit: r330780 - in head/sys: amd64/include isa x86/isa

2018-03-12 Thread Bruce Evans
On Mon, 12 Mar 2018, Konstantin Belousov wrote: On Mon, Mar 12, 2018 at 09:34:51AM -0600, Ian Lepore wrote: On Sun, 2018-03-11 at 23:25 +0200, Konstantin Belousov wrote: On Sun, Mar 11, 2018 at 02:20:39PM -0600, Ian Lepore wrote: On Sun, 2018-03-11 at 21:58 +0200, Konstantin Belousov wrote:

Re: svn commit: r330780 - in head/sys: amd64/include isa x86/isa

2018-03-12 Thread Ian Lepore
On Mon, 2018-03-12 at 17:56 +0200, Konstantin Belousov wrote: > On Mon, Mar 12, 2018 at 09:34:51AM -0600, Ian Lepore wrote: > > > > On Sun, 2018-03-11 at 23:25 +0200, Konstantin Belousov wrote: > > > > > > On Sun, Mar 11, 2018 at 02:20:39PM -0600, Ian Lepore wrote: > > > > > > > > > > > > On Su

Re: svn commit: r330780 - in head/sys: amd64/include isa x86/isa

2018-03-12 Thread Ian Lepore
On Mon, 2018-03-12 at 13:03 -0600, Ian Lepore wrote: > On Mon, 2018-03-12 at 17:56 +0200, Konstantin Belousov wrote: > > > > On Mon, Mar 12, 2018 at 09:34:51AM -0600, Ian Lepore wrote: > > > > > > [...] > > > > > > Does anybody really need an eventtimer that runs only at a fixed > > > periodic r

svn commit: r330806 - in head/stand: common i386/libi386 libsa ofw/libofw uboot/lib zfs

2018-03-12 Thread Warner Losh
Author: imp Date: Mon Mar 12 21:39:27 2018 New Revision: 330806 URL: https://svnweb.freebsd.org/changeset/base/330806 Log: Minor cosmetic changes. Make sure { on the same line as struct for all struct *devdesc. Move some type definitions to next to the dv_type define, since that's what

svn commit: r330807 - in head/stand/efi: libefi loader

2018-03-12 Thread Warner Losh
Author: imp Date: Mon Mar 12 21:39:38 2018 New Revision: 330807 URL: https://svnweb.freebsd.org/changeset/base/330807 Log: We can't use d_opendata for blkio storage. open_disk uses d_opendata for it's own purpse. We can't store blkio there. Fortunately, blkio is stored elsewhere and we ne

svn commit: r330808 - head/stand/i386/libi386

2018-03-12 Thread Warner Losh
Author: imp Date: Mon Mar 12 21:39:42 2018 New Revision: 330808 URL: https://svnweb.freebsd.org/changeset/base/330808 Log: Make struct libi386_devdesc match the struct devdesc better Move data to top and call it d_opendata. Modified: head/stand/i386/libi386/libi386.h Modified: head/stan

svn commit: r330810 - in head/stand: efi/libefi efi/loader i386/libi386 i386/loader libsa mips/beri/loader ofw/libofw sparc64/loader uboot/common uboot/lib userboot/userboot zfs

2018-03-12 Thread Warner Losh
Author: imp Date: Mon Mar 12 21:39:59 2018 New Revision: 330810 URL: https://svnweb.freebsd.org/changeset/base/330810 Log: Remove d_type from devdesc. It's not needed as we can fetch it from d_dev->dv_type when we need it. Modified: head/stand/efi/libefi/devicename.c head/stand/efi/loader

svn commit: r330812 - head/stand/efi/libefi

2018-03-12 Thread Warner Losh
Author: imp Date: Mon Mar 12 21:40:09 2018 New Revision: 330812 URL: https://svnweb.freebsd.org/changeset/base/330812 Log: Use the one-line-per-file pattern here, and sort the file names. Sponsored by: Netflix Modified: head/stand/efi/libefi/Makefile Modified: head/stand/efi/libefi/Make

Re: svn commit: r330780 - in head/sys: amd64/include isa x86/isa

2018-03-12 Thread Konstantin Belousov
On Mon, Mar 12, 2018 at 03:17:13PM -0600, Ian Lepore wrote: > So, the eventtimer code in the atrtc driver doesn't even work, and has > been broken (and unreported) since at least Nov 2015.  That sounds to > me like even more evidence that we should just remove eventtimer stuff > from the atrtc driv

svn commit: r330809 - in head/stand: common efi/libefi efi/loader i386/libi386 i386/loader mips/beri/loader ofw/libofw sparc64/loader uboot/common uboot/lib userboot/userboot zfs

2018-03-12 Thread Warner Losh
Author: imp Date: Mon Mar 12 21:39:49 2018 New Revision: 330809 URL: https://svnweb.freebsd.org/changeset/base/330809 Log: Use the actual struct devdesc at the start of all *_devdesc structs The current system is fragile and requires very careful layout of all *_devdesc structures. It als

svn commit: r330811 - head/stand/efi/libefi

2018-03-12 Thread Warner Losh
Author: imp Date: Mon Mar 12 21:40:05 2018 New Revision: 330811 URL: https://svnweb.freebsd.org/changeset/base/330811 Log: GC unused routines. Sponsored by: Netflix Modified: head/stand/efi/libefi/env.c Modified: head/stand/efi/libefi/env.c ==

svn commit: r330813 - in head/stand/efi: boot1 include libefi

2018-03-12 Thread Warner Losh
Author: imp Date: Mon Mar 12 21:40:14 2018 New Revision: 330813 URL: https://svnweb.freebsd.org/changeset/base/330813 Log: Move the env convenience routines out of boot1.c. These routines are more generally useful. Even though boot1 is on its way out, it's better to make these common duri

svn commit: r330814 - head/stand/efi/boot1

2018-03-12 Thread Warner Losh
Author: imp Date: Mon Mar 12 21:40:19 2018 New Revision: 330814 URL: https://svnweb.freebsd.org/changeset/base/330814 Log: Star BootCurrent entry when booting. Sponsored by: Netflix Modified: head/stand/efi/boot1/boot1.c Modified: head/stand/efi/boot1/boot1.c ===

svn commit: r330815 - head/stand/efi/loader

2018-03-12 Thread Warner Losh
Author: imp Date: Mon Mar 12 21:40:24 2018 New Revision: 330815 URL: https://svnweb.freebsd.org/changeset/base/330815 Log: Print the load and device path as well as BootCurrent and BootOrder Sponsored by: Netflix Modified: head/stand/efi/loader/main.c Modified: head/stand/efi/loader/mai

svn commit: r330817 - in head/sys: kern mips/include mips/mips

2018-03-12 Thread Brooks Davis
Author: brooks Date: Mon Mar 12 22:10:06 2018 New Revision: 330817 URL: https://svnweb.freebsd.org/changeset/base/330817 Log: MIPS: Implement fue*word* and casueword* in assembly. Remove NO_FUEWORD so the 'e' variants are wrapped by the non-'e' variants. This is more correct and leaves s

svn commit: r330819 - head/sys/cam/scsi

2018-03-12 Thread Brooks Davis
Author: brooks Date: Mon Mar 12 22:58:07 2018 New Revision: 330819 URL: https://svnweb.freebsd.org/changeset/base/330819 Log: Reject CAMIOGET and CAMIOQUEUE ioctl's on pass(4) in 32-bit compat mode. These take a union ccb argument which is full of kernel pointers. Substantial translation

svn commit: r330820 - head/sys/cam/scsi

2018-03-12 Thread Brooks Davis
Author: brooks Date: Mon Mar 12 23:02:01 2018 New Revision: 330820 URL: https://svnweb.freebsd.org/changeset/base/330820 Log: Reject ioctls to SCSI enclosures from 32-bit compat processes. The ioctl objects contain pointers and require translation and some refactoring of the infrastructur

svn commit: r330821 - head/sys/kern

2018-03-12 Thread Brooks Davis
Author: brooks Date: Mon Mar 12 23:04:42 2018 New Revision: 330821 URL: https://svnweb.freebsd.org/changeset/base/330821 Log: Use the stack for temporary storage in OTIOCCONS. The old code used the thread's pcb via the uap->data pointer. Reviewed by: ed Approved by: CheriBSD Spon

svn commit: r330822 - head/sys/i386/linux

2018-03-12 Thread Ed Maste
Author: emaste Date: Mon Mar 12 23:28:25 2018 New Revision: 330822 URL: https://svnweb.freebsd.org/changeset/base/330822 Log: imgact_linux.c: use standard indentation Sponsored by: Turing Robotic Industries Inc. Modified: head/sys/i386/linux/imgact_linux.c Modified: head/sys/i386/linux/

svn commit: r330823 - in head/sys: amd64/linux amd64/linux32 i386/linux

2018-03-12 Thread Ed Maste
Author: emaste Date: Tue Mar 13 00:40:05 2018 New Revision: 330823 URL: https://svnweb.freebsd.org/changeset/base/330823 Log: Apply some style(9) to Linuxulator linux_sysvec.c comments Modified: head/sys/amd64/linux/linux_sysvec.c head/sys/amd64/linux32/linux32_sysvec.c head/sys/i386/linu

svn commit: r330825 - head/stand/lua

2018-03-12 Thread Kyle Evans
Author: kevans Date: Tue Mar 13 02:59:13 2018 New Revision: 330825 URL: https://svnweb.freebsd.org/changeset/base/330825 Log: lualoader: Sprinkle some verbose_loading salt Our module loading messages should be hidden without verbose_loading -- go ahead and do that as a first step. Modifi

RE: svn commit: r328554 - head/sys/cam/scsi

2018-03-12 Thread Dexuan Cui via svn-src-head
Hi Warner, Sorry, I need to make a correction: acutally it looks the panic can NOT reproduce with stable/11 or the latest master branch. This is great! :-) Actually I was using an old version of the master branch that doesn’t have r328554 yet, and I could 100% reproduce the issue. If I manually

svn commit: r330826 - head/sbin/nvmecontrol

2018-03-12 Thread Alexander Motin
Author: mav Date: Tue Mar 13 03:02:09 2018 New Revision: 330826 URL: https://svnweb.freebsd.org/changeset/base/330826 Log: Add `nvmecontrol format` subcommand. It allows to change namespace parameters, such as block size, metadata, protection information, etc. and/or erase the data.