svn commit: r343116 - in head: include lib/libc/gen libexec/rtld-elf

2019-01-17 Thread Dag-Erling Smørgrav
Author: des Date: Thu Jan 17 16:50:50 2019 New Revision: 343116 URL: https://svnweb.freebsd.org/changeset/base/343116 Log: Revert r343093 until I can address the issues raised by kib@. Modified: head/include/dlfcn.h head/lib/libc/gen/dlopen.3 head/libexec/rtld-elf/rtld.c Modified:

svn commit: r343119 - head/sys/arm/allwinner

2019-01-17 Thread Kyle Evans
Author: kevans Date: Thu Jan 17 18:51:56 2019 New Revision: 343119 URL: https://svnweb.freebsd.org/changeset/base/343119 Log: Revert r343095 This was intended to fix the soft reset timeout on boot for OrangePi One/R1 with internal PHY, but seems to cause other problems later on due to

Re: svn commit: r343113 - head/contrib/libc++/include

2019-01-17 Thread Andriy Gapon
On 17/01/2019 17:35, Kirk McKusick wrote: > -#ifdef ELAST > +#if defined(ELAST) I think that these are exactly the same, so not sure what the change does. -- Andriy Gapon ___ svn-src-head@freebsd.org mailing list

svn commit: r343118 - in head/usr.sbin: . trim

2019-01-17 Thread Eugene Grosbein
Author: eugen Date: Thu Jan 17 18:07:59 2019 New Revision: 343118 URL: https://svnweb.freebsd.org/changeset/base/343118 Log: Re-add new small tool trim(8) to delete contents for blocks on devices using wear-leveling algorithms as a few weeks passed after review and discussion of trim(8)

Re: svn commit: r343113 - head/contrib/libc++/include

2019-01-17 Thread Kirk McKusick
> From:Andriy Gapon > Date:Thu, 17 Jan 2019 19:05:20 +0200 > To: Kirk McKusick , src-committ...@freebsd.org, >svn-src-...@freebsd.org, svn-src-head@freebsd.org > Subject: Re: svn commit: r343113 - head/contrib/libc++/include > > On 17/01/2019 17:35, Kirk McKusick wrote: >>

svn commit: r343115 - head/contrib/libc++/include

2019-01-17 Thread Kirk McKusick
Author: mckusick Date: Thu Jan 17 16:26:59 2019 New Revision: 343115 URL: https://svnweb.freebsd.org/changeset/base/343115 Log: Truely fix #if defined broken in -r343111 Pointy-hat-to: mckusick Modified: head/contrib/libc++/include/errno.h Modified: head/contrib/libc++/include/errno.h

svn commit: r343120 - in head/sys/x86: include x86

2019-01-17 Thread Conrad Meyer
Author: cem Date: Thu Jan 17 19:44:47 2019 New Revision: 343120 URL: https://svnweb.freebsd.org/changeset/base/343120 Log: Add definitions for AMD Spectre/Meltdown CPUID information No functional change, aside from printing recognized bits in CPU identification. The bits are

svn commit: r343121 - head/usr.sbin/nscd

2019-01-17 Thread Edward Tomasz Napierala
Author: trasz Date: Thu Jan 17 20:01:06 2019 New Revision: 343121 URL: https://svnweb.freebsd.org/changeset/base/343121 Log: Workaround for nscd(8) failure with large entries. It fixes a case where eg a 2KB group entry would take several seconds to complete with cache enabled in

Re: svn commit: r343122 - head/usr.sbin/freebsd-update

2019-01-17 Thread Xin LI
On Thu, Jan 17, 2019 at 1:39 PM Ed Maste wrote: > Author: emaste > Date: Thu Jan 17 21:38:57 2019 > New Revision: 343122 > URL: https://svnweb.freebsd.org/changeset/base/343122 > > Log: > freebsd-update: Clarify unsupported release upgrade error message > > Notify users that upgrading from

Re: svn commit: r343118 - in head/usr.sbin: . trim

2019-01-17 Thread Cy Schubert
In message <201901171808.x0hi80jc068...@repo.freebsd.org>, Eugene Grosbein writ es: > Author: eugen > Date: Thu Jan 17 18:07:59 2019 > New Revision: 343118 > URL: https://svnweb.freebsd.org/changeset/base/343118 > > Log: > Re-add new small tool trim(8) to delete contents for blocks > on

Re: svn commit: r343118 - in head/usr.sbin: . trim

2019-01-17 Thread Conrad Meyer
Please back it out; stop attributing code review to "hackers@," which can not (it's a list, not individuals) and did not review this changeset; and put it on phabricator for actual review. I think summary backout is warranted on the basis of your handling of this last time around and lack of

Re: svn commit: r343118 - in head/usr.sbin: . trim

2019-01-17 Thread Cy Schubert
In message , Conrad Meyer writes: > On Thu, Jan 17, 2019 at 12:22 PM Cy Schubert wrot > e: > > This is wrong. IIRC there was discussion that this should be in dd(1). > > Why not submit a revision to add the functionality to dd? > > Well, it's wrong, but not because we need another weird dd mode.

Re: svn commit: r343118 - in head/usr.sbin: . trim

2019-01-17 Thread Eugene Grosbein
18.01.2019 3:22, Cy Schubert wrote: > This is wrong. IIRC there was discussion that this should be in dd(1). > Why not submit a revision to add the functionality to dd? There is already https://reviews.freebsd.org/D18382 that had no code updates over 6 weeks and latest revision needs a fix as

Re: svn commit: r343118 - in head/usr.sbin: . trim

2019-01-17 Thread Eugene Grosbein
18.01.2019 3:23, Conrad Meyer пишет: > Please back it out; stop attributing code review to "hackers@," which > can not (it's a list, not individuals) and did not review this > changeset; and put it on phabricator for actual review. There is already https://reviews.freebsd.org/D18380 by imp and

Re: svn commit: r343118 - in head/usr.sbin: . trim

2019-01-17 Thread Conrad Meyer
On Thu, Jan 17, 2019 at 12:22 PM Cy Schubert wrote: > This is wrong. IIRC there was discussion that this should be in dd(1). > Why not submit a revision to add the functionality to dd? Well, it's wrong, but not because we need another weird dd mode. dd is hard enough to use already.

svn commit: r343122 - head/usr.sbin/freebsd-update

2019-01-17 Thread Ed Maste
Author: emaste Date: Thu Jan 17 21:38:57 2019 New Revision: 343122 URL: https://svnweb.freebsd.org/changeset/base/343122 Log: freebsd-update: Clarify unsupported release upgrade error message Notify users that upgrading from -CURRENT or -STABLE is unsupported by freebsd-update. Also

svn commit: r343123 - head/stand/libsa/zfs

2019-01-17 Thread Toomas Soome
Author: tsoome Date: Thu Jan 17 21:52:41 2019 New Revision: 343123 URL: https://svnweb.freebsd.org/changeset/base/343123 Log: loader should ignore active multi_vdev_crash_dump feature on zpool Since the loader zfs reader does not need to read the dump zvol, we can just enable the

Re: svn commit: r343118 - in head/usr.sbin: . trim

2019-01-17 Thread Conrad Meyer
On Thu, Jan 17, 2019 at 1:16 PM Eugene Grosbein wrote: > > 18.01.2019 3:23, Conrad Meyer пишет: > > > Please back it out; stop attributing code review to "hackers@," which > > can not (it's a list, not individuals) and did not review this > > changeset; and put it on phabricator for actual

Packaging base system (again) [Was: svn commit: r343118 - in head/usr.sbin: . trim]

2019-01-17 Thread Maxim Sobolev
On Thu, Jan 17, 2019 at 2:42 PM Enji Cooper wrote: > > Perhaps even by forking the whole ports idea into a smaller > closely-guarged subset. Something like a new baseports repository, which > might have structure like baseports/usr.bin/xxx, baseports/usr.sbin/yyy > etc. Then add some automagic

svn commit: r343117 - head/usr.bin/cmp

2019-01-17 Thread Mark Johnston
Author: markj Date: Thu Jan 17 17:36:18 2019 New Revision: 343117 URL: https://svnweb.freebsd.org/changeset/base/343117 Log: Fix handling of rights on stdio streams. - Limit rights on stdio before opening input files. Otherwise, open() may return one of the standard descriptors and we

Re: svn commit: r343122 - head/usr.sbin/freebsd-update

2019-01-17 Thread Ed Maste
On Thu, 17 Jan 2019 at 16:46, Xin LI wrote: > > On Thu, Jan 17, 2019 at 1:39 PM Ed Maste wrote: >> >> Author: emaste >> Date: Thu Jan 17 21:38:57 2019 >> New Revision: 343122 >> URL: https://svnweb.freebsd.org/changeset/base/343122 >> >> Log: >> freebsd-update: Clarify unsupported release

Re: svn commit: r343030 - in head/sys: cam conf dev/md dev/nvme fs/fuse fs/nfsclient fs/smbfs kern sys ufs/ffs vm

2019-01-17 Thread Conrad Meyer
On WITNESS builds after this change and all followup fixes I can see (@ r343108), I get a new warning: Sleeping on "pageprocwait" with the following non-sleepable locks held: exclusive sleep mutex pbuf (UMA zone) r = 0 (0xf80003033e00) locked @ .../sys/vm/uma_core.c:1139 stack backtrace: #0

Re: svn commit: r343118 - in head/usr.sbin: . trim

2019-01-17 Thread Enji Cooper
> On Jan 17, 2019, at 2:25 PM, Maxim Sobolev wrote: > > What I think we really need is some way to easily porti-ze useful stuff that > would otherwise go into /usr/[s]bin, so adding things would be just as easy > as hooking up SUBDIR into usr.[s]bin/Makefile. Yes, I know, this is topic >

Re: svn commit: r343118 - in head/usr.sbin: . trim

2019-01-17 Thread Rodney W. Grimes
> What I think we really need is some way to easily porti-ze useful stuff > that would otherwise go into /usr/[s]bin, so adding things would be just as > easy as hooking up SUBDIR into usr.[s]bin/Makefile. Yes, I know, this is > topic almost as old as the FreeBSD Project itself, but perhaps we

Re: svn commit: r343125 - head/sys/dev/ioat

2019-01-17 Thread Kevin Bowling
Out of curiosity are you using this driver? Any performance data? On Thu, Jan 17, 2019 at 4:21 PM Conrad Meyer wrote: > Author: cem > Date: Thu Jan 17 23:21:02 2019 > New Revision: 343125 > URL: https://svnweb.freebsd.org/changeset/base/343125 > > Log: > ioat(4): Set __result_use_check on

svn commit: r343112 - head/usr.sbin/jail

2019-01-17 Thread Eugene Grosbein
Author: eugen Date: Thu Jan 17 14:09:55 2019 New Revision: 343112 URL: https://svnweb.freebsd.org/changeset/base/343112 Log: jail(8): stop crashing with SIGSEGV inside run_command() function while processing not entirely correct jail.conf(5) file having something like "ip4.addr =

svn commit: r343113 - head/contrib/libc++/include

2019-01-17 Thread Kirk McKusick
Author: mckusick Date: Thu Jan 17 15:35:04 2019 New Revision: 343113 URL: https://svnweb.freebsd.org/changeset/base/343113 Log: Fix #if defined broken in -r343111 Pointy-hat-to: mckusick Modified: head/contrib/libc++/include/errno.h Modified: head/contrib/libc++/include/errno.h

svn commit: r343114 - head/contrib/libc++/include

2019-01-17 Thread Kirk McKusick
Author: mckusick Date: Thu Jan 17 15:42:10 2019 New Revision: 343114 URL: https://svnweb.freebsd.org/changeset/base/343114 Log: Proper definition of elast3. Reported by: Oliver Pinter Modified: head/contrib/libc++/include/errno.h Modified: head/contrib/libc++/include/errno.h

Re: svn commit: r343111 - in head: cddl/lib/libdtrace contrib/libc++/include contrib/libxo/tests/gettext contrib/libxo/tests/gettext/po/pig_latin contrib/openbsm/libbsm contrib/openbsm/sys/bsm lib/lib

2019-01-17 Thread Kirk McKusick
Thanks for your pointer to the problem. Now fixed in -r343113. Kirk McKusick ___ svn-src-head@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to

Re: svn commit: r343111 - in head: cddl/lib/libdtrace contrib/libc++/include contrib/libxo/tests/gettext contrib/libxo/tests/gettext/po/pig_latin contrib/openbsm/libbsm contrib/openbsm/sys/bsm lib/lib

2019-01-17 Thread Kirk McKusick
Thanks for your analysis. Now fixed in -r343113. Kirk McKusick ___ svn-src-head@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Re: svn commit: r343111 - in head: cddl/lib/libdtrace contrib/libc++/include contrib/libxo/tests/gettext contrib/libxo/tests/gettext/po/pig_latin contrib/openbsm/libbsm contrib/openbsm/sys/bsm lib/lib

2019-01-17 Thread Kirk McKusick
Per my previous email, it is fixed in -r343114 not -r343113. Kirk McKusick ___ svn-src-head@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

svn commit: r343124 - head/stand/libsa

2019-01-17 Thread Toomas Soome
Author: tsoome Date: Thu Jan 17 22:00:02 2019 New Revision: 343124 URL: https://svnweb.freebsd.org/changeset/base/343124 Log: libsa: add asprintf() asprintf() is a nice tool for string processing. MFC after:2 weeks Modified: head/stand/libsa/printf.c head/stand/libsa/stand.h

Re: svn commit: r343118 - in head/usr.sbin: . trim

2019-01-17 Thread Maxim Sobolev
What I think we really need is some way to easily porti-ze useful stuff that would otherwise go into /usr/[s]bin, so adding things would be just as easy as hooking up SUBDIR into usr.[s]bin/Makefile. Yes, I know, this is topic almost as old as the FreeBSD Project itself, but perhaps we just did

svn commit: r343125 - head/sys/dev/ioat

2019-01-17 Thread Conrad Meyer
Author: cem Date: Thu Jan 17 23:21:02 2019 New Revision: 343125 URL: https://svnweb.freebsd.org/changeset/base/343125 Log: ioat(4): Set __result_use_check on ioat_acquire_reserve Even M_WAITOK callers must check for failure. For example, if the device is quiescing, either due to

svn commit: r343129 - head/sys/cam/ata

2019-01-17 Thread Oleksandr Tymoshenko
Author: gonzo Date: Fri Jan 18 04:23:52 2019 New Revision: 343129 URL: https://svnweb.freebsd.org/changeset/base/343129 Log: [ata] Add workaround for KingDian S200 SSD crash on receiving TRIM command - Add ADA_Q_NO_TRIM quirk to be used with the device that falsely advertise TRIM support

svn commit: r343127 - head/usr.bin/compress

2019-01-17 Thread Oleksandr Tymoshenko
Author: gonzo Date: Fri Jan 18 00:26:25 2019 New Revision: 343127 URL: https://svnweb.freebsd.org/changeset/base/343127 Log: Fix descriptor/memory leak in compress(1) code This is mostly a style fix since the code in question is not called multiple times and doesn't have cummulative

Re: svn commit: r343118 - in head/usr.sbin: . trim

2019-01-17 Thread Warner Losh
On Thu, Jan 17, 2019 at 3:43 PM Conrad Meyer wrote: > On Thu, Jan 17, 2019 at 1:16 PM Eugene Grosbein wrote: > > > > 18.01.2019 3:23, Conrad Meyer пишет: > > > > > Please back it out; stop attributing code review to "hackers@," which > > > can not (it's a list, not individuals) and did not

Re: svn commit: r343125 - head/sys/dev/ioat

2019-01-17 Thread Conrad Meyer
On Thu, Jan 17, 2019 at 4:12 PM Kevin Bowling wrote: > > Out of curiosity are you using this driver? Any performance data? Yep. I don't have any hard numbers on hand but my recollection is it caps out at about 5 GB/s, total, on Broadwell. Our workload with it is predominantly unmapped 8kB

Re: svn commit: r343118 - in head/usr.sbin: . trim

2019-01-17 Thread Rodney W. Grimes
> On Thu, Jan 17, 2019 at 3:43 PM Conrad Meyer wrote: > > > On Thu, Jan 17, 2019 at 1:16 PM Eugene Grosbein wrote: > > > > > > 18.01.2019 3:23, Conrad Meyer ?: > > > > > > > Please back it out; stop attributing code review to "hackers@," which > > > > can not (it's a list, not individuals)

Re: svn commit: r343118 - in head/usr.sbin: . trim

2019-01-17 Thread Cy Schubert
In message , Enji Cooper writes : > > > --Apple-Mail=_6CB1620B-6707-4F06-B7FF-9F1ECBA36F56 > Content-Transfer-Encoding: quoted-printable > Content-Type: text/plain; > charset=utf-8 > > > > On Jan 17, 2019, at 2:25 PM, Maxim Sobolev = > wrote: > >=20 > > What I think we really need is some

Re: svn commit: r343118 - in head/usr.sbin: . trim

2019-01-17 Thread Warner Losh
On Thu, Jan 17, 2019 at 5:48 PM Rodney W. Grimes < free...@pdx.rh.cn85.dnsmgr.net> wrote: > > On Thu, Jan 17, 2019 at 3:43 PM Conrad Meyer wrote: > > > > > On Thu, Jan 17, 2019 at 1:16 PM Eugene Grosbein > wrote: > > > > > > > > 18.01.2019 3:23, Conrad Meyer ?: > > > > > > > > > Please back

Re: svn commit: r343118 - in head/usr.sbin: . trim

2019-01-17 Thread Cy Schubert
In message <201901180008.x0i08thg052...@pdx.rh.cn85.dnsmgr.net>, "Rodney W. Gri mes" writes: > > What I think we really need is some way to easily porti-ze useful stuff > > that would otherwise go into /usr/[s]bin, so adding things would be just as > > easy as hooking up SUBDIR into

Re: svn commit: r343118 - in head/usr.sbin: . trim

2019-01-17 Thread Cy Schubert
In message , Maxim Sobolev writes: > > What I think we really need is some way to easily porti-ze useful stuff > that would otherwise go into /usr/[s]bin, so adding things would be just as > easy as hooking up SUBDIR into usr.[s]bin/Makefile. Yes, I know, this is > topic almost as old as the

svn commit: r343128 - head/tools/build/mk

2019-01-17 Thread Oleksandr Tymoshenko
Author: gonzo Date: Fri Jan 18 00:39:17 2019 New Revision: 343128 URL: https://svnweb.freebsd.org/changeset/base/343128 Log: Add ypldap to the list of conditional obsolete files ypldap should be removed during delete-old if WITHOUT_NIS flag is enabled PR: 230727 Submitted

Re: svn commit: r343118 - in head/usr.sbin: . trim

2019-01-17 Thread Warner Losh
On Thu, Jan 17, 2019 at 2:16 PM Eugene Grosbein wrote: > 18.01.2019 3:23, Conrad Meyer пишет: > > > Please back it out; stop attributing code review to "hackers@," which > > can not (it's a list, not individuals) and did not review this > > changeset; and put it on phabricator for actual review.