svn commit: r229984 - head/sys/dev/pst

2012-01-11 Thread Don Lewis
Author: truckman Date: Wed Jan 11 21:38:05 2012 New Revision: 229984 URL: http://svn.freebsd.org/changeset/base/229984 Log: Pass the arguments to mtx_init() in the correct order. There should be no change to the binary because the value of MTX_DEF is zero and there is a visible function

svn commit: r230064 - head/sys/geom/part

2012-01-13 Thread Don Lewis
Author: truckman Date: Fri Jan 13 18:32:56 2012 New Revision: 230064 URL: http://svn.freebsd.org/changeset/base/230064 Log: Allow an MBR primary or extended Linux swap partition to be specified as the system dump device. This was already allowed for GPT. The Linux swap metadata at the

svn commit: r231102 - head/sbin/fsdb

2012-02-06 Thread Don Lewis
Author: truckman Date: Mon Feb 6 21:50:11 2012 New Revision: 231102 URL: http://svn.freebsd.org/changeset/base/231102 Log: Improve sparse file handling when printing the block list for an inode by not bailing out early when a hole is encountered in the direct block list. Print NULL block

Re: svn commit: r251512 - in head: . etc etc/mtree gnu/usr.bin/gdb gnu/usr.bin/gdb/arch/amd64 gnu/usr.bin/gdb/arch/arm gnu/usr.bin/gdb/arch/i386 gnu/usr.bin/gdb/arch/ia64 gnu/usr.bin/gdb/arch/mips gnu

2013-06-07 Thread Don Lewis
On 7 Jun, Ed Maste wrote: Author: emaste Date: Fri Jun 7 21:40:02 2013 New Revision: 251512 URL: http://svnweb.freebsd.org/changeset/base/251512 Log: Add a new knob WITH_DEBUG_FILES to control the building of standalone debug files for userland programs and libraries. The -g debug

Re: svn commit: r251512 - in head: . etc etc/mtree gnu/usr.bin/gdb gnu/usr.bin/gdb/arch/amd64 gnu/usr.bin/gdb/arch/arm gnu/usr.bin/gdb/arch/i386 gnu/usr.bin/gdb/arch/ia64 gnu/usr.bin/gdb/arch/mips gnu

2013-06-07 Thread Don Lewis
On 7 Jun, Glen Barber wrote: On Fri, Jun 07, 2013 at 04:35:23PM -0700, Don Lewis wrote: On 7 Jun, Ed Maste wrote: Author: emaste Date: Fri Jun 7 21:40:02 2013 New Revision: 251512 URL: http://svnweb.freebsd.org/changeset/base/251512 Log: Add a new knob WITH_DEBUG_FILES

Re: svn commit: r251886 - in head: contrib/apr contrib/apr-util contrib/serf contrib/sqlite3 contrib/subversion share/mk usr.bin usr.bin/svn usr.bin/svn/lib usr.bin/svn/lib/libapr usr.bin/svn/lib/liba

2013-06-19 Thread Don Lewis
On 18 Jun, Peter Wemm wrote: Added: head/usr.bin/svn/Makefile.inc == --- /dev/null 00:00:00 1970 (empty, because file is newly added) +++ head/usr.bin/svn/Makefile.inc Tue Jun 18 02:53:45 2013 (r251886)

svn commit: r252003 - head/usr.bin/svn

2013-06-19 Thread Don Lewis
Author: truckman Date: Wed Jun 19 19:44:57 2013 New Revision: 252003 URL: http://svnweb.freebsd.org/changeset/base/252003 Log: Fix a couple of typos that broke buildworld for me. Reviewed by: peter Modified: head/usr.bin/svn/Makefile.inc Modified: head/usr.bin/svn/Makefile.inc

Re: svn commit: r263379 - in head/sys: amd64/amd64 i386/i386 i386/xen isa pc98/cbus x86/isa x86/x86

2014-03-19 Thread Don Lewis
On 19 Mar, Warner Losh wrote: Author: imp Date: Wed Mar 19 21:03:04 2014 New Revision: 263379 URL: http://svnweb.freebsd.org/changeset/base/263379 Log: Remove vestiges of knowing the ISA bus, which we gave up on around 20 years ago. Remove redunant copy of isaregs.h. It hasn't been

Re: svn commit: r263755 - head/sys/kern

2014-03-27 Thread Don Lewis
On 27 Mar, Konstantin Belousov wrote: On Thu, Mar 27, 2014 at 04:05:12PM +0100, Mateusz Guzik wrote: On Thu, Mar 27, 2014 at 03:58:19PM +0100, Mateusz Guzik wrote: On Thu, Mar 27, 2014 at 04:46:57PM +0800, David Xu wrote: On 2014/03/27 16:37, Mateusz Guzik wrote: On Thu, Mar 27, 2014 at

Re: svn commit: r263755 - head/sys/kern

2014-03-28 Thread Don Lewis
On 28 Mar, David Xu wrote: On 2014/03/28 06:31, Don Lewis wrote: On 27 Mar, Konstantin Belousov wrote: On Thu, Mar 27, 2014 at 04:05:12PM +0100, Mateusz Guzik wrote: On Thu, Mar 27, 2014 at 03:58:19PM +0100, Mateusz Guzik wrote: On Thu, Mar 27, 2014 at 04:46:57PM +0800, David Xu wrote

Re: svn commit: r263755 - head/sys/kern

2014-03-29 Thread Don Lewis
On 29 Mar, Mateusz Guzik wrote: On Sat, Mar 29, 2014 at 11:52:09AM +0800, David Xu wrote: If fsetown handling like this is insecure this would bite us in that scenario (and few others). In short, if we can avoid giving another way to corrupt stuff in the kernel to userspace, we should. I

Re: svn commit: r264907 - in head/release: amd64 i386

2014-04-24 Thread Don Lewis
On 24 Apr, Glen Barber wrote: On Thu, Apr 24, 2014 at 07:12:10PM -0700, Nathan Whitehorn wrote: On 04/24/14 18:38, Glen Barber wrote: Author: gjb Date: Fri Apr 25 01:38:57 2014 New Revision: 264907 URL: http://svnweb.freebsd.org/changeset/base/264907 Log: Refactor make-memstick.sh to

svn commit: r265363 - head/sys/kern

2014-05-05 Thread Don Lewis
Author: truckman Date: Mon May 5 15:59:31 2014 New Revision: 265363 URL: http://svnweb.freebsd.org/changeset/base/265363 Log: Avoid unsigned integer overflow which can cause rman_reserve_resource_bound() to return incorrect results. Continue the initial search until the first viable

svn commit: r265923 - head/sys/kern

2014-05-12 Thread Don Lewis
Author: truckman Date: Mon May 12 17:56:52 2014 New Revision: 265923 URL: http://svnweb.freebsd.org/changeset/base/265923 Log: Nuke a couple of unnecessary assigments. Nothing uses the values of rstart and rend after this point. MFC after:1 week Modified:

svn commit: r265931 - head/sys/kern

2014-05-12 Thread Don Lewis
Author: truckman Date: Mon May 12 20:22:42 2014 New Revision: 265931 URL: http://svnweb.freebsd.org/changeset/base/265931 Log: Be even more paranoid about overflow. Requested by: ache Modified: head/sys/kern/subr_rman.c Modified: head/sys/kern/subr_rman.c

Re: svn commit: r265931 - head/sys/kern

2014-05-12 Thread Don Lewis
On 12 May, To: src-committ...@freebsd.org wrote: Author: truckman Date: Mon May 12 20:22:42 2014 New Revision: 265931 URL: http://svnweb.freebsd.org/changeset/base/265931 Log: Be even more paranoid about overflow. Requested by: ache Modified: head/sys/kern/subr_rman.c

Re: svn commit: r265408 - in head: sys/netinet usr.bin/netstat

2014-05-14 Thread Don Lewis
On 6 May, Gleb Smirnoff wrote: Author: glebius Date: Tue May 6 00:00:07 2014 New Revision: 265408 URL: http://svnweb.freebsd.org/changeset/base/265408 Log: - Remove net.inet.tcp.reass.overflows sysctl. It counts exactly same events that tcpstat's tcps_rcvmemdrop counter counts.

svn commit: r266426 - head/sys/kern

2014-05-18 Thread Don Lewis
Author: truckman Date: Mon May 19 04:44:27 2014 New Revision: 266426 URL: http://svnweb.freebsd.org/changeset/base/266426 Log: Slightly restructure the final loop in rman_reserve_resource_bound(). Replace with the existing loop termination test with a similar condition from the nested if

Re: svn commit: r266534 - head

2014-05-21 Thread Don Lewis
On 22 May, Xin LI wrote: Author: delphij Date: Thu May 22 05:33:50 2014 New Revision: 266534 URL: http://svnweb.freebsd.org/changeset/base/266534 Log: Fix build: Build libavl as prebuild-lib. Thanks! ___ svn-src-head@freebsd.org mailing list

svn commit: r266547 - head

2014-05-22 Thread Don Lewis
Author: truckman Date: Thu May 22 16:30:32 2014 New Revision: 266547 URL: http://svnweb.freebsd.org/changeset/base/266547 Log: Don't delete our new vt(4) man page. X-MFC-With: r265798 Modified: head/ObsoleteFiles.inc Modified: head/ObsoleteFiles.inc

Re: svn commit: r266587 - head/share/mk

2014-05-23 Thread Don Lewis
On 23 May, Warner Losh wrote: Author: imp Date: Fri May 23 14:34:22 2014 New Revision: 266587 URL: http://svnweb.freebsd.org/changeset/base/266587 Log: Allow CC to not actually exist. During the ports INDEX run, all the Makefiles are evaluated without building things. In a normal

svn commit: r266814 - head/sys/kern

2014-05-28 Thread Don Lewis
Author: truckman Date: Wed May 28 16:57:17 2014 New Revision: 266814 URL: http://svnweb.freebsd.org/changeset/base/266814 Log: Initialize r_flags the same way in all cases using a sanitized copy of flags that has several bits cleared. The RF_WANTED and RF_FIRSTSHARE bits are invalid in this

svn commit: r268373 - head/sys/kern

2014-07-07 Thread Don Lewis
Author: truckman Date: Mon Jul 7 22:02:39 2014 New Revision: 268373 URL: http://svnweb.freebsd.org/changeset/base/268373 Log: Declaration whitespace changes for style(9). MFC after:1 week Modified: head/sys/kern/subr_rman.c Modified: head/sys/kern/subr_rman.c

svn commit: r268780 - in head: share/man/man9 sys/kern sys/sys

2014-07-16 Thread Don Lewis
Author: truckman Date: Wed Jul 16 22:18:19 2014 New Revision: 268780 URL: http://svnweb.freebsd.org/changeset/base/268780 Log: Nuke the never-used RF_TIMESHARE feature, reducing the complexity of the code. The consensus on arch@ is that this feature might have been useful in the distant

Re: svn commit: r269656 - in head: bin/ps sys/kern sys/sys

2014-08-07 Thread Don Lewis
On 7 Aug, Konstantin Belousov wrote: Author: kib Date: Thu Aug 7 05:47:53 2014 New Revision: 269656 URL: http://svnweb.freebsd.org/changeset/base/269656 Log: Correct the problems with the ptrace(2) making the debuggee an orphan. One problem is inferior(9) looping due to the process

svn commit: r270510 - head

2014-08-24 Thread Don Lewis
Author: truckman Date: Sun Aug 24 21:21:54 2014 New Revision: 270510 URL: http://svnweb.freebsd.org/changeset/base/270510 Log: Catch up to gcc 3.3 - 3.4 upgrade. MFC after:3 days Modified: head/ObsoleteFiles.inc Modified: head/ObsoleteFiles.inc

Re: svn commit: r270510 - head

2014-08-24 Thread Don Lewis
On 24 Aug, Peter Wemm wrote: On Sunday 24 August 2014 21:21:54 Don Lewis wrote: Author: truckman Date: Sun Aug 24 21:21:54 2014 New Revision: 270510 URL: http://svnweb.freebsd.org/changeset/base/270510 Log: Catch up to gcc 3.3 - 3.4 upgrade. MFC after: 3 days Modified: head

Re: svn commit: r270510 - head

2014-08-24 Thread Don Lewis
On 24 Aug, Rui Paulo wrote: On Aug 24, 2014, at 14:44, Peter Wemm pe...@wemm.org wrote: On Sunday 24 August 2014 21:21:54 Don Lewis wrote: Author: truckman Date: Sun Aug 24 21:21:54 2014 New Revision: 270510 URL: http://svnweb.freebsd.org/changeset/base/270510 Log: Catch up to gcc 3.3

Re: svn commit: r271076 - in head/sys: amd64/amd64 amd64/include i386/i386 i386/include pc98/pc98

2014-09-03 Thread Don Lewis
On 4 Sep, John Baldwin wrote: Author: jhb Date: Thu Sep 4 01:46:06 2014 New Revision: 271076 URL: http://svnweb.freebsd.org/changeset/base/271076 Log: - Move the declaration of has_f00f_hack out of identcpu.c to machdep.c. That certainly brings back memories ...

svn commit: r258363 - in head/sys/dev/usb: . serial

2013-11-19 Thread Don Lewis
Author: truckman Date: Wed Nov 20 02:16:47 2013 New Revision: 258363 URL: http://svnweb.freebsd.org/changeset/base/258363 Log: Add alternate ID for Novatel MiFi 2200 CDMA, which is used by my Virgin Mobile branded device. It needs the U3GINIT_SCSIEJECT quirk. Reviewed by: hselasky

svn commit: r258364 - head/etc/devd

2013-11-19 Thread Don Lewis
Author: truckman Date: Wed Nov 20 02:20:27 2013 New Revision: 258364 URL: http://svnweb.freebsd.org/changeset/base/258364 Log: Regenerate after r258363 (alternate ID for Novatel MiFi 2200) and r258333 (bus_autoconf.sh tweak). Modified: head/etc/devd/usb.conf Modified:

svn commit: r258629 - head/share/man/man4

2013-11-26 Thread Don Lewis
Author: truckman Date: Tue Nov 26 09:14:39 2013 New Revision: 258629 URL: http://svnweb.freebsd.org/changeset/base/258629 Log: Mention that devd will kldload the driver when the device is connected. Mention that the automatic mode switch from umass to u3g needed by some devices does not

svn commit: r259675 - in head/sys/dev/usb: . quirk

2013-12-20 Thread Don Lewis
Author: truckman Date: Sat Dec 21 03:05:13 2013 New Revision: 259675 URL: http://svnweb.freebsd.org/changeset/base/259675 Log: Add quirks to make my old SanDisk Cruzer Mini 128MB happy. MFC after:1 week Modified: head/sys/dev/usb/quirk/usb_quirk.c head/sys/dev/usb/usbdevs

Re: svn commit: r271076 - in head/sys: amd64/amd64 amd64/include i386/i386 i386/include pc98/pc98

2014-09-04 Thread Don Lewis
On 4 Sep, John Baldwin wrote: On Wednesday, September 03, 2014 07:37:21 PM Don Lewis wrote: On 4 Sep, John Baldwin wrote: Author: jhb Date: Thu Sep 4 01:46:06 2014 New Revision: 271076 URL: http://svnweb.freebsd.org/changeset/base/271076 Log: - Move the declaration

Re: svn commit: r271076 - in head/sys: amd64/amd64 amd64/include i386/i386 i386/include pc98/pc98

2014-09-04 Thread Don Lewis
On 4 Sep, Alexey Dokuchaev wrote: On Thu, Sep 04, 2014 at 09:22:48AM -0700, Don Lewis wrote: I've still got the old hardware and am often tempted to see if it will run a recent version of FreeBSD. I don't think I want to know how long it would take to run buildworld post-clang. My router

Re: svn commit: r271076 - in head/sys: amd64/amd64 amd64/include i386/i386 i386/include pc98/pc98

2014-09-04 Thread Don Lewis
On 4 Sep, John-Mark Gurney wrote: Don Lewis wrote this message on Thu, Sep 04, 2014 at 09:22 -0700: On 4 Sep, John Baldwin wrote: On Wednesday, September 03, 2014 07:37:21 PM Don Lewis wrote: On 4 Sep, John Baldwin wrote: Author: jhb Date: Thu Sep 4 01:46:06 2014 New Revision

Re: svn commit: r277828 - in head/sys: fs/tmpfs vm

2015-01-28 Thread Don Lewis
On 28 Jan, Konstantin Belousov wrote: Author: kib Date: Wed Jan 28 10:37:23 2015 New Revision: 277828 URL: https://svnweb.freebsd.org/changeset/base/277828 Log: Update mtime for tmpfs files modified through memory mapping. Similar to UFS, perform updates during syncer scans, which in

Re: svn commit: r277828 - in head/sys: fs/tmpfs vm

2015-01-28 Thread Don Lewis
On 28 Jan, Konstantin Belousov wrote: On Wed, Jan 28, 2015 at 09:41:06AM -0800, Don Lewis wrote: On 28 Jan, Konstantin Belousov wrote: Author: kib Date: Wed Jan 28 10:37:23 2015 New Revision: 277828 URL: https://svnweb.freebsd.org/changeset/base/277828 Log: Update mtime

Re: svn commit: r278479 - in head: etc sys/kern

2015-02-09 Thread Don Lewis
On 9 Feb, Don Lewis wrote: On 10 Feb, Mateusz Guzik wrote: On Mon, Feb 09, 2015 at 11:13:51PM +, Rui Paulo wrote: +notify 10 { + match system kernel; + match subsystem signal; + match typecoredump; + action logger $comm $core

Re: svn commit: r278479 - in head: etc sys/kern

2015-02-09 Thread Don Lewis
On 10 Feb, Mateusz Guzik wrote: On Mon, Feb 09, 2015 at 11:13:51PM +, Rui Paulo wrote: +notify 10 { +match system kernel; +match subsystem signal; +match typecoredump; +action logger $comm $core; +}; + */ [..] +if

Re: svn commit: r280327 - in head/sys: kern vm

2015-03-30 Thread Don Lewis
On 28 Mar, Alan Cox wrote: On 03/28/2015 12:29, Bryan Drewery wrote: On 3/27/2015 9:41 PM, Don Lewis wrote: On 21 Mar, Alan Cox wrote: Author: alc Date: Sat Mar 21 17:56:55 2015 New Revision: 280327 URL: https://svnweb.freebsd.org/changeset/base/280327 Log: Introduce vm_object_color

Re: svn commit: r280327 - in head/sys: kern vm

2015-03-28 Thread Don Lewis
On 28 Mar, Bryan Drewery wrote: On 3/27/2015 9:41 PM, Don Lewis wrote: ../generated/adfiles/ad_x86_64_clone.cpp:1: fatal error: had to relocate PCH compilation terminated. /wrkdirs/usr/ports/java/openjdk7/work/openjdk/hotspot/make/bsd/makefiles/rules.make:149: recipe for target

Re: svn commit: r280327 - in head/sys: kern vm

2015-03-30 Thread Don Lewis
On 30 Mar, Konstantin Belousov wrote: On Sun, Mar 29, 2015 at 11:25:14PM -0700, Don Lewis wrote: On amd64, with an amd64 jail, and kernel rev r280326, I observe the following: One gcc process calls mmap() with addr=0 and len=0x657a000, and the value 0x81140 is returned

Re: svn commit: r280308 - head/sys/fs/devfs

2015-03-29 Thread Don Lewis
On 29 Mar, Jilles Tjoelker wrote: On Sun, Mar 22, 2015 at 11:25:07AM -0700, Don Lewis wrote: It's not totally worthless. I think the mtime on tty devices is used to calculate the idle time that is printed by the w command. We just don't need nanosecond accuracy for that. Hmm. The idle

Re: svn commit: r280327 - in head/sys: kern vm

2015-03-28 Thread Don Lewis
On 28 Mar, Bryan Drewery wrote: On 3/27/2015 9:41 PM, Don Lewis wrote: On 21 Mar, Alan Cox wrote: Author: alc Date: Sat Mar 21 17:56:55 2015 New Revision: 280327 URL: https://svnweb.freebsd.org/changeset/base/280327 Log: Introduce vm_object_color() and use it in mmap(2) to set the color

Re: svn commit: r280327 - in head/sys: kern vm

2015-03-28 Thread Don Lewis
On 28 Mar, Alan Cox wrote: On 03/28/2015 12:29, Bryan Drewery wrote: On 3/27/2015 9:41 PM, Don Lewis wrote: I was not seeing this problem on my older package builder running 10.1-STABLE. Since this problem has not shown up on the FreeBSD package building cluster, I got suspicious

Re: svn commit: r280327 - in head/sys: kern vm

2015-03-27 Thread Don Lewis
On 21 Mar, Alan Cox wrote: Author: alc Date: Sat Mar 21 17:56:55 2015 New Revision: 280327 URL: https://svnweb.freebsd.org/changeset/base/280327 Log: Introduce vm_object_color() and use it in mmap(2) to set the color of named objects to zero before the virtual address is selected.

Re: svn commit: r285829 - head/sys/kern

2015-07-24 Thread Don Lewis
On 23 Jul, Sergey Kandaurov wrote: Author: pluknet Date: Thu Jul 23 23:18:03 2015 New Revision: 285829 URL: https://svnweb.freebsd.org/changeset/base/285829 Log: Call ksem_get() with initialized 'rights'. ksem_get() consumes fget(), and it's mandatory there. Reported by:

Re: svn commit: r289391 - head/share/mk

2015-10-15 Thread Don Lewis
On 15 Oct, Bryan Drewery wrote: > On 10/15/2015 3:49 PM, Bryan Drewery wrote: >> Author: bdrewery >> Date: Thu Oct 15 22:49:56 2015 >> New Revision: 289391 >> URL: https://svnweb.freebsd.org/changeset/base/289391 >> >> Log: >> Make installing to a non-existent directory an error. > > > Sigh -

svn commit: r301596 - head/lib/libc/gen

2016-06-08 Thread Don Lewis
Author: truckman Date: Wed Jun 8 10:25:16 2016 New Revision: 301596 URL: https://svnweb.freebsd.org/changeset/base/301596 Log: Don't leak olinep if malloc() fails. If malloc() fails to allocate linep, then free olinep (if it exists) before returning to avoid a memory leak. Reported

svn commit: r301592 - head/lib/libc/resolv

2016-06-08 Thread Don Lewis
Author: truckman Date: Wed Jun 8 09:40:06 2016 New Revision: 301592 URL: https://svnweb.freebsd.org/changeset/base/301592 Log: Don't leak addrinfo if ai->ai_addrlen <= minsiz test fails. If the ai->ai_addrlen <= minsiz test fails, then freeaddrinfo() does not get called to free the

svn commit: r301574 - head/usr.bin/random

2016-06-07 Thread Don Lewis
Author: truckman Date: Wed Jun 8 02:14:05 2016 New Revision: 301574 URL: https://svnweb.freebsd.org/changeset/base/301574 Log: Fix a (false positive?) Argument cannot be negative coverity defect. Rather than guarding close(fd) with an fd >= 0 test and setting fd to -1 when it is closed

svn commit: r301582 - head/bin/setfacl

2016-06-07 Thread Don Lewis
Author: truckman Date: Wed Jun 8 05:32:39 2016 New Revision: 301582 URL: https://svnweb.freebsd.org/changeset/base/301582 Log: Explicitly NUL terminate the buffer filled by fread(). The fix in r300649 was not sufficient to convince Coverity that the buffer was NUL terminated, even with

Re: svn commit: r301546 - head/release/doc/en_US.ISO8859-1/relnotes

2016-06-07 Thread Don Lewis
On 7 Jun, Steven Kreuzer wrote: > Author: skreuzer (doc,ports committer) > Date: Tue Jun 7 14:11:15 2016 > New Revision: 301546 > URL: https://svnweb.freebsd.org/changeset/base/301546 > > Log: > Document 300779, Dummynet AQM version 0.2.1 > > Approved by:re (gjb, implicit,

svn commit: r300692 - head/bin/ed

2016-05-25 Thread Don Lewis
Author: truckman Date: Wed May 25 18:38:30 2016 New Revision: 300692 URL: https://svnweb.freebsd.org/changeset/base/300692 Log: Close the input FILE * in read_file() and the output FILE * in write_file() if read_stream() or write_stream() fails to avoid leaking the FILE. Reported by:

svn commit: r300633 - head/usr.sbin/acpi/acpidb

2016-05-24 Thread Don Lewis
Author: truckman Date: Tue May 24 23:41:36 2016 New Revision: 300633 URL: https://svnweb.freebsd.org/changeset/base/300633 Log: Fix acpidb CIDs 1011279 (Buffer not null terminated) and 978405 and 1199380 (Resource leak). load_dsdt() calls strncpy() to copy a filename and Coverity warns

svn commit: r300635 - head/usr.sbin/ypserv

2016-05-24 Thread Don Lewis
Author: truckman Date: Wed May 25 00:16:52 2016 New Revision: 300635 URL: https://svnweb.freebsd.org/changeset/base/300635 Log: Call free(cur) if strdup(dirp->d_name) fails to avoid a memory leak. Reported by: Coverity CID: 1007414 MFC after:1 week Modified:

svn commit: r300639 - head/usr.sbin/ypldap

2016-05-24 Thread Don Lewis
Author: truckman Date: Wed May 25 01:37:25 2016 New Revision: 300639 URL: https://svnweb.freebsd.org/changeset/base/300639 Log: Fix Coverity CIDs 1340544 Resource leak and 1340543 Use after free At line 479 of ldapclient.c in client_build_req(), the error return leaks ldap_attrs (CID

svn commit: r300649 - head/bin/setfacl

2016-05-24 Thread Don Lewis
Author: truckman Date: Wed May 25 05:20:34 2016 New Revision: 300649 URL: https://svnweb.freebsd.org/changeset/base/300649 Log: Fix Coverity CID 1019054 (String not null terminated) in setfacl. Increase the size of buf[] by one to allow room for a NUL character at the end. Reported

svn commit: r300648 - head/bin/ps

2016-05-24 Thread Don Lewis
Author: truckman Date: Wed May 25 05:12:56 2016 New Revision: 300648 URL: https://svnweb.freebsd.org/changeset/base/300648 Log: Fix CID 1011370 (Resource leak) in ps. There is no need to to call strdup() on the value returned by fmt(). The latter calls fmt_argv() which always returns a

svn commit: r300660 - head/lib/libc/gen

2016-05-25 Thread Don Lewis
Author: truckman Date: Wed May 25 06:55:53 2016 New Revision: 300660 URL: https://svnweb.freebsd.org/changeset/base/300660 Log: Fix 1016718 Resource leak. Don't leak a file descriptor if fchdir() fails. Reported by: Coverity CID: 1016718 MFC after:1 week Modified:

svn commit: r300949 - head/sys/netpfil/ipfw

2016-05-29 Thread Don Lewis
Author: truckman Date: Sun May 29 07:23:56 2016 New Revision: 300949 URL: https://svnweb.freebsd.org/changeset/base/300949 Log: Cast some expressions that multiply a long long constant by a floating point constant to int64_t. This avoids the runtime conversion of the the other operand in a

svn commit: r300950 - in head/sys: conf modules/dummynet

2016-05-29 Thread Don Lewis
Author: truckman Date: Sun May 29 07:29:35 2016 New Revision: 300950 URL: https://svnweb.freebsd.org/changeset/base/300950 Log: Now that PIE is free of runtime floating point, revert r300853 to reconnect PIE to the build. Modified: head/sys/conf/files head/sys/modules/dummynet/Makefile

Re: svn commit: r300949 - head/sys/netpfil/ipfw

2016-05-30 Thread Don Lewis
On 29 May, Bruce Evans wrote: > On Sun, 29 May 2016, Don Lewis wrote: > >> Log: >> Cast some expressions that multiply a long long constant by a >> floating point constant to int64_t. This avoids the runtime >> conversion of the the other operand in a set o

svn commit: r300705 - head/usr.bin/fortune/unstr

2016-05-25 Thread Don Lewis
Author: truckman Date: Thu May 26 01:33:24 2016 New Revision: 300705 URL: https://svnweb.freebsd.org/changeset/base/300705 Log: Avoid buffer overflow when copying the input file name and appending .dat. Check the return value from fread() to be sure that it was successful. Reported

svn commit: r300706 - head/usr.sbin/tzsetup

2016-05-25 Thread Don Lewis
Author: truckman Date: Thu May 26 01:45:04 2016 New Revision: 300706 URL: https://svnweb.freebsd.org/changeset/base/300706 Log: Avoid buffer overflow or truncation when constructing path_zoneinfo_file. Reported by: Coverity CID: 1011160 MFC after:1 week Modified:

svn commit: r300853 - in head/sys: conf modules/dummynet

2016-05-27 Thread Don Lewis
Author: truckman Date: Fri May 27 17:07:07 2016 New Revision: 300853 URL: https://svnweb.freebsd.org/changeset/base/300853 Log: Disconnect PIE from the build until it is free of floating point math. Reported by: lidl, adrian Modified: head/sys/conf/files

Re: svn commit: r300779 - in head: sbin/ipfw sys/modules/dummynet sys/netinet sys/netpfil/ipfw

2016-05-27 Thread Don Lewis
On 27 May, Adrian Chadd wrote: > Hi, > > Did this introduce floating point into the kernel? Cr*p, it did. It looks fixable, but I'll disconnect PIE from the build for now. ___ svn-src-head@freebsd.org mailing list

svn commit: r301180 - head/sbin/ipfw

2016-06-02 Thread Don Lewis
Author: truckman Date: Thu Jun 2 00:42:15 2016 New Revision: 301180 URL: https://svnweb.freebsd.org/changeset/base/301180 Log: Belatedly bump .Dd date for Dummynet AQM import in r300779. Modified: head/sbin/ipfw/ipfw.8 Modified: head/sbin/ipfw/ipfw.8

svn commit: r300784 - head/sys/conf

2016-05-26 Thread Don Lewis
Author: truckman Date: Thu May 26 22:07:09 2016 New Revision: 300784 URL: https://svnweb.freebsd.org/changeset/base/300784 Log: Include the new AQM files when compiling a kernel with options DUMMYNET. Reported by: Nikolay Denev MFC after:2 weeks (with r300779) Modified:

svn commit: r300779 - in head: sbin/ipfw sys/modules/dummynet sys/netinet sys/netpfil/ipfw

2016-05-26 Thread Don Lewis
Author: truckman Date: Thu May 26 21:40:13 2016 New Revision: 300779 URL: https://svnweb.freebsd.org/changeset/base/300779 Log: Import Dummynet AQM version 0.2.1 (CoDel, FQ-CoDel, PIE and FQ-PIE). Centre for Advanced Internet Architectures Implementing AQM in FreeBSD * Overview

svn commit: r300783 - head/sys/netpfil/ipfw

2016-05-26 Thread Don Lewis
Author: truckman Date: Thu May 26 22:03:28 2016 New Revision: 300783 URL: https://svnweb.freebsd.org/changeset/base/300783 Log: Correct a typo in a comment. MFC after:2 weeks (with r300779) Modified: head/sys/netpfil/ipfw/dn_aqm.h Modified: head/sys/netpfil/ipfw/dn_aqm.h

svn commit: r300781 - head/sys/netpfil/ipfw

2016-05-26 Thread Don Lewis
Author: truckman Date: Thu May 26 21:44:52 2016 New Revision: 300781 URL: https://svnweb.freebsd.org/changeset/base/300781 Log: Modify BOUND_VAR() macro to wrap all of its arguments in () and tweak its expression to work on powerpc and sparc64 (gcc compatibility). Correct a typo in a

Re: svn commit: r300779 - in head: sbin/ipfw sys/modules/dummynet sys/netinet sys/netpfil/ipfw

2016-05-26 Thread Don Lewis
On 26 May, To: src-committ...@freebsd.org wrote: > Author: truckman > Date: Thu May 26 21:40:13 2016 > New Revision: 300779 > URL: https://svnweb.freebsd.org/changeset/base/300779 > > Log: > Import Dummynet AQM version 0.2.1 (CoDel, FQ-CoDel, PIE and FQ-PIE). > > Centre for Advanced

svn commit: r301139 - head/bin/sh

2016-06-01 Thread Don Lewis
Author: truckman Date: Wed Jun 1 16:56:29 2016 New Revision: 301139 URL: https://svnweb.freebsd.org/changeset/base/301139 Log: The (i < PROMPTLEN - 1) test added by r300442 in the code for the default case of \c in the prompt format string is a no-op. We already passed this test at the

Re: svn commit: r301139 - head/bin/sh

2016-06-01 Thread Don Lewis
On 1 Jun, To: src-committ...@freebsd.org wrote: > Author: truckman > Date: Wed Jun 1 16:56:29 2016 > New Revision: 301139 > URL: https://svnweb.freebsd.org/changeset/base/301139 > > Log: > The (i < PROMPTLEN - 1) test added by r300442 in the code for the default > case of \c in the prompt

svn commit: r301162 - head/sys/netpfil/ipfw

2016-06-01 Thread Don Lewis
Author: truckman Date: Wed Jun 1 20:04:24 2016 New Revision: 301162 URL: https://svnweb.freebsd.org/changeset/base/301162 Log: Replace constant expressions that contain multiplications by fractional floating point values with integer divides. This will eliminate any chance that the

Re: svn commit: r295465 - head/usr.sbin/services_mkdb

2016-02-10 Thread Don Lewis
On 10 Feb, Stefan Esser wrote: > Author: se > Date: Wed Feb 10 09:40:45 2016 > New Revision: 295465 > URL: https://svnweb.freebsd.org/changeset/base/295465 > > Log: > Remove O_SYNC from the options passed to dbmopen(). > > The services db is created as a temporary file that is moved over

Re: svn commit: r294444 - in head/sys/modules: ix ixlv ixv

2016-01-20 Thread Don Lewis
On 20 Jan, Bryan Drewery wrote: > On 1/20/2016 1:59 PM, Warner Losh wrote: >> It would work built part of buildkernel since pci_iov_if.h would exist >> there. It would fail when built by hand since the kernel config didn’t save >> us. >> > > I don't understand. The problem was seen in

Re: svn commit: r296880 - in head: share/man/man9 sys/kern sys/sys

2016-03-15 Thread Don Lewis
On 15 Mar, Gleb Smirnoff wrote: > Hans, > > On Tue, Mar 15, 2016 at 08:50:11AM +0100, Hans Petter Selasky wrote: > H> > Modified: head/sys/sys/sysctl.h > H> > > == > H> > --- head/sys/sys/sysctl.hMon Mar 14

Re: svn commit: r296299 - head/sys/contrib/ipfilter/netinet

2016-03-01 Thread Don Lewis
On 2 Mar, Cy Schubert wrote: > Author: cy > Date: Wed Mar 2 03:28:57 2016 > New Revision: 296299 > URL: https://svnweb.freebsd.org/changeset/base/296299 > > Log: > Remove redundant NULL pointer comparison. > > Reported by: PVS-Studio (V595) in D5245 > Differential

svn commit: r300247 - head/share/man/man4

2016-05-19 Thread Don Lewis
Author: truckman Date: Thu May 19 23:03:07 2016 New Revision: 300247 URL: https://svnweb.freebsd.org/changeset/base/300247 Log: Document new net.inet.tcp.ecn.enable sysctl settings. MFC after:1 month (with r300240) Modified: head/share/man/man4/tcp.4 Modified:

svn commit: r300240 - head/sys/netinet

2016-05-19 Thread Don Lewis
Author: truckman Date: Thu May 19 22:20:35 2016 New Revision: 300240 URL: https://svnweb.freebsd.org/changeset/base/300240 Log: Change net.inet.tcp.ecn.enable sysctl mib from a binary off/on control to a three way setting. 0 - Totally disable ECN. (no change) 1 - Enable ECN if

Re: svn commit: r300240 - head/sys/netinet

2016-05-19 Thread Don Lewis
On 19 May, Ngie Cooper wrote: > On Thu, May 19, 2016 at 3:20 PM, Don Lewis <truck...@freebsd.org> wrote: >> Author: truckman >> Date: Thu May 19 22:20:35 2016 >> New Revision: 300240 >> URL: https://svnweb.freebsd.org/changeset/base/300240 >> >> Log: &

svn commit: r300564 - head/usr.sbin/pw

2016-05-23 Thread Don Lewis
Author: truckman Date: Tue May 24 05:02:24 2016 New Revision: 300564 URL: https://svnweb.freebsd.org/changeset/base/300564 Log: Fix CID 1006692 in /usr/sbin/pw pw_log() function and other fixes The length of the name returned from the $LOGNAME and $USER can be very long and it was being

svn commit: r300547 - in head: lib/libcam sbin/camcontrol sbin/iscontrol sys/cam usr.sbin/camdd usr.sbin/mptutil

2016-05-23 Thread Don Lewis
Author: truckman Date: Tue May 24 00:57:11 2016 New Revision: 300547 URL: https://svnweb.freebsd.org/changeset/base/300547 Log: Fix multiple Coverity Out-of-bounds access false postive issues in CAM The currently used idiom for clearing the part of a ccb after its header generates one or

Re: svn commit: r300547 - in head: lib/libcam sbin/camcontrol sbin/iscontrol sys/cam usr.sbin/camdd usr.sbin/mptutil

2016-05-23 Thread Don Lewis
On 24 May, To: src-committ...@freebsd.org wrote: > Author: truckman > Date: Tue May 24 00:57:11 2016 > New Revision: 300547 > URL: https://svnweb.freebsd.org/changeset/base/300547 > > Log: > Fix multiple Coverity Out-of-bounds access false postive issues in CAM > > The currently used idiom

svn commit: r300632 - head/usr.sbin/acpi/acpidump

2016-05-24 Thread Don Lewis
Author: truckman Date: Tue May 24 23:36:43 2016 New Revision: 300632 URL: https://svnweb.freebsd.org/changeset/base/300632 Log: Fix acpidump CID 1011278 (Buffer not null terminated) and other issues Coverity reports that a buffer used for temporary file generation might not be NUL

svn commit: r300636 - head/usr.sbin/ypserv

2016-05-24 Thread Don Lewis
Author: truckman Date: Wed May 25 00:25:38 2016 New Revision: 300636 URL: https://svnweb.freebsd.org/changeset/base/300636 Log: Delay calling yp_malloc_dnsent() until after some additional sanity checks to avoid leaking memory on error returns. Reported by: Coverity CID:

svn commit: r300642 - head/bin/sh

2016-05-24 Thread Don Lewis
Author: truckman Date: Wed May 25 02:10:30 2016 New Revision: 300642 URL: https://svnweb.freebsd.org/changeset/base/300642 Log: Match the descriptions of the \H and \h prompt string sequences to reality. They were swapped. X-Confirmed by: jilles MFC after:1 week Modified:

svn commit: r300643 - head/bin/mv

2016-05-24 Thread Don Lewis
Author: truckman Date: Wed May 25 02:51:15 2016 New Revision: 300643 URL: https://svnweb.freebsd.org/changeset/base/300643 Log: Close from_fd if malloc() fails to avoid a file descriptor leak. Reported by: Coverity CID: 1007203 MFC after:1 week Modified:

Re: svn commit: r300174 - head/sbin/dhclient

2016-05-18 Thread Don Lewis
On 18 May, Conrad E. Meyer wrote: > Author: cem > Date: Wed May 18 23:41:55 2016 > New Revision: 300174 > URL: https://svnweb.freebsd.org/changeset/base/300174 > > Log: > dhclient: Fix the trivial buffer overruns correctly > > A DHCP client identifier is simply the hardware type (one byte)

svn commit: r300442 - head/bin/sh

2016-05-22 Thread Don Lewis
Author: truckman Date: Mon May 23 01:01:23 2016 New Revision: 300442 URL: https://svnweb.freebsd.org/changeset/base/300442 Log: Hopefully fix Coverity CID 1008328 (Out-of-bounds write) in /bin/sh. Replace the magic constant 127 in the loop interation count with "PROMPTLEN - 1".

svn commit: r299524 - head/usr.bin/mklocale

2016-05-12 Thread Don Lewis
Author: truckman Date: Thu May 12 08:41:22 2016 New Revision: 299524 URL: https://svnweb.freebsd.org/changeset/base/299524 Log: Use strlcpy() instead of strncpy() when copying the encoding value to ensure that the destination is NUL terminated. Length truncation of one more character

svn commit: r299525 - head/usr.bin/msgs

2016-05-12 Thread Don Lewis
Author: truckman Date: Thu May 12 08:55:57 2016 New Revision: 299525 URL: https://svnweb.freebsd.org/changeset/base/299525 Log: Use strlcpy() instead of strncpy() when copying date and subj to ensure that these are properly NUL terminated since they are passed to printf(). Reported by:

svn commit: r299516 - head/sbin/ping

2016-05-11 Thread Don Lewis
Author: truckman Date: Thu May 12 05:43:54 2016 New Revision: 299516 URL: https://svnweb.freebsd.org/changeset/base/299516 Log: Check for socket creation success before calling bind(). Reported by: Coverity CID: 1194209 Modified: head/sbin/ping/ping.c Modified:

svn commit: r299520 - head/lib/libfetch

2016-05-12 Thread Don Lewis
Author: truckman Date: Thu May 12 06:39:13 2016 New Revision: 299520 URL: https://svnweb.freebsd.org/changeset/base/299520 Log: Use strlcpy() instead of strncpy() to copy the string returned by setlocale() so that static analyzers know that the string is NUL terminated. This was causing a

Re: svn commit: r300005 - head/usr.bin/ncal

2016-05-17 Thread Don Lewis
On 16 May, To: c...@freebsd.org wrote: > On 16 May, Conrad Meyer wrote: >> On Mon, May 16, 2016 at 10:05 PM, Don Lewis <truck...@freebsd.org> wrote: >>> Author: truckman >>> Date: Tue May 17 05:05:30 2016 >>> New Revision: 35 >>> UR

svn commit: r299952 - head/usr.bin/ldd

2016-05-16 Thread Don Lewis
Author: truckman Date: Mon May 16 16:01:46 2016 New Revision: 299952 URL: https://svnweb.freebsd.org/changeset/base/299952 Log: Increase size of argv[] array to avoid running off the end. Reported by: Coverity CID: 1193819 MFC after:1 week Modified:

svn commit: r299953 - head/usr.sbin/makefs

2016-05-16 Thread Don Lewis
Author: truckman Date: Mon May 16 16:16:46 2016 New Revision: 299953 URL: https://svnweb.freebsd.org/changeset/base/299953 Log: Fix an off by one error to avoid overflowing rp[]. Reported by: Coverity CID: 1007579 Modified: head/usr.sbin/makefs/mtree.c Modified:

  1   2   >