svn commit: r214011 - head/usr.sbin/ppp

2010-10-18 Thread Gleb Smirnoff
Author: glebius Date: Mon Oct 18 07:28:53 2010 New Revision: 214011 URL: http://svn.freebsd.org/changeset/base/214011 Log: Log if fopen() fails. Reviewed by: brian Modified: head/usr.sbin/ppp/ipcp.c Modified: head/usr.sbin/ppp/ipcp.c

svn commit: r214137 - head/usr.bin/unzip

2010-10-21 Thread Gleb Smirnoff
Author: glebius Date: Thu Oct 21 17:05:15 2010 New Revision: 214137 URL: http://svn.freebsd.org/changeset/base/214137 Log: Make it possible to read input from stdin. Without this change I don't see a way to unpack a multivolume archive without wasting disk space for a temporary file.

svn commit: r214174 - head/usr.bin/unzip

2010-10-21 Thread Gleb Smirnoff
Author: glebius Date: Thu Oct 21 20:22:00 2010 New Revision: 214174 URL: http://svn.freebsd.org/changeset/base/214174 Log: Fix typo in last commit. Submitted by: bcr Modified: head/usr.bin/unzip/unzip.1 Modified: head/usr.bin/unzip/unzip.1

svn commit: r214508 - head/sys/netinet

2010-10-29 Thread Gleb Smirnoff
Author: glebius Date: Fri Oct 29 10:57:18 2010 New Revision: 214508 URL: http://svn.freebsd.org/changeset/base/214508 Log: Revert a small part of the r198301, that is entirely unrelated to the r198301 itself. It also broke the logic of not sending more than one ARP request per second, that

svn commit: r214509 - head/sys/netinet

2010-10-29 Thread Gleb Smirnoff
Author: glebius Date: Fri Oct 29 11:13:42 2010 New Revision: 214509 URL: http://svn.freebsd.org/changeset/base/214509 Log: Remove meaningless X, that is a remain of comment, removed in r186200. Modified: head/sys/netinet/if_ether.c Modified: head/sys/netinet/if_ether.c

svn commit: r215790 - head/sys/netinet

2010-11-23 Thread Gleb Smirnoff
Author: glebius Date: Wed Nov 24 05:24:36 2010 New Revision: 215790 URL: http://svn.freebsd.org/changeset/base/215790 Log: Redo r166423. It is important not only skip freeing multicast entires when underlying interface is detached, but also purge pointers to them, to avoid double-free in

svn commit: r216296 - head/sbin/route

2010-12-08 Thread Gleb Smirnoff
Author: glebius Date: Wed Dec 8 15:10:27 2010 New Revision: 216296 URL: http://svn.freebsd.org/changeset/base/216296 Log: Add RTM_IEEE80211 to array of route message descriptions. PR: 151664 Submitted by: Alexey Illarionov littlesavage rambler.ru Modified:

svn commit: r216297 - head/sbin/route

2010-12-08 Thread Gleb Smirnoff
Author: glebius Date: Wed Dec 8 15:12:37 2010 New Revision: 216297 URL: http://svn.freebsd.org/changeset/base/216297 Log: - Fix array bounds checking. [1] - Add message length checking. PR: 151664 [1] Submitted by: Alexey Illarionov littlesavage rambler.ru [1] Reviewed by:

Re: svn commit: r238990 - in head/sys: net netinet netinet6

2012-08-22 Thread Gleb Smirnoff
On Tue, Aug 21, 2012 at 12:50:14PM -0600, Kenneth D. Merry wrote: K On Thu, Aug 02, 2012 at 13:57:50 +, Gleb Smirnoff wrote: K Author: glebius K Date: Thu Aug 2 13:57:49 2012 K New Revision: 238990 K URL: http://svn.freebsd.org/changeset/base/238990 K K Log: KFix races between

svn commit: r239710 - head/sys/vm

2012-08-26 Thread Gleb Smirnoff
Author: glebius Date: Sun Aug 26 09:54:11 2012 New Revision: 239710 URL: http://svn.freebsd.org/changeset/base/239710 Log: Fix function name in keg_cachespread_init() assert. Modified: head/sys/vm/uma_core.c Modified: head/sys/vm/uma_core.c

Re: svn commit: r239940 - head/sys/dev/ixgbe

2012-08-31 Thread Gleb Smirnoff
Scott, On Fri, Aug 31, 2012 at 10:07:38AM +, Scott Long wrote: S +/* S + * Optimized bcopy thanks to Luigi Rizzo's investigative work. Assumes S + * non-overlapping regions and 32-byte padding on both src and dst. S + */ S +static __inline int S +ixgbe_bcopy(void *_src, void *_dst, int l)

svn commit: r240071 - head/sys/net

2012-09-03 Thread Gleb Smirnoff
Author: glebius Date: Mon Sep 3 10:08:20 2012 New Revision: 240071 URL: http://svn.freebsd.org/changeset/base/240071 Log: Change bridge(4) to use if_transmit for forwarding packets to underlying interfaces instead of queueing. Tested by:ray Modified: head/sys/net/if_bridge.c

svn commit: r240072 - head/usr.sbin/arp

2012-09-03 Thread Gleb Smirnoff
Author: glebius Date: Mon Sep 3 14:16:16 2012 New Revision: 240072 URL: http://svn.freebsd.org/changeset/base/240072 Log: Explicitly document all variables in the net.link.ether.inet MIB. Modified: head/usr.sbin/arp/arp.4 Modified: head/usr.sbin/arp/arp.4

svn commit: r240073 - in head: sys/netinet usr.sbin/arp

2012-09-03 Thread Gleb Smirnoff
Author: glebius Date: Mon Sep 3 14:29:28 2012 New Revision: 240073 URL: http://svn.freebsd.org/changeset/base/240073 Log: Provide a sysctl switch that allows to install ARP entries with multicast bit set. FreeBSD refuses to install such entries since 9.0, and this broke installations

svn commit: r240086 - in head: share/man/man9 sys/conf sys/libkern sys/net sys/sys

2012-09-04 Thread Gleb Smirnoff
Author: glebius Date: Tue Sep 4 12:07:33 2012 New Revision: 240086 URL: http://svn.freebsd.org/changeset/base/240086 Log: - Move jenkins.h to jenkins_hash.c - Provide missing function that can do hashing of arbitrary sized buffer. - Refetch lookup3.c and do only minimal edits to it, so

svn commit: r240214 - head/sys/kern

2012-09-07 Thread Gleb Smirnoff
Author: glebius Date: Fri Sep 7 21:06:54 2012 New Revision: 240214 URL: http://svn.freebsd.org/changeset/base/240214 Log: Supply the pr_ctloutput method for local datagram sockets, so that setsockopt() and getsockopt() work on them. This makes 'tools/regression/sockets/unix_cmsg -t

svn commit: r240233 - in head: . contrib/pf/man contrib/pf/pfctl sys/contrib/altq/altq sys/contrib/pf/net sys/modules/pf sys/net sys/netinet sys/netinet/ipfw sys/netinet6 sys/netipsec sys/sys usr.b...

2012-09-08 Thread Gleb Smirnoff
Author: glebius Date: Sat Sep 8 06:41:54 2012 New Revision: 240233 URL: http://svn.freebsd.org/changeset/base/240233 Log: Merge the projects/pf/head branch, that was worked on for last six months, into head. The most significant achievements in the new code: o Fine grained locking,

svn commit: r240234 - head/contrib/bsnmp/snmpd

2012-09-08 Thread Gleb Smirnoff
Author: glebius Date: Sat Sep 8 07:12:00 2012 New Revision: 240234 URL: http://svn.freebsd.org/changeset/base/240234 Log: The first part of check_priv() function, that attempts to obtain creds from the control message, actually never worked. This means check_priv() didn't work for local

svn commit: r240264 - head

2012-09-09 Thread Gleb Smirnoff
Author: glebius Date: Sun Sep 9 08:14:47 2012 New Revision: 240264 URL: http://svn.freebsd.org/changeset/base/240264 Log: Add removed if_pflow.h. Modified: head/ObsoleteFiles.inc Modified: head/ObsoleteFiles.inc ==

svn commit: r240271 - head/contrib/bsnmp/snmpd

2012-09-09 Thread Gleb Smirnoff
Author: glebius Date: Sun Sep 9 09:46:48 2012 New Revision: 240271 URL: http://svn.freebsd.org/changeset/base/240271 Log: For UDP transport set IP_RECVDSTADDR sockopt on the socket, and provide IP_SENDSRCADDR control with datagram message we reply with. This makes bsnmpd reply from exactly

svn commit: r240352 - head/usr.sbin/bsnmpd/modules/snmp_hostres

2012-09-11 Thread Gleb Smirnoff
Author: glebius Date: Tue Sep 11 08:28:58 2012 New Revision: 240352 URL: http://svn.freebsd.org/changeset/base/240352 Log: Spelling. Modified: head/usr.sbin/bsnmpd/modules/snmp_hostres/hostres_swrun_tbl.c Modified: head/usr.sbin/bsnmpd/modules/snmp_hostres/hostres_swrun_tbl.c

svn commit: r240354 - head/usr.sbin/bsnmpd/modules/snmp_hostres

2012-09-11 Thread Gleb Smirnoff
Author: glebius Date: Tue Sep 11 08:33:16 2012 New Revision: 240354 URL: http://svn.freebsd.org/changeset/base/240354 Log: Do not count kernel threads as processes for hrSystemProcesses OID. PR: bin/160494 Submitted by: Jeremy Chadwick freebsd jdc.parodius.com Modified:

svn commit: r240371 - in head/sys/geom: mirror raid3

2012-09-11 Thread Gleb Smirnoff
Author: glebius Date: Tue Sep 11 20:20:13 2012 New Revision: 240371 URL: http://svn.freebsd.org/changeset/base/240371 Log: When synchronizing, include in the config dump amount of bytes syncronized. The rationale behind this is the following: for large disks the percent

svn commit: r240385 - head/lib/libc/sys

2012-09-12 Thread Gleb Smirnoff
Author: glebius Date: Wed Sep 12 09:50:17 2012 New Revision: 240385 URL: http://svn.freebsd.org/changeset/base/240385 Log: Describe in detail required conditions for receiving the SCM_CREDS control message and suggest to use LOCAL_CREDS setsockopt() for reliability. Modified:

svn commit: r240386 - head/share/man/man4

2012-09-12 Thread Gleb Smirnoff
Author: glebius Date: Wed Sep 12 10:09:34 2012 New Revision: 240386 URL: http://svn.freebsd.org/changeset/base/240386 Log: Document conditions for IP_SENDSRCADDR socket option. Obtained from:r167342 commit message Modified: head/share/man/man4/ip.4 Modified:

svn commit: r240638 - head/sys/netpfil/pf

2012-09-18 Thread Gleb Smirnoff
Author: glebius Date: Tue Sep 18 09:15:32 2012 New Revision: 240638 URL: http://svn.freebsd.org/changeset/base/240638 Log: Fix DIOCNATLOOK: zero key padding before performing lookup. Modified: head/sys/netpfil/pf/pf_ioctl.c Modified: head/sys/netpfil/pf/pf_ioctl.c

svn commit: r240640 - head/sys/net

2012-09-18 Thread Gleb Smirnoff
Author: glebius Date: Tue Sep 18 10:52:46 2012 New Revision: 240640 URL: http://svn.freebsd.org/changeset/base/240640 Log: - Add $FreeBSD$ to allow modifications to this file. - Move $OpenBSD$ to a more standard place. Modified: head/sys/net/pfvar.h Modified: head/sys/net/pfvar.h

svn commit: r240641 - in head/sys: net netpfil/pf

2012-09-18 Thread Gleb Smirnoff
Author: glebius Date: Tue Sep 18 10:54:56 2012 New Revision: 240641 URL: http://svn.freebsd.org/changeset/base/240641 Log: Make ruleset anchors in pf(4) reentrant. We've got two problems here: 1) Ruleset parser uses a global variable for anchor stack. 2) When processing a wildcard

svn commit: r240646 - head/sys/contrib/altq/altq

2012-09-18 Thread Gleb Smirnoff
Author: glebius Date: Tue Sep 18 12:34:35 2012 New Revision: 240646 URL: http://svn.freebsd.org/changeset/base/240646 Log: Do more than r236298 did in the projects/pf branch: use M_NOWAIT in altq_add() and its descendants. Currently altq(4) in FreeBSD is configured via pf(4) ioctls, which

svn commit: r240676 - head/sys/vm

2012-09-18 Thread Gleb Smirnoff
Author: glebius Date: Tue Sep 18 20:28:55 2012 New Revision: 240676 URL: http://svn.freebsd.org/changeset/base/240676 Log: If caller specifies UMA_ZONE_OFFPAGE explicitly, then do not waste memory in an allocation for a slab. Reviewed by: jeff Modified: head/sys/vm/uma_core.c

svn commit: r240723 - head/sys/net

2012-09-19 Thread Gleb Smirnoff
Author: glebius Date: Thu Sep 20 03:09:58 2012 New Revision: 240723 URL: http://svn.freebsd.org/changeset/base/240723 Log: Add missing break. Pointy hat to:glebius Modified: head/sys/net/pfvar.h Modified: head/sys/net/pfvar.h

svn commit: r240734 - head/contrib/bsnmp/snmpd

2012-09-19 Thread Gleb Smirnoff
Author: glebius Date: Thu Sep 20 05:41:20 2012 New Revision: 240734 URL: http://svn.freebsd.org/changeset/base/240734 Log: Re-do r240271: - Set IP_RECVDSTADDR sockopt on the socket only in case if it is INADDR_ANY bound. - Supply IP_SENDSRCADDR control message only if we did receive

svn commit: r240735 - head/share/man/man4

2012-09-19 Thread Gleb Smirnoff
Author: glebius Date: Thu Sep 20 05:49:31 2012 New Revision: 240735 URL: http://svn.freebsd.org/changeset/base/240735 Log: Redo r240386 providing more correct information. Modified: head/share/man/man4/ip.4 Modified: head/share/man/man4/ip.4

svn commit: r240736 - in head/sys: net netpfil/pf

2012-09-20 Thread Gleb Smirnoff
Author: glebius Date: Thu Sep 20 06:52:05 2012 New Revision: 240736 URL: http://svn.freebsd.org/changeset/base/240736 Log: Utilize Jenkins hash with random seed for source nodes storage. Modified: head/sys/net/pfvar.h head/sys/netpfil/pf/pf.c Modified: head/sys/net/pfvar.h

svn commit: r240737 - head/sys/netpfil/pf

2012-09-20 Thread Gleb Smirnoff
Author: glebius Date: Thu Sep 20 07:04:08 2012 New Revision: 240737 URL: http://svn.freebsd.org/changeset/base/240737 Log: Reduce copy/paste when freeing an source node. Modified: head/sys/netpfil/pf/pf.c Modified: head/sys/netpfil/pf/pf.c

svn commit: r240742 - head/sys/net

2012-09-20 Thread Gleb Smirnoff
Author: glebius Date: Thu Sep 20 10:05:10 2012 New Revision: 240742 URL: http://svn.freebsd.org/changeset/base/240742 Log: Convert lagg(4) to use if_transmit instead of if_start. In collaboration with:thompsa, sbruno, fabient Modified: head/sys/net/if_lagg.c Modified:

svn commit: r240809 - head/sys/netpfil/pf

2012-09-22 Thread Gleb Smirnoff
Author: glebius Date: Sat Sep 22 10:02:44 2012 New Revision: 240809 URL: http://svn.freebsd.org/changeset/base/240809 Log: Fix fallout from r236397 in pfr_update_stats(), that was missed later in r237155. We need to zero sockaddr before lookup. While here, make pfr_update_stats() panic on

svn commit: r240810 - head/sys/netpfil/pf

2012-09-22 Thread Gleb Smirnoff
Author: glebius Date: Sat Sep 22 10:04:48 2012 New Revision: 240810 URL: http://svn.freebsd.org/changeset/base/240810 Log: In pfr_insert_kentry() return ENOMEM if memory allocation failed. Modified: head/sys/netpfil/pf/pf_table.c Modified: head/sys/netpfil/pf/pf_table.c

svn commit: r240811 - head/sys/netpfil/pf

2012-09-22 Thread Gleb Smirnoff
Author: glebius Date: Sat Sep 22 10:14:47 2012 New Revision: 240811 URL: http://svn.freebsd.org/changeset/base/240811 Log: When connection rate hits and we overload a source to a table, we are actually editing table, which means editing rules, thus we need writer access to 'em. Fix

svn commit: r240835 - head/sys/contrib/altq/altq

2012-09-22 Thread Gleb Smirnoff
Author: glebius Date: Sat Sep 22 18:47:14 2012 New Revision: 240835 URL: http://svn.freebsd.org/changeset/base/240835 Log: Use M_NOWAIT in wtab_alloc(), too. Convert panic() to a soft failure here. wtab_alloc() is used by red_alloc(), which can fail. Reported by: Kim Culhan w8hdkim

svn commit: r240836 - head/sys/netpfil/pf

2012-09-22 Thread Gleb Smirnoff
Author: glebius Date: Sat Sep 22 19:03:11 2012 New Revision: 240836 URL: http://svn.freebsd.org/changeset/base/240836 Log: EBUSY is a better reply for refusing to unload pf(4) or pfsync(4). Submitted by: pluknet Modified: head/sys/netpfil/pf/if_pfsync.c head/sys/netpfil/pf/pf_ioctl.c

svn commit: r240918 - head/sys/contrib/altq/altq

2012-09-25 Thread Gleb Smirnoff
Author: glebius Date: Tue Sep 25 12:45:41 2012 New Revision: 240918 URL: http://svn.freebsd.org/changeset/base/240918 Log: Fix panic introduced by me in r240835, when zero weight was passed to wtab_alloc(). Reported by: Kim Culhan w8hdkim gmail.com Modified:

Re: svn commit: r240938 - head/sys/net

2012-09-26 Thread Gleb Smirnoff
Ed, On Tue, Sep 25, 2012 at 10:10:14PM +, Ed Maste wrote: E Author: emaste E Date: Tue Sep 25 22:10:14 2012 E New Revision: 240938 E URL: http://svn.freebsd.org/changeset/base/240938 E E Log: E Avoid INVARIANTS panic destroying an in-use tap(4) E E The requirement (implied by the

Re: svn commit: r240938 - head/sys/net

2012-09-26 Thread Gleb Smirnoff
On Wed, Sep 26, 2012 at 10:56:15AM +0400, Gleb Smirnoff wrote: T Ed, T T On Tue, Sep 25, 2012 at 10:10:14PM +, Ed Maste wrote: T E Author: emaste T E Date: Tue Sep 25 22:10:14 2012 T E New Revision: 240938 T E URL: http://svn.freebsd.org/changeset/base/240938 T E T E Log: T E Avoid

svn commit: r240971 - head/sys/net

2012-09-26 Thread Gleb Smirnoff
Author: glebius Date: Wed Sep 26 20:09:48 2012 New Revision: 240971 URL: http://svn.freebsd.org/changeset/base/240971 Log: - In the bridge_enqueue() do success/error accounting for each fragment, not only once. - In the GRAB_OUR_PACKETS() macro do increase if_ibytes. Modified:

svn commit: r240985 - head/sys/netinet

2012-09-27 Thread Gleb Smirnoff
Author: glebius Date: Thu Sep 27 07:13:21 2012 New Revision: 240985 URL: http://svn.freebsd.org/changeset/base/240985 Log: Fix bug in TCP_KEEPCNT setting, which slipped in in the last round of reviewing of r231025. Unlike other options from this family TCP_KEEPCNT doesn't specify time

svn commit: r240990 - head/sys/dev/pci

2012-09-27 Thread Gleb Smirnoff
Author: glebius Date: Thu Sep 27 10:30:11 2012 New Revision: 240990 URL: http://svn.freebsd.org/changeset/base/240990 Log: Fix several build failures for !COMPAT_FREEBSD32 and !COMPAT_FREEBSD* kernels introduced by r240981. Pointy hat to:sobomax Modified:

svn commit: r240992 - head/sys/dev/pci

2012-09-27 Thread Gleb Smirnoff
Author: glebius Date: Thu Sep 27 10:46:22 2012 New Revision: 240992 URL: http://svn.freebsd.org/changeset/base/240992 Log: Fix zillions of style(9) and spacing bugs introduced by r240981. Pointy hat to:sobomax Modified: head/sys/dev/pci/pci_user.c Modified:

svn commit: r241037 - in head: share/man/man9 sys/dev/bxe sys/dev/e1000 sys/dev/ixgbe sys/dev/mxge sys/dev/oce sys/dev/vxge sys/net sys/ofed/drivers/net/mlx4 sys/sys

2012-09-28 Thread Gleb Smirnoff
Author: glebius Date: Fri Sep 28 18:28:27 2012 New Revision: 241037 URL: http://svn.freebsd.org/changeset/base/241037 Log: The drbr(9) API appeared to be so unclear, that most drivers in tree used it incorrectly, which lead to inaccurate overrated if_obytes accounting. The drbr(9) used to

svn commit: r241039 - head/sys/netpfil/pf

2012-09-28 Thread Gleb Smirnoff
Author: glebius Date: Fri Sep 28 20:43:03 2012 New Revision: 241039 URL: http://svn.freebsd.org/changeset/base/241039 Log: Simplify and somewhat redesign interaction between pf_purge_thread() and pf_purge_expired_states(). Now pf purging daemon stores the current hash table index on

svn commit: r241043 - head/sys/netinet

2012-09-28 Thread Gleb Smirnoff
Author: glebius Date: Sat Sep 29 05:52:19 2012 New Revision: 241043 URL: http://svn.freebsd.org/changeset/base/241043 Log: carp_send_ad() should never return without rescheduling next run. Modified: head/sys/netinet/ip_carp.c Modified: head/sys/netinet/ip_carp.c

svn commit: r241045 - head/share/man/man4

2012-09-29 Thread Gleb Smirnoff
Author: glebius Date: Sat Sep 29 10:49:02 2012 New Revision: 241045 URL: http://svn.freebsd.org/changeset/base/241045 Log: Give a clue how to force tcpdump(8) to interpret correctly CARP packets. Modified: head/share/man/man4/carp.4 Modified: head/share/man/man4/carp.4

svn commit: r241052 - head/sbin/pfctl

2012-09-29 Thread Gleb Smirnoff
Author: glebius Date: Sat Sep 29 16:42:01 2012 New Revision: 241052 URL: http://svn.freebsd.org/changeset/base/241052 Log: - Get rid of #ifdef __FreeBSD__. - Use correct format when printing uint64_t. Modified: head/sbin/pfctl/pf_print_state.c Modified: head/sbin/pfctl/pf_print_state.c

svn commit: r241057 - head/sys/netpfil/pf

2012-09-29 Thread Gleb Smirnoff
Author: glebius Date: Sat Sep 29 20:11:00 2012 New Revision: 241057 URL: http://svn.freebsd.org/changeset/base/241057 Log: Clear and re-setup all function pointers that glue pf(4) and pfsync(4) together whenever the pfsync0 is brought down or up respectively. Modified:

svn commit: r241129 - head/sys/netinet

2012-10-02 Thread Gleb Smirnoff
Author: glebius Date: Tue Oct 2 12:03:02 2012 New Revision: 241129 URL: http://svn.freebsd.org/changeset/base/241129 Log: There is a complex race in in_pcblookup_hash() and in_pcblookup_group(). Both functions need to obtain lock on the found PCB, and they can't do classic inter-lock with

svn commit: r241131 - head/sys/netpfil/pf

2012-10-02 Thread Gleb Smirnoff
Author: glebius Date: Tue Oct 2 12:44:46 2012 New Revision: 241131 URL: http://svn.freebsd.org/changeset/base/241131 Log: To reduce volume of pfsync traffic: - Scan request update queue to prevent doubles. - Do not push undersized daragram in pfsync_update_request(). Modified:

Re: svn commit: r241140 - head/sys/kern

2012-10-02 Thread Gleb Smirnoff
On Tue, Oct 02, 2012 at 06:38:05PM +, Garrett Wollman wrote: G Author: wollman G Date: Tue Oct 2 18:38:05 2012 G New Revision: 241140 G URL: http://svn.freebsd.org/changeset/base/241140 G G Log: G Fix spelling of the function name in two assertion messages. G G Modified: G

svn commit: r241221 - in head: contrib/tcpdump usr.sbin/tcpdump/tcpdump

2012-10-05 Thread Gleb Smirnoff
== --- /dev/null 00:00:00 1970 (empty, because file is newly added) +++ head/contrib/tcpdump/print-pfsync.c Fri Oct 5 07:51:21 2012 (r241221) @@ -0,0 +1,451 @@ +/* + * Copyright (c) 2012 Gleb Smirnoff gleb...@freebsd.org

svn commit: r241244 - head/sys/netpfil/pf

2012-10-06 Thread Gleb Smirnoff
Author: glebius Date: Sat Oct 6 07:06:57 2012 New Revision: 241244 URL: http://svn.freebsd.org/changeset/base/241244 Log: The pfil(9) layer guarantees us presence of the protocol header, so remove extra check, that is always false. P.S. Also, goto there lead to unlocking a not locked

svn commit: r241245 - in head: . share/man/man9 sys/contrib/ipfilter/netinet sys/net sys/netinet sys/netpfil/ipfw sys/netpfil/pf sys/sys

2012-10-06 Thread Gleb Smirnoff
Author: glebius Date: Sat Oct 6 10:02:11 2012 New Revision: 241245 URL: http://svn.freebsd.org/changeset/base/241245 Log: A step in resolving mess with byte ordering for AF_INET. After this change: - All packets in NETISR_IP queue are in net byte order. - ip_input() is entered in

Re: svn commit: r241245 - in head: . share/man/man9 sys/contrib/ipfilter/netinet sys/net sys/netinet sys/netpfil/ipfw sys/netpfil/pf sys/sys

2012-10-07 Thread Gleb Smirnoff
On Sun, Oct 07, 2012 at 06:49:51PM -0700, Adrian Chadd wrote: A Hi, A A People have been reporting this: A A A Oct 7 18:35:19 alix kernel: in_cksum_skip: out of data by 53295 A Oct 7 18:35:19 alix kernel: in_cksum_skip: out of data by 55335 A A Would you please investigate this, or back the

svn commit: r241342 - head/sys/netinet

2012-10-08 Thread Gleb Smirnoff
Author: glebius Date: Mon Oct 8 07:21:32 2012 New Revision: 241342 URL: http://svn.freebsd.org/changeset/base/241342 Log: No reason to play with IP header before calling sctp_delayed_cksum() with offset beyond the IP header. Modified: head/sys/netinet/ip_divert.c Modified:

svn commit: r241344 - in head/sys: netgraph netinet netinet6 netpfil/ipfw netpfil/pf

2012-10-08 Thread Gleb Smirnoff
Author: glebius Date: Mon Oct 8 08:03:58 2012 New Revision: 241344 URL: http://svn.freebsd.org/changeset/base/241344 Log: After r241245 it appeared that in_delayed_cksum(), which still expects host byte order, was sometimes called with net byte order. Since we are moving towards net byte

svn commit: r241360 - head/sys/netpfil/pf

2012-10-09 Thread Gleb Smirnoff
Author: glebius Date: Mon Oct 8 23:02:32 2012 New Revision: 241360 URL: http://svn.freebsd.org/changeset/base/241360 Log: Any pfil(9) hooks should be called with already set VNET context. Reviewed by: bz Modified: head/sys/netpfil/pf/pf_ioctl.c Modified:

svn commit: r241359 - head/sys/netpfil/ipfw

2012-10-09 Thread Gleb Smirnoff
Author: glebius Date: Mon Oct 8 22:58:28 2012 New Revision: 241359 URL: http://svn.freebsd.org/changeset/base/241359 Log: Catch up with r241245 and do not return packet back in host byte order. Modified: head/sys/netpfil/ipfw/ip_fw_pfil.c Modified: head/sys/netpfil/ipfw/ip_fw_pfil.c

Re: svn commit: r241471 - head/share/man/man9

2012-10-11 Thread Gleb Smirnoff
On Fri, Oct 12, 2012 at 01:31:03AM +, Kevin Lo wrote: K Author: kevlo K Date: Fri Oct 12 01:31:02 2012 K New Revision: 241471 K URL: http://svn.freebsd.org/changeset/base/241471 K K Log: K Since the moduledata structure member priv is a void pointer, using K NULL instead of 0 when dealing

svn commit: r241481 - head/sys/netinet

2012-10-12 Thread Gleb Smirnoff
Author: glebius Date: Fri Oct 12 09:32:38 2012 New Revision: 241481 URL: http://svn.freebsd.org/changeset/base/241481 Log: Revert fixup of ip_len from r241480. Now stack isn't yet ready for that change. Modified: head/sys/netinet/ip_options.c Modified: head/sys/netinet/ip_options.c

svn commit: r241482 - head/share/man/man4

2012-10-12 Thread Gleb Smirnoff
Author: glebius Date: Fri Oct 12 12:27:30 2012 New Revision: 241482 URL: http://svn.freebsd.org/changeset/base/241482 Log: Be more explicit on how intact incoming packets in raw sockets are. Modified: head/share/man/man4/ip.4 Modified: head/share/man/man4/ip.4

svn commit: r241491 - head/share/man/man4

2012-10-12 Thread Gleb Smirnoff
Author: glebius Date: Fri Oct 12 19:53:13 2012 New Revision: 241491 URL: http://svn.freebsd.org/changeset/base/241491 Log: Fix type in last commit. Submitted by: brueffer Modified: head/share/man/man4/ip.4 Modified: head/share/man/man4/ip.4

svn commit: r241547 - head/sys/netinet

2012-10-14 Thread Gleb Smirnoff
Author: glebius Date: Sun Oct 14 15:08:07 2012 New Revision: 241547 URL: http://svn.freebsd.org/changeset/base/241547 Log: Fix a miss from r241344: in ip_mloopback() we need to go to net byte order prior to calling in_delayed_cksum(). Reported by: Olivier Cochard-Labbe olivier

svn commit: r241575 - head/sys/netinet

2012-10-15 Thread Gleb Smirnoff
Author: glebius Date: Mon Oct 15 07:57:55 2012 New Revision: 241575 URL: http://svn.freebsd.org/changeset/base/241575 Log: We don't need to convert ip6_len to host byte order before ip6_output(), the IPv6 stack is working in net byte order. The reason this code worked before is that

Re: svn commit: r241546 - head/sys/contrib/ipfilter/netinet

2012-10-15 Thread Gleb Smirnoff
On Mon, Oct 15, 2012 at 08:34:09AM -0400, John Baldwin wrote: J On Sunday, October 14, 2012 11:03:07 am Gleb Smirnoff wrote: J Author: glebius J Date: Sun Oct 14 15:03:06 2012 J New Revision: 241546 J URL: http://svn.freebsd.org/changeset/base/241546 J J Log: JFix defines in r241245. We

Re: svn commit: r241546 - head/sys/contrib/ipfilter/netinet

2012-10-15 Thread Gleb Smirnoff
On Tue, Oct 16, 2012 at 05:09:31AM +1100, Bruce Evans wrote: B On Mon, Oct 15, 2012 at 06:36:58PM +0400, Gleb Smirnoff wrote: B On Mon, Oct 15, 2012 at 08:34:09AM -0400, John Baldwin wrote: B J On Sunday, October 14, 2012 11:03:07 am Gleb Smirnoff wrote: B J Author: glebius B J Date: Sun

svn commit: r241603 - head/sys/dev/aha

2012-10-16 Thread Gleb Smirnoff
Author: glebius Date: Tue Oct 16 08:40:09 2012 New Revision: 241603 URL: http://svn.freebsd.org/changeset/base/241603 Log: Fix build of aha(4). Submitted by: delphij Modified: head/sys/dev/aha/aha.c head/sys/dev/aha/aha_isa.c head/sys/dev/aha/ahareg.h Modified:

svn commit: r241610 - in head: . sys/dev/usb sys/net sys/net80211 sys/netpfil/ipfw sys/netpfil/pf sys/sys

2012-10-16 Thread Gleb Smirnoff
:20 2012(r241609) +++ head/sys/net/if_clone.c Tue Oct 16 13:37:54 2012(r241610) @@ -1,4 +1,5 @@ /*- + * Copyright (c) 2012 Gleb Smirnoff gleb...@freebsd.org * Copyright (c) 1980, 1986, 1993 * The Regents of the University of California. All rights reserved. * @@ -42,19

svn commit: r241677 - head/sys/net

2012-10-18 Thread Gleb Smirnoff
Author: glebius Date: Thu Oct 18 09:57:56 2012 New Revision: 241677 URL: http://svn.freebsd.org/changeset/base/241677 Log: Utilize new macro to initialize if_baudrate(). Modified: head/sys/net/if_epair.c Modified: head/sys/net/if_epair.c

svn commit: r241678 - head/sys/dev/bxe

2012-10-18 Thread Gleb Smirnoff
Author: glebius Date: Thu Oct 18 09:59:50 2012 New Revision: 241678 URL: http://svn.freebsd.org/changeset/base/241678 Log: Utilize new macro to initialize if_baudrate. Modified: head/sys/dev/bxe/if_bxe.c Modified: head/sys/dev/bxe/if_bxe.c

svn commit: r241685 - head/contrib/bsnmp/snmp_mibII

2012-10-18 Thread Gleb Smirnoff
Author: glebius Date: Thu Oct 18 13:46:26 2012 New Revision: 241685 URL: http://svn.freebsd.org/changeset/base/241685 Log: Looks like support.h is really not needed here. Modified: head/contrib/bsnmp/snmp_mibII/mibII_route.c Modified: head/contrib/bsnmp/snmp_mibII/mibII_route.c

svn commit: r241687 - head/sys/dev/mxge

2012-10-18 Thread Gleb Smirnoff
Author: glebius Date: Thu Oct 18 13:57:28 2012 New Revision: 241687 URL: http://svn.freebsd.org/changeset/base/241687 Log: Utilize new macro to initialize if_baudrate. Modified: head/sys/dev/mxge/if_mxge.c Modified: head/sys/dev/mxge/if_mxge.c

Re: svn commit: r241688 - head/sys/net

2012-10-18 Thread Gleb Smirnoff
On Thu, Oct 18, 2012 at 02:08:26PM +, Andre Oppermann wrote: A Author: andre A Date: Thu Oct 18 14:08:26 2012 A New Revision: 241688 A URL: http://svn.freebsd.org/changeset/base/241688 A A Log: A Use LOG_WARNING level in in_attachdomain1() instead of printf(). A A Submitted by:

svn commit: r241689 - head/sys/dev/nvme

2012-10-18 Thread Gleb Smirnoff
Author: glebius Date: Thu Oct 18 14:25:33 2012 New Revision: 241689 URL: http://svn.freebsd.org/changeset/base/241689 Log: Fix build after r241659. Modified: head/sys/dev/nvme/nvme_qpair.c Modified: head/sys/dev/nvme/nvme_qpair.c

svn commit: r241723 - head/sys/dev/netmap

2012-10-19 Thread Gleb Smirnoff
Author: glebius Date: Fri Oct 19 09:41:45 2012 New Revision: 241723 URL: http://svn.freebsd.org/changeset/base/241723 Log: Fix build. Modified: head/sys/dev/netmap/netmap.c Modified: head/sys/dev/netmap/netmap.c ==

Re: svn commit: r241823 - in head: . etc etc/atf etc/mtree lib lib/atf lib/atf/libatf-c lib/atf/libatf-c++ libexec libexec/atf libexec/atf/atf-check share share/atf share/doc share/doc/atf share/examp

2012-10-22 Thread Gleb Smirnoff
On Mon, Oct 22, 2012 at 01:18:41AM +, Marcel Moolenaar wrote: M Tinderbox breakages that are the result of this commit are entirely M the committer's fault -- in other words: buildworld testing on amd64 M only. Taking into account the fact that last couple of weeks head was usually not

Re: svn commit: r241823 - in head: . etc etc/atf etc/mtree lib lib/atf lib/atf/libatf-c lib/atf/libatf-c++ libexec libexec/atf libexec/atf/atf-check share share/atf share/doc share/doc/atf share/examp

2012-10-22 Thread Gleb Smirnoff
On Mon, Oct 22, 2012 at 09:42:42AM -0700, Garrett Cooper wrote: G On Mon, Oct 22, 2012 at 8:07 AM, Gleb Smirnoff gleb...@freebsd.org wrote: G On Mon, Oct 22, 2012 at 01:18:41AM +, Marcel Moolenaar wrote: G M Tinderbox breakages that are the result of this commit are entirely G M

Re: svn commit: r241897 - in head: . sys/sys

2012-10-22 Thread Gleb Smirnoff
On Mon, Oct 22, 2012 at 07:28:42PM +0100, Attilio Rao wrote: A On 10/22/12, Konstantin Belousov k...@freebsd.org wrote: A Author: kib A Date: Mon Oct 22 17:54:32 2012 A New Revision: 241897 A URL: http://svn.freebsd.org/changeset/base/241897 A A Log: ABump __FreeBSD_version and make a

svn commit: r241913 - in head: . sys/net sys/netgraph sys/netinet sys/netinet6 sys/netipsec sys/netpfil/ipfw sys/netpfil/pf sys/sys

2012-10-22 Thread Gleb Smirnoff
Author: glebius Date: Mon Oct 22 21:09:03 2012 New Revision: 241913 URL: http://svn.freebsd.org/changeset/base/241913 Log: Switch the entire IPv4 stack to keep the IP packet header in network byte order. Any host byte order processing is done in local variables and host byte order values

svn commit: r241922 - head/sys/netipsec

2012-10-23 Thread Gleb Smirnoff
Author: glebius Date: Tue Oct 23 08:22:01 2012 New Revision: 241922 URL: http://svn.freebsd.org/changeset/base/241922 Log: - Fix one more miss from r241913. - Add XXX comment about necessity of the entire block, that fixes up the IP header. Modified: head/sys/netipsec/ipsec_input.c

Re: svn commit: r241922 - head/sys/netipsec

2012-10-23 Thread Gleb Smirnoff
On Tue, Oct 23, 2012 at 08:22:02AM +, Gleb Smirnoff wrote: T Author: glebius T Date: Tue Oct 23 08:22:01 2012 T New Revision: 241922 T URL: http://svn.freebsd.org/changeset/base/241922 T T Log: T - Fix one more miss from r241913. T - Add XXX comment about necessity of the entire block, T

svn commit: r241923 - in head/sys: netinet netipsec

2012-10-23 Thread Gleb Smirnoff
Author: glebius Date: Tue Oct 23 08:33:13 2012 New Revision: 241923 URL: http://svn.freebsd.org/changeset/base/241923 Log: Do not reduce ip_len by size of IP header in the ip_input() before passing a packet to protocol input routines. For several protocols this mean that now protocol

Re: svn commit: r241923 - in head/sys: netinet netipsec

2012-10-23 Thread Gleb Smirnoff
On Tue, Oct 23, 2012 at 11:12:00AM +0200, Andre Oppermann wrote: A On 23.10.2012 10:33, Gleb Smirnoff wrote: A Author: glebius A Date: Tue Oct 23 08:33:13 2012 A New Revision: 241923 A URL: http://svn.freebsd.org/changeset/base/241923 A A Log: A Do not reduce ip_len by size of IP

svn commit: r241925 - head/sys/netinet

2012-10-23 Thread Gleb Smirnoff
Author: glebius Date: Tue Oct 23 10:29:31 2012 New Revision: 241925 URL: http://svn.freebsd.org/changeset/base/241925 Log: Simplify ip_stripoptions() reducing number of intermediate variables. Modified: head/sys/netinet/ip_options.c Modified: head/sys/netinet/ip_options.c

svn commit: r241926 - head/sys/netinet

2012-10-23 Thread Gleb Smirnoff
Author: glebius Date: Tue Oct 23 10:30:09 2012 New Revision: 241926 URL: http://svn.freebsd.org/changeset/base/241926 Log: Use ip_stripoptions() instead of handrolled version. Modified: head/sys/netinet/ip_icmp.c Modified: head/sys/netinet/ip_icmp.c

Re: svn commit: r241931 - in head/sys: conf kern

2012-10-23 Thread Gleb Smirnoff
On Tue, Oct 23, 2012 at 02:19:45PM +, Andre Oppermann wrote: A Author: andre A Date: Tue Oct 23 14:19:44 2012 A New Revision: 241931 A URL: http://svn.freebsd.org/changeset/base/241931 A A Log: A Replace the ill-named ZERO_COPY_SOCKET kernel option with two A more appropriate named kernel

Re: svn commit: r241931 - in head/sys: conf kern

2012-10-23 Thread Gleb Smirnoff
On Tue, Oct 23, 2012 at 05:05:48PM +0200, Andre Oppermann wrote: A There shouldn't be any users. Zero copy send is broken and A responsible for random kernel crashes. Zero copy receive isn't A supported by any modern driver. Both are useless to dangerous. A A The main problem with

svn commit: r242013 - head/sys/net

2012-10-24 Thread Gleb Smirnoff
Author: glebius Date: Wed Oct 24 18:33:44 2012 New Revision: 242013 URL: http://svn.freebsd.org/changeset/base/242013 Log: Fix fallout from r240071. If destination interface lookup fails, we should broadcast a packet, not try to deliver it to NULL. Reported by: rpaulo Modified:

Re: svn commit: r242013 - head/sys/net

2012-10-24 Thread Gleb Smirnoff
On Wed, Oct 24, 2012 at 02:42:33PM -0400, John Baldwin wrote: J On Wednesday, October 24, 2012 2:33:44 pm Gleb Smirnoff wrote: J Author: glebius J Date: Wed Oct 24 18:33:44 2012 J New Revision: 242013 J URL: http://svn.freebsd.org/changeset/base/242013 J J Log: JFix fallout from r240071

svn commit: r242076 - head/sys/netinet

2012-10-25 Thread Gleb Smirnoff
Author: glebius Date: Thu Oct 25 09:00:57 2012 New Revision: 242076 URL: http://svn.freebsd.org/changeset/base/242076 Log: Fix error in r241913 that had broken fragment reassembly. Modified: head/sys/netinet/ip_input.c Modified: head/sys/netinet/ip_input.c

svn commit: r242077 - head/sys/netinet

2012-10-25 Thread Gleb Smirnoff
Author: glebius Date: Thu Oct 25 09:02:21 2012 New Revision: 242077 URL: http://svn.freebsd.org/changeset/base/242077 Log: After r241923 the updated ip_len no longer needed. Modified: head/sys/netinet/ip_input.c Modified: head/sys/netinet/ip_input.c

Re: svn commit: r242079 - in head: sbin/ipfw share/man/man4 sys/conf sys/net sys/netinet sys/netinet6 sys/netpfil/ipfw

2012-10-26 Thread Gleb Smirnoff
On Thu, Oct 25, 2012 at 10:29:51PM +0200, Andre Oppermann wrote: A On 25.10.2012 18:25, Andrey V. Elsukov wrote: A On 25.10.2012 19:54, Andre Oppermann wrote: A I still don't agree with naming the sysctl net.pfil.forward. This A type of forwarding is a property of IPv4 and IPv6 and thus should

svn commit: r242161 - in head/sys: net netinet netpfil/pf

2012-10-26 Thread Gleb Smirnoff
Author: glebius Date: Fri Oct 26 21:06:33 2012 New Revision: 242161 URL: http://svn.freebsd.org/changeset/base/242161 Log: o Remove last argument to ip_fragment(), and obtain all needed information on checksums directly from mbuf flags. This simplifies code. o Clear CSUM_IP from the mbuf

  1   2   3   4   5   6   7   8   9   10   >