Re: svn commit: r326702 - head/sys/net

2017-12-08 Thread Ryan Stone
On Fri, Dec 8, 2017 at 1:43 PM, Stephen Hurd wrote: > Author: shurd > Date: Fri Dec 8 18:43:31 2017 > New Revision: 326702 > URL: https://svnweb.freebsd.org/changeset/base/326702 > + if (!M_WRITABLE(*m_head)) { > + new_head = m_dup(*m_head, M_NOWAIT); > + if (new

svn commit: r326860 - head/sys/net

2017-12-14 Thread Ryan Stone
Author: rstone Date: Thu Dec 14 20:48:50 2017 New Revision: 326860 URL: https://svnweb.freebsd.org/changeset/base/326860 Log: Plug an ifaddr leak when changing a route's src If a route is modified in a way that changes the route's source address (i.e. the address used to access the gatewa

svn commit: r328271 - in head/sys: net netinet

2018-01-23 Thread Ryan Stone
Author: rstone Date: Tue Jan 23 03:15:39 2018 New Revision: 328271 URL: https://svnweb.freebsd.org/changeset/base/328271 Log: Reduce code duplication for inpcb route caching Add a new macro to clear both the L3 and L2 route caches, to hopefully prevent future instances where only the L3 c

svn commit: r328270 - head/sys/net

2018-01-23 Thread Ryan Stone
Author: rstone Date: Tue Jan 23 03:15:35 2018 New Revision: 328270 URL: https://svnweb.freebsd.org/changeset/base/328270 Log: Invalidate inpcb LLE cache if cached route is invalidated When the inpcb route cache is invalidated after a change to the routing tables, we need to invalidate the

svn commit: r328272 - head/sys/net

2018-01-23 Thread Ryan Stone
Author: rstone Date: Tue Jan 23 03:15:44 2018 New Revision: 328272 URL: https://svnweb.freebsd.org/changeset/base/328272 Log: Increment the route table gen count after a modify Increment the route table generation count after modifying a route. This signals back to TCP connections that t

svn commit: r307680 - in head/tools/tools: . git

2016-10-20 Thread Ryan Stone
git Thu Oct 20 18:23:44 2016(r307680) @@ -0,0 +1,214 @@ +#!/bin/sh +# +# Copyright (c) 2015 Ryan Stone. All rights reserved. +# +# Redistribution and use in source and binary forms, with or without +# modification, are permitted provided that the following conditions +# are met: +# 1. Redistributions

svn commit: r307681 - head/tools/tools/git

2016-10-20 Thread Ryan Stone
Author: rstone Date: Thu Oct 20 18:28:05 2016 New Revision: 307681 URL: https://svnweb.freebsd.org/changeset/base/307681 Log: Set the executable bit on arcgit and importgit Make it possible to run these scripts directly out of svn by setting the executable property on them. Modified: Dir

svn commit: r307887 - head/sys/netinet

2016-10-24 Thread Ryan Stone
Author: rstone Date: Mon Oct 24 22:11:33 2016 New Revision: 307887 URL: https://svnweb.freebsd.org/changeset/base/307887 Log: Fix ip_output() on point-to-point links In r304435, ip_output() was changed to use the result of the route lookup to decide whether the outgoing packet was a broad

svn commit: r308562 - head/tools/tools/git

2016-11-11 Thread Ryan Stone
Author: rstone Date: Fri Nov 11 23:07:31 2016 New Revision: 308562 URL: https://svnweb.freebsd.org/changeset/base/308562 Log: Fix git tools when run against a worktree In a git worktree, the gitdir is in an entirely different location. In arcgit, use git rev-parse --git-dir to get the cor

svn commit: r308580 - head/sys/net

2016-11-12 Thread Ryan Stone
Author: rstone Date: Sat Nov 12 19:03:23 2016 New Revision: 308580 URL: https://svnweb.freebsd.org/changeset/base/308580 Log: Don't read if_counters with if_addr_lock held Calling into an ifnet implementation with the if_addr_lock already held can cause a LOR and potentially a deadlock, a

svn commit: r308790 - head/tools/sched

2016-11-17 Thread Ryan Stone
@@ +#!/bin/sh +# +# Copyright (c) 2012 Ryan Stone +# All rights reserved. +# +# Redistribution and use in source and binary forms, with or without +# modification, are permitted provided that the following conditions +# are met: +# 1. Redistributions of source code must retain the above copyright

Re: svn commit: r309194 - head/usr.sbin/syslogd

2016-11-27 Thread Ryan Stone
On Sat, Nov 26, 2016 at 10:50 AM, Baptiste Daroussin wrote: > Author: bapt > Date: Sat Nov 26 15:49:59 2016 > New Revision: 309194 > URL: https://svnweb.freebsd.org/changeset/base/309194 > > Log: > initialize *nextp which could be left uninitialized in case the > configuration > file cannot b

Re: svn commit: r309194 - head/usr.sbin/syslogd

2016-11-27 Thread Ryan Stone
> > There is something very wrong in the code here. nextp is never > initialized, so obviously we can't access *nextp. I'm surprised that this > code can even compile with -Werror. I'd fix it but it'd not clear to me > what nextp is intended to do. > Apologies for the noise; I didn't see r30921

svn commit: r309372 - head/sys/sys

2016-12-01 Thread Ryan Stone
Author: rstone Date: Thu Dec 1 21:08:42 2016 New Revision: 309372 URL: https://svnweb.freebsd.org/changeset/base/309372 Log: Fix a false positive in a buf_ring assert buf_ring contains an assert that checks whether an item being enqueued already exists on the ring. There is a subtle bug

svn commit: r309414 - head/sys/sys

2016-12-02 Thread Ryan Stone
Author: rstone Date: Fri Dec 2 15:38:34 2016 New Revision: 309414 URL: https://svnweb.freebsd.org/changeset/base/309414 Log: Revert r309372 The bug intended to be fixed by r309372 was already addressed by r296178, so revert my change. Reported by: seph Modified: head/sys/sys/buf

svn commit: r353938 - head/sys/compat/linuxkpi/common/src

2019-10-23 Thread Ryan Stone
Author: rstone Date: Wed Oct 23 17:20:20 2019 New Revision: 353938 URL: https://svnweb.freebsd.org/changeset/base/353938 Log: Add missing M_NOWAIT flag The LinuxKPI linux_dma code calls PCTRIE_INSERT with a mutex held, but does not set M_NOWAIT when allocating nodes, leading to a potent

Re: svn commit: r352585 - head/sys/kern

2019-09-22 Thread Ryan Stone
Thanks! On Sat, Sep 21, 2019 at 4:03 PM Konstantin Belousov wrote: > > Author: kib > Date: Sat Sep 21 20:03:17 2019 > New Revision: 352585 > URL: https://svnweb.freebsd.org/changeset/base/352585 > > Log: > kern.elf{32,64}.pie_base sysctl: enforce page alignment. > > Requested by: rstone > S

Re: svn commit: r352707 - in head/sys: conf kern net sys

2019-09-26 Thread Ryan Stone
We also shouldn't have ifdef's that change the size of a kernel structure that's part of the KBI. Isn't struct epoch_tracker part of the KBI? On Thu, Sep 26, 2019 at 12:46 PM Warner Losh wrote: > > But we shouldn't be including opt_foo.h files in sys/*.h files. That's the > root cause of troubl

Re: svn commit: r352778 - in head/sys: conf sys

2019-09-26 Thread Ryan Stone
Is this enough? Won't out-of-tree modules get compiled without EPOCH_TRACE set? If such a module is loaded on a kernel with EPOCH_TRACE set then the module will call epoch_enter_preempt() with a epoch_tracker that is too small and have its stack corrupted, won't it? On Thu, Sep 26, 2019 at 5:12

svn commit: r352926 - head/sys/conf

2019-10-01 Thread Ryan Stone
Author: rstone Date: Tue Oct 1 13:36:01 2019 New Revision: 352926 URL: https://svnweb.freebsd.org/changeset/base/352926 Log: Clean up duplicate entries in sys/conf/files Reviewed by: imp Modified: head/sys/conf/files Modified: head/sys/conf/files ==

Re: svn commit: r322272 - head/sys/compat/linuxkpi/common/src

2021-01-06 Thread Ryan Stone
On Tue, Aug 8, 2017 at 3:36 PM Alexander Motin wrote: > > Author: mav > Date: Tue Aug 8 19:36:34 2017 > New Revision: 322272 > URL: https://svnweb.freebsd.org/changeset/base/322272 > > Log: > Fix few issues of LinuxKPI workqueue. > > LinuxKPI workqueue wrappers reported "successful" cancellat

svn commit: r356444 - head/libexec/rtld-elf

2020-01-07 Thread Ryan Stone
Author: rstone Date: Tue Jan 7 16:03:11 2020 New Revision: 356444 URL: https://svnweb.freebsd.org/changeset/base/356444 Log: rtld: Fix segfault in direct exec mode When rtld is directly executed with arguments, it has to move the program arguments, environment and elf aux data up a few s

Re: svn commit: r357051 - head/sys/dev/bge

2020-01-23 Thread Ryan Stone
What is a driver's responsibility now for entering/leaving the net epoch now? ___ svn-src-head@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Re: svn commit: r357051 - head/sys/dev/bge

2020-01-23 Thread Ryan Stone
On Thu, Jan 23, 2020 at 6:05 PM Gleb Smirnoff wrote: > > On Thu, Jan 23, 2020 at 02:17:33PM -0500, Ryan Stone wrote: > R> What is a driver's responsibility now for entering/leaving the net epoch > now? > > For drivers that are 'special', entering the net e

Re: svn commit: r357051 - head/sys/dev/bge

2020-01-23 Thread Ryan Stone
On Thu, Jan 23, 2020 at 8:25 PM Gleb Smirnoff wrote: > Because at interrupt level we can batch multiple packets in a single epoch. > This speeds up unfiltered packet forwarding performance by 5%. > > With driver level pfil hooks I would claim even more improvement, because > before > the change w

Re: svn commit: r360849 - in head: share/man/man9 sys/kern

2020-05-09 Thread Ryan Stone
On Sat, May 9, 2020 at 11:56 AM Ed Maste wrote: > > Author: emaste > Date: Sat May 9 15:56:02 2020 > New Revision: 360849 > URL: https://svnweb.freebsd.org/changeset/base/360849 > > Log: > remove %n support from printf(9) Should we put a KASSERT in to catch if new code tries to use a %n flag (

Re: svn commit: r321476 - head/sys/dev/ixgbe

2017-11-17 Thread Ryan Stone
On Tue, Jul 25, 2017 at 10:38 AM, Sean Bruno wrote: > Author: sbruno > Date: Tue Jul 25 14:38:30 2017 > New Revision: 321476 > URL: https://svnweb.freebsd.org/changeset/base/321476 > > Log: > Drop ixgbe RX lock during TCP_LRO processing. This eliminates a "storm" > of LOR detection and a bit

Re: svn commit: r321477 - head/sys/net

2017-11-17 Thread Ryan Stone
On Tue, Jul 25, 2017 at 10:41 AM, Sean Bruno wrote: > Author: sbruno > Date: Tue Jul 25 14:41:50 2017 > New Revision: 321477 > URL: https://svnweb.freebsd.org/changeset/base/321477 > > Log: > Don't hold the RM lock during lagg_proto_addport() to avoid an LOR. Can lagg_proto_addport() really be

svn commit: r219377 - head/lib/libc/stdlib

2011-03-07 Thread Ryan Stone
Author: rstone Date: Mon Mar 7 15:19:17 2011 New Revision: 219377 URL: http://svn.freebsd.org/changeset/base/219377 Log: Correct a typo in the malloc(3) manpage. Malloc options are set in the MALLOC_OPTIONS environment variable, not JEMALLOC_OPTIONS. Reviewed by: jasone Approved by:

svn commit: r220227 - head/sys/tools

2011-03-31 Thread Ryan Stone
Author: rstone Date: Thu Mar 31 21:33:33 2011 New Revision: 220227 URL: http://svn.freebsd.org/changeset/base/220227 Log: GNU awk does not output escaped newlines in multi-line printc statements. This leads to compile errors when trying to compile firmware(9) stubs created with gawk, as mult

svn commit: r220453 - in head/sys: amd64/amd64 i386/i386

2011-04-08 Thread Ryan Stone
Author: rstone Date: Fri Apr 8 14:39:41 2011 New Revision: 220453 URL: http://svn.freebsd.org/changeset/base/220453 Log: Add tunables that mirror the functionality of sysctls machdep.panic_on_nmi and machdep.kdb_on_nmi. Approved by: emaste (mentor) MFC after:1 week Modified: he

svn commit: r220888 - head/lib/libthr/thread

2011-04-20 Thread Ryan Stone
Author: rstone Date: Wed Apr 20 14:19:34 2011 New Revision: 220888 URL: http://svn.freebsd.org/changeset/base/220888 Log: r179417 introduced a bug into pthread_once(). Previously pthread_once() used a global pthread_mutex_t for synchronization. r179417 replaced that with an implementation

svn commit: r221081 - head/sys/kern

2011-04-26 Thread Ryan Stone
Author: rstone Date: Tue Apr 26 20:34:30 2011 New Revision: 221081 URL: http://svn.freebsd.org/changeset/base/221081 Log: If the 4BSD scheduler tries to schedule a thread that has been pinned or bound to an AP before SMP has started, the system will panic when we try to touch per-CPU state f

svn commit: r206945 - head/share/misc

2010-04-20 Thread Ryan Stone
;Rui paulo\nrpa...@freebsd.org\n2007/09/25"] rrs [label="Randall R stewart\n...@freebsd.org\n2007/02/08"] rse [label="Ralf S. engelschall\n...@freebsd.org\n1997/07/31"] +rstone [label="Ryan stone\nrst...@freebsd.org\n2010/04/19"] ru [label="Ruslan erm

Re: svn commit: r206945 - head/share/misc

2010-04-20 Thread Ryan Stone
Sorry, I forgot the following: Approved by: emaste (mentor) and jkoshy (mentor) I'm looking into why svn wasn't using the default checkin template for me. On Tue, Apr 20, 2010 at 6:43 PM, Ryan Stone wrote: > Author: rstone > Date: Tue Apr 20 22:43:53 2010 > New Revision:

svn commit: r207482 - head/lib/libpmc

2010-05-01 Thread Ryan Stone
Author: rstone Date: Sat May 1 21:59:06 2010 New Revision: 207482 URL: http://svn.freebsd.org/changeset/base/207482 Log: When configuring hwpmc to use the EXT_SNOOP event, only send a default cachestate qualifier on the Atom processor. Other Intel processors do not accept a cachestate qualif

svn commit: r207484 - head/sys/dev/hwpmc

2010-05-01 Thread Ryan Stone
Author: rstone Date: Sat May 1 22:04:58 2010 New Revision: 207484 URL: http://svn.freebsd.org/changeset/base/207484 Log: When configuring a system-wide couting PMC, hwpmc was incorrectly logging process mappings for that PMC. Nothing ever reads pmc logs out of a counting PMC, so the log buff

Re: svn commit: r223917 - head/etc/rc.d

2011-07-12 Thread Ryan Stone
I can confirm that on a 8.2-RELEASE derived system, the loader is setting module_path correctly: (TPC-F4-42:wheel)# cat /boot/loader.conf.local kernel="STOCK" module_path="/boot/kernel;/boot/modules;/modules" (TPC-F4-42:wheel)# sysctl kern.module_path kern.module_path: /boot/STOCK;/boot/kernel;/b

svn commit: r224150 - head/sbin/fdisk

2011-07-17 Thread Ryan Stone
Author: rstone Date: Sun Jul 17 21:08:16 2011 New Revision: 224150 URL: http://svn.freebsd.org/changeset/base/224150 Log: The MBR uses a 32-bit unsigned integer to store the size of a slice, but fdisk(1) internally uses a signed int. Should a user attempt to specify a slice containing more

svn commit: r224156 - head/sys/kern

2011-07-17 Thread Ryan Stone
Author: rstone Date: Sun Jul 17 21:53:42 2011 New Revision: 224156 URL: http://svn.freebsd.org/changeset/base/224156 Log: Fix a LOR between hwpmc and the kernel linker. When a system-wide sampling mode PMC is allocated, hwpmc calls linker_hwpmc_list_objects() while already holding an exclus

Re: svn commit: r224150 - head/sbin/fdisk

2011-07-17 Thread Ryan Stone
On Sun, Jul 17, 2011 at 7:09 PM, Bruce Evans wrote: > There was no need to further break the style. Ack. Should have caught that. Will fix. >> >> @@ -990,7 +990,7 @@ parse_config_line(char *line, CMD *comma >>            if (isalpha(*cp)) >>                command->args[command->n_args].argtyp

svn commit: r212281 - head/sys/vm

2010-09-06 Thread Ryan Stone
Author: rstone Date: Tue Sep 7 00:23:45 2010 New Revision: 212281 URL: http://svn.freebsd.org/changeset/base/212281 Log: In munmap() downgrade the vm_map_lock to a read lock before taking a read lock on the pmc-sx lock. This prevents a deadlock with pmc_log_process_mappings, which has an e

svn commit: r212282 - head/sys/vm

2010-09-06 Thread Ryan Stone
Author: rstone Date: Tue Sep 7 02:51:11 2010 New Revision: 212282 URL: http://svn.freebsd.org/changeset/base/212282 Log: Fix a typo in r212281. uintptr -> uintptr_t Pointy hat to: rstone Approved by:emaste (mentor) MFC after: 2 weeks Modified: head/sys/vm/vm_mmap.c Mo

Re: svn commit: r212281 - head/sys/vm

2010-09-06 Thread Ryan Stone
On Mon, Sep 6, 2010 at 8:23 PM, Ryan Stone wrote: > +       if (pkm.pm_address != (uintptr) NULL) I have no idea how this snuck past me. I must have deleted some characters after building and testing this. I'll fix it as soon as I can track down one of my mentors, but if somebody want

svn commit: r215474 - head/usr.bin/netstat

2010-11-18 Thread Ryan Stone
Author: rstone Date: Thu Nov 18 23:46:55 2010 New Revision: 215474 URL: http://svn.freebsd.org/changeset/base/215474 Log: When netstat was run with -i/-I and -w1 to produce running counters, the idrop field printed an absolute value rather than the delta from the last value Approved by:

svn commit: r215507 - head/sbin/camcontrol

2010-11-18 Thread Ryan Stone
Author: rstone Date: Fri Nov 19 03:47:10 2010 New Revision: 215507 URL: http://svn.freebsd.org/changeset/base/215507 Log: When doing a camcontrol rescan all or a camcontrol reset all, use the wildcard path id for enumerating the available busses. Previously camcontrol was implicitly passing

Re: svn commit: r215507 - head/sbin/camcontrol

2010-11-19 Thread Ryan Stone
I asked about this on freebsd-scsi and CAM_BUS_WILDCARD was what was suggested to me. I'm happy to make the change if the other way is correct. ___ svn-src-head@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscrib

Re: svn commit: r222853 - in head: . sys/amd64/amd64 sys/amd64/include sys/i386/i386 sys/i386/include sys/pc98/pc98

2011-08-11 Thread Ryan Stone
On Wed, Jun 8, 2011 at 4:12 AM, Andriy Gapon wrote: > Author: avg > Date: Wed Jun  8 08:12:15 2011 > New Revision: 222853 > URL: http://svn.freebsd.org/changeset/base/222853 > > Log: >  remove code for dynamic offlining/onlining of CPUs on x86 > >  The code has definitely been broken for SCHED_ULE

svn commit: r225640 - head/sys/dev/e1000

2011-09-17 Thread Ryan Stone
Author: rstone Date: Sat Sep 17 13:48:09 2011 New Revision: 225640 URL: http://svn.freebsd.org/changeset/base/225640 Log: Clear transmit checksum offload context state upon lem(4) interface initialization. Prior to this change packets may be transmitted with an incorrect checksum. Em(4

svn commit: r227290 - in head/sys: amd64/amd64 amd64/include i386/i386 i386/include

2011-11-06 Thread Ryan Stone
Author: rstone Date: Mon Nov 7 01:53:25 2011 New Revision: 227290 URL: http://svn.freebsd.org/changeset/base/227290 Log: Fix the DTrace pid return trap interrupt vector. Previously we were using 31, but that vector is reserved. Without this fix, running dtrace -p would either cause the

svn commit: r227291 - head/sys/cddl/contrib/opensolaris/uts/intel/dtrace

2011-11-06 Thread Ryan Stone
Author: rstone Date: Mon Nov 7 01:55:58 2011 New Revision: 227291 URL: http://svn.freebsd.org/changeset/base/227291 Log: Replace fasttrap_copyout() with uwrite(). FreeBSD copyout() is not able to write to the .text section of a process. Obtained from:rpaulo MFC after:3 day

svn commit: r227342 - head/sys/kern

2011-11-08 Thread Ryan Stone
Author: rstone Date: Tue Nov 8 15:17:54 2011 New Revision: 227342 URL: http://svn.freebsd.org/changeset/base/227342 Log: The in-kernel CTF parser caches the result of its first attempt to parse CTF data from a module. On subsequent attempts to retrieve CTF data for a module, return an erro

svn commit: r227429 - head/usr.sbin/config

2011-11-10 Thread Ryan Stone
Author: rstone Date: Thu Nov 10 21:07:14 2011 New Revision: 227429 URL: http://svn.freebsd.org/changeset/base/227429 Log: The generated Makefile for the kernel was not running ctfconvert on object files corresponding to source files that had the compile-with option set in conf/files. This m

svn commit: r227430 - head/sys/cddl/dev/dtrace/i386

2011-11-10 Thread Ryan Stone
Author: rstone Date: Thu Nov 10 22:03:35 2011 New Revision: 227430 URL: http://svn.freebsd.org/changeset/base/227430 Log: On i386, fbt probes are implemented by writing an invalid opcode over certain instructions in a function prologue or epilogue. DTrace has a hook into the invalid opcode

svn commit: r227441 - in head/sys: amd64/linux32 cddl/dev/systrace compat/freebsd32 i386/linux kern

2011-11-10 Thread Ryan Stone
Author: rstone Date: Fri Nov 11 03:49:42 2011 New Revision: 227441 URL: http://svn.freebsd.org/changeset/base/227441 Log: Correct the types of the arguments to return probes of the syscall provider. Previously we were erroneously supplying the argument types of the corresponding entry probe

Re: svn commit: r346386 - in head/sys: dev/bge dev/pci dev/twa x86/iommu

2019-04-25 Thread Ryan Stone
This change makes me *very* uncomfortable. It was originally brought in due to issues with Adaptec RAID cards using the aac(9) driver. The symptoms of the bug included silent corruption of data as it was written to disk. Are we sure that this change is a good idea, given how catastrophic it is w

Re: svn commit: r346386 - in head/sys: dev/bge dev/pci dev/twa x86/iommu

2019-04-25 Thread Ryan Stone
Linux handle the issue? On Thu, Apr 25, 2019 at 3:17 PM Ryan Stone wrote: > > This change makes me *very* uncomfortable. It was originally brought > in due to issues with Adaptec RAID cards using the aac(9) driver. The > symptoms of the bug included silent corruption of data as it was

Re: svn commit: r346386 - in head/sys: dev/bge dev/pci dev/twa x86/iommu

2019-04-25 Thread Ryan Stone
to be an IRC discussion on 2/28/12 that resulted in revision > r232267 > as a quick MFC'able fix, but I don't have a log of that conversation. :( I > couldn't find anything in e-mail either that was definitive for why this > might have > been inherent in PCI-e vs

svn commit: r316527 - head/sys/netinet

2017-04-05 Thread Ryan Stone
Author: rstone Date: Wed Apr 5 16:57:13 2017 New Revision: 316527 URL: https://svnweb.freebsd.org/changeset/base/316527 Log: Revert the optimization from r304436 r304436 attempted to optimize the handling of incoming UDP packet by only making an expensive call to in_broadcast() if the mb

Re: svn commit: r317755 - head/sbin/ifconfig

2017-05-03 Thread Ryan Stone
On Wed, May 3, 2017 at 1:21 PM, Alan Somers wrote: > Author: asomers > Date: Wed May 3 17:21:01 2017 > New Revision: 317755 > URL: https://svnweb.freebsd.org/changeset/base/317755 > > Log: > Various Coverity fixes in ifconfig(8) > > * Exit early if kldload(2) fails (1011259). This is the onl

Re: svn commit: r317755 - head/sbin/ifconfig

2017-05-03 Thread Ryan Stone
On Wed, May 3, 2017 at 1:39 PM, Ryan Stone wrote: > > > On Wed, May 3, 2017 at 1:21 PM, Alan Somers wrote: > >> Author: asomers >> Date: Wed May 3 17:21:01 2017 >> New Revision: 317755 >> URL: https://svnweb.freebsd.org/changeset/base/317755 >> >>

svn commit: r339185 - head/sys/netinet

2018-10-04 Thread Ryan Stone
Author: rstone Date: Thu Oct 4 22:03:58 2018 New Revision: 339185 URL: https://svnweb.freebsd.org/changeset/base/339185 Log: Hold a write lock across udp_notify() With the new route cache feature udp_notify() will modify the inp when it needs to invalidate the route cache. Ensure that w

svn commit: r329743 - in head: sbin/route sys/net

2018-02-21 Thread Ryan Stone
Author: rstone Date: Wed Feb 21 19:13:23 2018 New Revision: 329743 URL: https://svnweb.freebsd.org/changeset/base/329743 Log: Allow route change requests to not specify the gateway. Only require a gateway to be specified on a route add request. On a route change request that does not spe

svn commit: r329744 - head/sbin/route

2018-02-21 Thread Ryan Stone
Author: rstone Date: Wed Feb 21 19:13:27 2018 New Revision: 329744 URL: https://svnweb.freebsd.org/changeset/base/329744 Log: Fix route manpage to show correct flush syntax The current route(8) manpage shows that "flush" is an argument to the optional -n flag, rather than a separate subco

svn commit: r313646 - head/sys/netinet

2017-02-11 Thread Ryan Stone
Author: rstone Date: Sat Feb 11 17:05:08 2017 New Revision: 313646 URL: https://svnweb.freebsd.org/changeset/base/313646 Log: Don't zero out srtt after excess retransmits If the TCP stack has retransmitted more than 1/4 of the total number of retransmits before a connection drop, it decid

svn commit: r313814 - head/sys/kern

2017-02-16 Thread Ryan Stone
Author: rstone Date: Thu Feb 16 19:41:13 2017 New Revision: 313814 URL: https://svnweb.freebsd.org/changeset/base/313814 Log: Check for preemption after lowering a thread's priority When a high-priority thread is waiting for a mutex held by a low-priority thread, it temporarily lends its

svn commit: r313816 - head/sys/kern

2017-02-16 Thread Ryan Stone
Author: rstone Date: Thu Feb 16 20:06:21 2017 New Revision: 313816 URL: https://svnweb.freebsd.org/changeset/base/313816 Log: Fix a typo in my previous commit Somehow in the late stages of testing my sched_ule patch, a character was accidentally deleted from the file. Correct this.

Re: svn commit: r313814 - head/sys/kern

2017-02-16 Thread Ryan Stone
Sorry about that. It's fixed in r313816. On Thu, Feb 16, 2017 at 3:31 PM, Cy Schubert wrote: > In message <201702161941.v1gjfdop087...@repo.freebsd.org>, Ryan Stone > writes: > > Author: rstone > > Date: Thu Feb 16 19:41:13 2017 > > New Revision: 313814

svn commit: r313824 - head/sys/kern

2017-02-16 Thread Ryan Stone
Author: rstone Date: Thu Feb 16 21:18:31 2017 New Revision: 313824 URL: https://svnweb.freebsd.org/changeset/base/313824 Log: Revert r313814 and r313816 Something evidently got mangled in my git tree in between testing and review, as an old and broken version of the patch was apparently s

Re: svn commit: r313878 - head/sys/kern

2017-02-21 Thread Ryan Stone
On Tue, Feb 21, 2017 at 10:07 AM, Pedro Giffuni wrote: > Good point: it doesn't. > > The change gets ignored but it doesn't break the converter. At least not > immediately, the github converter in AOO breaks frequently but it is > probably unrelated. > It wouldn't "break" the converter but it wo

Re: svn commit: r311849 - in head: . sys/amd64/conf sys/arm64/conf sys/conf sys/dev/e1000 sys/i386/conf sys/mips/conf sys/modules sys/modules/em sys/modules/igb sys/powerpc/conf

2017-03-10 Thread Ryan Stone
There's also the issue that running "ifconfig igb0 blah" during startup will cause if_igb to be automatically loaded by ifconfig. I guess we could add a dummy if_igb.ko that just has a dependency on if_em.ko On Fri, Mar 10, 2017 at 1:13 PM, Warner Losh wrote: > On Fri, Mar 10, 2017 at 11:06 AM,

svn commit: r321939 - head/usr.bin/calendar/calendars

2017-08-02 Thread Ryan Stone
+374,7 @@ 10/26 Philip M. Gollucci born in Silver Spring, Maryland, United States, 1979 10/27 Takanori Watanabe born in Numazu, Shizuoka, Japan, 1972 10/31 Taras Korenko born in Cherkasy region, Ukraine, 1980 +11/03 Ryan Stone born in Ottawa, Ontario, Canada, 1985 11/05 M. Warner

svn commit: r323506 - head/usr.sbin/iovctl

2017-09-12 Thread Ryan Stone
Author: rstone Date: Tue Sep 12 21:12:04 2017 New Revision: 323506 URL: https://svnweb.freebsd.org/changeset/base/323506 Log: Fix incorrect error message in iovctl If the iovctl command was invoked with only the -C flag, the user would receive a message claiming that they needed to also s

Re: svn commit: r343525 - in head/sys/netinet: . tcp_stacks

2019-01-30 Thread Ryan Stone
On Mon, Jan 28, 2019 at 7:46 AM Michael Tuexen wrote: > > Author: tuexen > Date: Mon Jan 28 12:45:31 2019 > New Revision: 343525 > URL: https://svnweb.freebsd.org/changeset/base/343525 > > Log: > Fix the detection of ECN-setup SYN-ACK packets. > > RFC 3168 defines an ECN-setup SYN-ACK packet a

Re: svn commit: r251024 - in head: lib/msun lib/msun/ld128 lib/msun/ld80 lib/msun/src tools/regression/lib/msun

2013-05-27 Thread Ryan Stone
On Mon, May 27, 2013 at 1:23 PM, David Schultz wrote: > If someone were to write or import a good test framework, > get all the tests to use it, and put together a test tinderbox, that > would have a lot of impact. > > People are working on bringing ATF into FreeBSD: https://wiki.freebsd.org/Tes

svn commit: r252342 - head/sys/kern

2013-06-28 Thread Ryan Stone
Author: rstone Date: Fri Jun 28 15:55:30 2013 New Revision: 252342 URL: http://svnweb.freebsd.org/changeset/base/252342 Log: Correct a bug that prevented deadlkres from (almost) ever firing. deadlkres was using a reversed test to check whether ticks had rolled over. This meant that deadlk

svn commit: r263109 - head/sys/dev/puc

2014-03-13 Thread Ryan Stone
Author: rstone Date: Thu Mar 13 15:57:25 2014 New Revision: 263109 URL: http://svnweb.freebsd.org/changeset/base/263109 Log: Add MSI support to puc(9) Add support for MSI interrupts in the puc(9) driver. By default the driver will prefer MSI interrupts to legacy interrupts. A tunable,

svn commit: r264001 - in head/sys: conf dev/pci

2014-04-01 Thread Ryan Stone
Author: rstone Date: Tue Apr 1 14:49:25 2014 New Revision: 264001 URL: http://svnweb.freebsd.org/changeset/base/264001 Log: Add a method to get the PCI Routing ID for a device Reviewed by: kib Sponsored by: Sandvine, Inc Added: head/sys/dev/pci/pcib_support.c (contents, props chang

svn commit: r264002 - head/sys/x86/iommu

2014-04-01 Thread Ryan Stone
Author: rstone Date: Tue Apr 1 14:51:45 2014 New Revision: 264002 URL: http://svnweb.freebsd.org/changeset/base/264002 Log: Re-implement the DMAR I/O MMU code in terms of PCI RIDs Under the hood the VT-d spec is really implemented in terms of PCI RIDs instead of bus/slot/function, even t

svn commit: r264003 - in head/sys/amd64/vmm: amd intel io

2014-04-01 Thread Ryan Stone
Author: rstone Date: Tue Apr 1 14:54:43 2014 New Revision: 264003 URL: http://svnweb.freebsd.org/changeset/base/264003 Log: Re-write bhyve's I/O MMU handling in terms of PCI RIDs Reviewed by: neel Sponsored by: Sandvine Inc Modified: head/sys/amd64/vmm/amd/amdv.c head/sys/amd64/vmm

svn commit: r264006 - in head/sys: amd64/vmm/amd amd64/vmm/intel amd64/vmm/io conf dev/pci x86/iommu

2014-04-01 Thread Ryan Stone
Author: rstone Date: Tue Apr 1 15:06:03 2014 New Revision: 264006 URL: http://svnweb.freebsd.org/changeset/base/264006 Log: Revert PCI RID changes. My PCI RID changes somehow got intermixed with my PCI ARI patch when I committed it. I may have accidentally applied a patch to a non-clean

svn commit: r264007 - in head/sys: conf dev/pci

2014-04-01 Thread Ryan Stone
Author: rstone Date: Tue Apr 1 15:47:24 2014 New Revision: 264007 URL: http://svnweb.freebsd.org/changeset/base/264007 Log: Add a method to get the PCI RID for a device. Reviewed by: kib MFC after:2 months Sponsored by: Sandvine Inc. Added: head/sys/dev/pci/pcib_support.c (co

svn commit: r264008 - head/sys/x86/iommu

2014-04-01 Thread Ryan Stone
Author: rstone Date: Tue Apr 1 15:48:46 2014 New Revision: 264008 URL: http://svnweb.freebsd.org/changeset/base/264008 Log: Re-implement the DMAR I/O MMU code in terms of PCI RIDs Under the hood the VT-d spec is really implemented in terms of PCI RIDs instead of bus/slot/function, even t

svn commit: r264009 - in head/sys/amd64/vmm: amd intel io

2014-04-01 Thread Ryan Stone
Author: rstone Date: Tue Apr 1 15:54:03 2014 New Revision: 264009 URL: http://svnweb.freebsd.org/changeset/base/264009 Log: Re-write bhyve's I/O MMU handling in terms of PCI RID. Reviewed by: neel MFC after:2 months Sponsored by: Sandvine Inc. Modified: head/sys/amd64/vmm/amd/a

svn commit: r264011 - head/sys/dev/pci

2014-04-01 Thread Ryan Stone
Author: rstone Date: Tue Apr 1 16:02:02 2014 New Revision: 264011 URL: http://svnweb.freebsd.org/changeset/base/264011 Log: Add support for PCIe ARI PCIe Alternate RID Interpretation (ARI) is an optional feature that allows devices to have up to 256 different functions. It is implemen

svn commit: r264012 - head/usr.sbin/pciconf

2014-04-01 Thread Ryan Stone
Author: rstone Date: Tue Apr 1 16:03:52 2014 New Revision: 264012 URL: http://svnweb.freebsd.org/changeset/base/264012 Log: Print status of ARI capability in pciconf -c Teach pciconf how to print out the status (enabled/disabled) of the ARI capability on PCI Root Complexes and Downstream

svn commit: r264013 - head/sys/dev/pci

2014-04-01 Thread Ryan Stone
Author: rstone Date: Tue Apr 1 17:35:31 2014 New Revision: 264013 URL: http://svnweb.freebsd.org/changeset/base/264013 Log: Add missing copyright date. MFC after:2 months Modified: head/sys/dev/pci/pcib_support.c Modified: head/sys/dev/pci/pcib_support.c ===

svn commit: r264091 - head/sys/dev/pci

2014-04-03 Thread Ryan Stone
Author: rstone Date: Thu Apr 3 22:32:12 2014 New Revision: 264091 URL: http://svnweb.freebsd.org/changeset/base/264091 Log: Correct a PCI enumeration bug introduced in r264011 Ensure that first_func is set to 0 on every iteration of the PCI slot enumeration loop after the first. There i

Re: svn commit: r273112 - head/sys/dev/ixgbe

2014-11-06 Thread Ryan Stone
On Thu, Nov 6, 2014 at 12:21 PM, Adrian Chadd wrote: > Hm, are there any other hardware counters that we can use to see what > was dropped? On the 82599 and later you need to configure the RQSMR register to map queue pools to indices and then the QPRDC[i] register will contain the number of drops

Re: svn commit: r275422 - in head/sys: amd64/conf i386/conf pc98/conf powerpc/conf sparc64/conf

2014-12-03 Thread Ryan Stone
Why is DEADLKRES also excluded? It was designed to be safe to run in production without a noticeable perf hit. On Tue, Dec 2, 2014 at 2:55 PM, George V. Neville-Neil wrote: > Author: gnn > Date: Tue Dec 2 19:55:43 2014 > New Revision: 275422 > URL: https://svnweb.freebsd.org/changeset/base/2754

svn commit: r280957 - in head/sys: amd64/amd64 i386/i386 kern mips/mips powerpc/aim sparc64/sparc64 sys vm

2015-04-01 Thread Ryan Stone
Author: rstone Date: Wed Apr 1 12:42:26 2015 New Revision: 280957 URL: https://svnweb.freebsd.org/changeset/base/280957 Log: Fix integer truncation bug in malloc(9) A couple of internal functions used by malloc(9) and uma truncated a size_t down to an int. This could cause any number of

Re: svn commit: r280957 - in head/sys: amd64/amd64 i386/i386 kern mips/mips powerpc/aim sparc64/sparc64 sys vm

2015-04-01 Thread Ryan Stone
On Wed, Apr 1, 2015 at 11:10 AM, Alan Cox wrote: > On 04/01/2015 07:42, Ryan Stone wrote: > > Note to self: When this is MFCed, sparc64 needs the same fix. > > > > I suspect that you mean ia64 here, not sparc64. Yes? > Apparently. T

svn commit: r265107 - head/sys/dev/pci

2014-04-29 Thread Ryan Stone
Author: rstone Date: Tue Apr 29 20:49:47 2014 New Revision: 265107 URL: http://svnweb.freebsd.org/changeset/base/265107 Log: Be consistent with the whitespace in the rest of these files. X-MFC-With: r264007 Modified: head/sys/dev/pci/pci_if.m head/sys/dev/pci/pcib_if.m Modified: head/

svn commit: r266351 - head/lib/libnv

2014-05-17 Thread Ryan Stone
Author: rstone Date: Sat May 17 20:39:39 2014 New Revision: 266351 URL: http://svnweb.freebsd.org/changeset/base/266351 Log: Correct a typo. MFC after:1 week Modified: head/lib/libnv/nv.3 Modified: head/lib/libnv/nv.3 =

svn commit: r258572 - head/lib/libpmc

2013-11-25 Thread Ryan Stone
Author: rstone Date: Mon Nov 25 18:31:13 2013 New Revision: 258572 URL: http://svnweb.freebsd.org/changeset/base/258572 Log: pmc(3) does not document a dependency on but requires it, so include it explicitly from . MFC after:1 month Modified: head/lib/libpmc/pmc.h Modified: head

svn commit: r277352 - in head/usr.sbin: mountd rpc.lockd rpc.statd

2015-01-18 Thread Ryan Stone
Author: rstone Date: Mon Jan 19 00:33:32 2015 New Revision: 277352 URL: https://svnweb.freebsd.org/changeset/base/277352 Log: When mountd is creating sockets, it iterates over all addresses specified in the "hosts" array and eventually looks up the network address with getaddrinfo(). At one

svn commit: r277524 - in head/sys: dev/hwpmc sys

2015-01-21 Thread Ryan Stone
Author: rstone Date: Thu Jan 22 03:56:23 2015 New Revision: 277524 URL: https://svnweb.freebsd.org/changeset/base/277524 Log: style(9) cleanup Modified: head/sys/dev/hwpmc/hwpmc_core.c head/sys/dev/hwpmc/pmc_events.h head/sys/sys/pmc.h Modified: head/sys/dev/hwpmc/hwpmc_core.c ==

svn commit: r277649 - head/sys/vm

2015-01-24 Thread Ryan Stone
Author: rstone Date: Sat Jan 24 16:59:38 2015 New Revision: 277649 URL: https://svnweb.freebsd.org/changeset/base/277649 Log: vmspace_release() may sleep if the last reference is being released, so add a WITNESS_WARN() to catch cases where it is called with a non-sleepable lock held. MF

Re: svn commit: r277900 - head/sys/x86/x86

2015-01-29 Thread Ryan Stone
On Thu, Jan 29, 2015 at 3:45 PM, John Baldwin wrote: > Also, note that we always use the TSC as the cpu ticker, even if it is not the > timecounter. Thus, if C2+ is enabled on the systems, the kernel idle threads > will have an artificially low runtime since their idle time is not properly > acco

Re: svn commit: r279398 - in head/sys: dev/sfxge modules/sfxge

2015-02-28 Thread Ryan Stone
On Sat, Feb 28, 2015 at 2:01 PM, Andrew Rybchenko wrote: > +#if defined(INET) || defined(INET6) > +#error LRO > +#defineSFXGE_LRO 1 > +#endif Pretty sure you didn't mean the leave the #error in here ___ svn-src-head@freebsd.org mailing lis

  1   2   3   >