Re: svn commit: r214144 - head/sys/vm

[Ed Schouten]

Hi John,

* John Baldwin j...@freebsd.org, 20101021 19:29:
 + if (atomic_fetchadd_int(vm-vm_refcnt, -1) == 1)
   vmspace_dofree(vm);

Not that it's that useful, but maybe it would be good to use
refcount_release() here?

-- 
 Ed Schouten e...@80386.nl
 WWW: http://80386.nl/


pgpZWtA2gScwF.pgp
Description: PGP signature

Re: svn commit: r214144 - head/sys/vm

[John Baldwin]

On Thursday, October 21, 2010 2:19:21 pm Ed Schouten wrote:
 Hi John,
 
 * John Baldwin j...@freebsd.org, 20101021 19:29:
  +   if (atomic_fetchadd_int(vm-vm_refcnt, -1) == 1)
  vmspace_dofree(vm);
 
 Not that it's that useful, but maybe it would be good to use
 refcount_release() here?

Not in this case because the other places do not use the refcount API.  
Specifically, the code in vmspace_exit() is a bit tortuous.  I'd rather code 
only use the refcount API if it is going to always use it.

-- 
John Baldwin
___
svn-src-head@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to svn-src-head-unsubscr...@freebsd.org